D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18174

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-ruby

REVISION DETAIL
  https://phabricator.kde.org/D18174

AFFECTED FILES
  autotests/folding/highlight.rb.fold
  autotests/html/highlight.rb.html
  autotests/input/highlight.rb
  autotests/reference/highlight.rb.ref
  data/syntax/ruby.xml

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18164: Review KateGotoBar

[Christoph Cullmann]

cullmann added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in katedialogs.cpp:1130
> > you can either cumulatively add the delta values from events until the 
> > value of 120 is reached
> 
> I don't know what is unclear, it should be 120 not any other value.
> 
>   if (object == m_ModifiedUp) {
>   m_deltaUp += event->delta();
>   if (m_deltaUp >= 120) {
>   m_ModifiedUp->click();
>   }
> 
> and so on. If not do it right you can end up in partial value when it used 
> finer-resolution wheels and mishmash.

I think 120 would be better to use, as that is the value one should start to 
handle given the docs.
I would not use a static delta but just have the delta as member of the class.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
hase, michaelh, ngraham, bruns, demsking, sars, dhaumann

D18164: Review KateGotoBar

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> loh.tar wrote in katedialogs.cpp:1130
> > It should be 120,
> 
> Why? Have now read the doc, but without a new insight.
> 
> > also you can have 2 separate delta members
> 
> How and why?

> you can either cumulatively add the delta values from events until the value 
> of 120 is reached

I don't know what is unclear, it should be 120 not any other value.

  if (object == m_ModifiedUp) {
  m_deltaUp += event->delta();
  if (m_deltaUp >= 120) {
  m_ModifiedUp->click();
  }

and so on. If not do it right you can end up in partial value when it used 
finer-resolution wheels and mishmash.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18164: Review KateGotoBar

[loh tar]

loh.tar added a comment.


  I was about to move StatusBarButton into kateviewhelpers, so that this button 
can used elsewhere too, like here. But got stuck. However, I think such button 
would be handy. Perhaps also a  KateViewBarLayout. 
  Here shot regarding 'Change label text to be less redundant in conjunction 
with the "goto-button"' At least in German is that old text terrible.
  F6539614: 1547187451.png 

INLINE COMMENTS

> anthonyfieroni wrote in katedialogs.cpp:1130
> https://doc.qt.io/qt-5/qwheelevent.html#angleDelta
> It should be 120, also you can have 2 separate delta members

> It should be 120,

Why? Have now read the doc, but without a new insight.

> also you can have 2 separate delta members

How and why?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Aleix Pol Gonzalez]

apol added a comment.


  +1 to me too.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: apol, vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 10 Jan 2019 20:04:18 +
 Build duration:
57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestFailed: projectroot.autotests.kconfigcore_test_kconf_updateName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)

D18136: kconfig_compiler: delete the assignment operator and copy constructor

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:601faf2ad9d4: kconfig_compiler: delete the assignment 
operator and copy constructor (authored by aacid).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18136?vs=49108=49195#toc

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18136?vs=49108=49195

REVISION DETAIL
  https://phabricator.kde.org/D18136

AFFECTED FILES
  autotests/kconfig_compiler/test10.cpp.ref
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test5.cpp.ref
  autotests/kconfig_compiler/test8b.cpp.ref
  autotests/kconfig_compiler/test8c.cpp.ref
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_signal.cpp.ref
  src/kconfig_compiler/kconfig_compiler.cpp

To: aacid, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18135: KEmailSettings: Delete copy constructor and assignment operator

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:78da515c5deb: KEmailSettings: Delete copy constructor and 
assignment operator (authored by aacid).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18135?vs=49107=49192

REVISION DETAIL
  https://phabricator.kde.org/D18135

AFFECTED FILES
  src/core/kemailsettings.h

To: aacid, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 10 Jan 2019 19:44:58 +
 Build duration:
1 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestFailed: projectroot.autotests.kconfigcore_test_kconf_updateName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)

D18134: KEncodingProber: Delete copy constructor and assignment operator

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R270:d5ffc242950b: KEncodingProber: Delete copy constructor 
and assignment operator (authored by aacid).

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18134?vs=49105=49191

REVISION DETAIL
  https://phabricator.kde.org/D18134

AFFECTED FILES
  src/kencodingprober.h

To: aacid, vkrause
Cc: apol, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Volker Krause]

vkrause added a comment.


  IMHO a good idea, +1.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18136: kconfig_compiler: delete the assignment operator and copy constructor

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18136

To: aacid, vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18125: KateStatusBar: Add dictionary button

[loh tar]

loh.tar added a comment.


  I'm very much against such a label, and against the full name. 
  "UTF-8" has also no label and that's good. The only stuff where a description 
label is needed are these line/column/word hints. Without a label are you 
almost lost to know which is what.
  
  However, in some later change is planed to add a couple of options to 
customize the bar. So if someone insists on this label it will be then one 
option more. If
  Dominik's suggest is realized that the bar will become "smart to hide 
obsolete stuff when the space is scarce", I guess such a label will go as one 
of the first.
  
  As said, I like to shorten it even more and cut at least these "extra stuff".
  I have only a few dict installed, so any help is appreciated if there are 
other county codes possible than "xx_YY-". I like to modify it to prefer 
"YY" and fall back to "xx"
  
  - "en_GB-ize-w_accents" -> GB
  - "en-variant_0" -> en
  - "en" -> en
  
  
  
qDebug() << Sonnet::Speller().availableLanguages();

"de_AT", "de_BE", "de_CH", "de_DE", "de_LI", "de_LU", "en", "en-variant_0", 
"en-variant_1", "en-variant_2", "en-w_accents", "en-wo_accents", "en_AU", 
"en_AU-variant_0", "en_AU-variant_1", "en_AU-w_accents", 
"en_AU-wo_accents", 
"en_CA", "en_CA-variant_0", "en_CA-variant_1", "en_CA-w_accents", 
"en_CA-wo_accents", "en_GB", "en_GB-ise", "en_GB-ise-w_accents", 
"en_GB-ise-wo_accents", "en_GB-ize", "en_GB-ize-w_accents", 
"en_GB-ize-wo_accents", "en_GB-variant_0", "en_GB-variant_1", 
"en_GB-w_accents", 
"en_GB-wo_accents", "en_PH", "en_US", "en_US-large", "en_US-variant_0", 
"en_US-variant_1", "en_US-w_accents", "en_US-wo_accents", "he"

REVISION DETAIL
  https://phabricator.kde.org/D18125

To: loh.tar, #ktexteditor
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, bruns, demsking, cullmann, sars

D18134: KEncodingProber: Delete copy constructor and assignment operator

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R270 KCodecs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18134

To: aacid, vkrause
Cc: apol, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

[Nathaniel Graham]

ngraham added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18161

To: cfeck, #frameworks, #dolphin, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  They really help making the code better so it's good to have all applications 
getting those warnings

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18167

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: aacid
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/5/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 10 Jan 2019 19:26:08 +
 Build duration:
8 min 55 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.11/12/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 10 Jan 2019 19:26:08 +
 Build duration:
3 min 42 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 10 Jan 2019 19:26:08 +
 Build duration:
2 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D18137: delete copy constructor and assignment operator of some public classes

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:44b91ba50d2f: delete copy constructor and assignment 
operator of some public classes (authored by aacid).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18137?vs=49109=49186

REVISION DETAIL
  https://phabricator.kde.org/D18137

AFFECTED FILES
  src/lib/caching/kshareddatacache.h
  src/lib/util/kdelibs4configmigrator.h
  src/lib/util/kdelibs4migration.h

To: aacid, mpyne
Cc: mpyne, kde-frameworks-devel, michaelh, ngraham, bruns

D18137: delete copy constructor and assignment operator of some public classes

[Albert Astals Cid]

aacid added a comment.


  I did some grepping and didn't find anything obvious (which make sense since 
it would be crashy)

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18137

To: aacid, mpyne
Cc: mpyne, kde-frameworks-devel, michaelh, ngraham, bruns

D18164: Review KateGotoBar

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katedialogs.cpp:1130
> +// and with my mousepad was the experience also flawlessly
> +if (delta > 100) {
> +delta = 0;

https://doc.qt.io/qt-5/qwheelevent.html#angleDelta
It should be 120, also you can have 2 separate delta members

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18164: Review KateGotoBar

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Set minimum value of spin-box to 1
  - Don't force minimum width by buttons, see similar Bug 402904
  - Rename gotoRange -> m_gotoRange
  - Add modified_line_up/down buttons with mouse wheel support
  - Change label text to be less redundant in conjunction with the "goto-button"
  - Change QLabel to button, with an action to go to line number from 
clipboard. My first intend was to add a clear-button to the spin box (not so 
easy) because paste from clipboard needs an empty field. But then I had this 
idea which is much more handy.

TEST PLAN
  F6539214: 1547145791.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18164

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D10716: handle wrong password when using sudo which asks for another password

[Shubham]

shubham edited the summary of this revision.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added reviewers: KTextEditor, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D10716: handle wrong password when using sudo which asks for another password

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  In D10716#390699 , @jriddell wrote:
  
  > - set XDG_CONFIG_HOME to put kdesutestrc not in running users config dir
  
  
  What you want is `QStandardPaths::setTestModeEnabled(true);`.
  
  Some more general comments:
  
  - Autotests need to be conditional based on BUILD_TESTING
  - Is it necessary to write the mock su/sudo in python? That introduces a big 
and mostly unnecessary dependency on python.
  - By adding a new constructor to SuCommand which allows to specify the full 
path to su/sudo, testing would be much easier. It might be usable outside of 
the tests as well.
  - The testcases would be simpler if it used QTESTDATA and rows for the 
su/sudo and correct/incorrect password cases

INLINE COMMENTS

> kdesutest.cpp:3
> +#include 
> +#include <../src/suprocess.h>
> +#include 

Try to make `#include "suprocess.h"` work instead.

> kdesutest.cpp:13
> +#define ROOTPASSWORD "ilovekde"
> +#include "config-kdesutest.h"
> +

Should be above the defines.

> kdesutest.cpp:45
> +void sudoBadPassword() {
> +KSharedConfig::Ptr config = KSharedConfig::openConfig();
> +KConfigGroup group(config, "super-user-command");

The config modification should be split into a separate method.

> suprocess.cpp:34
>  
> +#include "../autotests/config-kdesutest.h"
> +

If autotests aren't built, this isn't available. AFAICT it's not necessary 
anyway.

> suprocess.cpp:44
>  QString superUserCommand;
> +bool testMode;
>  };

Not used anymore.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added a reviewer: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Otherwise the print preview dialog somehow gets the text color from the
  current default color scheme; also the user can't change the color scheme
  either from the print preview dialog or the "print" dialog launched from
  the preview dialog. All in all, this seems like a safe default.
  
  BUG: 391678
  FIXED-IN: 5.55.0

TEST PLAN
  - Change the default color scheme in kate to a dark one, e.g. Breeze dark
  - Open the print preview dialog, note that the text color is the one used in 
the breeze dark scheme, but the background color is still white
  
  Apply the diff, the print preview dialog will be using the Printing color 
scheme
  as expected.

REPOSITORY
  R39 KTextEditor

BRANCH
  print-preview-text-color

REVISION DETAIL
  https://phabricator.kde.org/D18163

AFFECTED FILES
  src/render/katerenderer.cpp

To: ahmadsamir
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18038: Fix semantics for ghns_exclude

[Nathaniel Graham]

ngraham added a comment.


  What is the test tool? Can you help a total n00b like me learn how to test 
KNewStuff patches like these?
  
  Also, the correct formatting is `CCBUG: 402888`. See 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18038

To: leinir, ronaldv, #kde_store, ngraham
Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, 
alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

[Christoph Feck]

cfeck created this revision.
cfeck added reviewers: Frameworks, Dolphin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cfeck requested review of this revision.

REVISION SUMMARY
  **[WIP/RFC] Please let me know if what I propose is sane**
  
  UNIX filenames can contain any bytes (except `\0` and `/`). Qt's 
`QFile::decodeName()` calls `QString::fromLocal8Bit()`, assuming that all 
filesystems use the system's locale encoding. For filenames that have been 
created with a different encoding, and have not yet been converted (e.g. using 
`convmv`), this creates non-reversible U+FFFD (REPLACEMENT CHARACTER) code 
points in the filenames.
  
  For example, some old-style archives might not contain any information about 
the encoding of the filenames, and even today archivers extract them without 
trying to convert to the locale's encoding.
  
  While full support for those filenames is not needed, Dolphin should at least 
be able to delete, rename, and move those files. Since all actual (local) file 
handling is done inside the `file` kioslave, patching Dolphin will not help.
  
  This code is a near verbatim copy of the code we had in kdelibs, written by 
Szókovács Róbert. Only minor adaptions to Qt5 were done. It decodes invalid 
bytes as U+10FExx from Plane 16 (Supplementary Private Use Area-B) to be able 
to encode them later.
  
  Dolphin could detect filenames with those characters, and either mark them 
(by color or overlay icon), or even automatically offer to rename them.
  
  CCBUG: 204768
  CCBUG: 165044

TEST PLAN
  touch "/tmp/test-"$'\377'".txt"
  dolphin /tmp
  
  Copying and deleting a test file worked with this code, failed without.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18161

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/file.cpp
  src/ioslaves/file/legacycodec.cpp
  src/ioslaves/file/legacycodec.h

To: cfeck, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17596

To: ngraham, #frameworks, #dolphin
Cc: cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, 
michaelh, ngraham, bruns

D17596: [KDirOperator] Allow renaming files from the context menu

[Nathaniel Graham]

ngraham added a comment.


  Sorry, I lost track of this after large changes were requested for the 
dependent patch D17595 . I'll try to get 
this in for 5.54.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17596

To: ngraham, #frameworks, #dolphin
Cc: cfeck, emateli, elvisangelaccio, markuss, dhaumann, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18125: KateStatusBar: Add dictionary button

[Nathaniel Graham]

ngraham added a comment.


  If we stay with `en_US`, I'd like to see a label so people know what it is. 
Otherwise, we should use the long name, because then it becomes obvious. So 
here are the two options I would approve of:
  
  - Dictionary: en_US v
  - American English v

REVISION DETAIL
  https://phabricator.kde.org/D18125

To: loh.tar, #ktexteditor
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, bruns, demsking, cullmann, sars

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Nathaniel Graham]

ngraham added a comment.


  In D17906#389914 , @mart wrote:
  
  > I wonder if it shouldn't be something in the future eventually part of the 
theme, I see things like menu font and toolbar font in fonts kcm as something 
completely obsolete, while those settings should be more about conventional 
typography (like normal font, heading font etc)
  
  
  +1 FWIW

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks, mart
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49175.
jriddell added a comment.


  - set XDG_CONFIG_HOME to put kdesutestrc not in running users config dir

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49173=49175

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49173.
jriddell added a comment.


  - write out path to kdesu_stub and su command from the tests to a config 
rather than setting it within the suprocess class, allows for other testing 
possibilities and binary relateability

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49164=49173

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

[Nathaniel Graham]

ngraham added a comment.


  BTW you still need to correct your `~/.gitconfig` file to have your real name 
and email address. :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17907

To: rooty, ngraham, #frameworks, #vdg, #plasma
Cc: cfeck, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17907: [KWidgetsAddons] Do not use light font styles for headings (3/3)

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:dc901a1f0b5f: [KWidgetsAddons] Do not use light font 
styles for headings (3/3) (authored by Krešimir Čohar kco...@gmail.com, 
committed by ngraham).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17907?vs=48502=49171

REVISION DETAIL
  https://phabricator.kde.org/D17907

AFFECTED FILES
  src/ktitlewidget.cpp

To: rooty, ngraham, #frameworks, #vdg, #plasma
Cc: cfeck, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/15/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 10 Jan 2019 16:14:51 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13319)18%
(1814/9840)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e5d392cb79f9: [kirigami] Do not use light font styles for 
headings (2/3) (authored by filipf, committed by ngraham).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17906?vs=48496=49168

REVISION DETAIL
  https://phabricator.kde.org/D17906

AFFECTED FILES
  src/controls/Heading.qml

To: filipf, ngraham, #plasma, #vdg, #frameworks, mart
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 10 Jan 2019 16:14:51 +
 Build duration:
4 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/5/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 10 Jan 2019 16:14:51 +
 Build duration:
4 min 20 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3602/13319)18%
(1813/9840)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
  

D17905: [frameworks] Do not use light font styles for headings (1/3)

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fdc912468785: [frameworks] Do not use light font styles 
for headings (1/3) (authored by filipf, committed by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17905?vs=48579=49167

REVISION DETAIL
  https://phabricator.kde.org/D17905

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/Heading.qml
  src/declarativeimports/plasmaextracomponents/qml/Title.qml

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: #frameworks, #plasma, #vdg, ngraham, abetts, kde-frameworks-devel, 
michaelh, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Nathaniel Graham]

ngraham added a comment.


  Yep, will do. We have other diffs for those.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks, mart
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D17528: Refactor SlaveInterface::calcSpeed

[David Edmundson]

davidedmundson added a comment.


  I opened a review for documentation purposes: 
https://phabricator.kde.org/D18158

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: davidedmundson, broulik, bruns, kde-frameworks-devel, michaelh, ngraham

D18158: Fix elapsed time check

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  To match the code it was refactored from it should be checking the code
  since the last time we checked calcSpeed, not since the job started.
  
  CCBUG: 402665

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18158

AFFECTED FILES
  src/core/slaveinterface.cpp

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> suprocess.cpp:124
> +if (d->testMode) {
> +args += QByteArray(CMAKE_RUNTIME_OUTPUT_DIRECTORY) + "/kdesu_stub";
> +} else {

This means the path to the build directory is hardcoded in the executable. That 
needs to be avoided to make builds fully reproducible 
(https://reproducible-builds.org/).

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49164.
jriddell added a comment.


  - in stub su and sudo use passed argument to find kdesu_stub and in suprocess 
pass local kdesu_stub for test mode

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49163=49164

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> davidedmundson wrote in slaveinterface.cpp:106
> That wasn't there in the old code because it has this guard:
> 
> const qint64 diff = currentTime - d->start_time;
> 
> (effectively calculating elapsed)
> 
> Then
> 
> if (diff - d->last_time >= 900) {
> 
> So we known first-last is non-zero
> 
> Should the new code be
> 
> https://phabricator.kde.org/P287 ?
> 
> It seemed to work for me.

Indeed that should be the code here.
The old code checked the elapsed time since last "calcSpeed()" call whereas the 
new code checks the elapsed time since the timer started.

> broulik wrote in slaveinterface.cpp:113
> We likely get a division by zero here for some reason

I doubt it will be zero here. `elapsed_time` stores elapsed time since the 
timer started so it will continue to grow (?) and the difference will always be 
> 0.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: davidedmundson, broulik, bruns, kde-frameworks-devel, michaelh, ngraham

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49163.
jriddell added a comment.


  - use locally built kdesu_stub

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49091=49163

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su.cmake
  autotests/sudo.cmake
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> broulik wrote in colorscope.h:134
> Complained with "QSharedPointer: cannot create a QSharedPointer from a 
> QObject-tracking QWeakPointer"

Seems odd.
And QSharedDataPointer? http://doc.qt.io/qt-5/qshareddatapointer.html
or std::shared_ptr.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18149

To: broulik, #plasma
Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> slaveinterface.cpp:106
> +const qint64 elapsed_time = d->elapsed_timer.elapsed();
> +if (elapsed_time >= 900) {
> +if (d->transfer_details.count() == max_count) {

That wasn't there in the old code because it has this guard:

const qint64 diff = currentTime - d->start_time;

(effectively calculating elapsed)

Then

if (diff - d->last_time >= 900) {

So we known first-last is non-zero

Should the new code be

https://phabricator.kde.org/P287 ?

It seemed to work for me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: davidedmundson, broulik, bruns, kde-frameworks-devel, michaelh, ngraham

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> apol wrote in colorscope.h:134
> How about using a QSharedPointer?

Complained with "QSharedPointer: cannot create a QSharedPointer from a 
QObject-tracking QWeakPointer"

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18149

To: broulik, #plasma
Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17528: Refactor SlaveInterface::calcSpeed

[Kai Uwe Broulik]

broulik reopened this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  We're getting some `SIGFPE` crash reports in this area: Bug 402665
  I failed to reproduce them, though. Best is probably to revert this patch 
because Frameworks release is imminent.

INLINE COMMENTS

> slaveinterface.cpp:113
> +const SlaveInterfacePrivate::TransferInfo last = {elapsed_time, 
> (d->filesize - d->offset)};
> +KIO::filesize_t lspeed = 1000 * (last.size - first.size) / 
> (last.time - first.time);
>  if (!lspeed) {

We likely get a division by zero here for some reason

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17528

To: chinmoyr, dfaure
Cc: broulik, bruns, kde-frameworks-devel, michaelh, ngraham

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> colorscope.h:134
> +
> +static Plasma::Theme *s_theme;
> +static int s_themeRefCount;

How about using a QSharedPointer?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18149

To: broulik, #plasma
Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> su:28
> +self.state = State.GOOD
> +call(["/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu_stub"])
> +exit(0)

That won't work anywhere else and requires that the binary is installed when 
running tests.

> sudo:28
> +self.state = State.GOOD
> +call(["/usr/lib/x86_64-linux-gnu/libexec/kf5/kdesu_stub"])
> +exit(0)

Same here.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

[Kai Uwe Broulik]

broulik added a comment.


  > Now in multi-thread environment will have problems especially on 
actualTheme(), no?
  
  `ColorScope` is QML-only and should be fine? Not sure about `Svg`, it never 
mentioned being thread-safe.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18149

To: broulik, #plasma
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

[Anthony Fieroni]

anthonyfieroni added a comment.


  Now in multi-thread environment will have problems especially on 
actualTheme(), no?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18149

To: broulik, #plasma
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17543: [Dialog] Don't alter mainItem's visibility

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b257029afc3b: [Dialog] Dont alter mainItems 
visibility (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17543?vs=47458=49147#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17543?vs=47458=49147

REVISION DETAIL
  https://phabricator.kde.org/D17543

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17542: Reset parentItem when mainItem changes

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f4bd4a613187: Reset parentItem when mainItem changes 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17542?vs=47457=49146

REVISION DETAIL
  https://phabricator.kde.org/D17542

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/14/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Thu, 10 Jan 2019 11:15:19 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13319)18%
(1814/9840)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/4/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 10 Jan 2019 11:15:19 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13319)18%
(1814/9840)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 10 Jan 2019 11:15:19 +
 Build duration:
2 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Marco Martin]

mart added a comment.


  so, if this is pushed, the same thing should happen at the same time to the 
corresponding plasma components

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks, mart
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D17542: Reset parentItem when mainItem changes

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  sometimes in the past i had problems about setting parentitem of an item to 
nullptr, due to all the scenegraph nodes of the item being destroyed and 
recreated...
  somewhere else to do something like that i did have a dummy qquickitem 
invisible and reparented stuff to that instead of nullptr
  
  this looks cleaner, so i would say go for it and if will cause problems, then 
go for the above workaround

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17542

To: broulik, #plasma, mart
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D17543: [Dialog] Don't alter mainItem's visibility

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17543

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17932: Improvements to completion

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  Hey there, sorry for the long delay. In general, I think your suggestions are 
very sane - most notably preferring exact case matches over fuzzy matches is a 
good thing to have!
  
  But I wonder: do we really need to make this configurable? Can't we just 
always do this? I.e. can you explain which models would have an insensitive 
exact match, and which ones have sensitive exact matches?
  
  Can you please submit the next patch iteration with context (I suggest you 
use `arc diff` for that)

INLINE COMMENTS

> katecompletionmodel.cpp:1554
>  
> -if(m_unimportant && !rhs.m_unimportant){
> +if (m_unimportant && !rhs.m_unimportant) {
>  return false;

unrelated whitespace changes should be fixed in separate commits

> katecompletionmodel.cpp:1575
> +
> +if( thisStartWithFilter && ! rhsStartsWithFilter ) {
> +return true;

here and below:remove space after `!`

> katecompletionmodel.cpp:1888
>  
> +QChar toLowerIfInsensitive(QChar c, Qt::CaseSensitivity caseSensitive) 
> +{

static or anon namespace

> katecompletionmodel.cpp:2026
>  
>  if (matchCompletion && match.length() == m_nameColumn.length()) {
> +if (model->matchCaseSensitivity() == Qt::CaseInsensitive &&

maybe simplify this to:

if (matchCompletion && m_nameColumn.startsWith(match, 
model->exactMatchCaseSensitivity())) {

  matchCompletion = PerfectMatch;
  m_haveExactMatch = true;

}

> katecompletionmodel.cpp:2029
> +model->exactMatchCaseSensitivity() == Qt::CaseSensitive &&
> +! m_nameColumn.startsWith(match, Qt::CaseSensitive)) {
> +return matchCompletion;

remove whitespace after !

> katecompletionmodel.h:394
> +Qt::CaseSensitivity m_matchCaseSensitivity = Qt::CaseInsensitive;
> +Qt::CaseSensitivity m_exactMatchCaseSensitivity = Qt::CaseInsensitive;  
> // Must be equal to or stricter than m_matchCaseSensitivity.
> +

should this comment be asserted in the setters or is it handled gracefully in 
the logic below?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17932

To: thomassc, #ktexteditor, #kdevelop, mwolff
Cc: mwolff, cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, head7, kfunk, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/13/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 10 Jan 2019 09:57:49 +
 Build duration:
5 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18149

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18148: Use HTTPS, if available, in links visible to users

[Grzegorz Szymaszek]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:b64681408d84: Use HTTPS, if available, in links visible to 
users (authored by gszymaszek).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18148?vs=49138=49140

REVISION DETAIL
  https://phabricator.kde.org/D18148

AFFECTED FILES
  src/document/katedocument.cpp
  src/utils/kateglobal.cpp

To: gszymaszek, #ktexteditor, dhaumann
Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Especially since the `Theme` isn't modified in any way but just used to read 
some data.
  While the `Private` part of `Theme` is already shared, creating a `Theme` 
instance still has some setup cost.

TEST PLAN
  Noticed in GammaRay there was a tonne of `Theme` objects.
  Just the usage in `Svg` alone accounted for 5ms startup time, and 
`ColorScope` is also widely used.
  After this patch there's merely 25 `Theme` objects being created.
  Wanted to use `QSharedPointer` for this but failed..
  Doesn't reduce refcount and cleanup when you assign a different theme using 
`Svg::setTheme` but this is hardly used anyway.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18149

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h
  src/plasma/private/svg_p.h
  src/plasma/svg.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18148: Use HTTPS, if available, in links visible to users

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  https-in-end-user-links (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18148

To: gszymaszek, #ktexteditor, dhaumann
Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible to users

[Grzegorz Szymaszek]

gszymaszek marked 2 inline comments as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18148

To: gszymaszek, #ktexteditor
Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible to users

[Grzegorz Szymaszek]

gszymaszek updated this revision to Diff 49138.
gszymaszek added a comment.


  Fixed two links to docs.kde.org

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18148?vs=49135=49138

BRANCH
  https-in-end-user-links (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18148

AFFECTED FILES
  src/document/katedocument.cpp
  src/utils/kateglobal.cpp

To: gszymaszek, #ktexteditor
Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible to users

[Burkhard Lück]

lueck added inline comments.

INLINE COMMENTS

> katedocument.cpp:4592
>  "Please replace with 
> 'remove-trailing-spaces modified;', see "
> -
> "http://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
> +
> "https://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
>  m_config->setRemoveSpaces(state ? 1 : 0);

dead link: The requested URL 
/stable5/en/applications/kate/config-variables.html was not found on this 
server.

This link works:
https://docs.kde.org/stable5/en/applications/katepart/config-variables.html#variable-remove-trailing-spaces

> katedocument.cpp:4597
>  "Please replace with 
> 'remove-trailing-spaces all;', see "
> -
> "http://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
> +
> "https://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
>  m_config->setRemoveSpaces(state ? 2 : 0);

dead link, see above

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18148

To: gszymaszek, #ktexteditor
Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann