D18475: Add AsciiDoc support

[Andreas Gratzer]

andreasgr added a comment.


  In D18475#400238 , @nibags wrote:
  
  > Hi!!
  >  Please, also add a test file in: "autotests/input/". To generate the files 
in "folding", "html" and "reference" use `make test` and 
`autotests/update-reference-data.sh`.
  >
  > I am not a reviewer, but I want to add some recommendations in relation to 
the itemData's:
  >
  > - On lines 467, 476 and 485 you use harded colors for the fonts. Ideally, 
don't use them, but use the default styles, since a better visualization is 
achieved in the different schemes: 
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
  > - On lines 469 & 471 you use background color, and on lines 466-467, 
473-474, 479-481 and 490 you use background color, but not font color. Try not 
to use background color if it's not necessary,  to get a better visualization 
in the different schemes. However, if you need background color, it also 
specifies the font color, to avoid readability problems in some color schemes 
(for example, the background color `_bg;` with `dsNormal` is not 
readable in dark schemes).
  
  
  Hi @nibags,
  
  many thanks for your feedback.
  
  I will see what I can do about the test file.
  
  Regarding colours, this was mostly done to make the highlighting look similar 
to the default output created by Asciidoctor.
  Your point about different schemes is a very valid one, though. I need to 
reconsider the style choices.
  
  Cheers

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18475

To: andreasgr, #framework_syntax_highlighting
Cc: nibags, kwrite-devel, kde-frameworks-devel, #framework_syntax_highlighting, 
bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/18/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 26 Jan 2019 04:31:17 +
 Build duration:
43 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18475: Add AsciiDoc support

[Nibaldo González]

nibags added a comment.


  Hi!!
  Please, also add a test file in: "autotests/input/". To generate the files in 
"folding", "html" and "reference" use `make test` and 
`autotests/update-reference-data.sh`.
  
  I am not a reviewer, but I want to add some recommendations in relation to 
the itemData's:
  
  - On lines 467, 476 and 485 you use harded colors for the fonts. Ideally, 
don't use them, but use the default styles, since a better visualization is 
achieved in the different schemes: 
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
  - On lines 469 & 471 you use background color, and on lines 466-467, 473-474, 
479-481 and 490 you use background color, but not font color. Try not to use 
background color if it's not necessary,  to get a better visualization in the 
different schemes. However, if you need background color, it also specifies the 
font color, to avoid readability problems in some color schemes (for example, 
the background color `_bg;` with `dsNormal` is not readable in dark 
schemes).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18475

To: andreasgr, #framework_syntax_highlighting
Cc: nibags, kwrite-devel, kde-frameworks-devel, #framework_syntax_highlighting, 
bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

[Krešimir Čohar]

rooty added a comment.


  In D18545#400222 , @rooty wrote:
  
  > In D18545#400220 , @filipf wrote:
  >
  > > Really nice, I think it fits in more with how edges are drawn elsewhere.
  > >
  > > Could you also add screenshots with Breeze Dark?
  >
  >
  > Sure thing. Added to test plan.
  
  
  Hmm, there doesn't seem to be much of a difference if any with Breeze dark, I 
wonder if that's because I haven't yet modified opaque/dialogs/background.svgz. 
Stay tuned :D

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

[Filip Fila]

filipf added a comment.


  Really nice, I think it fits in more with how edges are drawn elsewhere.
  
  Could you also add screenshots with Breeze Dark?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

[Krešimir Čohar]

rooty added a comment.


  In D18545#400214 , @ngraham wrote:
  
  > Wow, it's amazing how much nicer the After screenshot looks than the 
Before. Such a difference from a tiny change! +1
  
  
  Thanks! And thanks to Noah Davis for giving me a boost
  What do you think about the corner shadows though - too strong? Or... not an 
issue?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

[Nathaniel Graham]

ngraham added a comment.


  Wow, it's amazing how much nicer the After screenshot looks than the Before. 
Such a difference from a tiny change! +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

[Krešimir Čohar]

rooty edited the test plan for this revision.
rooty added reviewers: VDG, ngraham.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch aims to make the corners of the dialog/notification backgrounds 
(dialogs/background.svgz) more rounded and more in keeping
  with the Breeze window decoration theme.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18545

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18434: exiv2extractor: add support for bmp, gif, webp, tga

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D18434#400106 , @aacid wrote:
  
  > is it worth adding files to autotests/exiv2extractortest.cpp ?
  
  
  Shortly considered, but then I saw so far only a jpg file is tested, and 
thinking about it, the test checks that using libexiv2 works in principle, 
going across all the formats would rather test libexiv2 and not really add 
anything.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18434

To: kossebau, #baloo, #dolphin
Cc: aacid, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

[Albert Astals Cid]

El dilluns, 21 de gener de 2019, a les 6:46:32 CET, Ben Cooksley va escriure:
> Git commit f6c79ff4787148459aa91c17d683e4fd6a57c323 by Ben Cooksley.
> Committed on 21/01/2019 at 05:46.
> Pushed by bcooksley into branch 'master'.
> 
> Disable execution of tests for plasma-integration.
> This is necessary to ensure CI nodes do not become blocked due to hanging 
> tests withing plasma-integration.
> 
> Currently, plasma-integration has several tests that make use of KIO slaves 
> directly (skipping KLauncher).
> Unfortunately, they do not terminate the slaves prior to the conclusion of 
> the test, resulting in the kioslave processes being left around afterwards.
> This is a condition that CTest will not tolerate, leading to it waiting 
> indefinitely for these processes to exit - and in turn blocking all other 
> builds on the CI node in question.
> While this is not a major issue in the case of Linux builds, it can quickly 
> become a severe condition in the case of FreeBSD and Windows builds due to 
> those builders being fixed rather than dynamically allocated.
> 
> This class of issue (CTest waiting due to resident processes being left 
> behind) has been a major issue as of late and is quickly leading to the CI 
> system becoming unmaintainable due to the level of breakage.
> Should it be necessary to ensure the maintainability of the system, 
> withdrawal of execution of tests for all projects is an option currently 
> under consideration.

Stopping running the tests is never the solution.

We need to fix the tests.

And to fix the tests we need to be able to reproduce failures.

Is this error only happening on the CI? If so is there an easy way someone can 
reproduce the setup that happens in our CI?

If not we should be working on that. 

I understand your frustration when CI breaks, but I have seem that often the 
answer for such issues is "it works for me and i can't reproduce the CI 
problem".

So if we had a simple "run docker with this parameter and then run these 3 
scripts to reproduce the error" answer I'm sure more people would try to fix 
them. At least i might.

Cheers,
  Albert

> 
> CCMAIL: plasma-de...@kde.org
> CCMAIL: kde-frameworks-devel@kde.org
> CCMAIL: release-t...@kde.org
> CCMAIL: kdevelop-de...@kde.org
> CCMAIL: sysad...@kde.org
> 
> M  +2-0build-specs/Plasma/plasma-integration.yaml
> 
> https://invent.kde.org/sysadmin/ci-tooling/commit/f6c79ff4787148459aa91c17d683e4fd6a57c323
> 
> diff --git a/build-specs/Plasma/plasma-integration.yaml 
> b/build-specs/Plasma/plasma-integration.yaml
> index 3d39455..159546c 100644
> --- a/build-specs/Plasma/plasma-integration.yaml
> +++ b/build-specs/Plasma/plasma-integration.yaml
> @@ -1,5 +1,7 @@
>  kf5-qt5:
> +  run-tests: False
>force-inject-asan: True
>  
>  stable-kf5-qt5:
> +  run-tests: False
>force-inject-asan: True
> 

D18434: exiv2extractor: add support for bmp, gif, webp, tga

[Albert Astals Cid]

aacid added a comment.


  is it worth adding files to autotests/exiv2extractortest.cpp ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18434

To: kossebau, #baloo, #dolphin
Cc: aacid, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16913: Add the possibility to give focus to the KPluginSelector search field

[Thomas Surrel]

thsurrel updated this revision to Diff 50295.
thsurrel added a comment.


  Remove the timer

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16913?vs=45550=50295

BRANCH
  arc_focussearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16913

AFFECTED FILES
  src/kpluginselector.cpp
  src/kpluginselector.h

To: thsurrel, #frameworks
Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, 
bruns

D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files

[Jason Wilbee]

jwilbee updated this revision to Diff 50286.
jwilbee added a comment.


  Added requested changes to fallthrough context
  Incremented version number

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18509?vs=50212=50286

BRANCH
  kconfig-freeze-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18509

AFFECTED FILES
  data/syntax/kconfig.xml

To: jwilbee, #framework_syntax_highlighting, cullmann, dhaumann
Cc: nibags, shubham, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D18529: Rename Activities KCM icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:31e1b9977a47: Rename Activities KCM icon (authored by 
ndavis).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18529?vs=50273=50282#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18529?vs=50273=50282

REVISION DETAIL
  https://phabricator.kde.org/D18529

AFFECTED FILES
  icons-dark/preferences/32/preferences-activities.svg
  icons-dark/preferences/32/preferences-desktop-activities.svg
  icons/preferences/32/preferences-activities.svg
  icons/preferences/32/preferences-desktop-activities.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18088: FindGperf: in ecm_gperf_generate set SKIP_AUTOMOC for generated file

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ed985869924f: FindGperf: in ecm_gperf_generate set 
SKIP_AUTOMOC for generated file (authored by kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18088?vs=48942=50281

REVISION DETAIL
  https://phabricator.kde.org/D18088

AFFECTED FILES
  find-modules/FindGperf.cmake

To: kossebau, #frameworks, pino, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 added a comment.


  I have made some slight adjustments from the original KAlarm design, such as 
a shadow line at the bottom instead of orange, to better fir our style.
  Should I make those changes in the original icon as well?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-notification-bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18533

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-notification-bell.svg
  icons/preferences/32/preferences-desktop-notification-bell.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-activities (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18529

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

[Noah Davis]

ndavis added a dependent revision: D18532: Change icons for Activities 
dataengine and runner.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18529

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

[Noah Davis]

ndavis added a dependent revision: D18531: Change icon for Activities config.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18529

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

[Noah Davis]

ndavis added a dependent revision: D18530: Change Activities KCM icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18529

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18529: Rename Activities KCM icon

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  KCMs should have color icons while widgets should have monochrome icons, so I 
have changed the name of the KCM icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-activities (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18529

AFFECTED FILES
  icons-dark/preferences/32/preferences-activities.svg
  icons-dark/preferences/32/preferences-desktop-activities.svg
  icons/preferences/32/preferences-activities.svg
  icons/preferences/32/preferences-desktop-activities.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18388: Build without D-Bus on Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:5bbb846dd970: Build without D-Bus on Android (authored by 
vkrause).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18388?vs=49893=50272

REVISION DETAIL
  https://phabricator.kde.org/D18388

AFFECTED FILES
  CMakeLists.txt
  KF5XmlGuiConfig.cmake.in
  src/CMakeLists.txt
  src/kmainwindow.cpp
  src/ktoolbar.cpp
  src/kxmlguiwindow.cpp

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18507: Add Activities KCM icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c3981728515f: Add Activities KCM icon (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18507?vs=50208=50268

REVISION DETAIL
  https://phabricator.kde.org/D18507

AFFECTED FILES
  icons-dark/preferences/32/preferences-activities.svg
  icons/preferences/32/preferences-activities.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18527: List Android as officially supported

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18527

To: vkrause, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18390: Build without D-Bus on Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:d5e76df55828: Build without D-Bus on Android (authored by 
vkrause).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18390?vs=49895=50267

REVISION DETAIL
  https://phabricator.kde.org/D18390

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kbookmarkmanager.cpp
  src/kbookmarkmanager.h

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18527: List Android as officially supported

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18527

AFFECTED FILES
  metainfo.yaml

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18475: Add AsciiDoc support

[Andreas Gratzer]

andreasgr updated this revision to Diff 50263.
andreasgr removed projects: Frameworks, Kate.
andreasgr added a comment.
Herald added projects: Kate, Frameworks.


  - Add missing allowed leading characters for links.
  - Add escaping of attribute usage.
  - Avoid highlighting of spaces inside table.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18475?vs=50126=50263

REVISION DETAIL
  https://phabricator.kde.org/D18475

AFFECTED FILES
  data/syntax/asciidoc.xml

To: andreasgr, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, #framework_syntax_highlighting, 
bmortimer, hase, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

D17851: Add Android notification backend

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> vkrause wrote in notifybyandroid.cpp:125
> Possible, I'll investigate.

Addressed in D18526 .

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17851

To: vkrause, apol
Cc: broulik, apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 25 Jan 2019 15:00:04 +
 Build duration:
1 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D18526: Fix memory leak when passing icon data to Java

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18526

AFFECTED FILES
  src/notifybyandroid.cpp

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18389: Build without D-Bus on Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:cb1509537cb6: Build without D-Bus on Android (authored by 
vkrause).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18389?vs=49894=50261

REVISION DETAIL
  https://phabricator.kde.org/D18389

AFFECTED FILES
  CMakeLists.txt
  src/solid/CMakeLists.txt
  src/solid/devices/backends/fakehw/fakedevice.cpp
  src/solid/devices/backends/fakehw/fakemanager.cpp
  src/solid/devices/backends/fakehw/fakevolume.cpp
  src/solid/devices/ifaces/device.cpp
  src/solid/devices/managerbase.cpp

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18507: Add Activities KCM icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  We can always rename it in another commit.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-desktop (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18507

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18387: Build without D-Bus on Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:080ee499f169: Build without D-Bus on Android (authored by 
vkrause).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18387?vs=49891=50260

REVISION DETAIL
  https://phabricator.kde.org/D18387

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kiconloader.cpp

To: vkrause, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

[loh tar]

loh.tar added a comment.


  > also don't change the behavior of wordwrapping that is used by the view 
compared to what we would get by calling wordwrap on the document directly
  
  It's somehow not the case. The document has no such function. It's similar to 
ViewPrivate::smartNewline() or ViewPrivate::killLine().
  
  ViewPrivate::applyWordWrap() is (now) like a higher level functionality based 
on two lower level functions.
  
  When everyone want this into the document, I can try to do it. Just give 
advice how exactly. 
  My only idea is to add a new function (e.g. wrapParagraph, reformatLines), 
which will result in an almost empty ViewPrivate::applyWordWrap().

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17949

To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 25 Jan 2019 14:21:39 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18386: Build without D-Bus on Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:4e8e170580f3: Build without D-Bus on Android (authored by 
vkrause).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18386?vs=49890=50257

REVISION DETAIL
  https://phabricator.kde.org/D18386

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdeinit/ktoolinvocation.cpp

To: vkrause, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18385: Build without KAuth and D-Bus on Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:747f0cdff38b: Build without KAuth and D-Bus on Android 
(authored by vkrause).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18385?vs=49889=50256

REVISION DETAIL
  https://phabricator.kde.org/D18385

AFFECTED FILES
  CMakeLists.txt
  KF5ConfigWidgetsConfig.cmake.in
  src/CMakeLists.txt
  src/kcmodule.cpp
  src/kcmodule.h
  src/kstandardaction.cpp

To: vkrause, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18369: Create tel: links for phone numbers

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> svuorela wrote in ktexttohtml.cpp:159
> How are the thread safety of the KTextToHTML functions?
> 
> And does that match the thread safety of the QRegularExpression and the const 
> methods in there?

Valid point. This isn't specified in the documentation, things like `static 
bool triedLoadPlugin` in the existing code suggest that this isn't thread-safe 
right now though.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D18369

To: vkrause
Cc: svuorela, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/13/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 25 Jan 2019 12:34:24 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26674/31382)53%
(10635/20107)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)98%
(12172/12371)50%
(6367/12853)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6282/7385)65%
(1809/2795)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7766/8977)66%
(2282/3470)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 25 Jan 2019 12:32:56 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/7/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 25 Jan 2019 12:32:29 +
 Build duration:
8 min 52 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26691/31380)53%
(10652/20107)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12201/12371)50%
(6391/12853)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6271/7383)65%
(1803/2795)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)86%
(7765/8977)66%
(2281/3470)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/12/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Fri, 25 Jan 2019 12:20:47 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26662/31348)53%
(10636/20081)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12189/12371)50%
(6382/12853)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6282/7385)65%
(1809/2795)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7755/8961)66%
(2276/3460)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 25 Jan 2019 12:20:47 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D17122: Add option to use wl_display_add_socket_auto

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:d671fcd0c09d: Add option to use 
wl_display_add_socket_auto (authored by fvogt).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17122?vs=50238=50241

REVISION DETAIL
  https://phabricator.kde.org/D17122

AFFECTED FILES
  autotests/server/test_display.cpp
  src/server/display.cpp
  src/server/display.h

To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17122: Add option to use wl_display_add_socket_auto

[Roman Gilg]

romangg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17122: Add option to use wl_display_add_socket_auto

[Roman Gilg]

romangg added a dependent revision: D18522: Name Wayland socket automatically 
when no socket name was specified.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18521: [server] Send initial org_kde_plasma_virtual_desktop_management.rows

[Vlad Zagorodniy]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:87d9d440919f: [server] Send initial 
org_kde_plasma_virtual_desktop_management.rows (authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18521?vs=50235=50239

REVISION DETAIL
  https://phabricator.kde.org/D18521

AFFECTED FILES
  src/server/plasmavirtualdesktop_interface.cpp

To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

[Fabian Vogt]

fvogt updated this revision to Diff 50238.
fvogt added a comment.


  Replace XDG_RUNTIME_DIR, test still passes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17122?vs=49806=50238

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17122

AFFECTED FILES
  autotests/server/test_display.cpp
  src/server/display.cpp
  src/server/display.h

To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17122: Add option to use wl_display_add_socket_auto

[Fabian Vogt]

fvogt marked 4 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/6/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 25 Jan 2019 12:20:47 +
 Build duration:
5 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(2/31347)53%
(10640/20081)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12202/12372)50%
(6391/12853)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(73/74)99%
(73/74)85%
(6274/7383)65%
(1805/2795)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7754/8961)66%
(2275/3460)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

D17122: Add option to use wl_display_add_socket_auto

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> fvogt wrote in test_display.cpp:223
> That won't work reliably either though - if wayland-0 is free, but wayland-1 
> is used, it would pick wayland-0 and wayland-2. Maybe it should just check 
> that starting both displays at the same time succeeds and that their socket 
> names are not equal.

That's why I said "do it one more time from there until you find the second 
wayland-y".
For example (semi-pseudo):

  QString name1, name2;
  
  int cnt = -1;
  while(true) {
  cnt++;
  const QString name = "wayland-" + str(cnt);
  if (!runtimeDir.exists(name)) {
  name1 = name;
  break;
  }
  }
  while(true) {
  cnt++;
  const QString name = "wayland-" + str(cnt);
  if (!runtimeDir.exists(name)) {
  name2 = name;
  break;
  }
  }

David's solution is nicer though.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18521: [server] Send initial org_kde_plasma_virtual_desktop_management.rows

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  send-initla-row-event

REVISION DETAIL
  https://phabricator.kde.org/D18521

To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> fvogt wrote in test_display.cpp:223
> That won't work reliably either though - if wayland-0 is free, but wayland-1 
> is used, it would pick wayland-0 and wayland-2. Maybe it should just check 
> that starting both displays at the same time succeeds and that their socket 
> names are not equal.

I would suggest changing the XDG_RUNTIME_DIR for the duration of the test.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma, romangg
Cc: davidedmundson, zzag, romangg, kde-frameworks-devel, michaelh, ngraham, 
bruns

D17122: Add option to use wl_display_add_socket_auto

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> romangg wrote in test_display.cpp:223
> This fails when one tries to run the test inside another Wayland session, 
> which already uses the wayland-0 socket name.
> 
> What you could do here is loop until you find the first non-existing 
> `wayland-x` in the runtime dir. Then do it one more time from there until you 
> find the second `wayland-y`. Remember x,y and compare these below against the 
> created socket names.

That won't work reliably either though - if wayland-0 is free, but wayland-1 is 
used, it would pick wayland-0 and wayland-2. Maybe it should just check that 
starting both displays at the same time succeeds and that their socket names 
are not equal.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma, romangg
Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D17122: Add option to use wl_display_add_socket_auto

[Roman Gilg]

romangg requested changes to this revision.
romangg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test_display.cpp:223
> +QVERIFY(runtimeDir.exists());
> +QVERIFY(!runtimeDir.exists("wayland-0"));
> +QVERIFY(!runtimeDir.exists("wayland-1"));

This fails when one tries to run the test inside another Wayland session, which 
already uses the wayland-0 socket name.

What you could do here is loop until you find the first non-existing 
`wayland-x` in the runtime dir. Then do it one more time from there until you 
find the second `wayland-y`. Remember x,y and compare these below against the 
created socket names.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma, romangg
Cc: zzag, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D18521: [server] Send initial org_kde_plasma_virtual_desktop_management.rows

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REPOSITORY
  R127 KWayland

BRANCH
  send-initla-row-event

REVISION DETAIL
  https://phabricator.kde.org/D18521

AFFECTED FILES
  src/server/plasmavirtualdesktop_interface.cpp

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18509: Fixed Bug Which Caused Infinite Loop While Highlighting Kconfig Files

[Christoph Cullmann]

cullmann added a comment.


  I thought I had a endless loop/recursion detection, bad :/
  Will take a look.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18509

To: jwilbee, #framework_syntax_highlighting, cullmann, dhaumann
Cc: nibags, shubham, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D18516: Fix end of folding region in rules with lookAhead=true

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann, 
KTextEditor.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18516

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18516: Fix end of folding region in rules with lookAhead=true

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-region-lookahead

REVISION DETAIL
  https://phabricator.kde.org/D18516

AFFECTED FILES
  autotests/folding/Kconfig.fold
  autotests/folding/folding.cpp.fold
  autotests/folding/highlight.cpp.fold
  autotests/folding/highlight.lex.fold
  autotests/folding/highlight.sh.fold
  autotests/folding/highlight.y.fold
  autotests/folding/light52_muldiv.vhdl.fold
  autotests/folding/light52_tb.vhdl.fold
  autotests/folding/preprocessor-bug363280.cpp.fold
  autotests/folding/test.diff.fold
  autotests/folding/test.mss.fold
  autotests/folding/test.prolog.fold
  autotests/folding/test.yaml.fold
  src/lib/abstracthighlighter.cpp

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D11235: Request change of ptrace scope from KCrash

[Christoph Roick]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:9f3cfcff960c: Request change of ptrace scope from KCrash 
(authored by croick).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11235?vs=49717=50215#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=49717=50215

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/ptracer.cpp
  src/ptracer.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11235: Request change of ptrace scope from KCrash

[Christoph Roick]

croick retitled this revision from "[DrKonqi] Request change of ptrace scope 
from KCrash" to "Request change of ptrace scope from KCrash".
croick edited the summary of this revision.

REPOSITORY
  R871 DrKonqi

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11236: [KCrash] Establish socket to allow change of ptracer

[Christoph Roick]

This revision was automatically updated to reflect the committed changes.
Closed by commit R285:2af59ef51f8c: [KCrash] Establish socket to allow change 
of ptracer (authored by croick).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11236?vs=49711=50214#toc

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11236?vs=49711=50214

REVISION DETAIL
  https://phabricator.kde.org/D11236

AFFECTED FILES
  src/kcrash.cpp

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

[Christoph Roick]

croick edited the summary of this revision.

REPOSITORY
  R285 KCrash

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

restore dialog sizes and QTBUG-40584

[Alexander Semke]

Hi,

after having read the documentation of KWindowConfig::restoreWindowSize(), I
understood how to properly restore the dialog sizes. I'm in a process of fixing
this now in LabPlot (20 dialogs or so):

https://cgit.kde.org/labplot.git/commit/?
id=ebfa6b4243dec41b6c656483a57401de4b387793

https://cgit.kde.org/labplot.git/commit/?
id=817125ca5f2c3d1141e52342e9e0239ea9f4f4ed

Basically, the pattern I need to add now everywhere is something like this:

//restore saved settings if available
create(); // ensure there's a window created
KConfigGroup conf(KSharedConfig::openConfig(), "FunctionValuesDialog");
if (conf.exists()) {
KWindowConfig::restoreWindowSize(windowHandle(), conf);
resize(windowHandle()->size()); // workaround for QTBUG-40584
} else
resize(QSize(300, 0).expandedTo(minimumSize()));

I'm wondering why not to move this logic completely into
KWindowConfig::restoreWindowSize() so that in the application code, until
QTBUG-40584 is adressed, we can simply do

KConfigGroup conf(KSharedConfig::openConfig(), "FunctionValuesDialog");
KWindowConfig::restoreWindowSize(windowHandle(), conf);

Were there any arguments against this?

https://bugreports.qt.io/browse/QTBUG-40584 - this one was closed last year
with "Incomplete" even though David actually provided enough information...

--
Alexander