D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

[Fabian Vogt]

fvogt added a comment.


  Can you add context to this diff by either using arc or git diff with more 
context?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19027

To: Lekensteyn, ngraham, dfaure, fvogt
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Kai Uwe Broulik]

broulik added a comment.


  What's the air conditioning do? suspend to disk?
  
  +1 on the moon for suspend

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Eike Hein]

hein added a comment.


  Could this maybe be input-games-symbolic (too)? Because I want a monochrome 
version always (my app recolors icons using the Kirigami feature, and that only 
works with monochrome icons).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added reviewers: hein, VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

AFFECTED FILES
  icons-dark/devices/16/input-gaming.svg
  icons-dark/devices/22/input-gaming.svg
  icons-dark/devices/symbolic/input-gaming-symbolic.svg
  icons/devices/16/input-gaming.svg
  icons/devices/22/input-gaming.svg
  icons/devices/symbolic/input-gaming-symbolic.svg

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/27/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 15 Feb 2019 04:36:10 +
 Build duration:
9 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 23 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/23/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 15 Feb 2019 04:36:10 +
 Build duration:
7 min 39 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)53%
(32200/60190)38%
(16672/44242)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9139/9576)48%
(4320/9027)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8359/14359)51%
(4707/9313)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3906/7970)34%
(1613/4775)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/

D19007: Wait for DBus Reply Before Performing Computations

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> narvaez wrote in monitor.cpp:90
> It does fix the issue because if getBatchSize returns 0 then updateInterval 
> is set to 100. It does introduce another issue which is that it won't allow 
> for an update interval under 100 (say, if the batch size was configurable in 
> the future which is something you should really consider) but that is a minor 
> issue compared to the crash this fixes.

The batchsize 40 by default, so currently the update interval is 200 files. 100 
or 200 does not matter to much, it is just a crude limiter anyway.

A better fix would be emit the remaining time directly from the scheduler, 
which could adapt much better to fast and slow progress. And listening to 
signals on DBus is in general preferable to querying.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

[David Narváez]

narvaez added inline comments.

INLINE COMMENTS

> davidedmundson wrote in monitor.cpp:90
> That won't fix the issue.
> 
> getBatchSize is still returning a QDBusPendingReply, using the value before 
> it's loaded will always be zero.

It does fix the issue because if getBatchSize returns 0 then updateInterval is 
set to 100. It does introduce another issue which is that it won't allow for an 
update interval under 100 (say, if the batch size was configurable in the 
future which is something you should really consider) but that is a minor issue 
compared to the crash this fixes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> poboiko wrote in kinotify.cpp:390
> Right, sorry, misprinted. 
> Actually, since there are a lot of `decodeName` calls around, probably it 
> would be better to decode it just once, right before `event->mask` matching 
> then, and then pass it everywhere?
> (less code duplication & mutliple calls if `mask` matches several events...)

Yes, but such a cleanup should go into a different review.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D14661: Force reevaluation of Predicates if interfaces are removed

[Stefan Brüns]

bruns added a comment.


  In D14661#410848 , @volkov wrote:
  
  > I guess that there is a short period of time when UDisks daemon is in 
inconsistent state, i.e. org.freedesktop.UDisks2.Filesystem interface is 
removed for CD-ROM device, but the device's properties still have Optical=true.
  >  Adding "updateBackend(udi);" before "emit deviceAdded(udi);" gives Udisks 
time to become consistent.
  
  
  Its not UDisks which is inconsistent, but the representation in Solid. It has 
a lot of issues:
  
  - properties are not per interface in Solid, but per device. This is plain 
wrong (e.g. the partition and the filesystem '/dev/sda5' may have different 
size, but Solid merges their "Size" property).
  - Solid does not listen properly to the propertiesChanged event, but insists 
on polling in a number of places.
  - DBus messages are handled in different places (e.g. the interfaces signals, 
handled in both DeviceManager and the Device), leading to inconsistent state.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham, apol
Cc: volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D18940: Add battery icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b04959059668: Add battery icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18940?vs=51712&id=51730

REVISION DETAIL
  https://phabricator.kde.org/D18940

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/status/16/battery-000-charging.svg
  icons-dark/status/16/battery-000.svg
  icons-dark/status/16/battery-010-charging.svg
  icons-dark/status/16/battery-010.svg
  icons-dark/status/16/battery-020-charging.svg
  icons-dark/status/16/battery-020.svg
  icons-dark/status/16/battery-030-charging.svg
  icons-dark/status/16/battery-030.svg
  icons-dark/status/16/battery-040-charging.svg
  icons-dark/status/16/battery-040.svg
  icons-dark/status/16/battery-050-charging.svg
  icons-dark/status/16/battery-050.svg
  icons-dark/status/16/battery-060-charging.svg
  icons-dark/status/16/battery-060.svg
  icons-dark/status/16/battery-070-charging.svg
  icons-dark/status/16/battery-070.svg
  icons-dark/status/16/battery-080-charging.svg
  icons-dark/status/16/battery-080.svg
  icons-dark/status/16/battery-090-charging.svg
  icons-dark/status/16/battery-090.svg
  icons-dark/status/16/battery-100-charging.svg
  icons-dark/status/16/battery-100.svg
  icons-dark/status/16/battery-caution-charging.svg
  icons-dark/status/16/battery-caution.svg
  icons-dark/status/16/battery-empty-charging.svg
  icons-dark/status/16/battery-empty.svg
  icons-dark/status/16/battery-full-charging.svg
  icons-dark/status/16/battery-full.svg
  icons-dark/status/16/battery-good-charging.svg
  icons-dark/status/16/battery-good.svg
  icons-dark/status/16/battery-low-charging.svg
  icons-dark/status/16/battery-low.svg
  icons-dark/status/16/battery-missing.svg
  icons-dark/status/22/battery-000-charging.svg
  icons-dark/status/22/battery-000.svg
  icons-dark/status/22/battery-010-charging.svg
  icons-dark/status/22/battery-010.svg
  icons-dark/status/22/battery-020-charging.svg
  icons-dark/status/22/battery-020.svg
  icons-dark/status/22/battery-030-charging.svg
  icons-dark/status/22/battery-030.svg
  icons-dark/status/22/battery-040-charging.svg
  icons-dark/status/22/battery-040.svg
  icons-dark/status/22/battery-050-charging.svg
  icons-dark/status/22/battery-050.svg
  icons-dark/status/22/battery-060-charging.svg
  icons-dark/status/22/battery-060.svg
  icons-dark/status/22/battery-070-charging.svg
  icons-dark/status/22/battery-070.svg
  icons-dark/status/22/battery-080-charging.svg
  icons-dark/status/22/battery-080.svg
  icons-dark/status/22/battery-090-charging.svg
  icons-dark/status/22/battery-090.svg
  icons-dark/status/22/battery-100-charging.svg
  icons-dark/status/22/battery-100.svg
  icons-dark/status/22/battery-caution-charging.svg
  icons-dark/status/22/battery-caution.svg
  icons-dark/status/22/battery-empty-charging.svg
  icons-dark/status/22/battery-empty.svg
  icons-dark/status/22/battery-full-charging.svg
  icons-dark/status/22/battery-full.svg
  icons-dark/status/22/battery-good-charging.svg
  icons-dark/status/22/battery-good.svg
  icons-dark/status/22/battery-low-charging.svg
  icons-dark/status/22/battery-low.svg
  icons-dark/status/22/battery-missing.svg
  icons-dark/status/32/battery-000-charging.svg
  icons-dark/status/32/battery-000.svg
  icons-dark/status/32/battery-010-charging.svg
  icons-dark/status/32/battery-010.svg
  icons-dark/status/32/battery-020-charging.svg
  icons-dark/status/32/battery-020.svg
  icons-dark/status/32/battery-030-charging.svg
  icons-dark/status/32/battery-030.svg
  icons-dark/status/32/battery-040-charging.svg
  icons-dark/status/32/battery-040.svg
  icons-dark/status/32/battery-050-charging.svg
  icons-dark/status/32/battery-050.svg
  icons-dark/status/32/battery-060-charging.svg
  icons-dark/status/32/battery-060.svg
  icons-dark/status/32/battery-070-charging.svg
  icons-dark/status/32/battery-070.svg
  icons-dark/status/32/battery-080-charging.svg
  icons-dark/status/32/battery-080.svg
  icons-dark/status/32/battery-090-charging.svg
  icons-dark/status/32/battery-090.svg
  icons-dark/status/32/battery-100-charging.svg
  icons-dark/status/32/battery-100.svg
  icons-dark/status/32/battery-caution-charging.svg
  icons-dark/status/32/battery-caution.svg
  icons-dark/status/32/battery-empty-charging.svg
  icons-dark/status/32/battery-empty.svg
  icons-dark/status/32/battery-full-charging.svg
  icons-dark/status/32/battery-full.svg
  icons-dark/status/32/battery-good-charging.svg
  icons-dark/status/32/battery-good.svg
  icons-dark/status/32/battery-low-charging.svg
  icons-dark/status/32/battery-low.svg
  icons-dark/status/32/battery-missing.svg
  icons/index.theme
  icons/status/16/battery-000-charging.svg
  icons/status/16/battery-000.svg
  icons/status/16/battery-010-charging.svg
  icons/status/16/battery-010.svg
  icons/status/16/battery-020-charging.svg
  icons/status/16/battery-020.svg
  icons/status/16/battery-030-chargi

D18845: authority: add support for passing details to polkit

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> polkitqt1-authority.cpp:130
> + * The returned pointer needs to be freed via g_object_unref when no
> + * longer needed. Returns NULL if details is empty.
> + */

nullptr

> polkitqt1-authority.cpp:328
> +if ( details.empty() )
> +return NULL;
> +

nullptr

> polkitqt1-authority.cpp:332
> +
> +for ( const auto &entry: details.toStdMap() ) {
> +const auto &key = entry.first;

whitespace

> polkitqt1-authority.cpp:422
> +
> +if (pk_details != NULL) {
> +g_object_unref(pk_details);

nullptr, or just `if (pk_details) {`

> polkitqt1-authority.h:226
> + */
> +void checkAuthorizationWithDetails(
> +const QString &actionId, const Subject &subject,

please add a KF6 TODO, merge with checkAuthorization

REPOSITORY
  R563 Polkit-1 Qt Library

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: kde-frameworks-devel

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the summary of this revision.
rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51727.
rooty added a comment.


  Add suspend moon/crescent and hibernate snowflake (thanks Noah!)

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51718&id=51727

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 15 Feb 2019 02:05:59 +
 Build duration:
8 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 15 Feb 2019 02:05:59 +
 Build duration:
6 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6347/8464)43%
(10135/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2697/2772)49%
(5765/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/10/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 15 Feb 2019 02:05:58 +
 Build duration:
6 min 26 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D19007: Wait for DBus Reply Before Performing Computations

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> bruns wrote in monitor.cpp:90
> much more trivial:
> 
>   auto updateInterval = std::max(100, 5 * m_scheduler->getBatchSize());
>   if (m_filesIndexed % updateInterval == 0) { ...

That won't fix the issue.

getBatchSize is still returning a QDBusPendingReply, using the value before 
it's loaded will always be zero.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

[Stefan Brüns]

bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

[Stefan Brüns]

bruns added a comment.


  good catch, but the fix is overengineered ...

INLINE COMMENTS

> monitor.cpp:90
> +batchSize.waitForFinished();
>  
> +if (!batchSize.isError()) {

much more trivial:

  auto updateInterval = std::max(100, 5 * m_scheduler->getBatchSize());
  if (m_filesIndexed % updateInterval == 0) { ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

[Peter Wu]

Lekensteyn created this revision.
Lekensteyn added reviewers: ngraham, dfaure, fvogt.
Lekensteyn added a project: Frameworks.
Lekensteyn requested review of this revision.

REVISION SUMMARY
  When the Save File dialog is in use with filters, any relative path
  would trigger warnings due to KIO::stat receiving an invalid URL in
  KFileWidgetPrivate::updateLocationEditExtension. Fix the warning by
  ensuring that relative paths are valid file URLs.
  
  Add a bunch of tests to check the expected properties while at it. These
  tests pass regardless of the fix but after the fix, warnings are gone.
  
  BUG: 373119

TEST PLAN
  Before the kfilewidget.cpp change:
  
$ ninja bin/kfilewidgettest && bin/kfilewidgettest testFilterChange 
testSetFilterForSave
Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 8.2.1 20181127)
PASS   : KFileWidgetTest::initTestCase()
QWARN  : KFileWidgetTest::testFilterChange() kf5.kio.core: Invalid URL: 
QUrl("some.txt")
QWARN  : KFileWidgetTest::testFilterChange() kf5.kio.core: Invalid URL: 
QUrl("some.txt")
QWARN  : KFileWidgetTest::testFilterChange() kf5.kio.core: Invalid URL: 
QUrl("some.txt")
Qt: Session management error: networkIdsList argument is NULL
PASS   : KFileWidgetTest::testFilterChange()
QWARN  : KFileWidgetTest::testSetFilterForSave(some.txt) kf5.kio.core: 
Invalid URL: QUrl("some.txt")
QWARN  : KFileWidgetTest::testSetFilterForSave(some.txt) kf5.kio.core: 
Invalid URL: QUrl("some.txt")
PASS   : KFileWidgetTest::testSetFilterForSave(some.txt)
PASS   : KFileWidgetTest::testSetFilterForSave(extensionless name)
PASS   : KFileWidgetTest::testSetFilterForSave(existing file)
QWARN  : KFileWidgetTest::testSetFilterForSave(some.2019) kf5.kio.core: 
Invalid URL: QUrl("some.2019")
QWARN  : KFileWidgetTest::testSetFilterForSave(some.2019) kf5.kio.core: 
Invalid URL: QUrl("some.txt")
PASS   : KFileWidgetTest::testSetFilterForSave(some.2019)
QWARN  : KFileWidgetTest::testSetFilterForSave(some.html) kf5.kio.core: 
Invalid URL: QUrl("some.html")
QWARN  : KFileWidgetTest::testSetFilterForSave(some.html) kf5.kio.core: 
Invalid URL: QUrl("some.txt")
PASS   : KFileWidgetTest::testSetFilterForSave(some.html)
PASS   : KFileWidgetTest::cleanupTestCase()
  
  After the change, all `QWARN` lines are gone.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19027

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kfilewidget.cpp

To: Lekensteyn, ngraham, dfaure, fvogt
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty retitled this revision from "[breeze-icons] WIP, Add "Type User" and 
"List Users" icons" to "[breeze-icons] Revamp system.svgz".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty added a comment.


  In D19020#412431 , @ngraham wrote:
  
  > The only problem here that is that the label says "Type User" but the icon 
depicts a password field. Maybe the icon could depict both a username field and 
a password field, one on top of the other. Then I bet it would be tall enough 
that we wouldn't feel the need to put it inside a circle.
  
  
  We actually tried that already and it turned out kinda boxy
  
  F6606959: image.png 
  
  Btw I don't think it has to be an accurate depiction seeing as we've got the 
label under it, so we've got more wiggle room that way

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty added a comment.


  F6615636: image.png 
  
  P.s. are you sure about the I beam and the dots inside a password field?
  It might turn out small to make out / appreciate

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Andres Betts]

abetts added a comment.


  In D19020#412431 , @ngraham wrote:
  
  > The only problem here that is that the label says "Type User" but the icon 
depicts a password field. Maybe the icon could depict both a username field and 
a password field, one on top of the other. Then I bet it would be tall enough 
that we wouldn't feel the need to put it inside a circle.
  
  
  Is the objective that the user sees the icon first and then understands what 
is to be done? If that's the case, the idea of image correctness would be 
relevant. If however, you want to only convey an idea of typing, then I would 
say this is enough. Which of the two assumptions is the one we are going for?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Nathaniel Graham]

ngraham added a comment.


  The only problem here that is that the label says "Type User" but the icon 
depicts a password field. Maybe the icon could depict both a username field and 
a password field, one on top of the other. Then I bet it would be tall enough 
that we wouldn't feel the need to put it inside a circle.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Andres Betts]

abetts added a comment.


  In D19020#412418 , @rooty wrote:
  
  > In D19020#412412 , @abetts wrote:
  >
  > > Would an icon like this work?
  > >
  > > F6615590: Group 3.png 
  > >
  > > Just trying to get to a good final icon for typing your user.
  >
  >
  > hey i like that, kai made fun of my version, but using both dots //and// an 
i beam could work
  
  
  Give it a shot. As for Kai, Kai is Kai... hehe.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty added a comment.


  In D19020#412412 , @abetts wrote:
  
  > Would an icon like this work?
  >
  > F6615590: Group 3.png 
  >
  > Just trying to get to a good final icon for typing your user.
  
  
  hey i like that, kai made fun of my version, but using both dots //and// an i 
beam could work

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty updated this revision to Diff 51718.
rooty added a comment.


  Fix glitch

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51716&id=51718

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Andres Betts]

abetts added a comment.


  Would an icon like this work?
  
  F6615590: Group 3.png 
  
  Just trying to get to a good final icon for typing your user.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty added a comment.


  In D19020#412387 , @ngraham wrote:
  
  > +1 on that "List Users" icon! Very nice.
  >
  > For the "Type User" icon, I wonder how much we really need that background 
circle. Especially if we wind up improving the suspend icon to have a moon and 
stars or some other kind of sleepytime iconography, then it would be nice to 
have icons without circles on both sides, so it's kinda symmetrical.
  
  
  Oh you don't want the suspend icon to have a circle? Oh well that changes 
things :D
  The I beam thing without the circle is kinda weird to me, but it actually 
looks fine with the circle around it.
  What about putting a circle around the crescent/stars that are going to make 
up the new suspend icon?
  F6615531: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty updated this revision to Diff 51716.
rooty added a comment.


  Improve List Users 22 px version

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51714&id=51716

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Nathaniel Graham]

ngraham added a comment.


  +1 on that "List Users" icon! Very nice.
  
  For the "Type User" icon, I wonder how much we really need that background 
circle. Especially if we wind up improving the suspend icon to have a moon and 
stars or some other kind of sleepytime iconography, then it would be nice to 
have icons without circles on both sides, so it's kinda symmetrical.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] WIP, Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty retitled this revision from "Add "Type User" and "List Users" icons" to 
"[breeze-icons] WIP, Add "Type User" and "List Users" icons".
rooty edited the test plan for this revision.
rooty added reviewers: VDG, Plasma, ngraham, abetts.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: Add "Type User" and "List Users" icons

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch adds new icons for the action buttons modified/added in D18893 
.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18940: Add battery icons

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  battery-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein, ngraham
Cc: broulik, ngraham, filipf, trickyricky26, kde-frameworks-devel, hein, 
michaelh, bruns

D18940: Add battery icons

[Noah Davis]

ndavis updated this revision to Diff 51712.
ndavis added a comment.


  Change `status/22` and `status/22@2x` from Scalable to Fixed

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18940?vs=51462&id=51712

BRANCH
  battery-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18940

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/status/16/battery-000-charging.svg
  icons-dark/status/16/battery-000.svg
  icons-dark/status/16/battery-010-charging.svg
  icons-dark/status/16/battery-010.svg
  icons-dark/status/16/battery-020-charging.svg
  icons-dark/status/16/battery-020.svg
  icons-dark/status/16/battery-030-charging.svg
  icons-dark/status/16/battery-030.svg
  icons-dark/status/16/battery-040-charging.svg
  icons-dark/status/16/battery-040.svg
  icons-dark/status/16/battery-050-charging.svg
  icons-dark/status/16/battery-050.svg
  icons-dark/status/16/battery-060-charging.svg
  icons-dark/status/16/battery-060.svg
  icons-dark/status/16/battery-070-charging.svg
  icons-dark/status/16/battery-070.svg
  icons-dark/status/16/battery-080-charging.svg
  icons-dark/status/16/battery-080.svg
  icons-dark/status/16/battery-090-charging.svg
  icons-dark/status/16/battery-090.svg
  icons-dark/status/16/battery-100-charging.svg
  icons-dark/status/16/battery-100.svg
  icons-dark/status/16/battery-caution-charging.svg
  icons-dark/status/16/battery-caution.svg
  icons-dark/status/16/battery-empty-charging.svg
  icons-dark/status/16/battery-empty.svg
  icons-dark/status/16/battery-full-charging.svg
  icons-dark/status/16/battery-full.svg
  icons-dark/status/16/battery-good-charging.svg
  icons-dark/status/16/battery-good.svg
  icons-dark/status/16/battery-low-charging.svg
  icons-dark/status/16/battery-low.svg
  icons-dark/status/16/battery-missing.svg
  icons-dark/status/22/battery-000-charging.svg
  icons-dark/status/22/battery-000.svg
  icons-dark/status/22/battery-010-charging.svg
  icons-dark/status/22/battery-010.svg
  icons-dark/status/22/battery-020-charging.svg
  icons-dark/status/22/battery-020.svg
  icons-dark/status/22/battery-030-charging.svg
  icons-dark/status/22/battery-030.svg
  icons-dark/status/22/battery-040-charging.svg
  icons-dark/status/22/battery-040.svg
  icons-dark/status/22/battery-050-charging.svg
  icons-dark/status/22/battery-050.svg
  icons-dark/status/22/battery-060-charging.svg
  icons-dark/status/22/battery-060.svg
  icons-dark/status/22/battery-070-charging.svg
  icons-dark/status/22/battery-070.svg
  icons-dark/status/22/battery-080-charging.svg
  icons-dark/status/22/battery-080.svg
  icons-dark/status/22/battery-090-charging.svg
  icons-dark/status/22/battery-090.svg
  icons-dark/status/22/battery-100-charging.svg
  icons-dark/status/22/battery-100.svg
  icons-dark/status/22/battery-caution-charging.svg
  icons-dark/status/22/battery-caution.svg
  icons-dark/status/22/battery-empty-charging.svg
  icons-dark/status/22/battery-empty.svg
  icons-dark/status/22/battery-full-charging.svg
  icons-dark/status/22/battery-full.svg
  icons-dark/status/22/battery-good-charging.svg
  icons-dark/status/22/battery-good.svg
  icons-dark/status/22/battery-low-charging.svg
  icons-dark/status/22/battery-low.svg
  icons-dark/status/22/battery-missing.svg
  icons-dark/status/32/battery-000-charging.svg
  icons-dark/status/32/battery-000.svg
  icons-dark/status/32/battery-010-charging.svg
  icons-dark/status/32/battery-010.svg
  icons-dark/status/32/battery-020-charging.svg
  icons-dark/status/32/battery-020.svg
  icons-dark/status/32/battery-030-charging.svg
  icons-dark/status/32/battery-030.svg
  icons-dark/status/32/battery-040-charging.svg
  icons-dark/status/32/battery-040.svg
  icons-dark/status/32/battery-050-charging.svg
  icons-dark/status/32/battery-050.svg
  icons-dark/status/32/battery-060-charging.svg
  icons-dark/status/32/battery-060.svg
  icons-dark/status/32/battery-070-charging.svg
  icons-dark/status/32/battery-070.svg
  icons-dark/status/32/battery-080-charging.svg
  icons-dark/status/32/battery-080.svg
  icons-dark/status/32/battery-090-charging.svg
  icons-dark/status/32/battery-090.svg
  icons-dark/status/32/battery-100-charging.svg
  icons-dark/status/32/battery-100.svg
  icons-dark/status/32/battery-caution-charging.svg
  icons-dark/status/32/battery-caution.svg
  icons-dark/status/32/battery-empty-charging.svg
  icons-dark/status/32/battery-empty.svg
  icons-dark/status/32/battery-full-charging.svg
  icons-dark/status/32/battery-full.svg
  icons-dark/status/32/battery-good-charging.svg
  icons-dark/status/32/battery-good.svg
  icons-dark/status/32/battery-low-charging.svg
  icons-dark/status/32/battery-low.svg
  icons-dark/status/32/battery-missing.svg
  icons/index.theme
  icons/status/16/battery-000-charging.svg
  icons/status/16/battery-000.svg
  icons/status/16/battery-010-charging.svg
  icons/status/16/battery-010.svg
  icons/status/16/battery-020-charging.svg
  icons/status/16/battery-020.svg
  icon

D18940: Add battery icons

[Noah Davis]

ndavis added a comment.


  In D18940#412125 , @ngraham wrote:
  
  > In D18940#411818 , @ndavis wrote:
  >
  > > Would changing `status/22` to Fixed cause a problem? It doesn't appear to 
cause any real issue when I look at the change through Cuttlefish.
  >
  >
  > Run dolphin with `QT_SCALE_FACTOR=2` in the environment and see if the 
Places panel icons are still monochrome.
  
  
  Places panel icons aren't status icons. I tried the same environment variable 
on Cuttlefish and it still looks ok.F6615426: Screenshot_20190214_151225.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  battery-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein, ngraham
Cc: broulik, ngraham, filipf, trickyricky26, kde-frameworks-devel, hein, 
michaelh, bruns

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger marked 7 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, zzag, #kwin
Cc: schernikov, guilhermesi, kde-frameworks-devel, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger updated this revision to Diff 51709.
ekurzinger added a comment.


  Thanks for taking a look, Roman. I've addressed your style suggestions and 
added support for passing stream attributes to the compositor. I had ignored 
these initially since the driver doesn't actually use this (fairly new) feature 
of the extension right now, but it probably is best to support it for 
future-proofness.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18824?vs=51123&id=51709

REVISION DETAIL
  https://phabricator.kde.org/D18824

AFFECTED FILES
  src/client/protocols/wayland-eglstream-controller.xml
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/eglstream_controller_interface.cpp
  src/server/eglstream_controller_interface.h
  src/server/eglstream_controller_interface_p.h

To: ekurzinger, romangg, davidedmundson, zzag, #kwin
Cc: schernikov, guilhermesi, kde-frameworks-devel, michaelh, ngraham, bruns

D19007: Wait for DBus Reply Before Performing Computations

[Nathaniel Graham]

ngraham added reviewers: bruns, astippich, poboiko.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19005: android: don't default to gcc anymore

[Volker Krause]

vkrause added a comment.


  In fact none of those seem to work here. D19016 
 works here though, and I suspect that the 
14 -> 21 in there should fix ECM on the CI.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19005

To: apol, #frameworks, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19016: Update Android toolchain files to reality

[Volker Krause]

vkrause created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  - NDK r18 does not ship GCC anymore, it's only clang now
  - same for STL, there's only libc++ there
  - API level 14 is not supported either anymore, the minimum supported by the 
current NDK is 16
  - The minimum supported API level by KF5 right now is 21 though, so use that 
as the default

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19016

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19005: android: don't default to gcc anymore

[Volker Krause]

vkrause added a comment.


  Actually having tested this, "deprecated_value" looks wrong there, shouldn't 
this be "default_value"?

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19005

To: apol, #frameworks, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19007: Wait for DBus Reply Before Performing Computations

[David Narváez]

narvaez edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

[David Narváez]

narvaez added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

[David Narváez]

narvaez created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
narvaez requested review of this revision.

REVISION SUMMARY
  If the scheduler has not replied by the time the batch size is used, the
  default value is 0 and the mod operation results in a Floating Point
  Exception.
  
  I argue similar precautions are not needed for the call to
  m_scheduler->getRemainingTime() in updateRemainingTime because the
  default value of 0 will just lead to a confusing duration string but not
  a crash.

REPOSITORY
  R293 Baloo

BRANCH
  newFile_crash

REVISION DETAIL
  https://phabricator.kde.org/D19007

AFFECTED FILES
  src/qml/experimental/monitor.cpp

To: narvaez
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  > It's not that the Plasma logo is bad, it's that it doesn't make sense to 
put it everywhere; doing so dilutes its branding power in fact. Also, it 
doesn't make sense to put it on icons that have nothing to do with Plasma.
  
  Sure. But I see a big blue display and ... I just can't help myself hahahaha

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Nathaniel Graham]

ngraham added a comment.


  In D18986#411922 , @rooty wrote:
  
  > But I have the feeling you want me to do the opposite - F6614356: image.png 

  
  
  Yeah in general I think using some permutation of the "classic" design 
presents less risk since it's much more recognizable.
  
  It's not that the Plasma logo is bad, it's that it doesn't make sense to put 
it everywhere; doing so dilutes its branding power in fact. Also, it doesn't 
make sense to put it on icons that have nothing to do with Plasma.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19005: android: don't default to gcc anymore

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19005

To: apol, #frameworks, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18940: Add battery icons

[Nathaniel Graham]

ngraham added a comment.


  In D18940#411818 , @ndavis wrote:
  
  > Would changing `status/22` to Fixed cause a problem? It doesn't appear to 
cause any real issue when I look at the change through Cuttlefish.
  
  
  Run dolphin with `QT_SCALE_FACTOR=2` in the environment and see if the Places 
panel icons are still monochrome.

REPOSITORY
  R266 Breeze Icons

BRANCH
  battery-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein, ngraham
Cc: broulik, ngraham, filipf, trickyricky26, kde-frameworks-devel, hein, 
michaelh, bruns

D19005: android: don't default to gcc anymore

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  It's deprecated

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19005

AFFECTED FILES
  toolchain/Android.cmake

To: apol, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

[Nathaniel Graham]

ngraham added reviewers: chinmoyr, fvogt.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19001

To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18845: authority: add support for passing details to polkit

[Nathaniel Graham]

ngraham added reviewers: chinmoyr, fvogt, bruns.

REPOSITORY
  R563 Polkit-1 Qt Library

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: kde-frameworks-devel

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

[Luca Beltrame]

lbeltrame added reviewers: dhaumann, cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19001

To: mgerstner, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

[Luca Beltrame]

lbeltrame added a reviewer: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19001

To: mgerstner, dhaumann, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

[loh tar]

loh.tar updated this revision to Diff 51680.
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Add autotest
  - Don't wrap twice when static wrap is set to avoid bad result

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17949?vs=50648&id=51680

REVISION DETAIL
  https://phabricator.kde.org/D17949

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/view/kateview.cpp
  src/view/kateview.h

To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, gennad, michaelh, ngraham, bruns, demsking, sars

D18845: authority: add support for passing details to polkit

[Luca Beltrame]

lbeltrame added a reviewer: Frameworks.
lbeltrame added a subscriber: kde-frameworks-devel.

REPOSITORY
  R563 Polkit-1 Qt Library

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks
Cc: kde-frameworks-devel

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 AndroidQt5.12 - Build # 3 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/3/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Thu, 14 Feb 2019 13:52:14 +
 Build duration:
26 sec and counting
   CONSOLE OUTPUT
  [...truncated 92 lines...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Prepare Android Dependencies)[Pipeline] sh[2019-02-14T13:52:39.345Z] + python3 ci-tooling/helpers/getsetting.py --product Frameworks --project extra-cmake-modules --platform AndroidQt5.12 --key externalDependencies[2019-02-14T13:52:39.345Z] + systemDependencies=[2019-02-14T13:52:39.345Z] + export DESTDIR=/home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12/install-divert/[2019-02-14T13:52:39.345Z] + export INSTALL_ROOT=/home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12/install-divert/[2019-02-14T13:52:39.345Z] + export APP_INSTALL_PREFIX=/home/user/install-prefix/[2019-02-14T13:52:39.345Z] + mkdir -p /home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12/install-divert///home/user/install-prefix//[2019-02-14T13:52:39.345Z] + [2019-02-14T13:52:39.345Z] + rsync -Ha /home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12/install-divert///home/user/install-prefix// /home/user/install-prefix//[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[2019-02-14T13:52:40.049Z] + python3 -u ci-tooling/helpers/configure-build.py --product Frameworks --project extra-cmake-modules --branchGroup kf5-qt5 --platform AndroidQt5.12 --installTo /home/user/install-prefix/[2019-02-14T13:52:40.049Z] == Using the following environment to perform the build:[2019-02-14T13:52:40.049Z] QMAKESPEC = 'android-clang'[2019-02-14T13:52:40.049Z] HOME  = '/home/user'[2019-02-14T13:52:40.049Z] LOGNAME   = 'user'[2019-02-14T13:52:40.049Z] JOB_NAME  = 'Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12'[2019-02-14T13:52:40.049Z] HOSTNAME  = '2e51eded69ba'[2019-02-14T13:52:40.049Z] LANGUAGE  = 'en_US.UTF-8'[2019-02-14T13:52:40.049Z] OLDPWD= '/home/user'[2019-02-14T13:52:40.049Z] STANDALONE_CXX= 'clang++'[2019-02-14T13:52:40.049Z] STANDALONE_EXTRA  = '--stl=libc++'[2019-02-14T13:52:40.049Z] LC_ALL= 'en_US.UTF-8'[2019-02-14T13:52:40.049Z] JOB_URL   = 'https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/'[2019-02-14T13:52:40.049Z] ANDROID_NDK_ROOT  = '/opt/android-ndk'[2019-02-14T13:52:40.049Z] BUILD_ID  = '3'[2019-02-14T13:52:40.049Z] BUILD_URL = 'https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/3/'[2019-02-14T13:52:40.049Z] JENKINS_URL   = 'https://build.kde.org/'[2019-02-14T13:52:40.049Z] QMAKEFEATURES = '/opt/Qt/5.12.1/android_armv7/mkspecs/features'[2019-02-14T13:52:40.049Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/3/display/redirect'[2019-02-14T13:52:40.049Z] DEBIAN_FRONTEND   = 'noninteractive'[2019-02-14T13:52:40.049Z] QT_SELECT = 'qt5'[2019-02-14T13:52:40.049Z] ANDROID_HOME  = '/opt/android-sdk'[2019-02-14T13:52:40.049Z] LANG  = 'en_US.UTF-8'[2019-02-14T13:52:40.049Z] HUDSON_URL= 'https://build.kde.org/'[2019-02-14T13:52:40.049Z] QT_PATH   = '/opt/Qt'[2019-02-14T13:52:40.049Z] NODE_LABELS   = 'AndroidQt5.12 Docker Swarm-3a27b949ef82'[2019-02-14T13:52:40.049Z] SHLVL = '1'[2019-02-14T13:52:40.049Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-02-14T13:52:40.049Z] PKG_CONFIG_PATH   = '/opt/Qt/5.12.1/android_armv7/lib/pkgconfig:/opt/kdeandroid-deps/lib/pkgconfig'[2019-02-14T13:52:40.049Z] QT_ANDROID= '/opt/Qt/5.12.1/android_armv7'[2019-02-14T13:52:40.049Z] BUILD_DISPLAY_NAME= '#3'[2019-02-14T13:52:40.049Z] _ = '/usr/bin/java'[2019-02-14T13:52:40.049Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-02-14T13:52:40.049Z] EXECUTOR_NUMBER   = '0'[2019-02-14T13:52:40.049Z] ANDROID_NDK_PLATFORM  = 'android-21'[2019-02-14T13:52:40.049Z] LD_LIBRARY_PATH   = '/opt/Qt/5.12.1/android_armv7/lib:/opt/kdeandroid-deps/lib'[2019-02-14T13:52:40.049Z] STAGE_NAME= 'Configuring Build'[2019-02-14T13:52:40.049Z] USER  = 'user'[2019-02-14T13:52:40.049Z] JOB_BASE_NAME = 'kf5-qt5 AndroidQt5.12'[2019-02-14T13:52:40.049Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/3/display/redirect?page=changes'[

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 AndroidQt5.12 - Build # 2 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/2/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Thu, 14 Feb 2019 13:35:49 +
 Build duration:
33 sec and counting
   CONSOLE OUTPUT
  [...truncated 15 lines...][2019-02-14T13:36:08.486Z] No credentials specified[2019-02-14T13:36:08.489Z] Cloning the remote Git repository[2019-02-14T13:36:08.501Z] Cloning repository git://anongit.kde.org/extra-cmake-modules[2019-02-14T13:36:08.529Z]  > git init /home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12 # timeout=10[2019-02-14T13:36:08.555Z] Fetching upstream changes from git://anongit.kde.org/extra-cmake-modules[2019-02-14T13:36:08.555Z]  > git --version # timeout=10[2019-02-14T13:36:08.557Z]  > git fetch --tags --progress git://anongit.kde.org/extra-cmake-modules +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-14T13:36:13.300Z] Checking out Revision 0b47899c1b92b0781367179d4255f99e2bb41518 (origin/master)[2019-02-14T13:36:13.153Z]  > git config remote.origin.url git://anongit.kde.org/extra-cmake-modules # timeout=10[2019-02-14T13:36:13.155Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:36:13.160Z]  > git config remote.origin.url git://anongit.kde.org/extra-cmake-modules # timeout=10[2019-02-14T13:36:13.166Z] Fetching upstream changes from git://anongit.kde.org/extra-cmake-modules[2019-02-14T13:36:13.166Z]  > git fetch --tags --progress git://anongit.kde.org/extra-cmake-modules +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-14T13:36:13.285Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-14T13:36:13.313Z]  > git config core.sparsecheckout # timeout=10[2019-02-14T13:36:13.322Z]  > git checkout -f 0b47899c1b92b0781367179d4255f99e2bb41518 # timeout=10[2019-02-14T13:36:13.821Z] Commit message: "Add compile check to FindEGL"[Pipeline] checkout[2019-02-14T13:36:13.956Z] No credentials specified[2019-02-14T13:36:13.962Z] Cloning the remote Git repository[2019-02-14T13:36:13.825Z]  > git rev-list --no-walk 0b47899c1b92b0781367179d4255f99e2bb41518 # timeout=10[2019-02-14T13:36:13.965Z] Cloning repository https://anongit.kde.org/sysadmin/ci-tooling[2019-02-14T13:36:13.966Z]  > git init /home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12/ci-tooling # timeout=10[2019-02-14T13:36:14.006Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-14T13:36:14.006Z]  > git --version # timeout=10[2019-02-14T13:36:14.008Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:36:15.453Z] Checking out Revision f8f336bb592fdfbbb4661d5ff845f74f9ba7ac39 (origin/master)[2019-02-14T13:36:15.495Z] Commit message: "android: include rsync on the CI docker image"[Pipeline] checkout[2019-02-14T13:36:15.591Z] No credentials specified[2019-02-14T13:36:15.597Z] Cloning the remote Git repository[2019-02-14T13:36:15.164Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-14T13:36:15.166Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:36:15.171Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-14T13:36:15.177Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-14T13:36:15.177Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:36:15.444Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-14T13:36:15.457Z]  > git config core.sparsecheckout # timeout=10[2019-02-14T13:36:15.465Z]  > git checkout -f f8f336bb592fdfbbb4661d5ff845f74f9ba7ac39 # timeout=10[2019-02-14T13:36:15.600Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-02-14T13:36:15.601Z]  > git init /home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12/ci-tooling/repo-metadata # timeout=10[2019-02-14T13:36:15.613Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-02-14T13:36:15.613Z]  > git --version # timeout=10[2019-02-14T13:36:15.619Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:36:17.242Z] Checking out Revision 46cb47ef6f1be6b11d6a34044d03dd2637f432ca (origin/master)[2019-02-14T13:36:17.319Z] Commit message: "Update alkimia information"[Pipeline] checkout[2019-02-14T13:36:17.014Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-02-14T13:36:17.016Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:36:17.021Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # tim

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:eda235463cd2: Avoid duplicate *-php.xml files in 
"data/CMakeLists.txt" (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18746?vs=51542&id=51676

REVISION DETAIL
  https://phabricator.kde.org/D18746

AFFECTED FILES
  data/CMakeLists.txt

To: cullmann, #framework_syntax_highlighting, dhaumann, nibags
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18995: Explicitly link against KAuth

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:d7dcbb26ec20: Explicitly link against KAuth (authored by 
apol).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18995?vs=51641&id=51673

REVISION DETAIL
  https://phabricator.kde.org/D18995

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt

To: apol, #kate, #frameworks, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 AndroidQt5.12 - Build # 1 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Thu, 14 Feb 2019 13:00:51 +
 Build duration:
35 sec and counting
   CONSOLE OUTPUT
  [...truncated 15 lines...][2019-02-14T13:01:11.629Z] No credentials specified[2019-02-14T13:01:11.633Z] Cloning the remote Git repository[2019-02-14T13:01:11.654Z] Cloning repository git://anongit.kde.org/extra-cmake-modules[2019-02-14T13:01:11.702Z]  > git init /home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12 # timeout=10[2019-02-14T13:01:11.805Z] Fetching upstream changes from git://anongit.kde.org/extra-cmake-modules[2019-02-14T13:01:11.805Z]  > git --version # timeout=10[2019-02-14T13:01:11.836Z]  > git fetch --tags --progress git://anongit.kde.org/extra-cmake-modules +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-14T13:01:13.206Z]  > git config remote.origin.url git://anongit.kde.org/extra-cmake-modules # timeout=10[2019-02-14T13:01:13.255Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:01:13.299Z]  > git config remote.origin.url git://anongit.kde.org/extra-cmake-modules # timeout=10[2019-02-14T13:01:13.467Z] Checking out Revision 0b47899c1b92b0781367179d4255f99e2bb41518 (origin/master)[2019-02-14T13:01:14.202Z] Commit message: "Add compile check to FindEGL"[2019-02-14T13:01:14.202Z] First time build. Skipping changelog.[Pipeline] checkout[2019-02-14T13:01:14.389Z] No credentials specified[2019-02-14T13:01:14.395Z] Cloning the remote Git repository[2019-02-14T13:01:13.349Z] Fetching upstream changes from git://anongit.kde.org/extra-cmake-modules[2019-02-14T13:01:13.349Z]  > git fetch --tags --progress git://anongit.kde.org/extra-cmake-modules +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-14T13:01:13.446Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-14T13:01:13.474Z]  > git config core.sparsecheckout # timeout=10[2019-02-14T13:01:13.503Z]  > git checkout -f 0b47899c1b92b0781367179d4255f99e2bb41518 # timeout=10[2019-02-14T13:01:14.398Z] Cloning repository https://anongit.kde.org/sysadmin/ci-tooling[2019-02-14T13:01:14.398Z]  > git init /home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12/ci-tooling # timeout=10[2019-02-14T13:01:14.424Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-14T13:01:14.424Z]  > git --version # timeout=10[2019-02-14T13:01:14.434Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:01:16.203Z] Checking out Revision 8099e80fa7909bb0ceeeb580d342877195485805 (origin/master)[2019-02-14T13:01:16.273Z] Commit message: "android: no need to skip over the arguments for build-kde-dependencies"[Pipeline] checkout[2019-02-14T13:01:16.365Z] No credentials specified[2019-02-14T13:01:16.369Z] Cloning the remote Git repository[2019-02-14T13:01:15.883Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-14T13:01:15.896Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:01:15.924Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-14T13:01:15.942Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-14T13:01:15.942Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:01:16.178Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-14T13:01:16.206Z]  > git config core.sparsecheckout # timeout=10[2019-02-14T13:01:16.231Z]  > git checkout -f 8099e80fa7909bb0ceeeb580d342877195485805 # timeout=10[2019-02-14T13:01:16.371Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-02-14T13:01:16.371Z]  > git init /home/user/workspace/Frameworks/extra-cmake-modules/kf5-qt5 AndroidQt5.12/ci-tooling/repo-metadata # timeout=10[2019-02-14T13:01:16.380Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-02-14T13:01:16.380Z]  > git --version # timeout=10[2019-02-14T13:01:16.405Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:01:18.098Z] Checking out Revision 46cb47ef6f1be6b11d6a34044d03dd2637f432ca (origin/master)[2019-02-14T13:01:18.268Z] Commit message: "Update alkimia information"[2019-02-14T13:01:17.763Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-02-14T13:01:17.767Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T13:01:17.794Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-02-14T13:01:17.815Z] Fe

D18997: Add functions returning all definitions for a mimetype or file name

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> repository.h:176
> + */
> +QVector definitionsForFileName(const QString &fileName) 
> const;
> +

As I understand, this currently is unsorted. Wouldn't it make sense to sort the 
returned vector by priority?

This information is also missing currently in the API documentation: I had to 
read the code to understand whether the Definitions in the QVector are sorted 
or not. Same for definitionsForMimeType().

Any comments?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18997

To: davschul, vkrause, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 1 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Thu, 14 Feb 2019 12:57:53 +
 Build duration:
39 sec and counting
   CONSOLE OUTPUT
  [...truncated 3 lines...][Pipeline] nodeStill waiting to schedule taskAll nodes of label ‘AndroidQt5.12’ are offlineRunning on Docker Swarm-94df4a61f2c7 in /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2019-02-14T12:58:19.137Z] No credentials specified[2019-02-14T12:58:19.152Z] Cloning the remote Git repository[2019-02-14T12:58:19.169Z] Cloning repository git://anongit.kde.org/knotifications[2019-02-14T12:58:19.196Z]  > git init /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12 # timeout=10[2019-02-14T12:58:19.210Z] Fetching upstream changes from git://anongit.kde.org/knotifications[2019-02-14T12:58:19.210Z]  > git --version # timeout=10[2019-02-14T12:58:19.212Z]  > git fetch --tags --progress git://anongit.kde.org/knotifications +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-14T12:58:23.870Z]  > git config remote.origin.url git://anongit.kde.org/knotifications # timeout=10[2019-02-14T12:58:23.873Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T12:58:23.878Z]  > git config remote.origin.url git://anongit.kde.org/knotifications # timeout=10[2019-02-14T12:58:23.885Z] Fetching upstream changes from git://anongit.kde.org/knotifications[2019-02-14T12:58:23.885Z]  > git fetch --tags --progress git://anongit.kde.org/knotifications +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-14T12:58:24.023Z] Checking out Revision 90db26c7fc67603538be9e6887d83361b57c1348 (origin/master)[2019-02-14T12:58:24.447Z] Commit message: "GIT_SILENT Upgrade KF5 version to 5.56.0."[2019-02-14T12:58:24.447Z] First time build. Skipping changelog.[Pipeline] checkout[2019-02-14T12:58:24.578Z] No credentials specified[2019-02-14T12:58:24.582Z] Cloning the remote Git repository[2019-02-14T12:58:24.008Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-14T12:58:24.037Z]  > git config core.sparsecheckout # timeout=10[2019-02-14T12:58:24.043Z]  > git checkout -f 90db26c7fc67603538be9e6887d83361b57c1348 # timeout=10[2019-02-14T12:58:24.584Z] Cloning repository https://anongit.kde.org/sysadmin/ci-tooling[2019-02-14T12:58:24.585Z]  > git init /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12/ci-tooling # timeout=10[2019-02-14T12:58:24.592Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-14T12:58:24.592Z]  > git --version # timeout=10[2019-02-14T12:58:24.596Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T12:58:26.211Z] Checking out Revision 8099e80fa7909bb0ceeeb580d342877195485805 (origin/master)[2019-02-14T12:58:26.228Z] Commit message: "android: no need to skip over the arguments for build-kde-dependencies"[Pipeline] checkout[2019-02-14T12:58:26.344Z] No credentials specified[2019-02-14T12:58:26.347Z] Cloning the remote Git repository[2019-02-14T12:58:26.004Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-14T12:58:26.005Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T12:58:26.009Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-14T12:58:26.013Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-14T12:58:26.013Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T12:58:26.208Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-14T12:58:26.213Z]  > git config core.sparsecheckout # timeout=10[2019-02-14T12:58:26.215Z]  > git checkout -f 8099e80fa7909bb0ceeeb580d342877195485805 # timeout=10[2019-02-14T12:58:26.349Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-02-14T12:58:26.349Z]  > git init /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12/ci-tooling/repo-metadata # timeout=10[2019-02-14T12:58:26.352Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-02-14T12:58:26.352Z]  > git --version # timeout=10[2019-02-14T12:58:26.353Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-14T12:58:27.885Z] Checking out Revision 46cb47ef6f1be6b11d6a34044d03dd2637f432ca (origin/master)[2019-02-14T12:58:28.081Z] Commit message: "Update alkimia information"[Pipeline] checkout[2019-02-14T12:58:28.164Z] No credentials specified[2019-02-1

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/23/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 14 Feb 2019 12:45:00 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 134 lines...][2019-02-14T12:55:52.762Z] EXECUTOR_NUMBER   = '0'[2019-02-14T12:55:52.762Z] SHLVL = '1'[2019-02-14T12:55:52.762Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-02-14T12:55:52.762Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-02-14T12:55:52.762Z] PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-02-14T12:55:52.762Z] QT_PLUGIN_PATH= '/usr/local/lib/qca-qt5'[2019-02-14T12:55:52.762Z] XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'[2019-02-14T12:55:52.762Z] QT_SELECT = 'qt5'[2019-02-14T12:55:52.762Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-02-14T12:55:52.762Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'[2019-02-14T12:55:52.762Z] [2019-02-14T12:55:52.762Z] [2019-02-14T12:55:52.762Z] == Commencing Configuration:[2019-02-14T12:55:52.762Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/kwayland/kf5-qt5 FreeBSDQt5.12"[2019-02-14T12:55:53.023Z] -- The C compiler identification is Clang 6.0.1[2019-02-14T12:55:53.023Z] -- The CXX compiler identification is Clang 6.0.1[2019-02-14T12:55:53.023Z] -- Check for working C compiler: /usr/bin/cc[2019-02-14T12:55:53.284Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-02-14T12:55:53.284Z] -- Detecting C compiler ABI info[2019-02-14T12:55:53.284Z] -- Detecting C compiler ABI info - done[2019-02-14T12:55:53.284Z] -- Detecting C compile features[2019-02-14T12:55:53.541Z] -- Detecting C compile features - done[2019-02-14T12:55:53.541Z] -- Check for working CXX compiler: /usr/bin/c++[2019-02-14T12:55:53.541Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-02-14T12:55:53.541Z] -- Detecting CXX compiler ABI info[2019-02-14T12:55:53.541Z] -- Detecting CXX compiler ABI info - done[2019-02-14T12:55:53.541Z] -- Detecting CXX compile features[2019-02-14T12:55:54.106Z] -- Detecting CXX compile features - done[2019-02-14T12:55:54.106Z] -- [2019-02-14T12:55:54.106Z] [2019-02-14T12:55:54.106Z] -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.6.0") [2019-02-14T12:55:54.106Z] -- Found Wayland_Client: /usr/local/lib/libwayland-client.so (found version "1.16.0") [2019-02-14T12:55:54.379Z] -- Found Wayland_Server: /usr/local/lib/libwayland-server.so (found version "1.16.0") [2019-02-14T12:55:54.379Z] -- Found Wayland: /usr/local/lib/libwayland-client.so;/usr/local/lib/libwayland-server.so (found suitable version "1.16.0", minimum required is "1.13") found components:  Client Server [2019-02-14T12:55:54.379Z] -- Found WaylandScanner: /usr/local/bin/wayland-scanner  [2019-02-14T12:55:54.379Z] -- Performing Test HAVE_EGL[2019-02-14T12:55:54.379Z] -- Performing Test HAVE_EGL - Failed[2019-02-14T12:55:54.379Z] -- Could NOT find EGL (missing: HAVE_EGL) (found version "1.5")[2019-02-14T12:55:54.379Z] -- Looking for __GLIBC__[2019-02-14T12:55:54.379Z] -- Looking for __GLIBC__ - not found[2019-02-14T12:55:54.379Z] -- Performing Test _OFFT_IS_64BIT[2019-02-14T12:55:54.716Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-02-14T12:55:54.716Z] -- Performing Test HAVE_DATE_TIME[2019-02-14T12:55:55.098Z] -- Performing Test HAVE_DATE_TIME - Success[2019-02-14T12:55:55.098Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-02-14T12:55:55.098Z] -- Looking for linux/input.h[2019-02-14T12:55:55.098Z] -- Looking for linux/input.h - not found[2019-02-14T12:55:55.098Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-02-14T12:55:55.852Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-02-14T12:55:55.852Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-02-14T12:55:56.200Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-02-14T12:55:56.200Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-02-14T12:55:56.555Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-02-14T12:55:56.555Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.14", minimum required is "1.8.13") found components:  doxygen dot [2019-02-14T12:55:56.555Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2019-02-14T12:55:56.816Z] -- The weston executable was not found. Some autotests will not be executed.[2019-02-14T12:55:56.816Z] -- The following features have been enabled:[2019-02-14T12:55:56.816Z] [2019-02-14T12:55:56.81

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 14 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/14/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 Feb 2019 12:45:00 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26871/31456)53%
(10780/20167)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12320/12393)50%
(6482/12883)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6287/7396)65%
(1813/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)87%
(7810/9014)66%
(2308/3496)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:12b58edd254a: FakeInput: add support for pointer move 
with absolute coordinates (authored by jgrulich).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49133&id=51668

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Given we have absolute events for other input, this makes sense.
  
  Ship it

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

[Matthias Gerstner]

mgerstner created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
mgerstner requested review of this revision.

REVISION SUMMARY
  This change breaks up the rather large `TextBuffer::save()` into separate
  functions. Most notably the privileged code path that requires a D-Bus
  helper invocation is now better separated from the unprivileged local
  code path.
  
  This change also introduces a small change in behaviour: If file open
  failed for other reasons than lacking permissions the invocation of the
  D-Bus helper is skipped, since there is no hope of the helper helping us
  in this case.
  
  This is preparatory work for further security related improvements
  of the katetextbuffer privilege escalation handling.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19001

AFFECTED FILES
  src/buffer/katetextbuffer.cpp
  src/buffer/katetextbuffer.h

To: mgerstner
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18933: Send optional events from wl_pointer v5

[Vlad Zagorodniy]

zzag added a comment.


  In D18933#411966 , @davidedmundson 
wrote:
  
  > IMHO we should make frame() explicitly sent from the caller.
  
  
  Yeah, I'd prefer this way as well to be honest...
  
  > Hard to add retroactively in KF5 though :/
  
  So, it would be KF6 stuff, right?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

[David Edmundson]

davidedmundson added a comment.


  > so we could send a diagonal scroll motion in one frame?
  
  We have this for a few things, such as clicking and moving.
  
  IMHO we should make frame() explicitly sent from the caller.
  I've hit this a few times (mostly wl_output) where KWayland tries to make 
things "easy" but in practice ends up making it harder to follow the protocol 
accurately.
  
  Hard to add retroactively in KF5 though :/

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

[Vlad Zagorodniy]

zzag added a subscriber: davidedmundson.
zzag added a comment.


  @davidedmundson Would it make sense to have something like
  
void pointerAxisV5(Qt::Orientations orientations, const QPointF &delta,
   const QPoint &discreteDelta, PointerAxisSource source);
  
  so we could send a diagonal scroll motion in one frame?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

[Vlad Zagorodniy]

zzag updated this revision to Diff 51659.
zzag added a comment.


  Add Unknown axis source.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18933?vs=51438&id=51659

BRANCH
  pointer-axis-value-discrete

REVISION DETAIL
  https://phabricator.kde.org/D18933

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/server/pointer_interface.cpp
  src/server/pointer_interface.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h

To: zzag, #kwin
Cc: mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D18883: Add PDF thumbnailer

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#411807 , @ngraham wrote:
  
  > I like the head-on camcorder style, but there's the risk that it's less 
recognizable than the "classic" style of video recorder icon that's used pretty 
much everywhere. If we go with the head-on style, it needs to be //perfect//.
  >
  > Oh and I agree with @ndavis: let's not put the Plasma logo all over the 
place in new icons. This thing has nothing to do with Plasma; it's 
inappropriate branding.
  
  
  What do you mean by perfect though?
  Inappropriate? I don't know about that. Also, I really like the logo. 
  Be it head on or side view, there's probably going to be some sort of 
display, and the logo seems preferable to inserting a generic landscape 
(boring). 
  I'd consider putting an image of a film reel on the display though (instead 
of on top of the camera haha).
  
  In D18986#411825 , @trickyricky26 
wrote:
  
  > In D18986#411807 , @ngraham 
wrote:
  >
  > > I like the head-on camcorder style, but there's the risk that it's less 
recognizable than the "classic" style of video recorder icon that's used pretty 
much everywhere. If we go with the head-on style, it needs to be //perfect//.
  >
  >
  > To add to this, this type of camcorder was a design trend that pretty much 
stopped a few years ago as smartphone cameras got better. This means this style 
will probably become less recognizable in the future. Also it looks completely 
different than your 16px and 22px icons.
  >
  > I would suggest adding a handle with the integrated microphone to the 
"classic" video camera design.
  
  
  While it is true that it'll become less recognizable, it's really hard to 
look at a camcorder head on and not see a camera lens.
  It's different from my 16 px and 22 px icons, but that's hardly a problem, I 
can always change those to accommodate the 64 px version.
  But I have the feeling you want me to do the opposite - F6614356: image.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18997: Add functions returning all definitions for a mimetype or file name

[Christoph Cullmann]

cullmann added a comment.


  Thanks.
  
  Nice that we get the patches, then all can benefit from the improvements.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18997

To: davschul, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D18997: Add functions returning all definitions for a mimetype or file name

[David Schulz]

davschul added a comment.


  Nice respond times here, and thanks for the reviews :)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18997

To: davschul, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D18997: Add functions returning all definitions for a mimetype or file name

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0e94e0006005: Add functions returning all definitions for 
a mimetype or file name (authored by davschul, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18997?vs=51649&id=51651

REVISION DETAIL
  https://phabricator.kde.org/D18997

AFFECTED FILES
  src/lib/repository.cpp
  src/lib/repository.h

To: davschul, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D18997: Add functions returning all definitions for a mimetype or file name

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks => will push that.

REVISION DETAIL
  https://phabricator.kde.org/D18997

To: davschul, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D18996: Fix building with namespaced Qt

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:96466afebf63: Fix building with namespaced Qt (authored 
by davschul, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18996?vs=51644&id=51650

REVISION DETAIL
  https://phabricator.kde.org/D18996

AFFECTED FILES
  data/CMakeLists.txt
  src/lib/abstracthighlighter.h
  src/lib/abstracthighlighter_p.h
  src/lib/context_p.h
  src/lib/definition.h
  src/lib/foldingregion.h
  src/lib/format.h
  src/lib/htmlhighlighter.h
  src/lib/keywordlist_p.h
  src/lib/repository.h
  src/lib/repository_p.h
  src/lib/rule_p.h
  src/lib/state.h
  src/lib/theme.h
  src/lib/themedata_p.h
  src/lib/wildcardmatcher.cpp
  src/lib/wildcardmatcher_p.h

To: davschul, vkrause
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D18997: Add functions returning all definitions for a mimetype or file name

[David Schulz]

davschul updated this revision to Diff 51649.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18997?vs=51645&id=51649

REVISION DETAIL
  https://phabricator.kde.org/D18997

AFFECTED FILES
  src/lib/repository.cpp
  src/lib/repository.h

To: davschul, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D18996: Fix building with namespaced Qt

[Volker Krause]

vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Looks good to me, thanks!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18996

To: davschul, vkrause
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, michaelh, 
genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D18998: update literate haskell mimetype

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:fe00f62078ea: update literate haskell mimetype (authored 
by davschul, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18998?vs=51647&id=51648

REVISION DETAIL
  https://phabricator.kde.org/D18998

AFFECTED FILES
  data/syntax/literate-haskell.xml

To: davschul, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18998: update literate haskell mimetype

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Makes sense ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18998

To: davschul, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18998: update literate haskell mimetype

[David Schulz]

davschul added a comment.


  see 
https://cgit.freedesktop.org/xdg/shared-mime-info/tree/freedesktop.org.xml.in?h=Release-1-12#n6074

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18998

To: davschul, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18998: update literate haskell mimetype

[David Schulz]

davschul created this revision.
davschul added reviewers: vkrause, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.

REVISION SUMMARY
  According to the freedesktop mimetypes literate haskell uses it's own mimetype
  with the name text/x-literate-haskell

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18998

AFFECTED FILES
  data/syntax/literate-haskell.xml

To: davschul, vkrause, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann