KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/16/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 21 Feb 2019 05:28:52 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/28/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 21 Feb 2019 05:28:52 +
 Build duration:
5 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/24/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 21 Feb 2019 05:28:52 +
 Build duration:
4 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

[loh tar]

loh.tar added a comment.


  For my taste is that hint not really right/useful. That should not be shown 
when the document begin/end was wrapped but when the initially staring point 
reached.
  
  May try to fix that when got some +1

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19193

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19193

AFFECTED FILES
  src/inputmode/katenormalinputmode.cpp
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D16579: Remove support for non-standard APE tag field names

[James Smith]

smithjd retitled this revision from "Fix APE tag extraction" to "Remove support 
for non-standard APE tag field names".
smithjd edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
spoorun, ngraham, abrahams

D16579: Fix APE tag extraction

[James Smith]

smithjd added a comment.


  I realise that with all the fields referenced here having at least one 
standard fieldname parsed now that complaining may seem to be flogging a dead 
horse, but I'd like to re-iterate that identically-purposed fields should not 
be encouraged. This is at best a specialized re-purposing that really shouldn't 
be. Maintaining a branch / fork for this is probably appropriate.
  
  Lastly, I'd also like to point out the TagLib documentation, that 
specifically mentions a conversion from 'Album Artist' in 'AlbumArtist' for 
compatibility with other tags: 
https://taglib.org/api/classTagLib_1_1APE_1_1Tag.html#af77a10659fbb0018228420ad6de501e1.
 'Disc' is also converted from APE, but you have to dig into the code to find 
this: https://github.com/taglib/taglib/blob/master/taglib/ape/apetag.cpp#L211

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
spoorun, ngraham, abrahams

D16579: Fix APE tag extraction

[James Smith]

smithjd updated this revision to Diff 52185.
smithjd added a comment.


  - Use the de-facto Album Artist field name for APE tags.
  
  Re-base.

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16579?vs=44708=52185

BRANCH
  master-musepackFixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16579

AFFECTED FILES
  autotests/samplefiles/test.ape
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.wv
  src/extractors/taglibextractor.cpp

To: smithjd, astippich, bruns, mgallien
Cc: bruns, astippich, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
spoorun, ngraham, abrahams

D17518: Adapt favicon test to www.kde.org changes

[Stefan Brüns]

bruns abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17518

To: bruns, #frameworks, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> astippich wrote in propertydata.cpp:80
> This means that multiple entries with the same key get stored as single 
> entries in the property map, right? 
> This breaks the current behavior in dolphin and baloo-widgets. Merging (or 
> more specific D19088 ) must then wait 
> until we convert all those data to output stringlists. But I think this code 
> will also split up data of stringlists, doesn't it?
> Also, if there are multiple extractors for the same mime type (which I know 
> there aren not currently) , which will add e.g. two releaseYear properties, 
> these will be converted to a string.

Actually, I am not sure **if** we need the stringlists as a separate type.. 
What is the difference between multiple strings in a stringlist, and multiple 
strings as individual dict entries?

What is the **semantic** difference between the two?

> astippich wrote in propertydata.cpp:83
> Now ints are converted to doubles, which is not fatal, but IMHO also not very 
> clean either. But since JSON only knows doubles, this is what we get. Only 
> way out in this case is to query PropertyInfo::valueType, and do the 
> conversion based on this.

Thats what also happens in the current code.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added a comment.


  And factor out the function, it is used in 2 places, and you can unit test it 
then.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added a comment.


  In D18915#416402 , @cfoster wrote:
  
  > In D18915#416400 , @bruns wrote:
  >
  > > https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName
  > >
  > > > Returns the suffix for the file fileName, as known by the MIME database.
  > > >  This allows to pre-select "tar.bz2" for foo.tar.bz2, but still only 
"txt" for my.file.with.dots.txt.
  >
  >
  > This was the original method of getting the file extension however it was 
converting the file extensions to lower case.
  >
  > This can be demonstrated with the following code:
  >  QMimeDatabase db;
  >  QUrl url = (QString) "foo.TXT";
  >  const QString extension = db.suffixForFileName(url.toDisplayString());
  >  qDebug(qUtf8Printable(extension)); //outputs "txt"
  
  
  Just compare the extension after `.toLower()`, and if both match, keep the 
original one.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster added a comment.


  In D18915#416400 , @bruns wrote:
  
  > https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName
  >
  > > Returns the suffix for the file fileName, as known by the MIME database.
  > >  This allows to pre-select "tar.bz2" for foo.tar.bz2, but still only 
"txt" for my.file.with.dots.txt.
  
  
  This was the original method of getting the file extension however it was 
converting the file extensions to lower case.
  
  This can be demonstrated with the following code:
  QMimeDatabase db;
  QUrl url = (QString) "foo.TXT";
  const QString extension = db.suffixForFileName(url.toDisplayString());
  qDebug(qUtf8Printable(extension)); //outputs "txt"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added a comment.


  https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName
  
  > Returns the suffix for the file fileName, as known by the MIME database.
  >  This allows to pre-select "tar.bz2" for foo.tar.bz2, but still only "txt" 
for my.file.with.dots.txt.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster added inline comments.

INLINE COMMENTS

> ngraham wrote in batchrenamejob.cpp:181
> Is it?
> 
> `file.tar.gz`

Ah yes... very good point...
I think have to rethink how to solve this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh, bruns

D18915: Fix batchrename changing extension to lower case

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> batchrenamejob.cpp:181
> +
> + //If the oldFileName contains a '.' then its extension is all to the 
> right of the last dot
> +int dotIndex = oldFileName.lastIndexOf(QStringLiteral("."));

Is it?

`file.tar.gz`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh, bruns

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster updated this revision to Diff 52180.
cfoster added a comment.


  - Changes after review feedback

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18915?vs=51372=52180

BRANCH
  arcpatch-D18915_2

REVISION DETAIL
  https://phabricator.kde.org/D18915

AFFECTED FILES
  src/core/batchrenamejob.cpp

To: cfoster, #dolphin, #frameworks, abalaji
Cc: elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18845: authority: add support for passing details to polkit

[Stefan Brüns]

bruns added a comment.


  Does this solve part of T8075 ?

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: kde-frameworks-devel

D18770: [KStatusNotifierItem] use fallback sizes when none is available

[Stefan Brüns]

bruns added a comment.


  While this may be necessary in some cases, I wonder if there shouldn't be 
some more emphasis on using the IconName instead of a pixmap:
  
  - The icon stays scalable
  - Less data to serialize/deserialize over DBus
  
  Additionaly, the StatusNotifierHost could be to extended with a property 
denoting its current Icon size, so only sizes in use are serialized. This would 
help the cases where an application actually paints the Icon and can not use 
IconName + OverlayIconName.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D18770

To: pino
Cc: bruns, davidedmundson, kde-frameworks-devel, michaelh, ngraham

D18853: Fix sharing files with spaces or quotes in names via Telegram

[Mikhail Rudenko]

mikhailru added a comment.


  In D18853#416211 , @apol wrote:
  
  > Looks much better :D
  >
  > Can you land the patch?
  
  
  I'm afraid I can't. Actually this is my first KDE patch that have made it 
this far. :)

REPOSITORY
  R495 Purpose Library

BRANCH
  telegram-sharing-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18853

To: mikhailru, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18873: add baloo engine debugging category

[Stefan Brüns]

bruns added a comment.


  @valeriymalov - are you going to push this?

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18986: [breeze-icons] Add video camera icons

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:85f4fe3a76e5: [breeze-icons] Add video camera icons 
(authored by Rafael Brandmaier rafael.brandma...@kdemail.net).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=52165=52166

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/symbolic/camera-video-symbolic.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg
  icons/devices/symbolic/camera-video-symbolic.svg

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Eike Hein]

hein accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52165.
trickyricky26 added a comment.


  - Add -symbolic symlinks to the 16px version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=52161=52165

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons-dark/devices/symbolic/camera-video-symbolic.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg
  icons/devices/symbolic/camera-video-symbolic.svg

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18762: Add support for portals in KRun

[Denis Karpovskii]

GeeXT updated this revision to Diff 52163.
GeeXT added a comment.


  Swap the conditions

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18762?vs=51047=52163

BRANCH
  flatpak_open_url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18762

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18762: Add support for portals in KRun

[Denis Karpovskii]

GeeXT marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  flatpak_open_url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18762

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18455: Port to new connect syntax

[Aleix Pol Gonzalez]

apol added a comment.


  What happened here?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18455

To: chinmoyr, davidedmundson, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12251: Integrate with androiddeployqt dependencies files

[Aleix Pol Gonzalez]

apol abandoned this revision.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D12251

To: apol, #frameworks, vkrause, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15795: Fix warnings about deprecated install dirs

[Aleix Pol Gonzalez]

apol added a comment.


  Has this been fixed? I haven't seen these warnings

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15795

To: dinoh, apol, dfaure
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Eike Hein]

hein added a comment.


  Would it be possible to also add the lineart versions as -symbolic? In my new 
app I rely on Kirigami's icon recoloring feature and it only works with 
monochrome icons, so I rely on -symbolic to request them.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D17863: Add ecm_check_linker_flags function

[Aleix Pol Gonzalez]

apol added a comment.


  Yep, I'd say let's get it in kstars and if other applications start needing 
it, we move it to ECM to share.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17863

To: tcberner, #freebsd, dfaure, apol, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18762: Add support for portals in KRun

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Overall, it looks good to me. Let's get this in.
  
  Regarding your process, I think you could have passed `--devel` on the step 7 
and compiled kio there together with konversation. Maybe that makes it a bit 
easier next time.

INLINE COMMENTS

> krun.cpp:956
>  
> +if (checkNeedPortalSupport() && d->m_externalBrowserEnabled) {
> +// use the function from QDesktopServices as it handles portals 
> correctly

Maybe you can swap the condition so the function is only called when 
m_externalBrowserEnabled is true.

REPOSITORY
  R241 KIO

BRANCH
  flatpak_open_url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18762

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18853: Fix sharing files with spaces or quotes in names via Telegram

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks much better :D
  
  Can you land the patch?

REPOSITORY
  R495 Purpose Library

BRANCH
  telegram-sharing-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18853

To: mikhailru, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Noah Davis]

ndavis added a comment.


  @ngraham If you include this in TWIP, use this image since it's slightly 
sharper on the 64px icon. @trickyricky26's `montage` is screwing up even though 
he's using the same command as me. F6626420: montage-breeze-Background.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  LGTM! I really like how the 64px version turned out, especially that shotgun 
mic.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52161.
trickyricky26 added a comment.


  - Add the bottom 1px shadow

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=52154=52161

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

[loh tar]

loh.tar updated this revision to Diff 52158.
loh.tar edited the summary of this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Do not wrap in some cases with block selection
  - Auto wrap once wrapped line again also when static wrap is disabled
  
  Autotest looks BTW not so bad
  
The following tests FAILED:
62 - vimode_modes (Failed)
65 - vimode_keys (Failed)

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19131?vs=52072=52158

REVISION DETAIL
  https://phabricator.kde.org/D19131

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19107: Write valid UTF8 characters without escaping.

[Jos van den Oever]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:2cdcd4f30666: Write valid UTF8 characters without 
escaping. (authored by vandenoever).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19107?vs=52096=52159

REVISION DETAIL
  https://phabricator.kde.org/D19107

AFFECTED FILES
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  src/core/kconfigini.cpp

To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Now that's what I'm talkin' about!!! I love these!
  
  All in favor?

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty, ngraham
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52154.
trickyricky26 added a comment.


  - Improve contrast by making the camera silver, add Breeze-style shadows to 
screen and buttons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=52151=52154

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19107: Write valid UTF8 characters without escaping.

[Thiago Macieira]

thiago added a comment.


  It looks good to me.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19107

To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 52151.
trickyricky26 added a comment.


  - Use a 64px design with a shotgun-type mic; use steeper angle for the lens 
on small versions

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=52021=52151

BRANCH
  arcpatch-D18986

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19170: Fix crash while moving files

[David Hallas]

hallas added a comment.


  In D19170#415760 , @dfaure wrote:
  
  > If some code is deleting this job from a slot connected to it, that code 
needs to be fixed. This hack isn't a fix, it will only create more problems..
  >
  > E.g. if some other bad code runs the event loop in the slot connected to 
finished, it will now delete the job, and we'll get the exact same crash but on 
`if (emitResult)` this time.
  >
  > This is a big no from me. The emitter of a signal MUST NOT be deleted in 
slots connected to it.
  >
  > The bug needs proper analysis.
  
  
  Hi David,
  
  thanks for the reply :) I completely agree with you that this is a hack and 
shouldn't go in, it was merely meant as an aid in doing proper analysis of the 
bug. I hope one of the people who can actually reproduce the problem can try 
with this patch enabled and see if it goes away. If it does then I think we can 
be pretty certain that someone is deleting jobs that they shouldn't. Otherwise 
I don't have much to go on. I have tried to reproduce the problem in various 
ways, copying to/from an NTFS drive and also copying to/from SMB but I can't 
get it to crash. I have been looking some more into the code and I still cannot 
figure out how the KJob instance can get invalidated. Have you looked at the 
backtraces? Do you have any ideas or pointers to where to look?
  
  Appreciate the feedback

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D19170

To: hallas, #frameworks, elvisangelaccio, dfaure
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D19170: Fix crash while moving files

[David Hallas]

hallas added a comment.


  In D19170#416120 , @hallas wrote:
  
  > In D19170#416067 , @hallas wrote:
  >
  > > In D19170#415760 , @dfaure 
wrote:
  > >
  > > > If some code is deleting this job from a slot connected to it, that 
code needs to be fixed. This hack isn't a fix, it will only create more 
problems..
  > > >
  > > > E.g. if some other bad code runs the event loop in the slot connected 
to finished, it will now delete the job, and we'll get the exact same crash but 
on `if (emitResult)` this time.
  > > >
  > > > This is a big no from me. The emitter of a signal MUST NOT be deleted 
in slots connected to it.
  > > >
  > > > The bug needs proper analysis.
  > >
  > >
  > > Hi David,
  > >
  > > thanks for the reply :) I completely agree with you that this is a hack 
and shouldn't go in, it was merely meant as an aid in doing proper analysis of 
the bug. I hope one of the people who can actually reproduce the problem can 
try with this patch enabled and see if it goes away. If it does then I think we 
can be pretty certain that someone is deleting jobs that they shouldn't. 
Otherwise I don't have much to go on. I have tried to reproduce the problem in 
various ways, copying to/from an NTFS drive and also copying to/from SMB but I 
can't get it to crash. I have been looking some more into the code and I still 
cannot figure out how the KJob instance can get invalidated. Have you looked at 
the backtraces? Do you have any ideas or pointers to where to look?
  > >
  > > Appreciate the feedback
  >
  >
  > Ok, I think I just found a way to reproduce the problem:
  >
  > - Move a directory with a bunch of files to a NTFS USB Drive
  > - While it is moving the files, move them back
  > - Sometimes I have to have more then one move back and forth running for it 
to crash
  >
  >   I have now built KIO with address sanitizer and I get the following info:
  >
  >   ``` ==7539==ERROR: AddressSanitizer: heap-use-after-free on address 
0x6120002e3de0 at pc 0x7f2cdbbed173 bp 0x7ffec26c5050 sp 0x7ffec26c5040 READ of 
size 8 at 0x6120002e3de0 thread T0 #0 0x7f2cdbbed172 in 
KIO::CopyJobPrivate::slotResultErrorCopyingFiles(KJob*) 
../src/core/copyjob.cpp:1464 #1 0x7f2cdbbeb26f in 
KIO::CopyJobPrivate::slotResultCopyingFiles(KJob*) ../src/core/copyjob.cpp:1333 
#2 0x7f2cdbbfba35 in KIO::CopyJob::slotResult(KJob*) 
../src/core/copyjob.cpp:2160 #3 0x7f2cd612a986 in 
QMetaObject::activate(QObject*, int, int, void**) 
(/usr/lib64/libQt5Core.so.5+0x264986) #4 0x7f2cd7e6e18b in KJob::result(KJob*, 
KJob::QPrivateSignal) (/usr/lib64/libKF5CoreAddons.so.5+0x3d18b) #5 
0x7f2cd7e6ecc0 in KJob::finishJob(bool) 
(/usr/lib64/libKF5CoreAddons.so.5+0x3dcc0) #6 0x7f2cdbc95d8b in 
KIO::FileCopyJob::slotResult(KJob*) ../src/core/filecopyjob.cpp:497 #7 
0x7f2cd612a986 in QMetaObject::activate(QObject*, int, int, void**) 
(/usr/lib64/libQt5Core.so.5+0x264986) #8 0x7f2cd7e6e18b in KJob::result(KJob*, 
KJob::QPrivateSignal) (/usr/lib64/libKF5CoreAddons.so.5+0x3d18b) #9 
0x7f2cd7e6ecc0 in KJob::finishJob(bool) 
(/usr/lib64/libKF5CoreAddons.so.5+0x3dcc0) #10 0x7f2cdbcb2267 in 
KIO::SimpleJob::slotFinished() ../src/core/simplejob.cpp:232 #11 0x7f2cdbcb265d 
in KIO::SimpleJob::slotError(int, QString const&) ../src/core/simplejob.cpp:245 
#12 0x7f2cdbcb8e49 in QtPrivate::FunctorCall, 
QtPrivate::List, void, void (KIO::SimpleJob::*)(int, 
QString const&)>::call(void (KIO::SimpleJob::*)(int, QString const&), 
KIO::SimpleJob*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:134 #13 
0x7f2cdbcb88ea in void QtPrivate::FunctionPointer::call, void>(void 
(KIO::SimpleJob::*)(int, QString const&), KIO::SimpleJob*, void**) 
/usr/include/qt5/QtCore/qobjectdefs_impl.h:167 #14 0x7f2cdbcb83a7 in 
QtPrivate::QSlotObject, void>::impl(int, 
QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) 
/usr/include/qt5/QtCore/qobjectdefs_impl.h:396 #15 0x7f2cd612a986 in 
QMetaObject::activate(QObject*, int, int, void**) 
(/usr/lib64/libQt5Core.so.5+0x264986) #16 0x7f2cdbc63a91 in 
KIO::SlaveInterface::error(int, QString const&) 
src/core/KF5KIOCore_autogen/include/moc_slaveinterface.cpp:425 #17 
0x7f2cdbc5da14 in KIO::SlaveInterface::dispatch(int, QByteArray const&) 
../src/core/slaveinterface.cpp:192 #18 0x7f2cdbc5cac7 in 
KIO::SlaveInterface::dispatch() ../src/core/slaveinterface.cpp:89 #19 
0x7f2cdbc69a74 in KIO::Slave::gotInput() ../src/core/slave.cpp:406 #20 
0x7f2cdbc71d88 in QtPrivate::FunctorCall, 
QtPrivate::List<>, void, void (KIO::Slave::*)()>::call(void (KIO::Slave::*)(), 
KIO::Slave*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:134 #21 
0x7f2cdbc719cb in void QtPrivate::FunctionPointer::call, void>(void (KIO::Slave::*)(), 
KIO::Slave*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:167 #22 
0x7f2cdbc7118b in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, 
void**, bool*) 

D18986: [breeze-icons] Add video camera icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: trickyricky26, #vdg, hein, ndavis, rooty
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19170: Fix crash while moving files

[David Hallas]

hallas added a comment.


  In D19170#416067 , @hallas wrote:
  
  > In D19170#415760 , @dfaure wrote:
  >
  > > If some code is deleting this job from a slot connected to it, that code 
needs to be fixed. This hack isn't a fix, it will only create more problems..
  > >
  > > E.g. if some other bad code runs the event loop in the slot connected to 
finished, it will now delete the job, and we'll get the exact same crash but on 
`if (emitResult)` this time.
  > >
  > > This is a big no from me. The emitter of a signal MUST NOT be deleted in 
slots connected to it.
  > >
  > > The bug needs proper analysis.
  >
  >
  > Hi David,
  >
  > thanks for the reply :) I completely agree with you that this is a hack and 
shouldn't go in, it was merely meant as an aid in doing proper analysis of the 
bug. I hope one of the people who can actually reproduce the problem can try 
with this patch enabled and see if it goes away. If it does then I think we can 
be pretty certain that someone is deleting jobs that they shouldn't. Otherwise 
I don't have much to go on. I have tried to reproduce the problem in various 
ways, copying to/from an NTFS drive and also copying to/from SMB but I can't 
get it to crash. I have been looking some more into the code and I still cannot 
figure out how the KJob instance can get invalidated. Have you looked at the 
backtraces? Do you have any ideas or pointers to where to look?
  >
  > Appreciate the feedback
  
  
  Ok, I think I just found a way to reproduce the problem:
  
  - Move a directory with a bunch of files to a NTFS USB Drive
  - While it is moving the files, move them back
  - Sometimes I have to have more then one move back and forth running for it 
to crash
  
  I have now built KIO with address sanitizer and I get the following info:
  
==7539==ERROR: AddressSanitizer: heap-use-after-free on address 
0x6120002e3de0 at pc 0x7f2cdbbed173 bp 0x7ffec26c5050 sp 0x7ffec26c5040
READ of size 8 at 0x6120002e3de0 thread T0
#0 0x7f2cdbbed172 in 
KIO::CopyJobPrivate::slotResultErrorCopyingFiles(KJob*) 
../src/core/copyjob.cpp:1464
#1 0x7f2cdbbeb26f in KIO::CopyJobPrivate::slotResultCopyingFiles(KJob*) 
../src/core/copyjob.cpp:1333
#2 0x7f2cdbbfba35 in KIO::CopyJob::slotResult(KJob*) 
../src/core/copyjob.cpp:2160
#3 0x7f2cd612a986 in QMetaObject::activate(QObject*, int, int, void**) 
(/usr/lib64/libQt5Core.so.5+0x264986)
#4 0x7f2cd7e6e18b in KJob::result(KJob*, KJob::QPrivateSignal) 
(/usr/lib64/libKF5CoreAddons.so.5+0x3d18b)
#5 0x7f2cd7e6ecc0 in KJob::finishJob(bool) 
(/usr/lib64/libKF5CoreAddons.so.5+0x3dcc0)
#6 0x7f2cdbc95d8b in KIO::FileCopyJob::slotResult(KJob*) 
../src/core/filecopyjob.cpp:497
#7 0x7f2cd612a986 in QMetaObject::activate(QObject*, int, int, void**) 
(/usr/lib64/libQt5Core.so.5+0x264986)
#8 0x7f2cd7e6e18b in KJob::result(KJob*, KJob::QPrivateSignal) 
(/usr/lib64/libKF5CoreAddons.so.5+0x3d18b)
#9 0x7f2cd7e6ecc0 in KJob::finishJob(bool) 
(/usr/lib64/libKF5CoreAddons.so.5+0x3dcc0)
#10 0x7f2cdbcb2267 in KIO::SimpleJob::slotFinished() 
../src/core/simplejob.cpp:232
#11 0x7f2cdbcb265d in KIO::SimpleJob::slotError(int, QString const&) 
../src/core/simplejob.cpp:245
#12 0x7f2cdbcb8e49 in QtPrivate::FunctorCall, QtPrivate::List, void, void (KIO::SimpleJob::*)(int, 
QString const&)>::call(void (KIO::SimpleJob::*)(int, QString const&), 
KIO::SimpleJob*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:134
#13 0x7f2cdbcb88ea in void QtPrivate::FunctionPointer::call, void>(void (KIO::SimpleJob::*)(int, QString const&), KIO::SimpleJob*, 
void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:167
#14 0x7f2cdbcb83a7 in QtPrivate::QSlotObject, 
void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) 
/usr/include/qt5/QtCore/qobjectdefs_impl.h:396
#15 0x7f2cd612a986 in QMetaObject::activate(QObject*, int, int, void**) 
(/usr/lib64/libQt5Core.so.5+0x264986)
#16 0x7f2cdbc63a91 in KIO::SlaveInterface::error(int, QString const&) 
src/core/KF5KIOCore_autogen/include/moc_slaveinterface.cpp:425
#17 0x7f2cdbc5da14 in KIO::SlaveInterface::dispatch(int, QByteArray 
const&) ../src/core/slaveinterface.cpp:192
#18 0x7f2cdbc5cac7 in KIO::SlaveInterface::dispatch() 
../src/core/slaveinterface.cpp:89
#19 0x7f2cdbc69a74 in KIO::Slave::gotInput() ../src/core/slave.cpp:406
#20 0x7f2cdbc71d88 in QtPrivate::FunctorCall, 
QtPrivate::List<>, void, void (KIO::Slave::*)()>::call(void (KIO::Slave::*)(), 
KIO::Slave*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:134
#21 0x7f2cdbc719cb in void QtPrivate::FunctionPointer::call, void>(void (KIO::Slave::*)(), 
KIO::Slave*, void**) /usr/include/qt5/QtCore/qobjectdefs_impl.h:167
#22 0x7f2cdbc7118b in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, 

D19035: Help build on Windows with usage of CMake Targets

[Christoph Cullmann]

cullmann added a comment.


  I think then we should just abandon it, if it has no real benefit at all, or?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19035

To: dantti, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D19035: Help build on Windows with usage of CMake Targets

[Daniel Nicoletti]

dantti added a comment.


  I ended up compiling it using vcpkg toolchain directly on Windows, which 
showed this isn't required.
  
  In fact even when cross-compiling this won't fix anything because the tool 
must run on the host OS.
  
  So I only still think this is useful because the user will notice that it 
tried to compile and run an .EXE which won't work on their host, I don't think 
this will cause any harm but I didn't test if this still works when specifiyng 
the indexer path variable.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19035

To: dantti, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/25/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 20 Feb 2019 09:20:01 +
 Build duration:
5 min 30 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D19168: Fix crash in Dolphin when dropping trashed file in trash

[David Hallas]

hallas marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19168

To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

[David Hallas]

hallas updated this revision to Diff 52132.
hallas added a comment.


  Implemented review comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19168?vs=52105=52132

BRANCH
  fix_crash_when_dropping_trashed_file_in_trash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19168

AFFECTED FILES
  autotests/dropjobtest.cpp
  src/widgets/dropjob.cpp

To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

[Jos van den Oever]

vandenoever added a comment.


  So it's accepted?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19107

To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

[David Hallas]

hallas added a comment.


  In D19168#415767 , @dfaure wrote:
  
  > Looks good, just some minor improvement suggestions for the unittest.
  
  
  Thanks for the suggestions - I am still quite new to using QtTest :) 
Essentially I copied one of the other unit tests and worked my way from there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19168

To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

[Ahmad Samir]

ahmadsamir added a comment.


  In D19161#415701 , @dhaumann wrote:
  
  > This patch looks good to me, even though I cannot reproduce the issue 
following the steps in https://bugs.kde.org/show_bug.cgi?id=399278.
  
  
  Another way to test, try setting the underline attribute for any item in the 
syntax highlighting config widget, hitting apply unsets it again.
  
  It //might// be dependent on how qt is compiled, I am using Fedora, the OP in 
the BR is using Ubuntu. But I didn't look into that too much, since upstream 
docs clearly say FontUnderline is deprecated (and it looks like it's been 
deprecated since qtbase was split from monolithic qt git repo).
  
  > But yes, the Qt documentation says to use TextUnderlineStyle instead of 
FontUnderline. The implementation of fontUnderline() indeed also first tries to 
use TextUnderlineStyle, see: 
https://code.woboq.org/qt5/qtbase/src/gui/text/qtextformat.cpp.html#_ZNK15QTextCharFormat13fontUnderlineEv
  
  Yes, I was puzzled by that too; if FontUnderline is still supported in 
upstream code, why doesn't it work now...
  
  > So from my side this change is OK, but probably before committing this 
should be tested again.
  
  [...]
  
  In D19161#415702 , @dhaumann wrote:
  
  > Btw, searching in lxr.kde.org for FontUnderline reveals some more hits: 
https://lxr.kde.org/ident?_i=FontUnderline&_remember=1
  
  
  OK, I'll try and get them all. :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19161

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann