D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[loh tar]

loh.tar added a comment.


  Personally I would avoid doxygen style or multiline comments in code and 
prefer //

INLINE COMMENTS

> katerenderer.cpp:988
>  // ensure minimal height of one pixel to not fall in the div by 0 trap 
> somewhere
>  // use font line spacing, this includes the leading
> +m_fontHeight = qMax(1, qCeil(config()->fontMetrics().ascent() + 
> config()->fontMetrics().descent()));

a hint my good that lineSpacing() is not sufficient

> kateviewinternal.cpp:3024
>  
>  // first: paint our line
>  // set clipping region if we paint the line above us, too

"second:" is gone

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/30/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 25 Feb 2019 04:48:04 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/18/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 25 Feb 2019 04:48:05 +
 Build duration:
42 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3616/13331)18%
(1821/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(683/1571)29%
(303/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/26/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 25 Feb 2019 04:48:05 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[James Smith]

smithjd added inline comments.

INLINE COMMENTS

> taglibextractor.cpp:109
> +{
> +if (savedProperties.contains("TITLE")) {
> +result->add(Property::Title, 
> TStringToQString(savedProperties["TITLE"].toString()).trimmed());

This could return early if the property map is empty.

> taglibextractor.cpp:195
>  }
> -
> -itApe = lstApe.find("PERFORMER");
> -if (itApe != lstApe.end()) {
> -if (!data.performer.isEmpty()) {
> -data.performer += ", ";
> +/* Lyricist is called "WRITER" for wma/asf files */
> +if (savedProperties.contains("WRITER")) {

Can this be moved into the asf-specific extractions?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18826

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18563: Don't create directory tree when a new folder has a '/' in the name

[Shubham]

shubham added a comment.


  @ngraham Any updates?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Shubham]

shubham added a comment.


  @ngraham Any updates?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D17737: [CopyJob] Create clones in btrf/xfs mount

[Stefan Brüns]

bruns added a comment.


  The code looks sane to me, but I have not found time to test it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17737

To: chinmoyr, dfaure, davidedmundson, #frameworks
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D17737: [CopyJob] Create clones in btrf/xfs mount

[Stefan Brüns]

bruns added a comment.


  Can you update the summary - although CoW and cloning typically come 
together, they are two different functions (and you can e.g. have CoW disabled 
for a dir/file, and cloning still works).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17737

To: chinmoyr, dfaure, davidedmundson, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D17737: [CopyJob] Create clones in btrf/xfs mount

[Stefan Brüns]

bruns added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17737

To: chinmoyr, dfaure, davidedmundson, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D19287: [ExtractorCollection] Load extractor plugins lazily

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In many cases, only a few plugins are required, or even only one
  (e.g. for baloo-widgets, baloo_filemetadata_temp_extractor) or none
  (in case there is no extractor for a given mimetype).
  
  Loading of plugins is somewhat costly, so delay loading of plugins until
  they are requested by fetchExtractors(mimetype).
  
  For e.g. extracting tags from an mp3 file, which only requires the
  taglibextractor, the runtime is reduced by more than 90%.

TEST PLAN
  ctest
  valgrind --tool=callgrind

REPOSITORY
  R286 KFileMetaData

BRANCH
  lazy_loading

REVISION DETAIL
  https://phabricator.kde.org/D19287

AFFECTED FILES
  src/extractor.cpp
  src/extractor.h
  src/extractor_p.h
  src/extractorcollection.cpp
  src/extractorcollection.h

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 46 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/46/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 24 Feb 2019 20:18:25 +
 Build duration:
5 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)79%
(2710/3439)66%
(1760/2650)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(706/772)58%
(391/678)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(202/264)src.lib90%
(27/30)90%
(27/30)85%
(1782/2086)73%
(1167/1592)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 40 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/40/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 24 Feb 2019 20:18:25 +
 Build duration:
6 min 24 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)79%
(2710/3439)66%
(1760/2650)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(706/772)58%
(391/678)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(202/264)src.lib90%
(27/30)90%
(27/30)85%
(1782/2086)73%
(1167/1592)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 54 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/54/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Feb 2019 20:18:25 +
 Build duration:
1 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

D19255: WIP: Alternate approach to D19253

[Roman Gilg]

romangg added a comment.


  In D19255#418729 , @davidedmundson 
wrote:
  
  > > Maybe add a TODO comment on merge to the setLogicalSize (that it does not 
handle the size plus scale change correctly in every case).
  >
  > Can you expand on what you mean?
  
  
  I thought we discussed this problem already in the other diff. Example:
  
  Single 4K Monitor is used in 1080p with 1 times scaling: logical size is 1080p
  Now an atomic change comes of: Resolution set to 4K, scaling factor to 2. 
This triggers a wl_output::done event, but the logical size stays the same, 
i.e. not necessary set the dirty bit.
  
  I just realize with our current KWin/KWayland code, which has to set the 
logical size on every pixelSize and scale change we do not have this problem at 
the moment, but later if we want to send only one done event per atomic 
configuration change a single wl_output::done event might be generated but not 
the respective xdg_output::done event.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19255

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 39 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/39/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 24 Feb 2019 20:08:35 +
 Build duration:
3 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)79%
(2711/3439)66%
(1761/2650)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)92%
(707/772)58%
(392/678)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(202/264)src.lib90%
(27/30)90%
(27/30)85%
(1782/2086)73%
(1167/1592)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 53 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/53/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Feb 2019 20:08:35 +
 Build duration:
2 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 45 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/45/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 24 Feb 2019 20:08:35 +
 Build duration:
3 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)79%
(2710/3439)66%
(1760/2650)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(706/772)58%
(391/678)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/292)77%
(202/264)src.lib90%
(27/30)90%
(27/30)85%
(1782/2086)73%
(1167/1592)

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

[Nathaniel Graham]

ngraham added a comment.


  Updating the patch to only do that makes sense, but putting this 
minimum-value-is-always-zero guard in there too may also make sense just as a 
safety valve. I'll leave it up to the #plasma 
 folks at this point.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19256

To: benjaminrobin, #plasma
Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

D19263: Add more highlighting for nested languages in markdown.

[Dominik Haumann]

dhaumann added a comment.


  Hi Jos, could you please check again the output of the highlighting indexer?
  
ContextChecker::check: 
"/home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/markdown.xml" 
Unused contexts: QSet("kconfig-code")
  
  The checker says that this context is unused... I think this is a bug.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19263

To: vandenoever, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D19215: Install DefinitionDownloader header

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:df18fada76b2: Install DefinitionDownloader header 
(authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19215?vs=52269=52478

REVISION DETAIL
  https://phabricator.kde.org/D19215

AFFECTED FILES
  src/lib/CMakeLists.txt

To: davschul, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D19286: Add unit test for definitionsForFileName() and definitionsForMimeType()

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:41f4e86ee522: Add unit test for definitionsForFileName() 
and definitionsForMimeType() (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19286?vs=52471=52477#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19286?vs=52471=52477

REVISION DETAIL
  https://phabricator.kde.org/D19286

AFFECTED FILES
  autotests/syntaxrepository_test.cpp

To: dhaumann, cullmann, davschul, vkrause
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19286: Add unit test for definitionsForFileName() and definitionsForMimeType()

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  test-definitions-getters

REVISION DETAIL
  https://phabricator.kde.org/D19286

To: dhaumann, cullmann, davschul, vkrause
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19215: Install DefinitionDownloader header

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19215

To: davschul, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D19285: Make it compile without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R292:6d3e49e94e98: Make it compile without foreach (authored 
by mlaurent).

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19285?vs=52468=52473

REVISION DETAIL
  https://phabricator.kde.org/D19285

AFFECTED FILES
  CMakeLists.txt
  src/converter.cpp
  src/currency.cpp
  src/unitcategory.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19278: Make it compile without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R279:33bd17052e98: Make it compile without foreach (authored 
by mlaurent).

REPOSITORY
  R279 ThreadWeaver

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19278?vs=52452=52474

REVISION DETAIL
  https://phabricator.kde.org/D19278

AFFECTED FILES
  CMakeLists.txt
  autotests/JobTests.cpp
  benchmarks/QueueBenchmarks.cpp
  examples/ThumbNailer/Model.cpp
  src/weaver.cpp
  src/weaver_p.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19271: Make it compiles without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:3fbec01f6f7c: Make it compiles without foreach (authored 
by mlaurent).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19271?vs=52435=52472

REVISION DETAIL
  https://phabricator.kde.org/D19271

AFFECTED FILES
  CMakeLists.txt
  src/xslt.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19215: Install DefinitionDownloader header

[Dominik Haumann]

dhaumann added a comment.


  I also do not see an issue with this.
  
  But I would like to add some background info that may be interesting: 
Downloading the syntax highlighting files will download all files, and not just 
the ones that changed etc. This by itself is fine, since it guarantees 
consistency with highlighting files that include each other with the 
IncludeRules rule. However, with downloading you'll get almost 300 .xml files 
that need to be checked for version info etc... That may be slow (and in fact 
one of the reasons why we compile in the files as Qt resource). That said, if 
you open a file that uses KSyntaxHighlighting, you may experience several 
hundred milliseconds of delay when the Repository instance is created.
  
  I am just adding this as a "you should know what you are doing" info, since 
you probably want to avoid instanciating a Repository by default on application 
startup, since then Qt Creator would startup slower.
  
  Besides that, no issues from my side, of course :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19215

To: davschul, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D19286: Add unit test for definitionsForFileName() and definitionsForMimeType()

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: cullmann, davschul.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  Add unit tests for newly added functions for KF 5.56.

TEST PLAN
  make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  test-definitions-getters

REVISION DETAIL
  https://phabricator.kde.org/D19286

AFFECTED FILES
  autotests/syntaxrepository_test.cpp

To: dhaumann, cullmann, davschul
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19285: Make it compile without foreach

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R292 KUnitConversion

BRANCH
  build_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19285

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19278: Make it compile without foreach

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R279 ThreadWeaver

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19278

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19271: Make it compiles without foreach

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19271

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Thomas Schöps]

thomassc added a comment.


  I think that this change will fix bug 403470 as well.
  
  Suggestion: in updateFontHeight()  in katerenderer.cpp, add a comment saying 
that the line height needs to match that which is used by Qt, since Qt may 
handle some parts of the drawing, e.g. selection backgrounds, and a mismatch 
will cause drawing issues. Perhaps also say where in the Qt code this can be 
looked up.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: thomassc, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19285: Make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R292 KUnitConversion

BRANCH
  build_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19285

AFFECTED FILES
  CMakeLists.txt
  src/converter.cpp
  src/currency.cpp
  src/unitcategory.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Christoph Cullmann]

cullmann created this revision.
cullmann added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  using a better height and removing the overpainting stuff

TEST PLAN
  I did try a bit to zoom and use different documents, it looks ok, but it did 
look ok before in most cases, too :/

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19283

AFFECTED FILES
  src/render/katerenderer.cpp
  src/view/kateviewinternal.cpp

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19255: WIP: Alternate approach to D19253

[David Edmundson]

davidedmundson added a comment.


  > Maybe add a TODO comment on merge to the setLogicalSize (that it does not 
handle the size plus scale change correctly in every case).
  
  Can you expand on what you mean?

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19255

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  fix_crash_when_dropping_trashed_file_in_trash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19168

To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

[David Hallas]

hallas added a comment.


  @dfaure  - do you have any other comments for this commit?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19168

To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19035: Help build on Windows with usage of CMake Targets

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann edited reviewers, added: dantti; removed: cullmann.
cullmann added a comment.


  > I will abandon it.
  
  
  I compile syntax-highlighting btw. nightly, too, in the AbsInt compile farm 
on Windows (MSVC) and macOS (xcode toolchain) and see no issues with the 
current way.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19035

To: cullmann, #framework_syntax_highlighting, dhaumann, vkrause, dantti
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19035: Help build on Windows with usage of CMake Targets

[Christoph Cullmann]

cullmann abandoned this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19035

To: cullmann, #framework_syntax_highlighting, dhaumann, vkrause, dantti
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:8fb410574b14: Use QTextFormat::TextUnderlineStyle instead 
of QTextFormat::FontUnderline (authored by ahmadsamir, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19161?vs=52075=52459

REVISION DETAIL
  https://phabricator.kde.org/D19161

AFFECTED FILES
  src/schema/katestyletreewidget.cpp
  src/syntax/katehighlight.cpp
  src/syntax/katesyntaxmanager.cpp

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Given the docs explicitly state one shall use the new enum value, I think 
this should go in.

REPOSITORY
  R39 KTextEditor

BRANCH
  syntax-hl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19161

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18734: Update octave.xml to Octave 4.2.0

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c27d13d75155: Update octave.xml to Octave 4.2.0 (authored 
by sirgienko, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18734?vs=52442=52457

REVISION DETAIL
  https://phabricator.kde.org/D18734

AFFECTED FILES
  autotests/folding/highlight_octave.m.fold
  autotests/folding/test.octave.fold
  autotests/html/highlight_octave.m.html
  autotests/html/test.octave.html
  autotests/input/highlight_octave.m
  autotests/input/highlight_octave.m.syntax
  autotests/input/test.octave
  autotests/reference/highlight_octave.m.ref
  autotests/reference/test.octave.ref
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D19163: Make it possible to show all spaces in the document

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0a9aeb183314: Make it possible to show all spaces in the 
document (authored by apol, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19163?vs=52320=52456

REVISION DETAIL
  https://phabricator.kde.org/D19163

AFFECTED FILES
  autotests/src/vimode/base.cpp
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/document/katedocument.cpp
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/katecmds.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewinternal.cpp

To: apol, #kate, cullmann
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
bruns, demsking, sars, dhaumann

D19163: Make it possible to show all spaces in the document

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think that is ok now, thanks for the nifty feature.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19163

To: apol, #kate, cullmann
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
bruns, demsking, sars, dhaumann

D18734: Update octave.xml to Octave 4.2.0

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  But beside the stuff with the xcvxv.xcvc stuff, I think you can commit this 
already as a first step to have a nicer highlighting, nice to see all hard 
coded colors gone!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  octave

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Christoph Cullmann]

cullmann added a comment.


  For the . stuff in keywords, have you tried to specify some
  
  
  
  style stuff?

INLINE COMMENTS

> sirgienko wrote in octave.xml:2745
> Could one word (`end`) be in several region?
> Because, in Octave, you could end `if` statement by `endif` or just `end`.
> In this variant, this syntax supported, but correct implementation also allow 
> wrong Octave sytnax, like ending `while` via `endfor` (because we are using 
> one region for them in code above).

At the moment you can't say that it opens multiple regions.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D19249: Improve highlighting of TypeScript (and React) and add more tests for PHP

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:df1afdbedcbf: Improve highlighting of TypeScript (and 
React) and add more tests for PHP (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19249?vs=52372=52454

REVISION DETAIL
  https://phabricator.kde.org/D19249

AFFECTED FILES
  autotests/folding/highlight.js.fold
  autotests/folding/highlight.php.fold
  autotests/folding/test.js.fold
  autotests/folding/test.jsx.fold
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/highlight.php.html
  autotests/html/test.jsx.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/highlight.php
  autotests/input/test.jsx
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.js.ref
  autotests/reference/highlight.php.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.qml.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19215: Install DefinitionDownloader header

[Christoph Cullmann]

cullmann added a comment.


  I would have no issues with this if Volker is ok, too.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19215

To: davschul, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D19278: Make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R279 ThreadWeaver

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19278

AFFECTED FILES
  CMakeLists.txt
  autotests/JobTests.cpp
  benchmarks/QueueBenchmarks.cpp
  examples/ThumbNailer/Model.cpp
  src/weaver.cpp
  src/weaver_p.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

[Benjamin ROBIN]

benjaminrobin added a comment.


  In D19256#418577 , @ngraham wrote:
  
  > Feels like we should close this as well as the bug report ...
  
  
  I am agree with you, but this patch still fix 2 very minor issues :
  
  - `resizeFrame(QSize(` was used instead of `resizeFrame(QSizeF(`
  - In the creation of the variable `QSize frameSize` the `width()` and 
`height()` were implicitly converted from qreal to int (QtCreator is not happy 
with it)
  
  So I can update this patch to only reflect these 2 minors changes, or forget 
them...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19256

To: benjaminrobin, #plasma
Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:a2ebf9dd3b51: Skip base64 encoding of QDataStream, avoid 
temporary QByteArray (authored by bruns).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19202?vs=52210=52451

REVISION DETAIL
  https://phabricator.kde.org/D19202

AFFECTED FILES
  autotests/extractortest.cpp
  src/extractor.cpp
  src/indexeddataretriever.cpp

To: bruns, #frameworks, #baloo, astippich, ngraham
Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:0c782040b212: Let tests use the 
baloo_filemetadata_temp_extractor from the build dir (authored by bruns).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19268?vs=52419=52450

REVISION DETAIL
  https://phabricator.kde.org/D19268

AFFECTED FILES
  autotests/CMakeLists.txt

To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko
Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19202

To: bruns, #frameworks, #baloo, astippich, ngraham
Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Great catch!

REPOSITORY
  R824 Baloo Widgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19268

To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko
Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19256

To: benjaminrobin, #plasma
Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

D19256: [RFC] height or width of FrameSvgItem can be set to a negative number, handle it..

[Nathaniel Graham]

ngraham added a comment.


  Why is this number negative though? That seems wrong. The bug report seems to 
indicate that Qt is returning a garbage value: 
https://bugreports.qt.io/browse/QTBUG-73691
  
  There's even a patch: https://codereview.qt-project.org/#/c/254226/
  
  Feels like we should close this as well as the bug report and focus on the Qt 
fix (assuming that's the right approach).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19256

To: benjaminrobin, #plasma
Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/36/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Feb 2019 15:47:32 +
 Build duration:
7 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/35/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Feb 2019 15:38:27 +
 Build duration:
6 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 34 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/34/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 24 Feb 2019 14:52:27 +
 Build duration:
6 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2671/3407)66%
(1750/2642)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(675/740)58%
(386/670)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(223/292)77%
(203/264)src.lib90%
(27/30)90%
(27/30)85%
(1773/2086)73%
(1161/1592)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 142 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/142/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 24 Feb 2019 14:52:27 +
 Build duration:
7 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 48 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/48/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Feb 2019 14:52:27 +
 Build duration:
1 min 57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

D19263: Add more highlighting for nested languages in markdown.

[Jos van den Oever]

vandenoever added a comment.


  done

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19263

To: vandenoever, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko updated this revision to Diff 52442.
sirgienko added a comment.


  Remove outdate Octave tests

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18734?vs=52441=52442

BRANCH
  octave

REVISION DETAIL
  https://phabricator.kde.org/D18734

AFFECTED FILES
  autotests/folding/highlight_octave.m.fold
  autotests/folding/test.octave.fold
  autotests/html/highlight_octave.m.html
  autotests/html/test.octave.html
  autotests/input/highlight_octave.m
  autotests/input/highlight_octave.m.syntax
  autotests/input/test.octave
  autotests/reference/highlight_octave.m.ref
  autotests/reference/test.octave.ref
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko updated this revision to Diff 52441.
sirgienko added a comment.


  Add tests for Octave highlighting

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18734?vs=50963=52441

BRANCH
  octave

REVISION DETAIL
  https://phabricator.kde.org/D18734

AFFECTED FILES
  autotests/folding/test.octave.fold
  autotests/html/highlight_octave.m.html
  autotests/html/test.octave.html
  autotests/input/highlight_octave.m
  autotests/input/highlight_octave.m.syntax
  autotests/input/test.octave
  autotests/reference/test.octave.ref
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D19263: Add more highlighting for nested languages in markdown.

[Dominik Haumann]

dhaumann added a comment.


  Well, if it's fixed by adding the missing reference update then please do so.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19263

To: vandenoever, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D19255: WIP: Alternate approach to D19253

[Roman Gilg]

romangg added a comment.


  Also CCBUG: 400987

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19255

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D19255: WIP: Alternate approach to D19253

[Roman Gilg]

romangg added a comment.


  Maybe add a TODO comment on merge to the setLogicalSize (that it does not 
handle the size plus scale change correctly in every case).

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19255

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D19255: WIP: Alternate approach to D19253

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  I just tested it and it works. As you said in D19253 
 has same caveat as I pointed out not being 
in sync with wl_output::done event in case resolution and scale factor change 
at the same time such that logical size stays the same.
  
  But let's merge this patch, which is nicer than my solution in D19253 
, as a quick fix for every other case.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19255

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/33/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 24 Feb 2019 11:38:45 +
 Build duration:
2 min 20 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2670/3407)66%
(1749/2642)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(674/740)57%
(385/670)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(223/292)77%
(203/264)src.lib90%
(27/30)90%
(27/30)85%
(1773/2086)73%
(1161/1592)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/39/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 24 Feb 2019 11:38:45 +
 Build duration:
2 min 29 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2671/3407)66%
(1750/2642)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(675/740)58%
(386/670)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(223/292)77%
(203/264)src.lib90%
(27/30)90%
(27/30)85%
(1773/2086)73%
(1161/1592)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/47/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Feb 2019 11:38:45 +
 Build duration:
1 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test

D19271: Make it compiles without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

REPOSITORY
  R238 KDocTools

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19271

AFFECTED FILES
  CMakeLists.txt
  src/xslt.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19103: Middle-elide very long filenames in error strings

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> job_error.cpp:30
>  
> +static const int maxFilePathLength = 80;
> +

Maybe it's worth using the `s_` prefix here.

REPOSITORY
  R241 KIO

BRANCH
  squeeze-very-long-filenames (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19103

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D19258: Do not print indent lines

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:b11afe5a1438: Do not print indent lines (authored by 
dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19258?vs=52389=52434#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19258?vs=52389=52434

REVISION DETAIL
  https://phabricator.kde.org/D19258

AFFECTED FILES
  src/render/katerenderer.cpp

To: dhaumann, loh.tar
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19263: Add more highlighting for nested languages in markdown.

[Jos van den Oever]

vandenoever added a comment.


  I see that one test fails after committing this patch. The example output was 
modified by `/autotests/update-reference-data.sh` but I did not submit it. I 
thought it was not related to the markdown change.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19263

To: vandenoever, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 140 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/140/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 24 Feb 2019 09:21:54 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 32 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/32/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 24 Feb 2019 09:21:54 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2670/3407)66%
(1749/2642)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(674/740)57%
(385/670)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(223/292)77%
(203/264)src.lib90%
(27/30)90%
(27/30)85%
(1773/2086)73%
(1161/1592)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 38 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/38/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 24 Feb 2019 09:21:54 +
 Build duration:
2 min 25 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)81%
(34/42)81%
(34/42)78%
(2671/3407)66%
(1750/2642)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(675/740)58%
(386/670)examples0%
(0/2)0%
(0/2)0%
(0/204)0%
(0/88)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(223/292)77%
(203/264)src.lib90%
(27/30)90%
(27/30)85%
(1773/2086)73%
(1161/1592)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 46 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/46/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 24 Feb 2019 09:21:54 +
 Build duration:
1 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.folding_test

D19263: Add more highlighting for nested languages in markdown.

[Jos van den Oever]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:bbb5188d9e12: Add more highlighting for nested languages 
in markdown. (authored by vandenoever).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19263?vs=52430=52431

REVISION DETAIL
  https://phabricator.kde.org/D19263

AFFECTED FILES
  autotests/folding/test.markdown.fold
  autotests/html/test.markdown.html
  autotests/input/test.markdown
  autotests/reference/test.markdown.ref
  data/syntax/markdown.xml

To: vandenoever, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D19263: Add more highlighting for nested languages in markdown.

[Jos van den Oever]

vandenoever updated this revision to Diff 52430.
vandenoever added a comment.


  Increased kateversion to 5.0.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19263?vs=52410=52430

BRANCH
  nested (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19263

AFFECTED FILES
  autotests/folding/test.markdown.fold
  autotests/html/test.markdown.html
  autotests/input/test.markdown
  autotests/reference/test.markdown.ref
  data/syntax/markdown.xml

To: vandenoever, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D19251: Make it compiles without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:ff2240350387: Make it compiles without foreach (authored 
by mlaurent).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19251?vs=52377=52426

REVISION DETAIL
  https://phabricator.kde.org/D19251

AFFECTED FILES
  CMakeLists.txt
  autotests/karchivetest.cpp
  autotests/kcompressiondevicetest.cpp
  src/k7zip.cpp
  src/krcc.cpp
  tests/kziptest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19251: Make it compiles without foreach

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Ah, no, you're right.
  
  I remembered that there was a problem with function calls (rvalues) but that 
problem is not what I thought, it's the fact that one can't write 
qAsConst(myFunc()) (because the return value gets destroyed before it's used).
  But if the rvalue is const already, no problem.

REPOSITORY
  R243 KArchive

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19251

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns