KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/43/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 14 Mar 2019 04:38:55 +
 Build duration:
27 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13347)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(301/2266)7%
(97/1466)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(299/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 Mar 2019 04:38:55 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3610/13347)18%
(1819/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(301/2266)7%
(97/1466)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/47/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 14 Mar 2019 04:38:55 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 82 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/82/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 14 Mar 2019 04:37:32 +
 Build duration:
6 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/74/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 14 Mar 2019 04:37:32 +
 Build duration:
5 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/51/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 Mar 2019 04:37:32 +
 Build duration:
2 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53848.
chinmoyr marked 3 inline comments as done.
chinmoyr added a comment.


  Issues fixed.

REPOSITORY
  R373 Image Thumbnailers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19696?vs=53820=53848

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19696

AFFECTED FILES
  CMakeLists.txt
  blend/CMakeLists.txt
  blend/blendercreator.cpp
  blend/blendercreator.h
  blend/blenderthumbnail.desktop

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> bruns wrote in blendercreator.cpp:134
> So does the code I linked to. No need to cook your own.

Ah, sorry. I misunderstood what was written in doc. It really does swap them.

REPOSITORY
  R373 Image Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis added a comment.


  In D17469#430647 , @ngraham wrote:
  
  > Hmm, I see what you mean. Okay, let's go with this one!
  >
  > BTW, the duplicate test fails as of 
f2509047d4372f1a59d8f8b5ff009146f1a6adcb 
:
  >
  >   * Start testing of DupeTest *
  >   Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 7.3.0)
  >   PASS   : DupeTest::initTestCase()
  >   FAIL!  : DupeTest::test_duplicates() 
  > The following files are duplicates but not links:
  >   - /home/dev/kde/src/breeze-icons/icons/actions/22/go-up.svg
  >   - /home/dev/kde/src/breeze-icons/icons/actions/24/go-up.svg
  >  
  >  Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]
  >   FAIL!  : DupeTest::test_duplicates() 
  > The following files are duplicates but not links:
  >   - /home/dev/kde/src/breeze-icons/icons-dark/actions/22/go-up.svg
  >   - /home/dev/kde/src/breeze-icons/icons-dark/actions/24/go-up.svg
  >  
  >  Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]
  >
  >
  > Do you think you could fix that after landing this?
  
  
  Looks like I forgot to make the icon actually 24 px when I copied in the 22px 
version. I'll be sure to fix that.
  
  I should probably also update the 64px device icons for gamepads to match 
this.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19734: Fix compilation with Android API level >= 26

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19734

To: vkrause, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

T10262: Integrate KIO Slaves into file system using FUSE gateway

[Nathaniel Graham]

ngraham added a subscriber: fvogt.
ngraham added a comment.


  I'm not involved in GSoC this year but maybe you can talk to @fvogt about it. 
I think he may have already started the work, but might appreciate extra eyes 
and fingers! :)

TASK DETAIL
  https://phabricator.kde.org/T10262

To: cfeck, ngraham
Cc: fvogt, feverfew, #frameworks, ngraham, #dolphin, cfeck, alexde, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D17469: Give applications-games more contrast with Breeze Dark

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Hmm, I see what you mean. Okay, let's go with this one!
  
  BTW, the duplicate test fails as of f2509047d4372f1a59d8f8b5ff009146f1a6adcb 
:
  
* Start testing of DupeTest *
Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64 
shared (dynamic) release build; by GCC 7.3.0)
PASS   : DupeTest::initTestCase()
FAIL!  : DupeTest::test_duplicates() 
  The following files are duplicates but not links:
- /home/dev/kde/src/breeze-icons/icons/actions/22/go-up.svg
- /home/dev/kde/src/breeze-icons/icons/actions/24/go-up.svg

   Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]
FAIL!  : DupeTest::test_duplicates() 
  The following files are duplicates but not links:
- /home/dev/kde/src/breeze-icons/icons-dark/actions/22/go-up.svg
- /home/dev/kde/src/breeze-icons/icons-dark/actions/24/go-up.svg

   Loc: [/home/dev/kde/src/breeze-icons/autotests/testhelpers.h(42)]
  
  Do you think you could fix that after landing this?

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

T10262: Integrate KIO Slaves into file system using FUSE gateway

[Alexander Saoutkin]

feverfew added a comment.


  @ngraham I'll be having some free time this summer. I was thinking if we 
could solidify this task into exactly what we need to do so we can get a 
proposal in for GSoC?

TASK DETAIL
  https://phabricator.kde.org/T10262

To: cfeck, feverfew
Cc: feverfew, #frameworks, ngraham, #dolphin, cfeck, alexde, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis added a comment.


  In D17469#430616 , @ngraham wrote:
  
  > No room? Instead of widening the grips by one pixel to make room for the 
contrast border, how about building it in, effectively narrowing the grips by 
one pixel?
  
  
  That's what I had in mind to begin with when you said to add a border. It 
just doesn't look right. There's no controller in existence that looks like 
that.
  F669: Screenshot_20190313_194137.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19743: FrameSvgItem: catch margin changes of FrameSvg also outside own methods

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  FrameSvg updates the margins e.g. on a Theme change already in its
  internal event handling before the methods of FrameSvgItem are invoked.
  Due to that CheckMarginsChange guards before this change could not detect
  any changes, and thus missed to trigger an update via the margin objects
  to the QtQuick world.
  
  So when changing the theme e.g. in a Plasma shell or in the Plasma Theme
  Explorer, existing FrameSvg items are using outdated margins, resulting
  in broken display.
  
  By keeping a copy of the last seen margins as part of the item and not only
  per method, changes outside the FrameSvgItem items can be properly detected.

TEST PLAN
  Switch Plasma themes between Air, Breeze & Oxygen, see how different margins
  are reflected in the widgets sizes instantly.
  Switch Plasma themes in the Plasma Theme Explorer, with "Show Margins"
  enabled, see how margins are always correctly updated intead of taking the
  value of the last theme used.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  catchSvgFrameMarginChangesOnThemeChange

REVISION DETAIL
  https://phabricator.kde.org/D19743

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp
  src/declarativeimports/core/framesvgitem.h

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Nathaniel Graham]

ngraham added a comment.


  No room? Instead of widening the grips by one pixel to make room for the 
contrast border, how about building it in, effectively narrowing the grips by 
one pixel?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis updated this revision to Diff 53839.
ndavis added a comment.


  Darken the handle grips

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17469?vs=53836=53839

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

AFFECTED FILES
  icons-dark/categories/32/applications-games.svg
  icons/categories/32/applications-games.svg

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis added a comment.


  In D17469#430573 , @ngraham wrote:
  
  > Better, but the dark parts of the dark version still disappear against a 
dark background. Most of the time we solve this with a transparent outline (we 
did this for the clock icon recently), and I think that could work well here 
too.
  
  
  No, there are too many details and not enough room. It worked for the clock 
icon because a lot of clocks have a frame like that around them.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D18664: Baloo engine: treat every non-success code as a failure

[Valeriy Malov]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:eb68430ae5f4: Baloo engine: treat every non-success code 
as a failure (authored by valeriymalov).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18664?vs=53608=53838#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18664?vs=53608=53838

REVISION DETAIL
  https://phabricator.kde.org/D18664

AFFECTED FILES
  src/engine/database.cpp
  src/engine/documentdatadb.cpp
  src/engine/documentdb.cpp
  src/engine/documentiddb.cpp
  src/engine/documenttimedb.cpp
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/fsutils.cpp
  src/engine/idfilenamedb.cpp
  src/engine/idtreedb.cpp
  src/engine/mtimedb.cpp
  src/engine/phraseanditerator.cpp
  src/engine/positiondb.cpp
  src/engine/postingdb.cpp
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractorprocess.cpp
  src/file/fileindexscheduler.cpp
  src/file/indexcleaner.cpp
  src/file/main.cpp
  src/file/metadatamover.cpp

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, abrahams

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis added a comment.


  In D19736#430545 , @ngraham wrote:
  
  > Hmm, TBH it feels too busy for me, especially at the smaller sizes. I 
wonder if it might benefit from using a single circular line with an arrowhead 
instead, like this comically crude mockup illustrates: F6689810: 
Screenshot_20190313_150037.png 
  
  
  Unfortunately, there's just not enough space for that kind of icon at 16px. 
The screen in the icon has to be way too small, the arrow(s) has to be small 
enough that it turns into noise in the `off` version, the arrow has to make the 
icon weirdly uncentered or I need to forget about respecting the margins.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 33 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/33/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 13 Mar 2019 21:50:55 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.57.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.integration.querytestFailed: projectroot.autotests.integration.writetransactiontestName: projectroot.autotests.unit Failed: 4 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.engine.transactiontestFailed: projectroot.autotests.unit.file.filewatchtestFailed: projectroot.autotests.unit.file.metadatamovertestFailed: projectroot.autotests.unit.lib.filefetchjobtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report39%
(9/23)48%
(81/168)48%
(81/168)42%
(3961/9503)29%
(1587/5392)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration0%
(0/3)0%
(0/3)0%
(0/400)0%
(0/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine94%
(16/17)94%
(16/17)95%
(715/750)54%
(208/382)autotests.unit.file82%
(9/11)82%
(9/11)74%
(666/900)44%
(235/530)autotests.unit.lib50%
(3/6)50%
(3/6)80%
(329/411)42%
(77/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine70%
(26/37)70%
(26/37)48%
(1035/2172)34%
(430/1275)src.file32%
(12/38)32%
(12/38)31%
(518/1657)29%
(309/1074)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib45%
(5/11)45%
(5/11)47%
(440/943)43%
 

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/26/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 13 Mar 2019 21:50:55 +
 Build duration:
3 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.57.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.integration.querytestFailed: projectroot.autotests.integration.writetransactiontestName: projectroot.autotests.unit Failed: 5 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.engine.transactiontestFailed: projectroot.autotests.unit.file.filewatchtestFailed: projectroot.autotests.unit.file.kinotifytestFailed: projectroot.autotests.unit.file.metadatamovertestFailed: projectroot.autotests.unit.lib.filefetchjobtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report39%
(9/23)48%
(81/168)48%
(81/168)41%
(3939/9503)29%
(1572/5392)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration0%
(0/3)0%
(0/3)0%
(0/400)0%
(0/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine94%
(16/17)94%
(16/17)95%
(715/750)54%
(208/382)autotests.unit.file82%
(9/11)82%
(9/11)72%
(644/900)42%
(221/530)autotests.unit.lib50%
(3/6)50%
(3/6)80%
(329/411)42%
(77/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine70%
(26/37)70%
(26/37)48%
(1035/2172)34%
(430/1275)src.file32%
(12/38)32%
(12/38)31%
(518/1657)29%
(308/1074)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib45%
(5/11)45%
(5/11)47%

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 33 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/33/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 13 Mar 2019 21:50:55 +
 Build duration:
2 min 8 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.integration.querytestFailed: projectroot.autotests.integration.writetransactiontestName: projectroot.autotests.unit Failed: 4 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.engine.transactiontestFailed: projectroot.autotests.unit.file.filewatchtestFailed: projectroot.autotests.unit.file.metadatamovertestFailed: projectroot.autotests.unit.lib.filefetchjobtest

D17469: Give applications-games more contrast with Breeze Dark

[Nathaniel Graham]

ngraham added a comment.


  Better, but the dark parts of the dark version still disappear against a dark 
background. Most of the time we solve this with a transparent outline (we did 
this for the clock icon recently), and I think that could work well here too.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis retitled this revision from "applications-games icon for dark theme" to 
"Give applications-games more contrast with Breeze Dark".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: applications-games icon for dark theme

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: applications-games icon for dark theme

[Noah Davis]

ndavis updated this revision to Diff 53836.
ndavis added a comment.


  Change style for Breeze and Breeze Dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17469?vs=47254=53836

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

AFFECTED FILES
  icons-dark/categories/32/applications-games.svg
  icons/categories/32/applications-games.svg

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19736: Add screen-rotate-auto-on/off

[Nathaniel Graham]

ngraham added a comment.


  Hmm, TBH it feels too busy for me, especially at the smaller sizes. I wonder 
if it might benefit from using a single circular line with an arrowhead 
instead, like this comically crude mockup illustrates: F6689810: 
Screenshot_20190313_150037.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

[Nikita Sirgienko]

sirgienko closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19570

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

[Noah Davis]

ndavis added a comment.


  We did agree to have Qt and GTK settings separate in T8871 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

[Nathaniel Graham]

ngraham added a comment.


  In D19733#430500 , @ndavis wrote:
  
  > I don't think the light/dark window background looks good. It also gives 
the wrong message because the Colors KCM is what controls the window background 
color. The Window Decoration KCM icon has the same issue, but that already 
exists. Perhaps you should put buttons or sliders on the icon instead of using 
alternating background. That, or you could stick to keeping the Qt and GTK 
widget style KCMs separate and use symbolism for Qt/KDE and GTK/GNOME on 2 
different icons.
  
  
  I would tend to agree.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

[Noah Davis]

ndavis added a comment.


  BTW, when you change an icon into a symlink or vice versa, can you delete the 
icon you're changing in a separate commit and then add the new version of the 
icon? `arc patch` doesn't work when a file has been changed from or to a 
symlink.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19696: Add blender thumbnailer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> blendercreator.cpp:67
> +QPointer gzFile;
> +if(file.peek(2).startsWith("\x1F\x8B")) { // gzip magic (each gzip 
> member starts with ID1(0x1f) and ID2(0x8b))
> +file.close();

This requires a comment, stating gzip compression is optional.

> blendercreator.cpp:85
> +
> +// Example header: "BLENDER-257"
> +

Still wrong, "BLENDER-v257", missing 'v'/'V'

> blendercreator.cpp:105
> +if(isLittleEndian) {
> +blendStream.setByteOrder(QDataStream::LittleEndian);
> +} else {

Not relevant, as you only read using `readRawData()`

> blendercreator.cpp:110
> +
> +auto toInt32 = [isLittleEndian](const QByteArray ) -> qint32 {
> +return isLittleEndian ? qFromLittleEndian(bytes.constData())

Coding style, no trailing return type.

> chinmoyr wrote in blendercreator.cpp:134
> I am trying to swap bgr to rgb here.

So does the code I linked to. No need to cook your own.

REPOSITORY
  R373 Image Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

[Noah Davis]

ndavis added a comment.


  I don't think the light/dark window background looks good. It also gives the 
wrong message because the Colors KCM is what controls the Window background. 
The Window Decoration KCM icon has the same issue, but that already exists. 
Perhaps you should put buttons or sliders on the icon instead of using 
alternating background.s

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ndavis, kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19408: [RFC] Avoid deadlock in use of vi mode searchbar

[loh tar]

loh.tar added a comment.


  OK. I spend some time again, but give up now. 
  I've got the feeling that these key event handling is not very well 
engineered.
  May someone else take a closer look for some better solution, or at least try 
this patch, if it breaks some other functionality.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19408

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis updated this revision to Diff 53826.
ndavis edited the test plan for this revision.
ndavis added a comment.


  - Increase spacing between outside rotation marks and screen

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19736?vs=53825=53826

BRANCH
  rotate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19736

AFFECTED FILES
  icons-dark/actions/16/screen-rotate-auto-off.svg
  icons-dark/actions/16/screen-rotate-auto-on.svg
  icons-dark/actions/22/screen-rotate-auto-off.svg
  icons-dark/actions/22/screen-rotate-auto-on.svg
  icons-dark/actions/32/screen-rotate-auto-off.svg
  icons-dark/actions/32/screen-rotate-auto-on.svg
  icons-dark/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons-dark/actions/symbolic/screen-rotate-auto-on-symbolic.svg
  icons/actions/16/screen-rotate-auto-off.svg
  icons/actions/16/screen-rotate-auto-on.svg
  icons/actions/22/screen-rotate-auto-off.svg
  icons/actions/22/screen-rotate-auto-on.svg
  icons/actions/32/screen-rotate-auto-off.svg
  icons/actions/32/screen-rotate-auto-on.svg
  icons/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons/actions/symbolic/screen-rotate-auto-on-symbolic.svg

To: ndavis, #vdg, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19736: Add screen-rotate-auto-on/off

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Screen auto rotate icons for D19690 

REPOSITORY
  R266 Breeze Icons

BRANCH
  rotate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19736

AFFECTED FILES
  icons-dark/actions/16/screen-rotate-auto-off.svg
  icons-dark/actions/16/screen-rotate-auto-on.svg
  icons-dark/actions/22/screen-rotate-auto-off.svg
  icons-dark/actions/22/screen-rotate-auto-on.svg
  icons-dark/actions/32/screen-rotate-auto-off.svg
  icons-dark/actions/32/screen-rotate-auto-on.svg
  icons-dark/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons-dark/actions/symbolic/screen-rotate-auto-on-symbolic.svg
  icons/actions/16/screen-rotate-auto-off.svg
  icons/actions/16/screen-rotate-auto-on.svg
  icons/actions/22/screen-rotate-auto-off.svg
  icons/actions/22/screen-rotate-auto-on.svg
  icons/actions/32/screen-rotate-auto-off.svg
  icons/actions/32/screen-rotate-auto-on.svg
  icons/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons/actions/symbolic/screen-rotate-auto-on-symbolic.svg

To: ndavis, #vdg, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53820.
chinmoyr marked 4 inline comments as done.
chinmoyr added a comment.


  Moved to kdegraphics-thumbnailer
  Got rid of operator>>() and fixed other issues.

REPOSITORY
  R373 Image Thumbnailers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19696?vs=53699=53820

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19696

AFFECTED FILES
  CMakeLists.txt
  blend/CMakeLists.txt
  blend/blendercreator.cpp
  blend/blendercreator.h
  blend/blenderthumbnail.desktop

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> bruns wrote in blendercreator.cpp:57
> I think this is already done by the calling code - the thumbnailer gets only 
> called when the mimetype matches.

This part is required because blender can save files with gzip compression. 
Examples here :   https://download.blender.org/demo/test/Demo_274.zip. For some 
of them properties dialog shows "Contents: application/gzip".

> bruns wrote in blendercreator.cpp:101
> Does this mean 'size of header fields 1 to 5'?

yes

> bruns wrote in blendercreator.cpp:134
> https://doc.qt.io/qt-5/qimage.html#rgbSwapped-1

I am trying to swap bgr to rgb here.

REPOSITORY
  R373 Image Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icons

[Björn Feber]

GB_2 retitled this revision from "Add preferences-desktop-theme-applications 
and preferences-desktop-theme-windowborders icon" to "Add 
preferences-desktop-theme-applications and 
preferences-desktop-theme-windowborders icons".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19734: Fix compilation with Android API level >= 26

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Starting with API level 26, these methods are actually available and we
  don't need our dummy declarations anymore.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19734

AFFECTED FILES
  src/lib/util/kuser_unix.cpp

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowborders icon

[Björn Feber]

GB_2 retitled this revision from "Add preferences-desktop-theme-applications 
icon" to "Add preferences-desktop-theme-applications and 
preferences-desktop-theme-windowborders icon".
GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-applications icon

[Björn Feber]

GB_2 retitled this revision from "Add preferences-desktop-theme-windows icon" 
to "Add preferences-desktop-theme-applications icon".
GB_2 edited the summary of this revision.
GB_2 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-windows icon

[Björn Feber]

GB_2 updated this revision to Diff 53813.
GB_2 added a comment.


  Rename files and make icons more accurate

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19733?vs=53811=53813

BRANCH
  add-preferences-desktop-theme-windows-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19733

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-theme-applications.svg
  icons-dark/preferences/32/preferences-desktop-theme-windowdecorations.svg
  icons-dark/preferences/32/preferences-desktop-theme.svg
  icons/preferences/32/preferences-desktop-theme-applications.svg
  icons/preferences/32/preferences-desktop-theme-windowdecorations.svg
  icons/preferences/32/preferences-desktop-theme.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-windows icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-windows icon

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Adds an application style icon, adds a symlink and renames the old one to 
"preferences-desktop-theme-windows-borders".

TEST PLAN
  Search for "preferences-desktop-theme-windows" in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-preferences-desktop-theme-windows-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19733

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-theme-windows-borders.svg
  icons-dark/preferences/32/preferences-desktop-theme-windows.svg
  icons-dark/preferences/32/preferences-desktop-theme.svg
  icons/preferences/32/preferences-desktop-theme-windows-borders.svg
  icons/preferences/32/preferences-desktop-theme-windows.svg
  icons/preferences/32/preferences-desktop-theme.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19338: New location for KNSRC files

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Works great, thanks.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19338

To: leinir, #knewstuff, apol, ngraham, fvogt
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19500: [KDirModel] Fix job urls change signal connection

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19500

To: broulik, #frameworks, dfaure, jtamate
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19732: [KWidgetAddons] Fix build with Qt 5.13

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19732

To: matthieugras, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17469: applications-games icon for dark theme

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: guoyunhe; removed: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19732: [KWidgetAddons] Fix build with Qt 5.13

[Matthieu Gras]

matthieugras created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
matthieugras requested review of this revision.

REVISION SUMMARY
  QColor::dark(bool) is deprecated

TEST PLAN
  compiles

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19732

AFFECTED FILES
  src/kled.cpp

To: matthieugras
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19728: [GridViewKCM] Fix implicit width calculation

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:72f438f8e7ad: [GridViewKCM] Fix implicit width 
calculation (authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19728?vs=53799=53800

REVISION DETAIL
  https://phabricator.kde.org/D19728

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19728: [GridViewKCM] Fix implicit width calculation

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19728

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19728: [GridViewKCM] Fix implicit width calculation

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Take into account paddings around the page and scroll view and also use the 
correct grid delegate size

TEST PLAN
  Opened colors KCM, size was correct to the pixel now. Resized the window 
smaller a single pixel and it wrapped the delegates into two columns
  Initial size before
  F6688642: Screenshot_20190313_154950.png 

  Initial size after
  F6688643: Screenshot_20190313_155027.png 


REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19728

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19728: [GridViewKCM] Fix implicit width calculation

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19728

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/16/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 13 Mar 2019 14:42:13 +
 Build duration:
5 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.57.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1615/)51%
(1020/2012)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)48%
(210/434)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(561/758)63%
(532/845)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/531)34%
(177/522)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/13/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 13 Mar 2019 14:42:13 +
 Build duration:
2 min 14 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Package-5.57.0.xmlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1615/)51%
(1020/2012)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)48%
(210/434)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(561/758)63%
(532/845)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/531)34%
(177/522)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 13 Mar 2019 14:42:13 +
 Build duration:
57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

D19719: [kpackages] compile without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:2dd8e902e539: [kpackages] compile without foreach 
(authored by mlaurent).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19719?vs=53768=53796

REVISION DETAIL
  https://phabricator.kde.org/D19719

AFFECTED FILES
  CMakeLists.txt
  autotests/packagestructuretest.cpp
  src/kpackage/package.cpp
  src/kpackage/packageloader.cpp
  src/kpackage/private/packagejobthread.cpp
  src/kpackagetool/kpackagetool.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19718: [kiconthemes] compiles without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:2603a8ac4da6: [kiconthemes] compiles without foreach 
(authored by mlaurent).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19718?vs=53767=53795

REVISION DETAIL
  https://phabricator.kde.org/D19718

AFFECTED FILES
  CMakeLists.txt
  src/kiconloader.cpp
  src/kicontheme.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19338: New location for KNSRC files

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19338

To: leinir, #knewstuff, apol, ngraham, fvogt
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19719: [kpackages] compile without foreach

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  fix_compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19719

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19718: [kiconthemes] compiles without foreach

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19718

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  configfileextensions

REVISION DETAIL
  https://phabricator.kde.org/D19565

To: kossebau, #frameworks, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19408: [RFC] Avoid deadlock in use of vi mode searchbar

[loh tar]

loh.tar added a comment.


  hm, it may better to avoid to call that function at all in case of Ctrl-F (?) 
Will take a look.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19408

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D19408: [RFC] Avoid deadlock in use of vi mode searchbar

[Christoph Cullmann]

cullmann added a comment.


  I am unsure about the toplevel &&, wouldn't one just want that for the return 
case?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19408

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D19338: New location for KNSRC files

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Quick ping, be good to get this in sometime before it becomes late again... :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19338

To: leinir, #knewstuff, apol, ngraham, fvogt
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R288:4f4298539104: [KUiServerJobTracker] Update destUrl before 
finishing the job (authored by broulik).

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19583?vs=53343=53780

REVISION DETAIL
  https://phabricator.kde.org/D19583

AFFECTED FILES
  src/kuiserverjobtracker.cpp

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17469: applications-games icon for dark theme

[Yunhe Guo]

guoyunhe added a comment.


  In D17469#429992 , @ndavis wrote:
  
  > @guoyunhe Do you mind if I commandeer this?
  
  
  Go ahead!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: guoyunhe, #breeze, #vdg, ndavis
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19719: [kpackages] compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R290 KPackage

BRANCH
  fix_compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19719

AFFECTED FILES
  CMakeLists.txt
  autotests/packagestructuretest.cpp
  src/kpackage/package.cpp
  src/kpackage/packageloader.cpp
  src/kpackage/private/packagejobthread.cpp
  src/kpackagetool/kpackagetool.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19718: [kiconthemes] compiles without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R302 KIconThemes

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19718

AFFECTED FILES
  CMakeLists.txt
  src/kiconloader.cpp
  src/kicontheme.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns