D19778: [kitemmodels] make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  make it compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R275 KItemModels

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19778

AFFECTED FILES
  CMakeLists.txt
  autotests/proxymodeltestsuite/dynamictreemodel.cpp
  autotests/proxymodeltestsuite/modeleventlogger.cpp
  autotests/proxymodeltestsuite/modeleventlogger.h
  autotests/proxymodeltestsuite/modelspy.cpp
  autotests/proxymodeltestsuite/modelspy.h
  autotests/proxymodeltestsuite/proxymodeltest.cpp
  autotests/proxymodeltestsuite/proxymodeltest.h
  autotests/test_model_helpers.h
  src/kbreadcrumbselectionmodel.cpp
  src/kcheckableproxymodel.cpp
  src/kconcatenaterowsproxymodel.cpp
  src/kdescendantsproxymodel.cpp
  src/kextracolumnsproxymodel.cpp
  src/klinkitemselectionmodel.cpp
  src/kmodelindexproxymapper.cpp
  src/krecursivefilterproxymodel.cpp
  src/kselectionproxymodel.cpp
  tests/proxymodeltestapp/breadcrumbswidget.cpp
  tests/proxymodeltestapp/kreparentingproxymodel.cpp
  tests/proxymodeltestapp/matchcheckingwidget.cpp
  tests/proxymodeltestapp/modelcommanderwidget.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Björn Feber]

GB_2 updated this revision to Diff 53936.
GB_2 added a comment.


  Use old style for preferences-desktop-theme-windowdecorations

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19733?vs=53883&id=53936

BRANCH
  arcpatch-D19733

REVISION DETAIL
  https://phabricator.kde.org/D19733

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-theme-applications.svg
  icons-dark/preferences/32/preferences-desktop-theme-windowdecorations.svg
  icons/preferences/32/preferences-desktop-theme-applications.svg
  icons/preferences/32/preferences-desktop-theme-windowdecorations.svg

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19565: kconfig_compiler: new kcfgc args HeaderExtension & SourceExtension

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:a3ed87ca7808: kconfig_compiler: new kcfgc args 
HeaderExtension & SourceExtension (authored by kossebau).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19565?vs=53299&id=53934

REVISION DETAIL
  https://phabricator.kde.org/D19565

AFFECTED FILES
  KF5ConfigMacros.cmake
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/test_fileextensions.kcfg
  autotests/kconfig_compiler/test_fileextensions.kcfgc
  autotests/kconfig_compiler/test_fileextensions_main.cxx
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/checkkcfg.pl
  src/kconfig_compiler/kconfig_compiler.cpp

To: kossebau, #frameworks, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19602: [KParts] Fix compilation for Qt 5.13

[Laurent Montel]

mlaurent added a comment.


  Ping  do you want that we commit for you ?
  Otherwise I will do it as I need this patch.

REPOSITORY
  R306 KParts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19602

To: matthieugras, apol, mlaurent
Cc: mlaurent, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19768: Fixes memory leak of ssh_session

[David Hallas]

hallas closed this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19768

To: hallas, #frameworks, sitter, aacid
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19696: Add blender thumbnailer

[Stefan Brüns]

bruns added a comment.


  Save the two nitpicks, looks good to me now.
  
  Anyone else any comments?

INLINE COMMENTS

> blendercreator.cpp:24
> +#include 
> +#include 
> +

Really required?

> blendercreator.cpp:29
> +#include 
> +#include 
> +#include 

Unused ...

REPOSITORY
  R373 Image Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added a comment.


  Now, a unit test would be nice ...

INLINE COMMENTS

> batchrenamejob.cpp:177
> +}
> +return QStringLiteral();
> +}

This should be `return QString();`, wont get any cheaper than that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb added a task: T10258: Use correct search bars and use ellipsis whenever 
needed to follow the KDE HIG.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb updated this revision to Diff 53928.
ognarb added a comment.


  Use Unicode ellipsis

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19620?vs=53906&id=53928

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

AFFECTED FILES
  src/ui/findbar/khtmlfindbar.cpp
  src/ui/findbar/khtmlfindbar_base.ui

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb planned changes to this revision.
ognarb added a comment.


  Look likes I misread a part of the HIG: Since the placeholder won’t be 
visible anymore as soon as the user types, you should only use it on standalone 
input elements, not in groups of input elements such as forms.
  
  So the change in Search and replace need to be reverted.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17469: Give applications-games and input-gaming more contrast with Breeze Dark

[Noah Davis]

ndavis retitled this revision from "Give applications-games more contrast with 
Breeze Dark" to "Give applications-games and input-gaming more contrast with 
Breeze Dark".

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D17469: Give applications-games more contrast with Breeze Dark

[Noah Davis]

ndavis updated this revision to Diff 53925.
ndavis added a comment.


  Update input-gaming and make circle around dpad and colored buttons darker

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17469?vs=53839&id=53925

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

AFFECTED FILES
  icons-dark/categories/32/applications-games.svg
  icons-dark/devices/64/input-gaming.svg
  icons/categories/32/applications-games.svg
  icons/devices/64/input-gaming.svg

To: ndavis, #breeze, #vdg, guoyunhe, ngraham
Cc: abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, bruns

D19767: Fix malloc/delete mismatch

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> kio_sftp.cpp:446
>  cPath = QFile::decodeName(sPath);
> -delete sPath;
> +free(sPath);
>  

Use ssh_string_free_char ?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19767

To: hallas, #frameworks, dfaure, sitter
Cc: aacid, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D19768: Fixes memory leak of ssh_session

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  fixes_memory_leak_of_session (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19768

To: hallas, #frameworks, sitter, aacid
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb updated this revision to Diff 53922.
ognarb added a comment.


  Use proper Unicode ellipsis

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19771?vs=53919&id=53922

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19771

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/searchbarincremental.ui
  src/search/searchbarpower.ui

To: ognarb, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb added a reviewer: VDG.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb edited the summary of this revision.
ognarb added a reviewer: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Noah Davis]

ndavis added a comment.


  In D19733#431237 , @GB_2 wrote:
  
  > In D19733#431139 , @ndavis wrote:
  >
  > > I think `preferences-desktop-theme-applications` is fine, but 
`preferences-desktop-theme-windowdecorations` looks odd with that border. 
F6691545: Screenshot_20190314_135511.png 
  >
  >
  > Well, what do you suggest? This is the most accurate design.
  
  
  I think making it the same as the current `preferences-desktop-theme` is 
fine. Then `preferences-desktop-theme` can become a symlink to 
`preferences-desktop-theme-applications`.

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  See https://hig.kde.org/style/writing/placeholder.html
  
  Also change Find -> Search in Search and replace module
  
  Screenshot: comming

TEST PLAN
  Compile and run

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19771

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/searchbarincremental.ui
  src/search/searchbarpower.ui

To: ognarb
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Björn Feber]

GB_2 added a comment.


  In D19733#431139 , @ndavis wrote:
  
  > I think `preferences-desktop-theme-applications` is fine, but 
`preferences-desktop-theme-windowdecorations` looks odd with that border. 
F6691545: Screenshot_20190314_135511.png 
  
  
  Well, what do you suggest? This is the most accurate design.

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 139 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/139/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 14 Mar 2019 19:54:01 +
 Build duration:
2 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 239 lines...][2019-03-14T19:54:44.298Z] -- Generating done[2019-03-14T19:54:44.298Z] CMake Warning:[2019-03-14T19:54:44.298Z]   Manually-specified variables were not used by the project:[2019-03-14T19:54:44.298Z] [2019-03-14T19:54:44.298Z] BUILD_QCH[2019-03-14T19:54:44.298Z] [2019-03-14T19:54:44.298Z] [2019-03-14T19:54:44.298Z] -- Build files have been written to: C:/CI/workspace/Frameworks/breeze-icons/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-03-14T19:54:45.143Z] [2019-03-14T19:54:45.143Z] C:\CI\workspace\Frameworks\breeze-icons\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat" [2019-03-14T19:54:45.143Z] **[2019-03-14T19:54:45.143Z] ** Visual Studio 2017 Developer Command Prompt v15.7.3[2019-03-14T19:54:45.143Z] ** Copyright (c) 2017 Microsoft Corporation[2019-03-14T19:54:45.143Z] **[2019-03-14T19:54:46.527Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-03-14T19:54:47.101Z] [2019-03-14T19:54:47.101Z] jom 1.1.2 - empower your cores[2019-03-14T19:54:47.101Z] [2019-03-14T19:54:47.101Z] jom: parallel job execution disabled for Makefile[2019-03-14T19:54:47.101Z] Scanning dependencies of target qrcAlias_autogen[2019-03-14T19:54:47.101Z] Scanning dependencies of target symlink_autogen[2019-03-14T19:54:47.377Z] Scanning dependencies of target newline_autogen[2019-03-14T19:54:47.377Z] Scanning dependencies of target dupe_autogen[2019-03-14T19:54:47.377Z] Scanning dependencies of target scalable_autogen[2019-03-14T19:54:47.736Z] [  8%] Automatic MOC for target qrcAlias[2019-03-14T19:54:47.736Z] Scanning dependencies of target breeze-icons-mkdir[2019-03-14T19:54:47.736Z] Scanning dependencies of target breeze-icons-dark-mkdir[2019-03-14T19:54:48.012Z] [ 20%] Built target qrcAlias_autogen[2019-03-14T19:54:48.294Z] [  4%] Automatic MOC for target symlink[2019-03-14T19:54:48.294Z] [ 12%] Automatic MOC for target newline[2019-03-14T19:54:48.294Z] [ 16%] Automatic MOC for target dupe[2019-03-14T19:54:48.294Z] [ 20%] Automatic MOC for target scalable[2019-03-14T19:54:48.294Z] [ 20%] Built target breeze-icons-mkdir[2019-03-14T19:54:48.294Z] [ 20%] Built target breeze-icons-dark-mkdir[2019-03-14T19:54:48.564Z] Scanning dependencies of target qrcAlias[2019-03-14T19:54:48.853Z] [ 20%] Built target newline_autogen[2019-03-14T19:54:48.853Z] [ 20%] Built target symlink_autogen[2019-03-14T19:54:48.853Z] [ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.obj[2019-03-14T19:54:48.853Z] [ 25%] Built target dupe_autogen[2019-03-14T19:54:48.853Z] qrcAlias.cpp[2019-03-14T19:54:48.853Z] [ 29%] Built target scalable_autogen[2019-03-14T19:54:48.853Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.obj[2019-03-14T19:54:48.853Z] mocs_compilation.cpp[2019-03-14T19:54:49.129Z] Scanning dependencies of target symlink[2019-03-14T19:54:49.129Z] Scanning dependencies of target newline[2019-03-14T19:54:49.129Z] Scanning dependencies of target dupe[2019-03-14T19:54:49.129Z] Scanning dependencies of target scalable[2019-03-14T19:54:49.418Z] [ 33%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.obj[2019-03-14T19:54:49.418Z] [ 37%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.obj[2019-03-14T19:54:49.418Z] [ 45%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.obj[2019-03-14T19:54:49.418Z] dupetest.cpp[2019-03-14T19:54:49.418Z] [ 54%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.obj[2019-03-14T19:54:49.418Z] [ 45%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.obj[2019-03-14T19:54:49.418Z] [ 58%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.obj[2019-03-14T19:54:49.418Z] newlinetest.cpp[2019-03-14T19:54:49.418Z] symlinktest.cpp[2019-03-14T19:54:49.687Z] mocs_compilation.cpp[2019-03-14T19:54:49.687Z] mocs_compilation.cpp[2019-03-14T19:54:49.687Z] mocs_compilation.cpp[2019-03-14T19:54:50.269Z] [ 66%] Linking CXX executable bin\qrcAlias.exe[2019-03-14T19:54:52.780Z] [ 70%] Linking CXX executable ..\bin\symlink.exe[2019-03-14T19:54:52.780Z] [ 75%] Linking CXX executable ..\bin\dupe.exe[2019-03-14T19:54:54.209Z] [ 83%] Linking CXX executable ..\bin\newline.exe[2019-03-14T19:54:55.150Z] [ 83%] Built target qrcAlias[2019-03-14T19:54:55.150Z] [ 54%] Building CXX object autotests/CMakeFiles/scalable.dir/scal

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 52 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/52/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 Mar 2019 19:54:01 +
 Build duration:
48 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-03-14T19:54:43.453Z] -- Detecting CXX compiler ABI info[2019-03-14T19:54:43.453Z] -- Detecting CXX compiler ABI info - done[2019-03-14T19:54:43.453Z] -- Detecting CXX compile features[2019-03-14T19:54:44.016Z] -- Detecting CXX compile features - done[2019-03-14T19:54:44.016Z] -- [2019-03-14T19:54:44.016Z] [2019-03-14T19:54:44.272Z] -- Looking for __GLIBC__[2019-03-14T19:54:44.272Z] -- Looking for __GLIBC__ - found[2019-03-14T19:54:44.272Z] -- Performing Test _OFFT_IS_64BIT[2019-03-14T19:54:44.272Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-03-14T19:54:44.272Z] -- Performing Test HAVE_DATE_TIME[2019-03-14T19:54:44.528Z] -- Performing Test HAVE_DATE_TIME - Success[2019-03-14T19:54:44.785Z] -- The following REQUIRED packages have been found:[2019-03-14T19:54:44.785Z] [2019-03-14T19:54:44.785Z]  * ECM (required version >= 5.56.0), Extra CMake Modules., [2019-03-14T19:54:44.785Z]  * Qt5Core[2019-03-14T19:54:44.785Z]  * Qt5Test[2019-03-14T19:54:44.785Z]  * Qt5 (required version >= 5.10.0)[2019-03-14T19:54:44.785Z] [2019-03-14T19:54:44.785Z] -- Configuring done[2019-03-14T19:54:45.041Z] -- Generating done[2019-03-14T19:54:45.041Z] CMake Warning:[2019-03-14T19:54:45.041Z]   Manually-specified variables were not used by the project:[2019-03-14T19:54:45.041Z] [2019-03-14T19:54:45.041Z] BUILD_QCH[2019-03-14T19:54:45.041Z] [2019-03-14T19:54:45.041Z] [2019-03-14T19:54:45.041Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-03-14T19:54:45.836Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-03-14T19:54:45.836Z] Scanning dependencies of target newline_autogen[2019-03-14T19:54:45.836Z] Scanning dependencies of target qrcAlias_autogen[2019-03-14T19:54:45.836Z] Scanning dependencies of target symlink_autogen[2019-03-14T19:54:45.836Z] Scanning dependencies of target breeze-validate-svg[2019-03-14T19:54:45.836Z] Scanning dependencies of target dupe_autogen[2019-03-14T19:54:45.836Z] Scanning dependencies of target breeze-icons-mkdir[2019-03-14T19:54:45.836Z] Scanning dependencies of target scalable_autogen[2019-03-14T19:54:45.836Z] [  4%] Automatic MOC for target newline[2019-03-14T19:54:45.836Z] [  8%] Automatic MOC for target symlink[2019-03-14T19:54:45.836Z] [ 12%] Automatic MOC for target dupe[2019-03-14T19:54:45.836Z] [ 16%] Automatic MOC for target qrcAlias[2019-03-14T19:54:45.836Z] [ 16%] Built target breeze-validate-svg[2019-03-14T19:54:45.836Z] Scanning dependencies of target breeze-icons-dark-mkdir[2019-03-14T19:54:45.836Z] [ 20%] Automatic MOC for target scalable[2019-03-14T19:54:46.091Z] [ 20%] Built target breeze-icons-mkdir[2019-03-14T19:54:46.091Z] [ 20%] Built target breeze-icons-dark-mkdir[2019-03-14T19:54:46.091Z] [ 20%] Built target qrcAlias_autogen[2019-03-14T19:54:46.091Z] Scanning dependencies of target qrcAlias[2019-03-14T19:54:46.091Z] [ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2019-03-14T19:54:46.091Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:46.091Z] [ 29%] Built target dupe_autogen[2019-03-14T19:54:46.091Z] [ 29%] Built target newline_autogen[2019-03-14T19:54:46.091Z] [ 29%] Built target symlink_autogen[2019-03-14T19:54:46.091Z] [ 29%] Built target scalable_autogen[2019-03-14T19:54:46.091Z] Scanning dependencies of target symlink[2019-03-14T19:54:46.091Z] Scanning dependencies of target newline[2019-03-14T19:54:46.091Z] Scanning dependencies of target dupe[2019-03-14T19:54:46.091Z] Scanning dependencies of target scalable[2019-03-14T19:54:46.091Z] [ 33%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:46.091Z] [ 37%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:46.091Z] [ 41%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2019-03-14T19:54:46.091Z] [ 45%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2019-03-14T19:54:46.091Z] [ 50%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2019-03-14T19:54:46.091Z] [ 54%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:46.091Z] [ 58%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[2019-03-14T19:54:46.091Z] [ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilatio

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 75 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/75/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 14 Mar 2019 19:54:01 +
 Build duration:
46 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-03-14T19:54:42.371Z] -- Detecting CXX compiler ABI info[2019-03-14T19:54:42.628Z] -- Detecting CXX compiler ABI info - done[2019-03-14T19:54:42.628Z] -- Detecting CXX compile features[2019-03-14T19:54:42.884Z] -- Detecting CXX compile features - done[2019-03-14T19:54:42.884Z] -- [2019-03-14T19:54:42.884Z] [2019-03-14T19:54:43.139Z] -- Looking for __GLIBC__[2019-03-14T19:54:43.139Z] -- Looking for __GLIBC__ - found[2019-03-14T19:54:43.139Z] -- Performing Test _OFFT_IS_64BIT[2019-03-14T19:54:43.139Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-03-14T19:54:43.139Z] -- Performing Test HAVE_DATE_TIME[2019-03-14T19:54:43.394Z] -- Performing Test HAVE_DATE_TIME - Success[2019-03-14T19:54:43.652Z] -- The following REQUIRED packages have been found:[2019-03-14T19:54:43.652Z] [2019-03-14T19:54:43.653Z]  * ECM (required version >= 5.56.0), Extra CMake Modules., [2019-03-14T19:54:43.653Z]  * Qt5Core[2019-03-14T19:54:43.653Z]  * Qt5Test[2019-03-14T19:54:43.653Z]  * Qt5 (required version >= 5.10.0)[2019-03-14T19:54:43.653Z] [2019-03-14T19:54:43.653Z] -- Configuring done[2019-03-14T19:54:43.914Z] -- Generating done[2019-03-14T19:54:43.914Z] CMake Warning:[2019-03-14T19:54:43.914Z]   Manually-specified variables were not used by the project:[2019-03-14T19:54:43.914Z] [2019-03-14T19:54:43.914Z] BUILD_QCH[2019-03-14T19:54:43.914Z] [2019-03-14T19:54:43.914Z] [2019-03-14T19:54:43.914Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-03-14T19:54:44.789Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/[2019-03-14T19:54:44.789Z] Scanning dependencies of target breeze-validate-svg[2019-03-14T19:54:44.789Z] Scanning dependencies of target qrcAlias_autogen[2019-03-14T19:54:44.789Z] Scanning dependencies of target symlink_autogen[2019-03-14T19:54:44.789Z] Scanning dependencies of target breeze-icons-mkdir[2019-03-14T19:54:44.789Z] Scanning dependencies of target dupe_autogen[2019-03-14T19:54:44.789Z] Scanning dependencies of target scalable_autogen[2019-03-14T19:54:44.789Z] Scanning dependencies of target newline_autogen[2019-03-14T19:54:44.789Z] Scanning dependencies of target breeze-icons-dark-mkdir[2019-03-14T19:54:44.789Z] [  0%] Built target breeze-validate-svg[2019-03-14T19:54:44.789Z] [  4%] Automatic MOC for target qrcAlias[2019-03-14T19:54:44.789Z] [  8%] Automatic MOC for target symlink[2019-03-14T19:54:44.789Z] [ 12%] Automatic MOC for target newline[2019-03-14T19:54:44.789Z] [ 12%] Built target breeze-icons-mkdir[2019-03-14T19:54:44.789Z] [ 16%] Automatic MOC for target dupe[2019-03-14T19:54:44.789Z] [ 20%] Automatic MOC for target scalable[2019-03-14T19:54:44.789Z] [ 20%] Built target breeze-icons-dark-mkdir[2019-03-14T19:54:45.046Z] [ 20%] Built target qrcAlias_autogen[2019-03-14T19:54:45.047Z] [ 20%] Built target dupe_autogen[2019-03-14T19:54:45.047Z] [ 20%] Built target symlink_autogen[2019-03-14T19:54:45.047Z] [ 20%] Built target newline_autogen[2019-03-14T19:54:45.047Z] Scanning dependencies of target qrcAlias[2019-03-14T19:54:45.047Z] [ 20%] Built target scalable_autogen[2019-03-14T19:54:45.047Z] [ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2019-03-14T19:54:45.047Z] Scanning dependencies of target dupe[2019-03-14T19:54:45.047Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:45.047Z] Scanning dependencies of target newline[2019-03-14T19:54:45.047Z] Scanning dependencies of target symlink[2019-03-14T19:54:45.047Z] [ 33%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2019-03-14T19:54:45.047Z] [ 37%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:45.047Z] [ 41%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:45.047Z] [ 45%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2019-03-14T19:54:45.047Z] Scanning dependencies of target scalable[2019-03-14T19:54:45.047Z] [ 50%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:45.047Z] [ 54%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2019-03-14T19:54:45.047Z] [ 58%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[2019-03-14T19:54:45.047Z] [ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilatio

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 83 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/83/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 14 Mar 2019 19:54:01 +
 Build duration:
27 sec and counting
   CONSOLE OUTPUT
  [...truncated 164 lines...][2019-03-14T19:54:21.655Z] -- Looking for __GLIBC__ - not found[2019-03-14T19:54:21.655Z] -- Performing Test _OFFT_IS_64BIT[2019-03-14T19:54:21.655Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-03-14T19:54:21.655Z] -- Performing Test HAVE_DATE_TIME[2019-03-14T19:54:21.655Z] -- Performing Test HAVE_DATE_TIME - Success[2019-03-14T19:54:22.223Z] -- The following REQUIRED packages have been found:[2019-03-14T19:54:22.223Z] [2019-03-14T19:54:22.223Z]  * ECM (required version >= 5.56.0), Extra CMake Modules., [2019-03-14T19:54:22.223Z]  * Qt5Core[2019-03-14T19:54:22.223Z]  * Qt5Test[2019-03-14T19:54:22.223Z]  * Qt5 (required version >= 5.10.0)[2019-03-14T19:54:22.223Z] [2019-03-14T19:54:22.223Z] -- Configuring done[2019-03-14T19:54:22.795Z] -- Generating done[2019-03-14T19:54:22.795Z] CMake Warning:[2019-03-14T19:54:22.795Z]   Manually-specified variables were not used by the project:[2019-03-14T19:54:22.795Z] [2019-03-14T19:54:22.795Z] BUILD_QCH[2019-03-14T19:54:22.795Z] [2019-03-14T19:54:22.795Z] [2019-03-14T19:54:22.795Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-03-14T19:54:23.552Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.12 --usingInstall /home/jenkins/install-prefix/[2019-03-14T19:54:23.812Z] Scanning dependencies of target qrcAlias_autogen[2019-03-14T19:54:23.812Z] Scanning dependencies of target breeze-validate-svg[2019-03-14T19:54:23.812Z] Scanning dependencies of target scalable_autogen[2019-03-14T19:54:23.812Z] Scanning dependencies of target breeze-icons-dark-mkdir[2019-03-14T19:54:23.812Z] Scanning dependencies of target newline_autogen[2019-03-14T19:54:23.812Z] Scanning dependencies of target dupe_autogen[2019-03-14T19:54:23.812Z] Scanning dependencies of target symlink_autogen[2019-03-14T19:54:23.812Z] Scanning dependencies of target breeze-icons-mkdir[2019-03-14T19:54:23.812Z] [  4%] Automatic MOC for target qrcAlias[2019-03-14T19:54:23.812Z] [ 16%] Automatic MOC for target symlink[2019-03-14T19:54:23.812Z] [ 16%] Automatic MOC for target newline[2019-03-14T19:54:23.812Z] [ 16%] Automatic MOC for target scalable[2019-03-14T19:54:23.812Z] [ 16%] Built target breeze-validate-svg[2019-03-14T19:54:23.812Z] [ 20%] Automatic MOC for target dupe[2019-03-14T19:54:23.812Z] [ 20%] Built target breeze-icons-dark-mkdir[2019-03-14T19:54:23.812Z] [ 20%] Built target breeze-icons-mkdir[2019-03-14T19:54:23.812Z] [ 20%] Built target qrcAlias_autogen[2019-03-14T19:54:23.812Z] Scanning dependencies of target qrcAlias[2019-03-14T19:54:23.812Z] [ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2019-03-14T19:54:23.812Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:24.070Z] [ 29%] Built target symlink_autogen[2019-03-14T19:54:24.070Z] [ 29%] Built target dupe_autogen[2019-03-14T19:54:24.070Z] [ 29%] Built target scalable_autogen[2019-03-14T19:54:24.070Z] [ 29%] Built target newline_autogen[2019-03-14T19:54:24.070Z] Scanning dependencies of target newline[2019-03-14T19:54:24.070Z] Scanning dependencies of target dupe[2019-03-14T19:54:24.070Z] Scanning dependencies of target symlink[2019-03-14T19:54:24.070Z] [ 37%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:24.070Z] [ 37%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2019-03-14T19:54:24.070Z] [ 41%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2019-03-14T19:54:24.070Z] [ 45%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:24.070Z] [ 50%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2019-03-14T19:54:24.070Z] [ 54%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:24.070Z] Scanning dependencies of target scalable[2019-03-14T19:54:24.070Z] [ 58%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[2019-03-14T19:54:24.070Z] [ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[2019-03-14T19:54:24.637Z] [ 66%] Linking CXX executable bin/qrcAlias[2019-03-14T19:54:24.637Z] [ 66%] Built target qrcAlias[2019-03-14T19:54:24.637Z] Scanning dependencies of target breeze-icons-dark-rcc[2019-03-14T19:54:24.637Z] Scanning dependencies of target breeze-icons-rcc[2019-03-14T19:54:24.637Z] [ 70%] Generating res/breeze-ico

D19767: Fix malloc/delete mismatch

[Kai Uwe Broulik]

broulik added a reviewer: sitter.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19767

To: hallas, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19768: Fixes memory leak of ssh_session

[Kai Uwe Broulik]

broulik added a reviewer: sitter.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19768

To: hallas, #frameworks, sitter
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster updated this revision to Diff 53914.
cfoster added a comment.


  - Pass QString by reference

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18915?vs=53068&id=53914

BRANCH
  arcpatch-D18915

REVISION DETAIL
  https://phabricator.kde.org/D18915

AFFECTED FILES
  src/core/batchrenamejob.cpp

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19767: Fix malloc/delete mismatch

[Anthony Fieroni]

anthonyfieroni added a reviewer: dfaure.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19767

To: hallas, #frameworks, dfaure
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19768: Fixes memory leak of ssh_session

[David Hallas]

hallas created this revision.
hallas added a reviewer: Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fixes memory leak of ssh_session. The mSession member variable is
  allocated with a call to ssh_new in sftpOpenConnection but in the
  closeConnection a call to ssh_free was missing causing the ssh_session
  to be leaked.

TEST PLAN
  Build and run kio_sftp with address sanitizer

REPOSITORY
  R320 KIO Extras

BRANCH
  fixes_memory_leak_of_session (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19768

AFFECTED FILES
  sftp/kio_sftp.cpp

To: hallas, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19767: Fix malloc/delete mismatch

[David Hallas]

hallas created this revision.
hallas added a reviewer: Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fixes pointer was allocated with malloc (by libssh) but freed with
  delete. This is not safe and causes undefined behavior.

TEST PLAN
  Build and run kio_sftp with address sanitizer

REPOSITORY
  R320 KIO Extras

BRANCH
  fix_malloc_delete_mismatch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19767

AFFECTED FILES
  sftp/kio_sftp.cpp

To: hallas, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb updated this revision to Diff 53906.
ognarb added a comment.


  Remove icon to option button

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19620?vs=53505&id=53906

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

AFFECTED FILES
  src/ui/findbar/khtmlfindbar.cpp
  src/ui/findbar/khtmlfindbar_base.ui

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Noah Davis]

ndavis added a comment.


  I think `preferences-desktop-theme-applications` is fine, but 
`preferences-desktop-theme-windowdecorations` looks odd with that border. 
F6691545: Screenshot_20190314_135511.png 

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/20/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 Mar 2019 17:35:40 +
 Build duration:
9 min 52 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6420/8540)43%
(10277/23672)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5865/12071)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(855/1267)36%
(988/2717)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D18380: KIO: make file dialog columns resizable again (and movable)

[René J . V . Bertin]

rjvbb added a comment.


  >   ...aand that's exactly what happened. :(
  
  I'm not exhausted, my patch just works good enough (thanks also to feedback 
on here) to make me more interested in living the rest of my life rather than 
continue to explore alternatives. Maybe if an alternative patch review were 
posted (and mentioned) here I'd get myself to take a look, but maybe we'll only 
get one after this proposition has been committed and tested in the wild.
  
  Give it a couple of days. Then, if no one else reacts, decide what you 
prefer: the current fixed-width columns or my possibly suboptimal 
implementation that makes them resizable again.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz, markg
Cc: markg, cfeck, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/24/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 14 Mar 2019 17:35:40 +
 Build duration:
6 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6420/8540)43%
(10277/23672)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5865/12071)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(855/1267)36%
(988/2717)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/26/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 14 Mar 2019 17:35:40 +
 Build duration:
4 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D19734: Fix compilation with Android API level >= 26

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:35b0d2adf013: Fix compilation with Android API level 
>= 26 (authored by vkrause).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19734?vs=53814&id=53901

REVISION DETAIL
  https://phabricator.kde.org/D19734

AFFECTED FILES
  src/lib/util/kuser_unix.cpp

To: vkrause, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18380: KIO: make file dialog columns resizable again (and movable)

[Nathaniel Graham]

ngraham added a comment.


  In D18380#409963 , @ngraham wrote:
  
  > I hope not, but that's the problem with the wall-of-text communication 
style. Eventually people get exhausted and the discussion peters out with 
nothing getting done.
  
  
  ...aand that's exactly what happened. :(
  
  What needs to get done here to land this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz, markg
Cc: markg, cfeck, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19764: Fix Minimap with QtCurve style

[Kåre Särs]

sars created this revision.
sars added a reviewer: brauch.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.

REVISION SUMMARY
  The handle of the scrollbar in QtCurve is much smaller than the scrollbar 
width when the minimap is on and does not fill the whole width.
  
  This patch moves to always have the scrollbar-handle use the whole width (-2 
pixels)

TEST PLAN
  No visual difference with Breeze and with QtCurve the minimap scrollbar 
handle now uses the whole width of the scrollbar.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19764

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: sars, brauch
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19762: Only get clearTextPath when used

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It does some queries and introspection that takes up to 2ms.

TEST PLAN
  Mounted and unmounted an unencrypted drive, before it would query it 4x, 
after 1x

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D19762

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: broulik, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[loh tar]

loh.tar updated this revision to Diff 53891.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Use new sig/slot style
  - Move/Use KToggleAction in document as suggested
  - Fix not working throttle logic
  - Increase delay to 3sec
  - Remove unneeded extra option "Follow"
  
  TODO
  
  - Final position of action in menu. The still existing group is not needed 
anymore
  - Try it
  
#!/bin/bash
1. Usage: ./me |tee -a foobar while : do echo $(date -Ins)
  1. delay 1sec, -t 0.1 delay 100msec read -t 1 -n 1 done

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19517?vs=53613&id=53891

REVISION DETAIL
  https://phabricator.kde.org/D19517

AFFECTED FILES
  src/data/katepart5ui.rc
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/view/kateview.cpp
  src/view/kateview.h

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Björn Feber]

GB_2 updated this revision to Diff 53883.
GB_2 added a comment.


  Don't turn real files into symlinks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19733?vs=53882&id=53883

REVISION DETAIL
  https://phabricator.kde.org/D19733

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-theme-applications.svg
  icons-dark/preferences/32/preferences-desktop-theme-windowdecorations.svg
  icons/preferences/32/preferences-desktop-theme-applications.svg
  icons/preferences/32/preferences-desktop-theme-windowdecorations.svg

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Björn Feber]

GB_2 updated this revision to Diff 53882.
GB_2 added a comment.


  Update preferences-desktop-theme-applications icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19733?vs=53813&id=53882

BRANCH
  add-preferences-desktop-theme-windows-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19733

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-theme-applications.svg
  icons-dark/preferences/32/preferences-desktop-theme-windowdecorations.svg
  icons-dark/preferences/32/preferences-desktop-theme.svg
  icons/preferences/32/preferences-desktop-theme-applications.svg
  icons/preferences/32/preferences-desktop-theme-windowdecorations.svg
  icons/preferences/32/preferences-desktop-theme.svg

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Björn Feber]

GB_2 retitled this revision from "Add preferences-desktop-theme-applications 
and preferences-desktop-theme-windowborders icons" to "Add 
preferences-desktop-theme-applications and 
preferences-desktop-theme-windowdecorations icons".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19338: New location for KNSRC files

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:be0412024a46: New location for KNSRC files (authored by 
leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19338?vs=53117&id=53869

REVISION DETAIL
  https://phabricator.kde.org/D19338

AFFECTED FILES
  KF5NewStuffCoreConfig.cmake.in
  README.md
  src/core/engine.cpp
  src/core/engine.h

To: leinir, #knewstuff, apol, ngraham, fvogt
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19750: [attica] compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R235 Attica

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19750

AFFECTED FILES
  CMakeLists.txt
  src/provider.cpp
  src/providermanager.cpp
  tests/projecttest/projecttest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns