D19935: [KCMUTILS] compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R295 KCMUtils

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19935

AFFECTED FILES
  CMakeLists.txt
  src/kcmultidialog.cpp
  src/kpluginselector.cpp
  src/ksettings/dialog.cpp
  src/ksettings/dispatcher.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19934: [kded] compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R297 KDED

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19934

AFFECTED FILES
  CMakeLists.txt
  src/kded.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/23/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 21 Mar 2019 04:52:52 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.57.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(449/2236)17%
(195/1134)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(143/155)51%
(54/106)src100%
(8/8)100%
(8/8)68%
(222/327)50%
(105/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/8)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
  

D19903: Fix build with msvc

[Albert Astals Cid]

aacid added a comment.


  In D19903#435469 , @vonreth wrote:
  
  > Msvc2017.
  >  I think frameworks is still c++11?
  
  
  Not sure, probably yes.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19923: Improve the KCM error message

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

BRANCH
  improve-kcm-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19923

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth added a comment.


  Msvc2017.
  I think frameworks is still c++11?

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 20 Mar 2019 12:42:29 +
 Build duration:
9 hr 7 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D19930: [kwallets] compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R311 KWallet

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19930

AFFECTED FILES
  CMakeLists.txt
  src/api/KWallet/kwallet.cpp
  src/runtime/kwalletd/ktimeout.cpp
  src/runtime/kwalletd/kwalletd.cpp
  src/runtime/kwalletd/kwalletsessionstore.cpp
  src/runtime/kwalletd/migrationagent.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19929: [kparts] compile without foreacg

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R306 KParts

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19929

AFFECTED FILES
  CMakeLists.txt
  src/partmanager.cpp
  src/plugin.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/40/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 20 Mar 2019 09:01:35 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

D19903: Fix build with msvc

[Albert Astals Cid]

aacid added a comment.


  Which MSVC is that? it seems the decltype change is workarounding non C++14 
support?

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 22 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/22/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 20 Mar 2019 16:42:28 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Purpose-5.57.0.xmlcompat_reports/KF5Purpose_compat_report.htmllogs/KF5Purpose/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(452/2236)17%
(196/1134)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(146/155)54%
(57/106)src100%
(8/8)100%
(8/8)68%
(222/327)50%
(105/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/8)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
  

D19923: Improve the KCM error message

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Improve the KCM error message.

TEST PLAN
  Open a broken KCM. To get one, remove for example the Look and Feel KCM 
shared library (the file is 
/usr/lib/x86_64-linux-gnu/qt5/plugins/kcms/kcm_lookandfeel.so).

REPOSITORY
  R295 KCMUtils

BRANCH
  improve-kcm-error-message (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19923

AFFECTED FILES
  src/kcmoduleloader.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19895: Use https for links in the UI and documentation

[Volker Krause]

vkrause updated this revision to Diff 54435.
vkrause added a comment.


  Update konqueror.org link.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19895?vs=54356&id=54435

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19895

AFFECTED FILES
  docs/kcontrol5/proxy/index.docbook
  docs/kcookiejar5/man-kcookiejar5.8.docbook
  docs/kioslave5/data/index.docbook
  docs/kioslave5/help/documentationnotfound/index.docbook
  docs/kioslave5/mailto/index.docbook
  src/core/job_error.cpp
  src/kcms/kio/kproxydlg.ui
  src/widgets/kautomount.cpp

To: vkrause, yurchor
Cc: ognarb, yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19891: Use https for the pastebin backend and publicly accessible documentation

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:fbd859319a80: Use https for the pastebin backend and 
publicly accessible documentation (authored by vkrause).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19891?vs=54350&id=54433

REVISION DETAIL
  https://phabricator.kde.org/D19891

AFFECTED FILES
  README.md
  src/plugins/pastebin/pastebinplugin.cpp

To: vkrause, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19917: Additions for ProviderManager documentation

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:533b31b5d6f9: Additions for ProviderManager documentation 
(authored by leinir).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19917?vs=54422&id=54426

REVISION DETAIL
  https://phabricator.kde.org/D19917

AFFECTED FILES
  README.md
  src/providermanager.h

To: leinir, #frameworks, #knewstuff, apol
Cc: apol, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19917: Additions for ProviderManager documentation

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  We'll see I guess.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D19917

To: leinir, #frameworks, #knewstuff, apol
Cc: apol, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19917: Additions for ProviderManager documentation

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> apol wrote in providermanager.h:50
> You can use @see so doxygen creates a link?

It's supposed to pick those up automatically, i thought?

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D19917

To: leinir, #frameworks, #knewstuff
Cc: apol, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19917: Additions for ProviderManager documentation

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> providermanager.h:50
>   *
> - * Once you have loaded a Provider, use its functions to access the service.
> + * See addProviderFileToDefaultProviders(const QUrl &url) for an example of
> + * what the provider file sohuld look like. You can add providers to the

You can use @see so doxygen creates a link?

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D19917

To: leinir, #frameworks, #knewstuff
Cc: apol, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19917: Additions for ProviderManager documentation

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: Frameworks, KNewStuff.
leinir added a project: KNewStuff.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Someone attempting to work on an Attica based tool discovered that the root 
documentation for the framework was lacking. This is an attempt at alleviating 
that somewhat.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D19917

AFFECTED FILES
  README.md
  src/providermanager.h

To: leinir, #frameworks, #knewstuff
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19907: Add Theme::blurBehindEnabled()

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 54417.
kossebau added a comment.


  Remove sneaked-in code clean-up for repeated fetching of mask
  
  @davidedmundson Is the new dialog code fine?

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19907?vs=54416&id=54417

BRANCH
  addblurbehindflag

REVISION DETAIL
  https://phabricator.kde.org/D19907

AFFECTED FILES
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/theme.cpp
  src/plasma/theme.h
  src/plasmaquick/dialog.cpp

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19907: Add Theme::blurBehindEnabled()

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 54416.
kossebau added a comment.


  add missed-out application of the flag in PlasmaQuick::Dialog

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19907?vs=54399&id=54416

BRANCH
  addblurbehindflag

REVISION DETAIL
  https://phabricator.kde.org/D19907

AFFECTED FILES
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/theme.cpp
  src/plasma/theme.h
  src/plasmaquick/dialog.cpp

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19551: [knotifications] compile without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:99e1dc8786a1: [knotifications] compile without foreach 
(authored by mlaurent).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19551?vs=54392&id=54411

REVISION DETAIL
  https://phabricator.kde.org/D19551

AFFECTED FILES
  CMakeLists.txt
  src/knotificationmanager.cpp
  src/knotifyconfig.cpp
  src/kpassivepopup.cpp
  src/kstatusnotifieritem.cpp
  src/notifybypopup.cpp
  src/notifybyportal.cpp
  tests/knotificationdbustest.cpp

To: mlaurent, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19913

AFFECTED FILES
  CMakeLists.txt
  autotests/coronatest.cpp
  autotests/packagestructuretest.cpp
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h
  src/declarativeimports/core/datasource.cpp
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/tooltipdialog.cpp
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmaextracomponents/fallbackcomponent.cpp
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/datacontainer.cpp
  src/plasma/dataengine.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/package.cpp
  src/plasma/pluginloader.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/containment_p.cpp
  src/plasma/private/dataenginemanager.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/timetracker.cpp
  src/plasma/scripting/scriptengine.cpp
  src/plasma/service.cpp
  src/plasma/svg.cpp
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/configview.cpp
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  tests/kplugins/plugintest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 13 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/13/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Wed, 20 Mar 2019 12:42:44 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 490 lines...][2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/javax/inject/javax.inject/1/javax.inject-1.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/commons-logging/commons-logging/1.2/commons-logging-1.2.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/org/jetbrains/annotations/13.0/annotations-13.0.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/commons-codec/commons-codec/1.9/commons-codec-1.9.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/org/jdom/jdom2/2.0.6/jdom2-2.0.6.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/com/sun/activation/javax.activation/1.2.0/javax.activation-1.2.0.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/org/glassfish/jaxb/jaxb-core/2.2.11/jaxb-core-2.2.11.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/org/jvnet/staxex/stax-ex/1.7.7/stax-ex-1.7.7.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/javax/xml/bind/jaxb-api/2.2.12-b140109.1041/jaxb-api-2.2.12-b140109.1041.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/org/glassfish/jaxb/jaxb-runtime/2.2.11/jaxb-runtime-2.2.11.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/com/sun/istack/istack-commons-runtime/2.21/istack-commons-runtime-2.21.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/com/sun/xml/fastinfoset/FastInfoset/1.2.13/FastInfoset-1.2.13.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/org/glassfish/jaxb/txw2/2.2.11/txw2-2.2.11.jar[2019-03-20T12:43:28.490Z] Download https://jcenter.bintray.com/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar[2019-03-20T12:43:28.490Z] Download https://dl.google.com/dl/android/maven2/com/android/tools/build/manifest-merger/26.2.0/manifest-merger-26.2.0.jar[2019-03-20T12:43:35.043Z] File /home/user/.android/repositories.cfg could not be loaded.[2019-03-20T12:43:35.625Z] Checking the license for package Android SDK Platform 28 in /opt/android-sdk/licenses[2019-03-20T12:43:35.625Z] License for package Android SDK Platform 28 accepted.[2019-03-20T12:43:35.625Z] Preparing "Install Android SDK Platform 28 (revision: 6)".[2019-03-20T12:43:43.760Z] "Install Android SDK Platform 28 (revision: 6)" ready.[2019-03-20T12:43:43.760Z] Installing Android SDK Platform 28 in /opt/android-sdk/platforms/android-28[2019-03-20T12:43:43.760Z] "Install Android SDK Platform 28 (revision: 6)" complete.[2019-03-20T12:43:43.760Z] "Install Android SDK Platform 28 (revision: 6)" finished.[2019-03-20T12:43:44.016Z] :preBuild UP-TO-DATE[2019-03-20T12:43:44.016Z] :preDebugBuild UP-TO-DATE[2019-03-20T12:43:44.016Z] :compileDebugAidl NO-SOURCE[2019-03-20T12:43:44.016Z] :compileDebugRenderscript[2019-03-20T12:43:44.016Z] :checkDebugManifest[2019-03-20T12:43:44.016Z] :generateDebugBuildConfig[2019-03-20T12:43:44.016Z] :generateDebugResValues[2019-03-20T12:43:44.016Z] :generateDebugResources[2019-03-20T12:43:44.271Z] :packageDebugResources[2019-03-20T12:43:44.271Z] Download https://dl.google.com/dl/android/maven2/com/android/tools/build/aapt2/3.2.0-4818971/aapt2-3.2.0-4818971.pom[2019-03-20T12:43:44.271Z] Download https://dl.google.com/dl/android/maven2/com/android/tools/build/aapt2/3.2.0-4818971/aapt2-3.2.0-4818971-linux.jar[2019-03-20T12:43:44.527Z] :processDebugManifest[2019-03-20T12:43:44.527Z] :generateDebugRFile[2019-03-20T12:43:44.527Z] :prepareLintJar[2019-03-20T12:43:44.527Z] :generateDebugSources[2019-03-20T12:43:44.527Z] :javaPreCompileDebug[2019-03-20T12:43:45.453Z] :compileDebugJavaWithJavacNote: /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12/src/android/org/kde/knotifications/NotifyByAndroid.java uses or overrides a deprecated API.[2019-03-20T12:43:45.453Z] Note: Recompile with -Xlint:deprecation for details.[2019-03-20T12:43:45.453Z] Note: /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12/src/android/org/kde/knotifications/NotifyByAndroid.java uses unchecked or unsafe operations.[2019-03-20T12:43:45.453Z] Note: Recompile with -Xlint:unchecked for details.[2019-03-20T12:43:45.453Z] [2019-03-20T12:43:45.453Z] :extractDebugAnnotations[2019-03-20T12:43:46.111Z] Download https://dl.google.com/dl/android/maven2/com/android/tools/lint/lint-gradle/26.2.0/lint-gradle-26.2.0.pom[2019-03-20T12:43:46.111Z] Download https://dl.google.com/dl/android/maven2/com/android/tools/external/com-intellij/intellij-core/26.2.0/intellij-core-26.2.0.pom[2019-03-20T12:43:46.111Z] Download 

D19897: [kservice ] Make it compile without foreach

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:0c673cd78f6b: [kservice ] Make it compile without foreach 
(authored by mlaurent).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19897?vs=54361&id=54406

REVISION DETAIL
  https://phabricator.kde.org/D19897

AFFECTED FILES
  CMakeLists.txt
  autotests/kmimeassociationstest.cpp
  autotests/kservicetest.cpp
  autotests/ksycoca_xdgdirstest.cpp
  autotests/ksycocadicttest.cpp
  src/kdeinit/ktoolinvocation_win.cpp
  src/kdeinit/ktoolinvocation_x11.cpp
  src/plugin/kplugintrader.h
  src/services/kmimetypetrader.h
  src/services/kplugininfo.cpp
  src/services/kservice.cpp
  src/services/kservicegroup.cpp
  src/services/kservicetypetrader.h
  src/services/ktraderparsetree.cpp
  src/sycoca/kbuildservicefactory.cpp
  src/sycoca/kbuildsycoca.cpp
  src/sycoca/kmimeassociations.cpp
  src/sycoca/ksycocadict.cpp
  src/sycoca/ksycocafactory.cpp
  src/sycoca/ksycocautils_p.h
  src/sycoca/vfolder_menu.cpp
  tests/kmimeassociations_dumper.cpp
  tests/pluginlocator/plugintest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19907: Add Theme::blurBehindEnabled()

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> theme.h:391
> + * \code
> + * [BlurEffect]
> + * enabled=false

And this and above should have been updated to "[BlurBehindEffect]", as 
actually used in the code. So much for quick pre-lunch uploading, tss.

Will fix when landing the patch later tonight.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  addblurbehindflag

REVISION DETAIL
  https://phabricator.kde.org/D19907

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19907: Add Theme::blurBehindEnabled()

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  addblurbehindflag

REVISION DETAIL
  https://phabricator.kde.org/D19907

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19876: Fix: apply correctly the text colors of the chosen scheme

[Nibaldo González]

nibags updated this revision to Diff 54404.
nibags added a comment.


  - Fix theme names
  
  Convert theme names from KTextEditor => KSyntaxHighlighting and avoid using 
invalid `KSyntaxHighlighting::Theme` objects.
  
  The `KDE` and `vim (dark)` themes don't exist in KSyntaxHighlighting, in such 
cases `KSyntaxHighlighting::Repository::LightTheme` is used (however, the 
colors of the original theme are retained).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19876?vs=54295&id=54404

BRANCH
  fix-schemas

REVISION DETAIL
  https://phabricator.kde.org/D19876

AFFECTED FILES
  src/schema/kateschema.cpp
  src/syntax/katehighlight.cpp

To: nibags, #ktexteditor, #kate
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19908: [ConfigModule] Pass initial properties

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  There's probably some std algo for it but `std::copy` didn't work so I gave 
up.
  
  did `kcm.push("SomePage.qml", {title: "foo"})` and the new page had the title 
I passed in

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19908

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19907: Add Theme::blurBehindEnabled()

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows themes to disable the blurring of what is behind panels,
  if they either do not need it (being fully opaque) or by design want
  non-blurry transparency.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  addblurbehindflag

REVISION DETAIL
  https://phabricator.kde.org/D19907

AFFECTED FILES
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/theme.cpp
  src/plasma/theme.h

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19888: Add runtime guard that pages are KCMs in KCMultiDialog

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:d9ddd3524535: Add runtime guard that pages are KCMs in 
KCMultiDialog (authored by davidedmundson).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19888?vs=54341&id=54394

REVISION DETAIL
  https://phabricator.kde.org/D19888

AFFECTED FILES
  src/kcmultidialog.cpp

To: davidedmundson, aacid
Cc: aacid, rikmills, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/33/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 20 Mar 2019 09:01:35 +
 Build duration:
7 min 7 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.57.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)59%
(5706/9625)41%
(2111/5206)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(761/761)55%
(213/384)autotests.unit.file100%
(11/11)100%
(11/11)95%
(867/910)50%
(255/506)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)58%
(93/160)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)78%
(1713/2209)54%
(678/1255)src.file63%
(24/38)63%
(24/38)51%
(867/1710)39%
(394/1008)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/70)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/113)src.lib55%
(6/11)55%
(6/11)49%
(464/945)43%
(230/537)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%

D15983: React to config updates inside indexer

[Igor Poboiko]

poboiko closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15983

To: poboiko, #baloo, #frameworks, bruns, ngraham
Cc: kde-frameworks-devel, bruns, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, abrahams

D19551: [knotifications] compile without foreach

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> mlaurent wrote in knotifyconfig.cpp:53
> How we can use iterator here ?
> I didn't find a method for it.

Urgh, indeed. What kind of container is that
Never mind then

> notifybypopup.cpp:426
> +emit finished(i.key());
> +++i;
>  }

This is why a for() loop is better than a while loop() for such usage.

REPOSITORY
  R289 KNotifications

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19551

To: mlaurent, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19897: [kservice ] Make it compile without foreach

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> vfolder_menu.cpp:125
>  {
> -foreach (const KService::Ptr &p, items1) {
> +const QHash tmpItems1 = items1;
> +for (const KService::Ptr &p : tmpItems1) {

This makes me realize that this code was indeed detaching a copy of items1.
Good catch.
But better code would use a java-style iterator and call remove(), to avoid the 
copy and the extra lookup at remove time.

This can be a separate commit, this port is correct.

REPOSITORY
  R309 KService

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19897

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19551: [knotifications] compile without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 54392.
mlaurent added a comment.


  Fix loop

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19551?vs=54388&id=54392

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19551

AFFECTED FILES
  CMakeLists.txt
  src/knotificationmanager.cpp
  src/knotifyconfig.cpp
  src/kpassivepopup.cpp
  src/kstatusnotifieritem.cpp
  src/notifybypopup.cpp
  src/notifybyportal.cpp
  tests/knotificationdbustest.cpp

To: mlaurent, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth added a comment.


  btw
  
.vim-template:cpp
.vim-template:h
  
  aren't valid file names on windows, and look strange for unix too

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth added reviewers: mlaurent, davidedmundson, aacid.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19903

To: vonreth, mlaurent, davidedmundson, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19903: Fix build with msvc

[Hannah von Reth]

vonreth created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vonreth requested review of this revision.

REVISION SUMMARY
  For the decltype change see https://stackoverflow.com/a/51347067

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19903

AFFECTED FILES
  src/resultset.h
  src/resultset_iterator.cpp
  src/utils/lazy_val.h

To: vonreth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19902: Remove illegal file names

[Hannah von Reth]

vonreth abandoned this revision.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19902

To: vonreth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19902: Remove illegal file names

[Hannah von Reth]

vonreth updated this revision to Diff 54390.
vonreth added a comment.


  - Fix build with msvc

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19902?vs=54389&id=54390

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19902

AFFECTED FILES
  .vim-template:cpp
  .vim-template:h
  src/resultset.h
  src/resultset_iterator.cpp
  src/utils/lazy_val.h

To: vonreth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19902: Remove illegal file names

[Hannah von Reth]

vonreth created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vonreth requested review of this revision.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19902

AFFECTED FILES
  .vim-template:cpp
  .vim-template:h

To: vonreth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19551: [knotifications] compile without foreach

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> notifybypopup.cpp:424
> +QMap::const_iterator i = 
> d->passivePopups.constBegin();
> +while (i != d->passivePopups.constEnd()) {
> +emit finished(i.key());

this loop now will run forever...

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D19551

To: mlaurent, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19551: [knotifications] compile without foreach

[Laurent Montel]

mlaurent updated this revision to Diff 54388.
mlaurent added a comment.


  Use iterator here

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19551?vs=53231&id=54388

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19551

AFFECTED FILES
  CMakeLists.txt
  src/knotificationmanager.cpp
  src/knotifyconfig.cpp
  src/kpassivepopup.cpp
  src/kstatusnotifieritem.cpp
  src/notifybypopup.cpp
  src/notifybyportal.cpp
  tests/knotificationdbustest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19551: [knotifications] compile without foreach

[Laurent Montel]

mlaurent added inline comments.

INLINE COMMENTS

> dfaure wrote in knotifyconfig.cpp:53
> horribly slow, should use STL iterators

How we can use iterator here ?
I didn't find a method for it.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D19551

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns