D19812: Add a web page to view and compare icons of different sizes

[Yunhe Guo]

guoyunhe updated this revision to Diff 54919.
guoyunhe added a comment.


  Output to stderr

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54918&id=54919

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html
  vue.min.js

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

[Yunhe Guo]

guoyunhe updated this revision to Diff 54918.
guoyunhe added a comment.


  Don't use remote JavaScript library

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19812?vs=54688&id=54918

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19812

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  generate_web_data.sh
  index.html
  vue.min.js

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/51/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 27 Mar 2019 01:56:05 +
 Build duration:
7 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(53/60)88%
(53/60)84%
(3273/3913)47%
(4460/9517)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)97%
(1062/1090)49%
(2306/4743)src78%
(21/27)78%
(21/27)79%
(1204/1517)43%
(473/1108)src.extractors100%
(13/13)100%
(13/13)78%
(949/1221)46%
(1610/3511)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D20046: Verify mimetypes for all existing sample files, add some more

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in extractorcoveragetest.cpp:50
> Is it really audio/x-aifc? Taglibextractor the never actually got called. 
> Looks like we should also wire the new helper funciton into the extractor 
> tests, so that we make sure they support the right mimetype

Based on the content, yes. The correct extension according to shared-mime-info 
would be aiffc or aifc.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20046

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/50/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 27 Mar 2019 01:49:01 +
 Build duration:
7 min 3 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(51/59)86%
(51/59)83%
(3226/3875)47%
(4361/9333)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(1024/1052)49%
(2213/4559)src74%
(20/27)74%
(20/27)79%
(1195/1517)42%
(467/1108)src.extractors100%
(13/13)100%
(13/13)78%
(949/1221)46%
(1610/3511)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/46/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 27 Mar 2019 01:51:58 +
 Build duration:
2 min 33 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(53/60)88%
(53/60)84%
(3273/3913)47%
(4460/9517)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)97%
(1062/1090)49%
(2306/4743)src78%
(21/27)78%
(21/27)79%
(1204/1517)43%
(473/1108)src.extractors100%
(13/13)100%
(13/13)78%
(949/1221)46%
(1610/3511)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 51 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/51/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 27 Mar 2019 01:51:46 +
 Build duration:
1 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.extractorcoveragetest

D20046: Verify mimetypes for all existing sample files, add some more

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:67bcc588feca: Verify mimetypes for all existing sample 
files, add some more (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20046?vs=54785&id=54911

REVISION DETAIL
  https://phabricator.kde.org/D20046

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/extractorcoveragetest.cpp
  autotests/samplefiles/test.dot
  autotests/samplefiles/test.pl
  autotests/samplefiles/test_apple_systemprofiler.spx
  autotests/samplefiles/test_public_key.gpg

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/45/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 27 Mar 2019 01:49:00 +
 Build duration:
2 min 56 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(51/59)86%
(51/59)83%
(3226/3875)47%
(4361/9333)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(1024/1052)49%
(2213/4559)src74%
(20/27)74%
(20/27)79%
(1195/1517)42%
(467/1108)src.extractors100%
(13/13)100%
(13/13)78%
(949/1221)46%
(1610/3511)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D20045: Add helper function to determine mime type based on content and extension

[Stefan Brüns]

bruns marked 3 inline comments as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20045

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20045: Add helper function to determine mime type based on content and extension

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:69c25514cf6a: Add helper function to determine mime type 
based on content and extension (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20045?vs=54908&id=54909

REVISION DETAIL
  https://phabricator.kde.org/D20045

AFFECTED FILES
  src/CMakeLists.txt
  src/mimeutils.cpp
  src/mimeutils.h

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20045: Add helper function to determine mime type based on content and extension

[Stefan Brüns]

bruns updated this revision to Diff 54908.
bruns added a comment.


  add documentation

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20045?vs=54784&id=54908

BRANCH
  submit_mime

REVISION DETAIL
  https://phabricator.kde.org/D20045

AFFECTED FILES
  src/CMakeLists.txt
  src/mimeutils.cpp
  src/mimeutils.h

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  In D19952#439031 , @arvidhansson 
wrote:
  
  > In D19952#438965 , @ndavis wrote:
  >
  > > The rounded corners and bold 1 are not very breeze like, so I don't think 
so, unless he changes his design. Unless you still plan to do the icon 
yourself, you should probably hand off responsibility for the patch to someone 
else.
  >
  >
  > Sorry for the confusion, as I'm new to this I really need help and aren't 
able to do this alone, just just wanted to bring some attention to this and 
learn how to work with KDE. Thanks for all help, should we now use t-ask's 
first icon(the right one) or something else?
  
  
  No problem, it's just unfortunate that you picked an issue where other people 
already had their own ideas planned. If there weren't more than 1 design to 
look at, it would be easier for me to work with you 1-on-1. Why don't you try 
making an icon for an app you like that doesn't already have an icon in Breeze 
Icons? Not Firefox, Thunderbird or proprietary software, but there might be 
some exceptions. If you have questions, bring them up in the VDG chat.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D20045: Add helper function to determine mime type based on content and extension

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in mimeutils.cpp:39
> That reads a little bit confusing. I think it is more clear to write 
> something like "Check if extension based mime type is a specialized..."?

that would be the wrong way round ...

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit_mime

REVISION DETAIL
  https://phabricator.kde.org/D20045

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20041: [balooctl] Reduce nesting level for addOption arguments, cleanup

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:cc705f52d908: [balooctl] Reduce nesting level for 
addOption arguments, cleanup (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20041?vs=54769&id=54907

REVISION DETAIL
  https://phabricator.kde.org/D20041

AFFECTED FILES
  src/tools/balooctl/main.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 27 Mar 2019 00:08:08 +
 Build duration:
9 min 22 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.57.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(113/168)67%
(113/168)59%
(5718/9626)41%
(2117/5208)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(761/761)55%
(213/384)autotests.unit.file100%
(11/11)100%
(11/11)95%
(867/910)50%
(255/506)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)58%
(93/160)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)78%
(1713/2209)54%
(678/1255)src.file66%
(25/38)66%
(25/38)51%
(879/1712)40%
(400/1008)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/70)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/113)src.lib55%
(6/11)55%
(6/11)49%
(464/945)43%
(230/537)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
   

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/42/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 27 Mar 2019 00:08:08 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

D20042: Show the plasmoid context menu on long tap

[Aleix Pol Gonzalez]

apol updated this revision to Diff 54901.
apol added a comment.


  Convert to the containment coordinate system, otherwise we show the context 
menu of the applet at 0,0

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20042?vs=54777&id=54901

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20042

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/appletinterface.h

To: apol, #plasma, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20070: [PlasmaComponents3 ComboBox] Fix textColor

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20070

To: broulik, #plasma, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D20065

To: broulik, #frameworks, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: Go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail updated this revision to Diff 54897.
krutovmikhail added a comment.


  - Update per phabricator comments: styling, boolean to enum, windows fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20026?vs=54893&id=54897

BRANCH
  mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode

REVISION DETAIL
  https://phabricator.kde.org/D20026

AFFECTED FILES
  src/CMakeLists.txt
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/widgets/kurlcombobox.cpp
  src/widgets/kurlcombobox.h

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#438965 , @ndavis wrote:
  
  > The rounded corners and bold 1 are not very breeze like, so I don't think 
so, unless he changes his design. Unless you still plan to do the icon 
yourself, you should probably hand off responsibility for the patch to someone 
else.
  
  
  Sorry for the confusion, as I'm new to this I really need help and aren't 
able to do this alone, just just wanted to bring some attention to this and 
learn how to work with KDE. Thanks for all help, should we now use t-ask's 
first icon(the right one) or something else?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D20026: Go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail added a comment.


  Yes, I was mostly pointing out that it seems to be out of scope of this 
revision to fix that problem :-)
  
  https://bugs.kde.org/show_bug.cgi?id=157593#c4 this seems to be the most 
reasonable solution, if to keep the patch there. However, pressing "return" or 
otherwise changing URL is not same as UI element losing focus.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: Go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail updated this revision to Diff 54893.
krutovmikhail marked 11 inline comments as done.
krutovmikhail added a comment.


  - Update per phabricator comments: styling, boolean to enum, windows fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20026?vs=54815&id=54893

BRANCH
  mkrutov/20190324/feat/kurlnavigator_keypresses_in_edit_mode

REVISION DETAIL
  https://phabricator.kde.org/D20026

AFFECTED FILES
  src/CMakeLists.txt
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/widgets/kurlcombobox.cpp
  src/widgets/kurlcombobox.h

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: Go up in folder hierachy when in "edit mode"

[Nathaniel Graham]

ngraham added a comment.


  In D20026#438993 , @krutovmikhail 
wrote:
  
  > ngraham, in Dolphin, this commit is to blame for loosing editMode on 
changing URL: 
https://github.com/KDE/dolphin/commit/2af331b42c0514f4fdf848d0cc22f02717f7bec0
  >
  > I don't think that this behavior has any logic in it to be honest; but it 
seems that it was explicitly implemented to work that way.
  
  
  Yeah, it almost seems like that change was not really what was requested in 
the relevant bug report. Though it's kind of hard to tell.
  
  Regardless, we don't work around  apps' behavior in library components. So we 
should remove the workaround here and figure out how to handle Dolphin 
separately, either by reverting that change or fixing it so that it works with 
this new behavior in the URL navigator widget.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20070: [PlasmaComponents3 ComboBox] Fix textColor

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Uses the one from `ColorScope` rather than `Kirigami`.
  `Kirigami.Theme` isn't used in any other Plasma Components 3 and the 
`opacity` already changes for when it's disabled

TEST PLAN
  - `ComboBox` has correct color now

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20070

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: Go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail added a comment.


  ngraham, in Dolphin, this commit is to blame for loosing editMode on changing 
URL: 
https://github.com/KDE/dolphin/commit/2af331b42c0514f4fdf848d0cc22f02717f7bec0
  
  I don't think that this behavior has any logic in it to be honest; but it 
seems that it was explicitly implemented to work that way.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

[David Edmundson]

davidedmundson added a comment.


  These two should make the unit tests windows compatible (untested)

INLINE COMMENTS

> kprocesslisttest.cpp:38
> +{
> +struct passwd *pwdEntry = getpwuid(uid);
> +if (pwdEntry == nullptr) {

KUser::KUser()

(fortunately it's in kcoreaddons!)

> kprocesslisttest.cpp:52
> +{
> +return getpid();
> +}

qint64 QCoreApplication::applicationPid()

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis added a comment.


  The rounded corners and bold 1 are not very breeze like, so I don't think so, 
unless he changes his design. Unless you still plan to do the icon yourself, 
you should probably hand off responsibility for the patch to someone else.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Don't forget to update the commit message (it still mentions "Add 
GetProcessList") ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D12327: Show Detailed Tree View by default

[Noah Davis]

ndavis added a comment.


  +1
  
  Navigation is so much faster in tree view. I think navigation speed is what 
matters most of the time when people are selecting files or locations.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, apol
Cc: ndavis, kde-frameworks-devel, elvisangelaccio, abetts, #frameworks, 
michaelh, ngraham, bruns

D12327: Show Detailed Tree View by default

[Nathaniel Graham]

ngraham added a reviewer: apol.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg, apol
Cc: kde-frameworks-devel, elvisangelaccio, abetts, #frameworks, michaelh, 
ngraham, bruns

D12327: Show Detailed Tree View by default

[Nathaniel Graham]

ngraham removed a dependency: D12326: In Short View, display icons on top and 
increase icon size.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg
Cc: kde-frameworks-devel, elvisangelaccio, abetts, #frameworks, michaelh, 
ngraham, bruns

D12326: In Short View, display icons on top and increase icon size

[Nathaniel Graham]

ngraham removed a dependent revision: D12327: Show Detailed Tree View by 
default.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12326

To: ngraham
Cc: rkflx, abetts, anemeth, #frameworks, michaelh, ngraham, bruns

D12327: Show Detailed Tree View by default

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12327

To: ngraham, #frameworks, #vdg
Cc: kde-frameworks-devel, elvisangelaccio, abetts, #frameworks, michaelh, 
ngraham, bruns

D20062: [RFC] Add support for changing volume label.

[Stefan Brüns]

bruns added a comment.


  This definitely should be part of the StorageVolume interface.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/52/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 26 Mar 2019 17:47:58 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32948/60510)39%
(17162/5)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4373/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8435/14413)51%
(4761/9338)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4361/8045)40%
(1919/4805)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/66/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 26 Mar 2019 17:47:58 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32909/60501)39%
(17136/2)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4373/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8405/14403)51%
(4743/9335)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4364/8045)40%
(1922/4805)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/70/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 26 Mar 2019 17:47:58 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D20060: [KDynamicJobTracker] Use generated DBus interface

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ed158497a322: [KDynamicJobTracker] Use generated DBus 
interface (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20060?vs=54848&id=54873

REVISION DETAIL
  https://phabricator.kde.org/D20060

AFFECTED FILES
  src/widgets/kdynamicjobtracker.cpp

To: broulik, #frameworks, davidedmundson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures `args` are passed into the `KQuickAddons::ConfigModule`

TEST PLAN
  the qml kcm seems a bit backwarts, it creates an instance of the config 
module and thne creates a kcmoduleqml for it. But anyway I can now do 
`kcmshell5 someqmlkcm --args foo` and get a `QVariantList args` of 
`QVariant("foo")` now

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D20065

AFFECTED FILES
  src/kcmoduleloader.cpp

To: broulik, #frameworks, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

[Méven Car]

meven updated this revision to Diff 54869.
meven added a comment.


  update commit message

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19824?vs=54868&id=54869

BRANCH
  arcpatch-D19824

REVISION DETAIL
  https://phabricator.kde.org/D19824

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h
  tests/CMakeLists.txt
  tests/kfilewidgettest_saving_gui.cpp

To: meven, #frameworks, #dolphin, ngraham, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> kfilewidgettest_saving_gui.cpp:2
> +/* This file is part of the KDE libraries
> +Copyright (C) 2015 David Faure 
> +

Your copyright, since you wrote this file

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19824

To: meven, #frameworks, #dolphin, ngraham, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

[Méven Car]

meven updated this revision to Diff 54868.
meven marked an inline comment as done.
meven added a comment.


  Updated after review, add another test file instead of modifying it.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19824?vs=54082&id=54868

BRANCH
  arcpatch-D19824

REVISION DETAIL
  https://phabricator.kde.org/D19824

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h
  tests/CMakeLists.txt
  tests/kfilewidgettest_saving_gui.cpp

To: meven, #frameworks, #dolphin, ngraham, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19824

To: meven, #frameworks, #dolphin, ngraham, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19824

To: meven, #frameworks, #dolphin, ngraham, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

[Nathaniel Graham]

ngraham added reviewers: dfaure, sitter.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19439

To: marten, #plasma, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

[Jonathan Marten]

marten added a comment.


  Ping - anyone able to review please?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19439

To: marten, #plasma, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D20063: Sublime Merge Icon.

[Filip Fila]

filipf added a comment.


  Looks good. Since it's a proprietary program just check if they have any 
restrictions about having to use their icons. And yep, the xmlerrors file 
should be removed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg, ndavis
Cc: filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, 
Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, 
trickyricky26, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D20063: Sublime Merge Icon.

[Nathaniel Graham]

ngraham added a reviewer: ndavis.
ngraham added a comment.


  Thanks! The new icon looks good to me. However it looks like an `xmlerrors` 
file was accidentally added to this patch. Can you remove that?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg, ndavis
Cc: ngraham, #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, 
Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, 
trickyricky26, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

[Robert Hoffmann]

hoffmannrobert marked 5 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19887

To: hoffmannrobert, dfaure, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20063: Sublime Merge Icon.

[Kirill Otavva]

otavva added a reviewer: VDG.
otavva added a subscriber: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg
Cc: #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, Pixel_Lime, 
jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, 
mglb, michaelh, crozbo, ndavis, firef, ngraham, bruns, skadinna, 
aaronhoneycutt, mbohlender

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

[Robert Hoffmann]

hoffmannrobert retitled this revision from "Proposal for KFileItem to skip 
stat()" to "KFileItem: call stat() on demand, add SkipMimeTypeDetermination 
option".
hoffmannrobert edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19887

To: hoffmannrobert, dfaure, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20063: Sublime Merge Icon.

[Kirill Otavva]

otavva created this revision.
otavva added a project: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
otavva requested review of this revision.

REVISION SUMMARY
  Just added Sublime Merge icon.
  F6720983: screenshotSMIcon.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

AFFECTED FILES
  icons-dark/apps/48/sublime-merge.svg
  icons/apps/48/sublime-merge.svg
  xmlerrors

To: otavva
Cc: kde-frameworks-devel, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, rooty, trickyricky26, mglb, 
michaelh, crozbo, ndavis, firef, ngraham, bruns, skadinna, aaronhoneycutt, 
mbohlender

D20026: Go up in folder hierachy when in "edit mode"

[Nathaniel Graham]

ngraham added a comment.


  In D20026#438747 , @krutovmikhail 
wrote:
  
  > Thanks, I'll apply styling changes & will take a look at GWenView. Out of 
KDE Applications, what other consumers use KUrlNavigator? Is there an easy way 
to find out?
  
  
  Check this out: https://lxr.kde.org/ident?_i=KUrlNavigator&_remember=1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19784: Avoid calling QT_LSTAT and accessing recent documents

[Robert Hoffmann]

hoffmannrobert updated this revision to Diff 54863.
hoffmannrobert added a comment.


  - Use new KFileItem::SkipMimeTypeDetermination parameter

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19784?vs=54339&id=54863

BRANCH
  fix_recent_documents_kicker_hang

REVISION DETAIL
  https://phabricator.kde.org/D19784

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19887: Proposal for KFileItem to skip stat()

[Robert Hoffmann]

hoffmannrobert updated this revision to Diff 54862.
hoffmannrobert added a comment.


  - On-demand stat(), helper function, SkipMimeTypeDetermination

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19887?vs=54338&id=54862

BRANCH
  add_skipStat

REVISION DETAIL
  https://phabricator.kde.org/D19887

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kfileitem.h

To: hoffmannrobert, dfaure, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  The issue here is the placement of code. There are no API for changing any 
volume attributes so adding the changeLabel() method here feels awkward.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 69 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/69/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 26 Mar 2019 15:02:22 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D20026: Go up in folder hierachy when in "edit mode"

[Mikhail Krutov]

krutovmikhail added a comment.


  Thanks, I'll apply styling changes & will take a look at GWenView. Out of KDE 
Applications, what other consumers use KUrlNavigator? Is there an easy way to 
find out?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/51/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 26 Mar 2019 15:02:22 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32937/60506)39%
(17147/5)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4375/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8427/14412)51%
(4747/9338)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4360/8045)40%
(1918/4805)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(557/1055)39%
(347/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D16913: Add the possibility to give focus to the KPluginSelector search field

[Thomas Surrel]

thsurrel added a comment.


  No worries, the other patch is better actually.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D16913

To: thsurrel, #frameworks, #plasma
Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/65/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 26 Mar 2019 15:02:22 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32920/60500)39%
(17142/2)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4373/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8419/14405)51%
(4749/9335)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4364/8045)40%
(1922/4805)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D12545: Set focus on the filename line edit when a file is selected

[Nathaniel Graham]

ngraham added a comment.


  Done in D19849 .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12545

To: anemeth, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, rkflx, ngraham, #frameworks, michaelh, bruns

D19849: [KFileWidget] When saving, highlight filename after clicking existing file also when using double-click

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:cb8f77ec441b: [KFileWidget] When saving, highlight 
filename after clicking existing file also… (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19849?vs=54182&id=54860

REVISION DETAIL
  https://phabricator.kde.org/D19849

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #vdg, broulik, cfeck, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19849: [KFileWidget] When saving, highlight filename after clicking existing file also when using double-click

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  highlight-filename-after-click-when-saving (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19849

To: ngraham, #frameworks, #vdg, broulik, cfeck, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

[Nathaniel Graham]

ngraham added a comment.


  Oh gosh I completely forgot about this, sorry. :(

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D16913

To: thsurrel, #frameworks, #plasma
Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, 
bruns

D19913: [plasma-desktop] make it compiles without foreach

[Aleix Pol Gonzalez]

apol added a comment.


  It's bad enough that we need to give things names because Qt keeps detaching 
on foreach, I'd be giving at least more semantic names to these temporary 
variables.

INLINE COMMENTS

> coronatest.cpp:149
>  
> -foreach (auto cont, m_corona->containments()) {
> +const auto lst = m_corona->containments();
> +for (auto cont : lst) {

maybe call it containments? naming variables with a typename is bad (we even 
are using auto to not mention it's a list!)

> datamodel.cpp:401
>  if (list.first().canConvert()) {
> -foreach (const QVariant &item, list) {
> +for (const QVariant &item : qAsConst(list)) {
>  const QVariantMap &vh = item.value();

It already is const.

> pluginloader.cpp:567
>  //info.service() to be valid and would crash otherwise
> -foreach (auto& md, plugins) {
> +for (auto& md : plugins) {
>  auto pi = md.metaDataFileName().endsWith(QLatin1String(".json")) ? 
> KPluginInfo(md) : 
> KPluginInfo(KService::serviceByStorageId(md.metaDataFileName()));

shouldn't it be const?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

[Thomas Surrel]

thsurrel abandoned this revision.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D16913

To: thsurrel, #frameworks, #plasma
Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20059: Take clang-cl into account.

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM, looks like clang-cl will be missing a few arguments though.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20059

To: cmollekopf, #windows
Cc: apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D20060: [KDynamicJobTracker] Use generated DBus interface

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20060

To: broulik, #frameworks, davidedmundson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20059: Take clang-cl into account.

[Aleix Pol Gonzalez]

apol added a reviewer: Windows.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20059

To: cmollekopf, #windows
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D20034: Pass focus to child searchbar when KPluginSelector is focused

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:03653f4e4ef7: Pass focus to child searchbar when 
KPluginSelector is focused (authored by jayeshbhoot, committed by ngraham).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20034?vs=54743&id=54857

REVISION DETAIL
  https://phabricator.kde.org/D20034

AFFECTED FILES
  src/kpluginselector.cpp

To: jayeshbhoot, #plasma, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

[Nathaniel Graham]

ngraham added reviewers: bruns, broulik.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19956: ki18n: updating memory manager and removing compile warnings

[Tomaz Canabrava]

tcanabrava added a comment.


  -1 gettext is c code, should not use c++ includes.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D19956

To: carneirogustavo, andreagenor, tcanabrava, patrickelectric
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D19849: [KFileWidget] When saving, highlight filename after clicking existing file also when using double-click

[Nathaniel Graham]

ngraham added reviewers: broulik, cfeck, dfaure.
ngraham added a comment.


  Ping!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19849

To: ngraham, #frameworks, #vdg, broulik, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20062: [RFC] Add support for changing volume label.

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Is this the right approach to take?

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20062

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakestorageaccess.cpp
  src/solid/devices/backends/fakehw/fakestorageaccess.h
  src/solid/devices/backends/fstab/fstabstorageaccess.cpp
  src/solid/devices/backends/fstab/fstabstorageaccess.h
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp
  src/solid/devices/backends/udisks2/udisksstorageaccess.h
  src/solid/devices/ifaces/storageaccess.cpp
  src/solid/devices/ifaces/storageaccess.h

To: chinmoyr, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20046: Verify mimetypes for all existing sample files, add some more

[Alexander Stippich]

astippich accepted this revision.
astippich added inline comments.

INLINE COMMENTS

> extractorcoveragetest.cpp:50
> +m_knownFiles = {
> +{ "test.aif",  "audio/x-aifc"},
> +{ "test.ape",  "audio/x-ape"},

Is it really audio/x-aifc? Taglibextractor the never actually got called. Looks 
like we should also wire the new helper funciton into the extractor tests, so 
that we make sure they support the right mimetype

REPOSITORY
  R286 KFileMetaData

BRANCH
  extractor_coverage

REVISION DETAIL
  https://phabricator.kde.org/D20046

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20045: Add helper function to determine mime type based on content and extension

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.


  Just two small nitpicks

INLINE COMMENTS

> mimeutils.cpp:39
> +for (auto mime : extensionMimes) {
> +// check if the content is a specialized type (child) for a generic 
> container, e.g.:
> +// *.mkv -> [ application/matroska ]

That reads a little bit confusing. I think it is more clear to write something 
like "Check if extension based mime type is a specialized..."?

> mimeutils.h:33
> +KFILEMETADATA_EXPORT
> +QMimeType strictMimeType(const QString& filePath, const QMimeDatabase& db);
> +

Please add documentation with "since" tag

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit_mime

REVISION DETAIL
  https://phabricator.kde.org/D20045

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20042: Show the plasmoid context menu on long tap

[Nathaniel Graham]

ngraham added a comment.


  [testing with D20043 ] The context menu 
that is shown on press-and-hold seems to differ from the one shown when 
right-clicked:
  
  Right-clicked: F6720720: Screenshot_20190326_072442.png 

  
  Pressed-and-held: F6720722: Screenshot_20190326_072501.png 

  
  And the press-and-hold version opens the Alternatives panel in the wrong 
place, with the wrong assortment of items: F6720724: 
weird-2019-03-26_07.26.49.webm 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20042

To: apol, #plasma, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20046: Verify mimetypes for all existing sample files, add some more

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  extractor_coverage

REVISION DETAIL
  https://phabricator.kde.org/D20046

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20045: Add helper function to determine mime type based on content and extension

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice.

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit_mime

REVISION DETAIL
  https://phabricator.kde.org/D20045

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20047: Add X-GNOME-UsesNotifications as recognized key

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D20047

To: broulik, #frameworks, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19875: [Kactivities-stats] compile without foreach

[Kai Uwe Broulik]

broulik added a reviewer: ivan.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19875

To: mlaurent, dfaure, ivan
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

[Adriaan de Groot]

adridg added a comment.


  On FreeBSD, `/proc` is not necessarily mounted (it might be a Linuxism). So 
while I do **have** `/proc`, it's empty because procfs isn't mounted there. If 
I **do** mount it, then there's the expected list of processes and a curproc 
symlink. But `/proc/` doesn't contain  a `stat` file .. there's a 
`status`, though. Let me mess around a bit with that... yes, changing to 
`status` makes all 6 tests pass. So I'd suggest something like
  
#ifdef Q_OS_FREEBSD
  QString statusFileName(QStringLiteral("/status"));
#else
  QString statusFileName(QStringLiteral("/stat"));
#endif
  
  and then later on
  
filename += statusFileName;

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19875: [Kactivities-stats] compile without foreach

[Laurent Montel]

mlaurent added a comment.


  Ping ?:)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D19875

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19913: [plasma-desktop] make it compiles without foreach

[Laurent Montel]

mlaurent added a comment.


  Ping ?:)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19913

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

[Adriaan de Groot]

adridg added a comment.


  Config: Using QtTest library 5.12.1, Qt 5.12.1 (x86_64-little_endian-lp64 
shared (dynamic) release build; by Clang 6.0.1 (tags/RELEASE_601/final 335540))
  PASS   : KProcessListTest::initTestCase()
  
PASS   : KProcessListTest::testKProcessInfoConstructionAssignment()
FAIL!  : KProcessListTest::testProcessInfoList() 'processInfoList.empty() 
== false' returned FALSE. ()
   Loc: 
[/home/adridg/src/kde/tier-1/kcoreaddons/autotests/kprocesslisttest.cpp(89)]
FAIL!  : KProcessListTest::testProcessInfo() 'processInfo.isValid() == 
true' returned FALSE. ()
   Loc: 
[/home/adridg/src/kde/tier-1/kcoreaddons/autotests/kprocesslisttest.cpp(108)]
PASS   : KProcessListTest::testProcessInfoNotFound()
PASS   : KProcessListTest::cleanupTestCase()
Totals: 4 passed, 2 failed, 0 skipped, 0 blacklisted, 1ms
  
  I'll chase this for 34 minutes now (until 2pm)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20026: Go up in folder hierachy when in "edit mode"

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> kurlnavigator.cpp:400
> +while (hasParent) {
> +urlList.append(currentDirectory.path());
> +hasParent = (currentDirectory != 
> QUrl(parentDirectory(currentDirectory.path(;

Use `toLocalFile()` instead of `path()`, otherwise it breaks on Windows

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20041: [balooctl] Reduce nesting level for addOption arguments, cleanup

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20041

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20026: Go up in folder hierachy when in "edit mode"

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks, this works great in Dolphin. However it does not work properly in 
Gwenview; the URL Navigator switches back to breadcrumbs mode every time the Up 
arrow is pressed. I've also got come coding and style suggestions:

INLINE COMMENTS

> CMakeLists.txt:15
>defaultviewadapter.cpp
> -
>kdiroperator.cpp

Unrelated whitespace change

> CMakeLists.txt:42
>kurlnavigatorpathselectoreventfilter.cpp
> -
> -

Unrelated whitespace change

> kurlnavigator.cpp:54
>  #include 
> +#include 
>  #include 

Don't want this in production code

> kurlnavigator.cpp:124
> +
>  
>  /**

Unrelated whitespace change

> kurlnavigator.cpp:348
> + */
> +slotToggleEditableButtonPressed();
> +QTimer::singleShot(10, q->editor()->lineEdit(), SLOT(setFocus()));

This works in Dolphin, but causes the navigator to switch back to breadcrumbs 
mode in Gwenview. I think we need to instead fix whatever bug is causing the 
desire for thus ugly hack. :)

> kurlnavigator.cpp:387
> + if (slash == -1)
> + return QString();
> + else if (slash == 0)

Coding style: don't omit braces for single-line conditionals

> kurlnavigator.cpp:402
> +hasParent = (currentDirectory != 
> QUrl(parentDirectory(currentDirectory.path(;
> +qInfo() << currentDirectory.path();
> +currentDirectory = QUrl(parentDirectory(currentDirectory.path()));

Don't want this in production code

> kurlnavigator.cpp:425
>  }
> -
>  switchView();

Unrelated whitespace change

> kurlnavigator.cpp:474
> +} else {
> +m_pathBox->installEventFilter(q);
>  }

This feels like a hack

> kurlnavigator.cpp:561
>  q->setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);
> -
>  m_pathBox->show();

Unrelated whitespace change

> kurlnavigator.cpp:1287
> +emit keyUpPressed();
> +return true;
> +} else if (actualEvent->key() == Qt::Key_Down) {

You could remove the `true` from these

> kurlnavigator.h:495
>  Private *const d;
> -
>  Q_DISABLE_COPY(KUrlNavigator)

Unrelated whitespace change

> kurlcombobox.h:113
>  void setUrls(const QStringList &urls);
> + void setUrls(const QStringList &urls, bool removeOld);
>  

Too much indentation

> kurlcombobox.h:123
>  void setUrls(const QStringList &urls, OverLoadResolving remove);
> +void setUrls(const QStringList &urls, OverLoadResolving remove, bool 
> removeOld);
>  

In general we prefer using Enums rather than bools for function arguments. It 
makes the code much more readable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20026: Go up in folder hierachy when in "edit mode"

[Nathaniel Graham]

ngraham retitled this revision from "Bug 195801 - go up in folder hierachy when 
in "edit mode"" to "Go up in folder hierachy when in "edit mode"".
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19779: point readme to the wiki page

[Harald Sitter]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:998982a47cbc: point readme to the wiki page (authored by 
sitter).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19779?vs=53944&id=54849

REVISION DETAIL
  https://phabricator.kde.org/D19779

AFFECTED FILES
  src/kconf_update/README.kconf_update

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19779: point readme to the wiki page

[Harald Sitter]

sitter added a comment.


  I am taking silence as indifference.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19779

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

[David Edmundson]

davidedmundson added subscribers: adridg, vonreth.
davidedmundson added a comment.


  Awesome progress. Thanks ever so much.
  
  @vonreth  could you test the windows side for us and tell us how to do the 
unit test?
  
  @adridg could you run this on BSD. You should just need to run 
./bin/kprocesslisttest and see if it passes.

INLINE COMMENTS

> kprocesslist.cpp:38
> +KProcessInfoPrivate::KProcessInfoPrivate(KProcessInfo* q) :
> +q_ptr(q),
> +valid(false),

we don't need a q_ptr

It's only useful if the private object needs to signal things upwards.  
Our data structure is static.

> kprocesslist.cpp:65
> +{
> +d_ptr->valid = true;
> +d_ptr->pid = other.pid();

x = ProcessInfo()
x.valid() == false;
y=x;
y.valid() == true;

But you can simplify all this and the other one to

*d_ptr = *other.d_ptr;

> kprocesslist.cpp:72
> +KProcessInfo::~KProcessInfo()
> +{
> +}

delete d_ptr;

OR

replace make d_ptr a QScopedPointer

OR

make it a QSharedDataPointer  and our KProcessInfoPrivate inherit from 
QSharedData
(which is a bit more work but my favourite option)

> kprocesslist.h:51
> +KProcessInfo();
> +KProcessInfo(qint64 pid, QString name, QString user);
> +KProcessInfo(const KProcessInfo &other);

qint64 pid, const QString &name, const QString &user

it saves a string shallow copy

> kprocesslist_p.h:48-49
> +QString name;
> +QString image;
> +QString state;
> +QString user;

We should probably either kill these 2 or use them.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20060: [KDynamicJobTracker] Use generated DBus interface

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Avoids doing a blocking introspection call.

TEST PLAN
  Started a file copy, noticed there was an introspection call somewhere, 
changed it to use a generated dbus cpp file we already had anyway: call 
succeds, dont get a copy wiget dialog as the job view server returns false.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20060

AFFECTED FILES
  src/widgets/kdynamicjobtracker.cpp

To: broulik, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14598: Keep checking return value from calling browse_stat_path() in SMBSlave::stat() in sync with SMBSlave::listDir()

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.


  I don't really know this code, but I don't know who does

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14598

To: habacker, dfaure
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/32/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 26 Mar 2019 05:59:12 +
 Build duration:
4 hr 10 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 53 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/53/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 25 Mar 2019 21:02:33 +
 Build duration:
12 hr and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)