D20219: Propose Stefan Bruns as KFileMetaData maintainer

[Alexander Stippich]

astippich added a comment.


  I think @bruns is much more qualified than me as a maintainer as I lack 
overall experience in programming. He still finds wrong stuff in almost any 
revision of mine :)
  also +1 for baloo

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20219

To: apol, #frameworks, mgallien
Cc: mgallien, bruns, ngraham, astippich, kde-frameworks-devel, #baloo, gennad, 
domson, ashaposhnikov, michaelh, spoorun, abrahams

D20219: Propose Stefan Bruns as KFileMetaData maintainer

[Matthieu Gallien]

mgallien added subscribers: bruns, mgallien.
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  Thanks for all the work going on. I am really happy to see all the work done 
by @bruns

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20219

To: apol, #frameworks, mgallien
Cc: mgallien, bruns, ngraham, astippich, kde-frameworks-devel, #baloo, gennad, 
domson, ashaposhnikov, michaelh, spoorun, abrahams

D20219: Propose Stefan Bruns as KFileMetaData maintainer

[Nathaniel Graham]

ngraham added subscribers: astippich, ngraham.
ngraham added a comment.


  I'd say Baloo too, or instead. In fact @astippich has been doing a lot of 
high quality work for KFileMetadata too.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20219

To: apol, #frameworks
Cc: ngraham, astippich, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, spoorun, bruns, abrahams

D20219: Propose Stefan Bruns as KFileMetaData maintainer

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  He has been doing most of the work lately and seems very active, I'd say he is
  at the moment the person most qualified to maintain the framework.

TEST PLAN
  Actually it's yellow on build.kde.org at the moment, maybe it's something to 
sort out
  https://build.kde.org/job/Frameworks/job/kfilemetadata/

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20219

AFFECTED FILES
  metainfo.yaml

To: apol, #frameworks
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/56/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 03 Apr 2019 00:15:53 +
 Build duration:
9 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)84%
(3323/3975)47%
(4471/9539)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1092/1120)49%
(2289/4707)src79%
(22/28)79%
(22/28)79%
(1212/1537)43%
(476/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/61/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 03 Apr 2019 00:14:36 +
 Build duration:
6 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)84%
(3323/3975)47%
(4471/9539)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1092/1120)49%
(2289/4707)src79%
(22/28)79%
(22/28)79%
(1212/1537)43%
(476/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/55/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 03 Apr 2019 00:09:11 +
 Build duration:
6 min 40 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(53/60)88%
(53/60)84%
(3315/3969)47%
(4523/9647)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)97%
(1088/1116)49%
(2343/4817)src78%
(21/27)78%
(21/27)79%
(1208/1535)43%
(474/1114)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/60/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 03 Apr 2019 00:09:11 +
 Build duration:
5 min 24 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(53/60)88%
(53/60)84%
(3315/3969)47%
(4523/9647)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)97%
(1088/1116)49%
(2343/4817)src78%
(21/27)78%
(21/27)79%
(1208/1535)43%
(474/1114)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/61/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 03 Apr 2019 00:11:04 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.extractorcoveragetest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/60/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 03 Apr 2019 00:09:11 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.extractorcoveragetest

D20032: Convert string formatting tests to be data driven

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4d48330829d9: Convert string formatting tests to be data 
driven (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20032?vs=55073=55322

REVISION DETAIL
  https://phabricator.kde.org/D20032

AFFECTED FILES
  autotests/propertyinfotest.cpp
  autotests/propertyinfotest.h

To: bruns, #baloo, #frameworks, ngraham, astippich, apol
Cc: mgallien, apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20031: Declare PropertyInfo as QMetaType

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:e02feb62049e: Declare PropertyInfo as QMetaType (authored 
by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20031?vs=54740=55321

REVISION DETAIL
  https://phabricator.kde.org/D20031

AFFECTED FILES
  src/propertyinfo.cpp
  src/propertyinfo.h

To: bruns, #baloo, #frameworks, ngraham, astippich, apol
Cc: apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20032: Convert string formatting tests to be data driven

[Stefan Brüns]

bruns added a comment.


  In D20032#442635 , @apol wrote:
  
  > Whatever.
  >  @bruns Have you considered becoming the module maintainer? :)
  
  
  Thats fine for me. Where do I have to deliver my soul? ;-)

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20032

To: bruns, #baloo, #frameworks, ngraham, astippich, apol
Cc: mgallien, apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20031: Declare PropertyInfo as QMetaType

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20031

To: bruns, #baloo, #frameworks, ngraham, astippich, apol
Cc: apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20032: Convert string formatting tests to be data driven

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Whatever.
  @bruns Have you considered becoming the module maintainer? :)

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20032

To: bruns, #baloo, #frameworks, ngraham, astippich, apol
Cc: mgallien, apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20031: Declare PropertyInfo as QMetaType

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20031

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20032: Convert string formatting tests to be data driven

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20032

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: mgallien, apol, kde-frameworks-devel, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20033: Default string formatting test to C locale, add localized run

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20033

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20046: Verify mimetypes for all existing sample files, add some more

[Stefan Brüns]

bruns added a subscriber: bcooksley.
bruns added a comment.


hexdump -n 11 -C autotests/samplefiles/test.AppImage
  7f 45 4c 46 02 01 01 00  41 49 02 |.ELFAI.|
  
  
  
grep -v comment /usr/share/mime/packages/freedesktop.org.xml  | grep -B13 
'*\.appimage' 
  




  

  

  

  


--
  




  

  

  

  


  
  so obviously application/vnd.appimage is correct.
  
  @bcooksley #freebsd  - the shared 
mime data on BSD is outdated:
  
https://gitlab.freedesktop.org/xdg/shared-mime-info/commit/c643cab25b8a4ea17e73eae5bc318c840f0e3d4b

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20046

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: bcooksley, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  rating_write2

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20121: Test ffmpeg extractor using mime type helper

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_mimetypes

REVISION DETAIL
  https://phabricator.kde.org/D20121

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20216: Export path of kwalletd binary for kwallet_pam

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20216

To: davidedmundson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18365: Add a flag to keep a window on top

[Kai Uwe Broulik]

broulik added a comment.


  +1 also needed for critical notifications, cf D20154 


REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18365

To: davidedmundson, #kwin
Cc: broulik, apol, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20216: Export path of kwalletd binary for kwallet_pam

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  kwallet_pam requires the path to the kwalletd binary. Currently this is
  hardcoded.

TEST PLAN
  Looked at generated file

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20216

AFFECTED FILES
  src/api/KWallet/CMakeLists.txt
  src/api/KWallet/KF5WalletConfig.cmake.in

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20210: [Label] Bump import version so padding properties are available

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  The following works now
  
PlasmaComponents.Label {
leftPadding: ...
}

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20210

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/Label.qml

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19446: DocumentPrivate: Support auto bracket in block selection mode

[loh tar]

loh.tar updated this revision to Diff 55303.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Set proper start/end column independent  from selection direction.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19446?vs=55284=55303

REVISION DETAIL
  https://phabricator.kde.org/D19446

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20121: Test ffmpeg extractor using mime type helper

[Alexander Stippich]

astippich updated this revision to Diff 55301.
astippich added a comment.


  - add friend and use member function

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20121?vs=55059=55301

BRANCH
  ffmpeg_mimetypes

REVISION DETAIL
  https://phabricator.kde.org/D20121

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  src/extractors/ffmpegextractor.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Hallas]

hallas created this revision.
hallas added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Add support for KBookmarkOwner to communicate if it has tabs open. This
  is used by KBookmarkMenu to only add the `Bookmark Tabs as Folder...`
  entry if the KBookmarkOwner supports tabs and actually has tabs open.
  KBookmarkMenu will also keep track of if the state of tabs open changes
  and add/remove the menu entry accordingly.

TEST PLAN
  Unit test added

REPOSITORY
  R294 KBookmarks

BRANCH
  add_tabs_open (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20209

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kbookmarkmenutest.cpp
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h
  src/kbookmarkowner.h

To: hallas, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich updated this revision to Diff 55298.
astippich added a comment.


  - cleanup and formatting

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18604?vs=55127=55298

BRANCH
  rating_write2

REVISION DETAIL
  https://phabricator.kde.org/D18604

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18845: authority: add support for passing details to polkit

[Nathaniel Graham]

ngraham added a comment.


  Landed and changed the comment. @chinmoyr, what's next for T8075: Fix 
security issues with KAuth support in KIO ?

REPOSITORY
  R563 Polkit-1 Qt Library

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns, davidedmundson
Cc: elvisangelaccio, ngraham, mati865, kde-frameworks-devel

D18845: authority: add support for passing details to polkit

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R563:f26ada834aea: authority: add support for passing details 
to polkit (authored by mgerstner, committed by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18845?vs=54931=55297#toc

REPOSITORY
  R563 Polkit-1 Qt Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18845?vs=54931=55297

REVISION DETAIL
  https://phabricator.kde.org/D18845

AFFECTED FILES
  core/polkitqt1-authority.cpp
  core/polkitqt1-authority.h

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns, davidedmundson
Cc: elvisangelaccio, ngraham, mati865, kde-frameworks-devel

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/59/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 02 Apr 2019 18:29:11 +
 Build duration:
6 min 59 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(53/60)88%
(53/60)84%
(3315/3962)47%
(4523/9647)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)97%
(1088/1116)49%
(2343/4817)src78%
(21/27)78%
(21/27)79%
(1208/1528)43%
(474/1114)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/54/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 02 Apr 2019 18:29:11 +
 Build duration:
7 min 12 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(53/60)88%
(53/60)84%
(3315/3962)47%
(4523/9647)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)97%
(1088/1116)49%
(2343/4817)src78%
(21/27)78%
(21/27)79%
(1208/1528)43%
(474/1114)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D20046: Verify mimetypes for all existing sample files, add some more

[Alexander Stippich]

astippich added a comment.


  This causes one test failure on FreeBSD:
  
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/51/

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20046

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/59/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 02 Apr 2019 18:29:11 +
 Build duration:
1 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.extractorcoveragetest

D20082: Safeguard against invalid files

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:1ac4253f3cf0: Safeguard against invalid files (authored 
by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20082?vs=54958=55296

REVISION DETAIL
  https://phabricator.kde.org/D20082

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20208: Fix uninitialized memory read in KZip

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:299f5cae228c: Fix uninitialized memory read in KZip 
(authored by aacid).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20208?vs=55293=55295

REVISION DETAIL
  https://phabricator.kde.org/D20208

AFFECTED FILES
  src/kzip.cpp

To: aacid, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20208: Fix uninitialized memory read in KZip

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20208

To: aacid, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:81a8d573ecaf: DocumentPrivate: Add option Auto 
Reload Document to View menu (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19517?vs=55199=55294

REVISION DETAIL
  https://phabricator.kde.org/D19517

AFFECTED FILES
  src/data/katepart5ui.rc
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D20208: Fix uninitialized memory read in KZip

[Albert Astals Cid]

aacid added a subscriber: dfaure.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20208

To: aacid
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20208: Fix uninitialized memory read in KZip

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  We were passing handledextralen instead of n to parseExtraField
  
  We could also do a n < parseExtraField check earlier and fail, but given that 
parseExtraField always returns true and it has good checks for not over-reading 
from the buffer it seemed better just to pass n and let it parse as much as 
possible

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20208

AFFECTED FILES
  src/kzip.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18845: authority: add support for passing details to polkit

[David Edmundson]

davidedmundson accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns, davidedmundson
Cc: elvisangelaccio, ngraham, mati865, kde-frameworks-devel

D18845: authority: add support for passing details to polkit

[Nathaniel Graham]

ngraham added a comment.


  So what's next for this? Can this land now or do we need to change the 
comment first?

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: elvisangelaccio, ngraham, mati865, kde-frameworks-devel

D20197: Fix desktop link filter

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This doesn't work. Try creating a symlink to a directory. In the file picker 
dialog, the Open button doesn't work.
  
  See https://bugs.kde.org/show_bug.cgi?id=357171 for more context.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

[Aleix Pol Gonzalez]

apol retitled this revision from "Depends on D20191" to "Expose locked 
keystates on KModifierKeyInfo when on wayland".
apol edited the summary of this revision.
apol added a dependency: D20191: Proof of concept of a wayland protocol to 
allow the keystate dataengine to work.

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

[Aleix Pol Gonzalez]

apol added a dependent revision: D20193: Expose locked keystates on 
KModifierKeyInfo when on wayland.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20191

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20197: Fix desktop link filter

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19446: DocumentPrivate: Support auto bracket in block selection mode

[loh tar]

loh.tar updated this revision to Diff 55284.
loh.tar added a comment.


  - QCOMPARE also the selection in tests

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19446?vs=55280=55284

REVISION DETAIL
  https://phabricator.kde.org/D19446

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19446: DocumentPrivate: Support auto bracket in block selection mode

[loh tar]

loh.tar added a comment.


  >> Feature or bug? Select in block mode from right->left on a single line 
after last char a block. The brackets are exchanged )( and placed at the end of 
the block
  > 
  > Hmm, I think this counts as a bug.
  
  Have trouble to reproduce now. Was that fixed somewhere? Qt? Strange.

REVISION DETAIL
  https://phabricator.kde.org/D19446

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19446: DocumentPrivate: Support auto bracket in block selection mode

[loh tar]

loh.tar updated this revision to Diff 55280.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Add some auto tests

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19446?vs=55272=55280

REVISION DETAIL
  https://phabricator.kde.org/D19446

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven added a comment.


  After this patch I intend to update KFileItemPrivate::init to add birthtime 
there in the same manner.
  Perhaps it would be good to group the stax/QL_STAT code somewhere rather than 
spread.
  
  And then there is baloo-widgets and perhaps some dolphin work for this to 
flow to the UIs, or even gwenview.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20202: FrameSvgItem: add "mask" property

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D20203: desktoppackage: add "panelMask" 
property for Panel.qml.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20202

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20202: FrameSvgItem: add "mask" property

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  This property allows e.g. the Plasma shell to query the shape a panel has
  when defining the area for BlurBehind.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  framesvgitemaddmaskproperty

REVISION DETAIL
  https://phabricator.kde.org/D20202

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp
  src/declarativeimports/core/framesvgitem.h
  src/plasmaquick/dialog.cpp

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19446: DocumentPrivate: Support auto bracket in block selection mode

[loh tar]

loh.tar updated this revision to Diff 55272.
loh.tar added a comment.


  - Rebase on master

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19446?vs=52906=55272

REVISION DETAIL
  https://phabricator.kde.org/D19446

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/59/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 02 Apr 2019 12:38:09 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 58 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/58/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 02 Apr 2019 12:04:16 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20193: Depends on D20191

[David Faure]

dfaure added a comment.


  Still no description visible here :)

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/47/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 02 Apr 2019 12:09:12 +
 Build duration:
3 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/55/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 02 Apr 2019 12:09:11 +
 Build duration:
3 min 59 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> keystate.xml:34
> +  
> +  
> +  

I would just send the initial stateChanged on bind

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20191

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/54/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 02 Apr 2019 12:04:16 +
 Build duration:
4 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1814/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/46/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 02 Apr 2019 12:04:16 +
 Build duration:
4 min 55 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1814/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:9de0def99f96: [Dialog] Dont forward hover event 
when there is nowhere to forward it to (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20200?vs=55264=55268

REVISION DETAIL
  https://phabricator.kde.org/D20200

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20199: [Menu] Fix triggered sign

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:9aa249e86a34: [Menu] Fix triggered signal (authored by 
broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20199?vs=55263=55267

REVISION DETAIL
  https://phabricator.kde.org/D20199

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  We have a bug report about infinite loop in the notifications.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20200

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20200: [Dialog] Don't forward hover event when there is nowhere to forward it to

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Dialog has this clever way of re-sending a mouse event inside the bounardies 
of the dialog, so despite visual padding, the items can be clicked on any 
corner following Fitt's law.
  However, when the `mainItem` has no size, adjusting the position will adjust 
it inside the border since there is no pixel inside the main item, leading to 
infinite recursion as the event is processed again and again and again leading 
to a crash.

TEST PLAN
  Opened a `Dialog` with a `mainItem` without a `width`, dialog showed up tiny, 
hovered it, no longer crashed
  Verified that event is still forwarded in the normal case.
  
  I bet there's a tonne of crash reports like this (crash in `Dialog::event` in 
recursion) on bugzilla since an empty dialog could happen in case of a failure 
to load some QML bits.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20200

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20199: [Menu] Fix triggered sign

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20199

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20199: [Menu] Fix triggered sign

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It casted the `QAction` to a `MenuItem` which fails because it isn't such.
  Instead, manually find the item with the corresponding action.

TEST PLAN
PlasmaComponents.ContextMenu {
onTriggered: console.log(item)
}
  
  works now

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20199

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: CI system maintainability

[Ben Cooksley]

On Sat, Mar 30, 2019 at 10:46 PM Volker Krause  wrote:
>
> On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote:
> > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl
> > > I fear that a mandatory reviews would add too juch strain on smaller
> > > teams. If there's just one person with an intimate knowledge of the
> > > code-base, plus two co-developers, then who should do the reviews?
> > >
> > > How about a distinction based on importance of a project instead? I.e.
> > > mandatory reviews for frameworks and any app that wants to be included in
> > > KDE apps releases. Non-mandatory reviews can then also come with a
> > > "price" to pay: if CI errors are not dealt with in a timely manner, you
> > > should be free to disable the CI for administrative reasons...
> > While this does seem like a nice solution, unfortunately for many
> > repositories it isn't a case of disabling CI coverage for it, but also
> > CI coverage for everything that depends on it. In the case of
> > KContacts, this would also impact on parts of Extragear and Calligra
> > (who depending on their exact requirements would either lose a
> > dependency being available, or lose all of their CI coverage).
> >
> > This is why i've not pursued this as an option in the past, because
> > it's not fair on other projects that don't have anything to do with
> > another project aside from being a user of it's interfaces to lose
> > their coverage, simply because the project they depend on is broken.
>
> I agree that anything on the CI level would be merely a workaround for this at
> best. I'd rather suggest we address this at the source by turning the
> externally used modules into frameworks. We did that last year already for
> KHolidays and Syndication who were used by Plasma among others. KContacts,
> KCalCore and KMime should follow that next IMHO.
>
> The next time window to do that relatively painlessly is coming up after the
> 19.04 applications release I think, and all of those have been part of the
> KDE4-era kdepimlibs module that complied with KF5-like ABI guarantees, so the
> necessary work should be limited hopefully. Extra review of the public
> interfaces would certainly help with making this happen I think.

This would certainly help resolve many of the issues I think, because
then the build issues should be mostly contained to one specific
Product, which makes this much easier to work with in the long term.

>
> Regards,
> Volker

Cheers,
Ben

D20197: Fix desktop link filter

[Robert Hoffmann]

hoffmannrobert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  Set FileMode of the QFileDialog to QFileDialog::AnyFile instead of
  QFileDialog::Directory if KUrlRequester is to apply mode
  'KFile::File | KFile::Directory'.

TEST PLAN
  Right click onto desktop, select 'Create new' and then
  'Basic link to file or directory' or 'Link to Location (URL)'.
  Click the file selection icon.
  Without this patch only directories are shown, with the patch
  applied files and directories are shown.

REPOSITORY
  R241 KIO

BRANCH
  fix_desktop_link_filter

REVISION DETAIL
  https://phabricator.kde.org/D20197

AFFECTED FILES
  src/widgets/kurlrequester.cpp

To: hoffmannrobert
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20196: RFC: Add Notify capability to KConfigXT

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> kcoreconfigskeleton.h:217
>   */
>  template < typename T > class KConfigSkeletonGenericItem: public 
> KConfigSkeletonItem
>  {

Can you move the new flag into KConfigSkeletonItem which is d-pointered and 
expose write flags with a protected accessor?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D20196

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19876: Fix: apply correctly the text colors of the chosen scheme

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  I think this is good enough as it is.
  I would prefer that we in the future just switch over to use the 
syntax-highlighting themes, but that is a lot of work :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19876

To: nibags, #ktexteditor, #kate, cullmann, mwolff
Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, 
domson, michaelh, ngraham, bruns, demsking, sars

D20196: RFC: Add Notify capability to KConfigXT

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D20196

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20196: RFC: Add Notify capability to KConfigXT

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Lets you specify `Notifiers=` in `.kcfg` for config entries that should be 
written with `Notify` flag, i.e. announce the change to `KConfigWatcher`

TEST PLAN
  `KConfigCoreSkeleton` isn't exported but there's many classes that inherit 
from it (which I missed when I wrote this patch).
  Since it's not d-pointered, I cannot add a member variable to it, hence the 
RFC. Any suggestion on how to address this?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D20196

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_notifiers.cpp.ref
  autotests/kconfig_compiler/test_notifiers.h.ref
  autotests/kconfig_compiler/test_notifiers.kcfg
  autotests/kconfig_compiler/test_notifiers.kcfgc
  autotests/kconfig_compiler/test_notifiers_main.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 66 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/66/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 01 Apr 2019 23:56:50 +
 Build duration:
8 hr 11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_threadtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(263/399)66%
(263/399)54%
(32967/60629)39%
(17138/44481)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests98%
(56/57)98%
(56/57)95%
(9289/9771)48%
(4354/9111)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8473/14451)51%
(4766/9358)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4344/8049)40%
(1918/4821)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

D19876: Fix: apply correctly the text colors of the chosen scheme

[Nibaldo González]

nibags added a comment.


  I have tested this a lot and it works well so far. I don't know if you have 
any disagreement with the last update (for example, using `setTheme()` with an 
empty theme, although I haven't seen this cause any problems)...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19876

To: nibags, #ktexteditor, #kate, cullmann, mwolff
Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, 
domson, michaelh, ngraham, bruns, demsking, sars

D20195: Doxygen: don't use black color in tags

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:3c5f212c90ef: Doxygen: dont use black color in tags 
(authored by nibags).
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20195?vs=55255=55256

REVISION DETAIL
  https://phabricator.kde.org/D20195

AFFECTED FILES
  autotests/html/highlight.cpp.html
  autotests/html/highlight.dox.html
  autotests/html/test.c.html
  autotests/html/test.jsx.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  data/syntax/doxygen.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann