D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:47af5254b039: Add notifications and 
notifications-disabled icons (authored by GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20226?vs=55420=55451

REVISION DETAIL
  https://phabricator.kde.org/D20226

AFFECTED FILES
  icons-dark/actions/16/notifications-disabled.svg
  icons-dark/actions/16/notifications.svg
  icons/actions/16/notifications-disabled.svg
  icons/actions/16/notifications.svg

To: GB_2, #plasma, #vdg, ngraham, ndavis
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20197: Fix desktop link to file or directory

2019-04-04 Thread Nathaniel Graham 
ngraham added a comment.


  This is the right way to show a directory chooser dialog: 
https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/image.cpp#n356

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15872: Fix Oxygen background gradient for QML modules

2019-04-04 Thread Nathaniel Graham 
ngraham reopened this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh, I think I misunderstood your comment, @davidedmundson. You were saying we 
should merge this //after// tagging, duh. Reverted for now, and I'll re-merge 
it after tagging.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg, #plasma, davidedmundson
Cc: ngraham, davidedmundson, filipf, kde-frameworks-devel, michaelh, bruns

D15872: Fix Oxygen background gradient for QML modules

2019-04-04 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R295:3fe124c7f411: Fix Oxygen background gradient for QML 
modules (authored by hwti, committed by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15872?vs=42644=55450#toc

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15872?vs=42644=55450

REVISION DETAIL
  https://phabricator.kde.org/D15872

AFFECTED FILES
  src/kcmoduleqml.cpp

To: hwti, mart, #vdg, #plasma, davidedmundson
Cc: davidedmundson, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Noah Davis 
ndavis accepted this revision.
ndavis added a comment.


  Those curves are perfect 

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg, ngraham, ndavis
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/19/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 05 Apr 2019 00:00:11 +
 Build duration:
1 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D20230: Allow building without UDev on Linux

2019-04-04 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:124760e1a383: Allow building without UDev on Linux 
(authored by apol).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20230?vs=55353=55448

REVISION DETAIL
  https://phabricator.kde.org/D20230

AFFECTED FILES
  CMakeLists.txt

To: apol, #frameworks, davidedmundson
Cc: asturmlechner, davidedmundson, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15872: Fix Oxygen background gradient for QML modules

2019-04-04 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  We are really bad at letting reviews get lost and unnoticed. I'm really sorry!
  
  Tagging is on Saturday, so best to merge next week for proper testing.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg, #plasma, davidedmundson
Cc: davidedmundson, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 61 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/61/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 04 Apr 2019 21:52:50 +
 Build duration:
6 min 26 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.propertyinfotest_enFailed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)85%
(3645/4294)48%
(5029/10574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1259/1289)49%
(2517/5157)src79%
(22/28)79%
(22/28)79%
(1218/1537)43%
(479/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)99%
(207/209)54%
(398/734)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/67/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 04 Apr 2019 21:52:50 +
 Build duration:
5 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.propertyinfotest_enFailed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)85%
(3645/4294)48%
(5029/10574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1259/1289)49%
(2517/5157)src79%
(22/28)79%
(22/28)79%
(1218/1537)43%
(479/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)99%
(207/209)54%
(398/734)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 67 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/67/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 04 Apr 2019 21:52:50 +
 Build duration:
1 min 42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.extractorcoveragetestFailed: projectroot.autotests.propertyinfotest_en

D20033: Default string formatting test to C locale, add localized run

2019-04-04 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:a5130d940fb4: Default string formatting test to C locale, 
add localized run (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20033?vs=54742=55441

REVISION DETAIL
  https://phabricator.kde.org/D20033

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/propertyinfotest.cpp
  autotests/propertyinfotest.h

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D15872: Fix Oxygen background gradient for QML modules

2019-04-04 Thread Filip Fila 
filipf added a reviewer: Plasma.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg, #plasma
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15872: Fix Oxygen background gradient for QML modules

2019-04-04 Thread Filip Fila 
filipf added a comment.


  Ping.
  
  Is this actually what's been causing the following problem?
  
  F6753947: image.png 

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D20244: [AppletInterface] Check for corona before accessing it

2019-04-04 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20244

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20033: Default string formatting test to C locale, add localized run

2019-04-04 Thread Alexander Stippich 
astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  works nicely!

REPOSITORY
  R286 KFileMetaData

BRANCH
  i18n

REVISION DETAIL
  https://phabricator.kde.org/D20033

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/66/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 04 Apr 2019 17:09:20 +
 Build duration:
2 min 51 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)85%
(3628/4276)48%
(5009/10540)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1242/1271)49%
(2497/5123)src79%
(22/28)79%
(22/28)79%
(1218/1537)43%
(479/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)99%
(207/209)54%
(398/734)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 60 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/60/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 04 Apr 2019 17:04:37 +
 Build duration:
6 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)85%
(3628/4276)48%
(5009/10540)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1242/1271)49%
(2497/5123)src79%
(22/28)79%
(22/28)79%
(1218/1537)43%
(479/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)99%
(207/209)54%
(398/734)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/65/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 04 Apr 2019 17:00:08 +
 Build duration:
9 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)84%
(3475/4123)47%
(4833/10203)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1144/1173)49%
(2397/4925)src79%
(22/28)79%
(22/28)79%
(1218/1537)43%
(479/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)99%
(152/154)54%
(322/595)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

2019-04-04 Thread Alexander Stippich 
astippich added inline comments.

INLINE COMMENTS

> propertydata.cpp:88
> +if (it.value().isArray()) {
> +const auto values = it.value().toArray();
> +for (const auto val : values) {

Can you return arrays as lists here so that current behavior is unchanged, and 
put the behavior change into another patch so that we can merge this diff?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19087

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: mgallien, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 66 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/66/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 04 Apr 2019 17:03:39 +
 Build duration:
1 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.extractorcoveragetest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 59 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/59/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 04 Apr 2019 16:58:43 +
 Build duration:
5 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)84%
(3475/4123)47%
(4833/10203)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1144/1173)49%
(2397/4925)src79%
(22/28)79%
(22/28)79%
(1218/1537)43%
(479/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)99%
(152/154)54%
(322/595)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 65 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/65/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 04 Apr 2019 17:02:13 +
 Build duration:
1 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.extractorcoveragetest

D18665: Cleanup taglib writer test

2019-04-04 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:452edb1b4c80: Cleanup taglib writer test (authored by 
astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18665?vs=50711=55429

REVISION DETAIL
  https://phabricator.kde.org/D18665

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

2019-04-04 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:8e79f7ce2b7c: Implement support for writing rating 
information for taglib writer (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18604?vs=55298=55428

REVISION DETAIL
  https://phabricator.kde.org/D18604

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 64 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/64/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 04 Apr 2019 16:57:01 +
 Build duration:
3 min 6 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)84%
(3399/4046)47%
(4626/9807)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)97%
(1086/1114)49%
(2287/4703)src79%
(22/28)79%
(22/28)79%
(1218/1537)43%
(479/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)99%
(134/136)53%
(225/421)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 64 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/64/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 04 Apr 2019 16:58:18 +
 Build duration:
1 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.extractorcoveragetest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 58 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/58/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 04 Apr 2019 16:52:48 +
 Build duration:
5 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)84%
(3399/4046)47%
(4626/9807)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)97%
(1086/1114)49%
(2287/4703)src79%
(22/28)79%
(22/28)79%
(1218/1537)43%
(479/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)99%
(134/136)53%
(225/421)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D18603: Implement more tags for taglib writer

2019-04-04 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:926c70460edc: Implement more tags for taglib writer 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18603?vs=55126=55427

REVISION DETAIL
  https://phabricator.kde.org/D18603

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/63/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 04 Apr 2019 16:52:48 +
 Build duration:
4 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)84%
(3399/4046)47%
(4626/9807)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)97%
(1086/1114)49%
(2287/4703)src79%
(22/28)79%
(22/28)79%
(1218/1537)43%
(479/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)99%
(134/136)53%
(225/421)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 63 - Still Unstable!

2019-04-04 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/63/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 04 Apr 2019 16:52:48 +
 Build duration:
1 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.extractorcoveragetest

D18601: Rewrite taglib writer to use property interface

2019-04-04 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:982ebe58b3c8: Rewrite taglib writer to use property 
interface (authored by astippich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18601?vs=55125=55426#toc

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18601?vs=55125=55426

REVISION DETAIL
  https://phabricator.kde.org/D18601

AFFECTED FILES
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20121: Test ffmpeg extractor using mime type helper

2019-04-04 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:25eca3185ffa: Test ffmpeg extractor using mime type 
helper (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20121?vs=55301=55425

REVISION DETAIL
  https://phabricator.kde.org/D20121

AFFECTED FILES
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  src/extractors/ffmpegextractor.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

2019-04-04 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.12/25/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 04 Apr 2019 16:49:08 +
 Build duration:
56 sec and counting
   CONSOLE OUTPUT
  [...truncated 235 lines...][2019-04-04T16:49:54.164Z] -- Check for working CXX compiler: /usr/bin/c++[2019-04-04T16:49:54.420Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-04-04T16:49:54.420Z] -- Detecting CXX compiler ABI info[2019-04-04T16:49:54.420Z] -- Detecting CXX compiler ABI info - done[2019-04-04T16:49:54.420Z] -- Detecting CXX compile features[2019-04-04T16:49:54.982Z] -- Detecting CXX compile features - done[2019-04-04T16:49:54.982Z] -- Looking for __GLIBC__[2019-04-04T16:49:55.238Z] -- Looking for __GLIBC__ - found[2019-04-04T16:49:55.239Z] -- Performing Test _OFFT_IS_64BIT[2019-04-04T16:49:55.239Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-04-04T16:49:55.239Z] -- Performing Test HAVE_DATE_TIME[2019-04-04T16:49:55.494Z] -- Performing Test HAVE_DATE_TIME - Success[2019-04-04T16:49:55.494Z] -- Found KF5Kirigami2: /home/jenkins/install-prefix/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.57.0") [2019-04-04T16:49:55.494Z] -- Found KF5: success (found suitable version "5.57.0", minimum required is "5.56.0") found components:  Kirigami2 [2019-04-04T16:49:55.494Z] -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.57.0") [2019-04-04T16:49:55.494Z] -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.57.0") [2019-04-04T16:49:55.494Z] -- Found KF5: success (found suitable version "5.57.0", minimum required is "5.56.0") found components:  IconThemes ConfigWidgets [2019-04-04T16:49:55.494Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so[2019-04-04T16:49:55.494Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found[2019-04-04T16:49:55.494Z] -- Looking for gethostbyname[2019-04-04T16:49:55.749Z] -- Looking for gethostbyname - found[2019-04-04T16:49:55.749Z] -- Looking for connect[2019-04-04T16:49:55.749Z] -- Looking for connect - found[2019-04-04T16:49:55.749Z] -- Looking for remove[2019-04-04T16:49:55.749Z] -- Looking for remove - found[2019-04-04T16:49:55.749Z] -- Looking for shmat[2019-04-04T16:49:56.005Z] -- Looking for shmat - found[2019-04-04T16:49:56.005Z] -- Looking for IceConnectionNumber in ICE[2019-04-04T16:49:56.005Z] -- Looking for IceConnectionNumber in ICE - found[2019-04-04T16:49:56.005Z] -- Found X11: /usr/lib64/libX11.so[2019-04-04T16:49:56.005Z] -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") [2019-04-04T16:49:56.005Z] -- The following OPTIONAL packages have been found:[2019-04-04T16:49:56.005Z] [2019-04-04T16:49:56.005Z]  * KF5IconThemes (required version >= 5.56.0)[2019-04-04T16:49:56.005Z]  * KF5ConfigWidgets (required version >= 5.56.0)[2019-04-04T16:49:56.005Z]  * X11[2019-04-04T16:49:56.005Z]  * Qt5X11Extras (required version >= 5.10.0)[2019-04-04T16:49:56.005Z]  * PkgConfig[2019-04-04T16:49:56.005Z] [2019-04-04T16:49:56.005Z] -- The following REQUIRED packages have been found:[2019-04-04T16:49:56.005Z] [2019-04-04T16:49:56.005Z]  * ECM (required version >= 5.56.0)[2019-04-04T16:49:56.005Z]  * Qt5Core[2019-04-04T16:49:56.005Z]  * Qt5Network (required version >= 5.12.0)[2019-04-04T16:49:56.005Z]  * Qt5Qml (required version >= 5.12.0)[2019-04-04T16:49:56.005Z]  * Qt5Quick[2019-04-04T16:49:56.005Z]  * Qt5Gui[2019-04-04T16:49:56.005Z]  * Qt5Widgets[2019-04-04T16:49:56.005Z]  * Qt5QuickControls2[2019-04-04T16:49:56.005Z]  * Qt5 (required version >= 5.10.0)[2019-04-04T16:49:56.005Z]  * KF5Kirigami2 (required version >= 5.56.0)[2019-04-04T16:49:56.005Z]  * KF5 (required version >= 5.56.0)[2019-04-04T16:49:56.005Z] [2019-04-04T16:49:56.005Z] -- Configuring done[2019-04-04T16:49:56.005Z] -- Generating done[2019-04-04T16:49:56.005Z] CMake Warning:[2019-04-04T16:49:56.005Z]   Manually-specified variables were not used by the project:[2019-04-04T16:49:56.005Z] [2019-04-04T16:49:56.005Z] BUILD_QCH[2019-04-04T16:49:56.005Z] [2019-04-04T16:49:56.005Z] [2019-04-04T16:49:56.005Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/qqc2-desktop-style/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-04-04T16:49:57.620Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project qqc2-desktop-style --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-04-04T16:49:57.879Z] Scanning dependencies of target qqc2desktopstyleplugin_autogen[2019-04-04T16:49:57.879Z] Scanning dependencies of target org.kde.desktop_autogen[2019-04-04T16:49:57.879Z] [ 10%] Automatic MOC for target

D20197: Fix desktop link to file or directory

2019-04-04 Thread Robert Hoffmann 
hoffmannrobert added a comment.


  Is there a different decided directory chooser than QFileDialog?
  
  It's the way QFileDialog handles directories. If you click a directory, it 
not added to the selection, other than a file, which is. So, if 
QFileDialog::selectedUrls() is called, nothing is in the selection and the 
current path is returned.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20197: Fix desktop link to file or directory

2019-04-04 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, that's confusing. I would recommend using the decided directory chooser 
rather than rolling your own.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much nicer! This is a winner IMO.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg, ngraham
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D19686: don't scale when we are in AA_UseHighDpiPixmaps

2019-04-04 Thread Marco Martin 
mart abandoned this revision.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D19686

To: mart, #plasma, #frameworks
Cc: broulik, ngraham, bruns, fvogt, kde-frameworks-devel, michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber 
GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber 
GB_2 updated this revision to Diff 55420.
GB_2 added a comment.


  Remake icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20226?vs=55347=55420

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

AFFECTED FILES
  icons-dark/actions/16/notifications-disabled.svg
  icons-dark/actions/16/notifications.svg
  icons/actions/16/notifications-disabled.svg
  icons/actions/16/notifications.svg

To: GB_2, #plasma, #vdg
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20197: Fix desktop link to file or directory

2019-04-04 Thread Robert Hoffmann 
hoffmannrobert added a comment.


  You need to double click the directory, so you enter the directory, then 
click Open.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20197: Fix desktop link to file or directory

2019-04-04 Thread Nathaniel Graham 
ngraham added a comment.


  Interesting solution. However the directory use case still doesn't work. If I 
use the directory chooser to choose `/home/nate/Pictures`, the path fiels says 
`/home/nate/` and the file name field says `file:///home/nate/`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19446: DocumentPrivate: Support auto bracket in block selection mode

2019-04-04 Thread loh tar 
loh.tar added a comment.


  In D19446#442303 , @loh.tar wrote:
  
  > >> Feature or bug? Select in block mode from right->left on a single line 
after last char a block. The brackets are exchanged )( and placed at the end of 
the block
  > > 
  > > Hmm, I think this counts as a bug.
  >
  > Have trouble to reproduce now. Was that fixed somewhere? Qt? Strange.
  
  
  Stupid me, didn't understand my own description. :-/
  The behavior still exist and is independent from the selection direction.
  
  Our MovingRange "selectionRange" gets wrong updated in that case. So I think 
it's out of the scope from this patch.
  F6752729: 1554384115.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19446

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20197: Fix desktop link to file or directory

2019-04-04 Thread Robert Hoffmann 
hoffmannrobert added a comment.


  In D20197#442358 , @ngraham wrote:
  
  > This doesn't work. Try creating a symlink to a directory. In the file 
picker dialog, the Open button doesn't work.
  >
  > See https://bugs.kde.org/show_bug.cgi?id=357171 for more context.
  
  
  Yes, sorry. But this works.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20197: Fix desktop link to file or directory

2019-04-04 Thread Robert Hoffmann 
hoffmannrobert retitled this revision from "Fix desktop link filter" to "Fix 
desktop link to file or directory".
hoffmannrobert edited the summary of this revision.
hoffmannrobert edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20197: Fix desktop link filter

2019-04-04 Thread Robert Hoffmann 
hoffmannrobert updated this revision to Diff 55409.
hoffmannrobert added a comment.


  - Add file/directory selection

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20197?vs=55259=55409

BRANCH
  fix_desktop_link_filter

REVISION DETAIL
  https://phabricator.kde.org/D20197

AFFECTED FILES
  src/widgets/kurlrequester.cpp

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20238: device: include reapplyConnection() in the interface

2019-04-04 Thread Jan Grulich 
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D20238

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include reapplyConnection() in the interface

2019-04-04 Thread Aleksander Morgado 
aleksanderm marked an inline comment as done.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D20238

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include reapplyConnection() in the interface

2019-04-04 Thread Aleksander Morgado 
aleksanderm updated this revision to Diff 55395.
aleksanderm retitled this revision from "device: include Reapply() in the 
interface" to "device: include reapplyConnection() in the interface".

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20238?vs=55379=55395

REVISION DETAIL
  https://phabricator.kde.org/D20238

AFFECTED FILES
  src/device.cpp
  src/device.h

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20244: [AppletInterface] Check for corona before accessing it

2019-04-04 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  On plasmashell shutdown when the panels are destroyed, the available screen 
geometry changes.
  When an applet then accesses `screenGeometry` in response to that change, it 
crashes because the corona is already gone.
  
  `availableScreenRegion()` and `availableScreenRect()` already checked for 
this but `screenGeometry()` did not

TEST PLAN
  No longer have plasma crash in shutdown because of notification popup 
placement
  
  Ideally, plasmashell didn't bother signalling those changes on shutdown

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20244

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns