D20647: [Purpose] Make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R495 Purpose Library

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20647

AFFECTED FILES
  CMakeLists.txt
  autotests/menutest.cpp
  src/alternativesmodel.cpp
  src/configuration.cpp
  src/plugins/bluetooth/bluetoothplugin.cpp
  src/plugins/imgur/imgurplugin.cpp
  src/plugins/kdeconnect/kdeconnectplugin.cpp
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.cpp
  src/plugins/ktp-sendfile/ktpsendfileplugin.cpp
  src/plugins/nextcloud/nextcloudjob.cpp
  src/plugins/pastebin/pastebinplugin.cpp
  src/plugins/phabricator/phabricatorjobs.cpp
  src/plugins/phabricator/tests/testphabricator.cpp
  src/plugins/reviewboard/quick/rbrepositoriesmodel.cpp
  src/plugins/reviewboard/quick/rbreviewslistmodel.cpp
  src/plugins/reviewboard/reviewboardjobs.cpp
  src/plugins/saveas/saveasplugin.cpp
  src/plugins/telegram/telegramplugin.cpp
  src/plugins/youtube/youtubejobcomposite.cpp
  tests/tool/main.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20647: [Purpose] Make it compile without foreach

[Laurent Montel]

mlaurent edited the summary of this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D20647

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

[Volker Krause]

vkrause added a comment.


  In D20158#452099 , @broulik wrote:
  
  > @vkrause I just noticed xdg portal notification spec (the ones used for 
sandboxed flatpak apps) has four urgency levels: low, normal, *high*, critical.
  >  Do you think it would be useful to add `HighUrgency`, too? For Android, 
maybe? For freedesktop Notifications we could just map High to Normal then 
(like Gnome does it).
  >  It's not released yet, we can still meddle the enums for another few weeks 
:)
  
  
  Yep, Urgent/High/Normal/Low would indeed match Android perfectly. Adding more 
enum values also should be possible later without breaking compatibility, 
unless we assume them to be in the right order anywhere. If we need them 
ordered, maybe explicitly assign them values to leave some space between them?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20158

To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/37/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 18 Apr 2019 05:54:44 +
 Build duration:
2 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D20639: Remove TODO

[Shubham]

shubham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20639

To: shubham, dfaure, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20620: [balooctl] Switch multiline output to new helper

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in statuscommand.cpp:150
> Do we have to use `auto` here and below?

We hardly ever have to, but I see no reason why an explicit type would be 
helpful here. You wouldn't have objected if I had used `auto filenameIt = 
args.constBegin();`, right?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20620

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

Re: New framework: KCalCore

[Aleix Pol]

On Wed, Apr 17, 2019 at 6:40 PM Volker Krause  wrote:
>
> On Sunday, 14 April 2019 13:31:41 CEST David Faure wrote:
> > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote:
> > > Hi,
> > >
> > > I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> > >
> > > KCalCore is an implementation of the iCalendar standard based on libical,
> >
> > I wonder about the name, which doesn't mean much outside the circle of PIM
> > people. Shouldn't this be called KCalendar ?
> >
> > If the "Core" simply means non-GUI, we certainly don't have that word in
> > every non-GUI framework.
>
> Renaming the namespace should be manageable, we can soften the blow for
> external users with a namespace alias I guess, to at least keep SC until
> everyone has adapted.
>
> > > covering the data model, input/output and the rather complex recurrence
> > > algorithms defined in that standard. It's used outside of KDE PIM as well,
> > > e.g. by Zanshin or the Plasma Mobile calendar app.
> >
> > This makes me wonder: where does that mobile calendar app get the events
> > from? Akonadi? (then it still depends on kde/pim/*, and this move in itself
> > doesn't really remove the unwanted workspace->apps dependency?)
>
> So far it looked like just a local ical file, which I guess is temporary,
> while focusing on mobile UI development. Eventually I at least expect the need
> for KDav there too. So just moving KCalCore isn't going to be enough
> obviously, but it is a necessary first step either way.
>
> > Zanshin does use akonadi (though one could imagine a mobile version that
> > only uses KDav and KCalCore^H^H^H KCalendar).
> >
> > Some review:
> >
> > icalformat_p.h://TODO: KDE5, move this implementation to
> > icalformat_p.cpp incidencebase.h: * // TODO_KDE5: Provide a virtual
> > serialize() method, as done with assign() and equals(). incidencebase.h: *
> > // TODO_KDE5: Provide a virtual serialize() method, as done with assign()
> > and equals(). person.h:// TODO_KDE5: FIXME: This operator does
> > slicing,if the object is in fact one of the derived classes (Attendee)
>
> Person/Attendee I'd like to ideally see split into two non-polymorphic value
> types, as that would make direct QML consumption easier. That would also
> address the slicing risk.

Aliases shouldn't be strictly necessary because the framework can be
called KCal and the target KF5::CalCore, much like in KConfig.

We could decide to have it this way though.

Aleix

D20643: Fix invalid memory write on malformed tar files

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> aacid wrote in ktar.cpp:241
> You mean also printing std::numeric_limits::max() ?

I meant in a comment, but yeah, it's on the warning already.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20643

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20644: Fix memory leak when reading some tar files

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20644

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20643: Fix invalid memory write on malformed tar files

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> apol wrote in ktar.cpp:241
> It could make sense to say that it's because of the maximum size longling can 
> have in a comment.

You mean also printing std::numeric_limits::max() ?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20643

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20641: Fix uninitialized memory use when reading malformed tar files

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20641

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20641: Fix uninitialized memory use when reading malformed tar files

[Albert Astals Cid]

aacid added a comment.


  In D20641#452130 , @apol wrote:
  
  > Should maybe warn if it fails?
  
  
  I am not sure, but i don't think so, there's if's below that account for name 
and symlink being empty, so it's not a problem if this fails afaics

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20641

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20644: Fix memory leak when reading some tar files

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> karchive.cpp:602
>  Q_ASSERT(!d->rootDir);   // Call setRootDir only once during parsing 
> please ;)
> +delete d->rootDir;   // but if it happens, try not to leak
>  d->rootDir = rootDir;

:P don't try, do `//if it happens, don't leak`

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20644

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20641: Fix uninitialized memory use when reading malformed tar files

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Should maybe warn if it fails?

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20641

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20643: Fix invalid memory write on malformed tar files

[Aleix Pol Gonzalez]

apol added a comment.


  +1 in general

INLINE COMMENTS

> ktar.cpp:241
>  size--;// ignore trailing null
> +if (size > std::numeric_limits::max()) {
> +qCWarning(KArchiveLog) << "Failed to allocate memory for longlink of 
> size" << size;

It could make sense to say that it's because of the maximum size longling can 
have in a comment.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20643

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20639: Remove TODO

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  I don't think you understood the TODO. Also this change breaks ABI, since 
const it's part of it.
  The TODO talks about adding a startTimer method and deprecating timer (which 
it already is).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20639

To: shubham, dfaure, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/74/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 17 Apr 2019 20:20:47 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13355)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/84/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 17 Apr 2019 20:20:47 +
 Build duration:
5 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/81/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 17 Apr 2019 20:20:47 +
 Build duration:
5 min 34 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13355)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Given also on irc, no-one showed any interest for Air/Oxygen ,going to just 
push this, having at least one +1. Thanks for that one :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20602

To: kossebau, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:084edba0db19: Air/Oxygen desktoptheme: fix progressbar 
height using "hint-bar-size" (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20602?vs=56368&id=56476

REVISION DETAIL
  https://phabricator.kde.org/D20602

AFFECTED FILES
  src/desktoptheme/air/widgets/bar_meter_horizontal.svg
  src/desktoptheme/oxygen/widgets/bar_meter_horizontal.svg

To: kossebau, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

[Kai Uwe Broulik]

broulik added a comment.


  @vkrause I just noticed xdg portal notification spec (the ones used for 
sandboxed flatpak apps) has four urgency levels: low, normal, *high*, critical.
  Do you think it would be useful to add `HighUrgency`, too? For Android, 
maybe? For freedesktop Notifications we could just map High to Normal then 
(like Gnome does it).
  It's not released yet, we can still meddle the enums for another few weeks :)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20158

To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20529: add license to python test files

[Stefan Brüns]

bruns added a comment.


  In D20529#451614 , @bcooksley 
wrote:
  
  > In D20529#451561 , @bruns wrote:
  >
  > > In D20529#451147 , @bcooksley 
wrote:
  > >
  > > > can we get the full command it's running?
  > >
  > >
  > > `ctest -V -R externalextractortest`
  >
  >
  > That might be how the test is started, but how does it invoke Python?
  
  
  Run the command I gave, and it will tell you.
  
  And let me quote myself:
  
  > I also have neither time **nor means** to debug this.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20529

To: astippich, bruns
Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20644: Fix memory leak when reading some tar files

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  Not sure if they are even malformed (don't know enough about the tar format), 
but oss-fuzz has produced a file where there's files and then there's the 
special . file (the root).
  
  Since the files prior to finding "." need to be child of something, we 
already created a rootdir, so when we find "." we need to delete the existing 
one.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20644

AFFECTED FILES
  src/karchive.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20643: Fix invalid memory write on malformed tar files

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  If the file says it has a longlink of more than int_max bytes, the resize 
would do nothing (since casting to int means a negative number) and we'd try 
writing on a bytearray of size 0

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20643

AFFECTED FILES
  src/ktar.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 83 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/83/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 17 Apr 2019 18:11:51 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/73/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 17 Apr 2019 18:11:52 +
 Build duration:
9 min 41 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13355)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 80 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/80/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 17 Apr 2019 18:11:51 +
 Build duration:
8 min 10 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3626/13355)18%
(1818/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/72/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 17 Apr 2019 17:53:11 +
 Build duration:
4 min 47 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13355)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/79/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 17 Apr 2019 17:53:11 +
 Build duration:
4 min 6 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13355)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
  

D20283: [RFC] [SimpleKCM] Fix height calculation

[Nathaniel Graham]

ngraham updated this revision to Diff 56467.
ngraham added a comment.


  `arc`, you are driving me crazy

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20283?vs=56466&id=56467

REVISION DETAIL
  https://phabricator.kde.org/D20283

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20283: [RFC] [SimpleKCM] Fix height calculation

[Nathaniel Graham]

ngraham updated this revision to Diff 56466.
ngraham added a comment.


  Remove unintentional change

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20283?vs=56465&id=56466

BRANCH
  simplekcm-better-maximum-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20283

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 82 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/82/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 17 Apr 2019 17:53:11 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20283: [RFC] [SimpleKCM] Fix height calculation

[Nathaniel Graham]

ngraham updated this revision to Diff 56465.
ngraham marked an inline comment as done.
ngraham edited the summary of this revision.
ngraham added a comment.


  Use implicitHeights for headers and footers

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20283?vs=56462&id=56465

BRANCH
  simplekcm-better-maximum-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20283

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:bd8264e92869: Update audio, drive, edit, go, list, media, 
plasmavault icons to match breeze… (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20623?vs=56407&id=56464

REVISION DETAIL
  https://phabricator.kde.org/D20623

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/drive.svg
  src/desktoptheme/breeze/icons/edit.svg
  src/desktoptheme/breeze/icons/go.svg
  src/desktoptheme/breeze/icons/list.svg
  src/desktoptheme/breeze/icons/media.svg
  src/desktoptheme/breeze/icons/plasmavault.svg
  src/desktoptheme/breeze/icons/plasmavault_error.svg

To: ndavis, #vdg, #plasma, broulik, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D20283: [RFC] [SimpleKCM] Fix height calculation

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> SimpleKCM.qml:55
> ++ bottomPadding
> ++ (header && header.visible ? header.height + header.topPadding + 
> header.bottomPadding : 0)
> ++ (footer && footer.visible ? footer.height + footer.topPadding + 
> footer.bottomPadding : 0)

i don't think adding header.padding is correct here, also because in most cases 
it won't have sich a property.
also, header.implicitheight should be used, as size propagation from child to 
parent is always with implicitHeight (while height is from parent to child) 
otherwise gets binding loops

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20283

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20641: Fix uninitialized memory use when reading malformed tar files

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  Don't try to read longlink if readLongLink fails
  
  oss-fuzz #14310

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20641

AFFECTED FILES
  src/ktar.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20283: [RFC] [SimpleKCM] Fix height calculation

[Nathaniel Graham]

ngraham updated this revision to Diff 56462.
ngraham added a comment.


  Remove accidentally added change

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20283?vs=56461&id=56462

REVISION DETAIL
  https://phabricator.kde.org/D20283

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20283: [RFC] [SimpleKCM] Fix height calculation

[Nathaniel Graham]

ngraham retitled this revision from "[SimpleKCM] Base the maximum height on the 
screen height, not some random value" to "[RFC] [SimpleKCM] Fix height 
calculation".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20283

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

[Nathaniel Graham]

ngraham updated this revision to Diff 56461.
ngraham added a comment.


  Take headers and padding into account for height calculation

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20283?vs=55501&id=56461

BRANCH
  simplekcm-better-maximum-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20283

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20639: Remove TODO

[Shubham]

shubham created this revision.
shubham added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  todo

REVISION DETAIL
  https://phabricator.kde.org/D20639

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20606: Toggle folding of child ranges by right click

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  The question is: with a context menu, isn't that then already too 
inconvenient? 
  At the moment we have no context menu for the bar at all.
  I could live with the right click for the moment, we can still enhance that, 
if we add further "actions".
  But I think we need at least an action in the "Code Foldings" sub-menu that 
does trigger this for the current active folding region.
  If that is there, more can follow in extra changes, I think.

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Nathaniel Graham]

ngraham added a comment.


  Submitted D20637  and D20638 
 to keep the Widget Explorer using the 
correct icons after this patch lands.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma, broulik, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma, broulik, ngraham
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/78/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 17 Apr 2019 16:34:40 +
 Build duration:
9 min 24 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32977/60672)38%
(16829/43770)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9308/9772)47%
(4273/9015)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8468/14453)51%
(4700/9228)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4338/8049)40%
(1869/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(572/1080)39%
(343/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1294/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
 

Re: New framework: KCalCore

[Volker Krause]

On Sunday, 14 April 2019 20:30:07 CEST Alexander Potashev wrote:
> вт, 9 апр. 2019 г. в 20:10, Volker Krause :
> > On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote:
> > > вс, 7 апр. 2019 г. в 15:45, Volker Krause :
> > > > Hi,
> > > > 
> > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> > > > 
> > > > KCalCore is an implementation of the iCalendar standard based on
> > > > libical,
> > > > covering the data model, input/output and the rather complex
> > > > recurrence
> > > > algorithms defined in that standard. It's used outside of KDE PIM as
> > > > well,
> > > > e.g. by Zanshin or the Plasma Mobile calendar app.
> > > 
> > > Hi Volker,
> > > 
> > > While porting KTimeTracker to KF5, I noticed that KCalCore lost KIO
> > > support on the way from KDELibs4 to KF 5.0.
> > > 
> > > Of course I can subclass ICalFormat, but the FileStorage<->ICalFormat
> > > relation looks weird to me: ICalFormat::save() is the method that
> > > actually writes file to disk, while class name "ICalFormat" suggests
> > > that it should only be concerned about iCal contents, not the I/O.
> > > 
> > > May be CalFormat should only implement marshal/unmarshal methods, then
> > > actual r/w from disk can be done in FileStorage. Otherwise, for me to
> > > add KIO support right now I need to subclass ICalFormat rather than
> > > FileStorage which is weird.
> > 
> > Right. IMHO the entire file handling code should probably not be in there
> > in the first place. That is, the CalStorage class hierarchy and the file
> > I/O methods from the CalFormat hierachy (streaming to/from QIODevice
> > rather than working with full QByteArray serialization might however make
> > sense there).
> > 
> > This is also why KIO support was a very bad idea in there, the KCalCore
> > API is synchronous (predating KIO), while KIO is asynchronous, and so is
> > likely any other persistence backend one might want to use.
> > 
> > Looking at lxr.kde.org I'm however reluctant to remove any of this now
> > though, this is still too widely used.
> 
> Hi Volker,
> 
> Thanks for your thoughts!
> 
> Since David suggested renaming KCalCore to something else, how about we
> instead 1. Redesign the API (e.g. drop file handling, etc) and call it e.g.
> KCal, get it into KF5,
>  2. Keep releasing KCalCore as part of KDEPIM and may be port it to
> KF5::KCal as backend to reduce codebase,
>  3. Deprecate KCalCore and gradually port everything to the new clean
> KF5::KCal? ...
>  4. PROFIT: nobody's code is hurt since the legacy KCalCore API is
> still available.

That's essentially rejecting the move of KCalCore to KF5, which is a perfectly 
valid outcome of this discussion of course. If that's going to be the 
consensus it would be good to know that sooner rather than later though, to 
not waste any time on this.

Regards,
Volker


signature.asc
Description: This is a digitally signed message part.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 88 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/88/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 17 Apr 2019 16:34:40 +
 Build duration:
6 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Re: New framework: KCalCore

[Volker Krause]

On Sunday, 14 April 2019 13:31:41 CEST David Faure wrote:
> On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote:
> > Hi,
> > 
> > I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> > 
> > KCalCore is an implementation of the iCalendar standard based on libical,
> 
> I wonder about the name, which doesn't mean much outside the circle of PIM
> people. Shouldn't this be called KCalendar ?
> 
> If the "Core" simply means non-GUI, we certainly don't have that word in
> every non-GUI framework.

Renaming the namespace should be manageable, we can soften the blow for 
external users with a namespace alias I guess, to at least keep SC until 
everyone has adapted.

> > covering the data model, input/output and the rather complex recurrence
> > algorithms defined in that standard. It's used outside of KDE PIM as well,
> > e.g. by Zanshin or the Plasma Mobile calendar app.
> 
> This makes me wonder: where does that mobile calendar app get the events
> from? Akonadi? (then it still depends on kde/pim/*, and this move in itself
> doesn't really remove the unwanted workspace->apps dependency?)

So far it looked like just a local ical file, which I guess is temporary, 
while focusing on mobile UI development. Eventually I at least expect the need 
for KDav there too. So just moving KCalCore isn't going to be enough 
obviously, but it is a necessary first step either way.

> Zanshin does use akonadi (though one could imagine a mobile version that
> only uses KDav and KCalCore^H^H^H KCalendar).
>
> Some review:
> 
> icalformat_p.h://TODO: KDE5, move this implementation to
> icalformat_p.cpp incidencebase.h: * // TODO_KDE5: Provide a virtual
> serialize() method, as done with assign() and equals(). incidencebase.h: *
> // TODO_KDE5: Provide a virtual serialize() method, as done with assign()
> and equals(). person.h:// TODO_KDE5: FIXME: This operator does
> slicing,if the object is in fact one of the derived classes (Attendee)

Person/Attendee I'd like to ideally see split into two non-polymorphic value 
types, as that would make direct QML consumption easier. That would also 
address the slicing risk.

Regards,
Volker


signature.asc
Description: This is a digitally signed message part.

D20625: Truncate trailing forward slashes(/)

[Shubham]

shubham added a comment.


  @dfaure Intention was just to fix the TODO

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20625

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:acc6b9b71b51: Truncate trailing forward slashes(/) 
(authored by shubham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20625?vs=56437&id=56447

REVISION DETAIL
  https://phabricator.kde.org/D20625

AFFECTED FILES
  src/core/kmountpoint.cpp

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20620: [balooctl] Switch multiline output to new helper

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> statuscommand.cpp:150
> +
> +for (const auto& fileName : args) {
> +const auto file = collectFileStatus(tr, cfg, fileName);

Do we have to use `auto` here and below?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20620

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20619: [balooctl] Use new helper in json output

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> statuscommand.cpp:226
>  
> -  QJsonDocument json;
> -  json.setArray(filesInfo);
> -  QTextStream out(stdout);
> -  out << json.toJson(QJsonDocument::Indented);
> +for (const auto& fileName : args) {
> +const auto file = collectFileStatus(tr, cfg, fileName);

Do we have to use `auto` here and below?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20619

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20617: [balooctl] Factor out file index status collection from output

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  balooctl_status

REVISION DETAIL
  https://phabricator.kde.org/D20617

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20618: [balooctl] Use new helper for simple format output

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  balooctl_status

REVISION DETAIL
  https://phabricator.kde.org/D20618

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Volume icon are consistent now, Vault icon in tray is prettier (imho), media 
controls look unchanged/fine, folder view nav buttons look fine/better, lgtm

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma, broulik
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D20558: Bug fix: find c++ stl using regex

[Sharaf Zaman]

sh-zam added a comment.


  well.. I couldn't get it running as a toolchain and kept running into errors.
  
  I can give it another hit, though.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

Re: New framework: KCalCore

[David Faure]

On lundi 15 avril 2019 12:40:06 CEST Daniel Vrátil wrote:
> On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote:
> > Maybe KCal is enough? Reminds of iCal.
> 
> Wasn't KCal the original name of the library from pre-Akonadi times?
> KCalCore was a fork of KCal with the pre-Akonadi "Resources" system
> removed...

See? That's perfect, it comes full circle then :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Nathaniel Graham]

ngraham added a comment.


  This looks fine to me, but let's let a #plasma 
 person weigh in too. :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20558: Bug fix: find c++ stl using regex

[Aleix Pol Gonzalez]

apol added a comment.


  In D20558#451898 , @sh-zam wrote:
  
  > In my case if I do this: `include (Android.cmake)`, then it won't be able 
to find the `ECMAndroidDeployQt.cmake` because I am using android-ndk's 
toolchain.
  
  
  And why do you have to do this? Why can't krita work like every other KDE 
project? In the end we'll want Krita to work in binary-factory.kde.org like the 
rest...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Patch looks good now ;-)
  
  I'm curious about one more thing: what prompted this change? Did you have a 
mount point with a trailing slash, or was it just to "fix a TODO" (which, hehe, 
has been there since the very beginning of this code in 2003)?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20625

REVISION DETAIL
  https://phabricator.kde.org/D20625

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

[Sharaf Zaman]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:307b36662ec9: Bug fix: find c++ stl using regex (authored 
by sh-zam).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20558?vs=56311&id=56445

REVISION DETAIL
  https://phabricator.kde.org/D20558

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

[Sharaf Zaman]

sh-zam added a comment.


  > What does it mean that "it expects to run as a toolchain"?
  
  Sorry, I didn't notice this.
  
  On this line 

  
get_filename_component(_CMAKE_ANDROID_DIR "${CMAKE_TOOLCHAIN_FILE}" PATH)
  
  we get the path of `ECM/toolchain`, which is used to include 
`ECMAndroidDeployQt.cmake`, which in turn can only be extracted if it is being 
run as a toolchain.
  
  In my case if I do this: `include (Android.cmake)`, then it won't be able to 
find the `ECMAndroidDeployQt.cmake` because I am using android-ndk's toolchain.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  arcpatch-D20558

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar added a comment.


  hm, there is already a folding action in the View menu. 
  I understood Dominik so, not to add a context menu to the icon border, but to 
add the action to the context menu of the "edit range".
  Whatever, as said I'm not in the mood for that,  and it should be done in a 
2nd patch, when needed.
  But a context menu on the icon border would I very much dislike. Middle click 
is not so handy and perform atm "paste to begin of line"

INLINE COMMENTS

> kateviewhelpers.cpp:2484
> +// Don't try to fold a single line, which can happens due to adjustment 
> above'
> +// FIXME Avoid to offer a such folding marker
> +if (!foldingRange.onSingleLine()) {

oops, "to offer such a folding"

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar updated this revision to Diff 56444.
loh.tar added a comment.


  - Add docu to header, not full happy with
  - Add desired adjustment checks
  - Make toggleFoldingInRange more action friendly
- Add first try to unfold range itself into toggleFoldingInRange
- Be a smart ass, minimize if nesting in mouseReleaseEvent
  - Fix to eager toggleFoldingInRange, don't fold else part when written on one 
line } else {
  
  Regading toggleFoldingInRange
  
  - The return value is not needed anymore and will only in rare cases say 
"false"
  - Should now be useable as slot, so remove the return value?
  - Better name idea?

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20606?vs=56375&id=56444

REVISION DETAIL
  https://phabricator.kde.org/D20606

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20558: Bug fix: find c++ stl using regex

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  arcpatch-D20558

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

[Sharaf Zaman]

sh-zam added inline comments.

INLINE COMMENTS

> apol wrote in ECMAndroidDeployQt.cmake:43
> This looks quite awful. Why do you prefer using regex to string(FIND)? It 
> could be something like
> `string(FIND "${VALUE}" "c++.so\"" OUT)` if you want to be more specific.

Because `string (FIND ..)` doesn't work if `libc++.so` isn't added first to 
`CMAKE_CXX_STANDARD_LIBRARIES`

In my case this is the original value of `CMAKE_CXX_STANDARD_LIBRARIES`:

  -latomic -lm 
"/home/sh_zam/Android/Sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libunwind.a"
 
"/home/sh_zam/Android/Sdk/ndk-bundle/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a/libc++_shared.so"

and the value written to `stl` file is the same thing as above, which down the 
line causes `androidqtdeploy` to fail.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

[Aleix Pol Gonzalez]

apol added a comment.


  In D20558#450229 , @sh-zam wrote:
  
  > > Why are you using it without Android.cmake?
  >
  > I am building Krita and to add `create-apk` target I am using `include 
(ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake` because of some 
variables as it expects to run as a toolchain.
  
  
  What does it mean that "it expects to run as a toolchain"?

INLINE COMMENTS

> ECMAndroidDeployQt.cmake:43
> +# look for ++ and .so as in libc++.so
> +string (REGEX MATCH "\"[^ ]+\\+\\+[^ ]*\.so\"" OUT ${VALUE})
> +file(WRITE ${CMAKE_BINARY_DIR}/stl "${OUT}")

This looks quite awful. Why do you prefer using regex to string(FIND)? It could 
be something like
`string(FIND "${VALUE}" "c++.so\"" OUT)` if you want to be more specific.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20558

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

[Shubham]

shubham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20625

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

[Shubham]

shubham updated this revision to Diff 56437.
shubham marked an inline comment as done.
shubham added a comment.


  Correcty chop trailing slash

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20625?vs=56416&id=56437

BRANCH
  arcpatch-D20625

REVISION DETAIL
  https://phabricator.kde.org/D20625

AFFECTED FILES
  src/core/kmountpoint.cpp

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Anyone brave enough for a shipit? :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20602

To: kossebau, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kmountpoint.cpp:164
>  }
> -// TODO: Strip trailing '/' ?
> +mountedFrom = 
> mountedFrom.left(mountedFrom.lastIndexOf(QLatin1Char('/')));
>  }

That would turn "/boot/efi" into "/boot" !!

I wonder, did kmountpointtest still pass?

You want something like this instead:

  if (mountedFrom.endsWith('/')) {
  mountedFrom.chop(1);
  }

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20625

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

[David Edmundson]

davidedmundson added a comment.


  if (wl_proxy_get_version(d->surface) < 
ORG_KDE_PLASMA_SURFACE_ROLE_CRITICALNOTIFICATION_SINCE_VERSION) {
  //handle error code
  }

INLINE COMMENTS

> plasma-shell.xml:194
> +  
> +  
>  

D20626: Refactor and cleanup

[David Faure]

dfaure added a comment.


  I like the idea.
  
  The commit template has a "Test Plan" field, but it seems it was left empty - 
can you detail what tests you did?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20606: Toggle folding of child ranges by right click

[Milian Wolff]

mwolff added a comment.


  In D20606#451459 , @dhaumann wrote:
  
  > I would prefer a context menu that has this as action. This is much better 
discoverable and also extensible with more folding actions.
  
  
  I agree. Right-click should show a context menu. Middle-click could toggle, 
if you need it.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

[Kai Uwe Broulik]

broulik added a dependent revision: D20629: Support CriticalNotification type 
and place it in a CriticalNotificationLayer.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20628

To: broulik, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20630: [Dialog] Add CriticalNotification type

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Allows to flag a dialog window as critical notification that should be shown 
even on top of fullscreen windows

TEST PLAN
  Depends on D20627 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20630

AFFECTED FILES
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialog.h

To: broulik, #plasma, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20627: Introduce CriticalNotificationType

[Kai Uwe Broulik]

broulik added a dependent revision: D20630: [Dialog] Add CriticalNotification 
type.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D20627

To: broulik, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20627: Introduce CriticalNotificationType

[Kai Uwe Broulik]

broulik added a dependent revision: D20629: Support CriticalNotification type 
and place it in a CriticalNotificationLayer.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D20627

To: broulik, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  Compiles, tests adjusted and pass.
  I need some help with the versioning stuff please

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20628

AFFECTED FILES
  autotests/client/test_plasmashell.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/protocols/plasma-shell.xml
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  tests/plasmasurfacetest.cpp

To: broulik, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20627: Introduce CriticalNotificationType

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is a dedicated window type indicating a critical notification that is 
more urgent than a regular notification and may be shown even on top of 
fullscreen windows.

TEST PLAN
  Compiles, tests adjusted and pass

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D20627

AFFECTED FILES
  autotests/kwindowinfox11test.cpp
  autotests/netrootinfotestwm.cpp
  autotests/netwininfotestclient.cpp
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: broulik, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Refactor and cleanup

[Shubham]

shubham created this revision.
shubham added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20626

AFFECTED FILES
  src/kcms/kio/useragentinfo.cpp

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

[Shubham]

shubham added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20625

To: shubham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20625: Truncate trailing forward slashes(/)

[Shubham]

shubham created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  trailing

REVISION DETAIL
  https://phabricator.kde.org/D20625

AFFECTED FILES
  src/core/kmountpoint.cpp

To: shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns