D20692: Fix test KDirListerTest::testRenameItem

[Méven Car]

meven created this revision.
meven added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  The test was buggy to begin with : the wrong refreshedItems slot was used and 
would not refresh the expected m_refreshedItems2.

REPOSITORY
  R241 KIO

BRANCH
  fix-etst

REVISION DETAIL
  https://phabricator.kde.org/D20692

AFFECTED FILES
  autotests/kdirlistertest.cpp

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven added a comment.


  In D20096#451170 , @dfaure wrote:
  
  > This change also introduced regressions in two unittests: jobtest and 
kdirmodeltest. I'll let you look into those :-)
  >
  > 
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobtest/
  >  
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/projectroot/autotests/kiowidgets_kdirmodeltest/
  >
  > The first one is probably just an extra file in the dir (I know, bad 
isolation of the tests), the second one is more unexpected.
  
  
  The tests failures are not regressions as they are happened before the merge 
: 
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/72/testReport/
 although on Qt 5.12.
  
  Failures are:
  
  FAIL!  : KFileItemTest::testListProperties(two (text+html) files) Compared 
values are not the same
  
Actual   (props.mimeGroup()): ""
Expected (expectedMimeGroup): "text"
Loc: [/home/jenkins/workspace/Frameworks/kio/kf5-qt5 
SUSEQt5.10/autotests/kfileitemtest.cpp(590)]
  
  I don't reproduce locally.
  
  FAIL!  : KDirListerTest::testRenameItem() Compared values are not the same
  
Actual   (entry.second.mimetype()): "application/xhtml+xml"
Expected (QString("text/html"))   : "text/html"
Loc: [/home/jenkins/workspace/Frameworks/kio/kf5-qt5 
SUSEQt5.10/autotests/kdirlistertest.cpp(557)]
  
  I didn't reproduce locally, but I could see some issue in the test.
  Here is a fix proposal for this test : D20692 

  Is it possible to test it on jenkins before merging ?
  
  So it seems to me as sporadic failures of slightly unconsistent tests.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  I don't why src/Messages.sh would need to be updated.
  But the fix seems fine to me.

REPOSITORY
  R245 Solid

BRANCH
  error

REVISION DETAIL
  https://phabricator.kde.org/D20691

To: shubham, meven
Cc: meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20692: Fix test KDirListerTest::testRenameItem

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdirlistertest.cpp:549
> +
> +QSignalSpy spyRefreshItems(&m_dirLister, 
> SIGNAL(refreshItems2(QList>)));
>  QVERIFY(job->exec());

I don't see a signal called refreshItems2 anywhere.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20692

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[David Faure]

dfaure added a comment.


  I'm talking about jobtest and kdirmodeltest regressing exactly in build 87, 
which is where this commit landed.
  If you click on history for a given test you can see that those aren't 
sporadic failures: 
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiowidgets_kdirmodeltest/history/
  and
  
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobtest/history/
  
  The failures kdirlistertest and kfileitemtest are unrelated, and indeed look 
like they come from the switch to Qt 5.12, I'll look into those.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20693: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: KNewStuff, ngraham, sitter.
leinir added a project: KNewStuff.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  In the before-times, drop shadows were considered vitally important on 
everything, and so it was introduced to KNewStuff's dialogues as well. It was, 
however, never done quite right, and it's making our dialogues look all silly. 
So, we remove it for now, and if we still want it, we can reintroduce them in a 
more modern fashion.
  BUG:391108

TEST PLAN
  Open the details dialogue of any knewstuff listing
  Before patch: See pixelated (and weirdly positioned) pixelated border on all 
preview images
  After patch: See no pixelated border

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

AFFECTED FILES
  data/CMakeLists.txt
  data/thumb_frame.png
  src/ui/imagepreviewwidget.cpp
  src/ui/imagepreviewwidget_p.h

To: leinir, #knewstuff, ngraham, sitter
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 91 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/91/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 20 Apr 2019 08:38:02 +
 Build duration:
6 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/94/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 20 Apr 2019 08:38:02 +
 Build duration:
8 min 9 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32991/60674)39%
(16877/43779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9312/9780)47%
(4286/9027)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8461/14446)51%
(4708/9225)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4346/8049)40%
(1877/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(572/1080)39%
(343/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1294/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
  

D20692: Fix test KDirListerTest::testRenameItem

[Méven Car]

meven abandoned this revision.
meven added a comment.


  I mixed up refreshItems and slotRefreshItems.
  My fix is nonsense

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20692

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/81/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Apr 2019 08:38:02 +
 Build duration:
38 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32992/60680)39%
(16876/43782)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9314/9780)48%
(4290/9027)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8471/14453)51%
(4704/9228)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4352/8049)40%
(1884/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(572/1080)39%
(343/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1296/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
   

D20694: Use regular stat when resolving a symlink

[Méven Car]

meven created this revision.
meven added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Before f3b0f220a78d4e5a5b94b46e931779d755ac19ce 
 
when getting the details of a symlink a regular QT_STAT mimicking stat() was 
used.

TEST PLAN
  ctest

REPOSITORY
  R241 KIO

BRANCH
  fix-test

REVISION DETAIL
  https://phabricator.kde.org/D20694

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven added a comment.


  In D20096#453194 , @dfaure wrote:
  
  > I'm talking about jobtest and kdirmodeltest regressing exactly in build 87, 
which is where this commit landed.
  >  If you click on history for a given test you can see that those aren't 
sporadic failures: 
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiowidgets_kdirmodeltest/history/
  > and
  >  
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobtest/history/
  >
  > The failures in kfileitemtest and kdirlistertest (note: model != lister) 
are unrelated, I'll look into those.
  
  
  Thank you for making this clear.
  
  The regression are associated with symlink resolution.
  I think I have identified the issue.
  Please see D20694  and could we test this 
on CI.
  
  It makes me think that for some reviews, it would be good to test it on CI 
before merging.
  At my past place of work we used this extensively, it was quite helpful.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20694: Use regular stat when resolving a symlink

[Méven Car]

meven added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20694

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20694: Use regular stat when resolving a symlink

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Glad that the unittest caught an actual bug for once :-)
  
  Yes we'd all love pre-merge CI checks, but that won't happen with 
phabricator. I hear rumours of a migration to gitlab at some point, which 
should surely help.

REPOSITORY
  R241 KIO

BRANCH
  fix-test

REVISION DETAIL
  https://phabricator.kde.org/D20694

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20694: Use regular stat when resolving a symlink

[Ben Cooksley]

bcooksley added a comment.


  The Gitlab migration is in planning and preparation stages, so should happen 
sometime in the next couple of months.

REPOSITORY
  R241 KIO

BRANCH
  fix-test

REVISION DETAIL
  https://phabricator.kde.org/D20694

To: meven, dfaure, #frameworks
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20694: Use regular stat when resolving a symlink

[Méven Car]

meven added a comment.


  In D20694#453252 , @bcooksley 
wrote:
  
  > The Gitlab migration is in planning and preparation stages, so should 
happen sometime in the next couple of months.
  
  
  I can't wait for gitlab migration.
  phabricator is quite nice but not as common as a git-PR based workflow.

REPOSITORY
  R241 KIO

BRANCH
  fix-test

REVISION DETAIL
  https://phabricator.kde.org/D20694

To: meven, dfaure, #frameworks
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20694: Use regular stat when resolving a symlink

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:dfbc18403297: Use regular stat when resolving a symlink 
(authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20694?vs=56616&id=56618

REVISION DETAIL
  https://phabricator.kde.org/D20694

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: meven, dfaure, #frameworks
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20694: Use regular stat when resolving a symlink

[Méven Car]

meven added a comment.


  https://build.kde.org/view/OS - Windows/job/Frameworks/job/kio/job/kf5-qt5 
SUSEQt5.10/95 Will confirm if this is fixed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20694

To: meven, dfaure, #frameworks
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The tooltip for the audio system tray widget and panel edit mode had blurry 
versions of these icons because the icons were being scaled to fit.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  add-new-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20695

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/configure.svg
  src/desktoptheme/breeze/icons/distribute.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20695

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/92/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 20 Apr 2019 10:18:03 +
 Build duration:
6 min 50 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 82 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/82/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Apr 2019 10:18:03 +
 Build duration:
6 min 28 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(33006/60682)39%
(16878/43782)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9323/9780)48%
(4297/9027)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8465/14453)51%
(4700/9228)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4352/8049)40%
(1884/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(578/1082)39%
(345/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1294/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.i

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/95/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 20 Apr 2019 10:18:03 +
 Build duration:
8 min 37 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32991/60674)39%
(16879/43779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9321/9780)48%
(4295/9027)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8446/1)51%
(4702/9225)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4346/8049)40%
(1877/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(578/1082)39%
(345/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1294/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

D20694: Use regular stat when resolving a symlink

[Méven Car]

meven added a comment.


  Regressions are fixed :
  
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/95/testReport/junit/projectroot/autotests/kiowidgets_kdirmodeltest/history/
  
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobtest/history/
  
  There are 2 failures still on the build though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20694

To: meven, dfaure, #frameworks
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis planned changes to this revision.
ndavis added a comment.


  Oops, looks like I need 16px audio icons as well for the volume/mute icons 
inside the opened audio widget.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20695

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/93/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 20 Apr 2019 10:32:24 +
 Build duration:
7 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 96 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/96/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 20 Apr 2019 10:32:24 +
 Build duration:
8 min 23 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(33017/60678)39%
(16896/43781)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9332/9782)48%
(4299/9029)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8461/14446)51%
(4713/9225)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4346/8049)40%
(1877/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(578/1082)39%
(345/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1294/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
  

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Please revert the mode change to `Messages.sh`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20691

To: shubham, meven, elvisangelaccio
Cc: elvisangelaccio, meven, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 83 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/83/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Apr 2019 10:32:24 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(33025/60684)39%
(16894/43784)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9334/9782)48%
(4305/9029)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8472/14453)51%
(4707/9228)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4353/8049)40%
(1885/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(578/1082)39%
(345/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1294/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D20694: Use regular stat when resolving a symlink

[David Faure]

dfaure added a comment.


  I fixed them ;-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20694

To: meven, dfaure, #frameworks
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis updated this revision to Diff 56621.
ndavis added a comment.


  Add 16px audio icons

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20695?vs=56619&id=56621

BRANCH
  add-new-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20695

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/configure.svg
  src/desktoptheme/breeze/icons/distribute.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20695

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20694: Use regular stat when resolving a symlink

[Méven Car]

meven added a comment.


  In D20694#453296 , @dfaure wrote:
  
  > I fixed them ;-)
  
  
  Nice back to stable tests!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20694

To: meven, dfaure, #frameworks
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20695

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

ndavis updated this revision to Diff 56622.
ndavis added a comment.


  Fix 16-16-audio-volume-muted

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20695?vs=56621&id=56622

BRANCH
  add-new-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20695

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/configure.svg
  src/desktoptheme/breeze/icons/distribute.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/94/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 20 Apr 2019 11:15:59 +
 Build duration:
8 min 23 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D20264: Add test for "Auto Reload Document" option

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f5f715ea1441: Add test for "Auto Reload 
Document" option (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20264?vs=55576&id=56623#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20264?vs=55576&id=56623

REVISION DETAIL
  https://phabricator.kde.org/D20264

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h
  src/document/katedocument.cpp

To: loh.tar, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20606: Add action to toggle folding of child ranges

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:5c83e29561e3: Add action to toggle folding of child ranges 
(authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20606?vs=56527&id=56624#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20606?vs=56527&id=56624

REVISION DETAIL
  https://phabricator.kde.org/D20606

AFFECTED FILES
  src/data/katepart5ui.rc
  src/document/katebuffer.cpp
  src/document/katebuffer.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20565: Ensure not to fold the end marker

[loh tar]

loh.tar abandoned this revision.
loh.tar added a comment.


  Patch is part of D20606 
  
  > And happy Easter ;=)
  
  Thank you! :-)

REVISION DETAIL
  https://phabricator.kde.org/D20565

To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 84 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/84/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 20 Apr 2019 11:15:59 +
 Build duration:
36 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(33008/60684)39%
(16874/43784)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9332/9782)48%
(4297/9029)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8471/14453)51%
(4711/9228)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4341/8049)40%
(1872/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(578/1082)39%
(345/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1296/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D20697: Review IconBorder

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  The only two included changes noticeable by the user are:
  

  
  - Use line number color for unfolded triangle to be less intrusive
  - Move the line modification hint away from the edit area between the line 
numbers and the folding area to be less irritating when cursor is in first 
column
  
  Most of the changes in this patch could you see as code cosmetic or an 
attempt to make it more maintenance-friendly.
  

  
  - Cleanup, avoid redundancies and nesting
  - Rename members, make them unified named
  - Give each area an own value name
  - Remove m_oldBackgroundColor, can't see any benefit
  - Make positionToArea() and sizeHint() less error prone in case of design 
changes

TEST PLAN
  Pls try it, but I'm not sure if I'm done with it
  
  F6783737: 1555761488.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20697: Review IconBorder

[loh tar]

loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

[Shubham]

shubham updated this revision to Diff 56627.
shubham added a comment.


  Fix unintentional mode change

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20691?vs=56609&id=56627

BRANCH
  error

REVISION DETAIL
  https://phabricator.kde.org/D20691

AFFECTED FILES
  src/solid/devices/backends/iokit/cfhelper.cpp

To: shubham, meven, elvisangelaccio
Cc: elvisangelaccio, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

[Elvis Angelaccio]

elvisangelaccio resigned from this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  error

REVISION DETAIL
  https://phabricator.kde.org/D20691

To: shubham, meven
Cc: elvisangelaccio, meven, kde-frameworks-devel, michaelh, ngraham, bruns

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:b63c2a236faf: Fix no member named 'setTime_t' 
in 'QDateTime' error while building (authored by shubham).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20691?vs=56627&id=56629

REVISION DETAIL
  https://phabricator.kde.org/D20691

AFFECTED FILES
  src/solid/devices/backends/iokit/cfhelper.cpp

To: shubham, meven
Cc: elvisangelaccio, meven, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/23/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 20 Apr 2019 14:23:07 +
 Build duration:
1 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D20525: [InformationPanel] Use the new inline configuration mode

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> informationpanelcontent.cpp:113-114
> +m_configureLabel = new QLabel(i18nc("@label::textbox",
> +  "Select which data should "
> +  "be shown:"), this);
> +m_configureLabel->setWordWrap(true);

Why split the i18n sentence into two lines? It looks weird imho.

> informationpanelcontent.cpp:118
> +
> +m_configureButtons = new 
> QDialogButtonBox(QDialogButtonBox::Save|QDialogButtonBox::Cancel);
> +m_configureButtons->setVisible(false);

Coding style: missing space before/after `|`

> informationpanelcontent.cpp:122-124
> +m_configureButtons->setVisible(false);
> +m_configureLabel->setVisible(false);
> +emit configurationFinished();

These 3 lines could go in a dedicated function which we could call from both 
lambdas, to avoid code duplication. Or it could even be a private slot 
connected to `QDialogButtonBox::clicked`.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Elvis Angelaccio]

elvisangelaccio accepted this revision.

REPOSITORY
  R824 Baloo Widgets

BRANCH
  metadata_config_inline

REVISION DETAIL
  https://phabricator.kde.org/D20524

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich, elvisangelaccio
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layoutThe Baloo::MetaDataWidget is now able to stretch in a meaningful wayby itself, remove the wrapper.

[Elvis Angelaccio]

elvisangelaccio accepted this revision.

REPOSITORY
  R318 Dolphin

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20668

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, 
andrebarros, emmanuelp, mikesomov

D20691: Fix no member named 'setTime_t' in 'QDateTime' error while building

[Yurii Kolesnykov]

yurikoles added a comment.


  How about issuing a minor release?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20691

To: shubham, meven
Cc: yurikoles, elvisangelaccio, meven, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20700: Add "edit-remove" icon

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Add an alternative to `list-remove`, which needs to be next to `list-add` for 
context and `edit-delete`, which is a destructive deletion icon.

TEST PLAN
  Search for `edit-remove` in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-edit-remove-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20700

AFFECTED FILES
  icons-dark/actions/16/edit-remove.svg
  icons-dark/actions/22/edit-remove.svg
  icons-dark/actions/24/edit-remove.svg
  icons/actions/16/edit-remove.svg
  icons/actions/22/edit-remove.svg
  icons/actions/24/edit-remove.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20702: KTar: Protect against negative longlink sizes

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  Some of the negative values can cause uninitialize memory reads further down 
the code
  
  oss-fuzz #14381

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20702

AFFECTED FILES
  src/ktar.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon

[Björn Feber]

GB_2 added a comment.


  Oops, forgot that `paint-none` already exists, which looks like this. I will 
just make a symlink then.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20697: Review IconBorder

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I like the visual change, let's give it a try. Thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars