D20758: kpackagetool: read kpackage-generic.desktop from qrc

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20758

To: dfaure, sitter, apol
Cc: #frameworks

D20749: autotests: don't fail appstream test because of anything on stderr

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20749

To: dfaure, sitter, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20748: Fix wrong "Unable to find service type" warnings

[Albert Astals Cid]

aacid added a comment.


  Is this autotestable?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20748

To: dfaure, mart, arichardson, davidedmundson, mpyne
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20758: kpackagetool: read kpackage-generic.desktop from qrc

[David Faure]

dfaure created this revision.
dfaure added reviewers: sitter, apol.
dfaure requested review of this revision.

TEST PLAN
  (to mimick CI) : make uninstall in kpackage and then
  QT_LOGGING_RULES='*=true' XDG_DATA_DIRS=$KDEDIR/share 
/d/kde/build/5/frameworks/kpackage/bin/kpackagetool5 --appstream-metainfo . 
--appstream-metainfo-output /tmp/a.xml
  
  For some reason kpackagetool5 creates a KPluginMetaData from
  metadata.desktop in 3 different places of the code
  (Package::setPath calls metadata() but then it deletes it!, metadata() again 
later, and PackageTool::showAppstreamInfo)
  
  Before: Unknown property type for key "X-Plasma-MainScript" -> falling back 
to string
  After: No more warning

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20758

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

To: dfaure, sitter, apol
Cc: #frameworks

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks!

INLINE COMMENTS

> kbookmarkmenu.cpp:150
> +d->numberOfOpenTabs = numberOfOpenTabs;
> +m_bDirty = true;
> +}

Technically this is only needed if the number of open tabs went from "< 2" to 
">= 2" or vice versa.
When going from, say, 20 to 21, we don't need to refill the menu.
So the code could be

  m_bDirty = (d->numberOfOpenTabs < 2) != (numberOfOpenTabs < 2);
  d->numberOfOpenTabs = numberOfOpenTabs;

> kbookmarkmenu.h:104
> + */
> +void setNumberOfOpenTabs(unsigned int numberOfOpenTabs);
> +/**

All the "unsigned int" in this patch is a bit unusual in Qt/KDE code, we use 
int everywhere.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20752: Add missing properties in kpackage-generic.desktop

[David Faure]

dfaure created this revision.
dfaure added reviewers: mart, apol, sitter.
dfaure requested review of this revision.

REVISION SUMMARY
  Before:
  Unknown property type for key "Keywords" -> falling back to string
  Unknown property type for key "X-KDE-ParentApp" -> falling back to string
  
  After:
  Found property definition "X-KPackage-Dependencies" with type "QStringList"
  Found property definition "Keywords" with type "QStringList"

TEST PLAN
  QT_LOGGING_RULES='*=true' kpackagetool5 --appstream-metainfo . 
--appstream-metainfo-output /tmp/a.xml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20752

AFFECTED FILES
  src/kpackage/data/kservicetypes5/kpackage-generic.desktop

To: dfaure, mart, apol, sitter
Cc: #frameworks

D20749: autotests: don't fail appstream test because of anything on stderr

[David Faure]

dfaure created this revision.
dfaure added reviewers: sitter, apol.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  ERROR_VARIABLE simply means where stderr goes, this includes any qDebug,
  which surely doesn't mean failure.

TEST PLAN
  QT_LOGGING_RULES='*=true' ctest. See also CI constantly failing...

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20749

AFFECTED FILES
  autotests/kpackagetoolappstreamtest.cmake

To: dfaure, sitter, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20748: Fix wrong "Unable to find service type" warnings

[David Faure]

dfaure created this revision.
dfaure added reviewers: mart, arichardson, davidedmundson, mpyne.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  If we parsed the service type from a qrc file (like kpackagetool does)
  then it's wrong to later on say we can't find the file defining that
  service type.

TEST PLAN
  make uninstall in kpackage, then
  XDG_DATA_DIRS=$KDEDIR/share /bin/kpackagetool5 --appstream-metainfo 
. --appstream-metainfo-output /tmp/a.xml
  
  Used to say: Unable to find service type for service "KPackage/Generic" 
listed in "./metadata.desktop"
  even though it parsed ":/kservicetypes5/kpackage-generic.desktop" before.
  
  For this we need to extract and store the name of the service type we're
  parsing (key "X-KDE-ServiceType").

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20748

AFFECTED FILES
  src/lib/plugin/desktopfileparser.cpp
  src/lib/plugin/desktopfileparser_p.h

To: dfaure, mart, arichardson, davidedmundson, mpyne
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20742: Paint the folding marker in propper color and make it more visible

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:d9171c391267: Paint the folding marker in proper color and 
make it more visible (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20742?vs=56758=56767

REVISION DETAIL
  https://phabricator.kde.org/D20742

AFFECTED FILES
  src/render/katerenderer.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20735: [KPropertiesDialog] Add octal permissions

[Nathaniel Graham]

ngraham added a comment.


  I think it makes sense to show octal permissions somewhere in the GUI. Power 
users use the GUI, too. :) But yeah, where exactly to put it needs some thought.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20742: Paint the folding marker in propper color and make it more visible

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Both diff + output change in the screenshot look reasonable for me.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20742

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20742: Paint the folding marker in propper color and make it more visible

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Prior to this patch was the line in a color of the word wrap marker painted, 
now its the folding color.
  The line was, at least here, always hard to see, so it's now painted thicker 
and slightly more above. 
  To avoid the line will overpaint the text is the code moved up, before the 
text painting.

TEST PLAN
  F6787435: 1555954064.png 
  For your convenience the raw change before the lines are moved up
  
@@ -886,12 +886,13 @@ void KateRenderer::paintTextLine(QPainter , 
KateLineLayoutPtr range, int x
if (!(flags & SkipDrawFirstInvisibleLineUnderlined) && 
range->startsInvisibleBlock()) {
const QPainter::RenderHints backupRenderHints = paint.renderHints();
paint.setRenderHint(QPainter::Antialiasing, false);
-QPen pen(config()->wordWrapMarkerColor());
+QPen pen(config()->foldingColor());
pen.setCosmetic(true);
pen.setStyle(Qt::DashLine);
pen.setDashOffset(xStart);
+pen.setWidth(2);
paint.setPen(pen);
-paint.drawLine(0, (lineHeight() * range->viewLineCount()) - 1, 
xEnd - xStart, (lineHeight() * range->viewLineCount()) - 1);
+paint.drawLine(0, (lineHeight() * range->viewLineCount()) - 2, 
xEnd - xStart, (lineHeight() * range->viewLineCount()) - 2);
paint.setRenderHints(backupRenderHints);
}

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20742

AFFECTED FILES
  src/render/katerenderer.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20697: Review IconBorder

[Dominik Haumann]

dhaumann added a comment.


  Well, issues that were already there before should not hinder this patch of 
course! If you think this is good enough, please go on.

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20735: [KPropertiesDialog] Add octal permissions

[Pino Toscano]

pino added a comment.


  Also: what is the use case of this feature? For casual users the octal 
permissions make no sense, they are mostly useful for power users (if they 
don't even just use the terminal for these things).
  At most, this would fit in the "advanced permissions" dialog.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20708: Change input-* device icon styles, add 16px icons

[Nathaniel Graham]

ngraham added a comment.


  Even if only Inkscape currently uses the icon, as a rule we ignore that kind 
of information for code/content in Frameworks, because //in principle// any app 
could use it. It's more important for the icon to be semantically correct for 
any app that  wants to use it than it is for it to match its current sole user.
  
  For `dialog-input-devices`, I would accept an icon that //includes// a 
drawing tablet, but not one that has //only// a drawing tablet.
  
  We can do the Mouse and Joystick changes in another patch, I just wanted to 
mention them. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20708

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20735: [KPropertiesDialog] Add octal permissions

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1869
> +lbl = new QLabel(i18n("Octal: %1", perm2), gb);
> +gl = new QGridLayout(gb);
> +gl->addWidget(lbl, 7, 0, Qt::AlignRight);   

You don't need to create a whole new grid layout; just add the label to the 
existing one.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D17442: KTextEditor: Tweak keyboard shortcuts to free F keys

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:8193e735bca2: remove default shortcut F6 to show icon 
border (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17442?vs=47152=56754#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17442?vs=47152=56754

REVISION DETAIL
  https://phabricator.kde.org/D17442

AFFECTED FILES
  src/view/kateview.cpp

To: gregormi, #kate, cullmann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, bruns, demsking, sars

D17442: KTextEditor: Tweak keyboard shortcuts to free F keys

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  We go with the minimal invasive effort ATM: just remove F6.
  As discussed in D17443 .
  We can introduce the CTRL-E... stuff later.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17442

To: gregormi, #kate, cullmann
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, bruns, demsking, sars

D20735: [KPropertiesDialog] Add octal permissions

[Pino Toscano]

pino added a comment.


  In D20735#454271 , @shubham wrote:
  
  > How to print it as octal?
  
  
  http://lmgtfy.com/?q=QString+arg

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20735: [KPropertiesDialog] Add octal permissions

[Shubham]

shubham added a comment.


  In D20735#454263 , @pino wrote:
  
  > Tried to print it as octal-based value?
  
  
  No, now I get that those permissions were base 10.
  How to print it as octal?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20735: [KPropertiesDialog] Add octal permissions

[Pino Toscano]

pino added a comment.


  In D20735#454260 , @shubham wrote:
  
  > I had used permission() to get the mode_t variable, which I later type 
casted to qint64, still the permissions resulted were completed wrong.
  
  
  Tried to print it as octal-based value?
  
  > Any suggestions, how this may be done better in efficient manner?
  
  http://lmgtfy.com/?q=unix+mode_t

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20735: [KPropertiesDialog] Add octal permissions

[Shubham]

shubham added a comment.


  I had used permission() to get the mode_t variable, which I later type casted 
to qint64, still the permissions resulted were completed wrong.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20735: [KPropertiesDialog] Add octal permissions

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  Parsing the result of KFileItem::permissionsString() is a rather bad idea, 
especially considering that KFileItem already provides mode() and permissions().
  
  Also, the placing of the label is completely off.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20525: [InformationPanel] Use the new inline configuration mode

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R318 Dolphin

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

[Björn Feber]

GB_2 updated this revision to Diff 56747.
GB_2 added a comment.


  Fix icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20700?vs=56707=56747

BRANCH
  add-edit-remove-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20700

AFFECTED FILES
  icons-dark/actions/16/edit-remove.svg
  icons-dark/actions/16/paint-none.svg
  icons-dark/actions/22/edit-remove.svg
  icons-dark/actions/22/paint-none.svg
  icons/actions/16/edit-remove.svg
  icons/actions/16/paint-none.svg
  icons/actions/22/edit-remove.svg
  icons/actions/22/paint-none.svg

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20735: [KPropertiesDialog] Add octal permissions

[Shubham]

shubham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

[Nathaniel Graham]

ngraham added a comment.


  This patch doesn't apply:
  
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20693.
Checking patch src/ui/imagepreviewwidget_p.h...
Checking patch src/ui/imagepreviewwidget.cpp...
Checking patch data/thumb_frame.png...
error: the patch applies to 'data/thumb_frame.png' 
(afaf432793864e1fb3f1fc27aa1d53689f2243b5), which does not match the current 
contents.
error: data/thumb_frame.png: patch does not apply
Checking patch data/CMakeLists.txt...
Applied patch src/ui/imagepreviewwidget_p.h cleanly.
Applied patch src/ui/imagepreviewwidget.cpp cleanly.
Applied patch data/CMakeLists.txt cleanly.

 Patch Failed! 
Usage Exception: Unable to apply patch!
  
  Also it would be helpful if you used `arc` for your patches, since then you 
can see the context here in the web UI: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
  
  Additionally, it's nice if you can add a screenshot to the Test Plan section 
for patches that involve UI changes: 
https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Hallas]

hallas added a comment.


  In D20209#450100 , @dfaure wrote:
  
  > Urgh. Indeed. And looking around I find many inline virtuals in apparently 
public headers... http://www.davidfaure.fr/2019/inline_virtual_dtors.diff 
(though maybe some of these don't have d pointers at all...)
  >
  > About KBookmarkOwner, the lack of an explicit constructor is a problem too 
(apps wouldn't instanciate the d pointer). I just added TODO KF6 comments, for 
the next person in your position: 
https://commits.kde.org/kbookmarks/746ecc8db9a04e4d47adc62b0aa03733ca8ecdf8
  >
  > Meanwhile we have to find another way. Would my idea of adding methods to 
KBookmarkMenu work out?
  
  
  @dfaure - I have now implemented the functionality in `KBookmarkMenu` 
instead, so now there should be no ABI breakage :D
  
  Let me know what you think.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Hallas]

hallas updated this revision to Diff 56744.
hallas added a comment.


  Reworked the patch to avoid any ABI breakage. Now the new functionality is in 
KBookmarkMenu instead.

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20209?vs=55300=56744

BRANCH
  add_tabs_open (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20209

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kbookmarkmenutest.cpp
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/76/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 22 Apr 2019 12:42:42 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13358)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2262)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 83 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/83/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Apr 2019 12:42:42 +
 Build duration:
5 min 3 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13358)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2262)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/86/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 22 Apr 2019 12:42:42 +
 Build duration:
5 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20695: Add more icon sizes for audio, configure, distribute

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b5ec56091ed3: Add more icon sizes for audio, configure, 
distribute (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20695?vs=56622=56738

REVISION DETAIL
  https://phabricator.kde.org/D20695

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/configure.svg
  src/desktoptheme/breeze/icons/distribute.svg

To: ndavis, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

[Noah Davis]

ndavis added a comment.


  The 22px version needs to have 1px thick lines and 3px margins on each side.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20735: [KPropertiesDialog] Add octal permissions

[Shubham]

shubham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20735: [KPropertiesDialog] Add octal permissions

[Shubham]

shubham created this revision.
shubham added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  This patch adds file permissions shown in octal format to the 
KPropertiesDialog

TEST PLAN
  1. Right click any file/folder/link
  2. Select Properties
  3. Octal permissions displayed in Permissions tab

REPOSITORY
  R241 KIO

BRANCH
  octal

REVISION DETAIL
  https://phabricator.kde.org/D20735

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20525: [InformationPanel] Use the new inline configuration mode

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in informationpanelcontent.cpp:122-124
> These 3 lines could go in a dedicated function which we could call from both 
> lambdas, to avoid code duplication. Or it could even be a private slot 
> connected to `QDialogButtonBox::clicked`.

I don't think an extra level of indirection makes the code easier to understand 
...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20525: [InformationPanel] Use the new inline configuration mode

[Stefan Brüns]

bruns updated this revision to Diff 56732.
bruns marked 3 inline comments as done.
bruns added a comment.


  coding style, rebase

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20525?vs=56405=56732

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20525

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/panels/information/filemetadataconfigurationdialog.cpp
  src/panels/information/filemetadataconfigurationdialog.h
  src/panels/information/informationpanel.cpp
  src/panels/information/informationpanel.h
  src/panels/information/informationpanelcontent.cpp
  src/panels/information/informationpanelcontent.h

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20668: [InformationPanel] Remove obsolete intermediate wrapper widget/layoutThe Baloo::MetaDataWidget is now able to stretch in a meaningful wayby itself, remove the wrapper.

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:832fd0965594: [InformationPanel] Remove obsolete 
intermediate wrapper widget/layout (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20668?vs=56538=56730#toc

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20668?vs=56538=56730

REVISION DETAIL
  https://phabricator.kde.org/D20668

AFFECTED FILES
  src/panels/information/informationpanelcontent.cpp

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, 
andrebarros, emmanuelp, mikesomov

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich updated this revision to Diff 56729.
astippich added a comment.


  - Test result document

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17302?vs=52894=56729

BRANCH
  test_result

REVISION DETAIL
  https://phabricator.kde.org/D17302

AFFECTED FILES
  autotests/unit/file/CMakeLists.txt
  autotests/unit/file/resulttest.cpp
  src/engine/document.h

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20667: Make the FileMetadataWidget stretch vertically in a sensible way

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:380dc4037c10: Make the FileMetadataWidget stretch 
vertically in a sensible way (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20667?vs=56537=56726#toc

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20667?vs=56537=56726

REVISION DETAIL
  https://phabricator.kde.org/D20667

AFFECTED FILES
  src/filemetadatawidget.cpp

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:c36d6b26eb3f: [FileMetaDataWidget] Allow inline 
configuration of visible properties (authored by bruns).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20524?vs=56545=56725

REVISION DETAIL
  https://phabricator.kde.org/D20524

AFFECTED FILES
  src/filemetadatawidget.cpp
  src/filemetadatawidget.h

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich, elvisangelaccio
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 80 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/80/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 22 Apr 2019 10:47:46 +
 Build duration:
2 min 2 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3645/4297)48%
(5087/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1259/1289)49%
(2541/5207)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/86/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Apr 2019 10:47:46 +
 Build duration:
2 min 12 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3645/4297)48%
(5087/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1259/1289)49%
(2541/5207)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/85/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 22 Apr 2019 10:47:46 +
 Build duration:
1 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.extractorcoveragetest

D20608: Declare properties as meta type

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:e869bac59302: Declare properties as meta type (authored 
by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20608?vs=56387=56722

REVISION DETAIL
  https://phabricator.kde.org/D20608

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/properties.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/23/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 22 Apr 2019 09:41:39 +
 Build duration:
1 min 59 sec and counting
   BUILD ARTIFACTS
  acc/KF5Package-5.58.0.xmllogs/KF5Package/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1614/2221)51%
(1022/2020)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(529/531)48%
(212/442)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(562/759)63%
(532/845)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/531)34%
(177/522)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/20/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 22 Apr 2019 09:41:39 +
 Build duration:
2 min 4 sec and counting
   BUILD ARTIFACTS
  acc/KF5Package-5.58.0.xmllogs/KF5Package/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1614/2221)51%
(1022/2020)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(529/531)48%
(212/442)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(562/759)63%
(532/845)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/531)34%
(177/522)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/22/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 22 Apr 2019 09:41:39 +
 Build duration:
1 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

[Björn Feber]

GB_2 retitled this revision from "Add "edit-remove" icon symlink" to "Add 
"edit-remove" icon symlink and add 22px version of "paint-none"".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20700: Add "edit-remove" icon symlink

[Björn Feber]

GB_2 updated this revision to Diff 56707.
GB_2 added a comment.


  Add 22px version of `paint-none` and add symlink for it

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20700?vs=56651=56707

BRANCH
  add-edit-remove-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20700

AFFECTED FILES
  icons-dark/actions/16/edit-remove.svg
  icons-dark/actions/16/paint-none.svg
  icons-dark/actions/22/edit-remove.svg
  icons-dark/actions/22/paint-none.svg
  icons/actions/16/edit-remove.svg
  icons/actions/16/paint-none.svg
  icons/actions/22/edit-remove.svg
  icons/actions/22/paint-none.svg

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20697: Review IconBorder

[loh tar]

loh.tar added a comment.


  In D20697#453841 , @dhaumann wrote:
  
  > Did you test that the annotation border still works? You can do so in 
KDevelop by invoking git blame.
  
  
  :-/ ...OK, thanks
  
  > Besides I still gave no issues with this patch, except that I did not test 
myself. If you say there are mouse move issues, then these issues should be 
fixed asap :)
  
  It's no new issue..so it's not so urgent  :P

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20169: Add profile support interface for TerminalInterface

[Maximilian Schiller]

mschiller updated this revision to Diff 56697.
mschiller added a comment.


  change KDEPARTS to KPARTS

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=56696=56697

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/CMakeLists.txt
  src/terminalprofileinterface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

[Maximilian Schiller]

mschiller marked 3 inline comments as done.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

[Maximilian Schiller]

mschiller updated this revision to Diff 56696.
mschiller added a comment.


  Remove getProfilePath and remove get prefixes

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=56672=56696

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/CMakeLists.txt
  src/terminalprofileinterface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

[Dominik Haumann]

dhaumann added a comment.


  Please fix the API getters: in the KDE/Qt world, getters never start with 
'get': just use availableProdiles() etc.
  
  Similarly, I suggest to rename changeCurrentProfile() to setCurrentProfile().
  
  Could you provide an updated patch?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20697: Review IconBorder

[Dominik Haumann]

dhaumann added a comment.


  Did you test that the annotation border still works? You can do so in 
KDevelop by invoking git blame.
  
  Besides I still gave no issues with this patch, except that I did not test 
myself. If you say there are mouse move issues, then these issues should be 
fixed asap :)

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20264: Add test for "Auto Reload Document" option

[Dominik Haumann]

dhaumann added a comment.


  Yes, that's exactly what I meant. But if it's not stable, then it does not 
help. Maybe in that case keep it as is for now?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20264

To: loh.tar, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20700: Add "edit-remove" icon symlink

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I'll accept this if you also make 22px versions.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns