KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 79 - Still unstable!

2019-05-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/79/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 06 May 2019 22:18:25 +
 Build duration:
3 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: projectroot.autotests.kdelibs4configmigratortestFailed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kformattestFailed: projectroot.autotests.kprocesslisttestFailed: projectroot.autotests.krandomtest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 45 - Still Unstable!

2019-05-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/45/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 06 May 2019 22:18:25 +
 Build duration:
1 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kformattestFailed: projectroot.autotests.kprocesslisttest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 44 - Still Unstable!

2019-05-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/44/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 06 May 2019 22:11:25 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kformattestFailed: projectroot.autotests.kprocesslisttest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 43 - Still Unstable!

2019-05-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/43/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 06 May 2019 22:02:49 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kformattestFailed: projectroot.autotests.kprocesslisttest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 78 - Still Failing!

2019-05-06 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/78/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 06 May 2019 22:11:25 +
 Build duration:
1 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 323 lines...][2019-05-06T22:12:27.567Z] TODO: make it an error if one of the service type files is invalid or not found[2019-05-06T22:12:27.567Z] desktopfileparser.cpp[2019-05-06T22:12:29.372Z] [ 11%] Linking CXX executable ..\..\bin\desktoptojson.exe[2019-05-06T22:12:29.802Z] ktexttohtml.cpp[2019-05-06T22:12:32.789Z] [ 12%] Built target KF5CoreAddons_QCH[2019-05-06T22:12:32.790Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kaboutdata.cpp.obj[2019-05-06T22:12:32.790Z] [  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kcoreaddons.cpp.obj[2019-05-06T22:12:32.790Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.obj[2019-05-06T22:12:32.790Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.obj[2019-05-06T22:12:32.790Z] kaboutdata.cpp[2019-05-06T22:12:32.790Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.obj[2019-05-06T22:12:32.790Z] [ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.obj[2019-05-06T22:12:32.790Z] [ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.obj[2019-05-06T22:12:32.790Z] [ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.obj[2019-05-06T22:12:32.790Z] [ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.obj[2019-05-06T22:12:33.850Z] [ 12%] Built target desktoptojson[2019-05-06T22:12:33.850Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.obj[2019-05-06T22:12:34.825Z] kcoreaddons.cpp[2019-05-06T22:12:34.825Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.obj[2019-05-06T22:12:35.102Z] [ 14%] Linking CXX executable ..\bin\ktexttohtmltest.exe[2019-05-06T22:12:35.697Z] kfilesystemtype.cpp[2019-05-06T22:12:35.964Z] kmessage.cpp[2019-05-06T22:12:35.964Z] [ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.obj[2019-05-06T22:12:35.964Z] [ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.obj[2019-05-06T22:12:36.554Z] [ 15%] Built target ktexttohtmltest[2019-05-06T22:12:36.554Z] [ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginloader.cpp.obj[2019-05-06T22:12:37.182Z] kjobuidelegate.cpp[2019-05-06T22:12:37.182Z] kautosavefile.cpp[2019-05-06T22:12:37.182Z] kdirwatch.cpp[2019-05-06T22:12:37.182Z] kpluginfactory.cpp[2019-05-06T22:12:37.182Z] kpluginloader.cpp[2019-05-06T22:12:37.182Z] kprocess.cpp[2019-05-06T22:12:37.182Z] kbackup.cpp[2019-05-06T22:12:37.182Z] kurlmimedata.cpp[2019-05-06T22:12:37.182Z] [ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.obj[2019-05-06T22:12:37.182Z] kcompositejob.cpp[2019-05-06T22:12:37.182Z] kjob.cpp[2019-05-06T22:12:37.182Z] kjobtrackerinterface.cpp[2019-05-06T22:12:37.182Z] [ 17%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginmetadata.cpp.obj[2019-05-06T22:12:37.182Z] KDE5 TODO: Remove KConfig correctly[2019-05-06T22:12:37.463Z] kpluginmetadata.cpp[2019-05-06T22:12:37.757Z] [ 17%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/desktopfileparser.cpp.obj[2019-05-06T22:12:38.044Z] desktopfileparser.cpp[2019-05-06T22:12:38.044Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandom.cpp.obj[2019-05-06T22:12:38.044Z] krandom.cpp[2019-05-06T22:12:38.315Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandomsequence.cpp.obj[2019-05-06T22:12:39.383Z] krandomsequence.cpp[2019-05-06T22:12:39.667Z] [ 19%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander.cpp.obj[2019-05-06T22:12:39.667Z] [ 19%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kstringhandler.cpp.obj[2019-05-06T22:12:41.244Z] kstringhandler.cpp[2019-05-06T22:12:41.244Z] kmacroexpander.cpp[2019-05-06T22:12:41.244Z] [ 20%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/ktexttohtml.cpp.obj[2019-05-06T22:12:42.662Z] ktexttohtml.cpp[2019-05-06T22:12:42.924Z] [ 20%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4migration.cpp.obj[2019-05-06T22:12:42.924Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.11\src\lib\plugin\kpluginfactory.cpp(124): warning C4996: 'KPluginFactory::createPartObject': was declared deprecated[2019-05-06T22:12:42.924Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.11\src\lib\plugin\kpluginfactory.cpp(103): note: see declaration of 'KPluginFactory::createPartObject'[2019-05-06T22:12:42.924Z]

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 77 - Still Failing!

2019-05-06 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/77/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 06 May 2019 22:02:49 +
 Build duration:
1 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 330 lines...][2019-05-06T22:04:21.024Z] [  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.obj[2019-05-06T22:04:21.024Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.obj[2019-05-06T22:04:21.024Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.obj[2019-05-06T22:04:21.024Z] kaboutdata.cpp[2019-05-06T22:04:21.024Z] [ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.obj[2019-05-06T22:04:21.024Z] [ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.obj[2019-05-06T22:04:21.024Z] [ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.obj[2019-05-06T22:04:21.024Z] [ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.obj[2019-05-06T22:04:21.024Z] kcoreaddons.cpp[2019-05-06T22:04:21.024Z] [ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.obj[2019-05-06T22:04:21.024Z] kmessage.cpp[2019-05-06T22:04:21.024Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.obj[2019-05-06T22:04:21.024Z] kfilesystemtype.cpp[2019-05-06T22:04:21.024Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.obj[2019-05-06T22:04:21.024Z] kautosavefile.cpp[2019-05-06T22:04:21.024Z] [ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.obj[2019-05-06T22:04:21.024Z] kbackup.cpp[2019-05-06T22:04:21.024Z] KDE5 TODO: Remove KConfig correctly[2019-05-06T22:04:21.024Z] [ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.obj[2019-05-06T22:04:21.024Z] kjobuidelegate.cpp[2019-05-06T22:04:21.024Z] kdirwatch.cpp[2019-05-06T22:04:21.024Z] kpluginfactory.cpp[2019-05-06T22:04:21.024Z] kprocess.cpp[2019-05-06T22:04:21.024Z] kurlmimedata.cpp[2019-05-06T22:04:21.024Z] kcompositejob.cpp[2019-05-06T22:04:21.024Z] kjob.cpp[2019-05-06T22:04:21.024Z] kjobtrackerinterface.cpp[2019-05-06T22:04:21.284Z] [ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginloader.cpp.obj[2019-05-06T22:04:21.284Z] [ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginmetadata.cpp.obj[2019-05-06T22:04:21.284Z] [ 17%] Linking CXX executable ..\bin\ktexttohtmltest.exe[2019-05-06T22:04:21.284Z] kpluginmetadata.cpp[2019-05-06T22:04:21.284Z] kpluginloader.cpp[2019-05-06T22:04:21.284Z] [ 17%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/desktopfileparser.cpp.obj[2019-05-06T22:04:21.854Z] desktopfileparser.cpp[2019-05-06T22:04:21.854Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandom.cpp.obj[2019-05-06T22:04:21.854Z] krandom.cpp[2019-05-06T22:04:21.854Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandomsequence.cpp.obj[2019-05-06T22:04:21.854Z] [ 19%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander.cpp.obj[2019-05-06T22:04:21.854Z] krandomsequence.cpp[2019-05-06T22:04:22.112Z] kmacroexpander.cpp[2019-05-06T22:04:22.112Z] [ 19%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kstringhandler.cpp.obj[2019-05-06T22:04:22.372Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.11\src\lib\plugin\kpluginfactory.cpp(124): warning C4996: 'KPluginFactory::createPartObject': was declared deprecated[2019-05-06T22:04:22.372Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.11\src\lib\plugin\kpluginfactory.cpp(103): note: see declaration of 'KPluginFactory::createPartObject'[2019-05-06T22:04:22.372Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.11\src\lib\plugin\kpluginfactory.cpp(129): warning C4996: 'KPluginFactory::createObject': was declared deprecated[2019-05-06T22:04:22.372Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.11\src\lib\plugin\kpluginfactory.cpp(93): note: see declaration of 'KPluginFactory::createObject'[2019-05-06T22:04:22.372Z] kstringhandler.cpp[2019-05-06T22:04:22.372Z] [ 20%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/ktexttohtml.cpp.obj[2019-05-06T22:04:22.372Z] [ 20%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4migration.cpp.obj[2019-05-06T22:04:22.372Z] ktexttohtml.cpp[2019-05-06T22:04:22.633Z] [ 20%] Built target KF5CoreAddons_QCH[2019-05-06T22:04:22.633Z] [ 21%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4configmigrator.cpp.obj[2019-05-06T22:04:22.633Z] [ 21%] Built target ktexttohtmltest[2019-05-06T22:04:22.633Z] kdelibs4migration.cpp[2019-05-06T22:04:22.633Z]

D20958: New menu of syntax highlighting in the status bar

2019-05-06 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this is now perfect from my UI perspective. I'll let the KTextEditor 
folks do the code review part. :)

REPOSITORY
  R39 KTextEditor

BRANCH
  new-mode-menu

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg, ngraham
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D20833: Simpler check for flatpak

2019-05-06 Thread Jan Grulich 
jgrulich added a comment.


  Lookgs good to me, I'll wait for Kai to approve this since he is the 
maintainer. One thing to consider maybe, did /.flatpak-info always exist or is 
it something new? I always assumed there is just one flatpak-info file in 
$XDG_RUNTIME_DIR. Just to be sure it will work for older Flatpak versions.

INLINE COMMENTS

> broulik wrote in knotificationmanager.cpp:94
> Do you need this check now, even, since you're not using it anymore?

I think Kai is right, since there is /.flatpak-info (which I didn't know about 
until now), you don't need to check $XDG_RUNTIME_DIR.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20833

To: apol, #frameworks
Cc: jgrulich, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-06 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> hallas wrote in fstabhandling.cpp:126
> Yes indeed :D I was just wondering why it was made the way it is? Is there a 
> reason for the limit or was it just because we were only targeting vault type 
> mounts?

fuse filesystems are just to different to say "just add it and see what 
breaks". Other types should be added on a strict whitelist basis.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

2019-05-06 Thread Stefan Brüns 
bruns marked 2 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> hallas wrote in fstabdevice.cpp:62
> Would it make sense to wrap this in a function with a more expressive name 
> like: isEncryptedFilesystem or isValutFilesystem? Then we could use the same 
> function in fstabhandling.cpp:126

I don't think there is much to gain here - as the function is trivial, we 
should inline it. To keep the code easy to understand, the function name has to 
be really expressive. On the next fuse filesystem added, it may become quite 
different.

> hallas wrote in fstabdevice.cpp:172
> Why do we create a new FstabNetworkShare everytime this function is called 
> with NetworkShare but we return the same object instance when it is a 
> StorageAccess?

The storageAccess is also used internally, for the `emblems()` method. Creating 
it on each call would be to expensive, especially as it has quite some signals 
connected, also DBus signals.
NetworkShare is quite lightweight. There is no reason it couldn't be cached, 
but hardly any benefit.

REPOSITORY
  R245 Solid

BRANCH
  fstab_generic

REVISION DETAIL
  https://phabricator.kde.org/D21041

To: bruns, #frameworks, ngraham, hallas
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Still Unstable!

2019-05-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/42/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 06 May 2019 17:49:14 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kformattestFailed: projectroot.autotests.kprocesslisttest

D20007: Add GetProcessList for retrieving the list of currently active processes

2019-05-06 Thread David Hallas 
hallas added a comment.


  Thanks for the review! Landing it now.

REPOSITORY
  R244 KCoreAddons

BRANCH
  adds_kprocesslist (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 76 - Failure!

2019-05-06 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/76/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 06 May 2019 17:49:14 +
 Build duration:
1 min 33 sec and counting
   CONSOLE OUTPUT
  [...truncated 326 lines...][2019-05-06T17:50:15.488Z] mocs_compilation.cpp[2019-05-06T17:50:17.064Z] [ 17%] Linking CXX executable ..\bin\ktexttohtmltest.exe[2019-05-06T17:50:17.891Z] [ 19%] Built target desktoptojson[2019-05-06T17:50:17.891Z] [  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kaboutdata.cpp.obj[2019-05-06T17:50:17.891Z] [  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kcoreaddons.cpp.obj[2019-05-06T17:50:17.891Z] [  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.obj[2019-05-06T17:50:17.891Z] kaboutdata.cpp[2019-05-06T17:50:17.891Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.obj[2019-05-06T17:50:17.891Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.obj[2019-05-06T17:50:17.891Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.obj[2019-05-06T17:50:17.891Z] [  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.obj[2019-05-06T17:50:17.891Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.obj[2019-05-06T17:50:17.892Z] [ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.obj[2019-05-06T17:50:17.892Z] kcoreaddons.cpp[2019-05-06T17:50:17.892Z] [ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.obj[2019-05-06T17:50:17.892Z] kmessage.cpp[2019-05-06T17:50:17.892Z] kautosavefile.cpp[2019-05-06T17:50:17.892Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.obj[2019-05-06T17:50:17.892Z] kdirwatch.cpp[2019-05-06T17:50:17.892Z] kfilesystemtype.cpp[2019-05-06T17:50:17.892Z] kprocess.cpp[2019-05-06T17:50:17.892Z] kbackup.cpp[2019-05-06T17:50:17.892Z] KDE5 TODO: Remove KConfig correctly[2019-05-06T17:50:17.892Z] kurlmimedata.cpp[2019-05-06T17:50:17.892Z] kcompositejob.cpp[2019-05-06T17:50:17.892Z] kjob.cpp[2019-05-06T17:50:17.892Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.obj[2019-05-06T17:50:17.892Z] kjobtrackerinterface.cpp[2019-05-06T17:50:17.892Z] [ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.obj[2019-05-06T17:50:17.892Z] [ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.obj[2019-05-06T17:50:17.892Z] [ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginloader.cpp.obj[2019-05-06T17:50:17.892Z] kjobuidelegate.cpp[2019-05-06T17:50:17.892Z] [ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginmetadata.cpp.obj[2019-05-06T17:50:17.892Z] [ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/desktopfileparser.cpp.obj[2019-05-06T17:50:17.892Z] kpluginmetadata.cpp[2019-05-06T17:50:17.892Z] kpluginloader.cpp[2019-05-06T17:50:17.892Z] kpluginfactory.cpp[2019-05-06T17:50:17.892Z] desktopfileparser.cpp[2019-05-06T17:50:17.892Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandom.cpp.obj[2019-05-06T17:50:17.892Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandomsequence.cpp.obj[2019-05-06T17:50:17.892Z] [ 19%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander.cpp.obj[2019-05-06T17:50:17.892Z] krandom.cpp[2019-05-06T17:50:18.220Z] [ 19%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kstringhandler.cpp.obj[2019-05-06T17:50:21.982Z] krandomsequence.cpp[2019-05-06T17:50:21.982Z] kmacroexpander.cpp[2019-05-06T17:50:21.982Z] kstringhandler.cpp[2019-05-06T17:50:21.982Z] [ 20%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/ktexttohtml.cpp.obj[2019-05-06T17:50:22.448Z] [ 20%] Built target ktexttohtmltest[2019-05-06T17:50:22.448Z] [ 20%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/util/kdelibs4migration.cpp.obj[2019-05-06T17:50:29.693Z] [ 20%] Built target KF5CoreAddons_QCH[2019-05-06T17:50:29.693Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.11\src\lib\plugin\kpluginfactory.cpp(124): warning C4996: 'KPluginFactory::createPartObject': was declared deprecated[2019-05-06T17:50:29.693Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.11\src\lib\plugin\kpluginfactory.cpp(103): note: see declaration of 'KPluginFactory::createPartObject'[2019-05-06T17:50:29.693Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5 WindowsMSVCQt5.11\src\lib\plugin\kpluginfactory.cpp(129): warning C4996: 'KPluginFactory::createObject': was declared deprecated[2019-05-06T17:50:29.693Z] C:\CI\workspace\Frameworks\kcoreaddons\kf5-qt5

D20007: Add GetProcessList for retrieving the list of currently active processes

2019-05-06 Thread David Hallas 
hallas closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

2019-05-06 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  adds_kprocesslist (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

2019-05-06 Thread David Hallas 
hallas added a comment.


  @davidedmundson  - ping ?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: vonreth, adridg, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20938: Add Mounts Backend

2019-05-06 Thread David Hallas 
hallas added a comment.


  This patch has been superseeded by the wotk @bruns has done in D20995 
 - so closing this one :D

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20938

To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns
Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel, michaelh, ngraham, bruns

D20938: Add Mounts Backend

2019-05-06 Thread David Hallas 
hallas abandoned this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20938

To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns
Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

2019-05-06 Thread David Hallas 
hallas added inline comments.

INLINE COMMENTS

> fstabdevice.cpp:62
>  }
> +if ((fstype == QLatin1String("fuse.encfs")) ||
> +(fstype == QLatin1String("fuse.cryfs"))) {

Would it make sense to wrap this in a function with a more expressive name 
like: isEncryptedFilesystem or isValutFilesystem? Then we could use the same 
function in fstabhandling.cpp:126

> fstabdevice.cpp:91
>  if (m_iconName.isEmpty()) {
> -if (m_isNetworkShare) {
> +if (m_storageType == StorageType::NetworkShare) {
>  m_iconName = QLatin1String("network-server");

I think a switch here (without a default case) would be nice. This would allow 
us to get the compiler to tell us to update this list if new storage types are 
added.

> fstabdevice.cpp:172
> +   (interfaceType == Solid::DeviceInterface::NetworkShare)) {
>  return new FstabNetworkShare(this);
>  }

Why do we create a new FstabNetworkShare everytime this function is called with 
NetworkShare but we return the same object instance when it is a StorageAccess?

REPOSITORY
  R245 Solid

BRANCH
  fstab_generic

REVISION DETAIL
  https://phabricator.kde.org/D21041

To: bruns, #frameworks, ngraham, hallas
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 101 - Still Unstable!

2019-05-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/101/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 06 May 2019 16:15:57 +
 Build duration:
9 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

2019-05-06 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f066660f: [FileWidget] Replace Filter: 
with File type: when saving with a limited… (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20964?vs=57517=57656

REVISION DETAIL
  https://phabricator.kde.org/D20964

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KCalCore

2019-05-06 Thread Sérgio Martins 
On Tue, Apr 30, 2019 at 8:52 PM Allen Winter  wrote:
>
> Clazy is complaining about missing assign operators.  Do we care?
> If so, I can take a look at adding them or if anyone else wants to do that.
> -Allen

That will be fixed in Qt.

Regards,
Sergio Martins

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-06 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-06 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!

INLINE COMMENTS

> meven wrote in kdiroperator.cpp:418
> Any idea where I should add this information ?
> An example would suffice.

You already did, in the inline function documentation in 
`src/filewidgets/kdiroperator.h`

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-06 Thread David Hallas 
hallas added inline comments.

INLINE COMMENTS

> ngraham wrote in fstabhandling.cpp:126
> Now that the refactoring's been done, it should be easy to add support for 
> those or remove the conditional.

Yes indeed :D I was just wondering why it was made the way it is? Is there a 
reason for the limit or was it just because we were only targeting vault type 
mounts?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

2019-05-06 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  fstab_generic

REVISION DETAIL
  https://phabricator.kde.org/D21041

To: bruns, #frameworks, ngraham, hallas
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-06 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> hallas wrote in fstabhandling.cpp:126
> Why do we limit to these two filesystems? I think it would be really useful 
> to show all kinds of fuse based filesystems, e.g. isofs, sshfs and 
> xrdp-chansrv.

Now that the refactoring's been done, it should be easy to add support for 
those or remove the conditional.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

2019-05-06 Thread David Hallas 
hallas added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:126
> +{
> +if (fstype == "fuse.encfs" ||
> +fstype == "fuse.cryfs") {

Why do we limit to these two filesystems? I think it would be really useful to 
show all kinds of fuse based filesystems, e.g. isofs, sshfs and xrdp-chansrv.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

2019-05-06 Thread David Faure 
dfaure added a comment.


  I don't object to the patch, but maybe the properties dialog (and other users 
of this job) should indicate that the number being shown is "sum of file sizes, 
not actual disk space usage, which is larger" (blocks, inodes, directory 
sizes...)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17071

To: davidedmundson, dfaure, apol
Cc: sasch, adridg, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

2019-05-06 Thread Stefan Brüns 
bruns added a comment.


  In D21041#461446 , @broulik wrote:
  
  > Looks like we need a symbolic icon for that in breeze
  
  
  #vdg   ^
  
  Preferably yes, though thats orthogonal to this change.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21041

To: bruns, #frameworks, ngraham, hallas
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15076: Build failures with KSyntaxHighlighting 5.49

2019-05-06 Thread Tomaz Canabrava 
tcanabrava resigned from this revision.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D15076

To: asemke, #kde_edu, #cantor, #frameworks
Cc: bcooksley, elvisangelaccio, dfaure, cgiboudeaux, mpyne, cullmann, kde-edu, 
narvaez, apol

D19956: ki18n: updating memory manager and removing compile warnings

2019-05-06 Thread Tomaz Canabrava 
tcanabrava resigned from this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D19956

To: carneirogustavo, andreagenor, patrickelectric
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-06 Thread Méven Car 
meven updated this revision to Diff 57636.
meven edited the test plan for this revision.
meven added a comment.


  Fix drag^Ciltering, add mime filtering to the drag filtering

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20838?vs=57625=57636

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kfilewidgettest_gui.cpp

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-06 Thread Méven Car 
meven planned changes to this revision.
meven added a comment.


  An eventFilter must return true when the event has been processed and prevent 
further event handling.
  This prevent the drag filtering to not work (multiple files for instance).
  The code does not do that currently, I am on it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-06 Thread Méven Car 
meven edited the summary of this revision.
meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

2019-05-06 Thread Kai Uwe Broulik 
broulik added a comment.


  Looks like we need a symbolic icon for that in breeze

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21041

To: bruns, #frameworks, ngraham, hallas
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns