KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 36 - Fixed!

2019-05-08 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/36/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 08 May 2019 07:51:01 +
 Build duration:
5 min 18 sec and counting
   BUILD ARTIFACTS
  acc/KF5Wayland-5.58.0.xmllogs/KF5Wayland/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/262)92%
(240/262)85%
(26939/31565)53%
(10813/20237)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12355/12425)50%
(6497/12909)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6296/7409)65%
(1815/2806)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)86%
(7834/9074)66%
(2324/3531)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 32 - Still Unstable!

2019-05-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/32/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 08 May 2019 07:51:01 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5Wayland-5.58.0.xmllogs/KF5Wayland/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModelFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSurface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(237/262)90%
(237/262)79%
(24900/31493)48%
(9792/20237)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(41/43)95%
(41/43)88%
(10921/12419)44%
(5723/12909)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client97%
(72/74)97%
(72/74)80%
(5897/7373)59%
(1644/2806)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)84%
(7628/9044)64%
(2248/3531)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Unstable!

2019-05-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/40/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 08 May 2019 07:51:01 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D15910: Implement wl_surface::damage_buffer

2019-05-08 Thread Roman Gilg 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b71e10359725: Implement wl_surface::damage_buffer 
(authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15910?vs=48477&id=57749#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15910?vs=48477&id=57749

REVISION DETAIL
  https://phabricator.kde.org/D15910

AFFECTED FILES
  autotests/client/test_wayland_surface.cpp
  src/client/registry.cpp
  src/client/surface.cpp
  src/client/surface.h
  src/server/compositor_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface_p.h

To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D19455: [knotification] compile without deprecated methods

2019-05-08 Thread David Faure 
dfaure added a comment.


  OK, it looks like everyone is waiting on everyone else in this discussion.
  
  Done now: 
https://commits.kde.org/knotifications/adc20218571941d19281ad81520aec62e195b355

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D19455

To: mlaurent, dfaure
Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-08 Thread Steffen Hartleib 
steffenh added a comment.


  Hi @apol,
  
  Thanks for your time to look at my code. I know, I'am not good at this, so if 
you can point me at my errors I will try to correct this.

INLINE COMMENTS

> apol wrote in koneandtwofingerswipe.h:36
> Why is this commented out?

Oops this should not be here, it is a left over from gwenview.

> apol wrote in koneandtwofingerswipe.h:50
> If classes are installed and exported they should have a d-pointer.

Ok, I will add a private class for all exported classes.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-08 Thread Steffen Hartleib 
steffenh added a comment.


  Hi @nicolasfella,
  
  Ok, I need a new name, perhaps KGesture ?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 62 - Fixed!

2019-05-08 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/62/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 08 May 2019 08:39:06 +
 Build duration:
1 hr 26 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21079: make sure to also assert ScaledDirectories

2019-05-08 Thread Harald Sitter 
sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  Directories and ScaledDirectories do the same thing, the latter is however
  used for backwards compatibility with old theme implementations that do not
  know how to handle scaled icons. since our test knows how to handle
  scaled icons the two directories are in fact meant to be one long list for
  our purposes

TEST PLAN
  test still passes. stringlist now contains both types

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21079

AFFECTED FILES
  autotests/scalabletest.cpp

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21079: make sure to also assert ScaledDirectories

2019-05-08 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21079

To: sitter, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21079: make sure to also assert ScaledDirectories

2019-05-08 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:7e974fd48e0d: make sure to also assert ScaledDirectories 
(authored by sitter).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21079?vs=57753&id=57754

REVISION DETAIL
  https://phabricator.kde.org/D21079

AFFECTED FILES
  autotests/scalabletest.cpp

To: sitter, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20958: New menu of syntax highlighting in the status bar

2019-05-08 Thread loh tar 
loh.tar added a comment.


  >> I could add a "Recent" section to the beginning of the menu, it would be 
useful.
  > 
  > Nice! Just to be clear. That should to be work over session borders, not 
only the current one.
  
  Should you do it, here some bug report 
https://bugs.kde.org/show_bug.cgi?id=397563 but perhaps can this be closed in 
any case

REPOSITORY
  R39 KTextEditor

BRANCH
  new-mode-menu

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-08 Thread Méven Car 
meven added a comment.


  @ngraham Should I wait for some more review/testing, or LGTM means let's get 
this merge ASAP ?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20838_1

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-08 Thread Nathaniel Graham 
ngraham added a comment.


  Here's a tip: you can use https://lxr.kde.org to search for existing class 
names and identifiers.
  
  https://lxr.kde.org/search?_filestring=kgesture&_string=

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: ngraham, apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-08 Thread Nathaniel Graham 
ngraham added a comment.


  Given that nobody else from #frameworks 
 has offered any review comments, 
I say let's get it in early in this Frameworks cycle (i.e. now-ish) so we have 
almost a month of testing before release.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20838_1

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-08 Thread Méven Car 
meven added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D20838_1

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

2019-05-08 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21084

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21084: Symlink arrow-*-double to go-*-skip, add 24px go-*-skip

2019-05-08 Thread Noah Davis 
ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The arrow-*-double icons were symlinked to the go-top/bottom/first/last 
icons. Those didn't look like double arrows, so the arrow-*-double icons are 
now symlinked to go-*-skip.
  
  A previous commit with this change was reverted because there weren't any 
24px go-*-skip icons, so this patch also includes the missing icons.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arrows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21084

AFFECTED FILES
  icons-dark/actions/16/arrow-down-double.svg
  icons-dark/actions/16/arrow-left-double.svg
  icons-dark/actions/16/arrow-right-double.svg
  icons-dark/actions/16/arrow-up-double.svg
  icons-dark/actions/22/arrow-down-double.svg
  icons-dark/actions/22/arrow-left-double.svg
  icons-dark/actions/22/arrow-right-double.svg
  icons-dark/actions/22/arrow-up-double.svg
  icons-dark/actions/24/arrow-down-double.svg
  icons-dark/actions/24/arrow-left-double.svg
  icons-dark/actions/24/arrow-right-double.svg
  icons-dark/actions/24/arrow-up-double.svg
  icons-dark/actions/24/go-down-skip.svg
  icons-dark/actions/24/go-next-skip.svg
  icons-dark/actions/24/go-previous-skip.svg
  icons-dark/actions/24/go-up-skip.svg
  icons-dark/actions/32/arrow-down-double.svg
  icons-dark/actions/32/arrow-left-double.svg
  icons-dark/actions/32/arrow-right-double.svg
  icons-dark/actions/32/arrow-up-double.svg
  icons/actions/16/arrow-down-double.svg
  icons/actions/16/arrow-left-double.svg
  icons/actions/16/arrow-right-double.svg
  icons/actions/16/arrow-up-double.svg
  icons/actions/22/arrow-down-double.svg
  icons/actions/22/arrow-left-double.svg
  icons/actions/22/arrow-right-double.svg
  icons/actions/22/arrow-up-double.svg
  icons/actions/24/arrow-down-double.svg
  icons/actions/24/arrow-left-double.svg
  icons/actions/24/arrow-right-double.svg
  icons/actions/24/arrow-up-double.svg
  icons/actions/24/go-down-skip.svg
  icons/actions/24/go-next-skip.svg
  icons/actions/24/go-previous-skip.svg
  icons/actions/24/go-up-skip.svg
  icons/actions/32/arrow-down-double.svg
  icons/actions/32/arrow-left-double.svg
  icons/actions/32/arrow-right-double.svg
  icons/actions/32/arrow-up-double.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-08 Thread Steffen Hartleib 
steffenh added a comment.


  Hi @ngraham,
  
  thanks for the link, I see KGesture is already used. I hope KGestureHandler 
is not too similar

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: ngraham, apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-08 Thread Nathaniel Graham 
ngraham added a comment.


  Since these are touch-only, maybe `KTouchGesture` or `KTouchHandler`?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: ngraham, apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, bruns

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

2019-05-08 Thread Christoph Cullmann 
cullmann added a comment.


  I am not sure about the "UserSetsOfCharsToEncloseSelection" part.
  Wouldn't it be enough to have the "CharsToEncloseSelection" config part and 
have the other thing just internal in the editor config page as "template" the 
user can select to fill the selection of characters?
  I don't see the real benefit to have this as config.

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor, cullmann, mwolff, #vdg
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, dhaumann

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

2019-05-08 Thread Christoph Cullmann 
cullmann requested changes to this revision.
This revision now requires changes to proceed.

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor, cullmann, mwolff, #vdg
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, dhaumann

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

2019-05-08 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok ;=)
  Thanks for quick fix.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21078

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20083: Multiple level of autobrace

2019-05-08 Thread Christoph Cullmann 
cullmann abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20083

To: cullmann, cactus
Cc: cullmann, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D20083: Multiple level of autobrace

2019-05-08 Thread Christoph Cullmann 
cullmann commandeered this revision.
cullmann added a reviewer: cactus.
cullmann added a comment.


  We consider this fixed with D19608 .
  If you disagree, feel free to reopen this request.
  Btw., thanks for the incentive to submit a patch!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20083

To: cullmann, cactus
Cc: cullmann, loh.tar, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D4234: Change algorithm for autobrace.

2019-05-08 Thread Christoph Cullmann 
cullmann commandeered this revision.
cullmann added a reviewer: cactus.
cullmann added a comment.


  We altered stuff in D19608 .
  Could you try if that fits your needs?
  If not, perhaps we need a new review for what can be further improved, thanks.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4234

To: cullmann, #ktexteditor, mwolff, brauch, cactus
Cc: kde-frameworks-devel, nalvarez, mwolff, anthonyfieroni, dhaumann, brauch, 
cullmann, kwrite-devel, domson, michaelh, ngraham, bruns, demsking, sars

D4234: Change algorithm for autobrace.

2019-05-08 Thread Christoph Cullmann 
cullmann abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D4234

To: cullmann, #ktexteditor, mwolff, brauch, cactus
Cc: kde-frameworks-devel, nalvarez, mwolff, anthonyfieroni, dhaumann, brauch, 
cullmann, kwrite-devel, domson, michaelh, ngraham, bruns, demsking, sars

D21078: Avoid infinite loop in "Toggle Contained Nodes" action

2019-05-08 Thread loh tar 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:783647154a0e: Avoid infinite loop in "Toggle 
Contained Nodes" action (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21078?vs=57747&id=57772#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21078?vs=57747&id=57772

REVISION DETAIL
  https://phabricator.kde.org/D21078

AFFECTED FILES
  src/document/katebuffer.cpp
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

2019-05-08 Thread loh tar 
loh.tar added a comment.


  Well, I'm also not full convinced about the current way, but how else?
  
  The point is, you can now add as much sets as you like and rel. quickly 
change between your presets. I read you request so, that we have at the end 
only some hardcoded offers which the user can modify, but saved is only one 
setting. Not so user-friendly :-/
  
  When one setting always fit, why at all make it configurable?

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor, cullmann, mwolff, #vdg
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, dhaumann