D15934: Add battery and bluetooth icons for other DE compatibility

2019-05-10 Thread Noah Davis 
ndavis abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D15934

To: ndavis, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D21135: Allow to work with phone book and call history.

2019-05-10 Thread Stanislav Ageev 
sageev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sageev requested review of this revision.

REVISION SUMMARY
  This change allow to get contact and call history from phone.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21135

AFFECTED FILES
  src/CMakeLists.txt
  src/interfaces/org.bluez.obex.PhonebookAccess1.xml
  src/obexphonebookaccess.cpp
  src/obexphonebookaccess.h
  src/obexphonebookaccess_p.cpp
  src/obexphonebookaccess_p.h
  src/pendingcall.cpp
  src/pendingcall.h
  src/types.h

To: sageev
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21133: Fix KAr::openArchive with older Qt

2019-05-10 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D21133

To: aacid, apol, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » karchive » kf5-qt5 SUSEQt5.10 - Build # 43 - Fixed!

2019-05-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.10/43/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 10 May 2019 20:04:21 +
 Build duration:
2 min 4 sec and counting
   BUILD ARTIFACTS
  acc/KF5Archive-5.58.0.xmllogs/KF5Archive/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)80%
(28/35)80%
(28/35)78%
(4341/5531)54%
(1847/3430)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(1201/1208)52%
(544/1043)src88%
(22/25)88%
(22/25)77%
(3140/4053)58%
(1303/2229)tests0%
(0/4)0%
(0/4)0%
(0/270)0%
(0/158)

D21133: Fix KAr::openArchive with older Qt

2019-05-10 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.


  (if this was performance critical, the trimmed() shouldn't be done with 
recent Qt, but meh)

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21133

To: aacid, apol, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D21133: Fix KAr::openArchive with older Qt

2019-05-10 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21133

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21133: Fix KAr::openArchive with older Qt

2019-05-10 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  It seems older Qt don't like converting QByteArray("33  ").toInt()
  so call trimmed before calling toInt

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21133

AFFECTED FILES
  src/kar.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Allow compositors to send discrete axis values

2019-05-10 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 57883.
zzag added a comment.


  Small cleanup.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18933?vs=57882&id=57883

BRANCH
  pointer-axis-value-discrete

REVISION DETAIL
  https://phabricator.kde.org/D18933

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/server/pointer_interface.cpp
  src/server/pointer_interface.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Allow compositors to send discrete axis values

2019-05-10 Thread Vlad Zagorodniy 
zzag updated this revision to Diff 57882.
zzag added a comment.


  @since 5.XX becomes @since 5.59

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18933?vs=51659&id=57882

BRANCH
  pointer-axis-value-discrete

REVISION DETAIL
  https://phabricator.kde.org/D18933

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/server/pointer_interface.cpp
  src/server/pointer_interface.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D21127: [KDynamicJobTracker] Ask kuiserver asynchronously

2019-05-10 Thread David Faure 
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdynamicjobtracker.cpp:165
>  if (kuiserverTracker) {
>  kuiserverTracker->unregisterJob(job);
>  }

This would fail if the registerJob didn't happen yet.

Imagine a very short lived job (or a very slow kuiserver).

- register -> waiting for reply on requiresJobTracker
- unregister -> calling unregisterJob immediately, kuiserver will ignore it
- reply comes in, lambda calls registerJob

(note that the job is deleted with deleteLater, so the QPointer check doesn't 
help)

Result: the job stays up forever in kuiserver

Making things async means queueing requests, and having a sort of state 
machinne...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21127

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Allow compositors to send discrete axis values

2019-05-10 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  pointer-axis-value-discrete

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, mthw, kde-frameworks-devel, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

2019-05-10 Thread Kai Uwe Broulik 
broulik updated this revision to Diff 57864.
broulik added a comment.


  - When reply comes in after job already finished, call terminate on the 
jobview to end it gracefully

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21126?vs=57862&id=57864

REVISION DETAIL
  https://phabricator.kde.org/D21126

AFFECTED FILES
  src/kuiserverjobtracker.cpp
  src/kuiserverjobtracker.h

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

2019-05-10 Thread Kai Uwe Broulik 
broulik planned changes to this revision.
broulik added a comment.


  However now it obviously misses the first calls to set message and what not 
because the job view doesn't yet exist there...

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D21126

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21127: [KDynamicJobTracker] Ask kuiserver asynchronously

2019-05-10 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Frameworks, dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is only a fallback option so it shouldn't jeopardize the application by 
potentially blocking waiting for the server.

TEST PLAN
  Together with D21126  I can now use 
Dolphin fully without blocking when the server is frozen

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21127

AFFECTED FILES
  src/widgets/kdynamicjobtracker.cpp

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

2019-05-10 Thread Kai Uwe Broulik 
broulik edited the summary of this revision.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D21126

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21126: [KUiServerJobTracker] Register jobs asynchronously

2019-05-10 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Frameworks, dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Don't block waiting for the server to register the job, especially since it 
is typically only shown after 500ms anyway.

TEST PLAN
  Froze the server, app didn't block waiting in the register call anymore.
  Let the job finish and then unfroze the app, got a reply but it found the job 
already deleted and didn't do anything and didn't crash.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D21126

AFFECTED FILES
  src/kuiserverjobtracker.cpp
  src/kuiserverjobtracker.h

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21119: [JobDialog] Also signal cancellation when window is closed by the user

2019-05-10 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21119

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21119: [JobDialog] Also signal cancellation when window is closed by the user

2019-05-10 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This signal is emitted when the user tries to close the window manually, not 
when doing it programmatically.

TEST PLAN
  Asked it to share to kde connect, closed the window, got a cancellation 
signalled
  Asked it to share to kde connect, accepted task, task succeeded

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D21119

AFFECTED FILES
  src/widgets/JobDialog.qml

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21115: [KCModuleQML] Fix typo breaking implicitWidth for modules

2019-05-10 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  Now the notification KCM opens at a saner size
  The grid view kcms with a wider delegate than normal like colors now open at 
a pixel-perfect 3 columns now
  Previously the size was only determined by the buttons in the footer which at 
least for German locale with wide buttons made the dialog have a good looking 
size :)

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D21115

AFFECTED FILES
  src/kcmoduleqml.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20958: New menu of syntax highlighting in the status bar

2019-05-10 Thread Nibaldo González 
nibags updated this revision to Diff 57841.
nibags added a comment.


  - Fixes the menu alignment of the previous update

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20958?vs=57819&id=57841

BRANCH
  new-mode-menu

REVISION DETAIL
  https://phabricator.kde.org/D20958

AFFECTED FILES
  src/CMakeLists.txt
  src/mode/katemodemanager.cpp
  src/mode/katemodemenu.cpp
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/syntax/katehighlightmenu.cpp
  src/view/katestatusbar.cpp
  src/view/kateview.h

To: nibags, #ktexteditor, #kate, #vdg, ngraham, cullmann
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D20169: Add profile support interface for TerminalInterface

2019-05-10 Thread Maximilian Schiller 
mschiller added a comment.


  Ping

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

KDE CI: Frameworks » karchive » kf5-qt5 SUSEQt5.10 - Build # 42 - Unstable!

2019-05-10 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.10/42/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 10 May 2019 07:03:12 +
 Build duration:
2 min 37 sec and counting
   BUILD ARTIFACTS
  acc/KF5Archive-5.58.0.xmllogs/KF5Archive/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.karchivetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)83%
(29/35)83%
(29/35)78%
(4337/5531)54%
(1842/3430)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(1194/1208)52%
(539/1043)src92%
(23/25)92%
(23/25)78%
(3143/4053)58%
(1303/2229)tests0%
(0/4)0%
(0/4)0%
(0/270)0%
(0/158)

D21109: Fix KAr

2019-05-10 Thread Albert Astals Cid 
This revision was automatically updated to reflect the committed changes.
Closed by commit R243:79446284aec2: Fix KAr (authored by aacid).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21109?vs=57825&id=57838

REVISION DETAIL
  https://phabricator.kde.org/D21109

AFFECTED FILES
  .gitignore
  autotests/data/artest.a
  autotests/karchivetest.cpp
  autotests/karchivetest.h
  src/kar.cpp

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns