D21218: Create new icon for Knights based on Anjuta's icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:5a2dfb5804ba: Create new icon for Knights based on 
Anjuta's icon (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21218?vs=58105&id=58109#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21218?vs=58105&id=58109

REVISION DETAIL
  https://phabricator.kde.org/D21218

AFFECTED FILES
  icons/apps/48/knights.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Create new icon for Knights based on Anjuta's icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  anjuta-to-knights (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg, ndavis
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Create new icon for Knights based on Anjuta's icon

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  anjuta-to-knights (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg, ndavis
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Create new icon for Knights based on Anjuta's icon

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  anjuta-to-knights (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg, ndavis
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Create new icon for Knights based on Anjuta's icon

[Nathaniel Graham]

ngraham updated this revision to Diff 58105.
ngraham added a comment.


  Optimize with `scour`

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21218?vs=58096&id=58105

BRANCH
  anjuta-to-knights (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21218

AFFECTED FILES
  icons-dark/apps/48/knights.svg
  icons/apps/48/knights.svg

To: ngraham, #vdg, ndavis
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21219: Don't try to index SQL database dumps

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:60418cff50ad: Don't try to index SQL database dumps 
(authored by ngraham).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21219?vs=58097&id=58104

REVISION DETAIL
  https://phabricator.kde.org/D21219

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ngraham, #frameworks, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21218: Create new icon for Knights based on Anjuta's icon

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Once you've optimized the SVGs, I'll approve this.
  
  
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg, ndavis
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21219: Don't try to index SQL database dumps

[Matthieu Gallien]

mgallien accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  dont-try-to-index-database-dumps (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21219

To: ngraham, #frameworks, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21219: Don't try to index SQL database dumps

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  These contain no useful indexable data and can be huge, contributing to Baloo 
seeming
  to take forever to index and locking I/O. So don't try to index them.
  
  `src/file/fileexcludefilters.cpp` is not increased by one because it was 
already bumped
  in a prior commit this morning during this Frameworks cycle.

REPOSITORY
  R293 Baloo

BRANCH
  dont-try-to-index-database-dumps (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21219

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ngraham, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21218: Create new icon for Knights based on Anjuta's icon

[Nathaniel Graham]

ngraham retitled this revision from "Use Anjuta's icon for Knights, since it 
works and Anjuta is abandoned at this point" to "Create new icon for Knights 
based on Anjuta's icon".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

[Nathaniel Graham]

ngraham updated this revision to Diff 58096.
ngraham added a comment.


  New Knights icon based on Anjuta's

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21218?vs=58092&id=58096

BRANCH
  anjuta-to-knights (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21218

AFFECTED FILES
  icons-dark/apps/48/knights.svg
  icons/apps/48/knights.svg

To: ngraham, #vdg
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

[Maximilian Schiller]

mschiller updated this revision to Diff 58095.
mschiller added a comment.


  - Remove install of profileinterface

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=58094&id=58095

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/kde_terminal_interface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

[Maximilian Schiller]

mschiller updated this revision to Diff 58094.
mschiller added a comment.


  Move the interface to TerminalInterfaceV2

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20169?vs=56697&id=58094

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/CMakeLists.txt
  src/kde_terminal_interface.h

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

[Noah Davis]

ndavis added a comment.


  In D21218#465340 , @ognarb wrote:
  
  > Why not mirror the Anjuta icon and use the same background color as the 
original Knights icon? So that it looks closer to the original.
  
  
  I think this is probably better and might prevent confusion for existing 
Knights users.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg
Cc: ndavis, ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

[Carl Schwan]

ognarb added a comment.


  Why not mirror the Anjuta icon and use the same background color as the 
original Knights icon? So that it looks closer to the original.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg
Cc: ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Anjuta's icon depicts a knight-looking horse. However Anjuta is unmaintained 
and abandoned,
  the last release having been seven years ago. So let's use its icon for 
Knights, which
  needs one.
  
  CCBUG: 407527

REPOSITORY
  R266 Breeze Icons

BRANCH
  anjuta-to-knights (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21218

AFFECTED FILES
  icons-dark/apps/48/anjuta.svg
  icons-dark/apps/48/knights.svg
  icons/apps/48/anjuta.svg
  icons/apps/48/knights.svg

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21197: [KCoreDirLister] Remove assert in reinsert method

[Nathaniel Graham]

ngraham added reviewers: Frameworks, pino, elvisangelaccio, apol.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21197

To: chinmoyr, dfaure, #frameworks, pino, elvisangelaccio, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14464: Cancel privilege operation for read-only target with the current user as owner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Needs a rebase on master and the @since strings adjusted, but otherwise looks 
good to me.

INLINE COMMENTS

> global.h:248
>  ERR_PASSWD_SERVER = KJob::UserDefinedError + 72, ///< returned by 
> SlaveBase::openPasswordDialogV2, @since 5.24
> -ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73 ///< used by 
> Slave::createSlave, @since 5.30
> +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by 
> Slave::createSlave, @since 5.30
> +

5.59 now

> global.h:250
> +
> +ERR_PRIVILEGE_NOT_REQUIRED = KJob::UserDefinedError + 74 ///< used by 
> file ioslave, @since 5.50
>  };

5.59 now

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14464

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/105/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 14 May 2019 15:30:51 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13378)18%
(1823/9885)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/98/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 May 2019 15:29:47 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13378)18%
(1823/9885)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
  

D20983: Exclude .gcode and virtual machine files from indexing consideration

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:7f9ecb88253c: Exclude .gcode and virtual machine files 
from indexing consideration (authored by ngraham).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20983?vs=57824&id=58089

REVISION DETAIL
  https://phabricator.kde.org/D20983

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ngraham, bruns, #baloo
Cc: pino, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/104/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 14 May 2019 15:12:39 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13378)18%
(1822/9885)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 97 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/97/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 May 2019 15:12:39 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13378)18%
(1823/9885)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
  

Re: Deprecating KDEWebKit?

[Vlad Zagorodniy]

On 5/1/19 1:39 PM, Volker Krause wrote:

- Should we remove KDEWebKit from the default frameworks module set in kdesrc-
build, so that especially newcomers aren't confused by the common but harmless
build error caused by it? Applications actually needing it could still pull it
in via an explicit dependency.


+1

Cheers,
Vlad

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 108 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/108/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 14 May 2019 15:15:33 +
 Build duration:
3 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21155: Truncate long filname before creating a link

[David Faure]

dfaure added a comment.


  The first issue is solved by the use of NAME_MAX (the code doesn't actually 
hardcode 255), but indeed those are bytes, so this has to use 
QFile::encodeName() (to get to QByteArray), truncate, then QFile::decodeName() 
(to get back to QString). But what if this cuts in the middle of a utf-8 
sequence

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21155

To: chinmoyr, dfaure, ngraham
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 107 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/107/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 14 May 2019 15:12:39 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21172: FrameSvg: also clear mask cache on clearCache()

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f008615e3710: FrameSvg: also clear mask cache on 
clearCache() (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21172?vs=57960&id=58087

REVISION DETAIL
  https://phabricator.kde.org/D21172

AFFECTED FILES
  src/plasma/framesvg.cpp

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:6af447a84867: FrameSvgPrivate::generateBackground: 
generate background also if reqp != p (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21175?vs=57964&id=58085

REVISION DETAIL
  https://phabricator.kde.org/D21175

AFFECTED FILES
  src/plasma/framesvg.cpp

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8899389c9f67: FrameSvg: make hasElementPrefix() also 
handle prefix with trailing - (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21174?vs=58040&id=58086

REVISION DETAIL
  https://phabricator.kde.org/D21174

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/framesvg.h

To: kossebau, #plasma, mart
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21155: Truncate long filname before creating a link

[Stefan Brüns]

bruns added a comment.


  This has several issues:
  
  - 255 is only a typical value, it can be more or less, see 
https://en.wikipedia.org/wiki/Comparison_of_file_systems#Limits
- exFAT can store 255 UTF-16 characters
- eCryptFS can only use ~140 bytes (remainder is used for mangling/prefix)
  - for most FS on Linux, 255 is in **bytes**, not characters

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21155

To: chinmoyr, dfaure, ngraham
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D21175: FrameSvgPrivate::generateBackground: generate background also if reqp != p

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixgeneratebackground

REVISION DETAIL
  https://phabricator.kde.org/D21175

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21174: FrameSvg: make hasElementPrefix() also handle prefix with trailing -

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  makehaselementprefixmatchexpectation

REVISION DETAIL
  https://phabricator.kde.org/D21174

To: kossebau, #plasma, mart
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 103 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/103/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 14 May 2019 13:39:40 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3632/13374)18%
(1823/9883)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1418/3507)28%
(793/2829)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
 

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Nathaniel Graham]

ngraham added reviewers: bruns, Frameworks.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:168
>  
> +// strips last slash
> +if (mountpoint.at(mountpoint.length() -1) == '/') {

This is a litlle bit scarce ...

> apol wrote in fstabhandling.cpp:170
> you can call mountpoint.chop(2) for the same effect, which should be easier 
> to read.

and why "2"?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 102 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/102/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 14 May 2019 13:15:23 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3630/13374)18%
(1822/9883)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1418/3507)28%
(793/2829)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 106 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/106/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 14 May 2019 13:30:33 +
 Build duration:
7 min 50 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/96/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 May 2019 13:21:26 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3632/13374)18%
(1823/9883)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1418/3507)28%
(793/2829)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/105/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 14 May 2019 13:15:26 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/95/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 May 2019 13:15:26 +
 Build duration:
5 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3632/13374)18%
(1823/9883)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2274)6%
(92/1475)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1418/3507)28%
(793/2829)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 103 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/103/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 14 May 2019 12:25:41 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21200: FrameSvg: prevent crash when calling mask() with no frame yet created

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:193775def6a0: FrameSvg: prevent crash when calling mask() 
with no frame yet created (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21200?vs=58038&id=58075

REVISION DETAIL
  https://phabricator.kde.org/D21200

AFFECTED FILES
  src/plasma/framesvg.cpp

To: kossebau, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21201: FrameSvgItem: emit maskChanged also from geometryChanged()

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1bc1994dfe6b: FrameSvgItem: emit maskChanged also from 
geometryChanged() (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21201?vs=58039&id=58076

REVISION DETAIL
  https://phabricator.kde.org/D21201

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: kossebau, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/41/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 14 May 2019 12:14:13 +
 Build duration:
49 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D20595: Implement set_window_geometry

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:6da6c7c7e090: Implement set_window_geometry (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20595?vs=56357&id=58071#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20595?vs=56357&id=58071

REVISION DETAIL
  https://phabricator.kde.org/D20595

AFFECTED FILES
  autotests/client/test_xdg_shell_stable.cpp
  src/client/xdgshell.cpp
  src/client/xdgshell.h
  src/client/xdgshell_p.h
  src/client/xdgshell_stable.cpp
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_stable_interface.cpp

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/33/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 14 May 2019 12:14:14 +
 Build duration:
39 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.58.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSurface
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(239/262)91%
(239/262)82%
(25961/31585)51%
(10324/20259)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)93%
(11570/12439)47%
(6091/12925)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)84%
(6219/7410)64%
(1795/2806)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)85%
(7718/9079)64%
(2261/3537)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:169
> +// strips last slash
> +if (mountpoint.at(mountpoint.length() -1) == '/') {
> +mountpoint = mountpoint.left(mountpoint.length() - 2);

mountpoint.endsWith(QLatin1Char('/'))

> fstabhandling.cpp:170
> +if (mountpoint.at(mountpoint.length() -1) == '/') {
> +mountpoint = mountpoint.left(mountpoint.length() - 2);
> +}

you can call mountpoint.chop(2) for the same effect, which should be easier to 
read.

> fstabhandling.cpp:217
> +// strips last slash
> +if (mountpoint.at(mountpoint.length() -1) == '/') {
> +mountpoint = mountpoint.left(mountpoint.length() - 2);

Same as above.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21201: FrameSvgItem: emit maskChanged also from geometryChanged()

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  emitmaskchangedalsoonsizechange

REVISION DETAIL
  https://phabricator.kde.org/D21201

To: kossebau, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21200: FrameSvg: prevent crash when calling mask() with no frame yet created

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  donotcrashformask

REVISION DETAIL
  https://phabricator.kde.org/D21200

To: kossebau, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 37 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/37/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 14 May 2019 12:14:18 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.58.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/262)92%
(240/262)85%
(26958/31611)53%
(10810/20259)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12348/12441)50%
(6492/12925)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6308/7423)65%
(1815/2806)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)86%
(7848/9090)66%
(2326/3537)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D21155: Truncate long filname before creating a link

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:092beaf6fbab: Truncate long filname before creating a 
link (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21155?vs=57929&id=58069

REVISION DETAIL
  https://phabricator.kde.org/D21155

AFFECTED FILES
  src/core/copyjob.cpp

To: chinmoyr, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

[Kurt Hindenburg]

hindenburg added a comment.


  I would prefer using  TerminalInterfaceV2 in the current file instead of a 
new file. It would make using it much easier to use, document, etc and when kf6 
comes out, easier to re-combine.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein
Cc: dhaumann, pino, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20595

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

[David Edmundson]

davidedmundson added a comment.


  marking inline comments as done

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20595

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

[Méven Car]

meven abandoned this revision.
meven added a comment.


  Abandoned n favor of D21204 

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20301

To: meven, bruns, lukas, broulik
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Méven Car]

meven created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 406242
  CCBUG: 390691
  FIXED-IN: 5.59

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven
Cc: kde-frameworks-devel, michaelh, ngraham, bruns