D21401: Use native dialog overwrite check

2019-05-25 Thread Méven Car 
meven added a comment.


  In D21401#470121 , @ngraham wrote:
  
  > This will work fine for a KDE environment where we know that the file 
dialog correctly handles the overwrite use case. Do we know that the GTK file 
dialog does the same for when Kate is run on GNOME, XFCE, or MATE?
  
  
  I believe it will be fine. 
https://developer.gnome.org/gtk3/stable/GtkFileChooserDialog.html 
GtkFileChooserDialog has a `gtk_file_chooser_set_do_overwrite_confirmation` 
(since 2005's gtk 2.8) so I would expect QFileDialog to use this feature.
  So given GNOME, XFCE and MATE uses gtk >= 2.8, I don't foresee an issue on 
those DE.
  Also bug https://bugreports.qt.io/browse/QTBUG-11539 mentions it works under 
GNOME at least.
  
  On the QFileDialog side, I wish it would be better documented : 
https://doc.qt.io/archives/qt-4.8/qfiledialog.html#details mentioned GNOME and 
KDE but not anymore in qt5 stable documentation 
https://doc.qt.io/qt-5/qfiledialog.html#details

REPOSITORY
  R39 KTextEditor

BRANCH
  native-overwrite-check

REVISION DETAIL
  https://phabricator.kde.org/D21401

To: meven, ngraham, #frameworks, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D21412: Add action to reset font size

2019-05-25 Thread Kishore Gopalakrishnan 
kishoreg created this revision.
kishoreg added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kishoreg requested review of this revision.

REVISION SUMMARY
  Add an action to reset the font size to the default and set the default 
shortcut to Ctrl+0

TEST PLAN
  Zoom out the text. Press Ctrl+0 to zoom in.
  Do the same with the 'Reset font size' item in the 'View' menu.
  Try to reassign the keyboard shortcut in the shortcuts manager and check that 
it works.
  
  FEATURE: 407910

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21412

AFFECTED FILES
  src/data/katepart5ui.rc
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/view/kateview.cpp
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: kishoreg, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21401: Use native dialog overwrite check

2019-05-25 Thread Nathaniel Graham 
ngraham added a comment.


  This will work fine for a KDE environment where we know that the file dialog 
correctly handles the overwrite use case. Do we know that the GTK file dialog 
does the same for when Kate is run on GNOME, XFCE, or MATE?

REPOSITORY
  R39 KTextEditor

BRANCH
  native-overwrite-check

REVISION DETAIL
  https://phabricator.kde.org/D21401

To: meven, ngraham, #frameworks, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D21390: Test reading and seeking in KCompressionDevice

2019-05-25 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D21390

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21388: KCompressionDevice: Remove bIgnoreData

2019-05-25 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D21388

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21411: YAML: only comments after spaces and other improvements/fixes

2019-05-25 Thread Dominik Haumann 
dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-yaml

REVISION DETAIL
  https://phabricator.kde.org/D21411

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21410: Markdown: use includeAttrib in code blocks

2019-05-25 Thread Dominik Haumann 
dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  markdown-code

REVISION DETAIL
  https://phabricator.kde.org/D21410

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21411: YAML: only comments after spaces and other improvements/fixes

2019-05-25 Thread Nibaldo González 
nibags edited the summary of this revision.
nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21411

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21411: YAML: only comments after spaces and other improvements/fixes

2019-05-25 Thread Nibaldo González 
nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-yaml

REVISION DETAIL
  https://phabricator.kde.org/D21411

AFFECTED FILES
  autotests/folding/test.yaml.fold
  autotests/html/example.rmd.html
  autotests/html/test.yaml.html
  autotests/reference/example.rmd.ref
  autotests/reference/test.yaml.ref
  data/syntax/yaml.xml

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21410: Markdown: use includeAttrib in code blocks

2019-05-25 Thread Nibaldo González 
nibags edited the summary of this revision.
nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21410

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21410: Markdown: use includeAttrib in code blocks

2019-05-25 Thread Nibaldo González 
nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  markdown-code

REVISION DETAIL
  https://phabricator.kde.org/D21410

AFFECTED FILES
  autotests/html/test.markdown.html
  autotests/reference/test.markdown.ref
  data/syntax/markdown.xml

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21401: Use native dialog overwrite check

2019-05-25 Thread Christoph Cullmann 
cullmann added a comment.


  checkOverwrite decl. should be removed, too.

REPOSITORY
  R39 KTextEditor

BRANCH
  native-overwrite-check

REVISION DETAIL
  https://phabricator.kde.org/D21401

To: meven, ngraham, #frameworks, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D21401: Use native dialog overwrite check

2019-05-25 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Sounds reasonable.

REPOSITORY
  R39 KTextEditor

BRANCH
  native-overwrite-check

REVISION DETAIL
  https://phabricator.kde.org/D21401

To: meven, ngraham, #frameworks, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D21402: Avoid double overwrite check

2019-05-25 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, then lets do this.

REPOSITORY
  R40 Kate

BRANCH
  native-check

REVISION DETAIL
  https://phabricator.kde.org/D21402

To: meven, #kate, #frameworks, cullmann
Cc: apol, dhaumann, kwrite-devel, domson, michaelh, ngraham, demsking, 
cullmann, sars

D21204: Ensure no trailing slash in mountpoint read from fstab file.

2019-05-25 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> meven wrote in fstabhandling.cpp:142
> I am not familiar with those mounts.
> What is the udi of those mounted filesystem ?

for NFS the following entries are valid:

- 192.168.0.1:/some/dir
- 192.168.0.1:/some/dir/
- server:/other
- server:/

while `server:` (without slash) is invalid.

The first two entries are semantically the same

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: ngraham, bruns, apol, kde-frameworks-devel, michaelh

D21379: [UDev Backend] Narrow subsystems queried for cameras

2019-05-25 Thread Stefan Brüns 
bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Please also update the summary.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21402: Avoid double overwrite check

2019-05-25 Thread Aleix Pol Gonzalez 
apol added a comment.


  That should work on every platform. In fact, it would be a bug if any 
platform didn't do it.
  
  https://doc.qt.io/qt-5/qfiledialog.html#Option-enum
  See QFileDialog::DontConfirmOverwrite.

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D21402

To: meven, #kate, #frameworks, cullmann
Cc: apol, dhaumann, kwrite-devel, domson, michaelh, ngraham, demsking, 
cullmann, sars

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

2019-05-25 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1

REPOSITORY
  R300 KDEWebKit

REVISION DETAIL
  https://phabricator.kde.org/D21400

To: vkrause
Cc: apol, asturmlechner, kde-frameworks-devel, michaelh, ngraham, bruns

D21388: KCompressionDevice: Remove bIgnoreData

2019-05-25 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21388

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21390: Test reading and seeking in KCompressionDevice

2019-05-25 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21390

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21367: kioexec: change the scary debug messages for delayed deletion

2019-05-25 Thread Elvis Angelaccio 
elvisangelaccio added inline comments.

INLINE COMMENTS

> main.cpp:262
>  // it will have time to start up and read the file before it 
> gets deleted. #130709.
> -qDebug() << "sleeping...";
> -QThread::currentThread()->sleep(180); // 3 mn
> +const int sleep_secs = 180;
> +qDebug() << "sleeping for" << sleep_secs << "seconds before 
> deleting file...";

Please use camelCase

REVISION DETAIL
  https://phabricator.kde.org/D21367

To: Lekensteyn, elvisangelaccio, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21402: Avoid double overwrite check

2019-05-25 Thread Dominik Haumann 
dhaumann added a comment.


  Is this correct in all cases? Do we support KIO here? Does that depend on 
platform integration, i.e. gnome or Windows?

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D21402

To: meven, #kate, #frameworks, cullmann
Cc: dhaumann, kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars

D21401: Use native dialog overwrite check

2019-05-25 Thread Méven Car 
meven added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21401

To: meven, ngraham, #frameworks, #kate
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21402: Avoid double overwrite check

2019-05-25 Thread Méven Car 
meven created this revision.
meven added reviewers: Kate, Frameworks, cullmann.
Herald added a project: Kate.
Herald added a subscriber: kwrite-devel.
meven requested review of this revision.

REVISION SUMMARY
  QFileDialog has by default an overwrite check, avoid the second one done by 
kate.
  
  Related to D21401 

REPOSITORY
  R40 Kate

BRANCH
  native-check

REVISION DETAIL
  https://phabricator.kde.org/D21402

AFFECTED FILES
  kate/katesavemodifieddialog.cpp

To: meven, #kate, #frameworks, cullmann
Cc: kwrite-devel, domson, michaelh, ngraham, demsking, cullmann, sars, dhaumann

D21401: Use native dialog overwrite check

2019-05-25 Thread Méven Car 
meven created this revision.
meven added reviewers: ngraham, Frameworks, Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
meven requested review of this revision.

REVISION SUMMARY
  Past review https://git.reviewboard.kde.org/r/128452/ avoided double 
overwrite check by disabling the dialog one, it should have been the opposite, 
reusing QFileDialog.

REPOSITORY
  R39 KTextEditor

BRANCH
  native-overwrite-check

REVISION DETAIL
  https://phabricator.kde.org/D21401

AFFECTED FILES
  src/document/katedocument.cpp

To: meven, ngraham, #frameworks, #kate
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

2019-05-25 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  QtWebKit is dead, even the "revived" version has no changes since more
  than a year.

REPOSITORY
  R300 KDEWebKit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21400

AFFECTED FILES
  metainfo.yaml

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

2019-05-25 Thread Méven Car 
meven updated this revision to Diff 58642.
meven added a comment.


  Fix missing ')'

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58424&id=58642

BRANCH
  dolphin-view-modes

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12647: Move the inline preview button into the menu

2019-05-25 Thread Méven Car 
meven added a comment.


  In D12647#456283 , @meven wrote:
  
  > In D12647#434327 , @ngraham 
wrote:
  >
  > > I don't think this makes sense anymore.
  >
  >
  > "Put the Show Inline Preview button in the settings menu" is still in T8552 
, shouldn't we remove this there then ?
  
  
  @ngraham ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12647

To: ngraham, #frameworks
Cc: meven, kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D21367: kioexec: change the scary debug messages for delayed deletion

2019-05-25 Thread Peter Wu 
Lekensteyn updated this revision to Diff 58640.
Lekensteyn marked an inline comment as done.
Lekensteyn edited the test plan for this revision.
Lekensteyn added a comment.


  Addressed review comment by adding a constant for the interval. Changed 
minutes -> seconds in the debug message.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21367?vs=58549&id=58640

REVISION DETAIL
  https://phabricator.kde.org/D21367

AFFECTED FILES
  src/kioexec/main.cpp

To: Lekensteyn, elvisangelaccio, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21390: Test reading and seeking in KCompressionDevice

2019-05-25 Thread Albert Astals Cid 
aacid added a comment.


  The companion commit that fixes this test is 
https://phabricator.kde.org/D21388

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D21390

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21388: KCompressionDevice: Remove bIgnoreData

2019-05-25 Thread Albert Astals Cid 
aacid added a comment.


  test at https://phabricator.kde.org/D21390
  
  Made it in two separate bits so you can: 
   a) cherry-pick the test, run it, see it fails
   b) cherry-pick this fix on top, run test it, see it doesn't fail

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D21388

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21390: Test reading and seeking in KCompressionDevice

2019-05-25 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  This test fails without the patch to remove bIgnoreData from
  KCompressionDevice

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21390

AFFECTED FILES
  autotests/kcompressiondevicetest.cpp
  autotests/kcompressiondevicetest.h
  src/kcompressiondevice.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21390: Test reading and seeking in KCompressionDevice

2019-05-25 Thread Albert Astals Cid 
aacid updated this revision to Diff 58630.
aacid added a comment.


  forgot to add the _p.h file

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21390?vs=58629&id=58630

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21390

AFFECTED FILES
  autotests/kcompressiondevicetest.cpp
  autotests/kcompressiondevicetest.h
  src/kcompressiondevice.cpp
  src/kcompressiondevice_p.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21381: use org.freedesktop.appstream-glib package to validate appstream data

2019-05-25 Thread Matthieu Gallien 
mgallien added a comment.


  In D21381#469617 , @apol wrote:
  
  > How about we test against both?
  
  
  I have just pushed a new diff to do that.
  I am not sure if it desirable to keep appstreamcli test given it fails to 
validate files that are validated by flathub and appstream-utils (without 
flathub patches).
  
  > And maybe it should be using `appstream-util validate` instead of forcing 
it through flatpak? 
  >  It will make it easier to be able to run it in build.kde.org.
  
  I would like to also get an extra test to do that on setup where flatpak is 
available given that flathub uses a patched appstream-utils with relaxed 
validation constraints.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21381

To: mgallien, aacid, yurchor, apol
Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21381: use org.freedesktop.appstream-glib package to validate appstream data

2019-05-25 Thread Matthieu Gallien 
mgallien updated this revision to Diff 58628.
mgallien added a comment.


  - use appstream-util and appstreamcli to validate appdata file

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21381?vs=58595&id=58628

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21381

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: mgallien, aacid, yurchor, apol
Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

2019-05-25 Thread Laurent Montel 
mlaurent added a comment.


  LOGGINGCATEGORIESDIR indeed it's more specific +1 for me
  debug-categories5 => indeed it's just using by kdebugsettings at the moment. 
=> kdebugsettings-categories5 ? 
  no idea if it's better.
  
  @dfaure do you have an idea ?:)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns