D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58746.
mlaurent added a comment.


  Change as qlogging-categories5

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58604&id=58746

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent added a comment.


  Thanks david.
  Indeed qlogging-categories5 seems a good name :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21421: Tcsh: fix operators and keywords

[Christoph Cullmann]

cullmann added a comment.


  Actually the resource should be recreated on syntax file changes and be used.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21421

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> bruns wrote in fstabdevice.cpp:88
> @hallas:
> cat /proc/mounts

This is what I have in mounts:

  fuseiso on /home/dha/mnt1 type fuse.fuseiso 
(rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)

so there just isn't a whole lot of information - we don't even have the iso 
filename :/

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

[Kai Uwe Broulik]

broulik added a comment.


  However in `queryDeviceInterface` we actually check for it being `"1"`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21425

To: broulik, #frameworks, davidedmundson, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21421: Tcsh: fix operators and keywords

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored 
by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21421?vs=58696&id=58742

REVISION DETAIL
  https://phabricator.kde.org/D21421

AFFECTED FILES
  autotests/folding/highlight.tcsh.fold
  autotests/html/highlight.tcsh.html
  autotests/input/highlight.tcsh
  autotests/reference/highlight.tcsh.ref
  data/syntax/tcsh.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D21313: Create specific directory for kdebugsettings categories file

[David Faure]

dfaure added a comment.


  My suggestion is to call this qlogging-categories5.
  
  The 'q' prefix is missing to make this qt-specific rather than cross-toolkit.
  The "logging" instead of "debug" is because this affects all types of 
messages, and this is all about what's called "logging categories" in Qt.
  The "5" will allow co-installation of the qt5 and qt6 versions of the same 
library (but it will require two versions of kdebugsettings, or that 
kdebugsettings looks in both places -- but that can be done later).
  
  I wouldn't name it after the application using this, because well, it could 
change name, and there could be more apps using this (e.g. akonadiconsole, 
kdevelop...).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21421: Tcsh: fix operators and keywords

[jonathan poelen]

jpoelen added a comment.


  I forgot to ask about running the tests. Is it normal that system syntax 
files take precedence if we have an `index.katesyntax`? Currently I have to run 
the tests by setting the environment variable `XDG_DATA_DIRS`.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_tcsh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21421

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D21367: kioexec: change the scary debug messages for delayed deletion

[Elvis Angelaccio]

elvisangelaccio accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21367

To: Lekensteyn, elvisangelaccio, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21235: Add handling of fuseiso filesystem type

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in fstabdevice.cpp:88
> Hmm, hard to tell without some context or knowing what the original string is.

@hallas:
cat /proc/mounts

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

[Stefan Brüns]

bruns added a comment.


  I think just checking for the property existance is correct:
  
  > /usr/lib/udev/rules.d/40-usb-media-players.rules
  > 
  >> ATTRS{vendor}=="*Apple*", ATTRS{model}=="*iPod*", 
ENV{ID_MEDIA_PLAYER}="apple_ipod"
  >>  ATTRS{model}=="*[iI][tT][uU][nN][eE][sS]*", ATTRS{idVendor}=="22b8", 
ATTRS{idProduct}=="4810", ENV{ID_MEDIA_PLAYER}="motorola_itunes-phone"
  >>  ATTRS{model}=="*Motorola Phone (V3i)*", ATTRS{idVendor}=="22b8", 
ATTRS{idProduct}=="4810", ENV{ID_MEDIA_PLAYER}="motorola_v3i"
  >> 
  >> 1. Series 60 phones ATTRS{model}=="S60", ATTRS{idVendor}=="0421", 
ATTRS{idProduct}=="*", ENV{ID_MEDIA_PLAYER}="nokia_series-60-phones" 
ATTRS{product}=="Rockbox media player", ATTRS{manufacturer}=="Rockbox.org", 
ENV{ID_MEDIA_PLAYER}="rockbox" ATTRS{vendor}=="[sS][oO][nN][yY]*", 
ATTRS{model}=="*PSP*", ENV{ID_MEDIA_PLAYER}="sony_psp"
  
  
  
  > /usr/lib/udev/rules.d/70-uaccess.rules
  > 
  >> SUBSYSTEM=="usb", ENV{ID_MEDIA_PLAYER}=="?*", TAG+="uaccess"
  
  Maybe we should do the same for ID_GPHOTO2:
  
  > /usr/lib/udev/rules.d/70-uaccess.rules
  > 
  >> ENV{ID_GPHOTO2}=="?*", TAG+="uaccess"

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21425

To: broulik, #frameworks, davidedmundson, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> hallas wrote in fstabdevice.cpp:88
> Certainly :D I am also struggling a bit with how to best describe these FUSE 
> mounted devices, @ngraham do you have any good suggestions?

Hmm, hard to tell without some context or knowing what the original string is.

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19677: WIP: Port UDisks to using DBus ObjectManager

[Stefan Brüns]

bruns added a comment.


  The UDisksDeviceBackend class serves two functions:
  
  - shared data cache for UDisksDevice instances
  - static factory of instances
  
  The manager has everything it needs to function as a factory. The  
UDisksDeviceBackend would become a representation of the individual UDisks 
Objects, and would store the interfaces and associated properties. The manager 
does no store interfaces or properties directly, but only objects, i.e. 
`QMap m_cache;  m_cache[udi] = new 
UDisksDeviceBackend(interfaces_and_properties);
  
  The manager would also act as a dispatcher, demarshaling the DBus messages, 
and then e.g. calling on propertiesChanged 
`m_cache[udi]->propertiesChanged(QStringList invalidated, QVariantMap changed)`
  
  As the backend is a shared instance I don't think it can be merged with the 
device.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D19677

To: broulik, #frameworks, bruns
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D19677: WIP: Port UDisks to using DBus ObjectManager

[Kai Uwe Broulik]

broulik added a comment.


  You mean I kill that entire `DeviceBackend` wrapper and have `Device` do all 
the things with all the data stored in the `DeviceManager`?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D19677

To: broulik, #frameworks, bruns
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 121 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/121/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 27 May 2019 14:06:54 +
 Build duration:
7 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21317: Manipulate bytes instead of characters

[Chinmoy Ranjan Pradhan]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8e00726eda1f: Manipulate bytes instead of characters 
(authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21317?vs=58406&id=58725

REVISION DETAIL
  https://phabricator.kde.org/D21317

AFFECTED FILES
  src/core/copyjob.cpp

To: chinmoyr, bruns, dfaure, thiago
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21427: Always skip trailing slashes in FilderedDirIterator

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21427

To: poboiko, #frameworks, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21427: Always skip trailing slashes in FilderedDirIterator

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21427

To: poboiko, #frameworks, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21427: Always skip trailing slashes in FilderedDirIterator

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Frameworks, Baloo, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  I've encountered weird regression. Here is the description:
  
  1. Since some time, `config->includeFolders()` contains folders with trailing 
slashes.
  2. First entry that `QDirIterator::path()` returns matches exactly its 
argument, i.e. if we feed it with path with trailing slash,
  
  it will return exactly it. All the other paths don't have trailing slashes 
though.
  
  3. Because of that, inside `UnindexedFileIndexer::run()`, when we check 
whether path has changed, we perform comparison `it.filePath() == 
tr.documentUrl(id)`,
  
  and it fails becaue `documentUrl()` always returns path without trailing 
slash.
  
  4. So we call `DocumentUrlDB::replace()`, which removes old entry and calls 
`DocumentUrlDB::put()`.
  5. Finally, for some reason, `IdTreeDB` don't want to work with paths with 
trailing slashes.
  
  So in the end of the day we get entry for `includeFolder` removed from DB. 
Which corrupts `IdTreeDB` --- it can no longer resolve paths.
  The simplest solution proposed here is to make sure our `DirIterator` always 
returns paths without trailing slash, including first call.

TEST PLAN
  It compiles. As far as I can see, it also fixes the regression.
  Although, for some reason, this regression it's not always reproducible, so I 
cannot be completely sure. Would appreciate if someone else looked into it.

REPOSITORY
  R293 Baloo

BRANCH
  trailingSlash

REVISION DETAIL
  https://phabricator.kde.org/D21427

AFFECTED FILES
  src/file/filtereddiriterator.cpp

To: poboiko, #frameworks, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Kai Uwe Broulik]

broulik added a dependent revision: D21425: [UDev Backend] Filter for 
ID_MEDIA_PLAYER already when querying.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This avoids us creating wrapper objects for UDev devices we end up not being 
interested in.
  
  According to `match_property` [1] which filters the properties added by 
`sd_device_enumerator_add_match_property` which 
`udev_enumerate_add_match_property` ends up calling, a `value` of `NULL` can be 
used to check for mere existance of a property.
  
  [1] 
https://github.com/systemd/systemd/blob/master/src/libsystemd/sd-device/device-enumerator.c#L400

TEST PLAN
  Depends on D21379 
  
  I recall having done a patch like this before and ran into trouble but my 
phone shows up just fine both on startup and when plugging it in later. I think 
the check for `1` vs `"1"` being the culprit here, so just check for property 
existance which filters out most of the useless devices already.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21425

AFFECTED FILES
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> ltoscano wrote in renamefiledialog.h:5
> We do, but people sign it on a vuluntary basis:
> 
> https://ev.kde.org/rules/fla.php
> 
> Also, there is this which pre-dates the FLA but it is useful too (and still 
> in use):
> 
> https://cgit.kde.org/kde-dev-scripts.git/tree/relicensecheck.pl

Interesting it happens that Peter Penz is present in the old_license_table :

  ppenz' => ['gplv23', 'lgplv23', 'gplv2+', 'lgplv2+' ],

Which if I understand correctly means Peter Penz has allowed to move his gpl2+ 
contributions to some lgpl2+.

Hence it seems to me this code move and needed re-licensing can proceed.

I would appreciate some second opinion though, I am no FLA specialist.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: ngraham, #frameworks, #dolphin, broulik
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, michaelh, 
ngraham

D21367: kioexec: change the scary debug messages for delayed deletion

[Peter Wu]

Lekensteyn updated this revision to Diff 58714.
Lekensteyn set the repository for this revision to R241 KIO.
Lekensteyn added a comment.


  Using camelCase now.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21367?vs=58640&id=58714

REVISION DETAIL
  https://phabricator.kde.org/D21367

AFFECTED FILES
  src/kioexec/main.cpp

To: Lekensteyn, elvisangelaccio, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21401: Use native dialog overwrite check

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:fb2ea92822d2: Use native dialog overwrite check (authored 
by meven).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21401?vs=58708&id=58710

REVISION DETAIL
  https://phabricator.kde.org/D21401

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h

To: meven, ngraham, #frameworks, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D21402: Avoid double overwrite check

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R40:09053597e699: Avoid double overwrite check (authored by 
meven).

REPOSITORY
  R40 Kate

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21402?vs=58647&id=58709

REVISION DETAIL
  https://phabricator.kde.org/D21402

AFFECTED FILES
  kate/katesavemodifieddialog.cpp

To: meven, #kate, #frameworks, cullmann
Cc: apol, dhaumann, kwrite-devel, domson, michaelh, ngraham, demsking, 
cullmann, sars

D21401: Use native dialog overwrite check

[Méven Car]

meven added a comment.


  Good part is that the overwrite check dialog will now be a native one analog 
to other apps instead of a KMessageBox, providing consistency outside of KDE.

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D21401

REVISION DETAIL
  https://phabricator.kde.org/D21401

To: meven, ngraham, #frameworks, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D21401: Use native dialog overwrite check

[Méven Car]

meven updated this revision to Diff 58708.
meven added a comment.


  Remove decl of removed function checkOverwrite

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21401?vs=58646&id=58708

BRANCH
  arcpatch-D21401

REVISION DETAIL
  https://phabricator.kde.org/D21401

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h

To: meven, ngraham, #frameworks, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Kai Uwe Broulik]

broulik updated this revision to Diff 58706.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Limit to `usb` subsystem only
  - Add docs

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21379?vs=58584&id=58706

REVISION DETAIL
  https://phabricator.kde.org/D21379

AFFECTED FILES
  src/solid/devices/backends/shared/udevqtclient.cpp
  src/solid/devices/backends/shared/udevqtclient.h
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21418: KCompressionDevice::seek: Fix previous fix ^_^

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D21418

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 114 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/114/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 27 May 2019 07:04:06 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 111 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/111/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 27 May 2019 07:04:05 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13384)18%
(1822/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 104 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/104/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 27 May 2019 07:04:06 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13384)18%
(1823/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

D21419: Export SortFilterModel sort column to QML

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:39d1db6e49da: Export SortFilterModel sort column to QML 
(authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21419?vs=58691&id=58702

REVISION DETAIL
  https://phabricator.kde.org/D21419

AFFECTED FILES
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h

To: davidedmundson, #plasma, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns