D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> bruns wrote in fstabdevice.cpp:88
> By default fuseiso seems to maintain also a file "~/.mtab.fuseiso", there may 
> be more information

Yes it does :D After mounting an iso I have the following contents:

  /home/dha/test.iso /home/dha/mnt1 fuseiso defaults 0 0

So at least we should be able to dig out the iso filename.

So could a better description be something like:

  test.iso on /home/dha/mnt1

or

  test.iso (/home/dha/mnt1)

or maybe some mention that this is a fuseiso mount, i.e.

  test.iso fuseiso mounted on /home/dha/mnt1

I don't know if that becomes way too long

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21411: YAML: only comments after spaces and other improvements/fixes

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21411

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[David Faure]

dfaure added a comment.


  Writing into the user's home dir is a "hack".
  
  There are better ways for distros to set defaults (such as the global 
mimeapps.list) but it seems KIO ignores that... (to be checked...)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  I don't think it's a "distro hack" to set a default browser, which is why 
they all do it. Not having a default browser set seems like an error condition 
to me. However I see what you meanabout the bugginess and will work on it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I agree that we shouldn't remove the underlying feature, in fact it's still 
used on other protocols than http.
  
  But we have to ensure the default behaviour matches the KCM and vice-versa, 
for http.

INLINE COMMENTS

> componentchooserbrowser.cpp:68
> +if (browserCombo->count() > 0) {
> +const QString &storageId = 
> browserCombo->currentData().toString();
> +m_browserService = KService::serviceByStorageId(storageId);

This will lead to rather confusing user experience, btw.

On a freshly installed system [without distro hacks], BrowserApplication is 
empty.
In practice that means KRun::setEnableExternalBrowser will pick the entry 
x-scheme-handler/https in the user's mimeapps.list, if any. And if that isn't 
set either, then well, the current behaviour in KRun, AFAICS, *will* be to use 
KIO to find out the mimetype.

Then the user opens this KCM, and it says "your default browser is firefox" (or 
whichever is first in the list). "What?" says the user... "that's not what I'm 
experiencing..."

If you want to change the default behaviour, you need to actually change the 
default behaviour (in KRun), not just what the KCM shows by default.

The default behaviour of KRun and the default settings shown by this KCM have 
to match.

This investigation shows that this is already buggy before this patch (the 
fallback to x-scheme-handler/https in the user's mimeapps.list is missing 
here), but this patch makes it much worse, as is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D21265: Add Bluez API to DBus XML parser/generator

[Manuel Weichselbaumer]

This revision was automatically updated to reflect the committed changes.
Closed by commit R269:bfe94dface00: Add Bluez API to DBus XML parser/generator 
(authored by mweichselbaumer).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21265?vs=58867&id=58963

REVISION DETAIL
  https://phabricator.kde.org/D21265

AFFECTED FILES
  CMakeLists.txt
  tools/bluezapi2qt/BluezApiParser.cpp
  tools/bluezapi2qt/BluezApiParser.h
  tools/bluezapi2qt/CMakeLists.txt
  tools/bluezapi2qt/Comment.cpp
  tools/bluezapi2qt/Comment.h
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/CppGenerator.h
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Interface.h
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Method.h
  tools/bluezapi2qt/Methods.cpp
  tools/bluezapi2qt/Methods.h
  tools/bluezapi2qt/Parameter.cpp
  tools/bluezapi2qt/Parameter.h
  tools/bluezapi2qt/Properties.cpp
  tools/bluezapi2qt/Properties.h
  tools/bluezapi2qt/Property.cpp
  tools/bluezapi2qt/Property.h
  tools/bluezapi2qt/TODO
  tools/bluezapi2qt/TypeAnnotation.cpp
  tools/bluezapi2qt/TypeAnnotation.h
  tools/bluezapi2qt/XmlGenerator.cpp
  tools/bluezapi2qt/XmlGenerator.h
  tools/bluezapi2qt/main.cpp

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

[Nathaniel Graham]

ngraham added reviewers: Frameworks, dfaure.
ngraham added a comment.


  I'm still not sure whether the feature needs to be removed entirely. I feel 
that this minimal patch probably stands on its own well enough as-is.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: GB_2, dfaure, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D21313: Create specific directory for Qt logging categories file

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:0c95c9f799cd: Create specific directory for Qt logging 
categories file (authored by mlaurent).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58952&id=58953

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for Qt logging categories file

[Laurent Montel]

mlaurent retitled this revision from "Create specific directory for 
kdebugsettings categories file" to "Create specific directory for Qt logging 
categories file".

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Laurent Montel]

mlaurent updated this revision to Diff 58952.
mlaurent added a comment.


  Fix typo

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21313?vs=58746&id=58952

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21511: Make falkon icon a real SVG

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:ac701bd091cf: Make falkon icon a real SVG (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21511?vs=58944&id=58948

REVISION DETAIL
  https://phabricator.kde.org/D21511

AFFECTED FILES
  icons-dark/apps/48/falkon.svg
  icons/apps/48/falkon.svg

To: ndavis, #vdg, #falkon, abetts, drosca
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21511: Make falkon icon a real SVG

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

BRANCH
  falkon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21511

To: ndavis, #vdg, #falkon, abetts, drosca
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21511: Make falkon icon a real SVG

[David Rosca]

drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  falkon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21511

To: ndavis, #vdg, #falkon, abetts, drosca
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21511: Make falkon icon a real SVG

[Nathaniel Graham]

ngraham added a comment.


  LGTM

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21511

To: ndavis, #vdg, #falkon, abetts
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21511: Make falkon icon a real SVG

[Nathaniel Graham]

ngraham added a reviewer: abetts.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21511

To: ndavis, #vdg, #falkon, abetts
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21511: Make falkon icon a real SVG

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21511

To: ndavis, #vdg, #falkon
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21511: Make falkon icon a real SVG

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Falkon.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  A falkon icon was recently commited to Breeze that was simply a PNG inside of 
an SVG. This patch uses actual vector graphics and adds a 45 degree shadow 
under the bird to make it more Breeze-like.

REPOSITORY
  R266 Breeze Icons

BRANCH
  falkon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21511

AFFECTED FILES
  icons-dark/apps/48/falkon.svg
  icons/apps/48/falkon.svg

To: ndavis, #vdg, #falkon
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21411: YAML: only comments after spaces and other improvements/fixes

[Nibaldo González]

nibags added a comment.


  > Could one adapt the theme and remove the color later?
  
  Yes, it would be ideal, so there is consistency among all the themes

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-yaml

REVISION DETAIL
  https://phabricator.kde.org/D21411

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21411: YAML: only comments after spaces and other improvements/fixes

[Christoph Cullmann]

cullmann added a comment.


  Hmm,  ok, anyways, this change looks ok =)
  Could one adapt the theme and remove the color later?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-yaml

REVISION DETAIL
  https://phabricator.kde.org/D21411

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21411: YAML: only comments after spaces and other improvements/fixes

[Nibaldo González]

nibags added a comment.


  > Btw., would it be possible to remove the hardcoded color here: 
  
  That I added it in a previous commit; use hard background color to mark 
indentation with Tabs in some situations (specifically, in the indentation 
capture with dynamic rules), since YAML uses indentation with spaces. And in 
Solarized schemes, `dsAlert` has no background color.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-yaml

REVISION DETAIL
  https://phabricator.kde.org/D21411

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21411: YAML: only comments after spaces and other improvements/fixes

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  Screenshots look better!
  
  Btw., would it be possible to remove the hardcoded color here: 

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-yaml

REVISION DETAIL
  https://phabricator.kde.org/D21411

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21508: Jam: various improvements and fixes

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  (the hard coded color was already there, therefore this doesn't block this 
request)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_jam (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21508

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21508: Jam: various improvements and fixes

[Christoph Cullmann]

cullmann added a comment.


  Looks reasonable + test case, nice.
  Btw., would it be possible to remove the last remaining hard coded color 
 here, too?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21508

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21411: YAML: only comments after spaces and other improvements/fixes

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-yaml

REVISION DETAIL
  https://phabricator.kde.org/D21411

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D21411: YAML: only comments after spaces and other improvements/fixes

[Nibaldo González]

nibags updated this revision to Diff 58936.
nibags added a comment.


  - Some fixes in attributes and update test file

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21411?vs=58663&id=58936

BRANCH
  improve-yaml

REVISION DETAIL
  https://phabricator.kde.org/D21411

AFFECTED FILES
  autotests/folding/test.yaml.fold
  autotests/html/example.rmd.html
  autotests/html/test.yaml.html
  autotests/input/test.yaml
  autotests/reference/example.rmd.ref
  autotests/reference/test.yaml.ref
  data/syntax/yaml.xml

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/36/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 31 May 2019 10:48:15 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D21379: [UDev Backend] Narrow device queried for

[Kai Uwe Broulik]

broulik added a comment.


  For some reason here my `udev_enumerate_add_match_property("ID_MEDIA_PLAYER", 
null)` doesn't work. If I check for "1" it works but `null` doesn't find any 
devices. Since the systemd code uses `fnmatch`, we can probably just pass `*` 
to it to match anything.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

[Kai Uwe Broulik]

broulik reopened this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  I just reverted it as it indeed causes problems with initial device lookup. 
Not just in plasmashell but also in Dolphin. Since Frameworks tagging is 
tomrrow, better leave it for now and investigate thorougly next week :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Frameworks, Baloo, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.

REVISION SUMMARY
  If some folder was renamed while `baloo_file` was not running, it should pop 
up in `UnIndexedFileIterator`.
  However, it does not, because previously it was thought that folder should 
never be reindexed.
  It is not correct: it should be reindexed if its name was changed.
  As a consequence, we end up with invalid entries inside DB (DocumentUrl is 
invalid).
  
  Also, added unit test for `UnIndexedFileIterator`, which covers basic cases 
(including this one).
  Right now it fails due to D21427: Always skip trailing slashes in 
FilderedDirIterator  (one of the folders 
has trailing slash, while it should not)
  
  Also, since we need to check if name was changed already inside iterator, we 
can export this information
  and reuse it from `UnindexedFileIndexer`.

TEST PLAN
  1. Apply also patch from D21427: Always skip trailing slashes in 
FilderedDirIterator .
  2. ctest

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21509

AFFECTED FILES
  autotests/unit/file/unindexedfileiteratortest.cpp
  src/file/unindexedfileindexer.cpp
  src/file/unindexedfileiterator.cpp
  src/file/unindexedfileiterator.h

To: poboiko, #frameworks, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21313: Create specific directory for kdebugsettings categories file

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Maybe also update the commit message to 'Create specific directory for Qt 
logging categories file'

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> KDEInstallDirs.cmake:132
> +# ``LOGGINGCATEGORIESDIR``
> +# qt logging categories files directory 
> (``DATAROOTDIR/qlogging-categories5``) Since 5.59.0
>  #

nitpick: s/qt/Qt/

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  add_specific_kdebugsetting_directory

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, 
ngraham, bruns