D21586: Add syntax definition for ninja build

[jonathan poelen]

jpoelen updated this revision to Diff 59240.
jpoelen added a comment.


  I am confused, the generation of index.katesyntax fails because the list 
"variables" does not exist (there is no variable predefined in this context). 
We may be in a situation where a change of branch does not recompile the index 
file :/.
  
  I'll have to be more careful next time.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21586?vs=59154=59240

BRANCH
  ninja (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21586

AFFECTED FILES
  autotests/folding/build.ninja.fold
  autotests/html/build.ninja.html
  autotests/input/build.ninja
  autotests/reference/build.ninja.ref
  data/syntax/ninja.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21613: Format focal length as milli meter

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> propertyinfotest.cpp:144
>  { Property::AspectRatio,true,  1.8, 
> QStringLiteral("1.78:1")},
> +{ Property::PhotoFocalLength,   true,  2.0, 
> QStringLiteral("2 mm")},
>  };

For small frame cameras (compact cameras, smartphones, ...) the real focal 
length is often in the range of only a few millimeters, please add a test case 
which checks e.g. "2.4 mm" is formatted as such.

REPOSITORY
  R286 KFileMetaData

BRANCH
  focal_length

REVISION DETAIL
  https://phabricator.kde.org/D21613

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21584: Add LE Advertising and GATT APIs

[Manuel Weichselbaumer]

mweichselbaumer updated this revision to Diff 59238.
mweichselbaumer added a comment.


  Fixed according to comments

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59237=59238

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/gattmanagertest.cpp
  src/CMakeLists.txt
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  tests/leserver.cpp

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

[Manuel Weichselbaumer]

mweichselbaumer updated this revision to Diff 59237.
mweichselbaumer added a comment.


  Fixed according to comments

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59236=59237

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/gattmanagertest.cpp
  src/CMakeLists.txt
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  tests/leserver.cpp

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

[Manuel Weichselbaumer]

mweichselbaumer updated this revision to Diff 59236.
mweichselbaumer marked an inline comment as done.
mweichselbaumer added a comment.


  Fixed according to comments

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59151=59236

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  CMakeLists.txt
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/gattmanagertest.cpp
  src/CMakeLists.txt
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  tests/leserver.cpp

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21613: Format focal length as milli meter

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  focal_length

REVISION DETAIL
  https://phabricator.kde.org/D21613

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Alexander Stippich]

astippich added a comment.


  @bruns okay for you to merge this one?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, LeGast00n, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time as rational when applicable

[Alexander Stippich]

astippich updated this revision to Diff 59224.
astippich added a comment.


  - rename format function

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21533?vs=59222=59224

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time as rational when applicable

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:167
> For a chart of typical exposure times, see 
> https://www.borrowlenses.com/blog/shutter-speed-chart/
> 
> I can confirm for my Canon SLR there is at one more value which would give a 
> deviating result, 0.3 seconds (!= 1/3s). 0.25 seconds is shown as 1/4s.

Computation now also falls back to decimal representation if it cannot be 
represented with a 1/x rational

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time as rational when applicable

[Alexander Stippich]

astippich retitled this revision from "Format photo exposure time and bias as 
rational" to "Format photo exposure time as rational when applicable".
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21613: Format focal length as milli meter

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  focal_length

REVISION DETAIL
  https://phabricator.kde.org/D21613

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich updated this revision to Diff 59222.
astippich added a comment.


  - add unit

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21533?vs=59221=59222

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:167
> For a chart of typical exposure times, see 
> https://www.borrowlenses.com/blog/shutter-speed-chart/
> 
> I can confirm for my Canon SLR there is at one more value which would give a 
> deviating result, 0.3 seconds (!= 1/3s). 0.25 seconds is shown as 1/4s.

Thanks for the information. From what I've read, for the exposure time the 
right threshold is 0.3, and the value is always a rational of 1/x.
The story seems to be different for the bias, though, so I've excluded it here.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21533

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21533: Format photo exposure time and bias as rational

[Alexander Stippich]

astippich updated this revision to Diff 59221.
astippich added a comment.


  - only format exposure time

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21533?vs=59028=59221

BRANCH
  photo_time

REVISION DETAIL
  https://phabricator.kde.org/D21533

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/99/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 05 Jun 2019 19:34:25 +
 Build duration:
7 min 27 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.59.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3683/4336)48%
(5117/10719)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1280/1310)49%
(2556/5237)src79%
(23/29)79%
(23/29)79%
(1230/1552)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/93/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 05 Jun 2019 19:34:26 +
 Build duration:
5 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.59.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3683/4336)48%
(5117/10719)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1280/1310)49%
(2556/5237)src79%
(23/29)79%
(23/29)79%
(1230/1552)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D21519: Rename ImageMake and ImageModel properties

[Alexander Stippich]

astippich added a comment.


  @ngraham what's your take regarding "Manufacturer" vs. "Equipment 
Manufacturer"?

REPOSITORY
  R286 KFileMetaData

BRANCH
  euqipment_properties

REVISION DETAIL
  https://phabricator.kde.org/D21519

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21532: Format the aperture values as F numbers.

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:553f96769610: Format the aperture values as F numbers. 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21532?vs=59029=59218

REVISION DETAIL
  https://phabricator.kde.org/D21532

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21607: Don't delay emission of matchesChanged indefinitely

[Fabian Vogt]

fvogt added a comment.


  In D21607#474771 , @fvogt wrote:
  
  > I'm thinking about doing it completely differently now though, with a 0 
latency case (untested):
  >
  >   if(lastMatchChangeSignalled.hasExpired(250)) {
  >   matchChangeTimer.stop();
  >   emit q->matchesChanged(context.matches());
  >   } else {
  >   matchChangeTimer.start(250 - lastMatchChangeSignalled.elapsed());
  >   }
  >
  
  
  Just tried this and it's not too bad, but a noticable change in behaviour. As 
results are shown basically immediately once they're available, it's now 
visible how the entries are filled.
  
  So for the stable branches I'd like to keep the current version of the diff 
with a latency of [100,599] while for master something like the above with a 
latency of [0,500] can be tried.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21607

To: fvogt, #frameworks, broulik
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21607: Don't delay emission of matchesChanged indefinitely

[Fabian Vogt]

fvogt added a comment.


  In D21607#474763 , @bruns wrote:
  
  > This would emit the signal more often, but wouldn't
  >
  >   if (!matchChangeTimer.isActive())
  > matchChangeTimer.start(100)
  >
  >
  > achieve essentially the same?
  
  
  That would do it even more often.
  
  I'm thinking about doing it completely differently now though, with a 0 
latency case (untested):
  
if(lastMatchChangeSignalled.hasExpired(100)) {
matchChangeTimer.stop();
emit q->matchesChanged(context.matches());
} else {
matchChangeTimer.start(100 - lastMatchChangeSignalled.expired());
}
  
  What do you think?

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21607

To: fvogt, #frameworks, broulik
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21607: Don't delay emission of matchesChanged indefinitely

[Stefan Brüns]

bruns added a comment.


  This would emit the signal more often, but wouldn't
  
if (!matchChangeTimer.isActive())
  matchChangeTimer.start(100)
  
  achieve essentially the same?

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21607

To: fvogt, #frameworks, broulik
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21604: Fix building with Qt 5.13

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  This lacks a proper commit message

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21604

To: carewolf, bruns, ngraham
Cc: alexeymin, kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21604: Fix building with Qt 5.13

[Allan Sandfeld Jensen]

carewolf added inline comments.

INLINE COMMENTS

> alexeymin wrote in regexpcache.cpp:81
> can probably just be `QString suffixMatch(QLatin1String("^.*\\.("));` then, 
> without `=`

Sure, but it hardly matters, copy-elision will make the statements equivalent.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21604

To: carewolf, bruns, ngraham
Cc: alexeymin, kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21607: Don't delay emission of matchesChanged indefinitely

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Frameworks, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  Currently the signal is only emitted if there was no change to the matches in
  the last 100ms. Especially during krunner startup and early result collection,
  this is unlikely to happen though, so make sure that the signal is emitted
  at least once every ~500ms.

TEST PLAN
  Sometimes results only appeared after a noticable delay, now this
  delay is much shorter.

REPOSITORY
  R308 KRunner

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21607

AFFECTED FILES
  src/runnermanager.cpp

To: fvogt, #frameworks, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21606: RFC: ThreadWeaver Job Decorators not used properly and have no effect

[Fabian Vogt]

fvogt created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  ThreadWeaver Job Decorators don't actually hook into an existing job.
  Instead, they provide the same interface as the job and just pass through
  all calls.
  
  The way the QObjectDecorator is used by KRunner results in no signals actually
  getting emitted, making most of the code pointless.
  
  This patch is just a quick hack to show what would happen if the jobDone 
signal
  worked and is mostly intended to present the issue.

TEST PLAN
  jobDone is called now.

REPOSITORY
  R308 KRunner

BRANCH
  hack

REVISION DETAIL
  https://phabricator.kde.org/D21606

AFFECTED FILES
  src/runnerjobs.cpp

To: fvogt
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21604: Fix building with Qt 5.13

[Alexey Min]

alexeymin added inline comments.

INLINE COMMENTS

> regexpcache.cpp:81
>  // Combine all suffixes into one large RE: "^.*(foo|bar|baz)$"
> -auto suffixMatch = QLatin1String("^.*\\.(");
> +QString suffixMatch = QLatin1String("^.*\\.(");
>  suffixMatch += suffixes.join(QChar('|'));

can probably just be `QString suffixMatch(QLatin1String("^.*\\.("));` then, 
without `=`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21604

To: carewolf, bruns, ngraham
Cc: alexeymin, kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21604: Fix building with Qt 5.13

[Allan Sandfeld Jensen]

carewolf added reviewers: bruns, ngraham.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21604

To: carewolf, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21604: Fix building with Qt 5.13

[Allan Sandfeld Jensen]

carewolf created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
carewolf requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  fix-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21604

AFFECTED FILES
  src/file/regexpcache.cpp

To: carewolf
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20062: [RFC] Add support for changing volume label.

[Nathaniel Graham]

ngraham added a comment.


  Ping, any update on this?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20062

To: chinmoyr, #frameworks, bruns, broulik
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21599: Disable valgrind detection when compiling with MSVC

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> database.cpp:49
> +// the macros without ifdef'ing these in place
> +#if defined _MSC_VER && !defined NVALGRIND
> +#define NVALGRIND 1

Id suggest to use Q_CC_MSVC but it looks ok

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21599

To: bruns, #windows, bcooksley
Cc: vonreth, #baloo, alexeymin, kde-frameworks-devel, LeGast00n, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 88 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/88/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 05 Jun 2019 13:01:29 +
 Build duration:
5 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 743 lines...][2019-06-05T13:06:37.076Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.h:25,[2019-06-05T13:06:37.076Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:23:[2019-06-05T13:06:37.076Z] /usr/include/qt5/QtCore/qstringbuilder.h:415:10: note: candidate: ���template QString& operator+=(QString&, const QStringBuilder&)���[2019-06-05T13:06:37.076Z]  QString +=(QString , const QStringBuilder )[2019-06-05T13:06:37.076Z]   ^~~~[2019-06-05T13:06:37.076Z] /usr/include/qt5/QtCore/qstringbuilder.h:415:10: note:   template argument deduction/substitution failed:[2019-06-05T13:06:37.076Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:83:38: note:   ���QLatin1String��� is not derived from ���const QStringBuilder���[2019-06-05T13:06:37.076Z]  suffixMatch += QLatin1String(")$");[2019-06-05T13:06:37.076Z]   ^[2019-06-05T13:06:37.578Z] [ 39%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/baloodebug.cpp.o[2019-06-05T13:06:37.578Z] [ 39%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o[2019-06-05T13:06:37.578Z] make[2]: *** [src/lib/CMakeFiles/KF5Baloo.dir/build.make:206: src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o] Error 1[2019-06-05T13:06:37.578Z] make[2]: *** Waiting for unfinished jobs[2019-06-05T13:06:37.578Z] [ 39%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileindexer.cpp.o[2019-06-05T13:06:38.079Z] [ 39%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexer.cpp.o[2019-06-05T13:06:41.233Z] [ 40%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexerprovider.cpp.o[2019-06-05T13:06:42.287Z] [ 40%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/extractorprocess.cpp.o[2019-06-05T13:06:42.789Z] [ 40%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/timeestimator.cpp.o[2019-06-05T13:06:42.789Z] [ 40%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/indexcleaner.cpp.o[2019-06-05T13:06:43.841Z] [ 41%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/priority.cpp.o[2019-06-05T13:06:43.841Z] make[1]: *** [CMakeFiles/Makefile2:845: src/lib/CMakeFiles/KF5Baloo.dir/all] Error 2[2019-06-05T13:06:43.841Z] [ 41%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/regexpcache.cpp.o[2019-06-05T13:06:45.508Z] [ 41%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/fileexcludefilters.cpp.o[2019-06-05T13:06:45.508Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/extractorprocess.cpp: In lambda function:[2019-06-05T13:06:45.508Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/extractorprocess.cpp:37:21: warning: unused parameter ���exitCode��� [-Wunused-parameter][2019-06-05T13:06:45.508Z]  [=](int exitCode, QProcess::ExitStatus exitStatus)[2019-06-05T13:06:45.508Z]  ^~~~[2019-06-05T13:06:46.562Z] [ 41%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/storagedevices.cpp.o[2019-06-05T13:06:47.063Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp: In member function ���void RegExpCache::rebuildCacheFromFilterList(const QStringList&)���:[2019-06-05T13:06:47.063Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:82:17: error: no match for ���operator+=��� (operand types are ���QLatin1String��� and ���QString���)[2019-06-05T13:06:47.063Z]  suffixMatch += suffixes.join(QChar('|'));[2019-06-05T13:06:47.063Z]  ^~~~[2019-06-05T13:06:47.063Z] In file included from /usr/include/qt5/QtCore/qstring.h:1852,[2019-06-05T13:06:47.063Z]  from /usr/include/qt5/QtCore/qhashfunctions.h:44,[2019-06-05T13:06:47.063Z]  from /usr/include/qt5/QtCore/qlist.h:47,[2019-06-05T13:06:47.063Z]  from /usr/include/qt5/QtCore/QList:1,[2019-06-05T13:06:47.063Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.h:25,[2019-06-05T13:06:47.063Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:23:[2019-06-05T13:06:47.063Z] /usr/include/qt5/QtCore/qstringbuilder.h:408:13: note: candidate: ���template QByteArray& operator+=(QByteArray&, const QStringBuilder&)���[2019-06-05T13:06:47.063Z]  QByteArray +=(QByteArray , const QStringBuilder )[2019-06-05T13:06:47.063Z]  ^~~~[2019-06-05T13:06:47.063Z] 

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 91 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/91/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 05 Jun 2019 13:01:29 +
 Build duration:
3 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 619 lines...][2019-06-05T13:05:09.120Z] [ 45%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest.cpp.o[2019-06-05T13:05:09.120Z] [ 45%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/storagedevices.cpp.o[2019-06-05T13:05:09.120Z] [ 45%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o[2019-06-05T13:05:09.120Z] [ 45%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/transactiontest.cpp.o[2019-06-05T13:05:09.387Z] [ 46%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/file/fileexcludefilters.cpp.o[2019-06-05T13:05:09.387Z] [ 47%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/queryparsertest.cpp.o[2019-06-05T13:05:09.387Z] [ 47%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/singledbtest.cpp.o[2019-06-05T13:05:09.672Z] [ 47%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/singledbtest.cpp.o[2019-06-05T13:05:09.928Z] [ 47%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o[2019-06-05T13:05:09.928Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.12/src/file/regexpcache.cpp:82:17: error: no viable overloaded '+='[2019-06-05T13:05:09.928Z] suffixMatch += suffixes.join(QChar('|'));[2019-06-05T13:05:09.928Z] ~~~ ^  ~[2019-06-05T13:05:09.928Z] /usr/local/include/qt5/QtCore/qstringbuilder.h:474:13: note: candidate template ignored: could not match 'QStringBuilder' against 'QString'[2019-06-05T13:05:09.928Z] QByteArray +=(QByteArray , const QStringBuilder )[2019-06-05T13:05:09.928Z] ^[2019-06-05T13:05:09.928Z] /usr/local/include/qt5/QtCore/qstringbuilder.h:481:10: note: candidate template ignored: could not match 'QStringBuilder' against 'QString'[2019-06-05T13:05:09.928Z] QString +=(QString , const QStringBuilder )[2019-06-05T13:05:09.928Z]  ^[2019-06-05T13:05:09.928Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.12/src/file/regexpcache.cpp:83:17: error: no viable overloaded '+='[2019-06-05T13:05:09.928Z] suffixMatch += QLatin1String(")$");[2019-06-05T13:05:09.928Z] ~~~ ^  ~~~[2019-06-05T13:05:09.928Z] /usr/local/include/qt5/QtCore/qstringbuilder.h:474:13: note: candidate template ignored: could not match 'QStringBuilder' against 'QLatin1String'[2019-06-05T13:05:09.929Z] QByteArray +=(QByteArray , const QStringBuilder )[2019-06-05T13:05:09.929Z] ^[2019-06-05T13:05:09.929Z] /usr/local/include/qt5/QtCore/qstringbuilder.h:481:10: note: candidate template ignored: could not match 'QStringBuilder' against 'QLatin1String'[2019-06-05T13:05:09.929Z] QString +=(QString , const QStringBuilder )[2019-06-05T13:05:09.929Z]  ^[2019-06-05T13:05:09.929Z] [ 47%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[2019-06-05T13:05:10.185Z] 2 errors generated.[2019-06-05T13:05:10.185Z] gmake[2]: *** [src/lib/CMakeFiles/KF5Baloo.dir/build.make:219: src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o] Error 1[2019-06-05T13:05:10.185Z] gmake[2]: *** Waiting for unfinished jobs[2019-06-05T13:05:10.185Z] [ 48%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/singledbtest.cpp.o[2019-06-05T13:05:10.185Z] [ 49%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/firstrunindexer.cpp.o[2019-06-05T13:05:10.185Z] [ 49%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/singledbtest.cpp.o[2019-06-05T13:05:10.469Z] [ 49%] Linking CXX executable ../../../bin/mtimedbtest[2019-06-05T13:05:10.469Z] [ 49%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/newfileindexer.cpp.o[2019-06-05T13:05:10.469Z] [ 49%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/xattrindexer.cpp.o[2019-06-05T13:05:10.469Z] [ 49%] Built target mtimedbtest[2019-06-05T13:05:10.469Z] [ 49%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/modifiedfileindexer.cpp.o[2019-06-05T13:05:10.730Z] [ 49%] Linking CXX executable ../../../bin/queryparsertest[2019-06-05T13:05:10.730Z] [ 49%] Built target queryparsertest[2019-06-05T13:05:10.730Z] [ 50%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileindexer.cpp.o[2019-06-05T13:05:10.996Z] [ 50%] Linking CXX executable ../../../bin/transactiontest[2019-06-05T13:05:10.996Z] [ 50%] Linking CXX executable ../../../bin/documentiddbtest[2019-06-05T13:05:10.996Z] [ 50%] Built target transactiontest[2019-06-05T13:05:10.996Z] [ 50%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexer.cpp.o[2019-06-05T13:05:11.260Z] [ 50%] Built 

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 178 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/178/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 05 Jun 2019 13:01:29 +
 Build duration:
2 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 453 lines...][2019-06-05T13:04:15.741Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\documentdb.cpp(100): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2019-06-05T13:04:15.741Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\documentdb.cpp(153): warning C4267: 'return': conversion from 'size_t' to 'uint', possible loss of data[2019-06-05T13:04:15.741Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\documentdb.cpp(173): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2019-06-05T13:04:15.741Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\documentiddb.cpp(151): warning C4267: 'return': conversion from 'size_t' to 'uint', possible loss of data[2019-06-05T13:04:15.741Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\documentdatadb.cpp(97): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2019-06-05T13:04:15.741Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\idfilenamedb.cpp(105): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2019-06-05T13:04:15.741Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\documentdatadb.cpp(151): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2019-06-05T13:04:15.741Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\idfilenamedb.cpp(164): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2019-06-05T13:04:16.012Z] orpostingiterator.cpp[2019-06-05T13:04:16.273Z] [ 41%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/phraseanditerator.cpp.obj[2019-06-05T13:04:16.273Z] phraseanditerator.cpp[2019-06-05T13:04:16.273Z] [ 42%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/positiondb.cpp.obj[2019-06-05T13:04:16.273Z] [ 44%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/postingdb.cpp.obj[2019-06-05T13:04:16.273Z] [ 45%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/postingiterator.cpp.obj[2019-06-05T13:04:16.273Z] positiondb.cpp[2019-06-05T13:04:16.273Z] [ 46%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/queryparser.cpp.obj[2019-06-05T13:04:16.273Z] postingdb.cpp[2019-06-05T13:04:16.273Z] [ 48%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/transaction.cpp.obj[2019-06-05T13:04:16.273Z] [ 49%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/termgenerator.cpp.obj[2019-06-05T13:04:16.273Z] [ 50%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/vectorpostingiterator.cpp.obj[2019-06-05T13:04:16.273Z] postingiterator.cpp[2019-06-05T13:04:16.273Z] [ 51%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/vectorpositioninfoiterator.cpp.obj[2019-06-05T13:04:16.273Z] queryparser.cpp[2019-06-05T13:04:16.273Z] transaction.cpp[2019-06-05T13:04:16.273Z] termgenerator.cpp[2019-06-05T13:04:16.273Z] vectorpostingiterator.cpp[2019-06-05T13:04:16.273Z] [ 53%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/writetransaction.cpp.obj[2019-06-05T13:04:16.541Z] vectorpositioninfoiterator.cpp[2019-06-05T13:04:16.541Z] [ 54%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/global.cpp.obj[2019-06-05T13:04:16.541Z] writetransaction.cpp[2019-06-05T13:04:17.120Z] global.cpp[2019-06-05T13:04:17.120Z] [ 55%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/fsutils.cpp.obj[2019-06-05T13:04:18.092Z] fsutils.cpp[2019-06-05T13:04:18.092Z] [ 57%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/enginedebug.cpp.obj[2019-06-05T13:04:18.092Z] enginedebug.cpp[2019-06-05T13:04:18.092Z] [ 58%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/KF5BalooEngine_autogen/mocs_compilation.cpp.obj[2019-06-05T13:04:18.092Z] mocs_compilation.cpp[2019-06-05T13:04:18.092Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\positiondb.cpp(104): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2019-06-05T13:04:18.092Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\positiondb.cpp(180): warning C4267: 'argument': conversion from 'size_t' to 'uint', possible loss of data[2019-06-05T13:04:18.092Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\positiondb.cpp(199): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data[2019-06-05T13:04:18.092Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11\src\engine\positiondb.cpp(200): warning 

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 85 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/85/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 05 Jun 2019 13:01:29 +
 Build duration:
1 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 783 lines...][2019-06-05T13:03:23.505Z]  ^~~~[2019-06-05T13:03:23.505Z] /usr/include/qt5/QtCore/qstringbuilder.h:474:13: note:   template argument deduction/substitution failed:[2019-06-05T13:03:23.505Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:83:38: note:   ���QLatin1String��� is not derived from ���const QStringBuilder���[2019-06-05T13:03:23.505Z]  suffixMatch += QLatin1String(")$");[2019-06-05T13:03:23.505Z]   ^[2019-06-05T13:03:23.505Z] In file included from /usr/include/qt5/QtCore/qstring.h:1878,[2019-06-05T13:03:23.505Z]  from /usr/include/qt5/QtCore/qhashfunctions.h:44,[2019-06-05T13:03:23.505Z]  from /usr/include/qt5/QtCore/qlist.h:47,[2019-06-05T13:03:23.505Z]  from /usr/include/qt5/QtCore/QList:1,[2019-06-05T13:03:23.505Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.h:25,[2019-06-05T13:03:23.505Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:23:[2019-06-05T13:03:23.505Z] /usr/include/qt5/QtCore/qstringbuilder.h:481:10: note: candidate: ���template QString& operator+=(QString&, const QStringBuilder&)���[2019-06-05T13:03:23.505Z]  QString +=(QString , const QStringBuilder )[2019-06-05T13:03:23.505Z]   ^~~~[2019-06-05T13:03:23.505Z] /usr/include/qt5/QtCore/qstringbuilder.h:481:10: note:   template argument deduction/substitution failed:[2019-06-05T13:03:23.505Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:83:38: note:   ���QLatin1String��� is not derived from ���const QStringBuilder���[2019-06-05T13:03:23.505Z]  suffixMatch += QLatin1String(")$");[2019-06-05T13:03:23.505Z]   ^[2019-06-05T13:03:23.760Z] make[2]: *** [src/file/CMakeFiles/baloofilecommon.dir/build.make:295: src/file/CMakeFiles/baloofilecommon.dir/regexpcache.cpp.o] Error 1[2019-06-05T13:03:23.760Z] make[2]: *** Waiting for unfinished jobs[2019-06-05T13:03:23.760Z] [ 47%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[2019-06-05T13:03:23.760Z] [ 48%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/searchstore.cpp.o[2019-06-05T13:03:23.760Z] [ 48%] Building CXX object autotests/unit/engine/CMakeFiles/andpostingiteratortest.dir/andpostingiteratortest_autogen/mocs_compilation.cpp.o[2019-06-05T13:03:24.015Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp: In member function ���void RegExpCache::rebuildCacheFromFilterList(const QStringList&)���:[2019-06-05T13:03:24.015Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:82:17: error: no match for ���operator+=��� (operand types are ���QLatin1String��� and ���QString���)[2019-06-05T13:03:24.015Z]  suffixMatch += suffixes.join(QChar('|'));[2019-06-05T13:03:24.015Z]  ^~~~[2019-06-05T13:03:24.015Z] In file included from /usr/include/qt5/QtCore/qstring.h:1878,[2019-06-05T13:03:24.015Z]  from /usr/include/qt5/QtCore/qhashfunctions.h:44,[2019-06-05T13:03:24.015Z]  from /usr/include/qt5/QtCore/qlist.h:47,[2019-06-05T13:03:24.015Z]  from /usr/include/qt5/QtCore/QList:1,[2019-06-05T13:03:24.015Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.h:25,[2019-06-05T13:03:24.015Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:23:[2019-06-05T13:03:24.015Z] /usr/include/qt5/QtCore/qstringbuilder.h:474:13: note: candidate: ���template QByteArray& operator+=(QByteArray&, const QStringBuilder&)���[2019-06-05T13:03:24.015Z]  QByteArray +=(QByteArray , const QStringBuilder )[2019-06-05T13:03:24.015Z]  ^~~~[2019-06-05T13:03:24.015Z] /usr/include/qt5/QtCore/qstringbuilder.h:474:13: note:   template argument deduction/substitution failed:[2019-06-05T13:03:24.015Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:82:44: note:   ���QString��� is not derived from ���const QStringBuilder���[2019-06-05T13:03:24.015Z]  suffixMatch += suffixes.join(QChar('|'));[2019-06-05T13:03:24.015Z] ^[2019-06-05T13:03:24.015Z] In file included from /usr/include/qt5/QtCore/qstring.h:1878,[2019-06-05T13:03:24.015Z]  from /usr/include/qt5/QtCore/qhashfunctions.h:44,[2019-06-05T13:03:24.015Z]  from 

D21599: Disable valgrind detection when compiling with MSVC

[Stefan Brüns]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:617e371d972f: Disable valgrind detection when compiling 
with MSVC (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21599?vs=59190=59192

REVISION DETAIL
  https://phabricator.kde.org/D21599

AFFECTED FILES
  src/engine/database.cpp

To: bruns, #windows, bcooksley
Cc: #baloo, alexeymin, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21599: Disable valgrind detection when compiling with MSVC

[Stefan Brüns]

bruns removed a reviewer: Baloo.
bruns added a subscriber: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21599

To: bruns, #windows, bcooksley
Cc: #baloo, alexeymin, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 84 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/84/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 05 Jun 2019 12:51:48 +
 Build duration:
4 min 55 sec and counting
   CONSOLE OUTPUT
  [...truncated 754 lines...][2019-06-05T12:56:32.283Z] In file included from /usr/include/qt5/QtCore/qstring.h:1878,[2019-06-05T12:56:32.283Z]  from /usr/include/qt5/QtCore/qhashfunctions.h:44,[2019-06-05T12:56:32.283Z]  from /usr/include/qt5/QtCore/qlist.h:47,[2019-06-05T12:56:32.283Z]  from /usr/include/qt5/QtCore/QList:1,[2019-06-05T12:56:32.283Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.h:25,[2019-06-05T12:56:32.283Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:23:[2019-06-05T12:56:32.283Z] /usr/include/qt5/QtCore/qstringbuilder.h:481:10: note: candidate: ���template QString& operator+=(QString&, const QStringBuilder&)���[2019-06-05T12:56:32.283Z]  QString +=(QString , const QStringBuilder )[2019-06-05T12:56:32.283Z]   ^~~~[2019-06-05T12:56:32.283Z] /usr/include/qt5/QtCore/qstringbuilder.h:481:10: note:   template argument deduction/substitution failed:[2019-06-05T12:56:32.283Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:83:38: note:   ���QLatin1String��� is not derived from ���const QStringBuilder���[2019-06-05T12:56:32.283Z]  suffixMatch += QLatin1String(")$");[2019-06-05T12:56:32.283Z]   ^[2019-06-05T12:56:32.283Z] make[2]: *** [src/lib/CMakeFiles/KF5Baloo.dir/build.make:206: src/lib/CMakeFiles/KF5Baloo.dir/__/file/regexpcache.cpp.o] Error 1[2019-06-05T12:56:32.283Z] make[2]: *** Waiting for unfinished jobs[2019-06-05T12:56:32.283Z] [ 41%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/indexcleaner.cpp.o[2019-06-05T12:56:32.785Z] [ 41%] Building CXX object autotests/integration/CMakeFiles/querytest.dir/querytest_autogen/mocs_compilation.cpp.o[2019-06-05T12:56:32.785Z] [ 41%] Linking CXX executable ../../bin/querytest[2019-06-05T12:56:37.895Z] [ 41%] Built target querytest[2019-06-05T12:56:37.895Z] [ 42%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/priority.cpp.o[2019-06-05T12:56:37.895Z] [ 42%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/regexpcache.cpp.o[2019-06-05T12:56:37.895Z] [ 42%] Linking CXX executable ../../bin/writetransactiontest[2019-06-05T12:56:37.895Z] [ 42%] Built target writetransactiontest[2019-06-05T12:56:37.895Z] [ 42%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/fileexcludefilters.cpp.o[2019-06-05T12:56:37.895Z] [ 42%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/storagedevices.cpp.o[2019-06-05T12:56:37.895Z] [ 43%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filtereddiriterator.cpp.o[2019-06-05T12:56:37.895Z] [ 43%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileiterator.cpp.o[2019-06-05T12:56:38.397Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp: In member function ���void RegExpCache::rebuildCacheFromFilterList(const QStringList&)���:[2019-06-05T12:56:38.397Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:82:17: error: no match for ���operator+=��� (operand types are ���QLatin1String��� and ���QString���)[2019-06-05T12:56:38.397Z]  suffixMatch += suffixes.join(QChar('|'));[2019-06-05T12:56:38.397Z]  ^~~~[2019-06-05T12:56:38.397Z] In file included from /usr/include/qt5/QtCore/qstring.h:1878,[2019-06-05T12:56:38.397Z]  from /usr/include/qt5/QtCore/qhashfunctions.h:44,[2019-06-05T12:56:38.397Z]  from /usr/include/qt5/QtCore/qlist.h:47,[2019-06-05T12:56:38.397Z]  from /usr/include/qt5/QtCore/QList:1,[2019-06-05T12:56:38.397Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.h:25,[2019-06-05T12:56:38.397Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:23:[2019-06-05T12:56:38.397Z] /usr/include/qt5/QtCore/qstringbuilder.h:474:13: note: candidate: ���template QByteArray& operator+=(QByteArray&, const QStringBuilder&)���[2019-06-05T12:56:38.397Z]  QByteArray +=(QByteArray , const QStringBuilder )[2019-06-05T12:56:38.397Z]  ^~~~[2019-06-05T12:56:38.397Z] /usr/include/qt5/QtCore/qstringbuilder.h:474:13: note:   template argument deduction/substitution failed:[2019-06-05T12:56:38.397Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.12/src/file/regexpcache.cpp:82:44: note:   ���QString��� is not derived from ���const QStringBuilder���[2019-06-05T12:56:38.397Z]  suffixMatch += 

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 177 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/177/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 05 Jun 2019 12:51:48 +
 Build duration:
2 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 376 lines...][Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-06-05T12:54:18.233Z] [2019-06-05T12:54:18.233Z] C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-06-05T12:54:18.233Z] **[2019-06-05T12:54:18.233Z] ** Visual Studio 2019 Developer Command Prompt v16.0.3[2019-06-05T12:54:18.233Z] ** Copyright (c) 2019 Microsoft Corporation[2019-06-05T12:54:18.233Z] **[2019-06-05T12:54:19.612Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-06-05T12:54:20.590Z] [2019-06-05T12:54:20.590Z] jom 1.1.2 - empower your cores[2019-06-05T12:54:20.590Z] [2019-06-05T12:54:20.855Z] jom: parallel job execution disabled for Makefile[2019-06-05T12:54:20.855Z] Scanning dependencies of target BalooDBusInterfaces[2019-06-05T12:54:20.855Z] Scanning dependencies of target KF5BalooCodecs_autogen[2019-06-05T12:54:20.855Z] Scanning dependencies of target KF5Baloo_QCH[2019-06-05T12:54:21.113Z] [  3%] Automatic MOC for target KF5BalooCodecs[2019-06-05T12:54:21.463Z] [  6%] Built target KF5BalooCodecs_autogen[2019-06-05T12:54:21.463Z] [  2%] Generating org.kde.baloo.main.xml[2019-06-05T12:54:21.463Z] [  5%] Generating org.kde.baloo.scheduler.xml[2019-06-05T12:54:21.463Z] [  5%] Generating org.kde.baloo.fileindexer.xml[2019-06-05T12:54:21.463Z] [  6%] Generating src/lib/KF5Baloo.qch, src/lib/KF5Baloo.tags[2019-06-05T12:54:21.463Z] [  7%] Generating maininterface.cpp, maininterface.h[2019-06-05T12:54:21.463Z] [  9%] Generating schedulerinterface.cpp, schedulerinterface.h[2019-06-05T12:54:21.755Z] [ 10%] Generating fileindexerinterface.cpp, fileindexerinterface.h[2019-06-05T12:54:22.081Z] Scanning dependencies of target KF5BalooCodecs[2019-06-05T12:54:22.081Z] [ 11%] Generating maininterface.moc[2019-06-05T12:54:22.371Z] [ 12%] Generating schedulerinterface.moc[2019-06-05T12:54:22.371Z] [ 14%] Generating fileindexerinterface.moc[2019-06-05T12:54:22.653Z] [ 18%] Built target BalooDBusInterfaces[2019-06-05T12:54:22.653Z] [ 15%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/doctermscodec.cpp.obj[2019-06-05T12:54:22.653Z] [ 16%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/positioncodec.cpp.obj[2019-06-05T12:54:22.653Z] [ 18%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/postingcodec.cpp.obj[2019-06-05T12:54:22.653Z] doctermscodec.cpp[2019-06-05T12:54:22.961Z] [ 19%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/coding.cpp.obj[2019-06-05T12:54:22.961Z] [ 20%] Building CXX object src/codecs/CMakeFiles/KF5BalooCodecs.dir/KF5BalooCodecs_autogen/mocs_compilation.cpp.obj[2019-06-05T12:54:23.566Z] mocs_compilation.cpp[2019-06-05T12:54:30.856Z] coding.cpp[2019-06-05T12:54:30.856Z] positioncodec.cpp[2019-06-05T12:54:30.856Z] postingcodec.cpp[2019-06-05T12:54:30.856Z] [ 22%] Linking CXX static library ..\..\lib\KF5BalooCodecs.lib[2019-06-05T12:54:30.856Z] [ 22%] Built target KF5BalooCodecs[2019-06-05T12:54:30.856Z] Scanning dependencies of target KF5BalooEngine_autogen[2019-06-05T12:54:30.856Z] [ 23%] Automatic MOC for target KF5BalooEngine[2019-06-05T12:54:30.856Z] [ 23%] Built target KF5BalooEngine_autogen[2019-06-05T12:54:30.856Z] [ 23%] Built target KF5Baloo_QCH[2019-06-05T12:54:30.856Z] Scanning dependencies of target KF5BalooEngine[2019-06-05T12:54:30.856Z] [ 24%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/database.cpp.obj[2019-06-05T12:54:30.856Z] [ 25%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/andpostingiterator.cpp.obj[2019-06-05T12:54:30.856Z] [ 27%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/document.cpp.obj[2019-06-05T12:54:30.856Z] [ 28%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documentdb.cpp.obj[2019-06-05T12:54:30.856Z] andpostingiterator.cpp[2019-06-05T12:54:30.856Z] [ 29%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documentdatadb.cpp.obj[2019-06-05T12:54:30.856Z] [ 31%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documenturldb.cpp.obj[2019-06-05T12:54:30.856Z] [ 32%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documenttimedb.cpp.obj[2019-06-05T12:54:30.856Z] [ 33%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/documentiddb.cpp.obj[2019-06-05T12:54:30.856Z] [ 36%] Building CXX object src/engine/CMakeFiles/KF5BalooEngine.dir/enginequery.cpp.obj[2019-06-05T12:54:30.856Z] [ 36%] Building CXX object 

D21599: Disable valgrind detection when compiling with MSVC

[Alexey Min]

alexeymin accepted this revision as: Windows.
alexeymin added a comment.


  This should work.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21599

To: bruns, #baloo, #windows, bcooksley
Cc: alexeymin, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 87 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/87/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 05 Jun 2019 12:51:48 +
 Build duration:
1 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 764 lines...][2019-06-05T12:53:07.661Z]  from /usr/include/qt5/QtCore/qlist.h:47,[2019-06-05T12:53:07.661Z]  from /usr/include/qt5/QtCore/QList:1,[2019-06-05T12:53:07.661Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.h:25,[2019-06-05T12:53:07.661Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:23:[2019-06-05T12:53:07.661Z] /usr/include/qt5/QtCore/qstringbuilder.h:408:13: note: candidate: ���template QByteArray& operator+=(QByteArray&, const QStringBuilder&)���[2019-06-05T12:53:07.661Z]  QByteArray +=(QByteArray , const QStringBuilder )[2019-06-05T12:53:07.661Z]  ^~~~[2019-06-05T12:53:07.661Z] /usr/include/qt5/QtCore/qstringbuilder.h:408:13: note:   template argument deduction/substitution failed:[2019-06-05T12:53:07.661Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:83:38: note:   ���QLatin1String��� is not derived from ���const QStringBuilder���[2019-06-05T12:53:07.661Z]  suffixMatch += QLatin1String(")$");[2019-06-05T12:53:07.661Z]   ^[2019-06-05T12:53:07.661Z] In file included from /usr/include/qt5/QtCore/qstring.h:1852,[2019-06-05T12:53:07.661Z]  from /usr/include/qt5/QtCore/qhashfunctions.h:44,[2019-06-05T12:53:07.661Z]  from /usr/include/qt5/QtCore/qlist.h:47,[2019-06-05T12:53:07.661Z]  from /usr/include/qt5/QtCore/QList:1,[2019-06-05T12:53:07.661Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.h:25,[2019-06-05T12:53:07.661Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:23:[2019-06-05T12:53:07.661Z] /usr/include/qt5/QtCore/qstringbuilder.h:415:10: note: candidate: ���template QString& operator+=(QString&, const QStringBuilder&)���[2019-06-05T12:53:07.661Z]  QString +=(QString , const QStringBuilder )[2019-06-05T12:53:07.661Z]   ^~~~[2019-06-05T12:53:07.661Z] /usr/include/qt5/QtCore/qstringbuilder.h:415:10: note:   template argument deduction/substitution failed:[2019-06-05T12:53:07.661Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:83:38: note:   ���QLatin1String��� is not derived from ���const QStringBuilder���[2019-06-05T12:53:07.661Z]  suffixMatch += QLatin1String(")$");[2019-06-05T12:53:07.661Z]   ^[2019-06-05T12:53:07.661Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp: In member function ���void RegExpCache::rebuildCacheFromFilterList(const QStringList&)���:[2019-06-05T12:53:07.661Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:82:17: error: no match for ���operator+=��� (operand types are ���QLatin1String��� and ���QString���)[2019-06-05T12:53:07.661Z]  suffixMatch += suffixes.join(QChar('|'));[2019-06-05T12:53:07.661Z]  ^~~~[2019-06-05T12:53:07.661Z] In file included from /usr/include/qt5/QtCore/qstring.h:1852,[2019-06-05T12:53:07.661Z]  from /usr/include/qt5/QtCore/qhashfunctions.h:44,[2019-06-05T12:53:07.661Z]  from /usr/include/qt5/QtCore/qlist.h:47,[2019-06-05T12:53:07.661Z]  from /usr/include/qt5/QtCore/QList:1,[2019-06-05T12:53:07.661Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.h:25,[2019-06-05T12:53:07.661Z]  from /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:23:[2019-06-05T12:53:07.661Z] /usr/include/qt5/QtCore/qstringbuilder.h:408:13: note: candidate: ���template QByteArray& operator+=(QByteArray&, const QStringBuilder&)���[2019-06-05T12:53:07.661Z]  QByteArray +=(QByteArray , const QStringBuilder )[2019-06-05T12:53:07.661Z]  ^~~~[2019-06-05T12:53:07.661Z] /usr/include/qt5/QtCore/qstringbuilder.h:408:13: note:   template argument deduction/substitution failed:[2019-06-05T12:53:07.661Z] /home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.10/src/file/regexpcache.cpp:82:44: note:   ���QString��� is not derived from ���const QStringBuilder���[2019-06-05T12:53:07.661Z]  suffixMatch += suffixes.join(QChar('|'));[2019-06-05T12:53:07.661Z] ^[2019-06-05T12:53:07.661Z] In file included from /usr/include/qt5/QtCore/qstring.h:1852,[2019-06-05T12:53:07.661Z]  from /usr/include/qt5/QtCore/qhashfunctions.h:44,[2019-06-05T12:53:07.661Z]

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 90 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/90/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 05 Jun 2019 12:51:48 +
 Build duration:
1 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 606 lines...][2019-06-05T12:52:55.400Z] [ 43%] Linking CXX executable ../../bin/querytest[2019-06-05T12:52:55.400Z] [ 43%] Building CXX object autotests/unit/engine/CMakeFiles/orpostingiteratortest.dir/orpostingiteratortest.cpp.o[2019-06-05T12:52:55.666Z] [ 43%] Built target querytest[2019-06-05T12:52:55.666Z] [ 44%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/fileexcludefilters.cpp.o[2019-06-05T12:52:55.667Z] gmake[1]: *** [CMakeFiles/Makefile2:1473: src/lib/CMakeFiles/KF5Baloo.dir/all] Error 2[2019-06-05T12:52:55.667Z] gmake[1]: *** Waiting for unfinished jobs[2019-06-05T12:52:55.667Z] [ 44%] Building CXX object autotests/unit/engine/CMakeFiles/andpostingiteratortest.dir/andpostingiteratortest.cpp.o[2019-06-05T12:52:55.667Z] [ 44%] Building CXX object autotests/unit/engine/CMakeFiles/andpostingiteratortest.dir/singledbtest.cpp.o[2019-06-05T12:52:55.667Z] [ 45%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileindexer.cpp.o[2019-06-05T12:52:55.667Z] [ 45%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/transactiontest.cpp.o[2019-06-05T12:52:55.953Z] [ 46%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/queryparsertest.cpp.o[2019-06-05T12:52:55.953Z] [ 46%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/singledbtest.cpp.o[2019-06-05T12:52:56.218Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.12/src/file/regexpcache.cpp:82:17: error: no viable overloaded '+='[2019-06-05T12:52:56.218Z] suffixMatch += suffixes.join(QChar('|'));[2019-06-05T12:52:56.218Z] ~~~ ^  ~[2019-06-05T12:52:56.218Z] /usr/local/include/qt5/QtCore/qstringbuilder.h:474:13: note: candidate template ignored: could not match 'QStringBuilder' against 'QString'[2019-06-05T12:52:56.218Z] QByteArray +=(QByteArray , const QStringBuilder )[2019-06-05T12:52:56.218Z] ^[2019-06-05T12:52:56.218Z] /usr/local/include/qt5/QtCore/qstringbuilder.h:481:10: note: candidate template ignored: could not match 'QStringBuilder' against 'QString'[2019-06-05T12:52:56.218Z] QString +=(QString , const QStringBuilder )[2019-06-05T12:52:56.218Z]  ^[2019-06-05T12:52:56.218Z] /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.12/src/file/regexpcache.cpp:83:17: error: no viable overloaded '+='[2019-06-05T12:52:56.218Z] suffixMatch += QLatin1String(")$");[2019-06-05T12:52:56.218Z] ~~~ ^  ~~~[2019-06-05T12:52:56.218Z] /usr/local/include/qt5/QtCore/qstringbuilder.h:474:13: note: candidate template ignored: could not match 'QStringBuilder' against 'QLatin1String'[2019-06-05T12:52:56.218Z] QByteArray +=(QByteArray , const QStringBuilder )[2019-06-05T12:52:56.218Z] ^[2019-06-05T12:52:56.218Z] /usr/local/include/qt5/QtCore/qstringbuilder.h:481:10: note: candidate template ignored: could not match 'QStringBuilder' against 'QLatin1String'[2019-06-05T12:52:56.218Z] QString +=(QString , const QStringBuilder )[2019-06-05T12:52:56.218Z]  ^[2019-06-05T12:52:56.218Z] [ 46%] Building CXX object src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloodebug.cpp.o[2019-06-05T12:52:56.492Z] 2 errors generated.[2019-06-05T12:52:56.492Z] gmake[2]: *** [src/file/extractor/CMakeFiles/baloo_file_extractor.dir/build.make:180: src/file/extractor/CMakeFiles/baloo_file_extractor.dir/__/regexpcache.cpp.o] Error 1[2019-06-05T12:52:56.492Z] gmake[2]: *** Waiting for unfinished jobs[2019-06-05T12:52:56.492Z] [ 46%] Building CXX object autotests/unit/engine/CMakeFiles/orpostingiteratortest.dir/singledbtest.cpp.o[2019-06-05T12:52:57.167Z] [ 47%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/singledbtest.cpp.o[2019-06-05T12:52:57.486Z] [ 47%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexer.cpp.o[2019-06-05T12:52:57.486Z] [ 47%] Linking CXX executable ../../../bin/andpostingiteratortest[2019-06-05T12:52:57.768Z] [ 47%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filecontentindexerprovider.cpp.o[2019-06-05T12:52:58.144Z] [ 47%] Built target andpostingiteratortest[2019-06-05T12:52:58.144Z] [ 47%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/extractorprocess.cpp.o[2019-06-05T12:52:58.144Z] [ 48%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/timeestimator.cpp.o[2019-06-05T12:52:58.144Z] [ 48%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/indexcleaner.cpp.o[2019-06-05T12:52:58.444Z] [ 48%] Linking CXX executable ../../../bin/queryparsertest[2019-06-05T12:52:58.444Z] gmake[1]: *** [CMakeFiles/Makefile2:2089: 

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3282105c6cc6: [FilteredDirIterator] Combine all suffixes 
into one large RegExp (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21583?vs=59148=59191

REVISION DETAIL
  https://phabricator.kde.org/D21583

AFFECTED FILES
  src/file/regexpcache.cpp

To: bruns, #baloo, ngraham, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21599: Disable valgrind detection when compiling with MSVC

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Windows, bcooksley.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  MSVC chokes on the inline assembly, use the stub macros there instead.

TEST PLAN
  Valgrind detection on Linux/GCC still works
  MSVC untested

REPOSITORY
  R293 Baloo

BRANCH
  submit_unindexed

REVISION DETAIL
  https://phabricator.kde.org/D21599

AFFECTED FILES
  src/engine/database.cpp

To: bruns, #baloo, #windows, bcooksley
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21574: Update KBruch icon

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:86d0782cf4e2: Update KBruch icon (authored by ognarb).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21574?vs=59187=59189

REVISION DETAIL
  https://phabricator.kde.org/D21574

AFFECTED FILES
  icons-dark/apps/48/kbruch.svg
  icons/apps/48/kbruch.svg

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21586: Add syntax definition for ninja build

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Nice, I use ninja here, cool to have!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  ninja (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21586

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D21574: Update KBruch icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  kbruch

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb updated this revision to Diff 59187.
ognarb added a comment.


  - Optimize icon with scour-icon
  - Copy icon to breeze-dark
  - Remove png

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21574?vs=59131=59187

BRANCH
  kbruch

REVISION DETAIL
  https://phabricator.kde.org/D21574

AFFECTED FILES
  icons-dark/apps/48/kbruch.svg
  icons/apps/48/kbruch.svg

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21584: Add LE Advertising and GATT APIs

[Manuel Weichselbaumer]

mweichselbaumer marked 11 inline comments as done.
mweichselbaumer added inline comments.

INLINE COMMENTS

> drosca wrote in gattapplication_p.cpp:31
> Shouldn't the caller be made responsible for choosing object path?
> If we force a path then we should use "our" namespace - `/org/kde/bluez-qt/`.

Ok, will add possibility for custom prefix.

> drosca wrote in gattcharacteristic_p.cpp:33
> Any reason to use uint8?

I tried to figure out the maximum number of charcs (per service). I do not know 
exact numbers, but uint8 would intrinsically add limits.

> drosca wrote in gattservice.h:50
> Probably would be better to add setters for uuid/primary (and note that it 
> can only be set during creation), as if we need in future more properties we 
> will need to add new constructors.
> Or make it virtual?

GATT is well defined and i do not expect any changes (regarding additional 
properties).
This also follows the RAII idiom and is less error prone.
Could be made virtual though, however i believe adding further constructors 
won't harm.
Or if further properties are coming, we add setters for them, since they are 
then expected not to be mandatory.

> drosca wrote in leadvertisement.h:52
> Same as above, add setters?

see above

> drosca wrote in objectmanager.h:47
> Will this be used for more classes? Right now only GattApplication inherits 
> it.

QDbusAdaptors can only realize one single DBUS interface.
This is the base class the org.freedesktop.DBus.ObjectManager adaptor is 
handling.
Sure, this could (and should) be reused if other DBUS/BlueZ objects shall 
realize this interface.
GattApplication is meant to realize the org.freedesktop.DBus.ObjectManager 
interface (see gatt-api.txt).

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  Looks really good!

INLINE COMMENTS

> gattapplication.cpp:38
> +
> +GattApplication::GattApplication(QObject *parent) :
> +ObjectManager(parent),

Coding style:

  ​GattApplication::GattApplication(QObject *parent)
  : ObjectManager(parent)
  , d(new GattApplicationPrivate())
  {
  }

> gattapplication.cpp:53
> +
> +auto serviceAdaptors = findChildren();
> +auto charcAdaptors = findChildren();

const

> gattapplication.cpp:64
> +
> +GattService* service = 
> qobject_cast(serviceAdaptor->parent());
> +if (service) {

`GattService *service`

> gattapplication.h:66
> +
> +DBusManagerStruct getManagedObjects() const override;
> +

Should this be made private (preferrably in GattApplicationPrivate)?

> gattapplication_p.cpp:31
> +static uint8_t appNumber = 0;
> +m_objectPath.setPath(QStringLiteral("/org/bluez/app") + 
> QString::number(appNumber++));
> +}

Shouldn't the caller be made responsible for choosing object path?
If we force a path then we should use "our" namespace - `/org/kde/bluez-qt/`.

> gattcharacteristic.cpp:50
> +
> +void GattCharacteristic::writeValue(const QByteArray& value)
> +{

`const QByteArray )`

> gattcharacteristic_p.cpp:33
> +{
> +static uint8_t charcNumber = 0;
> +m_objectPath.setPath(m_service->objectPath().path() + 
> QStringLiteral("/char") + QString::number(charcNumber++));

Any reason to use uint8?

> gattcharacteristic_p.h:39
> +QDBusObjectPath m_objectPath;
> +QByteArray  m_value;
> +GattCharacteristic::ReadCallback m_readCallback = nullptr;

No additional spaces please.

> gattcharacteristicadaptor.cpp:57
> +return m_gattCharacteristic->readValue();
> +}
> +void GattCharacteristicAdaptor::WriteValue(const QByteArray , const 
> QVariantMap &/*options*/)

newline

> gattcharacteristicadaptor.h:58
> +private:
> +GattCharacteristic* m_gattCharacteristic;
> +};

`GattCharacteristic *m_gattCharacteristic`

> gattmanager.cpp:59
> +
> +for (auto child : application->children()) {
> +GattService* service = qobject_cast(child);

const auto children =  application->children();
  for (const auto  : children()

Also you can use `findChildren` as above.

> gattmanager.h:103
> +private:
> +explicit GattManager(const QString , QObject *parent = nullptr);
> +

This should have d-ptr as it's exported class.

> gattservice.h:50
> + */
> +GattService(const QString , bool isPrimary, GattApplication 
> *parent);
> +

Probably would be better to add setters for uuid/primary (and note that it can 
only be set during creation), as if we need in future more properties we will 
need to add new constructors.
Or make it virtual?

> leadvertisement.h:52
> + */
> +explicit LEAdvertisement(const QStringList , QObject 
> *parent = nullptr);
> +

Same as above, add setters?

> objectmanager.h:47
> + */
> +class BLUEZQT_EXPORT ObjectManager : public QObject
> +{

Will this be used for more classes? Right now only GattApplication inherits it.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.10 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.10/21/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 05 Jun 2019 06:32:05 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5BluezQt-5.59.0.xmlcompat_reports/KF5BluezQt_compat_report.htmllogs/KF5BluezQt/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)50%
(47/94)50%
(47/94)53%
(3067/5806)32%
(1372/4241)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(11/11)100%
(11/11)96%
(1434/1487)38%
(932/2446)autotests.fakebluez0%
(0/17)0%
(0/17)0%
(0/692)0%
(0/202)src71%
(30/42)71%
(30/42)52%
(1294/2493)37%
(421/1126)src.imports86%
(6/7)86%
(6/7)81%
(339/421)48%
(19/40)tests0%
(0/4)0%
(0/4)0%
(0/191)0%
(0/46)tools.bluezapi2qt0%
(0/13)0%
(0/13)0%
(0/522)0%
(0/381)

KDE CI: Frameworks » bluez-qt » kf5-qt5 SUSEQt5.12 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20SUSEQt5.12/21/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 05 Jun 2019 06:32:05 +
 Build duration:
6 min 21 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5BluezQt-5.59.0.xmlcompat_reports/KF5BluezQt_compat_report.htmllogs/KF5BluezQt/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)50%
(47/94)50%
(47/94)53%
(3067/5806)32%
(1370/4241)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(11/11)100%
(11/11)96%
(1434/1487)38%
(930/2446)autotests.fakebluez0%
(0/17)0%
(0/17)0%
(0/692)0%
(0/202)src71%
(30/42)71%
(30/42)52%
(1294/2493)37%
(421/1126)src.imports86%
(6/7)86%
(6/7)81%
(339/421)48%
(19/40)tests0%
(0/4)0%
(0/4)0%
(0/191)0%
(0/46)tools.bluezapi2qt0%
(0/13)0%
(0/13)0%
(0/522)0%
(0/381)

KDE CI: Frameworks » bluez-qt » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/bluez-qt/job/kf5-qt5%20FreeBSDQt5.12/21/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 05 Jun 2019 06:32:06 +
 Build duration:
1 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)