D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Nathaniel Graham]

ngraham added a comment.


  @cfeck @apol @aacid It's not clear to me what's being requested. Can someone 
clarify?

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D20181

To: JJRcop, broulik, #plasma, ngraham
Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Jonathan Rubenstein]

JJRcop updated this revision to Diff 59308.
JJRcop added a comment.


  Updated version number in comments to 5.59 since 5.58 came out earlier in May.

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20181?vs=55227=59308

REVISION DETAIL
  https://phabricator.kde.org/D20181

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/binary_data.cpp
  src/binary_data_p.h
  src/converter.cpp
  src/unit.h

To: JJRcop, broulik, #plasma, ngraham
Cc: abetts, cfeck, apol, aacid, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> bruns wrote in renamefiledialog.cpp:105
> The code assumes the "#" is the very last character ("Don't select the # 
> character"), so this requires a translation comment.

Is that better line 105 ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven updated this revision to Diff 59292.
meven marked an inline comment as done.
meven added a comment.


  Improve localization context

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17595?vs=59255=59292

BRANCH
  arcpatch-D17595_1

REVISION DETAIL
  https://phabricator.kde.org/D17595

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/renamefiledialog.cpp
  src/widgets/renamefiledialog.h

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 59290.
chinmoyr added a comment.


  - int -> ActionType
  - separated the logic in dropPrivileges() to two parts
  - accepting mode argument in mkdir
  - used *at() functions
  - minor cosmetic changes
  
  @mgerstner In case of rename, when owners are different I am trying to rename 
twice. First after changing euid
  and egid to the owner of src's parent dir and then the owner of dest's parent 
dir, hoping that at least one of 
  them is a privileged user. Do you think it's a good idea?

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14467?vs=38719=59290

BRANCH
  arcpatch-D14467

REVISION DETAIL
  https://phabricator.kde.org/D14467

AFFECTED FILES
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6227d63efa20: Add edit-select-text, make 16px draw-text 
like 22px (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21632?vs=59283=59287

REVISION DETAIL
  https://phabricator.kde.org/D21632

AFFECTED FILES
  icons-dark/actions/16/draw-text.svg
  icons-dark/actions/16/edit-select-text.svg
  icons-dark/actions/22/edit-select-text.svg
  icons/actions/16/draw-text.svg
  icons/actions/16/edit-select-text.svg
  icons/actions/22/edit-select-text.svg

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Perfect!

REPOSITORY
  R266 Breeze Icons

BRANCH
  edit-select-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21632

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

[Noah Davis]

ndavis added a dependent revision: D21633: Change Text Selection icon to 
edit-select-text.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21632

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21632

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21632: Add edit-select-text, make 16px draw-text like 22px

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Okular uses draw-text for the text selection tool, but it has 2 different 
icons at different sizes. This patch adds a more semantically correct icon for 
Okular (edit-select-text) and fixes the inconsistency between 16 and 22 px 
versions of draw-text.

REPOSITORY
  R266 Breeze Icons

BRANCH
  edit-select-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21632

AFFECTED FILES
  icons-dark/actions/16/draw-text.svg
  icons-dark/actions/16/edit-select-text.svg
  icons-dark/actions/22/edit-select-text.svg
  icons/actions/16/draw-text.svg
  icons/actions/16/edit-select-text.svg
  icons/actions/22/edit-select-text.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

[Manuel Weichselbaumer]

mweichselbaumer added inline comments.

INLINE COMMENTS

> drosca wrote in gattapplication.h:66
> Should this be made private (preferrably in GattApplicationPrivate)?

I override this in test class, so kept as protected.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/128/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 06 Jun 2019 17:41:33 +
 Build duration:
8 min 59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21584: Add LE Advertising and GATT APIs

[Manuel Weichselbaumer]

mweichselbaumer updated this revision to Diff 59277.
mweichselbaumer added a comment.


  Fixed according to comments

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21584?vs=59238=59277

BRANCH
  ble_gatt

REVISION DETAIL
  https://phabricator.kde.org/D21584

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/fakebluez/CMakeLists.txt
  autotests/fakebluez/adapterinterface.cpp
  autotests/fakebluez/adapterinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/fakebluez/leadvertisingmanagerinterface.cpp
  autotests/fakebluez/leadvertisingmanagerinterface.h
  autotests/gattmanagertest.cpp
  autotests/gattmanagertest.h
  autotests/leadvertisingmanagertest.cpp
  autotests/leadvertisingmanagertest.h
  src/CMakeLists.txt
  src/adapter.cpp
  src/adapter.h
  src/adapter_p.cpp
  src/adapter_p.h
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/interfaces/org.bluez.GattCharacteristic1.xml
  src/interfaces/org.bluez.GattManager1.xml
  src/interfaces/org.bluez.LEAdvertisement1.xml
  src/interfaces/org.bluez.LEAdvertisingManager1.xml
  src/leadvertisement.cpp
  src/leadvertisement.h
  src/leadvertisement_p.cpp
  src/leadvertisement_p.h
  src/leadvertisementadaptor.cpp
  src/leadvertisementadaptor.h
  src/leadvertisingmanager.cpp
  src/leadvertisingmanager.h
  src/leadvertisingmanager_p.h
  src/mediaendpoint.cpp
  src/objectmanager.cpp
  src/objectmanager.h
  src/objectmanageradaptor.cpp
  src/objectmanageradaptor.h
  src/pendingcall.cpp
  src/pendingcall.h
  src/types.h
  src/utils.cpp
  src/utils.h
  tests/CMakeLists.txt
  tests/leserver.cpp
  tests/leserver.h

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:69754bfed154: Always save view settings when switching 
from one view mode to another (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21459?vs=59058=59274

REVISION DETAIL
  https://phabricator.kde.org/D21459

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21459

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21607: Don't delay emission of matchesChanged indefinitely

[Nathaniel Graham]

ngraham added a comment.


  I think it's quite fine to have the entries jump around a little bit. To me 
it makes KRunner feel faster to have it start displaying results immediately 
and then refining them milliseconds later. +1

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21607

To: fvogt, #frameworks, broulik
Cc: ngraham, bruns, kde-frameworks-devel, LeGast00n, michaelh

D21628: Avoid container detach in a few places

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:26e6e5fb46c4: Avoid container detach in a few places 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21628?vs=59269=59271

REVISION DETAIL
  https://phabricator.kde.org/D21628

AFFECTED FILES
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/file/basicindexingjob.cpp
  src/file/fileindexerconfig.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17595: Upstream Dolphin's file rename dialog

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> renamefiledialog.cpp:105
> +} else {
> +newName = i18nc("@info:status", "New name #");
> +editLabel = new QLabel(i18ncp("@label:textbox",

The code assumes the "#" is the very last character ("Don't select the # 
character"), so this requires a translation comment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham

D21628: Avoid container detach in a few places

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21628

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21628: Avoid container detach in a few places

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  make

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21628

AFFECTED FILES
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/file/basicindexingjob.cpp
  src/file/fileindexerconfig.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

[Nathaniel Graham]

ngraham added a comment.


  This fixes it for me:
  
diff --git a/src/file/regexpcache.cpp b/src/file/regexpcache.cpp
index f47757ff..dce5cdcb 100644
--- a/src/file/regexpcache.cpp
+++ b/src/file/regexpcache.cpp
@@ -78,9 +78,9 @@ void RegExpCache::rebuildCacheFromFilterList(const 
QStringList& filters)
 }
 
 // Combine all suffixes into one large RE: "^.*(foo|bar|baz)$"
-auto suffixMatch = QLatin1String("^.*\\.(");
-suffixMatch += suffixes.join(QChar('|'));
-suffixMatch += QLatin1String(")$");
+auto suffixMatch = QLatin1String("^.*\\.(")
++ suffixes.join(QChar('|'))
++ QLatin1String(")$");
 qCDebug(BALOO) << suffixMatch;
 m_regexpCache.prepend(QRegularExpression(suffixMatch));
 }

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21583

To: bruns, #baloo, ngraham, poboiko
Cc: bcooksley, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 86 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/86/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 06 Jun 2019 13:35:56 +
 Build duration:
9 min 26 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.59.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(114/169)67%
(114/169)58%
(5744/9901)40%
(2153/5367)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(799/799)56%
(236/424)autotests.unit.file100%
(11/11)100%
(11/11)98%
(889/910)53%
(269/506)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)58%
(93/160)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine92%
(35/38)92%
(35/38)77%
(1733/2259)53%
(679/1279)src.file68%
(26/38)68%
(26/38)51%
(895/1746)40%
(416/1029)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/72)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/113)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/254)0%
(0/125)src.lib55%
(6/11)55%
(6/11)41%
(394/952)38%
(212/561)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 89 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/89/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 06 Jun 2019 13:35:57 +
 Build duration:
6 min 14 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.59.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(114/169)67%
(114/169)58%
(5744/9901)40%
(2153/5367)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(799/799)56%
(236/424)autotests.unit.file100%
(11/11)100%
(11/11)98%
(889/910)53%
(269/506)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)58%
(93/160)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine92%
(35/38)92%
(35/38)77%
(1733/2259)53%
(679/1279)src.file68%
(26/38)68%
(26/38)51%
(895/1746)40%
(416/1029)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/72)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/113)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/254)0%
(0/125)src.lib55%
(6/11)55%
(6/11)41%
(394/952)38%
(212/561)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%

D21459: Always save view settings when switching from one view mode to another

[Nathaniel Graham]

ngraham added a comment.


  Your reasoning makes sense. Shipit! :)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21459

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 179 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/179/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 06 Jun 2019 13:35:57 +
 Build duration:
4 min 35 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 92 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/92/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 06 Jun 2019 13:35:57 +
 Build duration:
3 min 4 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

[Stefan Brüns]

bruns added a comment.


  In D21583#475086 , @bcooksley 
wrote:
  
  > This change unfortunately does not compile on any platform tracked by the 
CI system.
  >  Please see https://build.kde.org/job/Frameworks/job/baloo/
  >
  > This is something which needs correcting relatively urgently, as without it 
running any Dependency Build job is impossible.
  
  
  Its always nice to see how easy it is to merge the wrong branch with 
phabricator ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21583

To: bruns, #baloo, ngraham, poboiko
Cc: bcooksley, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Plasma applets when they were all C++ had a way for them to signal when
  they were ready for showing to the user.
  
  The QtQuick plugin does it automatically when an applet is compiled and
  the component is created with no scope for the applet to do something
  async.
  
  This is initially intended just for the desktop wallpaper, but is
  generic enough for any applet/containment that does async loading on
  startup.
  
  API is chosen as we need something ref-count based to handle wallpaper
  and containment both loading something asynchronous, and limited by the
  fact that AppletInterface is not exported.

TEST PLAN
  qDebug

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21618

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/appletinterface.h
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.h

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Pushed as part of D21379 

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21425

To: broulik, #frameworks, davidedmundson, bruns
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven marked 7 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> bruns wrote in renamefiledialog.cpp:126
> better name - `m_extensionsAreUnique`

The current name seems fine to me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven updated this revision to Diff 59255.
meven added a comment.


Add a Private class to RenameFileDialog, code fixes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17595?vs=47606=59255

BRANCH
  arcpatch-D17595

REVISION DETAIL
  https://phabricator.kde.org/D17595

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/renamefiledialog.cpp
  src/widgets/renamefiledialog.h

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven commandeered this revision.
meven added a reviewer: ngraham.
meven added inline comments.

INLINE COMMENTS

> pino wrote in renamefiledialog.cpp:50-51
> why a minimum size is enforced?

For files whose name is short, I think the dialog would not look nice.
This look fine in dolphin.
Was added in 507984415a2953000ef1edb77c9dbc3364846b13 


> pino wrote in renamefiledialog.cpp:54
> assert in a library, especially when checking user input, is never a good 
> idea...

What would be better ?
An ASSERT, removing it altogether ? Printing the message to std-err ?

> bruns wrote in renamefiledialog.cpp:60
> space around `|`

I really wish we would enforce use of a code formater, community wise ...
This is something I miss from rust:  `cargo fmt`
Such as astyle.

> bruns wrote in renamefiledialog.cpp:101
> is this correct for e.g. `foo.jpeg`? - the preferred extension is `jpg`, so 
> this may select to many characters

I have tested it, it works fine with .jpeg files.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/39/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 06 Jun 2019 10:48:59 +
 Build duration:
1 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D21379: [UDev Backend] Narrow device queried for

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:fe1c9c02e09f: [UDev Backend] Narrow device queried for 
(authored by broulik).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21379?vs=59052=59253

REVISION DETAIL
  https://phabricator.kde.org/D21379

AFFECTED FILES
  src/solid/devices/backends/shared/udevqtclient.cpp
  src/solid/devices/backends/shared/udevqtclient.h
  src/solid/devices/backends/udev/udevdevice.cpp
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21583: [FilteredDirIterator] Combine all suffixes into one large RegExp

[Ben Cooksley]

bcooksley added a comment.


  This change unfortunately does not compile on any platform tracked by the CI 
system.
  Please see https://build.kde.org/job/Frameworks/job/baloo/
  
  This is something which needs correcting relatively urgently, as without it 
running any Dependency Build job is impossible.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21583

To: bruns, #baloo, ngraham, poboiko
Cc: bcooksley, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21379: [UDev Backend] Narrow device queried for

[Stefan Brüns]

bruns accepted this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

[Stefan Brüns]

bruns added a comment.


  In D21379#475032 , @broulik wrote:
  
  > Ping :)
  >
  > In D21379#472870 , @bruns wrote:
  >
  > > The question now is, should we also differnentiate here, i.e. map 
`QVariant()` to `nullptr`, and  use `"*"` for wildcards?
  >
  >
  > What do you mean?
  
  
  Previously, you used `QVariant()` as wildcard, now it is `"*"`, which matches 
the udev syntax.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21607: Don't delay emission of matchesChanged indefinitely

[Fabian Vogt]

fvogt updated this revision to Diff 59252.
fvogt added a comment.


  New algorithm with no delay if not necessary.

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21607?vs=59203=59252

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21607

AFFECTED FILES
  src/runnermanager.cpp

To: fvogt, #frameworks, broulik
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21607: Don't delay emission of matchesChanged indefinitely

[Fabian Vogt]

fvogt added a comment.


  In D21607#474772 , @fvogt wrote:
  
  > So for the stable branches I'd like to keep the current version of the diff 
with a latency of [100,599] while for master something like the above with a 
latency of [0,500] can be tried.
  
  
  And I just now realize that I'm stupid and mixed this up with milou. krunner 
is a framework so there is no stable branch...
  
  I'll update the diff to the [0,250] case.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D21607

To: fvogt, #frameworks, broulik
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21379: [UDev Backend] Narrow device queried for

[Kai Uwe Broulik]

broulik added a comment.


  Ping :)
  
  In D21379#472870 , @bruns wrote:
  
  > The question now is, should we also differnentiate here, i.e. map 
`QVariant()` to `nullptr`, and  use `"*"` for wildcards?
  
  
  What do you mean?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven added a comment.


  Any feedback @ngraham ?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21459

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21584: Add LE Advertising and GATT APIs

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  It seems you uploaded only diff with latest changes, you need to upload the 
entire diff against master.

INLINE COMMENTS

> gattapplication.h:47
>   */
> -explicit GattApplication(QObject *parent = nullptr);
> +explicit GattApplication(const QString , QObject 
> *parent = nullptr);
>  

Maybe it would be best to add constructor that uses default object path. Also 
please add better documentation as to what object path prefix is.

`explicit GattApplication(QObject *parent = nullptr);`

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns