D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

[Andreas Sturmlechner]

asturmlechner added a comment.


  This should probably also be posted on release-team ML.

REPOSITORY
  R300 KDEWebKit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21400

To: vkrause, apol, cullmann
Cc: cullmann, apol, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: apol, bruns, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  KAuth action has a setDetail method. This can be used to override the message 
shown in the authentication dialog.
  However, until now none of the backends actually used it. So this patch;
  
  - Overloads setDetail method. The overload accepts details in a QMap.
  - Makes use of the details in polkit1 backend.

REPOSITORY
  R283 KAuth

BRANCH
  arcpatch-D18845

REVISION DETAIL
  https://phabricator.kde.org/D21795

AFFECTED FILES
  autotests/TestBackend.cpp
  autotests/TestBackend.h
  src/AuthBackend.h
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fake/FakeBackend.cpp
  src/backends/fake/FakeBackend.h
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/backends/mac/AuthServicesBackend.cpp
  src/backends/mac/AuthServicesBackend.h
  src/backends/policykit/PolicyKitBackend.cpp
  src/backends/policykit/PolicyKitBackend.h
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h
  src/kauthaction.cpp
  src/kauthaction.h
  src/kauthexecutejob.cpp

To: chinmoyr, apol, bruns, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 56 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/56/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 14 Jun 2019 05:43:33 +
 Build duration:
2 min 55 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(447/2241)17%
(170/996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(147/156)54%
(54/100)src100%
(8/8)100%
(8/8)66%
(216/326)48%
(87/180)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 59774.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=59766&id=59774

BRANCH
  win32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 99 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/99/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 14 Jun 2019 00:11:02 +
 Build duration:
2 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3753/4416)48%
(5210/10891)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1299/1329)49%
(2606/5337)src79%
(23/29)79%
(23/29)79%
(1281/1613)44%
(536/1212)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/105/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 14 Jun 2019 00:11:02 +
 Build duration:
2 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3753/4416)48%
(5210/10891)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1299/1329)49%
(2606/5337)src79%
(23/29)79%
(23/29)79%
(1281/1613)44%
(536/1212)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D20967: [UserMetaData] Add method to query which attributes are set

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:bbb05dfe7f9f: [UserMetaData] Add method to query which 
attributes are set (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20967?vs=59509&id=59773

REVISION DETAIL
  https://phabricator.kde.org/D20967

AFFECTED FILES
  autotests/usermetadatawritertest.cpp
  src/usermetadata.cpp
  src/usermetadata.h
  src/xattr_p.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20967: [UserMetaData] Add method to query which attributes are set

[Stefan Brüns]

bruns added a comment.


  FreeBSD and WIndows folks had their chance to speak up - Windows will just 
have to wait for the CI ...
  FreeBSD has been reviewed, @arrowd - Thanks!

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20967

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21788: Make Plasma::Svg::elementRect a bit leaner

[Aleix Pol Gonzalez]

apol updated this revision to Diff 59772.
apol added a comment.


  Prefer a QRegularExpression to QRegExp

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21788?vs=59746&id=59772

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21788

AFFECTED FILES
  src/plasma/private/svg_p.h
  src/plasma/svg.cpp

To: apol, #plasma, #frameworks
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21790: [PendingFileQueue] Use more accurate calculation of remaining time

[Stefan Brüns]

bruns added a dependent revision: D21791: [PendingFileQueueTest] Shorten 
timeouts, verify tracking time.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21790

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time

[Stefan Brüns]

bruns edited the summary of this revision.
bruns added a dependency: D21790: [PendingFileQueue] Use more accurate 
calculation of remaining time.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21791

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21792: [PendingFileQueue] Refactor for easier and faster unit testing

[Stefan Brüns]

bruns added a dependent revision: D21793: [PendingFileQueueTest] Use synthetic 
timer events to speedup test.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21792

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test

[Stefan Brüns]

bruns edited the summary of this revision.
bruns added a dependency: D21792: [PendingFileQueue] Refactor for easier and 
faster unit testing.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21793

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

[Stefan Brüns]

bruns added a comment.


  In D21709#477608 , @ngraham wrote:
  
  > LGTM, but maybe an autotest might make sense for this case.
  
  
  I have submitted some preliminary changes to make this more feasible. The 
current autotest structure is not really able to catch this (real timers are 
problematic, especially when you try to catch race conditions), and any 
additional test case would add to the test time significantly.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21709

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21793: [PendingFileQueueTest] Use synthetic timer events to speedup test

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Waiting 5 seconds until the pending file queue has been processed slows
  down the tests significantly, instead of waiting for the time to pass
  inject events with appropriate timestamps, the real timer events are
  filtered out. This shortens the runtime from 7.6 to 2.6 seconds.
  
  The first test still uses real timers, to check if the chained triggering
  of the timers from the slots work.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  pendingfilequeue

REVISION DETAIL
  https://phabricator.kde.org/D21793

AFFECTED FILES
  autotests/unit/file/pendingfilequeuetest.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21792: [PendingFileQueue] Refactor for easier and faster unit testing

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Supply the current time as an argument to the slots, so the slots can
  be called with artificial timestamps, decoupling it from the wall time.

TEST PLAN
  ctest -R pendingfilequeuetest

REPOSITORY
  R293 Baloo

BRANCH
  pendingfilequeue

REVISION DETAIL
  https://phabricator.kde.org/D21792

AFFECTED FILES
  src/file/pendingfilequeue.cpp
  src/file/pendingfilequeue.h

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21790: [PendingFileQueue] Use more accurate calculation of remaining time

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  QTime::secsTo completely ignores any fractional (sub-second) part, i.e.
  1.001 to 2.999 is a difference of 1 second, as is 1.999 to 2.001.
  
  This leads to bursts when processing the pending queue, and also makes
  testing more difficult, as the timeouts trigger with a jitter of
  +/- 1 second.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  pendingfilequeue

REVISION DETAIL
  https://phabricator.kde.org/D21790

AFFECTED FILES
  src/file/pendingfilequeue.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21791: [PendingFileQueueTest] Shorten timeouts, verify tracking time

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  There is no need to wait 2 seconds until the file is processed from the
  pending file queue.
  
  Check if the file is removed from the recently emitted queue after the
  set tracking time has elapsed.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  pendingfilequeue

REVISION DETAIL
  https://phabricator.kde.org/D21791

AFFECTED FILES
  autotests/unit/file/pendingfilequeuetest.cpp
  src/file/pendingfilequeue.h

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21788: Make Plasma::Svg::elementRect a bit leaner

[Stefan Brüns]

bruns added a comment.


  Please put the dead code removal in a separate review.

INLINE COMMENTS

> svg.cpp:111
>  const QString contentsAsString(QString::fromLatin1(contents));
> -QRegExp idExpr(QLatin1String("id\\s*=\\s*(['\"])(\\d+-\\d+-.*)\\1"));
> +static QRegExp 
> idExpr(QLatin1String("id\\s*=\\s*(['\"])(\\d+-\\d+-.*)\\1"));
>  idExpr.setMinimal(true);

Please use a QRegularExpression with lazy quantifiers, you can use `const 
static` then, no need for `QRegExp.setMinimal(true)`.
Just replace `*`/`+` with `*?`/`+?`.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21788

To: apol, #plasma, #frameworks
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 59766.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=59765&id=59766

BRANCH
  win32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21656: Create a breeze icon for kfourinline

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Noah Davis]

ndavis added a comment.


  I just tried the patch on my own computer and I noticed a few more things 
that need to be changed:
  
  - The canvas size is 128x128 px when it should be 48x48
  - Strokes need to be converted to paths ( [Ctrl] + [Alt] + [c] ). Strokes 
don't always look correct in various SVG renderers, including the Qt renderer.
  - I see you added a shadow inside the darker blue rim, but while you can do 
that, there also needs to be a 1px high shadow on the very bottom for it to 
match the HIG.
- There are some exceptions, but they are not common (or the icon creator 
and reviewers just forgot ¯\_(ツ)_/¯ ).
  - The top left and bottom right corners are not aligned to the grid:
  
  F6888034: Screenshot_20190613_182219.png 

  F6888038: Screenshot_20190613_182302.png 

  
  Suggestions regarding the colors:
  
  - I think the icon would be more recognizable if the board had a darker color 
instead of a lighter color. The board itself could use a gradient, but I assume 
you're still planning to add that.
  - For the indentations, I think they would look more natural if their colors 
were based on the board's colors rather than the pieces' colors.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 59765.
brute4s99 marked an inline comment as done.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21661?vs=59574&id=59765

BRANCH
  win32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21661

AFFECTED FILES
  src/CMakeLists.txt
  src/knotification.cpp
  src/knotificationmanager.cpp
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 marked 67 inline comments as done.
brute4s99 added a comment.


  updated code incoming. I think I should make a new diff for further 
discussions, as this one is quite riddled with suggestions now. Are there any 
more issues with this patch or should I continue with a new one instead? I'm 
willing to fix it further if you have some suggestions! ✊

INLINE COMMENTS

> nicolasfella wrote in notifybysnore.cpp:44
> This should be documented somewhere else, too. Either the API dox or the KDE 
> wiki

I've added more inline docs for now. @pino if you could guide me on how to 
update the docs on the website, that'd be great! 😃

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Lovely. :)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D15739

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Méven Car]

meven added a dependent revision: D21789: Fix tests relating to the removal of 
the Root Place in D15739.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D15739

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Méven Car]

meven updated this revision to Diff 59751.
meven added a comment.


  - Adapt test to remove Root in the Places by default

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15739?vs=59750&id=59751

BRANCH
  arcpatch-D15739

REVISION DETAIL
  https://phabricator.kde.org/D15739

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: meven, #dolphin, #vdg, tcanabrava, ngraham
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham added a comment.


  <3
  
  Nice huge diff! You see why I had trouble with it, maybe. :) I am very 
impressed that you pulled this off so quickly though!

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D15739

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Méven Car]

meven updated this revision to Diff 59750.
meven added a comment.


  - Adapt test to remove Root in the Places by default

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15739?vs=59749&id=59750

BRANCH
  arcpatch-D15739

REVISION DETAIL
  https://phabricator.kde.org/D15739

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: meven, #dolphin, #vdg, tcanabrava, ngraham
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Méven Car]

meven commandeered this revision.
meven added a reviewer: ngraham.
meven added a comment.


  Taking over this.
  Dolphin test fix patch is coming too.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D15739

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

[Méven Car]

meven updated this revision to Diff 59749.
meven added a comment.
This revision is now accepted and ready to land.


  - Adapt test to remove Root in the Places by default

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15739?vs=42276&id=59749

BRANCH
  arcpatch-D15739

REVISION DETAIL
  https://phabricator.kde.org/D15739

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 132 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/132/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 13 Jun 2019 19:02:44 +
 Build duration:
7 min 12 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_kprotocolinfotestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 122 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/122/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 13 Jun 2019 19:02:43 +
 Build duration:
7 min 41 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/402)66%
(266/402)55%
(33356/61086)39%
(17046/44003)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9400/9856)48%
(4327/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8485/14476)51%
(4705/9233)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4487/8193)41%
(1951/4753)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1206)39%
(370/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4291)36%
(1314/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 132 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/132/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 13 Jun 2019 19:02:44 +
 Build duration:
6 min 29 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report61%
(22/36)64%
(259/402)64%
(259/402)53%
(32573/61062)38%
(16630/44000)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9400/9856)48%
(4327/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8345/14463)50%
(4650/9230)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4485/8193)41%
(1951/4753)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file0%
(0/7)0%
(0/7)0%
(0/1194)0%
(0/952)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4291)36%
(1314/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

D14464: Cancel privilege operation for read-only target with the current user as owner

[Chinmoy Ranjan Pradhan]

chinmoyr closed this revision.
chinmoyr added a comment.


  https://commits.kde.org/kio/14b29cf64611f91f0bc1f5828e4c86392510f0e6

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14464

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14464: Cancel privilege operation for read-only target with the current user as owner

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 59748.
chinmoyr added a comment.


  Updated frameworks version.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14464?vs=38714&id=59748

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14464

AFFECTED FILES
  src/core/global.h
  src/core/job_error.cpp
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D14467#479223 , @ngraham wrote:
  
  > @mgerstner How is this looking now? Yea/nay?
  
  
  He is not available for the next couple of weeks. However he did ask one of 
his colleagues to have a look at it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Nathaniel Graham]

ngraham added a comment.


  Totally awesome :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21788: Make Plasma::Svg::elementRect a bit leaner

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Don't double-access maps
  Don't construct ids more times than necessary.
  Make regular expression static so it's not compiled on every run.
  Remove unused code.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21788

AFFECTED FILES
  src/plasma/private/svg_p.h
  src/plasma/svg.cpp

To: apol, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14467: Auth Support: Drop privileges if target is not owned by root

[Nathaniel Graham]

ngraham added a comment.


  @mgerstner How is this looking now? Yea/nay?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14467

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: mgerstner, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14464: Cancel privilege operation for read-only target with the current user as owner

[Nathaniel Graham]

ngraham added a comment.


  @chinmoyr can you address @dfaure's remaining comments so we can get this in?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14464

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D21782#479190 , @GB_2 wrote:
  
  > I think a KCollapsibleGroupBox would fit here: 
http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/
  
  
  Thanks! I'll give it a shot.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Nathaniel Graham]

ngraham added a comment.


  In D21782#479190 , @GB_2 wrote:
  
  > I think a KCollapsibleGroupBox would fit here: 
http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/
  
  
  +1, this seems like a perfect use of that widget in fact. Dolphin has an 
example in `viewpropertiesdialog.cpp`.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

[David Edmundson]

davidedmundson planned changes to this revision.
davidedmundson added a comment.


  Will make new and improved version

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21618

To: davidedmundson, #plasma, apol
Cc: broulik, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  In D21783#479187 , @ngraham wrote:
  
  > Thanks! Is this for T8075 ?
  
  
  Yes it is.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Björn Feber]

GB_2 added a comment.


  I think a KCollapsibleGroupBox would fit here: 
http://blog.davidedmundson.co.uk/blog/my-new-widget-in-frameworks/

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Nathaniel Graham]

ngraham added a comment.


  Thanks! Is this for T8075 ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 59738.
chinmoyr added a comment.


  Fix typo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=59737&id=59738

BRANCH
  warn

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/usernotificationhandler.cpp
  src/core/usernotificationhandler_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: VDG, Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Currently it uses the dialog from D21782  
to provide the current action being performed, the source file and any
  action specific detail.
  
  F6887442: warningdialog.png 
  
  The initial plan was to show all the files needing elevated privileges but 
due to KIO jobs processing one file at
  a time only limited info could be provided. There's also the option for 
determing this during the stat phase but it
  caused my VM to slow down to a crawl. Any more ideas here?

REPOSITORY
  R241 KIO

BRANCH
  warn

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/core/usernotificationhandler.cpp
  src/core/usernotificationhandler_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21782: Add a warning dialog with details, continue, and cancel button

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: VDG, Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  F6887442: warningdialog.png 

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

AFFECTED FILES
  src/kmessagebox.cpp
  src/kmessagebox.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D15739: [Places panel] Don't show Root by default

[Nathaniel Graham]

ngraham added a comment.


  If you'd like to, I'm more than happy to hand it off. Removing Root is 
trivial, but adjusting the autotest has been a big pain. It explicitly looks 
for Root and I've had a tough time changing it appropriately. I've sunk a 
number of hours into it without success, so if you'd like to take over, please 
feel free.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, tcanabrava
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 116 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/116/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 13 Jun 2019 13:38:53 +
 Build duration:
5 min 31 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13385)18%
(1823/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1579)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 123 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/123/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 13 Jun 2019 13:38:53 +
 Build duration:
4 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13385)18%
(1823/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1579)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 126 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/126/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 13 Jun 2019 13:38:53 +
 Build duration:
2 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21767: Automatically set version of desktopthemes packages to KF5_VERSION

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:eff37abdcbda: Automatically set version of desktopthemes 
packages to KF5_VERSION (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21767?vs=59650&id=59729#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21767?vs=59650&id=59729

REVISION DETAIL
  https://phabricator.kde.org/D21767

AFFECTED FILES
  src/desktoptheme/air/CMakeLists.txt
  src/desktoptheme/air/metadata.desktop
  src/desktoptheme/air/metadata.desktop.cmake
  src/desktoptheme/breeze-dark/CMakeLists.txt
  src/desktoptheme/breeze-dark/metadata.desktop
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-light/CMakeLists.txt
  src/desktoptheme/breeze-light/metadata.desktop
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/CMakeLists.txt
  src/desktoptheme/breeze/metadata.desktop
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/oxygen/CMakeLists.txt
  src/desktoptheme/oxygen/metadata.desktop
  src/desktoptheme/oxygen/metadata.desktop.cmake

To: kossebau, #plasma, ltoscano, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21780: Add X-Flatpak-RenamedFrom as recognized key

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  LGTM.
  
  I do not actually know why we need the type definition to begin with though, 
it occurs to me sycoca could/should just contain all keys it found in the 
desktop file since they get parsed on the KService side later anyway. So, 
limiting the sycoca to defined properties seems a bit cumbersome.
  
  Specifically from an application developer POV I would totally expect that I 
could install a desktop file in some service path and then access arbitrary 
properties via `service->property("X-Foo", QVariant::Int)` which should not 
require any type definitions; until the property() call it doesn't matter what 
the type is. Having to define X-* keys for them to get put in the sycoca seems 
to partially defeat the purpose of X-* entries.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D21780

To: broulik, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21780: Add X-Flatpak-RenamedFrom as recognized key

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Flatpak enforces RDN notation (`com.example.foo.bar`) from appstream and 
flatpakbuilder renames desktop files if neccessary. This key lets us identify 
what the original names were when an app sends e.g. `foobar` as desktop entry 
to us

TEST PLAN
  Used in D21779 

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D21780

AFFECTED FILES
  src/services/application.desktop

To: broulik, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb updated this revision to Diff 59720.
ognarb added a comment.


  Use more round corner.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59707&id=59720

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » attica » kf5-qt5 AndroidQt5.12 - Build # 21 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/21/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Thu, 13 Jun 2019 10:07:22 +
 Build duration:
1 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 137 lines...][2019-06-13T10:08:20.889Z] JOB_URL   = 'https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/'[2019-06-13T10:08:20.889Z] QMAKESPEC = 'android-clang'[2019-06-13T10:08:20.889Z] LANGUAGE  = 'en_US.UTF-8'[2019-06-13T10:08:20.889Z] JOB_BASE_NAME = 'kf5-qt5 AndroidQt5.12'[2019-06-13T10:08:20.889Z] HOME  = '/home/user'[2019-06-13T10:08:20.889Z] USER  = 'user'[2019-06-13T10:08:20.889Z] QT_SELECT = 'qt5'[2019-06-13T10:08:20.889Z] ANDROID_NDK_PLATFORM  = 'android-21'[2019-06-13T10:08:20.889Z] LD_LIBRARY_PATH   = '/opt/Qt/5.12.3/android_armv7/lib:/opt/kdeandroid-deps/lib'[2019-06-13T10:08:20.889Z] ANDROID_NDK   = '/opt/android-ndk'[2019-06-13T10:08:20.889Z] LANG  = 'en_US.UTF-8'[2019-06-13T10:08:20.889Z] ANDROID_HOME  = '/opt/android-sdk'[2019-06-13T10:08:20.889Z] CMAKE_PREFIX_PATH = '/home/user/install-prefix:/opt/Qt/5.12.3/android_armv7:/opt/kdeandroid-deps'[2019-06-13T10:08:20.889Z] QT_PATH   = '/opt/Qt'[2019-06-13T10:08:20.889Z] SHLVL = '1'[2019-06-13T10:08:20.889Z] _ = '/usr/bin/java'[2019-06-13T10:08:20.889Z] OLDPWD= '/home/user'[2019-06-13T10:08:20.889Z] ANDROID_NDK_TOOLCHAIN_PREFIX = 'arm-linux-androideabi'[2019-06-13T10:08:20.889Z] PWD   = '/home/user/workspace/Frameworks/attica/kf5-qt5 AndroidQt5.12'[2019-06-13T10:08:20.889Z] PERSIST   = '1'[2019-06-13T10:08:20.889Z] QMAKEFEATURES = '/opt/Qt/5.12.3/android_armv7/mkspecs/features'[2019-06-13T10:08:20.889Z] STANDALONE_CC = 'clang'[2019-06-13T10:08:20.889Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/21/display/redirect'[2019-06-13T10:08:20.889Z] LOGNAME   = 'user'[2019-06-13T10:08:20.889Z] STAGE_NAME= 'Configuring Build'[2019-06-13T10:08:20.889Z] STANDALONE_CXX= 'clang++'[2019-06-13T10:08:20.889Z] BUILD_DISPLAY_NAME= '#21'[2019-06-13T10:08:20.889Z] DEBIAN_FRONTEND   = 'noninteractive'[2019-06-13T10:08:20.889Z] SHELL = '/bin/sh'[2019-06-13T10:08:20.889Z] WORKSPACE = '/home/user/workspace/Frameworks/attica/kf5-qt5 AndroidQt5.12'[2019-06-13T10:08:20.889Z] JOB_NAME  = 'Frameworks/attica/kf5-qt5 AndroidQt5.12'[2019-06-13T10:08:20.889Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/display/redirect'[2019-06-13T10:08:20.889Z] PKG_CONFIG_PATH   = '/opt/Qt/5.12.3/android_armv7/lib/pkgconfig:/opt/kdeandroid-deps/lib/pkgconfig'[2019-06-13T10:08:20.889Z] [2019-06-13T10:08:20.889Z] [2019-06-13T10:08:20.889Z] == Commencing Configuration:[2019-06-13T10:08:20.889Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.12.3/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks/attica/kf5-qt5 AndroidQt5.12"[2019-06-13T10:08:20.889Z] -- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=[2019-06-13T10:08:20.889Z] -- Android: Targeting API '21' with architecture 'arm', ABI 'armeabi-v7a', and processor 'armv7-a'[2019-06-13T10:08:20.889Z] -- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=[2019-06-13T10:08:20.889Z] -- Android: Selected Clang toolchain 'arm-linux-androideabi-clang' with GCC toolchain 'arm-linux-androideabi-4.9'[2019-06-13T10:08:21.144Z] -- The C compiler identification is Clang 7.0.2[2019-06-13T10:08:21.144Z] -- The CXX compiler identification is Clang 7.0.2[2019-06-13T10:08:21.144Z] -- Check for working C compiler: /opt/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang[2019-06-13T10:08:21.144Z] -- Check for working C compiler: /opt/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -- works[2019-06-13T10:08:21.144Z] -- Detecting C compiler ABI info[2019-06-13T10:08:21.144Z] -- Detecting C compiler ABI info - done[2019-06-13T10:08:21.144Z] -- Detecting C compile features[2019-06-13T10:08:21.399Z] -- Detecting C compile features - done[2019-06-13T10:08:21.399Z] -- Check for working CXX compiler: /opt/android-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++[2019-06-13T10:08:21.399Z] -- Check for working CXX compi

D21778: Add some documentation for PlatformDependent

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:fbda1d799cc1: Add some documentation for 
PlatformDependent (authored by bshah).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21778?vs=59711&id=59712

REVISION DETAIL
  https://phabricator.kde.org/D21778

AFFECTED FILES
  src/platformdependent.h

To: bshah, leinir
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21778: Add some documentation for PlatformDependent

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Looks good :)

REPOSITORY
  R235 Attica

BRANCH
  bshah/docs

REVISION DETAIL
  https://phabricator.kde.org/D21778

To: bshah, leinir
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21778: Add some documentation for PlatformDependent

[Bhushan Shah]

bshah created this revision.
bshah added a reviewer: leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bshah requested review of this revision.

REVISION SUMMARY
  Also add note about deprecating askForCredentials and saveCredentials in
  future.

REPOSITORY
  R235 Attica

BRANCH
  bshah/docs

REVISION DETAIL
  https://phabricator.kde.org/D21778

AFFECTED FILES
  src/platformdependent.h

To: bshah, leinir
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21721#478676 , @ngraham wrote:
  
  > Could the new one be API compatible so we wouldn't need to wait for KF6? 
Also it's always nice to avoid breaking API if you don't have to.
  
  
  Not entirely sure we can do that, the old KNewStuff widgets are quite tightly 
bound to the widget world... It might be possible with a touch of heavy duty 
header wrangling (keeping it abi compatible would be a fair bit of work, though 
not impossible). At the very least, though, i'd like to perhaps do that as a 
sort of... second step after these components have been created. In short: 
Doable, but quite possibly more work than it'd be worth (when compared to 
straight up deprecation-and-porting-guide).

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb updated this revision to Diff 59707.
ognarb added a comment.


  Change color of some points

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59706&id=59707

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb updated this revision to Diff 59706.
ognarb added a comment.


  Still works in progress (need to add the gradiend) but some improvement

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59372&id=59706

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21618: Allow QtQuick applets and wallpapers to defer UiReadyConstraint

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> appletinterface.cpp:172
>  
> -applet()->updateConstraints(Plasma::Types::UiReadyConstraint);
> +if (m_loadingRef == 0) {
> +applet()->updateConstraints(Plasma::Types::UiReadyConstraint);

In my case this code path is hit before any of the QML property assignments or 
`Component.onCompletd` are executed. I don't really understand why given 
`AppletQuickItem::init()` does `forceCompletion()`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21618

To: davidedmundson, #plasma, apol
Cc: broulik, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns