D21204: Ensure no trailing slash in mountpoint read from fstab file.

[Méven Car]

meven added a comment.


  How do you like this alternative @bruns ?
  The upside is that is fixes the bug and does not change stored data and keeps 
compatibility.
  The downside is that it is a little hackish.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[Chinmoy Ranjan Pradhan]

chinmoyr planned changes to this revision.
chinmoyr added a comment.


  TODO
  
  - Change the UI of the warning dialog
  - We still need more details

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Pino Toscano]

pino added a comment.


  In D21661#479366 , @brute4s99 
wrote:
  
  > I think I should make a new diff for further discussions, as this one is 
quite riddled with suggestions now. Are there any more issues with this patch 
or should I continue with a new one instead?
  
  
  Please do not drop this opening a new one, otherwise the whole discussion is 
basically killed...

INLINE COMMENTS

> CMakeLists.txt:49
> +  find_package(Qt5Network REQUIRED)
> +  find_package(Qt5XmlPatterns REQUIRED)
> +  list(APPEND knotifications_SRCS notifybysnore.cpp)

what do you need XmlPatterns for?

> CMakeLists.txt:51
> +  list(APPEND knotifications_SRCS notifybysnore.cpp)
> +  endif ()
> +

this is indented too much

> notifybysnore.cpp:80
> +const auto index = str.indexOf(QLatin1Char('='));
> +map.insert(str.toString().mid(0, index), str.mid(index + 1));
> +}

instead of getting the real QString of `str` and then get a substring of it, 
first get the substring(ref) and then get the real QString of it

> notifybysnore.cpp:83
> +const auto action = map[QStringLiteral("action")].toString();
> +const auto id = 
> map[QStringLiteral("notificationId")].toString().toInt();
> +KNotification *notification;

QStringRef has toInt()

> notifybysnore.cpp:84
> +const auto id = 
> map[QStringLiteral("notificationId")].toString().toInt();
> +KNotification *notification;
> +const auto it = m_notifications.constFind(id);

if the notification is not found, this will be an uninitialized pointer; TBH if 
the search for the notification with the specified id fails, then it should be 
better to return earlier, as it means the notification is unknown

> notifybysnore.cpp:92
> +const auto snoreAction = SnoreToastActions::getAction(waction);
> +// MSVC2019 has issues with QString::toStdWString()
> +

please document what is the issue, so in the future the workaround can be 
dropped

> notifybysnore.cpp:139-140
> +if (m_notifications.constFind(notification->id()) != 
> m_notifications.constEnd()) {
> +qCDebug(LOG_KNOTIFICATIONS) << "Duplicate notification with ID: 
> " << notification->id() << " ignored.";
> +return;
> +}

they are indented too much

> notifybysnore.cpp:168-171
> +if (!proc->waitForStarted()) {
> +} else {
> +finish(notification);
> +}

the logic here is swapped: if `waitForStarted()` returns false, that means the 
process did not start successfully; also, after `finish()` you must return 
earlier (do not forget to delete the process), otherwise the rest of the code 
does things as if the process run fine

> notifybysnore.cpp:178-179
> +if (exitStatus == QProcess::NormalExit) {
> +QFile::remove(QString(iconDir.path() + QLatin1Char('/') 
> ++ QString::number(notification->id()) + 
> QStringLiteral(".png")));
> +} else {

the removal ought to be done no matter the exit status of the process: the 
process exited, so image for it is no more needed

> notifybysnore.cpp:200-202
> +if (it.value()) {
> +finish(it.value());
> +}

no need to use `it` here, you already have the `notification` parameter...

> brute4s99 wrote in notifybysnore.cpp:44
> I've added more inline docs for now. @pino if you could guide me on how to 
> update the docs on the website, that'd be great! 😃

> if you could guide me on how to update the docs on the website, that'd be 
> great!

which website?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21661: add snoretoast backend for KNotifications on Windows

[Pino Toscano]

pino added a comment.


  Ah, one last thing I apparently forgot to mention so far: the names of class 
variables must start with `m_`.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21711: Julia: update syntax and add constants keywords

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c91c2554215d: Julia: update syntax and add constants 
keywords (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21711?vs=59476&id=59854

REVISION DETAIL
  https://phabricator.kde.org/D21711

AFFECTED FILES
  autotests/folding/test.jl.fold
  autotests/html/test.jl.html
  autotests/input/test.jl
  autotests/reference/test.jl.ref
  data/syntax/julia.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21712: KateModeMenuList: move to QListView

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21712

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
bruns, demsking, cullmann, sars, dhaumann

D21661: add snoretoast backend for KNotifications on Windows

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> notifybysnore.cpp:72
> +sock->deleteLater();
> +sock->close();
> +const QString data =

deleteLater should also close the socket.
Also don't use a pointer after you deleted it, even with a deleteLater.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

[Albert Vaca Cintora]

albertvaka added a comment.


  If I understand correctly, the only reason to use KContacts here is so we can 
use its PhoneNumber type. We could change it to a QString?

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D21369

To: sredman, apol
Cc: albertvaka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:9b0ecc5d41b0: [PendingFileQueue] Avoid delete + create / 
create + delete race (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21709?vs=59473&id=59867#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21709?vs=59473&id=59867

REVISION DETAIL
  https://phabricator.kde.org/D21709

AFFECTED FILES
  src/file/pendingfile.cpp
  src/file/pendingfilequeue.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21807: [PendingFileQueueTest] Verify delete + create actually works

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:309518239d77: [PendingFileQueueTest] Verify delete + 
create actually works (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21807?vs=59827&id=59868

REVISION DETAIL
  https://phabricator.kde.org/D21807

AFFECTED FILES
  autotests/unit/file/pendingfilequeuetest.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21809: [PendingFileQueueTest] Verify create + delete do not emit extra events

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:bb011d2fc034: [PendingFileQueueTest] Verify create + 
delete do not emit extra events (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21809?vs=59828&id=59869

REVISION DETAIL
  https://phabricator.kde.org/D21809

AFFECTED FILES
  autotests/unit/file/pendingfilequeuetest.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Format the photo exposure bias value in EV units
  and in steps of thirds when applicable
  
  CCBUG: 343273

REPOSITORY
  R286 KFileMetaData

BRANCH
  exposure_bias

REVISION DETAIL
  https://phabricator.kde.org/D21830

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich added a comment.


  exposure bias seems mostly to be in steps of 1/3 according to 
https://www.geofflawrence.com/exposure_compensation.html

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich added a comment.


  ping! this now tests the resulting document and tests how the different data 
types are added to it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Stefan Brüns]

bruns added a comment.


  Many cameras can be switched to 1/2 EV steps.

INLINE COMMENTS

> formatstrings.cpp:189
> +int wholeNumber = roundedThirds / 3;
> +if (wholeNumber > 0) {
> +return i18nc("Exposure compensation given in thirds, with whole 
> number, in exposure value (EV)", "%1 %2/3 EV", locale.toString(wholeNumber), 
> locale.toString(remainder));

this is probably not working for e.g.  "-1 1/3"

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich added a comment.


  In D21830#480181 , @bruns wrote:
  
  > Many cameras can be switched to 1/2 EV steps.
  
  
  Damn ;) do you know any other values? In case not, I would add this case in a 
loop and stupidly try everything

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Stefan Brüns]

bruns added a comment.


  In D21830#480185 , @astippich 
wrote:
  
  > In D21830#480181 , @bruns wrote:
  >
  > > Many cameras can be switched to 1/2 EV steps.
  >
  >
  > Damn ;) do you know any other values? In case not, I would add this case in 
a loop and stupidly try everything
  
  
  I think with 1/2 and 1/3 you have covered 99.9% of the cameras.
  
  You can quantize to 1/6, and if the fractional part is in {2,3,4}, use the 
"%1 %2/%3" format.
  
  To avoid the `if() { if() { if() { }}}` cascade, you may use a nested 
function (lambda) for the default case (format as double), and do an early 
return.
  
  How about integral/fractional instead of wholeNumber/remainder?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> formatstrings.cpp:183
> +auto val = value.toDouble();
> +// exposure values are in steps of one third, divide by it
> +auto thirds = val * 3;

You obviously multiply here ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in formatstrings.cpp:183
> You obviously multiply here ...

dividing by one third is multiplying by three :)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich updated this revision to Diff 59873.
astippich added a comment.


  - cover 1/2 case

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21830?vs=59870&id=59873

BRANCH
  exposure_bias

REVISION DETAIL
  https://phabricator.kde.org/D21830

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich marked an inline comment as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich updated this revision to Diff 59874.
astippich added a comment.


  - remove unneeded newline

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21830?vs=59873&id=59874

BRANCH
  exposure_bias

REVISION DETAIL
  https://phabricator.kde.org/D21830

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21830: Format photo exposure bias value

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> formatstrings.cpp:193
> +return i18nc("Exposure bias/compensation in exposure value (EV)", 
> "%1 EV", locale.toString(val, 'g', 3));
> +} else {
> +int integral = roundedSixthParts / 6;

no need for else here, you return. dito below

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D21830

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

[Aleix Pol Gonzalez]

apol added a comment.


  In D21369#480148 , @albertvaka 
wrote:
  
  > If I understand correctly, the only reason to use KContacts here is so we 
can use its PhoneNumber type. We could change it to a QString?
  
  
  It is a string now, the advantage of using the PhoneNumber class is that it 
has some extra metadata with it (e.g. that you get to know if it's a work or 
home phone number).

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D21369

To: sredman, apol
Cc: albertvaka, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21830: Format photo exposure bias value

[Alexander Stippich]

astippich updated this revision to Diff 59875.
astippich added a comment.


  - remove unnecessary else

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21830?vs=59874&id=59875

BRANCH
  exposure_bias

REVISION DETAIL
  https://phabricator.kde.org/D21830

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21661: add snoretoast backend for KNotifications on Windows

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> pino wrote in notifybysnore.cpp:92
> please document what is the issue, so in the future the workaround can be 
> dropped

I can't put my finger on it I can only tell that 
https://github.com/KDE/snoretoast/blob/a53a6b733624ada78ef0f852407cad4be1c00b16/examples/qt/main.cpp#L58
 produces a corrupted string.
Runs fine with msvc2017.
I tried to create a minimal example https://invent.kde.org/snippets/253 but 
this one works fine..

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 108 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/108/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 15 Jun 2019 14:24:54 +
 Build duration:
3 min 50 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.60.0.xmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3753/4416)48%
(5210/10891)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1299/1329)49%
(2606/5337)src79%
(23/29)79%
(23/29)79%
(1281/1613)44%
(536/1212)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 102 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/102/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 15 Jun 2019 14:24:54 +
 Build duration:
3 min 55 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3753/4416)48%
(5210/10891)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1299/1329)49%
(2606/5337)src79%
(23/29)79%
(23/29)79%
(1281/1613)44%
(536/1212)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 70 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/70/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Jun 2019 05:23:56 +
 Build duration:
3 days 10 hr and counting

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 170 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/170/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 12 Jun 2019 18:16:47 +
 Build duration:
2 days 22 hr and counting
   CONSOLE OUTPUT
  [...truncated 303 lines...][2019-06-15T16:18:37.635Z] [2019-06-15T16:18:37.635Z] -- The following RUNTIME packages have not been found:[2019-06-15T16:18:37.635Z] [2019-06-15T16:18:37.635Z]  * CatDoc, catdoc executable, [2019-06-15T16:18:37.635Z]Extract text from office 98 files - RUNTIME dependency[2019-06-15T16:18:37.635Z] [2019-06-15T16:18:37.635Z] -- The following OPTIONAL packages have not been found:[2019-06-15T16:18:37.635Z] [2019-06-15T16:18:37.635Z]  * KF5Config (required version >= 5.59.0), KDE Frameworks 5: Config Framework, [2019-06-15T16:18:37.635Z]Config is needed to build the AppImage extractor[2019-06-15T16:18:37.635Z]  * Poppler (required version >= 0.12.1), A PDF rendering library, [2019-06-15T16:18:37.635Z]Support for PDF files[2019-06-15T16:18:37.635Z]  * FFmpeg (required version >= 55.27), Video Tag reader, [2019-06-15T16:18:37.635Z]Support for video metadata[2019-06-15T16:18:37.635Z]  * EPub, Ebook epub reader, [2019-06-15T16:18:37.635Z]Support for epub metadata[2019-06-15T16:18:37.635Z]  * libappimage (required version >= 0.1.10), Core library of the AppImage project, [2019-06-15T16:18:37.635Z]Needed to build the AppImage extractor[2019-06-15T16:18:37.635Z] [2019-06-15T16:18:37.635Z] -- Configuring done[2019-06-15T16:18:39.559Z] -- Generating done[2019-06-15T16:18:39.559Z] -- Build files have been written to: C:/CI/workspace/Frameworks/kfilemetadata/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-06-15T16:18:40.155Z] [2019-06-15T16:18:40.155Z] C:\CI\workspace\Frameworks\kfilemetadata\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-06-15T16:18:40.418Z] **[2019-06-15T16:18:40.418Z] ** Visual Studio 2019 Developer Command Prompt v16.0.3[2019-06-15T16:18:40.418Z] ** Copyright (c) 2019 Microsoft Corporation[2019-06-15T16:18:40.418Z] **[2019-06-15T16:18:41.802Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-06-15T16:18:42.382Z] [2019-06-15T16:18:42.382Z] jom 1.1.2 - empower your cores[2019-06-15T16:18:42.382Z] [2019-06-15T16:18:42.648Z] jom: parallel job execution disabled for Makefile[2019-06-15T16:18:42.648Z] Scanning dependencies of target KF5FileMetaData_QCH[2019-06-15T16:18:42.648Z] Scanning dependencies of target KF5FileMetaData_autogen[2019-06-15T16:18:42.648Z] [  1%] Automatic MOC for target KF5FileMetaData[2019-06-15T16:18:43.240Z] [  1%] Built target KF5FileMetaData_autogen[2019-06-15T16:18:43.240Z] [  0%] Generating src/KF5FileMetaData.qch, src/KF5FileMetaData.tags[2019-06-15T16:18:43.822Z] Scanning dependencies of target KF5FileMetaData[2019-06-15T16:18:47.289Z] [  8%] Built target KF5FileMetaData_QCH[2019-06-15T16:18:47.289Z] [  1%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/extractionresult.cpp.obj[2019-06-15T16:18:47.289Z] [  2%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/simpleextractionresult.cpp.obj[2019-06-15T16:18:47.289Z] extractionresult.cpp[2019-06-15T16:18:47.289Z] [  3%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/extractor.cpp.obj[2019-06-15T16:18:47.289Z] [  3%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/extractorplugin.cpp.obj[2019-06-15T16:18:47.289Z] [  4%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/extractorcollection.cpp.obj[2019-06-15T16:18:47.289Z] [  5%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/externalextractor.cpp.obj[2019-06-15T16:18:47.289Z] [  5%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/propertyinfo.cpp.obj[2019-06-15T16:18:47.289Z] [  7%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/typeinfo.cpp.obj[2019-06-15T16:18:47.289Z] [  8%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/usermetadata.cpp.obj[2019-06-15T16:18:47.289Z] [  8%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/writedata.cpp.obj[2019-06-15T16:18:47.289Z] [  8%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/writer.cpp.obj[2019-06-15T16:18:47.586Z] [  9%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/writerplugin.cpp.obj[2019-06-15T16:18:49.692Z] simpleextractionresult.cpp[2019-06-15T16:18:49.692Z] extractor.cpp[2019-06-15T16:18:49.692Z] extractorplugin.cpp[2019-06-15T16:18:49.692Z] extractorcollection.cpp[2019-06-15T16:18:49.692Z] externalextractor.cpp[2019-06-15T16:18:49.692Z] propertyinfo.cpp[2019-06-15T16:18:49.692Z] typeinfo.cpp[2019-06-15T16:18:49.692Z] usermetadata.cpp[2019-06-15T16:18:49.692Z] writedata.cpp[

D21661: add snoretoast backend for KNotifications on Windows

[Shubham]

shubham added inline comments.

INLINE COMMENTS

> notifybysnore.h:44
> +QHash> m_notifications;
> +QString program = QStringLiteral("SnoreToast.exe");
> +QLocalServer server;

I doubt this compiles...You can't initialise variables inside the class

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: shubham, nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D17241: WIP:Disable highlighting after 512 characters on a line.

[Kåre Särs]

sars added a comment.


  I tried the patch and it improved the performance really much! :) I was able 
to edit a line that contained over a million characters!
  
  Unfortunately I can't comment on the code too much, as I don't know the code 
enough.
  
  Some general stuff:
  
  1. Should there be a warning/information-message about why the highlighting 
is disabled?
  2. Should the line length limit be increased?
  
  Great work!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: cullmann, vkrause, dhaumann, mwolff, sars
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The positions() method is only used inside the PhraseAndIterator and
  requires either a VectorPositionInfoIterator or a DBPositionIterator,
  as these are the only ones reimplementing the positions() method.
  
  Actually, VectorPositionInfoIterator and DBPositionIterator have
  identical implementations, save the constructor argument. The conversion
  of the constructor argument can be trivially inlined and DBPositionIterator
  can be removed completely.
  
  This indirectly improves the test coverage (VectorPositionInfoIterator is
  used in the PhraseAndIteratorTest) and removes duplicate code.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21835

AFFECTED FILES
  autotests/unit/engine/phraseanditeratortest.cpp
  autotests/unit/engine/positiondbtest.cpp
  src/engine/phraseanditerator.cpp
  src/engine/phraseanditerator.h
  src/engine/positiondb.cpp
  src/engine/positiondb.h
  src/engine/postingiterator.cpp
  src/engine/postingiterator.h
  src/engine/transaction.cpp
  src/engine/vectorpositioninfoiterator.cpp
  src/engine/vectorpositioninfoiterator.h

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 171 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/171/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 15 Jun 2019 16:18:58 +
 Build duration:
3 hr 17 min and counting
   CONSOLE OUTPUT
  [...truncated 298 lines...][2019-06-15T19:36:25.373Z]  * KF5I18n (required version >= 5.59.0)[2019-06-15T19:36:25.373Z]  * KF5 (required version >= 5.59.0)[2019-06-15T19:36:25.373Z]  * Doxygen (required version >= 1.8.13)[2019-06-15T19:36:25.373Z]Needed for API dox QCH file generation[2019-06-15T19:36:25.373Z]  * QHelpGenerator, Part of Qt5 tools[2019-06-15T19:36:25.373Z]Needed for API dox QCH file generation[2019-06-15T19:36:25.373Z]  * Qt5Test[2019-06-15T19:36:25.373Z]  * Qt5 (required version >= 5.10.0)[2019-06-15T19:36:25.373Z] [2019-06-15T19:36:25.373Z] -- The following RUNTIME packages have not been found:[2019-06-15T19:36:25.373Z] [2019-06-15T19:36:25.373Z]  * CatDoc, catdoc executable, [2019-06-15T19:36:25.373Z]Extract text from office 98 files - RUNTIME dependency[2019-06-15T19:36:25.373Z] [2019-06-15T19:36:25.373Z] -- The following OPTIONAL packages have not been found:[2019-06-15T19:36:25.373Z] [2019-06-15T19:36:25.373Z]  * KF5Config (required version >= 5.59.0), KDE Frameworks 5: Config Framework, [2019-06-15T19:36:25.373Z]Config is needed to build the AppImage extractor[2019-06-15T19:36:25.373Z]  * Poppler (required version >= 0.12.1), A PDF rendering library, [2019-06-15T19:36:25.373Z]Support for PDF files[2019-06-15T19:36:25.373Z]  * FFmpeg (required version >= 55.27), Video Tag reader, [2019-06-15T19:36:25.373Z]Support for video metadata[2019-06-15T19:36:25.373Z]  * EPub, Ebook epub reader, [2019-06-15T19:36:25.373Z]Support for epub metadata[2019-06-15T19:36:25.373Z]  * libappimage (required version >= 0.1.10), Core library of the AppImage project, [2019-06-15T19:36:25.373Z]Needed to build the AppImage extractor[2019-06-15T19:36:25.373Z] [2019-06-15T19:36:25.373Z] -- Configuring done[2019-06-15T19:36:27.270Z] -- Generating done[2019-06-15T19:36:27.270Z] -- Build files have been written to: C:/CI/workspace/Frameworks/kfilemetadata/kf5-qt5 WindowsMSVCQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-06-15T19:36:31.411Z] [2019-06-15T19:36:31.411Z] C:\CI\workspace\Frameworks\kfilemetadata\kf5-qt5 WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-06-15T19:36:31.411Z] **[2019-06-15T19:36:31.411Z] ** Visual Studio 2019 Developer Command Prompt v16.0.3[2019-06-15T19:36:31.411Z] ** Copyright (c) 2019 Microsoft Corporation[2019-06-15T19:36:31.411Z] **[2019-06-15T19:36:32.805Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-06-15T19:36:32.805Z] [2019-06-15T19:36:32.805Z] jom 1.1.2 - empower your cores[2019-06-15T19:36:32.805Z] [2019-06-15T19:36:32.805Z] jom: parallel job execution disabled for Makefile[2019-06-15T19:36:32.805Z] Scanning dependencies of target KF5FileMetaData_autogen[2019-06-15T19:36:33.063Z] Scanning dependencies of target KF5FileMetaData_QCH[2019-06-15T19:36:33.063Z] [  1%] Automatic MOC for target KF5FileMetaData[2019-06-15T19:36:33.063Z] [  1%] Built target KF5FileMetaData_autogen[2019-06-15T19:36:33.063Z] [  1%] Generating src/KF5FileMetaData.qch, src/KF5FileMetaData.tags[2019-06-15T19:36:33.322Z] Scanning dependencies of target KF5FileMetaData[2019-06-15T19:36:34.261Z] [  8%] Built target KF5FileMetaData_QCH[2019-06-15T19:36:34.261Z] [  1%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/extractionresult.cpp.obj[2019-06-15T19:36:34.261Z] [  2%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/simpleextractionresult.cpp.obj[2019-06-15T19:36:34.261Z] [  5%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/extractor.cpp.obj[2019-06-15T19:36:34.261Z] [  3%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/extractorplugin.cpp.obj[2019-06-15T19:36:34.261Z] [  4%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/extractorcollection.cpp.obj[2019-06-15T19:36:34.261Z] [  5%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/externalextractor.cpp.obj[2019-06-15T19:36:34.261Z] extractionresult.cpp[2019-06-15T19:36:34.261Z] [  4%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/propertyinfo.cpp.obj[2019-06-15T19:36:34.261Z] [  6%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/typeinfo.cpp.obj[2019-06-15T19:36:34.261Z] [  8%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/usermetadata.cpp.obj[2019-06-15T19:36:34.261Z] [  8%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/writer.cpp.obj[2019-06-15T19:36:34.261Z] [  9%] Building CXX object src/CMakeFiles/KF5FileMetaData.dir/writerplugin.cpp.obj[2019-06-15T19:36:

D21661: add snoretoast backend for KNotifications on Windows

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> shubham wrote in notifybysnore.h:44
> I doubt this compiles...You can't initialise variables inside the class

Have you heard  of this new c++ standard? C++11?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: shubham, nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D17241: WIP:Disable highlighting after 512 characters on a line.

[Christoph Cullmann]

cullmann added a comment.


  I am not sure about the warning.
  The line length limit default should be increased it think, we could just try 
something like 1 for a start.
  I would propose we try this without a warning and see if we get negative 
feedback.
  Normally this should only kick in situations were before we slowed down to 
"unusable".
  Would that be ok?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: cullmann, vkrause, dhaumann, mwolff, sars
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20967: [UserMetaData] Add method to query which attributes are set

[Ben Cooksley]

bcooksley added a comment.


  This change has unfortunately made MSVC unhappy - 
https://build.kde.org/view/Failing/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/lastFailedBuild/

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20967

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: bcooksley, arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D21313: Create specific directory for Qt logging categories file

[Ben Cooksley]

bcooksley added a comment.


  This change appears to be responsible for all Android builds being broken.
  See https://build.kde.org/view/Failing/
  
  Could someone take a look please?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: bcooksley, kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
bencreasy, michaelh, ngraham, bruns

D20967: [UserMetaData] Add method to query which attributes are set

[Stefan Brüns]

bruns added a comment.


  #windows  - thanks for ignoring 
every review request!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20967

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: bcooksley, arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17241: WIP:Disable highlighting after 512 characters on a line.

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.


  +1

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: cullmann, vkrause, dhaumann, mwolff, sars
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D20967: [UserMetaData] Add method to query which attributes are set

[Ben Cooksley]

bcooksley added a comment.


  Please note that there are very few people involved with Windows builds 
(despite the number of projects that make use of them in general) so people may 
not always have the ability to respond to every review request.
  That is why the CI system monitors the state of code and can catch issues as 
they happen.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20967

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: bcooksley, arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D19498: loadLibrary: Use enum values to define what type of plugin we load

[Alexander Potashev]

aspotashev added a reviewer: Frameworks.

REPOSITORY
  R317 Kross

REVISION DETAIL
  https://phabricator.kde.org/D19498

To: aspotashev, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20967: [UserMetaData] Add method to query which attributes are set

[Stefan Brüns]

bruns added a comment.


  In D20967#480338 , @bcooksley 
wrote:
  
  > Please note that there are very few people involved with Windows builds 
(despite the number of projects that make use of them in general) so people may 
not always have the ability to respond to every review request.
  >  That is why the CI system monitors the state of code and can catch issues 
as they happen.
  
  
  If there are OS specific changes, and they are added to the subscribers list, 
they damn should. The CI catches some errors, but not everything.
  
  Also, this code is not covered by the unit tests on Windows, so even when the 
CI shows green this just means it compiles.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20967

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: bcooksley, arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » karchive » kf5-qt5 AndroidQt5.12 - Build # 53 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20AndroidQt5.12/53/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sat, 15 Jun 2019 23:43:09 +
 Build duration:
17 min and counting

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.12 - Build # 15 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.12/15/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:22 +
 Build duration:
1 min 44 sec and counting

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.12 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.12/24/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:24 +
 Build duration:
2 min 5 sec and counting

KDE CI: Frameworks » syndication » kf5-qt5 AndroidQt5.12 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20AndroidQt5.12/10/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:22 +
 Build duration:
1 min 58 sec and counting

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.12 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.12/24/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:23 +
 Build duration:
1 min 56 sec and counting

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.12 - Build # 40 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.12/40/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:27 +
 Build duration:
2 min 49 sec and counting

KDE CI: Frameworks » attica » kf5-qt5 AndroidQt5.12 - Build # 22 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/22/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:29 +
 Build duration:
4 min 35 sec and counting

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.12 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.12/18/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:25 +
 Build duration:
4 min 52 sec and counting

KDE CI: Frameworks » kcodecs » kf5-qt5 AndroidQt5.12 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20AndroidQt5.12/17/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:28 +
 Build duration:
5 min 2 sec and counting

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 32 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/32/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:25 +
 Build duration:
5 min 43 sec and counting

KDE CI: Frameworks » kitemmodels » kf5-qt5 AndroidQt5.12 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20AndroidQt5.12/12/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Sun, 16 Jun 2019 00:03:26 +
 Build duration:
6 min 14 sec and counting

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  All users of TermGenerator::termList do not use QStrings but UTF-8
  ByteArrays. Remove repetitive code.
  
  While at it, make the lists const to avoid detach on iteration.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D21839

AFFECTED FILES
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21313: Create specific directory for Qt logging categories file

[Friedrich W. H. Kossebau]

kossebau added subscribers: vkrause, apol.
kossebau added a comment.


  In D21313#480332 , @bcooksley 
wrote:
  
  > This change appears to be responsible for all Android builds being broken.
  >  See https://build.kde.org/view/Failing/
  >
  > Could someone take a look please?
  
  
  Seems the cause of the build failures is that with the Android builds **not** 
the ECM from the product builds or dep builds is picked up, **but** only the 
ECM as deployed as part of the SDK.
  At least this is what looking at the age of the different builds on CI of the 
ECM product, the dep set and the SDK showed (where SDK was older than this 
change, everything else newer). 
  And triggering a fresh build of the SDK made the builds of the Framework 
builds no longer fail.
  So no issue with this patch, but the Android build setup it seems.
  
  @apol @vkrause Perhaps something to check wit hthe CI or in general to make 
sure the ECM of the host and the target are not accidentally mixed or both 
visible at the same time.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: apol, vkrause, bcooksley, kossebau, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 172 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/172/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 16 Jun 2019 00:34:37 +
 Build duration:
3 min 50 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: projectroot.autotests.externalextractortestFailed: projectroot.autotests.externalwritertest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/109/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 16 Jun 2019 00:34:37 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.60.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3753/4416)48%
(5210/10891)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1299/1329)49%
(2606/5337)src79%
(23/29)79%
(23/29)79%
(1281/1613)44%
(536/1212)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 103 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/103/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 16 Jun 2019 00:34:37 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.60.0.xmllogs/KF5FileMetaData/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3753/4416)48%
(5210/10891)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1299/1329)49%
(2606/5337)src79%
(23/29)79%
(23/29)79%
(1281/1613)44%
(536/1212)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)