D13425: File indexer closing improvements.

[James Smith]

smithjd abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien, #baloo, poboiko
Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, LeGast00n, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 127 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/127/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 17 Jun 2019 00:18:32 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.file.filewatchtest

D21866: [TermGenerator] Leave single term phrases out of the PositionDB

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:1a573d5fe373: [TermGenerator] Leave single term phrases 
out of the PositionDB (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21866?vs=59967&id=59969

REVISION DETAIL
  https://phabricator.kde.org/D21866

AFFECTED FILES
  src/engine/termgenerator.cpp
  src/engine/transaction.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21866: [TermGenerator] Leave single term phrases out of the PositionDB

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21866

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21865: [TermGenerator] Do Term truncation prior to UTF-8 conversion

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:a99bb98143c6: [TermGenerator] Do Term truncation prior to 
UTF-8 conversion (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21865?vs=59964&id=59968

REVISION DETAIL
  https://phabricator.kde.org/D21865

AFFECTED FILES
  src/engine/termgenerator.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21866: [TermGenerator] Leave single term phrases out of the PositionDB

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Any search phrase consisting of a single term only can be handled by
  the PostingDB alone, and a document with single terms can never match
  a real phrase (consisting a multiple terms).
  
  Storing these terms also in the PositonDB just wastes space, so remove
  these from the DB, and delegate single term phrases to the PostingDB.
  
  While the document content and even filenames (basename + suffix) consist
  of multiple terms typically, folder names, tags and properties are often
  a single term.

TEST PLAN
  ctest
  ctest -R querytest

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21866

AFFECTED FILES
  src/engine/termgenerator.cpp
  src/engine/transaction.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21865: [TermGenerator] Do Term truncation prior to UTF-8 conversion

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  phrasestorage_fixes

REVISION DETAIL
  https://phabricator.kde.org/D21865

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

[Stefan Brüns]

bruns added a comment.


  In D21855#480992 , @thiago wrote:
  
  > Alternative: return (quint64(devId) << 32) | inode;
  >
  > Not endian-dependent, like the memcpy solution. Make sure the other side is 
adapted to match.
  
  
  Thats the problem here - the "other side" is an ondisk DB ...
  
  But removing devId from the ID and just keeping inode is on the todo list, we 
are asking for trouble here anyway in case of 64bit inodes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21855

To: bruns, #baloo, ngraham, astippich, poboiko, thiago
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

[Thiago Macieira]

thiago added a comment.


  Alternative: return (quint64(devId) << 32) | inode;
  
  Not endian-dependent, like the memcpy solution. Make sure the other side is 
adapted to match.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21855

To: bruns, #baloo, ngraham, astippich, poboiko, thiago
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

[Stefan Brüns]

bruns added a comment.


  In D21855#480990 , @thiago wrote:
  
  > +1
  
  
  Thx for the confirmation!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21855

To: bruns, #baloo, ngraham, astippich, poboiko, thiago
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

[Thiago Macieira]

thiago added a comment.


  +1

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21855

To: bruns, #baloo, ngraham, astippich, poboiko, thiago
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

[Stefan Brüns]

bruns added a comment.


  In D21839#480777 , @poboiko wrote:
  
  > > As the limit is somewhat arbitrary, maybe we can just limit the QString? 
I don't think this has any serious side effects.
  >
  > Yep, that's what I've suggested (if I understood you correctly).
  >  I guess, we can put the trimming part right to `termList()`, it will 
further reduce code repetition. Something like
  >
  >   str = str.left(maxTermSize); 
  >   list << str.toUtf8();
  >
  
  
  See D21865 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21839

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21865: [TermGenerator] Do Term truncation prior to UTF-8 conversion

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The (somewhat arbitrary) term truncation was applied to the UTF-8 encoded
  data, somethimes truncating the term in the middle of a codepoint.
  
  Truncate the QString instead. This also has the effect of leaving more
  useful characters for languages where the majority of codepoints are
  encoded as 2 or more bytes.
  
  This requires some extra storage size in the DB when a term which would
  have been truncated previously now goes in as is, but likely only a few
  terms / languages are affected (for english words UTF-8 encodes most
  codepoints in 1 byte).
  
  There is a small caveat for the SearchStore. As queries were truncated
  likewise, an untruncated query would no longer find untruncated terms from
  new index runs. To allow matches nevertheless, truncated terms use
  StartsWith instead of Equal matches.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  phrasestorage_fixes

REVISION DETAIL
  https://phabricator.kde.org/D21865

AFFECTED FILES
  src/engine/termgenerator.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21864: [QueryTest] Test if independent phrases are really independent

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Tags (and KFileMetaData properties) call TermGenerator::inxedXattrText
  (respectively TermGenerator::indexText) multiple times if there are
  several tags for a file or multiple values for one property.
  
  In case there are the tags "Two", "Three" and "Two-Three", querying
  "Two-Three" should not yield files which just have the "Two" and "Three"
  tags set.
  
  Depends on D21862 , D21863 


TEST PLAN
  ctest -R querytest

REPOSITORY
  R293 Baloo

BRANCH
  phrasestorage_fixes

REVISION DETAIL
  https://phabricator.kde.org/D21864

AFFECTED FILES
  autotests/integration/querytest.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21863: [TermGenerator] Insert an empty position between independent terms

[Stefan Brüns]

bruns added a dependent revision: D21864: [QueryTest] Test if independent 
phrases are really independent.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21863

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21862: [QueryTest] Restructure tests to allow easier extension

[Stefan Brüns]

bruns added a dependent revision: D21864: [QueryTest] Test if independent 
phrases are really independent.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21862

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21863: [TermGenerator] Insert an empty position between independent terms

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Terms of a phrase have adjacent positions, but independent terms/phrases
  should be spaced apart to not treat these as phrases.

TEST PLAN
  ctest -R querytest
  (after D21864)

REPOSITORY
  R293 Baloo

BRANCH
  phrasestorage_fixes

REVISION DETAIL
  https://phabricator.kde.org/D21863

AFFECTED FILES
  src/engine/termgenerator.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21862: [QueryTest] Restructure tests to allow easier extension

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The test documents are not touched by the individual tests, so there is
  no need to set these up on every test iteration, only the DB has to
  be set up and primed.
  
  Preliminary change for further tests.

TEST PLAN
  ctest
  (no functional changes)

REPOSITORY
  R293 Baloo

BRANCH
  phrasestorage_fixes

REVISION DETAIL
  https://phabricator.kde.org/D21862

AFFECTED FILES
  autotests/integration/querytest.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15739: [Places panel] Don't show Root by default

[Elvis Angelaccio]

elvisangelaccio accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D15739

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21861: Add default variables for variables interface

[Dominik Haumann]

dhaumann added a comment.


  Btw, if there is a better place for initialization, I'd happily move the code 
to some other place.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21861

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21861: Add default variables for variables interface

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: cullmann, gregormi.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  Add set of default variables that mostly match Qt Creator's one.
  Currently unused.

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  add-default-variables

REVISION DETAIL
  https://phabricator.kde.org/D21861

AFFECTED FILES
  src/utils/kateglobal.cpp

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21509: [UnIndexedFileIteratorTest] Add tests

[Igor Poboiko]

poboiko retitled this revision from "[baloo_file] Index renamed folders inside 
UnindexedFileIndexer" to "[UnIndexedFileIteratorTest] Add tests".
poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21509

To: poboiko, #frameworks, #baloo, bruns
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

[Igor Poboiko]

poboiko updated this revision to Diff 59951.
poboiko added a comment.


  Rebase on master.
  
  Since we now reindex folder always when cTime changes, revert `nameChanged()` 
routine
  Cover the case when we feed `UnIndexedFileIterator` with path that ends with 
`/`

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21509?vs=59099&id=59951

BRANCH
  unindexed-renamed

REVISION DETAIL
  https://phabricator.kde.org/D21509

AFFECTED FILES
  autotests/unit/file/unindexedfileiteratortest.cpp

To: poboiko, #frameworks, #baloo, bruns
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:4651988e2963: [IdUtils] Fix aliasing warning (authored by 
bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21855?vs=59939&id=59948

REVISION DETAIL
  https://phabricator.kde.org/D21855

AFFECTED FILES
  src/engine/idutils.h

To: bruns, #baloo, ngraham, astippich, poboiko, thiago
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21855

To: bruns, #baloo, ngraham, astippich, poboiko, thiago
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 124 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/124/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 16 Jun 2019 17:28:13 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:381e2cd92379: [PostingIterator] Move positions() method 
to VectorPositionInfoIterator (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21835?vs=59889&id=59945

REVISION DETAIL
  https://phabricator.kde.org/D21835

AFFECTED FILES
  autotests/unit/engine/phraseanditeratortest.cpp
  autotests/unit/engine/positiondbtest.cpp
  src/engine/phraseanditerator.cpp
  src/engine/phraseanditerator.h
  src/engine/positiondb.cpp
  src/engine/positiondb.h
  src/engine/postingiterator.cpp
  src/engine/postingiterator.h
  src/engine/transaction.cpp
  src/engine/vectorpositioninfoiterator.cpp
  src/engine/vectorpositioninfoiterator.h

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 123 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/123/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 16 Jun 2019 17:15:28 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.file.filewatchtest

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

[Igor Poboiko]

poboiko added a comment.


  > As the limit is somewhat arbitrary, maybe we can just limit the QString? I 
don't think this has any serious side effects.
  
  Yep, that's what I've suggested (if I understood you correctly).
  I guess, we can put the trimming part right to `termList()`, it will further 
reduce code repetition. Something like
  
str = str.left(maxTermSize); 
list << str.toUtf8();

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21839

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

[Stefan Brüns]

bruns added a comment.


  In D21839#480765 , @poboiko wrote:
  
  > Actually, there is an issue with that code right now, which I wanted to 
fix, but forgot.
  >  The trimming part `finalArr = finalArr.mid(0, maxTermSize);` actually 
should be performed on `QString` instead of `QByteArray` - unicode symbols 
inside term can consist of two bytes, and cutting at `maxTermSize` bytes can 
actually cut half of last symbol. I end up with terms like `тождественно�` 
inside `balooshow -x`.
  >  Not to mention that russian terms end up being pretty small.
  
  
  As the limit is somewhat arbitrary, maybe we can just limit the QString? I 
don't think this has any serious side effects.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21839

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3e3cd7e63336: [WriteTransactionTest] Clear mixup of 
QString and QByteArray (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21844?vs=59913&id=59941

REVISION DETAIL
  https://phabricator.kde.org/D21844

AFFECTED FILES
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:7420bc056326: [TermGenerator] Use UTF-8 ByteArray for 
termList (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21839?vs=59896&id=59942

REVISION DETAIL
  https://phabricator.kde.org/D21839

AFFECTED FILES
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

[Igor Poboiko]

poboiko added a comment.


  Actually, there is an issue with that code right now, which I wanted to fix, 
but forgot.
  The trimming part `finalArr = finalArr.mid(0, maxTermSize);` actually should 
be performed on `QString` instead of `QByteArray` - unicode symbols inside term 
can consist of two bytes, and cutting at `maxTermSize` bytes can actually cut 
half of symbols. I end up with terms like `тождественно�` inside `balooshow -x`.
  Not to mention that russian terms end up being pretty small.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21839

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21835

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D21839

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops!

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D21844

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

[Stefan Brüns]

bruns added a reviewer: thiago.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21855

To: bruns, #baloo, ngraham, astippich, poboiko, thiago
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  memcpy with a small fixed size is optimized by all contemporary compilers
  to a few assembly instructions, but contrary to the pointer casting it
  lets the compiler do the right thing.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21855

AFFECTED FILES
  src/engine/idutils.h

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Any chance this could not be done by abusing KDECMakeSettings.cmake as 
injection vector? I know you are just following the example of what was done 
for appstreamcli, but IMHO this has already been a bad hack, screwing over the 
fine granular design of all the ECM modules trying to keep aspects separate. 
And yes, by the price of the overhead with more explicit module includes, but 
it's like that. Or we should just screw it and put everything in one big 
"KDEECMEverythingEvenKitchenSink.cmake" ;) And yes, one possible would like to 
have such a generic wrapper module in any case, for quick prototyping. But the 
individual modules should stay focussed.
  
  The docs of KDECMakeSettings say: "Changes various CMake settings to what the 
KDE community views as more sensible defaults."
  Thus adding automatic tests or macros for tests using external tools would 
not in the scope of this very module.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: kossebau, winterz, knauss, cgiboudeaux, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  touchFile expects a QString argument, not QByteArray. Use
  QFile::encodeFileName() instead of QString::toUtf8().

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D21844

AFFECTED FILES
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17241: WIP:Disable highlighting after 512 characters on a line.

[Christoph Cullmann]

cullmann added a comment.


  4daee27406cad0001f30bca4bf551495e0624d23 

  
  >
  =
  
  - addConfigEntry(ConfigEntry(LineLengthLimit, "Line Length Limit", QString(), 
4096));
  
  +addConfigEntry(ConfigEntry(LineLengthLimit, "Line Length Limit", 
QString(), 1));

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: cullmann, vkrause, dhaumann, mwolff, sars
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17241: WIP:Disable highlighting after 512 characters on a line.

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:1b7a2c69e492: WIP:Disable highlighting after 512 
characters on a line. (authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17241?vs=59550&id=59899

REVISION DETAIL
  https://phabricator.kde.org/D17241

AFFECTED FILES
  src/completion/katecompletiondelegate.cpp
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/render/katerenderrange.cpp
  src/render/katerenderrange.h

To: cullmann, vkrause, dhaumann, mwolff, sars
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17241: WIP:Disable highlighting after 512 characters on a line.

[Christoph Cullmann]

cullmann added a comment.


  Then let's try that. Even for all cases without hitting the limit the new 
code is faster.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17241

To: cullmann, vkrause, dhaumann, mwolff, sars
Cc: zetazeta, mwolff, brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21313: Create specific directory for Qt logging categories file

[Ben Cooksley]

bcooksley added a comment.


  The Binary Factory uses the tooling shipped as part of the KDE SDK (which 
always builds everything from scratch, and I don't know if part of that 
includes ECM, hence why the issue doesn't show up there).
  
  The CI system on the other hand uses it's own tooling exclusively on all 
platforms, however because the Android image ships with a limited number of 
libraries it is reliant on the KDE SDK to provide a number of non-KDE 
libraries, and thus has to include the SDK paths when performing builds. 
Unfortunately this means that it is possible on Android for CI builds to be 
contaminated by the SDK - the result of which we're seeing here.
  
  Ideally the SDK would separate the base system (non-KDE) libraries from the 
KDE ones to avoid this issue (and the CI system could therefore rely on it's 
own build results exclusively)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: apol, vkrause, bcooksley, kossebau, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for Qt logging categories file

[Volker Krause]

vkrause added a comment.


  In D21313#480401 , @kossebau wrote:
  
  > @apol @vkrause Perhaps something to check wit the CI or in general with the 
ECM Android toolchain  to make sure the ECM of the host and the target are not 
accidentally mixed or both visible at the same time.
  
  
  Right, I don't understand why it does that though. On binary factory we 
didn't have that problem, and AFAIK they use the same setup?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21313

To: mlaurent, dfaure, cgiboudeaux
Cc: apol, vkrause, bcooksley, kossebau, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, bencreasy, michaelh, ngraham, bruns