D21907: Show feedback inline when creating new files or folders

[Squeaky Pancakes]

squeakypancakes added a comment.


  Do the warnings need to below the buttons? I feel like they are kinda out of 
place there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham
Cc: squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham added a comment.


  The gif depicts a rather extreme case where you're deliberately trying to 
test all the feedback modes in quick succession. :) At @meven's request, I've 
already removed the red error message when the text field is empty.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham
Cc: dhaumann, aacid, meven, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21907: Show feedback inline when creating new files or folders

[Dominik Haumann]

dhaumann added a comment.


  Have not looked at the patch, just the gif: I am rather sceptical if instant 
feedback is a good idea here. First, having an empty line edit will happen a 
lot, usually without the user wanting to press OK. That means the user will 
already get feedback in the middle of the workflow even though he did not yet 
have the intention to click OK yet.
  The same may hold true for the other cases. Too much on-the-fly feedback may 
be annoying and stress the user unnecessarily.
  
  Finally, resizing the dialog depending on the error message also looks rather 
hard on my eyes.
  
  The much better fix would be: create the folder "New Folder" inline in the 
list view and immediately switch to edit mode, this way you do not need a 
dialog at all but don't loose anything. If the folder already exists, name it 
"New Folder (i)". Yes, that's how it's done in Windows as well, but I think it 
makes a lot of sense.
  
  Comments? :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham
Cc: dhaumann, aacid, meven, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21907: Show feedback inline when creating new files or folders

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> meven wrote in knewfilemenu.cpp:1071
> What about Windows ? maybe use QDir::separator() ?

read the docu for QDir::separator() , you seldom ever want to use it.

https://agateau.com/2015/qdir-separator-considered-harmful/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham
Cc: aacid, meven, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham added a comment.


  In D21907#482087 , @meven wrote:
  
  > It made me think about D17595 .
  >  Would it make sense to upstream this to KIO and unify behavior with 
Open/Save Dialog (it currently has a folder name check using popups).
  >  This is a different matter so it should not stop progress here.
  
  
  This is already in KIO. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham
Cc: meven, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Méven Car]

meven added a comment.


  It made me think about D17595 .
  Would it make sense to upstream this to KIO and unify behavior with Open/Save 
Dialog (it currently has a folder name check using popups).
  This is a different matter so it should not stop progress here.

INLINE COMMENTS

> knewfilemenu.cpp:1071
> +if (true /*folders*/) {
> +QStringList folders = text.split(QLatin1Char('/'));
> +if (!folders.isEmpty()) {

What about Windows ? maybe use QDir::separator() ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham
Cc: meven, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Re: KInit - Current state and benchmarks

[Albert Astals Cid]

El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va 
escriure:
> > Are we sure it's fair to assume people have SSD? our of the 4 laptops i 
> > own, only 2 have SSD.
> 
> It's at least safe to assume it's the trend moving forward.
> 
> > Do you think it's worth me trying in one of the two that don't have SSD?
> 
> More data is normally a good thing. If you or anyone else wants to
> collect stats:
> From my git link above, it's as simple as running the normal ; cmake;
> make ; ./kinittest -median 5


On my very old/very slow computer seems to make a lot of difference

RESULT : DaveTest::testQProcess():
 2,625 msecs per iteration (total: 2,625, iterations: 1)
RESULT : DaveTest::testKInit():
 1,852 msecs per iteration (total: 1,852, iterations: 1)


RESULT : DaveTest::testQProcess():
 2,390 msecs per iteration (total: 2,390, iterations: 1)
RESULT : DaveTest::testKInit():
 1,846 msecs per iteration (total: 1,846, iterations: 1)


So can we please keep/improve it?


Cheers,
  Albert

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham updated this revision to Diff 60079.
ngraham marked an inline comment as done.
ngraham added a comment.


  Don't show an ugly error when the text field is blank

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21907?vs=60072=60079

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #vdg, #frameworks, shubham
Cc: meven, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> knewfilemenu.cpp:1047
> +if (text.length() == 0) {
> +m_messageWidget->setText(i18n("Name cannot be blank."));
> +m_messageWidget->setMessageType(KMessageWidget::Error);

I would rather disable the ok button, as long as the user has not entered text, 
rather than using an error.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham
Cc: meven, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Shubham]

shubham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Shubham]

shubham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Shubham]

shubham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham added a comment.


  I've submitted a proposed replacement for this as D21907: Show feedback 
inline when creating new files or folders .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Nathaniel Graham]

ngraham added a comment.


  I've submitted a proposed replacement for this as D21907: Show feedback 
inline when creating new files or folders .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Nathaniel Graham]

ngraham added a comment.


  I've submitted a proposed replacement for this as D21907: Show feedback 
inline when creating new files or folders .

REPOSITORY
  R241 KIO

BRANCH
  err

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Frameworks, shubham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now, the new file/folder dialog allows you to give it an invalid name, 
and
  afterwards it will show you a dialog window complaining at you. This is not 
very
  user-friendly, and becomes more user-unfriendly if we want to use it to show 
  warnings rather than errors. Finally it doesn't scale well because as we add 
more
  conditions to check for, we'll need to add more dialog windows.
  
  This patch implements the name feedback/warning/error inline in the original 
name
  dialog itself, and disables the OK button for invalid names.
  
  This patch obsoletes D18384 , D18563 
, and D18599 
.

TEST PLAN
  F6915347: Peek 2019-06-19 17-59.gif 

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #vdg, #frameworks, shubham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

[Daniel Vrátil]

dvratil added a dependent revision: D21906: Events plugin: implement the new 
showEvent() API.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D21901

To: dvratil, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a dependent revision: D21905: [Digital Clock] Open KOrganizer 
with event details on click.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

[Daniel Vrátil]

dvratil updated this revision to Diff 60068.
dvratil added a comment.


  - Fix ABI compatibility

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21901?vs=60065=60068

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21901

AFFECTED FILES
  src/calendarevents/calendareventsplugin.cpp
  src/calendarevents/calendareventsplugin.h

To: dvratil, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil created this revision.
dvratil added a reviewer: mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  This extends the API to allow calendar UIs to request opening a detailed
  view of an event.
  
  Also contains a minor cleanup of unused m_eventPlugins member.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21902

AFFECTED FILES
  src/declarativeimports/calendar/daysmodel.cpp
  src/declarativeimports/calendar/daysmodel.h
  src/declarativeimports/calendar/eventdatadecorator.cpp
  src/declarativeimports/calendar/eventdatadecorator.h
  src/declarativeimports/calendar/eventpluginsmanager.cpp
  src/declarativeimports/calendar/eventpluginsmanager.h

To: dvratil, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21902: Calendar: add method to show event details

[Daniel Vrátil]

dvratil added a dependency: D21901: Calendar events: allow plugins to show 
event details.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21902

To: dvratil, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

[Daniel Vrátil]

dvratil added a dependent revision: D21902: Calendar: add method to show event 
details.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D21901

To: dvratil, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

[Daniel Vrátil]

dvratil added a reviewer: Frameworks.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D21901

To: dvratil, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21901: Calendar events: allow plugins to show event details

[Daniel Vrátil]

dvratil created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REVISION SUMMARY
  This adds new method to the plugin API that will allow plugins to show
  event details when user clicks on the event, for example by
  opening KOrganizer.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21901

AFFECTED FILES
  src/calendarevents/calendareventsplugin.h

To: dvratil
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Re: KInit - Current state and benchmarks

[David Edmundson]

On Wed, 19 Jun 2019, 16:39 Aleix Pol,  wrote:

> On Tue, Jun 18, 2019 at 12:05 PM David Edmundson
>  wrote:
> >
> > > Are we sure it's fair to assume people have SSD? our of the 4 laptops
> i own, only 2 have SSD.
> >
> > It's at least safe to assume it's the trend moving forward.
> >
> > > Do you think it's worth me trying in one of the two that don't have
> SSD?
> >
> > More data is normally a good thing. If you or anyone else wants to
> > collect stats:
> > From my git link above, it's as simple as running the normal ; cmake;
> > make ; ./kinittest -median 5
>
> I don't see a git link above.
>

kde:scratch/davidedmundson/inittimer



> Aleix
>

Re: KInit - Current state and benchmarks

[Aleix Pol]

On Tue, Jun 18, 2019 at 12:05 PM David Edmundson
 wrote:
>
> > Are we sure it's fair to assume people have SSD? our of the 4 laptops i 
> > own, only 2 have SSD.
>
> It's at least safe to assume it's the trend moving forward.
>
> > Do you think it's worth me trying in one of the two that don't have SSD?
>
> More data is normally a good thing. If you or anyone else wants to
> collect stats:
> From my git link above, it's as simple as running the normal ; cmake;
> make ; ./kinittest -median 5

I don't see a git link above.

Aleix

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Nathaniel Graham]

ngraham added a comment.


  Yes, I plan to put it up for review today or tomorrow. Sorry for the long 
wait!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham added a comment.


  Yes, I plan to put it up for review today or tomorrow. Sorry for the long 
wait!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21788: Make Plasma::Svg::elementRect a bit leaner

[Aleix Pol Gonzalez]

apol added a comment.


  ping?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21788

To: apol, #plasma, #frameworks
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21882: RFC: [CopyJob] Batch reporting processed amount

[Chinmoy Ranjan Pradhan]

chinmoyr accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21882

To: broulik, #frameworks, dfaure, chinmoyr, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21897: Address some issues reported by Krazy analysis

[Tommy Lincoln]

pajamapants3000 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pajamapants3000 requested review of this revision.

REVISION SUMMARY
  Resolved all issues discovered by the krazy plugins: crashy, explicit.
  
  Other issues remain; I left them alone because I either wasn't sure
  they should be addressed or I wasn't sure how to do so.

TEST PLAN
  Should build and pass existing tests - confirmed.

REPOSITORY
  R310 KTextWidgets

BRANCH
  krazy-50b2564 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21897

AFFECTED FILES
  autotests/kfindtest.h
  src/kregexpeditor/kregexpeditorinterface.h
  src/widgets/krichtextwidget.cpp
  src/widgets/ktextedit.cpp

To: pajamapants3000
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 60052.
leinir marked 2 inline comments as done.
leinir added a comment.


  Address pino's comments about BIC (and some documentation)
  
  - Don't mark functions virtual which should not be virtual
  - Apply the signal/slot virt func workaround for improved BIC
  - Add a bit more documentation (and some @since)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=60021=60052

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffButton.qml
  src/qtquick/qml/NewStuffDialog.qml
  src/qtquick/qml/NewStuffDialogContent.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

Re: KInit - Current state and benchmarks

[David Edmundson]

> Seems like this would need some refocusing if we want to keep it?

Definitely. We've essentially broken all of it right now.

My goal for the research and this thread is to try and get a definitive
kde-wide answer to "if we want to keep it" so I know where to put work in.

D21607: Don't delay emission of matchesChanged indefinitely

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R308:a07027cd4f22: Dont delay emission of matchesChanged 
indefinitely (authored by fvogt).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21607?vs=59252=60049

REVISION DETAIL
  https://phabricator.kde.org/D21607

AFFECTED FILES
  src/runnermanager.cpp

To: fvogt, #frameworks, broulik, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, LeGast00n, michaelh

D21894: set the focusPolicy of kpasswordlineedit to the policy of its proxy

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this is entirely the same kind of change as done in
  c695aa5a21a731ab72c8405141b43feccad2b56a 

  
  a proxy does not automatically adopt the same focus policy as the widget
  it proxies. instead it has its own policy which is simply the qwidget
  default.
  this prevents keyboard focus from working in (e.g.) buddy scenarios as well
  as when hitting Tab to move through the intractable widgets with a
  keyboard.
  seeing as kpasswordlineedit is essentially a lineedit and being able to
  "tab" from a username edit to a password edit seems a crucial behavioral
  expectation.
  
  BUG: 398275
  CHANGELOG: KPasswordLineEdit now correctly inherits its QLineEdit's 
focusPolicy

TEST PLAN
  designer reports StrongFocus as default now. when using the KPLE without 
changing its policy it will correctly receive focus through keyboard tabbing

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21894

AFFECTED FILES
  src/kpasswordlineedit.cpp

To: sitter, cfeck
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir marked 2 inline comments as done.
leinir added inline comments.

INLINE COMMENTS

> pino wrote in engine.h:471
> BIC change, you cannot add virtual  functions in a public class

That shouldn't be virtual anyway, not sure why i did that...

> pino wrote in provider.h:148
> BIC change, you cannot add virtual  functions in a public class

That's a fair bit more annoying... Oh well, signal-based workaround it is, i 
guess (not like we have a lot of providers anyway ;) )

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21813: RFC: Consider adding more padding to the desktop theme

[Nathaniel Graham]

ngraham added a comment.


  In D21813#481300 , @filipf wrote:
  
  > In D21813#481152 , 
@martinsotirov wrote:
  >
  > > I think Plasma needs a whole lot more padding all over the place, not 
just in the notifications, but I guess there must be some kind of compromise 
with all the people who like more cramped UIs.
  >
  >
  > And in this case it would be easier if we implemented the changes in the 
desktop theme rather than in code because those wanting more cramped UIs could 
just use a different desktop theme (fork an old version e.g.).
  
  
  ...and store it in the new vdg-playground repo (or whatever it's called) and 
make it available on store.kde.org.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21607: Don't delay emission of matchesChanged indefinitely

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I tried it and it works fine for me. Note that the AppStream runner's 
behavior has improved as of 0.12.7 since it now correctly returns no results 
instead of all results when it doesn't get a match.

REPOSITORY
  R308 KRunner

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21607

To: fvogt, #frameworks, broulik, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, LeGast00n, michaelh

D21882: RFC: [CopyJob] Batch reporting processed amount

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21882

To: broulik, #frameworks, dfaure, chinmoyr, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> brute4s99 wrote in notifybysnore.cpp:84
> well, I just found out the patch had broken functionality that I fixed just 
> after putting here an `else return`! 

I have fixed the issue now.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns