D21940: Make automatic spellcheck work after reloading a document

[Kåre Särs]

sars added a comment.


  LGTM

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21940

To: ahmadsamir, #ktexteditor, cullmann
Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

D14467: Auth Support: Drop privileges if target is not owned by root

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 60167.
chinmoyr marked 5 inline comments as done.
chinmoyr added a comment.


  Thanks @maltek. I've fixed all the issues.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14467?vs=59319=60167

BRANCH
  arcpatch-D14467

REVISION DETAIL
  https://phabricator.kde.org/D14467

AFFECTED FILES
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/filehelper.cpp

To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin, maltek
Cc: maltek, mreeves, mgerstner, fvogt, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D21931: [kmoretools] Add icons to download and install actions

[gregormi]

gregormi accepted this revision.
gregormi added a comment.


  Looks good to me.

REPOSITORY
  R304 KNewStuff

BRANCH
  actions

REVISION DETAIL
  https://phabricator.kde.org/D21931

To: nicolasfella, gregormi, ngraham, #vdg, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

[Méven Car]

meven abandoned this revision.
meven added a comment.


  The change was making wrong assumptions.
  kconfig_compile is due to old version of the tool being installed in 
debian/ubuntu.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D21923

To: meven, dfaure, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21940: Make automatic spellcheck work after reloading a document

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  When a document gets reloaded for whatever reason, automatic spellcheck
  should be refreshed so as to re-process the document contents.
  
  BUG: 408291
  FIXED-IN: 5.61.0

TEST PLAN
  - Open a document - with a couple of misspelled words - in kate
  - Enable "automatic spell checking"
  - Reload the document
  - The misspelled words in the document should be higlighted after reloading

REPOSITORY
  R39 KTextEditor

BRANCH
  document-reloaded-spellcheck (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21940

AFFECTED FILES
  src/spellcheck/ontheflycheck.cpp
  src/spellcheck/ontheflycheck.h

To: ahmadsamir, #ktexteditor, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21933: Symlink install to edit-download

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:8ff69b32634d: Symlink install to edit-download (authored 
by nicolasfella).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21933?vs=60142=60143

REVISION DETAIL
  https://phabricator.kde.org/D21933

AFFECTED FILES
  icons-dark/status/22/install.svg
  icons/status/22/install.svg

To: nicolasfella, #breeze, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21933: Symlink install to edit-download

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, download is basically the same as install from this perspective.

REPOSITORY
  R266 Breeze Icons

BRANCH
  foo

REVISION DETAIL
  https://phabricator.kde.org/D21933

To: nicolasfella, #breeze, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21933: Symlink install to edit-download

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Breeze, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  edit-download is the icon we want for this purpose

REPOSITORY
  R266 Breeze Icons

BRANCH
  foo

REVISION DETAIL
  https://phabricator.kde.org/D21933

AFFECTED FILES
  icons-dark/status/22/install.svg
  icons/status/22/install.svg

To: nicolasfella, #breeze, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21933: Symlink install to edit-download

[Nicolas Fella]

nicolasfella added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21933

To: nicolasfella, #breeze, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Please add description, otherwise let's try it out.

REPOSITORY
  R273 KGuiAddons

BRANCH
  wayland_keystate

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol, romangg
Cc: romangg, dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham updated this revision to Diff 60137.
ngraham added a comment.
This revision is now accepted and ready to land.


  - Do the right thing on Windows
  - Don't show any warnings when creating filenames with slashes in them (KIO 
currently allows it but substitutes a different character)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21907?vs=60079=60137

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D20193: Expose locked keystates on KModifierKeyInfo when on wayland

[Aleix Pol Gonzalez]

apol edited the summary of this revision.
apol edited the test plan for this revision.

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol
Cc: dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20443: Move to runtime the decision to use x11 or not

[Aleix Pol Gonzalez]

apol updated this revision to Diff 60135.
apol added a comment.


  rebase

REPOSITORY
  R273 KGuiAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20443?vs=55915=60135

BRANCH
  wayland_keystate

REVISION DETAIL
  https://phabricator.kde.org/D20443

AFFECTED FILES
  src/CMakeLists.txt
  src/util/kmodifierkeyinfo.cpp
  src/util/kmodifierkeyinfoprovider.cpp
  src/util/kmodifierkeyinfoprovider_dummy.cpp
  src/util/kmodifierkeyinfoprovider_p.h
  src/util/kmodifierkeyinfoprovider_x11.cpp
  src/util/kmodifierkeyinfoprovider_xcb.cpp
  src/util/kmodifierkeyinfoprovider_xcb.h

To: apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21931: [kmoretools] Add icons to download and install actions

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R304 KNewStuff

BRANCH
  actions

REVISION DETAIL
  https://phabricator.kde.org/D21931

To: nicolasfella, gregormi, ngraham, #vdg, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21931: [kmoretools] Add icons to download and install actions

[Nathaniel Graham]

ngraham edited reviewers, added: KNewStuff; removed: Spectacle.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21931

To: nicolasfella, gregormi, ngraham, #vdg, #knewstuff, #spectacle
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21931: [kmoretools] Add icons to download and install actions

[Nathaniel Graham]

ngraham added reviewers: VDG, Spectacle.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21931

To: nicolasfella, gregormi, ngraham, #vdg, #spectacle
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21931: [kmoretools] Add icons to download and install actions

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Makes it look nicer

REPOSITORY
  R304 KNewStuff

BRANCH
  actions

REVISION DETAIL
  https://phabricator.kde.org/D21931

AFFECTED FILES
  src/kmoretools/kmoretools_p.h

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21931: [kmoretools] Add icons to download and install actions

[Nicolas Fella]

nicolasfella added reviewers: gregormi, ngraham.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21931

To: nicolasfella, gregormi, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> display.h:207
> +
> +/** @since 5.57 */
> +KeyStateInterface *createKeyStateInterface(QObject *parent = nullptr);

please keep up to date.

> keystate_interface.cpp:89
> +
> +qDebug() << Q_FUNC_INFO << " setting state" << dptr->m_resources 
> << key << state;
> +for(auto r : qAsConst(dptr->m_resources))

->

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20191

To: apol, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  Going to better handle Windows and also fix a bug that slipped in.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham added a comment.


  Any more comments?

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Looks good from a visual and usability POV.

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

[Méven Car]

meven added a comment.


  In D21923#482383 , @apol wrote:
  
  > That doesn't look alright:
  >  
https://phabricator.kde.org/source/kconfig/browse/master/src/kconfig_compiler/kconfig_compiler.cpp$1768
  
  
  That is a line I am editing in this patch precissely.
  The line is about generated code only, the bulk of the patch is then updating 
tests.
  
  > We are still including the _kf5 postfix.
  > 
  > Also note the executable still is called kconfig_compiler_kf5
  
  Since 892e693f616297a91835d3d79353926b96bd1201 
 and 
the pointed review, kconfig_compiler is the main executable name used (see 
KF5ConfigMacros.cmake) for future proofing reason mainly (avoiding to update 
the executable name for kf6 for instance).
  kconfig_compiler_kf5 is kept for backward compatibility with kde4support only.
  
  And for instance on my system (kubuntu) kconfig_compiler_kf5 is not 
installed, while kconfig_compiler is.
  The leftover mention of kconfig_compiler_kf5 in generated files is confusing 
consequently.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D21923

To: meven, dfaure, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21864: [QueryTest] Test if independent phrases are really independent

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  phrasestorage_fixes

REVISION DETAIL
  https://phabricator.kde.org/D21864

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21862: [QueryTest] Restructure tests to allow easier extension

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  phrasestorage_fixes

REVISION DETAIL
  https://phabricator.kde.org/D21862

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21863: [TermGenerator] Insert an empty position between independent terms

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  phrasestorage_fixes

REVISION DETAIL
  https://phabricator.kde.org/D21863

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D12992: New elisa icon

[Nathaniel Graham]

ngraham added a comment.


  @lshoravi ping! Any chance we can finish up work on this icon and get it in?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D12992

To: lshoravi, #vdg, ngraham, #elisa
Cc: abetts, paullesur, januz, mgallien, alex-l, andreask, kde-frameworks-devel, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Nathaniel Graham]

ngraham added a comment.


  Ping!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: emateli, ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

[Aleix Pol Gonzalez]

apol added a comment.


  That doesn't look alright:
  
https://phabricator.kde.org/source/kconfig/browse/master/src/kconfig_compiler/kconfig_compiler.cpp$1768
  
  We are still including the _kf5 postfix.
  
  Also note the executable still is called kconfig_compiler_kf5

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D21923

To: meven, dfaure, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:7ef3c35c7ed6: Change joystick settings icon to game 
controller (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21919?vs=60102=60113

REVISION DETAIL
  https://phabricator.kde.org/D21919

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gaming.svg
  icons/preferences/32/preferences-desktop-gaming.svg

To: ndavis, #vdg, ngraham, filipf
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21919: Change joystick settings icon to game controller

[Nathaniel Graham]

ngraham added a comment.


  Looks like that's done in D21922 

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham, filipf
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21919: Change joystick settings icon to game controller

[Filip Fila]

filipf accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham, filipf
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

[Méven Car]

meven created this revision.
meven added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Since https://git.reviewboard.kde.org/r/116995/diff/1#index_header 
kconfig_compiler_kf5 has been renamed to kconfig_compiler but the references 
strings were not updated

TEST PLAN
  ctest

REPOSITORY
  R237 KConfig

BRANCH
  replace-old-string

REVISION DETAIL
  https://phabricator.kde.org/D21923

AFFECTED FILES
  autotests/kconfig_compiler/test1.cpp.ref
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test1.kcfgc
  autotests/kconfig_compiler/test10.cpp.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test10.kcfgc
  autotests/kconfig_compiler/test11.cpp.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11.kcfg
  autotests/kconfig_compiler/test11.kcfgc
  autotests/kconfig_compiler/test11a.cpp.ref
  autotests/kconfig_compiler/test11a.h.ref
  autotests/kconfig_compiler/test11a.kcfg
  autotests/kconfig_compiler/test11a.kcfgc
  autotests/kconfig_compiler/test12.cpp.ref
  autotests/kconfig_compiler/test12.h.ref
  autotests/kconfig_compiler/test13.cpp.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test2.cpp.ref
  autotests/kconfig_compiler/test2.h.ref
  autotests/kconfig_compiler/test2.kcfgc
  autotests/kconfig_compiler/test3.cpp.ref
  autotests/kconfig_compiler/test3.h.ref
  autotests/kconfig_compiler/test3.kcfgc
  autotests/kconfig_compiler/test3a.cpp.ref
  autotests/kconfig_compiler/test3a.h.ref
  autotests/kconfig_compiler/test3a.kcfgc
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.h.ref
  autotests/kconfig_compiler/test4.kcfgc
  autotests/kconfig_compiler/test5.cpp.ref
  autotests/kconfig_compiler/test5.h.ref
  autotests/kconfig_compiler/test5.kcfgc
  autotests/kconfig_compiler/test6.cpp.ref
  autotests/kconfig_compiler/test6.h.ref
  autotests/kconfig_compiler/test6.kcfgc
  autotests/kconfig_compiler/test7.cpp.ref
  autotests/kconfig_compiler/test7.h.ref
  autotests/kconfig_compiler/test7.kcfgc
  autotests/kconfig_compiler/test8a.cpp.ref
  autotests/kconfig_compiler/test8a.h.ref
  autotests/kconfig_compiler/test8b.cpp.ref
  autotests/kconfig_compiler/test8b.h.ref
  autotests/kconfig_compiler/test8c.cpp.ref
  autotests/kconfig_compiler/test8c.h.ref
  autotests/kconfig_compiler/test9.cpp.ref
  autotests/kconfig_compiler/test9.h.ref
  autotests/kconfig_compiler/test9.kcfgc
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_dpointer.h.ref
  autotests/kconfig_compiler/test_dpointer.kcfgc
  autotests/kconfig_compiler/test_fileextensions.kcfgc
  autotests/kconfig_compiler/test_notifiers.cpp.ref
  autotests/kconfig_compiler/test_notifiers.h.ref
  autotests/kconfig_compiler/test_notifiers.kcfgc
  autotests/kconfig_compiler/test_qdebugcategory.cpp.ref
  autotests/kconfig_compiler/test_qdebugcategory.h.ref
  autotests/kconfig_compiler/test_qdebugcategory.kcfgc
  autotests/kconfig_compiler/test_signal.cpp.ref
  autotests/kconfig_compiler/test_signal.h.ref
  autotests/kconfig_compiler/test_signal.kcfg
  autotests/kconfig_compiler/test_translation_kde.cpp.ref
  autotests/kconfig_compiler/test_translation_kde.h.ref
  autotests/kconfig_compiler/test_translation_kde.kcfgc
  autotests/kconfig_compiler/test_translation_kde_domain.cpp.ref
  autotests/kconfig_compiler/test_translation_kde_domain.h.ref
  autotests/kconfig_compiler/test_translation_kde_domain.kcfgc
  autotests/kconfig_compiler/test_translation_qt.cpp.ref
  autotests/kconfig_compiler/test_translation_qt.h.ref
  autotests/kconfig_compiler/test_translation_qt.kcfgc
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/checkkcfg.pl
  src/kconfig_compiler/kconfig_compiler.cpp

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[Ömer Fadıl Usta]

usta added a comment.


  In D21919#482275 , @ngraham wrote:
  
  > Maybe we should also consider renaming the KCM to be "Gaming Controller" 
since I don't know how many people are actually using standalone joysticks 
anymore. I remember that those were all the rage in the 90s, but probably these 
days people are just using their XBox controllers or whatever.
  
  
  +1 , at least GamePads or Game Controllers

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D15645: Add scheme selection menu with a "System" entry.

[Nathaniel Graham]

ngraham added a comment.


  I'm sorry this got lost, @amhndu. Is this reviewable in its current state?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino
Cc: pino, ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21919: Change joystick settings icon to game controller

[Nathaniel Graham]

ngraham added a comment.


  Maybe we should also consider renaming the KCM to be "Gaming Controller" 
since I don't know how many people are actually using standalone joysticks 
anymore. I remember that those were all the rage in the 90s, but probably these 
days people are just using their XBox controllers or whatever.

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[David Edmundson]

davidedmundson added a comment.


  +1 from me.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21919: Change joystick settings icon to game controller

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  BUG: 406679
  FIXED-IN: 5.60

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-gaming.svg
  icons/preferences/32/preferences-desktop-gaming.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20026: Go up in folder hierachy when in "edit mode"

[Nathaniel Graham]

ngraham added a comment.


  What's the status of this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21907: Show feedback inline when creating new files or folders

[Nathaniel Graham]

ngraham added a comment.


  In D21907#482146 , @dhaumann wrote:
  
  > The much better fix would be: create the folder "New Folder" inline in the 
list view and immediately switch to edit mode, this way you do not need a 
dialog at all but don't loose anything. If the folder already exists, name it 
"New Folder (i)". Yes, that's how it's done in Windows as well, but I think it 
makes a lot of sense.
  >
  > Comments? :)
  
  
  Unfortunately we cannot do this for the dialogs from `KNewFileMenu` because 
KIO has no knowledge of the client's view. This dialog is invoked not only from 
Dolphin, but in the file dialogs and many other places. Dolphin itself could 
implement this as it already has a "rename inline" mode, but it would be a lot 
of extra code. And `KDirOperator` which is used for the file dialogs does not 
have that feature so it would have to gain it first.
  
  In D21907#482146 , @dhaumann wrote:
  
  > Finally, resizing the dialog depending on the error message also looks 
rather hard on my eyes.
  
  
  
  
  In D21907#482169 , 
@squeakypancakes wrote:
  
  > Do the warnings need to below the buttons? I feel like they are kinda out 
of place there.
  
  
  I experimented with putting the warnings elsewhere, but then the problem is 
that they cause items in the user interface below them to jump around as they 
appear and disappear. I know from experience that many people really hate this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham
Cc: squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns