D20193: Expose locked keystates on KModifierKeyInfo when on wayland

[Aleix Pol Gonzalez]

apol abandoned this revision.

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D20193

To: apol, romangg, dfaure
Cc: alexeymin, zzag, romangg, dfaure, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns

D22015: [KUiServerJobTracker] Handle ownership change

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Just look whether we have a new service instead of assuming the old one is 
empty.
  This makes atomic service owner change when the owner is replaced work.

TEST PLAN
  Started a copy, killed plasmashell, restarted it, got a plasma job tracker 
(i.e. still works)
  Had a separate job progress viewer running, Started a copy, started 
plasmashell started, it claimed the service and took it away from the other, 
now I got the job re-show in plasmashell

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D22015

AFFECTED FILES
  src/kuiserverjobtracker.cpp

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22015: [KUiServerJobTracker] Handle ownership change

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D22015

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22015: [KUiServerJobTracker] Handle ownership change

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R288:cf6cdbb3ad9b: [KUiServerJobTracker] Handle ownership 
change (authored by broulik).

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22015?vs=60417&id=60419

REVISION DETAIL
  https://phabricator.kde.org/D22015

AFFECTED FILES
  src/kuiserverjobtracker.cpp

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22018: Install KFileCustomDialog

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  API docs advertise this as public API, and it seems to be intended as such.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22018

AFFECTED FILES
  src/filewidgets/CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Aleix Pol Gonzalez]

apol added a comment.


  X-Purpose-Action won't get translations.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D10747: Implement zwp_linux_dmabuf_v1

[Roman Gilg]

romangg updated this revision to Diff 60429.
romangg added a comment.


  - Update protocol xml to wayland-protocols master

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=60366&id=60429

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D21894: set the focusPolicy of kpasswordlineedit to the policy of its proxy

[Christoph Feck]

cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21894

To: sitter, cfeck
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22022: Downgrade "Could not change permissions" dialog box to a qWarning

[David Faure]

dfaure created this revision.
dfaure added reviewers: chinmoyr, ngraham, maltek.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  We already silenced that annoying messagebox for filesystems like
  VFAT, NTFS, SMBFS etc. But it still happens in more tricky cases like
  copying to a VirtualBox shared folder when the host is Windows
  (i.e. this is NTFS but we can't know, mtab just says vboxsf,
  and with a Linux host, vboxsf does support chmod).
  
  All other similar warnings (chown/chgrp/utime failing) also just
  lead to a qWarning, no point in annoying the user about this since
  he/she can't do anything about it anyway.
  
  In addition at the filesystem level chmod(2) doesn't even fail anymore
  these days on VFAT/NTFS, it just fails silently.

TEST PLAN
  Not really, since I couldn't actually get that warning on a native
  Linux system, due to the last point above.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22022

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: dfaure, chinmoyr, ngraham, maltek
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22022: Downgrade "Could not change permissions" dialog box to a qWarning

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22022

To: dfaure, chinmoyr, ngraham, maltek
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22018: Install KFileCustomDialog

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22018

To: vkrause, aacid
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D20210: [Label] Bump import version so padding properties are available

[Kai Uwe Broulik]

broulik abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20210

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

nicolasfella updated this revision to Diff 60441.
nicolasfella added a comment.


  - rename role
  - add file for extra translations

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=60346&id=60441

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  extraJsonTranslationKeys.txt
  src/alternativesmodel.cpp
  src/alternativesmodel.h
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  ellipsis

REVISION DETAIL
  https://phabricator.kde.org/D13150

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

D13150: Add ellipsis where appropriate

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:2eb66cbd8666: Add ellipsis where appropriate (authored by 
nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13150?vs=60441&id=60445

REVISION DETAIL
  https://phabricator.kde.org/D13150

AFFECTED FILES
  extraJsonTranslationKeys.txt
  src/alternativesmodel.cpp
  src/alternativesmodel.h
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json
  src/widgets/menu.cpp

To: nicolasfella, #vdg, apol, ngraham
Cc: aspotashev, apol, kde-frameworks-devel, #vdg, LeGast00n, michaelh, ngraham, 
bruns

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.12 - Build # 61 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.12/61/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 23 Jun 2019 10:54:57 +
 Build duration:
1 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 56 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/56/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 23 Jun 2019 10:54:57 +
 Build duration:
3 min 8 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(458/2247)17%
(172/1001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(147/156)54%
(54/100)src100%
(8/8)100%
(8/8)68%
(227/332)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%

D21960: AppArmor: update syntax

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D21960

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

Re: KInit - Current state and benchmarks

[Alexander Richardson]

On Sat, 22 Jun 2019 at 11:21, David Edmundson
 wrote:
>
> Benchmarks of dolphin on a low end ARM laptop:
>  Dolphin via QProcess: 1233ms
>  Dolphin via Kinit: 1144ms
>
> again a consistent saving in the order of ~7%
>
> Initially I had wanted to scrap it, I'm now very conflicted.
>
> I'll try to port all of plasma services to use it properly again and
> see what difference that makes across a broad context over a wider
> range of services.
>
> David

Hi David,

There is also one more thing we might want to take into account:
Kinit mostly breaks ASLR since all libraries will have libc, QtBase,
etc mapped at the same address if we do fork() without execve(). This
makes code reuse attacks a bit easier since the attacker can reuse the
guessed addresses for all base libraries. Only the executable and any
libraries loaded by the executable will have randomized addressed.

However, in my opinion all probabilistic vulnerability mitigation
schemes such as ASLR are not particularly useful since they just make
it more difficult for an attacker rather than actually preventing the
attack.
Moreover, it has been shown that ASLR can be broken due to MMU
side-channels (even from JavaScript running in a browser sandbox!) [1]
or if you have a fork()ing server (which is similar to the kinit
case)[2].
Upcoming CPUs will have more useful features to partially enforce
control flow integrity (Intel Control-flow Enforcement Technology
(CET) or ARM Branch Target Indicators (BTI)) which should be more
effective than ASLR.

Personally, I think it makes sense to keep kinit if it speeds up
start-up by 7% even if it (mostly) breaks ASLR since ASLR is already
pretty much broken. Also we have been doing this for years and I don't
think there has been a CVE because of kinit not randomizing some
library locations.

I am currently working on CHERI [3], an ISA extension that adds
128-bit capabilities (essentially pointers with bounds and
permissions) to the MIPS (and RISC-V) ISAs. We currently run
everything on a 100Mhz FPGA so I'm sure the start-up time would be
quite noticeable there. I have not yet managed to get kinit to compile
but we do have QtBase and QtWebkit working. It shouldn't be too hard
to compile kinit and run the measurements but I doubt I will have time
to do that in the next month or two.

In the past few years I've done quite a lot of work with the FreeBSD
runtime linker. Based on my current measurements of relocation
processing in the runtime linker, it can take a lot of time to resolve
all symbols (especially if lazy binding is disabled by linking with -z
now) and to process all relocations.
I believe LD_BIND_NOW/-z now is becoming the default in some
distributions since it allows mapping the GOT read-only after
relocation processing and therefore slightly reduces the attack
surface.
Kinit allows us to skip those steps for some of the libraries so it
should always be a noticeable performance win.

Alex

[1] https://www.vusec.net/projects/anc/
[2] www.scs.stanford.edu/brop/bittau-brop.pdf
[3] http://chericpu.com

D21940: Make automatic spellcheck work after reloading a document

[Ahmad Samir]

ahmadsamir updated this revision to Diff 60467.
ahmadsamir removed a subscriber: dhaumann.
ahmadsamir added a comment.


  Use a lambda instead of adding a standalone method

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21940?vs=60154&id=60467

BRANCH
  document-reloaded-spellcheck (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21940

AFFECTED FILES
  src/spellcheck/ontheflycheck.cpp

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

D21940: Make automatic spellcheck work after reloading a document

[Ahmad Samir]

ahmadsamir marked 5 inline comments as done.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21940

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

D22022: Downgrade "Could not change permissions" dialog box to a qWarning

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22022

To: dfaure, chinmoyr, ngraham, maltek
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 138 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/138/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 23 Jun 2019 12:17:23 +
 Build duration:
6 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_kprotocolinfotestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21862: [QueryTest] Restructure tests to allow easier extension

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:dea183a02e2b: [QueryTest] Restructure tests to allow 
easier extension (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21862?vs=59960&id=60475

REVISION DETAIL
  https://phabricator.kde.org/D21862

AFFECTED FILES
  autotests/integration/querytest.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21863: [TermGenerator] Insert an empty position between independent terms

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:60e03a38ec61: [TermGenerator] Insert an empty position 
between independent terms (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21863?vs=59961&id=60476

REVISION DETAIL
  https://phabricator.kde.org/D21863

AFFECTED FILES
  src/engine/termgenerator.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21864: [QueryTest] Test if independent phrases are really independent

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:ba5de13364ed: [QueryTest] Test if independent phrases are 
really independent (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21864?vs=59962&id=60477

REVISION DETAIL
  https://phabricator.kde.org/D21864

AFFECTED FILES
  autotests/integration/querytest.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 128 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/128/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 23 Jun 2019 12:32:23 +
 Build duration:
3 min 3 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 138 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/138/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 23 Jun 2019 12:17:23 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report61%
(22/36)64%
(259/402)64%
(259/402)53%
(32590/61156)38%
(16648/44038)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9400/9856)48%
(4329/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8345/14465)50%
(4656/9232)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4513/8223)41%
(1956/4767)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file0%
(0/7)0%
(0/7)0%
(0/1194)0%
(0/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1789/4291)36%
(1316/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D21940: Make automatic spellcheck work after reloading a document

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me now :)

REPOSITORY
  R39 KTextEditor

BRANCH
  document-reloaded-spellcheck (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21940

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/128/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 23 Jun 2019 12:17:23 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/402)66%
(266/402)55%
(33379/61179)39%
(17059/44041)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9400/9856)48%
(4331/9089)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8484/14477)51%
(4704/9235)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4515/8223)41%
(1956/4767)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(655/1206)39%
(373/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1789/4291)36%
(1316/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

D21940: Make automatic spellcheck work after reloading a document

[Ahmad Samir]

ahmadsamir added a comment.


  Great :). Please commit it too (as I don't have access to kde git).

REPOSITORY
  R39 KTextEditor

BRANCH
  document-reloaded-spellcheck (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21940

To: ahmadsamir, #ktexteditor, cullmann, dhaumann
Cc: sars, kde-frameworks-devel, kwrite-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, dhaumann

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 57 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/57/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 23 Jun 2019 13:23:38 +
 Build duration:
6 min 33 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)21%
(462/2247)18%
(178/1001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)60%
(60/100)src100%
(8/8)100%
(8/8)68%
(227/332)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
 

D15739: [Places panel] Don't show Root by default

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:639ba4ca8e83: [Places panel] Don't show Root by 
default (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15739?vs=59751&id=60490

REVISION DETAIL
  https://phabricator.kde.org/D15739

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesmodel.cpp

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, 
bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel, 
kde-frameworks-devel, LeGast00n, michaelh, ngraham

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 139 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/139/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 23 Jun 2019 14:09:38 +
 Build duration:
7 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_kprotocolinfotestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 139 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/139/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 23 Jun 2019 14:09:38 +
 Build duration:
8 min 56 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report61%
(22/36)64%
(259/402)64%
(259/402)53%
(32567/61117)38%
(16607/43968)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9364/9820)48%
(4290/9019)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8348/14465)50%
(4658/9232)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4512/8220)41%
(1955/4767)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file0%
(0/7)0%
(0/7)0%
(0/1194)0%
(0/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4291)36%
(1314/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 129 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/129/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 23 Jun 2019 14:09:38 +
 Build duration:
9 min 24 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.60.0.xmllogs/KF5KIO/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kprotocolinfotestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/402)66%
(266/402)55%
(33348/61140)39%
(17016/43971)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9364/9820)48%
(4292/9019)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8486/14477)51%
(4705/9235)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets74%
(28/38)74%
(28/38)55%
(4514/8220)41%
(1955/4767)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1206)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/85)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1341)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1794/4291)36%
(1314/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D15645: Add scheme selection menu with a "System" entry.

[Nathaniel Graham]

ngraham added a comment.


  @amhndu are you interested in resuming work on this? If not, please let us 
know so we can find someone else to take it over. Thanks!

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino
Cc: pino, ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22047: Fix translation of actiondisplay

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: apol, aacid.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  To be able to be translated the entries need to be subentry of KPlugin

REPOSITORY
  R495 Purpose Library

BRANCH
  unfuckup

REVISION DETAIL
  https://phabricator.kde.org/D22047

AFFECTED FILES
  src/alternativesmodel.cpp
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json

To: nicolasfella, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

[Pino Toscano]

pino added a comment.


  I do not see how this is supposed to fix the translations. Nothing translates 
the strings statically (like the various `Name`/`Comment`/etc), nor at runtime.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

[Nicolas Fella]

nicolasfella added a comment.


  @aacid and I have been working on making it possible to translate arbitrary 
JSON entries. See https://phabricator.kde.org/R883:1544734

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  okay

REPOSITORY
  R495 Purpose Library

BRANCH
  unfuckup

REVISION DETAIL
  https://phabricator.kde.org/D22047

To: nicolasfella, apol, aacid
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22049: pluginloader: Change behavior of X-KDE-ParentApp

[Bhushan Shah]

bshah created this revision.
bshah added reviewers: mart, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bshah requested review of this revision.

REVISION SUMMARY
  X-KDE-ParentApp is the key in desktop file to display that given service
  or application is part of the another application or extension of other
  application. In KDE4 this key was used to mark applets to be used in the
  specific application like plasma-desktop, kdevelop, amarok etc.
  
  In KF5 world, none of this applications have applet loading mechanism
  apart from plasma*, and there are likely only Plasma applet, containment
  or dataengines.
  
  Previous API, when no/empty parentApp was passed would filter out every
  application which had something as parentApp. This was to ensure only
  compatible plugins are loaded in Plasma. This resulted in applets
  getting excluded if they suggested that org.kde.plasmashell is their
  parent application. Refine this API to,
  
  - If no/empty parentApp is provided, provide all applets
  - If parentApp is provided, filter by applet
  
  This behavior is more filter like instead of other way around.
  
  CHANGELOG: Applet, DataEngine and containment listing methods in
  Plasma::PluginLoader no longer filters the plugins with X-KDE-ParentApp
  provided when empty string is passed.

TEST PLAN
  tested that plasma loads properly, plasmaengineexplorer lists
  all engines and plasmawindowed works fine. Neverthless requires more testing

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22049

AFFECTED FILES
  src/plasma/pluginloader.cpp
  src/plasma/pluginloader.h

To: bshah, mart, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22047: Fix translation of actiondisplay

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:1405e495ccab: Fix translation of actiondisplay (authored 
by nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22047?vs=60498&id=60504

REVISION DETAIL
  https://phabricator.kde.org/D22047

AFFECTED FILES
  src/alternativesmodel.cpp
  src/plugins/bluetooth/bluetoothplugin.json
  src/plugins/email/emailplugin.json
  src/plugins/imgur/imgurplugin.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json
  src/plugins/ktp-sendfile/ktpsendfileplugin.json
  src/plugins/nextcloud/nextcloudplugin.json
  src/plugins/pastebin/pastebinplugin.json
  src/plugins/phabricator/phabricatorplugin.json
  src/plugins/reviewboard/reviewboardplugin.json
  src/plugins/saveas/saveasplugin.json
  src/plugins/telegram/telegramplugin.json
  src/plugins/twitter/metadata.json
  src/plugins/youtube/youtubeplugin.json

To: nicolasfella, apol, aacid
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D15645: Add scheme selection menu with a "System" entry.

[Amish Naidu]

amhndu added a comment.


  Thanks for picking this up again!
  I'm definitely interested to resume but I've been a little busy this week. I 
can take a look again this weekend.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino
Cc: pino, ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

D15645: Add scheme selection menu with a "System" entry.

[Nathaniel Graham]

ngraham added a comment.


  OK, sounds good!

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino
Cc: pino, ngraham, broulik, kde-frameworks-devel, LeGast00n, michaelh, bruns

T8349: Improve Places panel usability and presentation

[Méven Car]

meven updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham, meven
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, fprice, cblack, arvidhansson, ian, jguidon, 
hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, feverfew, trickyricky26, mglb, meven, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov, 
aaronhoneycutt, mbohlender

T8349: Improve Places panel usability and presentation

[Méven Car]

meven updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham, meven
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, fprice, cblack, arvidhansson, ian, jguidon, 
hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, feverfew, trickyricky26, mglb, meven, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov, 
aaronhoneycutt, mbohlender

D22055: Improve Job Dialog buttons' icons and text

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: nicolasfella, apol, GB_2, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The buttons were on the wrong side of the window, lacked icons, and the 
affirmative
  button said "run" which didn't match the verb used in the dialog's title 
"send".
  
  This patch corrects those issues.

TEST PLAN
  F6928593: Screenshot_20190623_201202.png 


REPOSITORY
  R495 Purpose Library

BRANCH
  better-job-dialog-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22055

AFFECTED FILES
  src/widgets/JobDialog.qml

To: ngraham, nicolasfella, apol, GB_2, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D19646: Redesign config pages

[Nathaniel Graham]

ngraham added a comment.


  In D19646#483593 , @GB_2 wrote:
  
  > It would be great if you also improved the JobDialog buttons:
  >
  > - put them on the right
  > - give them icons
  
  
  Done with D22055 

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19646

To: nicolasfella, #vdg, apol, ngraham
Cc: GB_2, trmdi, abetts, ltoscano, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22055: Improve Job Dialog buttons' icons and text

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Thanks.

REPOSITORY
  R495 Purpose Library

BRANCH
  better-job-dialog-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22055

To: ngraham, nicolasfella, apol, GB_2, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21563: Fix empty pages in print preview and lines printed twice

[Robert Hoffmann]

hoffmannrobert added a comment.


  In D21563#473734 , @ngraham wrote:
  
  > Fixes https://bugs.kde.org/show_bug.cgi?id=376270?
  
  
  No, that's something different. That is apparently a duplicate of 
https://bugs.kde.org/show_bug.cgi?id=391678 which is already fixed: 
https://phabricator.kde.org/D18163

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21563

To: hoffmannrobert
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
bruns, demsking, cullmann, sars, dhaumann

D21563: Fix empty pages in print preview and lines printed twice

[Robert Hoffmann]

hoffmannrobert added a comment.


  It fixes this bug: https://bugs.kde.org/show_bug.cgi?id=348598

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21563

To: hoffmannrobert
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
bruns, demsking, cullmann, sars, dhaumann

D22055: Improve Job Dialog buttons' icons and text

[Nicolas Fella]

nicolasfella accepted this revision.

REPOSITORY
  R495 Purpose Library

BRANCH
  better-job-dialog-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22055

To: ngraham, nicolasfella, apol, GB_2, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21563: Fix empty pages in print preview and lines printed twice

[Dominik Haumann]

dhaumann added a comment.


  Many years ago I also stumbled over this bug, and I know for sure it never 
was fixed. If this fix really works then this would be really great! That said 
I have not yet tried the patch but am positive to get this in soon!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21563

To: hoffmannrobert
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, 
michaelh, bruns, demsking, cullmann, sars

D21563: Fix empty pages in print preview and lines printed twice

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added reviewers: Kate, KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21563

To: hoffmannrobert, #kate, #ktexteditor
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, 
michaelh, bruns, demsking, cullmann, sars

D21986: RFC: Change initial size of the config dialog

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I looked into what it would take to make the size adjust to its contents and 
I don't think it's worth the effort here due to the way this dialog is 
constructed. Porting to use a real QtQuick dialog would solve a lot of 
problems, but until we do that, this change is fine.

REPOSITORY
  R495 Purpose Library

BRANCH
  size

REVISION DETAIL
  https://phabricator.kde.org/D21986

To: nicolasfella, #vdg, apol, ngraham
Cc: aacid, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#367532 , @ngraham wrote:
  
  > Using "Recently Used" as the section header label presents the following 
problems:
  >
  > - One of the items is named "Recently Used"
  > - The other items actually do not display a list of recently used files; 
they display a list of recently //saved// files.
  >
  >   That's why I was trying to come up with a generic I volunteer myself to 
update the tests.section header label that could feasible encompass both.
  
  
  I think we should use another word than "Recents" like "Recent" singular, 
"Recent files", "Recent Activity" or event "Timeline" perhaps but "Recent" has 
my preference.
  It is a category title usually they are nouns. We can use an adjective but 
since a plural form is weird not to have a noun coming with it.
  
  I volunteer myself to update the tests.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  "Recent" sounds fine to me. Feel free to commandeer this revision if you'd 
like to finish it up and handle the tests. These places panel tests are the 
bane of my existence! :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22055: Improve Job Dialog buttons' icons and text

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:cad3d131b9b9: Improve Job Dialog buttons' icons and 
text (authored by ngraham).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22055?vs=60529&id=60540

REVISION DETAIL
  https://phabricator.kde.org/D22055

AFFECTED FILES
  src/widgets/JobDialog.qml

To: ngraham, nicolasfella, apol, GB_2, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 64 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/64/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 23 Jun 2019 21:36:06 +
 Build duration:
3 min 2 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(450/2243)17%
(173/1001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(147/156)56%
(56/100)src100%
(8/8)100%
(8/8)67%
(219/328)48%
(88/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 59 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/59/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 23 Jun 2019 21:36:06 +
 Build duration:
3 min 3 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(457/2246)17%
(172/1001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(147/156)54%
(54/100)src100%
(8/8)100%
(8/8)68%
(226/331)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Adriaan de Groot]

adridg added inline comments.

INLINE COMMENTS

> adridg wrote in kprocesslist_unix_procstat.cpp:38
> I absolutely have Opinions on C++ style that apply here, so I'm going to talk 
> to Tobias elsewhere.

In order to simplify cleanup, I'd use a RAII class as well:

  /** @brief Wrapper around procstat_open_sysctl()
   * 
   * Hangs on to a procstat instance for its friend classes, and closes
   * it on destruction. Cast to bool to check for success.
   */
  struct ProcStat
  {
  ProcStat()
  {
  pstat = procstat_open_sysctl();
  }
  ~ProcStat()
  {
  procstat_close(pstat);
  }
  operator bool() const
  {
  return pstat;
  }
  
  struct procstat *pstat;
  };

Lines 37-42 become `ProcStat p; if (!p) return rc;`, but more importantly you 
can drop cleanup from other return paths since the destructor handles it.

> kprocesslist_unix_procstat.cpp:46
> +struct kinfo_proc *procs;
> +procs = procstat_getprocs(pstat, KERN_PROC_PROC, 0, &proc_count);
> +

Similarly, you could

  struct ProcStatProcesses
  {
  public:
  ProcStatProcesses(ProcStat& pstat) : parent(pstat)
  {
  procs = procstat_getprocs(parent.pstat, KERN_PROC_PROC, 0, 
&proc_count);
  }
  ~ProcStatProcesses()
  {
  if (procs)
  {
  procstat_freeprocs(parent.pstat, procs);
  }
  }
  operator bool() const
  {
  return procs && proc_count > 0;
  }
  
  ProcStat& parent;
  unsigned int proc_count;
  struct kinfo_proc *procs;
  }

I'd probably also write an iterator for it, returning KProcessInfo from 
`operator*()`, so that the magic is hidden away in small classes and the 
overall algorithm becomes a very short bit of text. You might call that 
over-engineered, since there's nothing wrong with the code as-written.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Disable logs unless the logging category kf5.kconfig.kdesktopfile is enabled

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven commandeered this revision.
meven added a reviewer: ngraham.
meven added inline comments.

INLINE COMMENTS

> kfileplacesmodel.cpp:289
>  KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
> -  QStringLiteral("Today"), 
> I18N_NOOP2("KFile System Bookmarks", "Today"),
> +  QStringLiteral("Created 
> Today"), I18N_NOOP2("KFile System Bookmarks", "Today"),
>
> QUrl(QStringLiteral("timeline:/today")),  QStringLiteral("go-jump-today"));

timeline protocol works on modification date, we should change this to 
"Modified Today".
It is a better feature anyway.

> kfileplacesmodel.cpp:292
>  KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
> -  QStringLiteral("Yesterday"), 
> I18N_NOOP2("KFile System Bookmarks", "Yesterday"),
> +  QStringLiteral("Created 
> Yesterday"), I18N_NOOP2("KFile System Bookmarks", "Yesterday"),
>
> QUrl(QStringLiteral("timeline:/yesterday")),  
> QStringLiteral("view-calendar-day"));

same here

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Now that we have creation date support, what do you think about adjusting the 
timeline to show files that were either created or modified during a given time 
period?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22061: Add a logging category for logs warnings

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kdesktopfile.h:27
>  
> +#include 
> +Q_DECLARE_LOGGING_CATEGORY(kconfigLoggingDesktop)

Use ecm_qt_declare_logging_category from cmake.

This should never be in header files too, or it would spill on applications 
otherwise.

See for example how it's done in this same repo on KCONF_UPDATE_LOG.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven updated this revision to Diff 60546.
meven added a comment.


  Use KCONF_DESKTOP_LOG to setup logging

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=60545&id=60546

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kdesktopfile.cpp

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven updated this revision to Diff 60547.
meven added a comment.


  Removed blank line

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=60546&id=60547

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kdesktopfile.cpp

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven added a comment.


  Thank you very much again @apol for your guidance.
  
  I am not sure my naming scheme is ideal.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#485714 , @ngraham wrote:
  
  > Now that we have creation date support, what do you think about adjusting 
the timeline to show files that were either created or modified during a given 
time period?
  
  
  Well modified files already includes created files, so that is pretty much 
accomplished.
  And baloo probably does not support file date creation metadata.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kfileplacesitem.cpp:113
>  case KFilePlacesModel::RecentlySavedType:
> -m_groupName = i18nc("@item", "Recently Saved");
> +m_groupName = i18nc("@item", "Recents");
>  break;

Rename to "Recent"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 65 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/65/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 24 Jun 2019 03:06:22 +
 Build duration:
3 min 13 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)21%
(461/2246)18%
(178/1001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)60%
(60/100)src100%
(8/8)100%
(8/8)68%
(226/331)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
 

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/60/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Jun 2019 03:06:15 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.60.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(454/2246)17%
(173/1001)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(144/156)53%
(53/100)src100%
(8/8)100%
(8/8)68%
(226/331)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%