D22653: Add view-qrcode icons

[Noah Davis]

ndavis added a comment.


  In D22653#500427 , @mbruchert 
wrote:
  
  > The blue corners are supposed to indicate that the QR-Code can be scanned.
  
  
  But aren't QR codes normally scannable?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22653: Add view-qrcode icons

[Noah Davis]

ndavis added a comment.


  In D22653#500471 , @broulik wrote:
  
  > How about `view-barcode-qr`? then we could potentially have specific 
`view-barcode-aztec` and also a fallback to `view-barcode`
  
  
  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22670: Change Highlight to ButtonFocus, improve stylesheet support

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma, Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Changed Highlight to Button focus so that these SVGs wouldn't use the same 
color as the selection background.
  
  Also changed some hardcoded colors to colorscheme colors (e.g., Icon Yellow 
to NeutralText) and changed some weird default stylesheet colors to normal 
colors (e.g., #7b7c7e to Shade Black).

TEST PLAN
  Screenshots are coming

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  focus-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22670

AFFECTED FILES
  src/desktoptheme/breeze/icons/konv_message.svg
  src/desktoptheme/breeze/icons/network.svg
  src/desktoptheme/breeze/icons/osd.svg
  src/desktoptheme/breeze/icons/quassel.svg
  src/desktoptheme/breeze/icons/software.svg
  src/desktoptheme/breeze/icons/window.svg
  src/desktoptheme/breeze/widgets/action-overlays.svg
  src/desktoptheme/breeze/widgets/bar_meter_horizontal.svg
  src/desktoptheme/breeze/widgets/bar_meter_vertical.svg
  src/desktoptheme/breeze/widgets/busywidget.svg
  src/desktoptheme/breeze/widgets/calendar.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg
  src/desktoptheme/breeze/widgets/glowbar.svg
  src/desktoptheme/breeze/widgets/pager.svg
  src/desktoptheme/breeze/widgets/viewitem.svg

To: ndavis, #vdg, #plasma, #breeze
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

[Alexander Potashev]

aspotashev added a comment.


  This broke some public APIs on Windows: since Qt5DBus is not being "imported" 
by CMake, a group of .cpp files is not being compiled, see e.g. 
https://cgit.kde.org/knotifications.git/tree/src/CMakeLists.txt#n25 . Thus e.g. 
class KStatusNotifierItem implementation becomes unavailable at linking time, 
even though CMake configuration installs the respective header files.
  
  As a consequence, we have linking errors in applications that rely on 
KStatusNotifierItem: https://phabricator.kde.org/T11275

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: aspotashev, bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/6/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 23 Jul 2019 00:42:41 +
 Build duration:
7 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kformattestFailed: projectroot.autotests.kprocesslisttest

D22667: Make the default build type "Debug" when compiling a git checkout.

[Aleix Pol Gonzalez]

apol added a comment.


  +1 Makes a lot of sense to me. In KDevelop we are already setting Debug by 
default.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22667

To: dfaure, kde-buildsystem
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, bencreasy, michaelh, 
ngraham, bruns

D22667: Make the default build type "Debug" when compiling a git checkout.

[David Faure]

dfaure created this revision.
dfaure added a reviewer: kde-buildsystem.
Herald added projects: Frameworks, Build System.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  The idea comes from
  https://blog.kitware.com/cmake-and-the-default-build-type/
  but I adapted it to leave it empty for tarballs, to avoid messing up
  distribution packaging.
  
  The goal is to make this more sensible for [new] developers who just
  run cmake and end up with a "no debug symbols, no optimizations" build,
  i.e. the one and only completely useless combination of those two flags.
  
  Possible risk: distributions who compile from git checkouts...

TEST PLAN
  "mkdir build ; cd build ; cmake .." in kblog leads to CMAKE_BUILD_TYPE=Debug

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22667

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: dfaure, kde-buildsystem
Cc: kde-frameworks-devel, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, 
bruns

D22586: KRun QML proxy: fix path/URL confusion

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  D22586

REVISION DETAIL
  https://phabricator.kde.org/D22586

To: dfaure, davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22657: Use non-deprecated suggestName

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  nd

REVISION DETAIL
  https://phabricator.kde.org/D22657

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 148 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/148/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 22 Jul 2019 21:38:46 +
 Build duration:
31 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfilewidgettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33457/61052)39%
(17055/43959)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9341/9791)48%
(4285/9007)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8534/14438)51%
(4693/9207)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4595/8216)42%
(2000/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1204)39%
(373/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4290)36%
(1316/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 147 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/147/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 22 Jul 2019 21:03:49 +
 Build duration:
34 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33457/61052)39%
(17042/43959)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9341/9791)48%
(4284/9007)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8531/14438)51%
(4688/9207)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4592/8216)42%
(1997/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1204)39%
(373/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4290)36%
(1316/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/7/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 22 Jul 2019 21:33:40 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 35 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 22 Jul 2019 21:04:59 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5KDE4Support-5.61.0.xmlacc/KF5KDELibs4Support-5.61.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kglobalsettingstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/290)43%
(124/290)47%
(21555/45931)38%
(13009/34261)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11342/11739)50%
(7167/14369)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9479/17867)48%
(5539/11439)src.kdeui19%
(13/67)19%
(13/67)7%
(724/9692)6%
(302/5396)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1242)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/855)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/186)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1530)0%
(0/487)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 16 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/16/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 22 Jul 2019 21:18:07 +
 Build duration:
8 min 10 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfilewidgettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33454/61052)39%
(17052/43959)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9341/9791)48%
(4289/9007)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8527/14438)51%
(4692/9207)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4595/8216)42%
(2000/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/10/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 22 Jul 2019 21:16:40 +
 Build duration:
8 min 42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/9/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 22 Jul 2019 21:03:49 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/5/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 22 Jul 2019 21:04:59 +
 Build duration:
7 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D22658: Use non-deprecated suggestName

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R239:36a409210949: Use non-deprecated suggestName (authored by 
nicolasfella).

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22658?vs=62333=62355

REVISION DETAIL
  https://phabricator.kde.org/D22658

AFFECTED FILES
  src/kio/kdirselectdialog.cpp

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22637: Deprecate suggestName

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4cdf7f01c191: Deprecate suggestName (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22637?vs=62325=62354#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22637?vs=62325=62354

REVISION DETAIL
  https://phabricator.kde.org/D22637

AFFECTED FILES
  src/core/global.cpp
  src/core/global.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22656: Replace implementation of suggestName with KFileUtils::suggestName

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:65010677ff35: Replace implementation of suggestName with 
KFileUtils::suggestName (authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22656?vs=62330=62353

REVISION DETAIL
  https://phabricator.kde.org/D22656

AFFECTED FILES
  autotests/globaltest.cpp
  autotests/globaltest.h
  src/core/global.cpp

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: kbuildsycoca global in a modern world

[Harald Sitter]

On Sun, Jul 21, 2019 at 5:38 PM David Faure  wrote:
>
> On mardi 16 juillet 2019 13:08:02 CEST Harald Sitter wrote:
> > I was wondering if kbuildsycoca's global code still has a reason to exist.
>
> I wondered the same when I redesigned most of ksycoca some time ago,
> and I chose to keep the feature.
> The thinking is the following: imagine a kiosk-mode device where every login
> is a first time login for that user (because the user gets deleted every time,
> to start ).
> The startup will be slow every time because the ksycoca file has to be created
> by parsing all desktop files.
> A sysadmin can run kbuildsycoca5 --global once and users will end up using
> that.
>
> > The way I read the code a local kbuildsycoca would only reuse the
> > global sycoca iff languages, prefixes and signatures are a match.
>
> Same logic as for a local sycoca, yes.
>
> > But prefixes are not ever the same in any "default" or even reasonable
> > scenario. Specifically, prefixes are essentially
> > QStandardPaths::GenericDataLocation paths and those include at least
> > one user-specific directory on every single platform documented for
> > QSP.
>
> Oops. That's a porting bug, I would say. The home dir shouldn't be taken into
> account for the global database.
> I checked the kde4 code and it used to do
>if (bGlobalDatabase)
>{
>  setenv("KDEHOME", "-", 1);
>  setenv("KDEROOTHOME", "-", 1);
>}
> exactly for this purpose.
>
> WARNING WARNING the current code seems to not do that, and still it cleans up
> the local applications directory afterwards, so if you run
> kbuildsycoca5 --global in your user account, it will delete
> ~/.local/share/applications, as far as I can see in the code!
>
> I just removed that very dangerous cleanup code, don't try --global before
> having that fix...
> https://commits.kde.org/kservice/5cf75cedc26447bce4c1cf0b4c0fa71018f506f5
>
> > On linuxy systems this is even a very important path as (e.g.)
> > application desktop files edited by kmenuedit are stored in
> > XDG_DATA_HOME, so not including that would break overrides or custom
> > software installs. Additionally bundle software such as flatpak can do
> > user-specific software installation which means it also injects paths
> > into XDG_DATA_DIRS.
>
> Right. As soon as you have things in XDG_DATA_HOME, you need a local ksycoca,
> that's for sure.
>
> > Do we still need the global cache feature at all?
>
> I wish Waldo Bastian was around to answer the following question: how does
> this feature differ from an autostart script copying a global ksycoca to the
> user's directory, in such a kiosk setup?
>
> I can't see a good reason to keep the feature, actually :-)

Right, so I am very much in favor of removing this feature. It seems
entirely unlikely it is being used given the current state it was in.
And ultimately the same effect can be achieved by generating a ksycoca
and then copying into /etc/skel or some other place so it gets picked
up by the session. We really don't need special code for a kiosk use
case.

HS

D22653: Add view-qrcode icons

[Kai Uwe Broulik]

broulik added a comment.


  How about `view-barcode-qr`? then we could potentially have specific 
`view-barcode-aztec` and also a fallback to `view-barcode`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22586: KRun QML proxy: fix path/URL confusion

[David Faure]

dfaure added a comment.


  @davidedmundson @apol patch OK now?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22586

To: dfaure, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22658: Use non-deprecated suggestName

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R239 KDELibs4Support

BRANCH
  nd

REVISION DETAIL
  https://phabricator.kde.org/D22658

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22656: Replace implementation of suggestName with KFileUtils::suggestName

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  internal

REVISION DETAIL
  https://phabricator.kde.org/D22656

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22637: Deprecate suggestName

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  depre

REVISION DETAIL
  https://phabricator.kde.org/D22637

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22659: Fix bracket

[Hannah von Reth]

vonreth added a comment.


Applications/19.08 was branched before the commit introducing this issue

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22659

To: vonreth, brute4s99
Cc: ltoscano, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, 
sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22659: Fix bracket

[Luigi Toscano]

ltoscano added a comment.


  This should be backported to Applications/19.08.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22659

To: vonreth, brute4s99
Cc: ltoscano, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, 
sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris added a reviewer: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

To: smokris, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22662: Add common GLSL file extensions (.vs, .gs, .fs)

[Steve Mokris]

smokris created this revision.
smokris added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
smokris requested review of this revision.

REVISION SUMMARY
  These 2-letter extensions are used by, for example:
  
  - https://www.interactiveshaderformat.com/about
  - https://github.com/euler0/sublime-glsl
  - https://github.com/polym0rph/GLSL.tmbundle
  - http://plugins.netbeans.org/plugin/46515/glsl-syntax-highlighter

TEST PLAN
  This commit also adds a test to ensure that .fs still defaults to FSharp.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22662

AFFECTED FILES
  syntax/glsl.xml
  syntaxrepository_test.cpp

To: smokris
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22653: Add view-qrcode icons

[Mathis Brüchert]

mbruchert added a comment.


  The blue corners are supposed to indicate that the QR-Code can be scanned.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

[Mathis Brüchert]

mbruchert updated this revision to Diff 62346.
mbruchert added a comment.


  Add icons to breeze-dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22653?vs=62344=62346

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons-dark/actions/16/view-qrcode.svg
  icons-dark/actions/22/view-qrcode.svg
  icons-dark/actions/32/view-qrcode.svg
  icons/actions/16/view-qrcode.svg
  icons/actions/22/view-qrcode.svg
  icons/actions/32/view-qrcode.svg

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

[Mathis Brüchert]

mbruchert updated this revision to Diff 62344.
mbruchert added a comment.


  Remove accidentially committed changes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22653?vs=62343=62344

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons/actions/16/view-qrcode.svg
  icons/actions/22/view-qrcode.svg
  icons/actions/32/view-qrcode.svg

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

[Mathis Brüchert]

mbruchert updated this revision to Diff 62343.
mbruchert added a comment.


  Optimize and use css theme colors

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22653?vs=62318=62343

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons/actions/16/view-qrcode.svg
  icons/actions/22/view-qrcode.svg
  icons/actions/32/view-qrcode.svg
  optimize-svg.sh

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22659: Fix bracket

[Hannah von Reth]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:872083cefb55: Fix bracket (authored by vonreth).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22659?vs=62336=62342

REVISION DETAIL
  https://phabricator.kde.org/D22659

AFFECTED FILES
  sftp/kio_sftp.cpp

To: vonreth, brute4s99
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22659: Fix bracket

[Piyush Aggarwal]

brute4s99 accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22659

To: vonreth, brute4s99
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22659: Fix bracket

[Piyush Aggarwal]

brute4s99 added a comment.


  thanks Hannah!

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22659

To: vonreth, brute4s99
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22659: Fix bracket

[Hannah von Reth]

vonreth added a reviewer: brute4s99.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22659

To: vonreth, brute4s99
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22659: Fix bracket

[Hannah von Reth]

vonreth created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
vonreth requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22659

AFFECTED FILES
  sftp/kio_sftp.cpp

To: vonreth
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[Noah Davis]

ndavis added a comment.


  In D22617#500369 , @davidhurka 
wrote:
  
  > Making the parts with background color transparent would be better, right? 
That would even work on systems which don’t access the stylesheet.
  
  
  Not necessarily. In Breeze, the normal window Background is `#eff0f1`, the 
ViewBackground is `#fcfcfc` and the selection background is `#3daee9`. If you 
use the Background class, you will have `#eff0f1`, whether the SVG is on top of 
a normal window background or not. This is more useful for Plasma themes than 
icons, but they're both made with SVGs and can use the same color classes.
  
  > So this means, changing the Neutral Text property on your system will 
modify the Beware Orange parts of breeze icons, yes? That’s what I meant with 
mapping.
  > 
  > I could imagine adding this to the HIG: A table with the reduced breeze 
color palette, the color names, the corresponding color scheme entries, and the 
existing description to the color. (So only add the color scheme entry.)
  
  Yeah, showing a clearer relationship between color classes and default colors 
would be good.
  
  >> or fork, patch and merge request to submit a patch for that repo.
  > 
  > Not today, have to leave the wall plug now... :)
  
  Understandable.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[David Hurka]

davidhurka added a comment.


  In D22617#500361 , @ndavis wrote:
  
  > In D22617#500346 , @davidhurka 
wrote:
  >
  > > - Why does the stylesheet need a background?
  >
  >
  > You only need to add the classes that you will use. If you want to use the 
window background color, you can use the Background class.
  
  
  Making the parts with background color transparent would be better, right? 
That would even work on systems which don’t access the stylesheet.
  
  >> - How are the color scheme properties in the stylesheet mapped to the 
reduced breeze palette in the HIG? (I think neutral or Beware Orange do not 
clearly map.)
  > 
  > Beware Orange is just the name of a color (it's an arbitrary name). 
NeutralText is a class that maps to the Neutral Text color in your system 
colorscheme. The color of Neutral Text just happens to be Beware Orange with 
the Breeze colorscheme, but you could make it purple by changing the 
colorscheme. Since Breeze uses Beware Orange, that color must be the default 
color in the stylesheet so that the icon color looks like Breeze in non-Qt apps.
  
  So this means, changing the Neutral Text property on your system will modify 
the Beware Orange parts of breeze icons, yes? That’s what I meant with mapping.
  
  I could imagine adding this to the HIG: A table with the reduced breeze color 
palette, the color names, the corresponding color scheme entries, and the 
existing description to the color. (So only add the color scheme entry.)
  
  > If you find any more flaws in the HIG, report an issue at 
https://invent.kde.org/websites/hig-kde-org/issues
  
  Concerning margins: https://invent.kde.org/websites/hig-kde-org/issues/12
  
  > or fork, patch and merge request to submit a patch for that repo.
  
  Not today, have to leave the wall plug now... :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[Noah Davis]

ndavis added a comment.


  In D22617#500346 , @davidhurka 
wrote:
  
  > By the way, the suggested stylesheet in 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does 
not follow https://hig.kde.org/style/icon.html as far as I can understand it.
  
  
  I just changed the stylesheet in the workflow tips today. I need to update 
the HIG to match it.
  
  > - Why does the stylesheet need a background?
  
  You only need to add the classes that you will use. If you want to use the 
window background color, you can use the Background class.
  
  > - How are the color scheme properties in the stylesheet mapped to the 
reduced breeze palette in the HIG? (I think neutral or Beware Orange do not 
clearly map.)
  
  Beware Orange is just the name of a color (it's an arbitrary name). 
NeutralText is a class that maps to the Neutral Text color in your system 
colorscheme. The color of Neutral Text just happens to be Beware Orange with 
the Breeze colorscheme, but you could make it purple by changing the 
colorscheme. Since Breeze uses Beware Orange, that color must be the default 
color in the stylesheet so that the icon color looks like Breeze in non-Qt apps.
  
  If you find any more flaws in the HIG, report an issue at 
https://invent.kde.org/websites/hig-kde-org/issues or fork, patch and merge 
request to submit a patch for that repo.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[Nathaniel Graham]

ngraham added a comment.


  These versions look great to me now. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[David Hurka]

davidhurka added a comment.


  By the way, the suggested stylesheet in 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze does 
not follow https://hig.kde.org/style/icon.html as far as I can understand it.
  
  - Why does the stylesheet need a background?
  - How are the color scheme properties in the stylesheet mapped to the reduced 
breeze palette in the HIG? (I think neutral or Beware Orange do not clearly 
map.)
  
  If this is ok now, I still have to add the lost `id="current-color-scheme"`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22658: Use non-deprecated suggestName

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

TEST PLAN
  Builds

REPOSITORY
  R239 KDELibs4Support

BRANCH
  nd

REVISION DETAIL
  https://phabricator.kde.org/D22658

AFFECTED FILES
  src/kio/kdirselectdialog.cpp

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 146 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/146/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 22 Jul 2019 16:45:03 +
 Build duration:
28 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfilewidgettestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33514/61108)39%
(17073/43977)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9370/9820)48%
(4295/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8561/14465)51%
(4701/9219)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4596/8216)42%
(2001/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(654/1204)39%
(373/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4290)36%
(1316/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[David Hurka]

davidhurka updated this revision to Diff 62332.
davidhurka added a comment.


  - Adapt view-pages-facing and -facing-first-centered to use ndavis' suggested 
files

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62294=62332

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/16/view-pages-continuous.svg
  icons-dark/actions/16/view-pages-facing-first-centered.svg
  icons-dark/actions/16/view-pages-facing.svg
  icons-dark/actions/16/view-pages-overview.svg
  icons-dark/actions/16/view-pages-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/22/view-pages-continuous.svg
  icons-dark/actions/22/view-pages-facing-first-centered.svg
  icons-dark/actions/22/view-pages-facing.svg
  icons-dark/actions/22/view-pages-overview.svg
  icons-dark/actions/22/view-pages-single.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/snap-page.svg
  icons/actions/16/view-pages-continuous.svg
  icons/actions/16/view-pages-facing-first-centered.svg
  icons/actions/16/view-pages-facing.svg
  icons/actions/16/view-pages-overview.svg
  icons/actions/16/view-pages-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/22/view-pages-continuous.svg
  icons/actions/22/view-pages-facing-first-centered.svg
  icons/actions/22/view-pages-facing.svg
  icons/actions/22/view-pages-overview.svg
  icons/actions/22/view-pages-single.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22657: Use non-deprecated suggestName

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

TEST PLAN
  Builds

REPOSITORY
  R495 Purpose Library

BRANCH
  nd

REVISION DETAIL
  https://phabricator.kde.org/D22657

AFFECTED FILES
  src/plugins/nextcloud/nextcloudjob.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22617: Add view-pages-* icons, as needed in Okular for page layout selection

[David Hurka]

davidhurka retitled this revision from "Add icons for pagelayout options, as 
needed in Okular" to "Add view-pages-* icons, as needed in Okular for page 
layout selection".
davidhurka edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22656: Replace implementation of suggestName with KFileUtils::suggestName

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This way we avoid having duplicate code. Also remove the now unneeded test

TEST PLAN
  Builds

REPOSITORY
  R241 KIO

BRANCH
  internal

REVISION DETAIL
  https://phabricator.kde.org/D22656

AFFECTED FILES
  autotests/globaltest.cpp
  autotests/globaltest.h
  src/core/global.cpp

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 14 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/14/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 22 Jul 2019 16:45:03 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33514/61108)39%
(17062/43977)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9370/9820)48%
(4293/9013)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8556/14465)51%
(4703/9219)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4591/8216)42%
(1996/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D22653: Add view-qrcode icons

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/8/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 22 Jul 2019 16:45:03 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_kfilewidgettestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22653: Add view-qrcode icons

[Noah Davis]

ndavis added a comment.


  Hi! Thanks for the patch. There are few things I'd like you to change before 
I accept this.
  
  The icons need optimization and colorscheme support (see workflow tips). If 
you have questions or need help, feel free to ask.
  
  16px version:
  The margins are a pixel too wide on each side (see HIG). You could even fit 
in some random dots with the extra space that decreasing the margins would give 
you.
  F7077677: Screenshot_20190722_124543.png 

  
  32px:
  Not sure if this should be changed, but what is the reason for the blue 
corners?
  
  Make sure you read these:
  https://hig.kde.org/style/icon.html
  https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze
Cc: ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22637: Deprecate suggestName

[Nicolas Fella]

nicolasfella updated this revision to Diff 62325.
nicolasfella added a comment.


  - Include deprecated since
  - Don't build with KIOCORE_NO_DEPRECATED

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22637?vs=62271=62325

BRANCH
  depre

REVISION DETAIL
  https://phabricator.kde.org/D22637

AFFECTED FILES
  src/core/global.cpp
  src/core/global.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22638: Port internal usage of KIO::suggestName

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:23e5b099b0e9: Port internal usage of KIO::suggestName 
(authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22638?vs=62272=62323

REVISION DETAIL
  https://phabricator.kde.org/D22638

AFFECTED FILES
  src/core/copyjob.cpp
  src/filewidgets/knewfilemenu.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/widgets/renamedialog.cpp
  src/widgets/renamedialog.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22557: [IndexCleaner] ignore non-existent entries inside config

[Igor Poboiko]

poboiko closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D22557

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22653: Add view-qrcode icons

[Mathis Brüchert]

mbruchert added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22653: Add view-qrcode icons

[Mathis Brüchert]

mbruchert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mbruchert requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons/actions/16/view-qrcode.svg
  icons/actions/22/view-qrcode.svg
  icons/actions/32/view-qrcode.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22647: Change Highlight to ButtonFocus in stylesheets

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:822b3ae3f88a: Change Highlight to ButtonFocus in 
stylesheets (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22647?vs=62303=62316

REVISION DETAIL
  https://phabricator.kde.org/D22647

AFFECTED FILES
  icons-dark/actions/12/transform-affect-gradient.svg
  icons-dark/actions/12/transform-affect-pattern.svg
  icons-dark/actions/12/transform-affect-rounded-corners.svg
  icons-dark/actions/12/transform-affect-stroke.svg
  icons-dark/actions/16/artifact.svg
  icons-dark/actions/16/category2parent.svg
  icons-dark/actions/16/child2category.svg
  icons-dark/actions/16/curve-connector.svg
  icons-dark/actions/16/deep-history.svg
  icons-dark/actions/16/dialog-tile-clones.svg
  icons-dark/actions/16/document-compareright.svg
  icons-dark/actions/16/draw-connector.svg
  icons-dark/actions/16/edit-select-original.svg
  icons-dark/actions/16/edit-table-cell-split.svg
  icons-dark/actions/16/edit-table-insert-column-left.svg
  icons-dark/actions/16/edit-table-insert-column-right.svg
  icons-dark/actions/16/edit-table-insert-row-above.svg
  icons-dark/actions/16/edit-table-insert-row-below.svg
  icons-dark/actions/16/edit-table-insert-row-under.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/escape-direction-all.svg
  icons-dark/actions/16/escape-direction-down.svg
  icons-dark/actions/16/escape-direction-horizontal.svg
  icons-dark/actions/16/escape-direction-left.svg
  icons-dark/actions/16/escape-direction-right.svg
  icons-dark/actions/16/escape-direction-up.svg
  icons-dark/actions/16/escape-direction-vertical.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/foreign_green.svg
  icons-dark/actions/16/foreign_red.svg
  icons-dark/actions/16/format-break-node.svg
  icons-dark/actions/16/format-connect-node.svg
  icons-dark/actions/16/format-disconnect-node.svg
  icons-dark/actions/16/format-join-node.svg
  icons-dark/actions/16/format-precision-more.svg
  icons-dark/actions/16/format-remove-node.svg
  icons-dark/actions/16/format-text-capitalize.svg
  icons-dark/actions/16/format-text-lowercase.svg
  icons-dark/actions/16/format-text-uppercase.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/16/insert-button.svg
  icons-dark/actions/16/insert-endnote.svg
  icons-dark/actions/16/insert-footnote.svg
  icons-dark/actions/16/insert-more-mark.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/insert-table-of-contents.svg
  icons-dark/actions/16/insert-table.svg
  icons-dark/actions/16/kr_mountman.svg
  icons-dark/actions/16/kr_syncbrowse_off.svg
  icons-dark/actions/16/kr_syncbrowse_on.svg
  icons-dark/actions/16/layer-bottom.svg
  icons-dark/actions/16/layer-duplicate.svg
  icons-dark/actions/16/layer-lower.svg
  icons-dark/actions/16/layer-next.svg
  icons-dark/actions/16/layer-previous.svg
  icons-dark/actions/16/layer-raise.svg
  icons-dark/actions/16/layer-top.svg
  icons-dark/actions/16/lines-connector.svg
  icons-dark/actions/16/media-show-active-track-amarok.svg
  icons-dark/actions/16/media-track-queue-amarok.svg
  icons-dark/actions/16/mode1.svg
  icons-dark/actions/16/mode2.svg
  icons-dark/actions/16/mode3.svg
  icons-dark/actions/16/mode4.svg
  icons-dark/actions/16/mode5.svg
  icons-dark/actions/16/node-segment-curve.svg
  icons-dark/actions/16/node-segment-line.svg
  icons-dark/actions/16/node-transform.svg
  icons-dark/actions/16/node-type-auto-smooth.svg
  icons-dark/actions/16/node-type-cusp.svg
  icons-dark/actions/16/node-type-smooth.svg
  icons-dark/actions/16/node-type-symmetric.svg
  icons-dark/actions/16/object-to-path.svg
  icons-dark/actions/16/paint-pattern.svg
  icons-dark/actions/16/path-break-apart.svg
  icons-dark/actions/16/path-combine.svg
  icons-dark/actions/16/path-cut.svg
  icons-dark/actions/16/path-effect-parameter-next.svg
  icons-dark/actions/16/path-inset.svg
  icons-dark/actions/16/path-intersection.svg
  icons-dark/actions/16/path-offset-dynamic.svg
  icons-dark/actions/16/path-offset-linked.svg
  icons-dark/actions/16/path-outset.svg
  icons-dark/actions/16/path-reverse.svg
  icons-dark/actions/16/rectangle-make-corners-sharp.svg
  icons-dark/actions/16/selection-move-to-layer-above.svg
  icons-dark/actions/16/selection-move-to-layer-below.svg
  icons-dark/actions/16/show-node-handles.svg
  icons-dark/actions/16/similarartists-amarok.svg
  icons-dark/actions/16/snap-bounding-box-center.svg
  icons-dark/actions/16/snap-bounding-box-corners.svg
  icons-dark/actions/16/snap-bounding-box-edges.svg
  icons-dark/actions/16/snap-bounding-box-midpoints.svg
  icons-dark/actions/16/snap-grid-guide-intersections.svg
  icons-dark/actions/16/snap-nodes-center.svg
  icons-dark/actions/16/snap-nodes-cusp.svg
  

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka added a comment.


  In D22617#500212 , @ndavis wrote:
  
  > In D22617#500031 , @davidhurka 
wrote:
  >
  > > I can’t follow you here. Centering the first page is a feature / 
technical detail of Okular, but it indicates that the first page is somehow 
special, like the cover page of a book. But your document could be a single 
chapter of the book as well, so the first page is just a regular odd-numbered 
page. That page should be aligned right.
  >
  >
  > Since it's an icon for Okular and the feature is called "Facing Pages 
(Center First Page), I don't understand what the problem is with making the top 
symbol centered.
  >
  > Here's what I had in mind:
  >  F7077350: view-pages-facing-first-centered.svg 
 F7077351: 
view-pages-facing-first-centered.svg 
  
  
  Just thinking about RTL layout, centering the top symbol is probably better. 
Fold will still be on the right, because all the other icons already have it on 
the right...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add icons for pagelayout options, as needed in Okular

[Noah Davis]

ndavis added a comment.


  In D22617#500168 , @davidhurka 
wrote:
  
  > Other icons with fold in the bottom I could find:
  >
  > - document-duplicate
  > - document-revert-symbolic[-rtl]
  > - kt-restore-defaults
  > - password-copy
  > - viewpdf
  > - xml-node-duplicate
  > - user-desktop-symbolic
  > - document-multiple
  > - folder-documents[-symbolic]
  > - emblem-documents-symbolic
  >
  >   Most icons indeed have the fold at the top, especially Mimetypes icons 
look great. :)
  
  
  Thanks! In case you're not sure, you don't need to change any of those in 
this patch.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add icons for pagelayout options, as needed in Okular

[Noah Davis]

ndavis added a comment.


  In D22617#500031 , @davidhurka 
wrote:
  
  > Makes sense, so I’m flipping snap-page now. Is that written down somewhere?
  
  
  Nope, it was recently decided, but I've had that in the back of my mind for a 
while.
  
  > Previously I thought a fold on the top is for documents, and a fold on the 
bottom for pages. Icons like file-new have a fold on the top, icons like 
insert-page-break have it at the bottom.
  
  I think it doesn't have anything to do with whether the icon is for pages or 
documents, it's just that the document-new icon was created more recently with 
a different style. It might be useful to have a distinction between pages and 
documents, but a different position for the fold isn't enough and I'm not sure 
how to make the difference obvious.
  
  >> Naming Scheme:
  >>  [...]
  > 
  > Because it’s changing the layout of page//s//, not a layout //in a// page, 
yes?
  
  Mainly just to be consistent with existing icon naming schemes, but that's 
another possible reason that I didn't think of.
  
  >> `pagelayout-facing`:
  >>  [...]
  > 
  > I have increased the height by 1px for the 22px icon.
  
  It still looks pretty squished. Here's what I was thinking of: F7077302: 
view-pages-facing.svg 
  
  >> `pagelayout-facing-first-centered`: 
  >>  [...]
  > 
  > I can’t follow you here. Centering the first page is a feature / technical 
detail of Okular, but it indicates that the first page is somehow special, like 
the cover page of a book. But your document could be a single chapter of the 
book as well, so the first page is just a regular odd-numbered page. That page 
should be aligned right.
  
  Since it's an icon for Okular and the feature is called "Facing Pages (Center 
First Page), I don't understand what the problem is with making the top symbol 
centered.
  
  Here's what I had in mind:
  F7077350: view-pages-facing-first-centered.svg 
 F7077351: 
view-pages-facing-first-centered.svg 
  
  In D22617#500141 , @davidhurka 
wrote:
  
  > But it is just a redundancy. Can’t there be a script, which copies icons to 
icons-dark and changes the colors, when compiling the icons?
  
  
  For most icons, probably.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add icons for pagelayout options, as needed in Okular

[Nathaniel Graham]

ngraham added a comment.


  In D22617#500141 , @davidhurka 
wrote:
  
  > In D22617#500131 , @ndavis wrote:
  >
  > > I'll give the latest changes a proper review in a little while.
  > >
  > > In D22617#500046 , @davidhurka 
wrote:
  > >
  > > > What is the icons-dark directory good for? The icons in there are 
mostly just the same as in icons.
  > >
  > >
  > > Non-Qt apps, since they don't work with our stylesheets. Hopefully an XDG 
standard for coloring symbolic/monochrome icons will fix that and then we can 
drop icons-dark.
  >
  >
  > But it is just a redundancy. Can’t there be a script, which copies icons to 
icons-dark and changes the colors, when compiling the icons?
  
  
  Oh that sounds like a lovely idea!!!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22647: Change Highlight to ButtonFocus in stylesheets

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah, and that seems like a sensible practice in general. All right, ship it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  focus-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22647

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22609: Add expanding spacers as a customization option for toolbars

[David Faure]

dfaure added a comment.


  OK, if you don't think there is a use case, let's leave fixed-width spacers 
aside for now.
  
  I was wondering abour the lowercase thing, too. It looks weird. Maybe 
Separator should become uppercase so they can both be?

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22637: Deprecate suggestName

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> global.h:144
>   * @since 5.0
> + * @deprecated Use KFileUtils::suggestName() from KCoreAddons
>   */

I like it when we say when something got deprecated, like this

- @deprecated since 5.61, use KFileUtils::suggestName() from KCoreAddons

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22637

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22638: Port internal usage of KIO::suggestName

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  nodeprecated

REVISION DETAIL
  https://phabricator.kde.org/D22638

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka added a comment.


  In D22617#499767 , @ndavis wrote:
  
  > Nice work!
  >
  > I know a lot of monochrome icons currently use the bottom right position 
for the folded corner, but I think we should start using the top right. The 
bottom right clashes with our convention of putting additional symbols in the 
bottom right and all of our color icons use the top right for the corner fold.
  
  
  Other icons with fold in the bottom I could find:
  
  - document-duplicate
  - document-revert-symbolic[-rtl]
  - kt-restore-defaults
  - password-copy
  - viewpdf
  - xml-node-duplicate
  - user-desktop-symbolic
  - document-multiple
  - folder-documents[-symbolic]
  - emblem-documents-symbolic
  
  Most icons indeed have the fold at the top, especially Mimetypes icons look 
great. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22645: [Busy Indicator] Match duration of QQC2-desktop-style version

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:2a7ce9862942: [Busy Indicator] Match duration of 
QQC2-desktop-style version (authored by ngraham).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22645?vs=62296=62305

REVISION DETAIL
  https://phabricator.kde.org/D22645

AFFECTED FILES
  src/kbusyindicatorwidget.cpp

To: ngraham, sitter, #vdg
Cc: kde-frameworks-devel, cfeck, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka added a comment.


  In D22617#500131 , @ndavis wrote:
  
  > I'll give the latest changes a proper review in a little while.
  >
  > In D22617#500046 , @davidhurka 
wrote:
  >
  > > What is the icons-dark directory good for? The icons in there are mostly 
just the same as in icons.
  >
  >
  > Non-Qt apps, since they don't work with our stylesheets. Hopefully an XDG 
standard for coloring symbolic/monochrome icons will fix that and then we can 
drop icons-dark.
  
  
  But it is just a redundancy. Can’t there be a script, which copies icons to 
icons-dark and changes the colors, when compiling the icons?
  
  >> And I’m a bit concerned that scour-icon removes the 
id="currentColorScheme" attribute from the stylesheet. How do I avoid that?
  > 
  > Hm, you could try removing `--enable-id-stripping` and `--shorten-ids` from 
the command. If anything from this page 
 confuses 
you or doesn't work, be sure to post in the Discussion section. Writing 
documentation isn't a strength of mine, but it's something that has to be done.
  
  Done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22645: [Busy Indicator] Match duration of QQC2-desktop-style version

[Harald Sitter]

sitter accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  match-duration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22645

To: ngraham, sitter, #vdg
Cc: kde-frameworks-devel, cfeck, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22647: Change Highlight to ButtonFocus in stylesheets

[Noah Davis]

ndavis added a comment.


  In D22647#500137 , @ngraham wrote:
  
  > Right, I see that there's actually no regression. In principle, can you 
describe what a color scheme needs to do to avoid this situation?
  
  
  Use a selection background color that is different from the button focus 
decoration color.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22647

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22647: Change Highlight to ButtonFocus in stylesheets

[Nathaniel Graham]

ngraham added a comment.


  Right, I see that there's actually no regression. In principle, can you 
describe what a color scheme needs to do to avoid this situation?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22647

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22647: Change Highlight to ButtonFocus in stylesheets

[Noah Davis]

ndavis added a comment.


  In D22647#500117 , @ngraham wrote:
  
  > Whoa, huge diff. All the more reason why we need to find a way to have all 
the icons use a single external stylesheet.
  >
  > This will require documentation changes as well on 
https://hig.kde.org/style/icon.html and 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips
  
  
  
  
  > As for the change itself, this is what happens when using the light color 
scheme: F7076742: Screenshot_20190722_080127.png 

  > 
  > Seems like this change just shifts the problem from Breeze Dark to regular 
Breeze.
  
  Actually, the problem isn't shifted at all, the change just doesn't fix 
anything for the current versions of Breeze and Breeze Dark. I'm using a custom 
colorscheme that reflects how I want Breeze Dark to look in the future. Breeze 
will use colors like these in the future: F7076861: 
Screenshot_20190722_101754.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22647

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22617: Add icons for pagelayout options, as needed in Okular

[Noah Davis]

ndavis added a comment.


  I'll give the latest changes a proper review in a little while.
  
  In D22617#500046 , @davidhurka 
wrote:
  
  > What is the icons-dark directory good for? The icons in there are mostly 
just the same as in icons.
  
  
  Non-Qt apps, since they don't work with our stylesheets. Hopefully an XDG 
standard for coloring symbolic/monochrome icons will fix that and then we can 
drop icons-dark.
  
  > And I’m a bit concerned that scour-icon removes the id="currentColorScheme" 
attribute from the stylesheet. How do I avoid that?
  
  Hm, you could try removing `--enable-id-stripping` and `--shorten-ids` from 
the command. If anything from this page 
 confuses 
you or doesn't work, be sure to post in the Discussion section. Writing 
documentation isn't a strength of mine, but it's something that has to be done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/18/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 22 Jul 2019 13:58:42 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)28%
(35/123)28%
(35/123)25%
(3334/13138)18%
(1737/9632)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)55%
(490/890)33%
(276/824)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)37%
(1269/3473)26%
(748/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private33%
(6/18)33%
(6/18)42%
(656/1573)29%
(300/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)28%
(574/2024)18%
(316/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 141 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/141/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 22 Jul 2019 13:58:42 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)28%
(35/123)28%
(35/123)25%
(3338/13139)18%
(1738/9632)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)55%
(490/890)33%
(276/824)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)37%
(1269/3473)26%
(748/2841)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private33%
(6/18)33%
(6/18)42%
(656/1573)29%
(300/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2025)18%
(317/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
  

D22647: Change Highlight to ButtonFocus in stylesheets

[Nathaniel Graham]

ngraham requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22647

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22647: Change Highlight to ButtonFocus in stylesheets

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoa, huge diff. All the more reason why we need to find a way to have all 
the icons use a single external stylesheet.
  
  This will require documentation changes as well on 
https://hig.kde.org/style/icon.html and 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips
  
  As for the change itself, this is what happens when using the light color 
scheme: F7076742: Screenshot_20190722_080127.png 

  
  Seems like this change just shifts the problem from Breeze Dark to regular 
Breeze.

REPOSITORY
  R266 Breeze Icons

BRANCH
  focus-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22647

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22647: Change Highlight to ButtonFocus in stylesheets

[Noah Davis]

ndavis retitled this revision from "Change Highlight to ViewFocus in 
stylesheets" to "Change Highlight to ButtonFocus in stylesheets".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22647

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22647: Change Highlight to ViewFocus in stylesheets

[Noah Davis]

ndavis updated this revision to Diff 62303.
ndavis added a comment.


  Change ViewFocus to ButtonFocus to match some elements in the Breeze desktop 
theme

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22647?vs=62299=62303

BRANCH
  focus-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22647

AFFECTED FILES
  icons-dark/actions/12/transform-affect-gradient.svg
  icons-dark/actions/12/transform-affect-pattern.svg
  icons-dark/actions/12/transform-affect-rounded-corners.svg
  icons-dark/actions/12/transform-affect-stroke.svg
  icons-dark/actions/16/artifact.svg
  icons-dark/actions/16/category2parent.svg
  icons-dark/actions/16/child2category.svg
  icons-dark/actions/16/curve-connector.svg
  icons-dark/actions/16/deep-history.svg
  icons-dark/actions/16/dialog-tile-clones.svg
  icons-dark/actions/16/document-compareright.svg
  icons-dark/actions/16/draw-connector.svg
  icons-dark/actions/16/edit-select-original.svg
  icons-dark/actions/16/edit-table-cell-split.svg
  icons-dark/actions/16/edit-table-insert-column-left.svg
  icons-dark/actions/16/edit-table-insert-column-right.svg
  icons-dark/actions/16/edit-table-insert-row-above.svg
  icons-dark/actions/16/edit-table-insert-row-below.svg
  icons-dark/actions/16/edit-table-insert-row-under.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/escape-direction-all.svg
  icons-dark/actions/16/escape-direction-down.svg
  icons-dark/actions/16/escape-direction-horizontal.svg
  icons-dark/actions/16/escape-direction-left.svg
  icons-dark/actions/16/escape-direction-right.svg
  icons-dark/actions/16/escape-direction-up.svg
  icons-dark/actions/16/escape-direction-vertical.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/foreign_green.svg
  icons-dark/actions/16/foreign_red.svg
  icons-dark/actions/16/format-break-node.svg
  icons-dark/actions/16/format-connect-node.svg
  icons-dark/actions/16/format-disconnect-node.svg
  icons-dark/actions/16/format-join-node.svg
  icons-dark/actions/16/format-precision-more.svg
  icons-dark/actions/16/format-remove-node.svg
  icons-dark/actions/16/format-text-capitalize.svg
  icons-dark/actions/16/format-text-lowercase.svg
  icons-dark/actions/16/format-text-uppercase.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/16/insert-button.svg
  icons-dark/actions/16/insert-endnote.svg
  icons-dark/actions/16/insert-footnote.svg
  icons-dark/actions/16/insert-more-mark.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/insert-table-of-contents.svg
  icons-dark/actions/16/insert-table.svg
  icons-dark/actions/16/kr_mountman.svg
  icons-dark/actions/16/kr_syncbrowse_off.svg
  icons-dark/actions/16/kr_syncbrowse_on.svg
  icons-dark/actions/16/layer-bottom.svg
  icons-dark/actions/16/layer-duplicate.svg
  icons-dark/actions/16/layer-lower.svg
  icons-dark/actions/16/layer-next.svg
  icons-dark/actions/16/layer-previous.svg
  icons-dark/actions/16/layer-raise.svg
  icons-dark/actions/16/layer-top.svg
  icons-dark/actions/16/lines-connector.svg
  icons-dark/actions/16/media-show-active-track-amarok.svg
  icons-dark/actions/16/media-track-queue-amarok.svg
  icons-dark/actions/16/mode1.svg
  icons-dark/actions/16/mode2.svg
  icons-dark/actions/16/mode3.svg
  icons-dark/actions/16/mode4.svg
  icons-dark/actions/16/mode5.svg
  icons-dark/actions/16/node-segment-curve.svg
  icons-dark/actions/16/node-segment-line.svg
  icons-dark/actions/16/node-transform.svg
  icons-dark/actions/16/node-type-auto-smooth.svg
  icons-dark/actions/16/node-type-cusp.svg
  icons-dark/actions/16/node-type-smooth.svg
  icons-dark/actions/16/node-type-symmetric.svg
  icons-dark/actions/16/object-to-path.svg
  icons-dark/actions/16/paint-pattern.svg
  icons-dark/actions/16/path-break-apart.svg
  icons-dark/actions/16/path-combine.svg
  icons-dark/actions/16/path-cut.svg
  icons-dark/actions/16/path-effect-parameter-next.svg
  icons-dark/actions/16/path-inset.svg
  icons-dark/actions/16/path-intersection.svg
  icons-dark/actions/16/path-offset-dynamic.svg
  icons-dark/actions/16/path-offset-linked.svg
  icons-dark/actions/16/path-outset.svg
  icons-dark/actions/16/path-reverse.svg
  icons-dark/actions/16/rectangle-make-corners-sharp.svg
  icons-dark/actions/16/selection-move-to-layer-above.svg
  icons-dark/actions/16/selection-move-to-layer-below.svg
  icons-dark/actions/16/show-node-handles.svg
  icons-dark/actions/16/similarartists-amarok.svg
  icons-dark/actions/16/snap-bounding-box-center.svg
  icons-dark/actions/16/snap-bounding-box-corners.svg
  icons-dark/actions/16/snap-bounding-box-edges.svg
  icons-dark/actions/16/snap-bounding-box-midpoints.svg
  icons-dark/actions/16/snap-grid-guide-intersections.svg
  icons-dark/actions/16/snap-nodes-center.svg
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/14/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 22 Jul 2019 13:58:42 +
 Build duration:
4 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_iconitemtest

D22647: Change Highlight to ViewFocus in stylesheets

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22647

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22646: [Busy Indicator] Match duration of QQC2-desktop-style version

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:28bc0f3ea1c1: [Busy Indicator] Match duration of 
QQC2-desktop-style version (authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22646?vs=62297=62300

REVISION DETAIL
  https://phabricator.kde.org/D22646

AFFECTED FILES
  src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml

To: ngraham, broulik, #vdg
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22647: Change Highlight to ViewFocus in stylesheets

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This fixes an issue where changing the selection background color in the 
colorscheme also changes the color of SVG elements using Highlight. This also 
prevents the elements from blending in with the selection background in 
colorschemes that use a different color for selection than the focus decoration.

REPOSITORY
  R266 Breeze Icons

BRANCH
  focus-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22647

AFFECTED FILES
  icons-dark/actions/12/transform-affect-gradient.svg
  icons-dark/actions/12/transform-affect-pattern.svg
  icons-dark/actions/12/transform-affect-rounded-corners.svg
  icons-dark/actions/12/transform-affect-stroke.svg
  icons-dark/actions/16/artifact.svg
  icons-dark/actions/16/category2parent.svg
  icons-dark/actions/16/child2category.svg
  icons-dark/actions/16/curve-connector.svg
  icons-dark/actions/16/deep-history.svg
  icons-dark/actions/16/dialog-tile-clones.svg
  icons-dark/actions/16/document-compareright.svg
  icons-dark/actions/16/draw-connector.svg
  icons-dark/actions/16/edit-select-original.svg
  icons-dark/actions/16/edit-table-cell-split.svg
  icons-dark/actions/16/edit-table-insert-column-left.svg
  icons-dark/actions/16/edit-table-insert-column-right.svg
  icons-dark/actions/16/edit-table-insert-row-above.svg
  icons-dark/actions/16/edit-table-insert-row-below.svg
  icons-dark/actions/16/edit-table-insert-row-under.svg
  icons-dark/actions/16/edit-text-frame-update.svg
  icons-dark/actions/16/escape-direction-all.svg
  icons-dark/actions/16/escape-direction-down.svg
  icons-dark/actions/16/escape-direction-horizontal.svg
  icons-dark/actions/16/escape-direction-left.svg
  icons-dark/actions/16/escape-direction-right.svg
  icons-dark/actions/16/escape-direction-up.svg
  icons-dark/actions/16/escape-direction-vertical.svg
  icons-dark/actions/16/filename-title-amarok.svg
  icons-dark/actions/16/foreign_green.svg
  icons-dark/actions/16/foreign_red.svg
  icons-dark/actions/16/format-break-node.svg
  icons-dark/actions/16/format-connect-node.svg
  icons-dark/actions/16/format-disconnect-node.svg
  icons-dark/actions/16/format-join-node.svg
  icons-dark/actions/16/format-precision-more.svg
  icons-dark/actions/16/format-remove-node.svg
  icons-dark/actions/16/format-text-capitalize.svg
  icons-dark/actions/16/format-text-lowercase.svg
  icons-dark/actions/16/format-text-uppercase.svg
  icons-dark/actions/16/input-mouse-click-left.svg
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/16/input-mouse-click-right.svg
  icons-dark/actions/16/insert-button.svg
  icons-dark/actions/16/insert-endnote.svg
  icons-dark/actions/16/insert-footnote.svg
  icons-dark/actions/16/insert-more-mark.svg
  icons-dark/actions/16/insert-page-break.svg
  icons-dark/actions/16/insert-table-of-contents.svg
  icons-dark/actions/16/insert-table.svg
  icons-dark/actions/16/kr_mountman.svg
  icons-dark/actions/16/kr_syncbrowse_off.svg
  icons-dark/actions/16/kr_syncbrowse_on.svg
  icons-dark/actions/16/layer-bottom.svg
  icons-dark/actions/16/layer-duplicate.svg
  icons-dark/actions/16/layer-lower.svg
  icons-dark/actions/16/layer-next.svg
  icons-dark/actions/16/layer-previous.svg
  icons-dark/actions/16/layer-raise.svg
  icons-dark/actions/16/layer-top.svg
  icons-dark/actions/16/lines-connector.svg
  icons-dark/actions/16/media-show-active-track-amarok.svg
  icons-dark/actions/16/media-track-queue-amarok.svg
  icons-dark/actions/16/mode1.svg
  icons-dark/actions/16/mode2.svg
  icons-dark/actions/16/mode3.svg
  icons-dark/actions/16/mode4.svg
  icons-dark/actions/16/mode5.svg
  icons-dark/actions/16/node-segment-curve.svg
  icons-dark/actions/16/node-segment-line.svg
  icons-dark/actions/16/node-transform.svg
  icons-dark/actions/16/node-type-auto-smooth.svg
  icons-dark/actions/16/node-type-cusp.svg
  icons-dark/actions/16/node-type-smooth.svg
  icons-dark/actions/16/node-type-symmetric.svg
  icons-dark/actions/16/object-to-path.svg
  icons-dark/actions/16/paint-pattern.svg
  icons-dark/actions/16/path-break-apart.svg
  icons-dark/actions/16/path-combine.svg
  icons-dark/actions/16/path-cut.svg
  icons-dark/actions/16/path-effect-parameter-next.svg
  icons-dark/actions/16/path-inset.svg
  icons-dark/actions/16/path-intersection.svg
  icons-dark/actions/16/path-offset-dynamic.svg
  icons-dark/actions/16/path-offset-linked.svg
  icons-dark/actions/16/path-outset.svg
  icons-dark/actions/16/path-reverse.svg
  icons-dark/actions/16/rectangle-make-corners-sharp.svg
  icons-dark/actions/16/selection-move-to-layer-above.svg
  icons-dark/actions/16/selection-move-to-layer-below.svg
  icons-dark/actions/16/show-node-handles.svg
  icons-dark/actions/16/similarartists-amarok.svg
  icons-dark/actions/16/snap-bounding-box-center.svg
  

D22144: Add kio recentlyused:/ to access KactivitytStats data

[Méven Car]

meven updated this revision to Diff 62298.
meven added a comment.


  Disallow getting mimetype or stating non root path

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22144?vs=61929=62298

BRANCH
  arcpatch-D22144

REVISION DETAIL
  https://phabricator.kde.org/D22144

AFFECTED FILES
  CMakeLists.txt
  kio-extras.categories
  recentlyused/CMakeLists.txt
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h
  recentlyused/recentlyused.json

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22646: [Busy Indicator] Match duration of QQC2-desktop-style version

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  match-duration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22646

To: ngraham, broulik, #vdg
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22645: [Busy Indicator] Match duration of QQC2-desktop-style version

[Nathaniel Graham]

ngraham retitled this revision from "[Busy Indicator] Match duration of QML 
version" to "[Busy Indicator] Match duration of QQC2-desktop-style version".

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22645

To: ngraham, sitter, #vdg
Cc: kde-frameworks-devel, cfeck, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22646: [Busy Indicator] Match duration of QQC2-desktop-style version

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: broulik, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Match the duration (2 seconds) that was set in D22630 
.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  match-duration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22646

AFFECTED FILES
  src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml

To: ngraham, broulik, #vdg
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22645: [Busy Indicator] Match duration of QML version

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: sitter, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Match the duration (2 seconds) that was set in D22630 
.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  match-duration (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22645

AFFECTED FILES
  src/kbusyindicatorwidget.cpp

To: ngraham, sitter, #vdg
Cc: kde-frameworks-devel, cfeck, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka added a comment.


  What is the icons-dark directory good for? The icons in there are mostly just 
the same as in icons.
  
  And I’m a bit concerned that scour-icon removes the id="currentColorScheme" 
attribute from the stylesheet. How do I avoid that?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka updated this revision to Diff 62294.
davidhurka added a comment.


  - Rename pagelayout-* to view-pages-*

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62293=62294

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/16/view-pages-continuous.svg
  icons-dark/actions/16/view-pages-facing-first-centered.svg
  icons-dark/actions/16/view-pages-facing.svg
  icons-dark/actions/16/view-pages-overview.svg
  icons-dark/actions/16/view-pages-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/22/view-pages-continuous.svg
  icons-dark/actions/22/view-pages-facing-first-centered.svg
  icons-dark/actions/22/view-pages-facing.svg
  icons-dark/actions/22/view-pages-overview.svg
  icons-dark/actions/22/view-pages-single.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/snap-page.svg
  icons/actions/16/view-pages-continuous.svg
  icons/actions/16/view-pages-facing-first-centered.svg
  icons/actions/16/view-pages-facing.svg
  icons/actions/16/view-pages-overview.svg
  icons/actions/16/view-pages-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/22/view-pages-continuous.svg
  icons/actions/22/view-pages-facing-first-centered.svg
  icons/actions/22/view-pages-facing.svg
  icons/actions/22/view-pages-overview.svg
  icons/actions/22/view-pages-single.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka updated this revision to Diff 62293.
davidhurka added a comment.


  - Remove 24px icons
  - Flip snap-page icons vertically, so the corner fold is at the top-right
  - Make pagelayout-single link to snap-page
  - Flip pagelayout-* icons, except pagelayout-single

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22617?vs=62208=62293

BRANCH
  add-icons-for-pagelayouts

REVISION DETAIL
  https://phabricator.kde.org/D22617

AFFECTED FILES
  icons-dark/actions/16/pagelayout-continuous.svg
  icons-dark/actions/16/pagelayout-facing-first-centered.svg
  icons-dark/actions/16/pagelayout-facing.svg
  icons-dark/actions/16/pagelayout-overview.svg
  icons-dark/actions/16/pagelayout-single.svg
  icons-dark/actions/16/snap-page.svg
  icons-dark/actions/22/pagelayout-continuous.svg
  icons-dark/actions/22/pagelayout-facing-first-centered.svg
  icons-dark/actions/22/pagelayout-facing.svg
  icons-dark/actions/22/pagelayout-overview.svg
  icons-dark/actions/22/pagelayout-single.svg
  icons-dark/actions/22/snap-page.svg
  icons-dark/actions/24/snap-page.svg
  icons/actions/16/pagelayout-continuous.svg
  icons/actions/16/pagelayout-facing-first-centered.svg
  icons/actions/16/pagelayout-facing.svg
  icons/actions/16/pagelayout-overview.svg
  icons/actions/16/pagelayout-single.svg
  icons/actions/16/snap-page.svg
  icons/actions/22/pagelayout-continuous.svg
  icons/actions/22/pagelayout-facing-first-centered.svg
  icons/actions/22/pagelayout-facing.svg
  icons/actions/22/pagelayout-overview.svg
  icons/actions/22/pagelayout-single.svg
  icons/actions/22/snap-page.svg
  icons/actions/24/snap-page.svg

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka added a comment.


  
  
  In D22617#499767 , @ndavis wrote:
  
  > Nice work!
  >
  > I know a lot of monochrome icons currently use the bottom right position 
for the folded corner, but I think we should start using the top right. The 
bottom right clashes with our convention of putting additional symbols in the 
bottom right and all of our color icons use the top right for the corner fold.
  
  
  Makes sense, so I’m flipping snap-page now. Is that written down somewhere?
  
  Previously I thought a fold on the top is for documents, and a fold on the 
bottom for pages. Icons like file-new have a fold on the top, icons like 
insert-page-break have it at the bottom.
  
  > There are some additional changes I would like to see.
  > 
  > Naming scheme:
  >  Since this is changing the view, the naming scheme should be something 
like `view-pages-*` rather than `pagelayout-*`
  
  Because it’s changing the layout of page//s//, not a layout //in a// page, 
yes?
  
  > `pagelayout-single`: 
  >  This should be a relative symlink to `snap-page.svg` since they're the 
same icon.
  
  Ok.
  
  > `pagelayout-facing`:
  >  The 16px version is good, but the larger versions don't use up enough of 
the available canvas. In general, aim to use 100% of the allowed vertical space 
(16px in height with 3px top/bottom margins for 22px) unless that would force 
you to squish the symbols in an unattractive way.
  
  I have increased the height by 1px for the 22px icon.
  
  > `pagelayout-facing-first-centered`: 
  >  The top page should be centered to reflect how the view mode works. I 
think the top page shouldn't be cut off, but that means you'll need to shrink 
the size of the pages overall. This will be particularly difficult for the 16px 
version. If you can't get the 16px version to look right with a 2px margin on 
the top and bottom, I'll accept it with a 1px margin even though that goes 
against the HIG.
  
  I can’t follow you here. Centering the first page is a feature / technical 
detail of Okular, but it indicates that the first page is somehow special, like 
the cover page of a book. But your document could be a single chapter of the 
book as well, so the first page is just a regular odd-numbered page. That page 
should be aligned right.
  
  Now my 16px icon looks like a bunch of arrows, not so fine...
  
  >  ---
  > 
  > I don't think it's necessary to do 24px versions of these icons, but 
there's no harm in doing them. It's just more work.
  
  Removed them.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, 
bruns

D22636: Don't persist authentication

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:95016c51cfc3: Dont persist authentication (authored 
by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22636?vs=62270=62290#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22636?vs=62270=62290

REVISION DETAIL
  https://phabricator.kde.org/D22636

AFFECTED FILES
  src/buffer/org.kde.ktexteditor.katetextbuffer.actions

To: broulik, fvogt, cullmann, aacid
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22609: Add expanding spacers as a customization option for toolbars

[Felix Ernst]

felixernst retitled this revision from "Add spacers as a customization option 
for toolbars" to "Add expanding spacers as a customization option for toolbars".

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22609: Add spacers as a customization option for toolbars

[Felix Ernst]

felixernst added a comment.


  You all are too kind!
  
  > Code looks fine.
  
  First try \o/
  
  I'll put the comments that aren't directly related into another revision.
  I'll rename it to "--- expanding spacer ---" then. So I'll keep it lowercase 
and in the same style as "--- seperator ---" if nobody has a better idea.
  
  > fixed-width spacer
  
  I don't really understand their benefit yet because I can't imagine a 
scenario where I would want one that wouldn't better be solved with an 
expanding one. So to me it seems like it is a widget we don't want to have so 
users don't pick the spacer that is worse in 95 % of cases out of lack of 
knowledge.
  I can be convinced to add a fixed-width one though if I see an example where 
we would want them. We would have to decide what size a fixed-width spacer has.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22638: Port internal usage of KIO::suggestName

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

TEST PLAN
  Builds

REPOSITORY
  R241 KIO

BRANCH
  nodeprecated

REVISION DETAIL
  https://phabricator.kde.org/D22638

AFFECTED FILES
  src/core/copyjob.cpp
  src/filewidgets/knewfilemenu.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/widgets/renamedialog.cpp
  src/widgets/renamedialog.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns