D22751: KTar::openArchive: Remove "bad" assert

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22751

To: aacid, apol
Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22747: Fix KCMulti sidebar margins

[Aleix Pol Gonzalez]

apol added a comment.


  KPageDialog says that with Auto it will behave like a List if just a List of 
pages are passed. Maybe it's a problem there?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D22747

To: ngraham, mart
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22755: [platforms/xcb] Use XRES extension to get real window PID

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's increasingly common for apps to be in their own PID namespace. If
  this is the case, they report a buggy NET_WM_PID on their windows as
  obviously they don't know their own PID.
  
  This patch uses the XResources extension to query the real PID instead
  of asking the window.
  
  This allows the task manager to know the real PID when doing lookups for
  matching services or showing pulseaudio badges.
  
  Querying the NET_WM_ATOM with the NETWM classes remains unchanged, so we
  still have access to all information should a system need it.
  
  BUG: 384837

TEST PLAN
  The relevant unit test KWindowInfo::testPid() still passes whilst using
  this new extension.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22755

AFFECTED FILES
  CMakeLists.txt
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22750: CMakeLists.txt: Allow setting UDEV_RULES_INSTALL_DIR when building

[Alistair Francis]

alistairf abandoned this revision.
alistairf added a comment.


  Not required

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22750

To: alistairf, drosca
Cc: arojas, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22750: CMakeLists.txt: Allow setting UDEV_RULES_INSTALL_DIR when building

[Alistair Francis]

alistairf added a comment.


  Ah, you are right. I didn't realise that. This appears to not be needed.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22750

To: alistairf, drosca
Cc: arojas, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22750: CMakeLists.txt: Allow setting UDEV_RULES_INSTALL_DIR when building

[Antonio Rojas]

arojas added a comment.


  Why is this needed? This is working already as is (that's what the CACHE flag 
is for)

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22750

To: alistairf, drosca
Cc: arojas, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22751: KTar::openArchive: Remove "bad" assert

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  There's nothing the caller of this function can do to control the assert
  condition, so asserting is "too rude", and on top of that there's
  a perfectly valid if below that already handles the condition properly

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22751

AFFECTED FILES
  src/ktar.cpp

To: aacid
Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22750: CMakeLists.txt: Allow setting UDEV_RULES_INSTALL_DIR when building

[Alistair Francis]

alistairf created this revision.
alistairf added a reviewer: drosca.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alistairf requested review of this revision.

REVISION SUMMARY
  Allow the user to overwrite UDEV_RULES_INSTALL_DIR when building. This
  allows distros to specify where the udev rules should go.
  
  Signed-off-by: Alistair Francis 

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D22750

AFFECTED FILES
  CMakeLists.txt

To: alistairf, drosca
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22723: Fix RunnerManager::queryFinished()

[Albert Astals Cid]

aacid added a comment.


  I honestly don't see the problem with this patch, one may argue that the 
ThreadWeaver API is awkward, ok, but this is using it correctly AFAICS, i.e. 
have a ThreadWeaver::QObjectDecorator, give it a ThreadWeaver::Job on its 
constructor, and go on from there.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

metadata editor (and API) for KDE save file dialog?

[René J . V . Bertin]

Hi,

Has it ever been considered to add a (pop-up) widget to the save file dialog 
that would allow to specify metadata key/value pairs when saving a file, plus 
the corresponding API so apps can set it too?

For instance, when a browser downloads a file on Mac it will add a Spotlight 
attribute (really just a standard Unix xattr underneath) that records the 
source URL and download date; this can be quite useful at times. (The system 
uses this information when you're launching a downloaded executable for 
instance, even if the executable is "hidden" inside a disk-image.)


R.

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D22143#502314 , @meven wrote:
  
  > >   Relying on undocumented names of generated sources files does not get 
my +1. That needs someone else to take responsibility :)
  >
  > Well this kind of file generation is common and is indirectly documented 
through the ecm_qt_declare_logging_category macro.
  
  
  The current implementation of the macro is an internal detail. It is not part 
of the API contract.
  Binding one's code to current internal implementation has two disadvantages: 
it makes it harder for the macro developers to enhance the macro, because they 
would break your code, Or they do not know someone is relying on internal 
details, and your code breaks one day.
  
  > I don't think this is an important issue.
  > 
  > For what it is worth, the same technique is used in other repos :
  
  IMHO all cases which are bad code :)
  
  > This does not justify it but makes the points that other KDE devs did not 
see an issue with it.
  
  All us KDE devs have different backgrounds, so not surprising there are 
different opinions :)
  
  > I would gladly use an alternative if presented with one.
  
  I just tried to give one in my previous comment: regenerating the respective 
logging source files in the autotest dir again, by calling the macro there once 
more.
  Or extend the documentation of the macro, to specify the cpp name. Then its 
part of the API contract officially :)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Méven Car]

meven added a comment.


  >   Relying on undocumented names of generated sources files does not get my 
+1. That needs someone else to take responsibility :)
  
  Well this kind of file generation is common and is indirectly documented 
through the ecm_qt_declare_logging_category macro.
  
  I don't think this is an important issue.
  
  For what it is worth, the same technique is used in other repos :
  
  kdebugsettings/autotests/CMakeLists.txt
  22:${CMAKE_BINARY_DIR}/src/kdebugsettings_debug.cpp
  
  plasma-thunderbolt/autotests/kded/CMakeLists.txt
  5:${CMAKE_BINARY_DIR}/src/kded
  11:${CMAKE_BINARY_DIR}/src/kded/kded_bolt_debug.cpp
  
  pulseaudio-qt/autotests/CMakeLists.txt
  8:${CMAKE_BINARY_DIR}/src/debug.cpp
  
  This does not justify it but makes the points that other KDE devs did not see 
an issue with it.
  
  I would gladly use an alternative if presented with one.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22747: Fix KCMulti sidebar margins

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Just need to set the face type to `List`.

TEST PLAN
  F7096922: kcmulti.png 

REPOSITORY
  R295 KCMUtils

BRANCH
  fix-kcmulti-sidebar-margins (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22747

AFFECTED FILES
  src/kcmultidialog.cpp

To: ngraham, mart
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22708: [WIP] Add a kded module infra for fuse mount services

[Andrius da Costa Ribas]

andriusr added inline comments.

INLINE COMMENTS

> CMakeLists.txt:19
>  add_subdirectory(kcms)
> +add_subdirectory(mountserviced)
>  

should we restrict platforms here? (e.g.: NOT WIN32, NOT ANDROID). There are 
fuse wrappers such as winfsp's or dokany's, but possibly those should not work 
there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven marked 2 inline comments as done.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22717

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven marked 3 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> ivan wrote in resultset.cpp:293
> Any reason for the rename?

It is so that the ResourceEvent join in  resourceEventJoinClause works with 
every sql request.
Other wise I would have needed a parameter or multiple functions to make the 
left join work.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22717

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Nope, current solution does not satisfy my personal standards, sorry :)
  Relying on undocumented names of generated sources files does not get my +1. 
That needs someone else to take responsibility :)
  
  If transfering the name via variables s not possible, I would go for 
regenerating the respective logging source files in the autotest dir then again 
instead.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Ivan Čukić]

ivan added a reviewer: kossebau.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Ivan Čukić]

ivan added a comment.


  If @kossebau is satisfied, go for it

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> resultset.cpp:293
>  SELECT
> -rl.targettedResource as resource
> -  , SUM(rsc.cachedScore) as score
> -  , MIN(rsc.firstUpdate) as firstUpdate
> -  , MAX(rsc.lastUpdate)  as lastUpdate
> -  , rl.usedActivity  as activity
> -  , rl.initiatingAgent   as agent
> -  , COALESCE(ri.title, rl.targettedResource) as title
> +from_table.targettedResource as resource
> +  , SUM(rsc.cachedScore) as score

Any reason for the rename?

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22717

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

[Marco Martin]

mart added a comment.


  In D22083#498499 , 
@hpereiradacosta wrote:
  
  > Looking into kcmultidialog, it seems there is some internal handling of 
margins in there, for a reason unknown to me. Maybe you want to investigate 
there too (in a different patch)
  >
  > Hugo
  
  
  It should look better now

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22083

To: mart, #plasma, #frameworks, #vdg, ngraham
Cc: hpereiradacosta, cfeck, ndavis, ngraham, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D22083: introduce concept of header and footer for kpageview

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:b581c5f990a6: introduce concept of header and footer for 
kpageview (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22083?vs=61844=62554#toc

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22083?vs=61844=62554

REVISION DETAIL
  https://phabricator.kde.org/D22083

AFFECTED FILES
  src/kpagedialog.cpp
  src/kpagedialog_p.h
  src/kpageview.cpp
  src/kpageview.h
  src/kpageview_p.h

To: mart, #plasma, #frameworks, #vdg, ngraham
Cc: hpereiradacosta, cfeck, ndavis, ngraham, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, bruns

D22733: Delete redundant and monochrome versions of applications-internet

[Nathaniel Graham]

ngraham added a comment.


  Good idea. I'll submit patches for them and get them in before this lands.

REPOSITORY
  R266 Breeze Icons

BRANCH
  only-colorful-applications-intetnet-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22733

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: Qt dependency policy

[Aleix Pol]

On Sun, Jul 21, 2019 at 12:55 PM David Faure  wrote:
>
> Taking into account the feedback from the SUSE packagers
> (about how dropping support for Qt 5.9 LTS the very month Qt 5.12 LTS comes
> out is a problem since not everyone can upgrade to Qt 5.12 LTS right away)
> I have modified the policy to temporarily support 4 versions when the oldest
> (and newest) are LTS.
>
> https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements

Sounds good to me.
+1

Aleix

D22487: Offer metadata.json when requesting the package metadata

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:40556d1ceae6: Offer metadata.json when requesting the 
package metadata (authored by apol).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22487?vs=61851=62537

REVISION DETAIL
  https://phabricator.kde.org/D22487

AFFECTED FILES
  src/kpackage/package.cpp

To: apol, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

[Alexander Volkov]

volkov updated this revision to Diff 62536.
volkov added a comment.


  fixed

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22737?vs=62531=62536

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22737

AFFECTED FILES
  src/platforms/xcb/kwindowsystem.cpp

To: volkov, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

[Alexander Volkov]

volkov added inline comments.

INLINE COMMENTS

> apol wrote in kwindowsystem.cpp:75
> I don't think that it makes sense to multiply topLeft by dpr, since dpr is 
> local to the screen you're treating.
> 
> How have you tested this?

Only on a single screen. Thanks for notice.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D22737

To: volkov, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kwindowsystem.cpp:75
> +const qreal dpr = screen->devicePixelRatio();
> +region += QRect(geometry.topLeft() * dpr, geometry.size() * dpr);
>  }

I don't think that it makes sense to multiply topLeft by dpr, since dpr is 
local to the screen you're treating.

How have you tested this?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D22737

To: volkov, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/6/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 25 Jul 2019 12:29:35 +
 Build duration:
48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:685959c3fa78: Notify users when not using 
KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh (authored by apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22580?vs=62169=62533

REVISION DETAIL
  https://phabricator.kde.org/D22580

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: apol, #frameworks, albertvaka, cgiboudeaux
Cc: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/13/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 25 Jul 2019 12:09:26 +
 Build duration:
9 min 25 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22714: Add missing KIOWIDGETS_NO_DEPRECTAED check

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:22179dfeb576: Add missing KIOWIDGETS_NO_DEPRECTAED check 
(authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22714?vs=62467=62532

REVISION DETAIL
  https://phabricator.kde.org/D22714

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22723: Fix RunnerManager::queryFinished()

[Aleix Pol Gonzalez]

apol added a dependent revision: D22514: Show if KRunner is still searching for 
more things.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

[Alexander Volkov]

volkov added a reviewer: Frameworks.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D22737

To: volkov, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22737: xcb: Fix setStrut() for High-DPI scaling

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  In addition to _NET_WM_STRUT setStrut() also sets _NET_WM_STRUT_PARTIAL,
  which requires screen's geometry in device pixels.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22737

AFFECTED FILES
  src/platforms/xcb/kwindowsystem.cpp

To: volkov
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Méven Car]

meven updated this revision to Diff 62526.
meven marked 5 inline comments as done.
meven added a comment.


  Better category name

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22143?vs=60786=62526

BRANCH
  arcpatch-D22143

REVISION DETAIL
  https://phabricator.kde.org/D22143

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  kactivities-stats.categories
  src/CMakeLists.txt
  src/common/database/Database.cpp
  src/resultmodel.cpp
  src/resultset.cpp
  src/resultwatcher.cpp

To: meven, ivan, #frameworks
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Méven Car]

meven added a comment.


  @ivan What are you thoughts about this ?

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22717

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22717

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven updated this revision to Diff 62522.
meven added a comment.


  Add an automated test on date filtering

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22717?vs=62520=62522

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22717

AFFECTED FILES
  autotests/QueryTest.cpp
  autotests/QueryTest.h
  autotests/ResultSetTest.cpp
  src/query.cpp
  src/query.h
  src/resultset.cpp
  src/terms.cpp
  src/terms.h
  tests/model/window.cpp
  tests/model/window.ui

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> broulik wrote in klistopenfiles.cpp:39
> Or just make the `pidList` `const` which it should be anyway

Not possible, due to the removeDuplicates() line.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven marked 2 inline comments as done.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22717

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> ivan wrote in resultset.cpp:182
> setDate above is by value, here it is const-ref. Check for the size of the 
> type and decide on one of these.

QDate size is 8 byte, so on most systems nowadays it will equal to a ref size, 
so I am opting towards the simpler and more stable one : by value.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22717

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven updated this revision to Diff 62520.
meven added a comment.


  Optionaly join with ResourceEvent when date filtering is being used, review 
feedback

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22717?vs=62473=62520

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22717

AFFECTED FILES
  autotests/QueryTest.cpp
  autotests/QueryTest.h
  src/query.cpp
  src/query.h
  src/resultset.cpp
  src/terms.cpp
  src/terms.h
  tests/model/window.cpp
  tests/model/window.ui

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22723: Fix RunnerManager::queryFinished()

[Fabian Vogt]

fvogt added a comment.


  In D22723#501907 , @apol wrote:
  
  > In D22723#501690 , @fvogt wrote:
  >
  > > Looks like a hack still, with two Job objects for each job...
  > >
  > > What about just merging `QObjectDecorator` into `FindMatchesJobInternal` 
by basically just adding a custom `done` signal and ignoring the entire 
"decorators which are actually wrappers" business?
  > >
  > > IMO this new `FindMatchesJobInternal` class makes it even less obvious 
what's actually going on.
  >
  >
  > This is how ThreadWeaver and especially QObjectDecorator is meant to be 
used.
  
  
  The way `ThreadWeaver::QObjectDecorator` is apparently meant to be used is to 
wrap the custom job inside a `QObjectDecorator` and use only the wrapper from 
there on:
  
  
https://github.com/KDE/threadweaver/blob/239cf8fffe687c0a758f5170a40b26ae0acef7b0/autotests/QueueTests.cpp#L157
  
autoDeleteJob = new QObjectDecorator(new AppendCharacterJob(QChar('a'), 
));
[...]
QVERIFY(autoDeleteJob != nullptr);
QVERIFY(connect(autoDeleteJob, SIGNAL(done(ThreadWeaver::JobPointer)),
SLOT(deleteJob(ThreadWeaver::JobPointer;
  
  which is not great, to say the least.
  
  What this patch does on the surface is wrap the `QObjectDecorator` inside an 
object that fakes being the custom job itself.
  That's actually a slightly better design than the code above does as now the 
pointer passed from the `done` signal is not the `QObjectDecorator` pointer but 
the custom class.
  
  Still, IMO much better would be to just merge the `QObjectDecorator` into the 
custom job as that would both avoid creating two job objects per job and make 
the code clearer and shorter.
  
  > I don't really know why you say it's confusing. The confusing part so far 
was that jobDone slot was never called.
  
  Which likely happened because the author was confused by the code...

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dfaure wrote in klistopenfiles.cpp:39
> qAsConst(pidList) to avoid a detach

Or just make the `pidList` `const` which it should be anyway

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: Qt dependency policy

[Volker Krause]

On Sunday, 21 July 2019 12:55:21 CEST David Faure wrote:
> Taking into account the feedback from the SUSE packagers
> (about how dropping support for Qt 5.9 LTS the very month Qt 5.12 LTS comes
> out is a problem since not everyone can upgrade to Qt 5.12 LTS right away)
> I have modified the policy to temporarily support 4 versions when the oldest
> (and newest) are LTS.
> 
> https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements

FTR, +1 from me as well, having been part of the discussion about this at the 
sprint.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.