D22960: Add handle icons

[Eike Hein]

hein created this revision.
hein added reviewers: Frameworks, apol, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
hein requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22960

AFFECTED FILES
  KF5Kirigami2Macros.cmake

To: hein, #frameworks, apol, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22958: Add initial Android support to ecm_add_app_icon

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> apol wrote in ECMAddAppIcon.cmake:154
> this if could go up to where we're checking the icon name in an elseif up at 
> line 146.

We'd need to do a `get_filename_component` there and end up either pulling the 
`ext` thing out twice (unless CMake doesn't do block scoping) or ahead of the 
`ABSOLUTE` one and then possibly unnecessarily. FWIW I copied that entire regex 
block out of ECMInstallIcons.cmake to play it safe so I'd prefer not touching 
it ... :-)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22958

To: hein, #frameworks, mart, leinir, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

[Aleix Pol Gonzalez]

apol updated this revision to Diff 63153.
apol added a comment.


  simplify

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22952?vs=63133=63153

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22952

AFFECTED FILES
  src/icon.cpp
  src/icon.h

To: apol, #frameworks, #kirigami
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22958: Add initial Android support to ecm_add_app_icon

[Aleix Pol Gonzalez]

apol added a comment.


  The patch makes sense. +1

INLINE COMMENTS

> ECMAddAppIcon.cmake:154
> +set(ext   "${CMAKE_MATCH_4}")
> +if(NOT ${icon_type} STREQUAL ".svg" OR NOT ${icon_type} 
> STREQUAL ".svgz")
> +message(AUTHOR_WARNING "${icon_full} is not a SVG file - 
> ignoring")

this if could go up to where we're checking the icon name in an elseif up at 
line 146.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22958

To: hein, #frameworks, mart, leinir, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22955: Add icon used by Kirigami.AboutPage

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c17c048ec2f7: Add icon used by Kirigami.AboutPage 
(authored by hein).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22955?vs=63146=63152

REVISION DETAIL
  https://phabricator.kde.org/D22955

AFFECTED FILES
  KF5Kirigami2Macros.cmake

To: hein, #frameworks, mart, apol
Cc: mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, hein

D22955: Add icon used by Kirigami.AboutPage

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22955

To: hein, #frameworks, mart, apol
Cc: mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, hein

D22958: Add initial Android support to ecm_add_app_icon

[Eike Hein]

hein added a comment.


  This is the culmination of a patch series that makes About dialogs in 
Kirigami work reasonably across platforms:
  
  F7168840: about.jpg 

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22958

To: hein, #frameworks, mart, leinir, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22958: Add initial Android support to ecm_add_app_icon

[Eike Hein]

hein added a comment.


  The code is mostly copy-and-pasted together from ECMAddAppIcon.cmake and 
ECMInstallIcons.cmake.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22958

To: hein, #frameworks, mart, leinir, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22958: Add initial Android support to ecm_add_app_icon

[Eike Hein]

hein created this revision.
hein added reviewers: Frameworks, mart, leinir, apol.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
hein requested review of this revision.

REVISION SUMMARY
  Kirigami has a `kirigami_package_breeze_icons` CMake macro that
  KDE Frameworks apps targeting Android use to extract icons from
  the Breeze theme into a folder that will get picked up by our
  SDK for inclusion in the eventual .apk binary package.
  
  Applications that bundle their own application icon that is not
  included in the Breeze theme do not benefit from this, as that
  macro relies on making a clone of breeze-icons.git to work from,
  and as those apps install their icons into the "hicolor" theme
  instead anyway, as is spec-conformant.
  
  This e.g. means that the application icon won't show on the
  Kirigami.AboutPage Qt Quick component, which is used to display
  the About dialogs in Kirigami apps.
  
  This patch makes ecm_app_icon put app icons into the same
  folder, if the constraints of being on Android and being a SVG
  icon are satisfied, causing the icon to be picked up into the
  .apk.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22958

AFFECTED FILES
  modules/ECMAddAppIcon.cmake

To: hein, #frameworks, mart, leinir, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22698: Support passing target to ki18n_wrap_ui macro

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:8f84d19aad04: Support passing target to ki18n_wrap_ui 
macro (authored by daandemeyer, committed by aacid).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22698?vs=62459=63150

REVISION DETAIL
  https://phabricator.kde.org/D22698

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: daandemeyer, ilic
Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

Re: KCrash crash racing

[Albert Astals Cid]

El dimecres, 31 de juliol de 2019, a les 12:26:23 CEST, Harald Sitter va 
escriure:
> Moin Moin!
> 
> I've been haunting down a nasty backtrace problem in drkonqi where it
> entirely fails to create a backtrace and am now fairly confident this
> is in fact a design flaw with kcrash, but I have no awesome ideas on
> how to solve this properly.
> 
> Long story short: there is a space of time between SEGV occurring and
> drkonqi stopping the threads. This causes (e.g.) GIO threads to
> actively unavoidably crash the process. Most recently this could/can
> be observed with plasmashell which has a GIO thread sitting around
> when (I think) flatpak updates are being checked. The result is that
> the crash cannot be traced because the process dies before drkonqi has
> a chance to deal with it.
> 
> If you have ever seen a warning or error of the kind "XCB connection
> lost" or something similar it is in fact the very same problem, albeit
> usually not fatal.
> 
> When a process crashes SEGV is sent to any one thread. The other
> threads continue to run!
> When the SEGV arrives the standard handler will possibly restart the
> process, then close all open file descriptors, potentially start (and
> wait for) drkonqi and when drkonqi has worked its magic raise itself
> to a core pattern process if applicable [1].
> The threads have still not been suspended!
> When drkonqi starts, it sends STOP to the crashed process. STOP is
> delivered to every thread, thus stopping everything this time around.
> Only now is the process "safe" from crashing while crashing.
> 
> And that's the race right there. In between the file descriptors
> getting closed and the STOPping the threads that aren't being handled
> and continue to run to potentially access the now-closed file
> descriptors. In GIO's case it can try to read inotify events and run
> into an error (e.g. in ik_source_read_some_events) and g_error, which
> as far as I can tell will result in a TRAP because g_error almost
> always(?) ends in g_abort.
> 
> The solution is simply: we shouldn't close FDs before all threads are stopped.
> 
> Practically I can't think of a way to actually pull this off though.
> We'd need to close the FDs *at* STOP. But STOP like KILL cannot be
> handled.
> 
> I think the actual solution here would need to be that kcrash stops
> invoking drkonqi and instead defers to a core handler through which
> drkonqi can get access to the core.
> Trouble is that there can only be one core handler and there are more
> software providers on a system than just us, so I guess this isn't
> really a viable solution :/
> Also the core stuff isn't too portable I think.
> 
> I am fairly out of ideas :/

Tried looking at what breakpad does?

Cheers,
  Albert

P.S: I've no idea if i'm saying something stupid, sorry if i am ^_^

> 
> [1] http://man7.org/linux/man-pages/man5/core.5.html
> 

D22955: Add icon used by Kirigami.AboutPage

[Eike Hein]

hein created this revision.
hein added reviewers: Frameworks, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
hein requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22955

AFFECTED FILES
  KF5Kirigami2Macros.cmake

To: hein, #frameworks, mart
Cc: mart, plasma-devel, fbampaloukas, domson, dkardarakos, apol, 
davidedmundson, hein

D22698: Support passing target to ki18n_wrap_ui macro

[Chusslove Illich]

ilic accepted this revision.
This revision is now accepted and ready to land.

REVISION DETAIL
  https://phabricator.kde.org/D22698

To: daandemeyer, ilic
Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

D22698: Support passing target to ki18n_wrap_ui macro

[Alex Merry]

alexmerry added a comment.


  Since you tagged me in this, I'll say that (as a former maintainer of 
Extra-CMake-Modules as well as someone who still makes extensive use of CMake 
professionally despite not doing much KDE stuff these days) the change looks 
good (and following modern conventions) from a CMake perspective.
  
  The rest of KI18N_WRAP_UI is less nice (from a modern CMake perspective), but 
as a minimal change to support a feature that helps write cleaner CMake code 
downstream, I think this is a good patch.

REVISION DETAIL
  https://phabricator.kde.org/D22698

To: daandemeyer, ilic
Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

D22709: Support passing target to ecm_add_app_icon.

[Daan De Meyer]

daandemeyer added a comment.


  Ping

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22709

To: daandemeyer, alexmerry, dschmidt
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22699: Support passing target to ecm_qt_declare_logging_category

[Daan De Meyer]

daandemeyer added a comment.


  Ping

REVISION DETAIL
  https://phabricator.kde.org/D22699

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22768: Forward declare KLocalizedString and make I18n a private dependency.

[Daan De Meyer]

daandemeyer added a comment.


  Ping

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D22768

To: daandemeyer, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22698: Support passing target to ki18n_wrap_ui macro

[Daan De Meyer]

daandemeyer added a comment.


  To give an example of how the addition would improve KDE CMake build scripts, 
let's look at part of Kate's CMake build script.
  
  It currently looks like this:
  
# collect the needed source files
set (KATE_LIBRARY_SRCS
   kateappadaptor.cpp
   kateapp.cpp
   kateconfigdialog.cpp
   kateconfigplugindialogpage.cpp
   katedocmanager.cpp
   katefileactions.cpp
   katemainwindow.cpp
   katepluginmanager.cpp
   kateviewmanager.cpp
   kateviewspace.cpp
   katesavemodifieddialog.cpp
   katemwmodonhddialog.cpp
   katecolorschemechooser.cpp
   katequickopenmodel.cpp
   katetabbutton.cpp
   katetabbar.cpp

   # session
   session/katesessionsaction.cpp
   session/katesessionmanager.cpp
   session/katesessionmanagedialog.cpp
   session/katesession.cpp

   katemdi.cpp
   katerunninginstanceinfo.cpp
   katequickopen.cpp
   katewaiter.h
)

ki18n_wrap_ui(KATE_LIBRARY_SRCS
ui/sessionconfigwidget.ui
session/katesessionmanagedialog.ui
)

add_library(kdeinit_kate STATIC ${KATE_LIBRARY_SRCS})
  
  If the proposed change is accepted, it could be refactored to the following:
  
add_library(kdeinit_kate STATIC "")

ki18n_wrap_ui(kdeinit_kate
ui/sessionconfigwidget.ui
session/katesessionmanagedialog.ui
)

target_sources(kdeinit_kate PRIVATE
   kateappadaptor.cpp
   kateapp.cpp
   kateconfigdialog.cpp
   kateconfigplugindialogpage.cpp
   katedocmanager.cpp
   katefileactions.cpp
   katemainwindow.cpp
   katepluginmanager.cpp
   kateviewmanager.cpp
   kateviewspace.cpp
   katesavemodifieddialog.cpp
   katemwmodonhddialog.cpp
   katecolorschemechooser.cpp
   katequickopenmodel.cpp
   katetabbutton.cpp
   katetabbar.cpp

   # session
   session/katesessionsaction.cpp
   session/katesessionmanager.cpp
   session/katesessionmanagedialog.cpp
   session/katesession.cpp

   katemdi.cpp
   katerunninginstanceinfo.cpp
   katequickopen.cpp
   katewaiter.h
)
  
  
  
  - We don't need a `SRCS` variable anymore. Instead, generated files are added 
directly to the library target using the `target_sources` command.
  - The order commands are called in becomes more intuitive. We can call 
`add_library` first, follow with the `ki18n_wrap_ui` command and end with 
specifying the long list of source files instead of having to start the script 
with specifying all source files.

REVISION DETAIL
  https://phabricator.kde.org/D22698

To: daandemeyer, ilic
Cc: ltoscano, alexmerry, turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, 
sbergeron, michaelh, ngraham, bruns

D22724: Add ECMAddQtDesignerPlugin

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:6709de184aa3: Add ECMAddQtDesignerPlugin (authored by 
kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22724?vs=62676=63136

REVISION DETAIL
  https://phabricator.kde.org/D22724

AFFECTED FILES
  docs/module/ECMAddQtDesignerPlugin.rst
  modules/ECMAddQtDesignerPlugin.cmake

To: kossebau, #build_system, #frameworks
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, 
bencreasy, michaelh, ngraham, bruns

D22952: Kirigami.Icon: Fix loading bigger images when source is a URL

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Port to using the QImage::load() that takes a QIODevice and only do it when 
the
  execution is finished, instead of upon readyRead(). This makes sure that we 
are
  only processing the icon when is fully downloaded.
  
  BUG: 407409
  BUG: 400312

TEST PLAN
  Reproduced the bug and fixed it

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22952

AFFECTED FILES
  src/icon.cpp
  src/icon.h

To: apol, #frameworks, #kirigami
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22884: [RFC] Don't show title on page by default

[Nathaniel Graham]

ngraham added a comment.


  In D22884#506943 , 
@hpereiradacosta wrote:
  
  > "KPageWidgetItems live in a multi-page KPageDialog"
  >  Is that really true ? Does it not live also standalone when running e.g. 
kcmshell5 kwindecoration (or any other kcm ?)
  >  If yes, and at least in this case, the title has to stay, because there is 
no side bar.
  
  
  This patch simply adjusts the defaults. If we decide to do this, KCMShell can 
be adjusted to show the title on the page when showing a single KCM. But even 
then it's not really necessary IMO because the KCMShell window's titlebar 
already shows the KCM title.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22884

To: ngraham, #vdg, mart, cfeck
Cc: hpereiradacosta, broulik, aspotashev, GB_2, ndavis, cfeck, mmustac, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22942: [kded/baloosearchmodule] Remove useless qDebug messages

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  no-qdebug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22942

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

Re: KCrash crash racing

[Aleix Pol]

On Wed, Jul 31, 2019 at 12:26 PM Harald Sitter  wrote:
>
> Moin Moin!
>
> I've been haunting down a nasty backtrace problem in drkonqi where it
> entirely fails to create a backtrace and am now fairly confident this
> is in fact a design flaw with kcrash, but I have no awesome ideas on
> how to solve this properly.
>
> Long story short: there is a space of time between SEGV occurring and
> drkonqi stopping the threads. This causes (e.g.) GIO threads to
> actively unavoidably crash the process. Most recently this could/can
> be observed with plasmashell which has a GIO thread sitting around
> when (I think) flatpak updates are being checked. The result is that
> the crash cannot be traced because the process dies before drkonqi has
> a chance to deal with it.
>
> If you have ever seen a warning or error of the kind "XCB connection
> lost" or something similar it is in fact the very same problem, albeit
> usually not fatal.
>
> When a process crashes SEGV is sent to any one thread. The other
> threads continue to run!
> When the SEGV arrives the standard handler will possibly restart the
> process, then close all open file descriptors, potentially start (and
> wait for) drkonqi and when drkonqi has worked its magic raise itself
> to a core pattern process if applicable [1].
> The threads have still not been suspended!
> When drkonqi starts, it sends STOP to the crashed process. STOP is
> delivered to every thread, thus stopping everything this time around.
> Only now is the process "safe" from crashing while crashing.
>
> And that's the race right there. In between the file descriptors
> getting closed and the STOPping the threads that aren't being handled
> and continue to run to potentially access the now-closed file
> descriptors. In GIO's case it can try to read inotify events and run
> into an error (e.g. in ik_source_read_some_events) and g_error, which
> as far as I can tell will result in a TRAP because g_error almost
> always(?) ends in g_abort.
>
> The solution is simply: we shouldn't close FDs before all threads are stopped.
>
> Practically I can't think of a way to actually pull this off though.
> We'd need to close the FDs *at* STOP. But STOP like KILL cannot be
> handled.
>
> I think the actual solution here would need to be that kcrash stops
> invoking drkonqi and instead defers to a core handler through which
> drkonqi can get access to the core.
> Trouble is that there can only be one core handler and there are more
> software providers on a system than just us, so I guess this isn't
> really a viable solution :/
> Also the core stuff isn't too portable I think.

Well, yes. It's a complex issue as we're dealing with a dying process.

My impression is that relying on core handlers makes a lot of sense,
there would be some questions to answer such as "what happens when
running on other systems". Maybe for now we could try doing an
in-between? Handling cores on plasma and using drkonqi as we do now
otherwise?

Does drkonqi work nowadays at all on systems that aren't Linux/BSD?

Aleix

D22946: Include API to generically implement --replace arguments

[Aleix Pol Gonzalez]

apol updated this revision to Diff 63124.
apol added a comment.


  More documentation.
  Don't wait for the original process to finish.

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22946?vs=63116=63124

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22946

AFFECTED FILES
  src/kdbusservice.cpp
  src/kdbusservice.h

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/22/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 05 Aug 2019 13:59:07 +
 Build duration:
7 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/29/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 05 Aug 2019 13:59:07 +
 Build duration:
6 min 56 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33492/61079)39%
(17059/43959)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9343/9793)48%
(4286/9007)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8530/14438)51%
(4696/9207)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4628/8241)42%
(2006/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(371/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
  

D22763: [KDirOperator] Use more human-readable sort order descriptions

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:10b6d83bbc4c: [KDirOperator] Use more human-readable sort 
order descriptions (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22763?vs=62711=63122

REVISION DETAIL
  https://phabricator.kde.org/D22763

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: meven, ngraham, #frameworks, nicolasfella
Cc: churaev, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22946: Include API to generically implement --replace arguments

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> apol wrote in kdbusservice.h:121
> I'd say this is for applications using KDBusService really and it's not like 
> this is the only usage of this org.qtproject.* here.

By just reading the API dox, I would have assumed one can replace any "unique 
service" with the well-known name, not just services using the same 
toolkit/libaries. Only when I saw the implementation, it became obvious.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Aleix Pol Gonzalez]

apol updated this revision to Diff 63116.
apol added a comment.


  error handling

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22946?vs=63115=63116

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22946

AFFECTED FILES
  src/kdbusservice.cpp
  src/kdbusservice.h

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> kossebau wrote in kdbusservice.h:121
> A unique service which has a /MainApplication object implementing a 
> rg.qtproject.Qt.QCoreApplication interface,...
> 
> Any chance to make this non-Qt-only?

I'd say this is for applications using KDBusService really and it's not like 
this is the only usage of this org.qtproject.* here.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kdbusservice.cpp:119
> +}
> +}
> +

What if the quit fails? No error handling?

I fear for having such logic in the library it needs to be more elaborared IMHO.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kdbusservice.h:121
> + * Indicates that if there's already a unique service running, to be 
> quit and replaced
> + * with our own.
> + *

A unique service which has a /MainApplication object implementing a 
rg.qtproject.Qt.QCoreApplication interface,...

Any chance to make this non-Qt-only?

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Aleix Pol Gonzalez]

apol updated this revision to Diff 63115.
apol added a comment.


  Argument -> flag

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22946?vs=63114=63115

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22946

AFFECTED FILES
  src/kdbusservice.cpp
  src/kdbusservice.h

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Aleix Pol Gonzalez]

apol edited the summary of this revision.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Aleix Pol Gonzalez]

apol marked 3 inline comments as done.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22884: [RFC] Don't show title on page by default

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  "KPageWidgetItems live in a multi-page KPageDialog"
  Is that really true ? Does it not leave also standalone when running e.g. 
kcmshell5 kwindecoration (or any other kcm ?)
  If yes, and at least in this case, the title has to stay, because there is no 
side bar.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22884

To: ngraham, #vdg, mart, cfeck
Cc: hpereiradacosta, broulik, aspotashev, GB_2, ndavis, cfeck, mmustac, 
kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kossebau wrote in kdbusservice.h:151
> Please no "bool" type argument, this makes places calling harder to 
> understand -> https://community.kde.org/Policies/Library_Code_Policy#Flags

especially given there is an `options` flag already, you can just add another 
flag for this

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Just some API style nitpicks while this was by-passing. Not dealt with 
KDBusService recently, so cannot really comment otherwise. 
QCoreApplication::processEvents() in the constructor though makes me feel 
uncomfortable, any chance to make this async?

INLINE COMMENTS

> kdbusservice.h:150
> + * This is is meant to be used to implement the --replace argument on 
> applications.
> + */
> +explicit KDBusService(StartupOptions options, bool replace, QObject 
> *parent = nullptr);

@since missing

> kdbusservice.h:151
> + */
> +explicit KDBusService(StartupOptions options, bool replace, QObject 
> *parent = nullptr);
> +

Please no "bool" type argument, this makes places calling harder to understand 
-> https://community.kde.org/Policies/Library_Code_Policy#Flags

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: kossebau, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22946: Include API to generically implement --replace arguments

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  It's quite wide-spread in KDE applications, and having to implement it in 
every
  application isn't very efficient.
  This adds an argument to suggest this replace so applications can share the
  implementation.

TEST PLAN
  Ported plasmashell to it, works.

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22946

AFFECTED FILES
  src/kdbusservice.cpp
  src/kdbusservice.h

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 63107.
leinir added a comment.


  - Use typed animations instead of the inefficient PropertyAnimation

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=62850=63107

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22942: [kded/baloosearchmodule] Remove useless qDebug messages

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Baloo, bruns, ngraham.
Herald added projects: Frameworks, Baloo.
poboiko requested review of this revision.

REVISION SUMMARY
  Those messages are not informative anyway; they are categorized as "kdeinit5";
  and they tend to spam logs during indexing with filenames of indexed files.

TEST PLAN
  make

REPOSITORY
  R293 Baloo

BRANCH
  no-qdebug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22942

AFFECTED FILES
  src/kioslaves/kded/baloosearchmodule.cpp

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D22528: KIO FTP: Fix file copy hanging when copying to existing file

[Harald Sitter]

sitter added a comment.


  @dfaure are we ok to land this for now?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: rikmills, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns