D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Not having `id="current-color-scheme"` causes stylesheets to not work 
correctly.

INLINE COMMENTS

> depth16to8.svg:1
> -http://www.w3.org/2000/svg; viewBox="0 0 22 22">
> -  
> -

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Nathaniel Graham]

ngraham added subscribers: ndavis, ngraham.
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  `FIXED-IN: ` refers to the next release (i.e. the one that this fix will make 
it into). The latest released version of KDE Frameworks is 5.61, so the next 
one is 5.62.
  
  I imagine the Digikam Windows build scoops up all the relevant assets liek 
icons and includes them in the installed app. If not, then the breeze-icons 
framework actually gets installed on Windows somewhere. Either way, you don't 
need to do anything else.
  
  LGTM! All good, @ndavis?

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

[Albert Astals Cid]

aacid added a comment.


  hmmm, now that i think about it LC_ALL probably needs a .UTF-8 suffix or 
something to be correct
  
  But OTOH this is working fine for me.
  
  comments?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: kde-frameworks-devel, asemke, LeGast00n, michaelh, ngraham, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  We were only setting LANGUAGE, but that does not set LC_TIME so the time was 
still
  set to the "system" locale, we now set LC_ALL to switch the application 
completely to that language

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23119

AFFECTED FILES
  autotests/kxmlgui_unittest.cpp
  src/kswitchlanguagedialog_p.cpp

To: aacid
Cc: kde-frameworks-devel, asemke, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 added a comment.


  I am not quite sure of the version for the FIXED-IN tag.
  
  Also, this bug was reported in digikam running on Windows 10, are there any 
additional steps necessary to get this change from breeze-icons to the digikam 
Windows build?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23116

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-depth-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23116

AFFECTED FILES
  icons-dark/actions/22/depth16to8.svg
  icons-dark/actions/22/depth8to16.svg
  icons/actions/22/depth16to8.svg
  icons/actions/22/depth8to16.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

[sysadmin/ci-tooling] craftmaster: Include SnoreToast in the Windows CI system.

[Ben Cooksley]

Git commit 4015e2bbba5a2eb2719f0979848dc86d28c67a31 by Ben Cooksley.
Committed on 12/08/2019 at 19:09.
Pushed by bcooksley into branch 'master'.

Include SnoreToast in the Windows CI system.

This should repair KNotifications builds on Windows and restore the 
maintainability of the CI system on Windows (which is currently impaired due to 
this unannounced new hard dependency)

CCMAIL: kde-frameworks-devel@kde.org

M  +4-1craftmaster/packages.list

https://invent.kde.org/sysadmin/ci-tooling/commit/4015e2bbba5a2eb2719f0979848dc86d28c67a31

diff --git a/craftmaster/packages.list b/craftmaster/packages.list
index 986c61c..62d357d 100644
--- a/craftmaster/packages.list
+++ b/craftmaster/packages.list
@@ -29,7 +29,10 @@ libs/libxml2
 data/docbook-dtd
 data/docbook-xsl
 perl-modules/uri-url
-perl-modules/xml-parser
+perl-modules/xml-pars
+
+# KNotification
+dev-utils/snoretoast
 
 # KWallet
 libs/gcrypt

Re: KCalendarCore plugins/datasources?

[Volker Krause]

On Sunday, 11 August 2019 12:12:10 CEST Bhushan Shah wrote:
> [I am not subscribed to kde-pim list, please keep me or k-f-d in CC]
> 
> Hello,
> 
> So yesterday I was discussing this with the Volker in #kde-devel, that
> currently kcalcore doesn't provide a "plugin interface" to create a
> various data sources like, file storage, online/cloud storage, or
> akonadi storage, and Akonadi have it's own custom code for this.
> 
> Would it make sense to have something like this in kcalcore itself?
> Volker mentioned to me that it needs close look at Akonadi based
> implementation and trying to finalize API.

The main use-case I see for this is using the platform calendar on systems 
like Android that have such a concept, rather than an Akonadi backend, ie. I'd 
not see this as a direct interface to e.g. a CalDav server.

KCalCore is certainly the right data model for this regarding events/todos and 
a collection thereof, but it might not model enough of what is behind that, 
such as multiple calendars fed from different backends as present on Android 
or Akonadi, as well as API interacting with those (e.g. triggering a re-sync).

For Akonadi that code is in akonadi-calendar and/or calendarsupport (I'm not 
too familiar with the details, IIRC this is largely Sergio's work). For 
Android see 
https://developer.android.com/guide/topics/providers/calendar-provider, esp. 
the Calendar table.

I think a proper data source abstraction would need to model this part too, 
without going too much into an account concept, that should be left to the 
corresponding backend.

For content access KCalCore::Calendar is probably a decent abstraction, it 
might be worth checking if the Akonadi code is extending or breaching that 
abstraction for some reason, so we don't miss anything here.

A low-tier plugin system would be quite attractive then IMHO, it could for 
example also avoid some of the current Plasma/Akonadi calendar integration 
complexity. Prototyping that outside of KCalCore initially makes sense 
probably, but I could see that go into KCalCore eventually.

Regards,
Volker


signature.asc
Description: This is a digitally signed message part.

D22528: KIO FTP: Fix file copy hanging when copying to existing file

[Yaroslav Sidlovsky]

ZaWertun abandoned this revision.
ZaWertun added a comment.


  No problem. I'm closing revision then.
  Thanks for the feedback.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: ngraham, rikmills, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

[Harald Sitter]

sitter added a comment.


  Well, we *could* land it, I am also not sure if that is a net-improvement 
though. As David said we are playing ping-pong with bugs and all of them are 
symptoms of the larger issue that error handling is done inconsistently, which 
in turn is why fixing one bug causes another, as has happened here. This will 
keep on happening until we address the root problem. If you want to help with 
facilitating that what I really want is a quick and dirty integration test 
system built for ftp so we can check such high level functionality as "can I 
overwrite a file".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: ngraham, rikmills, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

[Nathaniel Graham]

ngraham added a comment.


  > but sure, whatever, if you think it's better with this commit than with the 
earlier equally broken two versions, I'm not objecting.
  
  @sitter so what do you think, should we land this in the meantime?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: ngraham, rikmills, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21661: add snoretoast backend for KNotifications on Windows

[Volker Krause]

vkrause added a comment.


  It looks like this made D-Bus and Phonon hard required dependencies on 
Android again!?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: vkrause, nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

Re: KCalendarCore plugins/datasources?

[Allen Winter]

On Monday, August 12, 2019 6:49:48 AM EDT Daniel Vrátil wrote:
> On Sunday, 11 August 2019 12:12:10 CEST Bhushan Shah wrote:
> > [I am not subscribed to kde-pim list, please keep me or k-f-d in CC]
> > 
> > Hello,
> 
> Hi Bhushan,
> 
> > 
> > So yesterday I was discussing this with the Volker in #kde-devel, that
> > currently kcalcore doesn't provide a "plugin interface" to create a
> > various data sources like, file storage, online/cloud storage, or
> > akonadi storage, and Akonadi have it's own custom code for this.
> > Would it make sense to have something like this in kcalcore itself?
> > Volker mentioned to me that it needs close look at Akonadi based
> > implementation and trying to finalize API.
> 
> There's KCalendarCore::CalStorage which allows users to write their own 
> calendar data sources, which could be used as a plugin interface. Extending 
> the library with a plugin infrastructure would also be OK IMO, but if we want 
> to have a bunch of plugins to integrate between KCalendarCore and various 
> backend-specific libraries (e.g. KGAPI, KDAV, Kolab, ...), we should create 
> KCalendarAddons (or something like that), assuming there's actually any 
> demand 
> for this.
> 
> For Akonadi the way it works is that we create an instance of 
> KCalendarCore::Calendar and directly populate it with entities loaded from 
> Akonadi. We don't use the CalStorage interface for that as we don't need that 
> kind of abstraction to integrate between KCalendarCore and Akonadi.
> 
Agree with Dan.
I'd say not to put plugins directly into KCalendarCore, but create a new repo 
for that purpose.
If needed.

D23112: Add a event Spy for GtkFileChooser recent files

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> GtkEventSpy.cpp:125
> +
> +app.name = attributes.value("exec");
> +// remove "'" caracters wrapping the command and any character after 
> a space

It stores the full `Exec` line of the desktop file, including the `%u`.
What you probably want do to is use `KServiceTypeTrader` to find the 
application with said Exec line.

  auto services = 
KServiceTypeTrader::self()->query(QStringLiteral("Application"), 
QStringLiteral("exist Exec and ('%1' == Exec)").arg(cmd));

and then operate on the `KService` desktop file name, e.g. `org.gnome.evince` 
instead of the executable.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Kai Uwe Broulik]

broulik added a comment.


  Can you check out the `KBookmarks` framework which has classes for processing 
xbel files

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, ivan.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  GtkFileChooser/GtkRecentManager follows 
https://www.freedesktop.org/wiki/Specifications/desktop-bookmark-spec/ 
specification to store its recently accessed files.
  The history is stored in $HOME/.local/share/recently-used.xbel
  
  Adds an event spy for the xml file used by gtk following the example of the 
KRecentDocument EventSpy.
  
  It allows to populate recently accessed files from apps using Gtk, including 
inkscape, gimp...

TEST PLAN
  Compile
  killall -9 kactivitymanage
  run your localy built version of kactivitymanagerd, for instance:
  ~/kde/usr/lib/x86_64-linux-gnu/libexec/kactivitymanagerd
  Run a gtk app and open a file
  The file access can be seen in kickoff/kicker history

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko added inline comments.

INLINE COMMENTS

> dhaumann wrote in definition.h:339
> Please improve the API documentation and add, for instance:
> 
> - Only existing keywordLists() can be changed. For non-existent keyword 
> lists, false is returned.
> - @see keywordList(), keywordLists()
> 
> What I am currently also missing is a section about highlight invalidation: 
> Does one have to trigger a document rehighlight oneself, and if so, how?
> 
> My point is: Assume a doc is highlighted up to line 100. Now you add keywords 
> to a list that are used in these 100 lines, i.e. the highlighting may change 
> arbitrarily.
> 
> How is the KSyntaxHighlighting user supposed to trigger a rehighlight? Or 
> should one only change keyword lists before highlighting any document?

I more thinking in variant, when the highlighting more dynamic, and is done 
more, that one time. For example, in Cantor, we rehighlight whole worksheet, 
when a new variable created in curresponding session. So, if you write "my_var 
= 3" in Python session (and run command cell with this command), "my_var" 
starts to highlight by Cantor as variable after that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23061

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D23061: Possiblity to change Definition data after loading

[Nikita Sirgienko]

sirgienko updated this revision to Diff 63599.
sirgienko added a comment.


  Add test and change the function description

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23061?vs=63492=63599

BRANCH
  read-write

REVISION DETAIL
  https://phabricator.kde.org/D23061

AFFECTED FILES
  autotests/syntaxrepository_test.cpp
  src/lib/definition.cpp
  src/lib/definition.h
  src/lib/keywordlist_p.h

To: sirgienko, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

Re: KCalendarCore plugins/datasources?

[Daniel Vrátil]

On Sunday, 11 August 2019 12:12:10 CEST Bhushan Shah wrote:
> [I am not subscribed to kde-pim list, please keep me or k-f-d in CC]
> 
> Hello,

Hi Bhushan,

> 
> So yesterday I was discussing this with the Volker in #kde-devel, that
> currently kcalcore doesn't provide a "plugin interface" to create a
> various data sources like, file storage, online/cloud storage, or
> akonadi storage, and Akonadi have it's own custom code for this.
> Would it make sense to have something like this in kcalcore itself?
> Volker mentioned to me that it needs close look at Akonadi based
> implementation and trying to finalize API.

There's KCalendarCore::CalStorage which allows users to write their own 
calendar data sources, which could be used as a plugin interface. Extending 
the library with a plugin infrastructure would also be OK IMO, but if we want 
to have a bunch of plugins to integrate between KCalendarCore and various 
backend-specific libraries (e.g. KGAPI, KDAV, Kolab, ...), we should create 
KCalendarAddons (or something like that), assuming there's actually any demand 
for this.

For Akonadi the way it works is that we create an instance of 
KCalendarCore::Calendar and directly populate it with entities loaded from 
Akonadi. We don't use the CalStorage interface for that as we don't need that 
kind of abstraction to integrate between KCalendarCore and Akonadi.

Regards,
Dan

> 
> 
> Thanks


-- 
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

signature.asc
Description: This is a digitally signed message part.

D23029: Fix the attica pkgconfig file.

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D23029#510716 , @cgiboudeaux 
wrote:
  
  > Unless someone has objections, I'll push this tomorrow.
  
  
  You seem to have not set any reviewers on this... It seems fine to me, but 
pkgconfig isn't really my forte :)

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D23029

To: cgiboudeaux
Cc: leinir, fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23029: Fix the attica pkgconfig file.

[Christophe Giboudeaux]

cgiboudeaux marked an inline comment as done.
cgiboudeaux added a comment.


  Unless someone has objections, I'll push this tomorrow.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D23029

To: cgiboudeaux
Cc: fvogt, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

[David Faure]

dfaure created this revision.
dfaure added reviewers: broulik, davidedmundson, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  All QWidget-based API is now deprecated in this module.

TEST PLAN
  Builds.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23108

AFFECTED FILES
  src/kstartupinfo.h
  src/kwindowsystem.cpp
  src/kwindowsystem.h

To: dfaure, broulik, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22528: KIO FTP: Fix file copy hanging when copying to existing file

[Yaroslav Sidlovsky]

ZaWertun added a comment.


  Just found another bug on the KDE bugzilla related to this: 
https://bugs.kde.org/show_bug.cgi?id=410357.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22528

To: ZaWertun, sitter, dfaure, cfeck
Cc: rikmills, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Piyush Aggarwal]

brute4s99 added a comment.


  In D22727#505540 , @dfaure wrote:
  
  > The Qt documentation says "Warning: Because of differences in the platforms 
supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are 
platform-dependent: On Unix, the rights of the owner of the file are returned 
and on Windows the rights of the current user are returned. "
  
  
  okay, I believe you mean I should leave these changes as-are in the diff. Am 
I right?
  
  > But, wait, this code is mixing "int permissions" (*) with the QFileDevice 
enum, that doesn't make any sense to me.
  > 
  > (*) this comes from KIO::put, which takes unix permissions on unix, not 
sure what it takes on Windows...
  > 
  > This doesn't match: unix permissions are octal (e.g. group read is 040 in 
octal), QFileDevice enum is hex (0x040).
  
  Okay. I'm still unable to understand where/ how sftp::put() is called, or I 
would change everywhere it is called, to Qt way of permission extraction.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: pino, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  In D7446#505870 , @ngraham wrote:ut 
I am all ears for inputs.
  
  > Right now by default we only show two: "today" and "last month". We should 
probably keep it at that, at most; my sense is that even these are very 
infrequently used. Sometimes I wonder if they should even be on the placed 
panel by default at all. Especially once your new recentlyused:/ ioslave is 
merged, it's so good that it will obviate the need for the "today" one, at the 
minimum.
  
  
  My proposal was about which default entries to have for the recentlyused:/ 
kio slave.
  With D22717  we have now date filtering 
and with D22775  we will be able to have 
date range filtering in recentlyused:/ and hence we can ask ourselves which are 
the default entries to expose.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, fbampaloukas, alexde, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

Re: Unified git commit message guideline

[David Faure]

Hello Roman,

On dimanche 11 août 2019 23:52:55 CEST Roman Gilg wrote:
> [1] https://www.conventionalcommits.org

I like the idea very much, the changelog does look a bit messy indeed.
It would allow me to filter out all style, ci, and test changes, which are not 
interesting to the user of the frameworks.

I'm missing a type for internal cleanups like porting away from deprecated 
methods or fixing a harmless compiler warning? OTOH "chore" isn't documented 
in the Angular convention so I don't know what it is. In any case, it sounds 
like we need to write down our own list of types, right?

I would also like to keep the "Test Plan" field from phab even after we move 
to gitlab, it pushes people to write down how they actually tested the change.

I think we should wait until after the switch to gitlab though, because it 
might have some influence on this. For instance with phab I tend to prefix the 
subject with the repo name so that on k-f-d we can see which framework it's 
about. But that looks a bit redundant in the git history of a given repo 
afterwards so if the emails from gitlab include the repo name automatically, 
we shouldn't do that in the git commit log itself.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5