KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 15 Aug 2019 02:49:40 +
 Build duration:
3 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 92 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/92/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 15 Aug 2019 02:50:40 +
 Build duration:
2 min 42 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.62.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)21%
(461/2245)18%
(176/999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)58%
(58/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
  

D23159: Prevent error() being emitted when purposefully reading 0 bytes

[Alexander Saoutkin]

feverfew added inline comments.

INLINE COMMENTS

> apol wrote in file.cpp:520
> this should be
> 
>   {
>   Q_EMIT data({});`
>   return;
>   }
> 
> I'm not sure that we'd need an empty data emitted then. Are you trying to fix 
> a specific bug that triggers this?

I('ve not seen any IOSlave use a Q_EMIT macro, any reason why it's necessary 
here (what's the change in the behaviour).

Please re-read the summary, carefully, the error is subtle.

> apol wrote in file.cpp:526
> alternatively this could also check ` && bytes != 0`

Please reread the summary, this would not fix the bug.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23163: Remove double check for DBus

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:ffd4373116a8: Remove double check for DBus (authored by 
nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23163?vs=63772=63775

REVISION DETAIL
  https://phabricator.kde.org/D23163

AFFECTED FILES
  src/CMakeLists.txt

To: nicolasfella, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23163: Remove double check for DBus

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  it was just in case.. ;)

REPOSITORY
  R289 KNotifications

BRANCH
  doublecheck

REVISION DETAIL
  https://phabricator.kde.org/D23163

To: nicolasfella, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23163: Remove double check for DBus

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Once is enough

TEST PLAN
  builds

REPOSITORY
  R289 KNotifications

BRANCH
  doublecheck

REVISION DETAIL
  https://phabricator.kde.org/D23163

AFFECTED FILES
  src/CMakeLists.txt

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23159: Prevent error() being emitted when purposefully reading 0 bytes

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> file.cpp:520
> +// Nothing to do...
> +return data(QByteArray());
> +}

this should be

  {
  Q_EMIT data({});`
  return;
  }

I'm not sure that we'd need an empty data emitted then. Are you trying to fix a 
specific bug that triggers this?

> file.cpp:526
>  
>  if (!res.isEmpty()) {
>  data(res);

alternatively this could also check ` && bytes != 0`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23159

To: feverfew, dfaure, fvogt, chinmoyr
Cc: apol, kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23134: fix additionalDeliminator attribute

[jonathan poelen]

jpoelen updated this revision to Diff 63771.
jpoelen added a comment.


  - add unit test

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23134?vs=63683=63771

BRANCH
  fix_wordDelimiters (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23134

AFFECTED FILES
  autotests/folding/fix_d399348.addDelim.fold
  autotests/html/fix_d399348.addDelim.html
  autotests/input/fix_d399348.addDelim
  autotests/input/syntax/fix_d399348_additional_deliminators.xml
  autotests/reference/fix_d399348.addDelim.ref
  src/lib/rule.cpp

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

[Aleix Pol Gonzalez]

apol added a comment.


  There's several unrealated changes I'd discourage but the patch looks good 
overall. +1

INLINE COMMENTS

> icoutils_wrestool.cpp:78
>  
> -if ( name.at(0) == '\'' )
> -name = name.mid(1, name.size()-2);
> +if (name.at(0) == QLatin1Char('\'')) {
> +name = name.mid(1, name.length() - 2);

startsWith()

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23145

To: broulik, vonreth, pali, antlarr, bruns
Cc: apol, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D23131: Define install location for JAR/AAR files for Android

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23131

To: vkrause, #build_system, #android, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, 
michaelh, ngraham, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM +1

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: apol, kde-frameworks-devel, asemke, LeGast00n, michaelh, ngraham, bruns

D23161: Make media control icons outline style instead of solid style

[Björn Feber]

GB_2 added a comment.


  F7247689: photo5775267645204048231.jpg 
  This would fix the unbalanced icon style in file operation notifications.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23161

To: guoyunhe, #vdg, ndavis, ngraham
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/22/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 14 Aug 2019 20:18:46 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D23161: Make media control icons outline style instead of solid style

[Yunhe Guo]

guoyunhe added a comment.


  Yes, I did a search on the internet and almost all popular music app use 
solid play/pause/stop icon.
  
  The outline icon will look like this in JuK:
  
  F7247683: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23161

To: guoyunhe, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23161: Make media control icons outline style instead of solid style

[Yunhe Guo]

guoyunhe updated this revision to Diff 63763.
guoyunhe added a comment.


  22px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23161?vs=63762=63763

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23161

AFFECTED FILES
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/22/media-playback-pause.svg
  icons-dark/actions/22/media-playback-start.svg
  icons-dark/actions/22/media-playback-stop.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/22/media-playback-pause.svg
  icons/actions/22/media-playback-start.svg
  icons/actions/22/media-playback-stop.svg

To: guoyunhe, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 91 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/91/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 14 Aug 2019 20:18:46 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.62.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(457/2245)17%
(172/999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(147/156)54%
(54/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
  

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/25/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 14 Aug 2019 20:18:46 +
 Build duration:
3 min 9 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.62.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)21%
(461/2245)18%
(178/999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)60%
(60/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
   

D23161: Make media control icons outline style instead of solid style

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  We don't strictly adhere to outline or filled style (for better or worse), 
sometimes making use of both styles in the same icon (e.g., `view-list-icons`). 
I think the general idea is that we normally use the line/outline style unless 
that puts the designer at a disadvantage. Icons  can look messy with the 
outline style sometimes.
  
  The standard media control symbols are rarely seen with an outline style in 
real graphical user interfaces. As far as I know, that style is never seen on 
physical media control buttons. I think changing the style would be more likely 
to make the icons look odd.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23161

To: guoyunhe, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23161: Make media control icons outline style instead of solid style

[Yunhe Guo]

guoyunhe updated this revision to Diff 63762.
guoyunhe added a comment.


  Correct SVG format

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23161?vs=63760=63762

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23161

AFFECTED FILES
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/22/media-playback-start.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/22/media-playback-start.svg

To: guoyunhe, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23161: Make media control icons outline style instead of solid style

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Hmm, not sure how I feel about this. I kind of like the filled-in versions.
  
  Regardless, please re-add `id="current-color-scheme"` to the CSS, or else the 
icons will no longer change their colors to reflect the color scheme.
  
  Also, if we want to do this, we'll need a companion patch for 
plasma-frameworks to adjust the equivalent icons in the Breeze Plasma theme too.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23161

To: guoyunhe, #vdg, ndavis, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23161: Make media control icons outline style instead of solid style

[Nathaniel Graham]

ngraham added reviewers: VDG, ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23161

To: guoyunhe, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23161: Make media control icons outline style instead of solid style

[Yunhe Guo]

guoyunhe edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23161

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23161: Make media control icons outline style instead of solid style

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  In progress. If others think this is the correct way to do it, I can continue 
with other media control icons and all sizes.
  
  From my understanding of KDE HIG, the icon should be outline style whenever 
possible.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23161

AFFECTED FILES
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 24 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/24/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 14 Aug 2019 19:07:39 +
 Build duration:
6 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 471 lines...][2019-08-14T19:14:32.054Z] [ 34%] Built target ktpsendfileplugin_autogen[2019-08-14T19:14:32.054Z] [ 34%] Building CXX object src/plugins/youtube/CMakeFiles/youtubeplugin.dir/youtubejob.cpp.o[2019-08-14T19:14:32.615Z] [ 35%] Building CXX object src/plugins/youtube/CMakeFiles/youtubeplugin.dir/youtubejobcomposite.cpp.o[2019-08-14T19:14:32.615Z] Scanning dependencies of target kdeconnectplugin_autogen[2019-08-14T19:14:32.615Z] [ 36%] Automatic MOC for target kdeconnectplugin[2019-08-14T19:14:32.870Z] Scanning dependencies of target reviewboardplugin_autogen[2019-08-14T19:14:32.870Z] [ 37%] Automatic MOC for target reviewboardplugin[2019-08-14T19:14:32.870Z] Scanning dependencies of target phabricatorplugin_autogen[2019-08-14T19:14:32.870Z] [ 38%] Automatic MOC for target phabricatorplugin[2019-08-14T19:14:32.870Z] [ 39%] Building CXX object src/plugins/nextcloud/CMakeFiles/nextcloudplugin.dir/nextcloudplugin.cpp.o[2019-08-14T19:14:32.870Z] [ 39%] Built target kdeconnectplugin_autogen[2019-08-14T19:14:32.870Z] [ 40%] Building CXX object src/plugins/nextcloud/CMakeFiles/nextcloudplugin.dir/nextcloudjob.cpp.o[2019-08-14T19:14:32.870Z] [ 41%] Linking CXX shared library ../../../bin/librbpurposequickplugin.so[2019-08-14T19:14:33.126Z] [ 41%] Built target reviewboardplugin_autogen[2019-08-14T19:14:33.126Z] Scanning dependencies of target emailplugin_autogen[2019-08-14T19:14:33.126Z] [ 41%] Automatic MOC for target emailplugin[2019-08-14T19:14:33.126Z] [ 41%] Built target phabricatorplugin_autogen[2019-08-14T19:14:33.126Z] Scanning dependencies of target telegramplugin_autogen[2019-08-14T19:14:33.126Z] [ 41%] Automatic MOC for target telegramplugin[2019-08-14T19:14:33.126Z] Scanning dependencies of target bluetoothplugin_autogen[2019-08-14T19:14:33.126Z] [ 41%] Automatic MOC for target bluetoothplugin[2019-08-14T19:14:33.126Z] [ 41%] Built target emailplugin_autogen[2019-08-14T19:14:33.126Z] Scanning dependencies of target kdeconnectsmsplugin_autogen[2019-08-14T19:14:33.126Z] [ 42%] Automatic MOC for target kdeconnectsmsplugin[2019-08-14T19:14:33.382Z] /home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.13/src/plugins/youtube/youtubejob.cpp: In member function ���void YoutubeJob::videoUploaded()���:[2019-08-14T19:14:33.382Z] /home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.13/src/plugins/youtube/youtubejob.cpp:125:65: error: invalid use of incomplete type ���class QJsonObject���[2019-08-14T19:14:33.382Z]   125 | auto doc = QJsonDocument::fromJson(reply->readAll()).object();[2019-08-14T19:14:33.382Z]   | ^[2019-08-14T19:14:33.382Z] In file included from /usr/include/qt5/QtCore/qobject.h:54,[2019-08-14T19:14:33.382Z]  from /usr/include/qt5/QtCore/QObject:1,[2019-08-14T19:14:33.382Z]  from /home/jenkins/install-prefix/include/KF5/KCoreAddons/kjob.h:26,[2019-08-14T19:14:33.382Z]  from /home/jenkins/install-prefix/include/KF5/KCoreAddons/KJob:1,[2019-08-14T19:14:33.382Z]  from /home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.13/src/plugins/youtube/youtubejob.h:21,[2019-08-14T19:14:33.382Z]  from /home/jenkins/workspace/Frameworks/purpose/kf5-qt5 SUSEQt5.13/src/plugins/youtube/youtubejob.cpp:18:[2019-08-14T19:14:33.382Z] /usr/include/qt5/QtCore/qmetatype.h:1971:1: note: forward declaration of ���class QJsonObject���[2019-08-14T19:14:33.382Z]  1971 | QT_FOR_EACH_STATIC_CORE_CLASS(QT_FORWARD_DECLARE_STATIC_TYPES_ITER)[2019-08-14T19:14:33.382Z]   | ^[2019-08-14T19:14:33.382Z] [ 42%] Built target telegramplugin_autogen[2019-08-14T19:14:33.382Z] Scanning dependencies of target purposequickplugin_autogen[2019-08-14T19:14:33.382Z] [ 42%] Built target rbpurposequickplugin[2019-08-14T19:14:33.382Z] [ 43%] Automatic MOC for target purposequickplugin[2019-08-14T19:14:33.382Z] [ 43%] Built target bluetoothplugin_autogen[2019-08-14T19:14:33.382Z] Scanning dependencies of target KF5PurposeWidgets_autogen[2019-08-14T19:14:33.382Z] Scanning dependencies of target alternativesmodeltest_autogen[2019-08-14T19:14:33.382Z] [ 44%] Automatic MOC for target KF5PurposeWidgets[2019-08-14T19:14:33.382Z] [ 45%] Automatic MOC for target alternativesmodeltest[2019-08-14T19:14:33.382Z] Scanning dependencies of target sharetool_autogen[2019-08-14T19:14:33.382Z] [ 45%] Automatic MOC for target sharetool[2019-08-14T19:14:33.382Z] make[2]: *** [src/plugins/youtube/CMakeFiles/youtubeplugin.dir/build.make:89: src/plugins/youtube/CMakeFiles/youtubeplugin.dir/youtubejob.cpp.o] Error 1[2019-08-14T19:14:33.382Z] make[2]: *** Waiting for unfinished 

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/2/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Wed, 14 Aug 2019 19:07:09 +
 Build duration:
5 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/21/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 14 Aug 2019 19:07:39 +
 Build duration:
3 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 412 lines...][2019-08-14T19:11:18.104Z] Scanning dependencies of target emailplugin_autogen[2019-08-14T19:11:18.104Z] [ 36%] Automatic MOC for target emailplugin[2019-08-14T19:11:18.104Z] [ 36%] Built target ktpsendfileplugin_autogen[2019-08-14T19:11:18.104Z] Scanning dependencies of target telegramplugin_autogen[2019-08-14T19:11:18.104Z] [ 36%] Automatic MOC for target telegramplugin[2019-08-14T19:11:18.360Z] [ 37%] Building CXX object src/plugins/nextcloud/CMakeFiles/nextcloudplugin.dir/nextcloudplugin.cpp.o[2019-08-14T19:11:18.360Z] [ 38%] Linking CXX shared library ../../../bin/librbpurposequickplugin.so[2019-08-14T19:11:18.360Z] [ 38%] Built target rbpurposequickplugin[2019-08-14T19:11:18.360Z] Scanning dependencies of target bluetoothplugin_autogen[2019-08-14T19:11:18.360Z] [ 38%] Automatic MOC for target bluetoothplugin[2019-08-14T19:11:18.360Z] [ 38%] Built target kdeconnectplugin_autogen[2019-08-14T19:11:18.360Z] [ 39%] Building CXX object src/plugins/youtube/CMakeFiles/youtubeplugin.dir/youtubeplugin.cpp.o[2019-08-14T19:11:18.360Z] [ 39%] Built target phabricatorplugin_autogen[2019-08-14T19:11:18.360Z] Scanning dependencies of target kdeconnectsmsplugin_autogen[2019-08-14T19:11:18.360Z] [ 40%] Automatic MOC for target kdeconnectsmsplugin[2019-08-14T19:11:18.617Z] [ 40%] Built target reviewboardplugin_autogen[2019-08-14T19:11:18.617Z] Scanning dependencies of target purposequickplugin_autogen[2019-08-14T19:11:18.617Z] [ 41%] Automatic MOC for target purposequickplugin[2019-08-14T19:11:18.617Z] [ 41%] Built target emailplugin_autogen[2019-08-14T19:11:18.617Z] Scanning dependencies of target KF5PurposeWidgets_autogen[2019-08-14T19:11:18.618Z] [ 42%] Automatic MOC for target KF5PurposeWidgets[2019-08-14T19:11:18.618Z] [ 42%] Built target telegramplugin_autogen[2019-08-14T19:11:18.618Z] [ 43%] Building CXX object src/plugins/nextcloud/CMakeFiles/nextcloudplugin.dir/nextcloudjob.cpp.o[2019-08-14T19:11:18.618Z] [ 43%] Building CXX object src/plugins/youtube/CMakeFiles/youtubeplugin.dir/youtubejob.cpp.o[2019-08-14T19:11:18.874Z] [ 43%] Built target bluetoothplugin_autogen[2019-08-14T19:11:18.874Z] Scanning dependencies of target alternativesmodeltest_autogen[2019-08-14T19:11:18.874Z] [ 44%] Automatic MOC for target alternativesmodeltest[2019-08-14T19:11:18.874Z] [ 45%] Building CXX object src/plugins/youtube/CMakeFiles/youtubeplugin.dir/youtubejobcomposite.cpp.o[2019-08-14T19:11:18.874Z] [ 45%] Built target kdeconnectsmsplugin_autogen[2019-08-14T19:11:18.874Z] Scanning dependencies of target sharetool_autogen[2019-08-14T19:11:18.874Z] [ 45%] Built target purposequickplugin_autogen[2019-08-14T19:11:18.875Z] [ 45%] Automatic MOC for target sharetool[2019-08-14T19:11:19.134Z] [ 45%] Built target sharetool_autogen[2019-08-14T19:11:19.134Z] Scanning dependencies of target purposeprocess[2019-08-14T19:11:19.134Z] [ 46%] Building CXX object src/CMakeFiles/purposeprocess.dir/purposeprocess_autogen/mocs_compilation.cpp.o[2019-08-14T19:11:19.134Z] Scanning dependencies of target saveasplugin[2019-08-14T19:11:19.134Z] [ 47%] Building CXX object src/CMakeFiles/purposeprocess.dir/externalprocess/purposeprocess_main.cpp.o[2019-08-14T19:11:19.134Z] [ 47%] Building CXX object src/plugins/saveas/CMakeFiles/saveasplugin.dir/saveasplugin_autogen/mocs_compilation.cpp.o[2019-08-14T19:11:19.134Z] [ 48%] Building CXX object src/plugins/saveas/CMakeFiles/saveasplugin.dir/saveasplugin.cpp.o[2019-08-14T19:11:19.134Z] [ 48%] Built target KF5PurposeWidgets_autogen[2019-08-14T19:11:19.134Z] Scanning dependencies of target imgurplugin[2019-08-14T19:11:19.134Z] [ 48%] Building CXX object src/plugins/imgur/CMakeFiles/imgurplugin.dir/imgurplugin_autogen/mocs_compilation.cpp.o[2019-08-14T19:11:19.134Z] Scanning dependencies of target pastebinplugin[2019-08-14T19:11:19.134Z] [ 49%] Building CXX object src/plugins/imgur/CMakeFiles/imgurplugin.dir/imgurplugin.cpp.o[2019-08-14T19:11:19.134Z] [ 50%] Building CXX object src/plugins/pastebin/CMakeFiles/pastebinplugin.dir/pastebinplugin_autogen/mocs_compilation.cpp.o[2019-08-14T19:11:19.134Z] [ 51%] Building CXX object src/plugins/pastebin/CMakeFiles/pastebinplugin.dir/pastebinplugin.cpp.o[2019-08-14T19:11:19.392Z] [ 51%] Built target alternativesmodeltest_autogen[2019-08-14T19:11:19.392Z] Scanning dependencies of target ktpsendfileplugin[2019-08-14T19:11:19.392Z] [ 52%] Building CXX object src/plugins/ktp-sendfile/CMakeFiles/ktpsendfileplugin.dir/ktpsendfileplugin_autogen/mocs_compilation.cpp.o[2019-08-14T19:11:19.392Z] [ 53%] Building CXX object src/plugins/ktp-sendfile/CMakeFiles/ktpsendfileplugin.dir/ktpsendfileplugin.cpp.o[2019-08-14T19:11:19.392Z] [ 54%] Building CXX object 

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 90 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/90/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 14 Aug 2019 19:07:39 +
 Build duration:
5 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 392 lines...][2019-08-14T19:12:31.025Z] Scanning dependencies of target ReviewboardHelpers_autogen[2019-08-14T19:12:31.025Z] [  2%] Automatic MOC for target ReviewboardHelpers[2019-08-14T19:12:31.025Z] [  2%] Built target ReviewboardHelpers_autogen[2019-08-14T19:12:31.025Z] Scanning dependencies of target PhabricatorHelpers_autogen[2019-08-14T19:12:31.025Z] [  3%] Automatic MOC for target PhabricatorHelpers[2019-08-14T19:12:31.525Z] [  3%] Built target PhabricatorHelpers_autogen[2019-08-14T19:12:31.525Z] Scanning dependencies of target moveqmldir[2019-08-14T19:12:31.525Z] [  3%] Built target moveqmldir[2019-08-14T19:12:31.525Z] [  3%] Generating qrc_standard-plugin-types.cpp[2019-08-14T19:12:32.574Z] Scanning dependencies of target KF5Purpose[2019-08-14T19:12:32.574Z] [  4%] Building CXX object src/CMakeFiles/KF5Purpose.dir/KF5Purpose_autogen/mocs_compilation.cpp.o[2019-08-14T19:12:34.229Z] [  5%] Building CXX object src/CMakeFiles/KF5Purpose.dir/purpose_external_process_debug.cpp.o[2019-08-14T19:12:35.683Z] [  5%] Building CXX object src/CMakeFiles/KF5Purpose.dir/pluginbase.cpp.o[2019-08-14T19:12:37.350Z] [  6%] Building CXX object src/CMakeFiles/KF5Purpose.dir/job.cpp.o[2019-08-14T19:12:39.008Z] [  7%] Building CXX object src/CMakeFiles/KF5Purpose.dir/alternativesmodel.cpp.o[2019-08-14T19:12:42.991Z] [  8%] Building CXX object src/CMakeFiles/KF5Purpose.dir/configuration.cpp.o[2019-08-14T19:12:46.122Z] [  8%] Building CXX object src/CMakeFiles/KF5Purpose.dir/helper.cpp.o[2019-08-14T19:12:48.483Z] [  9%] Building CXX object src/CMakeFiles/KF5Purpose.dir/externalprocess/processjob.cpp.o[2019-08-14T19:12:51.597Z] [ 10%] Building CXX object src/CMakeFiles/KF5Purpose.dir/qrc_standard-plugin-types.cpp.o[2019-08-14T19:12:51.597Z] [ 10%] Linking CXX shared library ../bin/libKF5Purpose.so[2019-08-14T19:12:52.645Z] [ 10%] Built target KF5Purpose[2019-08-14T19:12:53.149Z] Scanning dependencies of target ReviewboardHelpers[2019-08-14T19:12:53.149Z] [ 11%] Building CXX object src/plugins/reviewboard/CMakeFiles/ReviewboardHelpers.dir/ReviewboardHelpers_autogen/mocs_compilation.cpp.o[2019-08-14T19:12:55.556Z] [ 11%] Building CXX object src/plugins/reviewboard/CMakeFiles/ReviewboardHelpers.dir/reviewboardjobs.cpp.o[2019-08-14T19:12:59.588Z] [ 12%] Building CXX object src/plugins/reviewboard/CMakeFiles/ReviewboardHelpers.dir/debug.cpp.o[2019-08-14T19:13:01.948Z] [ 13%] Linking CXX shared library ../../../bin/libReviewboardHelpers.so[2019-08-14T19:13:02.448Z] [ 13%] Built target ReviewboardHelpers[2019-08-14T19:13:02.448Z] Scanning dependencies of target PhabricatorHelpers[2019-08-14T19:13:02.448Z] [ 14%] Building CXX object src/plugins/phabricator/CMakeFiles/PhabricatorHelpers.dir/PhabricatorHelpers_autogen/mocs_compilation.cpp.o[2019-08-14T19:13:04.825Z] [ 15%] Building CXX object src/plugins/phabricator/CMakeFiles/PhabricatorHelpers.dir/phabricatorjobs.cpp.o[2019-08-14T19:13:08.128Z] [ 16%] Building CXX object src/plugins/phabricator/CMakeFiles/PhabricatorHelpers.dir/debug.cpp.o[2019-08-14T19:13:10.509Z] [ 16%] Linking CXX shared library ../../../bin/libPhabricatorHelpers.so[2019-08-14T19:13:10.509Z] [ 16%] Built target PhabricatorHelpers[2019-08-14T19:13:10.509Z] Scanning dependencies of target emailplugin_autogen[2019-08-14T19:13:10.509Z] [ 16%] Automatic MOC for target emailplugin[2019-08-14T19:13:11.013Z] [ 16%] Built target emailplugin_autogen[2019-08-14T19:13:11.013Z] Scanning dependencies of target telegramplugin_autogen[2019-08-14T19:13:11.013Z] [ 16%] Automatic MOC for target telegramplugin[2019-08-14T19:13:11.521Z] [ 16%] Built target telegramplugin_autogen[2019-08-14T19:13:11.521Z] Scanning dependencies of target bluetoothplugin_autogen[2019-08-14T19:13:11.521Z] [ 16%] Automatic MOC for target bluetoothplugin[2019-08-14T19:13:12.024Z] [ 16%] Built target bluetoothplugin_autogen[2019-08-14T19:13:12.024Z] Scanning dependencies of target kdeconnectsmsplugin_autogen[2019-08-14T19:13:12.024Z] [ 17%] Automatic MOC for target kdeconnectsmsplugin[2019-08-14T19:13:12.521Z] [ 17%] Built target kdeconnectsmsplugin_autogen[2019-08-14T19:13:12.521Z] Scanning dependencies of target purposequickplugin_autogen[2019-08-14T19:13:12.521Z] [ 18%] Automatic MOC for target purposequickplugin[2019-08-14T19:13:13.031Z] [ 18%] Built target purposequickplugin_autogen[2019-08-14T19:13:13.031Z] Scanning dependencies of target KF5PurposeWidgets_autogen[2019-08-14T19:13:13.031Z] [ 19%] Automatic MOC for target KF5PurposeWidgets[2019-08-14T19:13:13.541Z] [ 19%] Built target KF5PurposeWidgets_autogen[2019-08-14T19:13:13.541Z] Scanning dependencies of target alternativesmodeltest_autogen[2019-08-14T19:13:13.541Z] [ 20%] Automatic MOC for target 

D23116: Fix missing digit and pixel-perfect alignment of depth action icons

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c8ebfc2530dd: Fix missing digit and pixel-perfect 
alignment of depth action icons (authored by Rafael Brandmaier 
rafael.brandma...@kdemail.net).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23116?vs=63652=63757

REVISION DETAIL
  https://phabricator.kde.org/D23116

AFFECTED FILES
  icons-dark/actions/22/depth16to8.svg
  icons-dark/actions/22/depth8to16.svg
  icons/actions/22/depth16to8.svg
  icons/actions/22/depth8to16.svg

To: trickyricky26, #vdg, ngraham, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23159: Prevent error() being emitted when purposefully reading 0 bytes

[Alexander Saoutkin]

feverfew created this revision.
feverfew added reviewers: dfaure, fvogt, chinmoyr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  Currently when 0 is passed as a parameter, if the file to be read is 
non-empty both data and error signals 
  are emitted. This behaviour is incorrect, as there is no error. This patch 
makes sure that only data is 
  emitted.

TEST PLAN
  The application I'm developing that hit this bug now no longer hits this 
issue.

REPOSITORY
  R241 KIO

BRANCH
  Read0Bug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23159

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: feverfew, dfaure, fvogt, chinmoyr
Cc: kfm-devel, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23157: Add technology property to battery interface

[Méven Car]

meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23157

AFFECTED FILES
  src/solid/devices/frontend/battery.h

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:403c617eea56: Add a logging category for logs warnings 
(authored by meven).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=63729=63735

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  CMakeLists.txt
  kconfig.categories
  src/core/CMakeLists.txt
  src/core/kconfig.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp
  src/core/kconfigwatcher.cpp
  src/core/kdesktopfile.cpp

To: meven, #frameworks, apol, cgiboudeaux
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R237 KConfig

BRANCH
  arcpatch-D22061

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol, cgiboudeaux
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22805: set autorcc and autouic by default

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Patch as is fine with me.
  But no expert on both flags itself, no idea if there could be sideeffects of 
having those two now injected as ON to all projects. Possibly best to do global 
rebuilds of all projects on CI once this lands.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22805

To: sitter
Cc: cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

[Nicolas Fella]

nicolasfella updated this revision to Diff 63732.
nicolasfella added a comment.


  - Fix case

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23149?vs=63712=63732

BRANCH
  dbustest

REVISION DETAIL
  https://phabricator.kde.org/D23149

AFFECTED FILES
  CMakeLists.txt

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D23149: Only build tests when DBus is available

[Nicolas Fella]

nicolasfella marked an inline comment as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D23149: Only build tests when DBus is available

[Nicolas Fella]

nicolasfella added a comment.


  Yes, QtDBus is available on Windows, so no change there

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D23149: Only build tests when DBus is available

[Alexander Potashev]

aspotashev added a comment.


  At least for now Window CI tries and tests something:
  
  
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.13/1/console

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D23149: Only build tests when DBus is available

[Alexander Potashev]

aspotashev added a comment.


  Does this mean we cannot test Solid on Windows CI? 
https://api.kde.org/frameworks/solid/html/ says Solid is supported also on 
Windows.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven added a comment.


  In D22061#511799 , @cgiboudeaux 
wrote:
  
  > ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it 
should be fine.
  
  
  Should be good now.
  Thank you for your feedback.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22061: Add a logging category for logs warnings

[Méven Car]

meven updated this revision to Diff 63729.
meven added a comment.


  Renamed kconf to kconfig, KCONF to KCONFIG, re-add the mistakenly removed 
categories file

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22061?vs=62903=63729

BRANCH
  arcpatch-D22061

REVISION DETAIL
  https://phabricator.kde.org/D22061

AFFECTED FILES
  CMakeLists.txt
  kconfig.categories
  src/core/CMakeLists.txt
  src/core/kconfig.cpp
  src/core/kconfiggroup.cpp
  src/core/kconfigini.cpp
  src/core/kconfigwatcher.cpp
  src/core/kdesktopfile.cpp

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D23103: Add decibel power units (dBW and multiples)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Since there are only two common units in the list right now, adding a third 
doesn't seem like a disaster. :)
  
  @broulik, what do you think?

REPOSITORY
  R292 KUnitConversion

BRANCH
  log_power_units

REVISION DETAIL
  https://phabricator.kde.org/D23103

To: iasensio, broulik, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven marked an inline comment as done.
meven added a comment.


  In D23112#511779 , @ngraham wrote:
  
  > Cool stuff. Does it handle duplicates when a file is present in both 
GTKFileChooserRecent and KActivitiesStats?
  
  
  Yes, the file url is a sort of a key, so this is fine.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven marked 2 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> ngraham wrote in kactivitymanagerd-plugin-gtk-eventspy.json:41
> Not sure you need to add translations of your own name here

This was done for Ivan so I guess the translation team fills this.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63724.
meven added a comment.


  grammar

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63713=63724

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22805: set autorcc and autouic by default

[Volker Krause]

vkrause added a comment.


  I'm happy with this, +2 from my side.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22805

To: sitter
Cc: cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

D22805: set autorcc and autouic by default

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  @kossebau @vkrause @apol something else to change?

INLINE COMMENTS

> KDECMakeSettings.cmake:82
> +# - CMAKE_AUTORCC and CMAKE_AUTOUIC enabled by default when supported by 
> cmake
> +#   (>= 3.0) since 5.61.0
>  #

5.62 now

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22805

To: sitter
Cc: cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel, 
kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

D22061: Add a logging category for logs warnings

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should 
be fine.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D23149: Only build tests when DBus is available

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> CMakeLists.txt:127
>  add_subdirectory(src)
> -if (BUILD_TESTING)
> +if (TARGET QT5::DBus AND BUILD_TESTING)
>  add_subdirectory(autotests)

Qt5::DBus, not sure if this is case-sensitive, if it is this would disable the 
tests for everyone I think. Apart from that, +2.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23103: Add decibel power units (dBW and multiples)

[Ismael Asensio]

iasensio marked an inline comment as done.
iasensio added a comment.


  Well, in my field of work (telephony, radar and radio signal transmission) it 
makes totally sense (altought Terawatts would be major words ). It is a non 
trivial conversion that we make quite frequently.
  
  If the question is between dBm and dBW as a common unit, I would go for dBm 
with no doubt. In my experience dBm is widely more used that its counterpart 
dBW. Also, as a quick and dirty comparison, one can check the difference in 
length and quality of those two articles: https://en.wikipedia.org/wiki/DBm and 
https://en.wikipedia.org/wiki/Decibel_watt.
  
  If it is wether decibel power units are common globally, I would say (knowing 
that I have a field bias) that at least as important as horsepower on a 
different field. 
  Of course, I will gently (and happily) accept your decision. Just wanted to 
provide some context.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D23103

To: iasensio, broulik
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22699: Support passing target to ecm_qt_declare_logging_category

[Christophe Giboudeaux]

cgiboudeaux set the repository for this revision to R240 Extra CMake Modules.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22699

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
bencreasy, michaelh, ngraham, bruns

D22709: Support passing target to ecm_add_app_icon.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  -1.
  
  This shall be compliant with the minimum ECM version set in the project.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22709

To: daandemeyer, alexmerry, dschmidt
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, 
michaelh, ngraham, bruns

D23112: Add a event Spy for GtkFileChooser recent files

[Nathaniel Graham]

ngraham added a comment.


  Cool stuff. Does it handle duplicates when a file is present in both 
GTKFileChooserRecent and KActivitiesStats?

INLINE COMMENTS

> kactivitymanagerd-plugin-gtk-eventspy.json:41
> +"Name[zh_CN]": "Méven Car",
> +"Name[zh_TW]": "Méven Car"
> +}

Not sure you need to add translations of your own name here

> kactivitymanagerd-plugin-gtk-eventspy.json:46
> +"Dependencies": [],
> +"Description": "Collects events from applications that uses 
> GtkFileChooser and GtkRecentManager as specified by 
> https://www.freedesktop.org/wiki/Specifications/desktop-bookmark-spec/;,
> +"EnabledByDefault": true,

that uses -> that use

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23103: Add decibel power units (dBW and multiples)

[Nathaniel Graham]

ngraham added a comment.


  Works just fine, but by adding dBm as a common unit, it's now the first t 
hing that shows up when I convert watts:
  
  F7247005: Screenshot_20190814_070401.png 

  
  Seems a little odd to me, not being an audio professional. Does it really 
make sense to display dBm when I convert 5 terawatts? :p
  
  F7247009: Screenshot_20190814_070623.png 


REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D23103

To: iasensio, broulik
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven marked 2 inline comments as done.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven marked 5 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> ivan wrote in GtkEventSpy.cpp:143
> Let's hope commands will never have spaces in them :)

It is to just extract the executable name, we don't want to have an exploding 
number of initiatingAgent for every argument and parameter that might come 
through here.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven updated this revision to Diff 63713.
meven added a comment.


  Add const where need be, simplify KTrader query

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63669=63713

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23149: Only build tests when DBus is available

[Nicolas Fella]

nicolasfella added reviewers: bcooksley, broulik, bruns, Frameworks.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23149

To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The tests require DBus

REPOSITORY
  R245 Solid

BRANCH
  dbustest

REVISION DETAIL
  https://phabricator.kde.org/D23149

AFFECTED FILES
  CMakeLists.txt

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 14 Aug 2019 10:03:47 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23112: Add a event Spy for GtkFileChooser recent files

[Méven Car]

meven added a comment.


  In D23112#511354 , @ivan wrote:
  
  > Thanks for geting involved this much!
  
  
  :D

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23147: KRun: fix runtime warning when widget is null

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23147

To: dfaure, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23147: KRun: fix runtime warning when widget is null

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23147

To: dfaure, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23134: fix additionalDeliminator attribute

[Dominik Haumann]

dhaumann added a comment.


  Could you add a unit test for this?
  
  - add the dummy xml similar to the one in the bug report. This can be done by 
using the additional search folder in the Repository.
  - add a test highlighting like done with the others
  
  The so only when the unit tests run, the Repository contains the additional 
search path.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23134

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Thanks. Removing hardcoded colors would also be nice :-)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  gettext (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23135

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23147: KRun: fix runtime warning when widget is null

[David Faure]

dfaure created this revision.
dfaure added reviewers: nicolasfella, vkrause.
Herald added a project: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  I wanted the connection to be broken if the widget was deleted early,
  but if there's no widget then Qt warns about a null receiver. Use qApp
  as receiver in that case, just to have something non-null.

TEST PLAN
  kde-open5 file.pdf

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23147

AFFECTED FILES
  src/widgets/krun.cpp

To: dfaure, nicolasfella, vkrause
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Kai Uwe Broulik]

broulik added a comment.


  Then please investigate what's going on there.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14632: keyword rule: Spport for keywords inclusion from another language/file

[Dominik Haumann]

dhaumann added a comment.


  What just came to my mind is that this patch also has an issue: If you 
include a keyword list of a.xml in b.xml, and a.xml uses different word 
delimiters for the keyword list, then the keywords in b.xml will not be 
highlighted/detected correctly.
  
  Did we think about this when approving this change? What solutions do we have 
for this? The least we can do is to add this i) to the API documentation, and 
ii) to the highlighting section in the docbook.
  
  That said, the correct fix would be to simply refer to the keyword list of 
the respective Definition, and if the rule is applied, we should check for the 
word delimiters of the referenced keyword list...
  
  Any other thoughts?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, vkrause, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Piyush Aggarwal]

brute4s99 added a comment.


  the duplicate notification always has id= -1, so I think it's more an issue  
of KNotifications, I think

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: vonreth, pali, antlarr, bruns.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  16 bit executables don't have `--language` in their output.
  While at it, port to `QRegularExpression` and just do a global match rather 
than splitting the output into individual lines.
  Since the name is captured very fuzzy (it can include spaces, too), I 
couldn't just do an optional match but had to do two specific matches for with 
and without `--language`.
  Also, somewhat fix the individual icon selection which looks broken but 
doesn't appear to be used anyway.
  
  Moreover, only extract icon groups (type 14). I checked `wrestool` source 
code[1] and it cannot actually decode single icons (type 3) nor cursors (type 
1). Calling it with `--raw` usually creates `.dib` files which don't appear to 
be proper bitmaps and fail to generate thumbnails.
  
  [1] https://github.com/Lampus/icoutils/blob/master/wrestool/extract.c#L93

TEST PLAN
  F7246563: Screenshot_20190814_094956.png 

  :D

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23145

AFFECTED FILES
  thumbnail/icoutils_wrestool.cpp

To: broulik, vonreth, pali, antlarr, bruns
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> klistopenfiles.cpp:26
> +
> +void listProcessesWithOpenFiles(QDir path, Callback callback)
> +{

Can you allow passing an optional context object, so when the caller gets 
deleted, you don't crash when the reply comes in?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23112: Add a event Spy for GtkFileChooser recent files

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> GtkEventSpy.cpp:135
> +// See 
> https://techbase.kde.org/Development/Tutorials/Services/Traders#The_KTrader_Query_Language
> +QString query = QString("exist Exec and ((Exec ~~ '%1') or (exist 
> GenericName and '%1' ~~ GenericName) or (exist Name and '%1' ~~ 
> Name))").arg(exec);
> +KService::List services = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"), query);

Isn't that a bit coarse? Doesn't matching the `Exec` line exactly work?

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

[Kai Uwe Broulik]

broulik added a comment.


  I think this is a bug in KDE Connect? I've seen numerous people complain 
about that in the new notification system that didn't filter them out 
originally.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D23133

To: brute4s99, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns