D23300: Add FictionBook 2 icons

2019-08-21 Thread Yuri Chornoivan
yurchor updated this revision to Diff 64186.
yurchor added a comment.


  Be consistent with existing book-style icons.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64152&id=64186

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D23300: Add FictionBook 2 icons

2019-08-21 Thread Yuri Chornoivan
yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D22946: Include API to generically implement --replace arguments

2019-08-21 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> kdbusservice.cpp:129
> +d->registered = bus->registerService(d->serviceName
> + , (options & Replace) ? 
> QDBusConnectionInterface::ReplaceExistingService : 
> QDBusConnectionInterface::DontQueueService
> + , (options & Replace) ? 
> QDBusConnectionInterface::AllowReplacement : 
> QDBusConnectionInterface::DontAllowReplacement

I don't like this part very much. It means we're registering the name whilst 
the former app is potentially still running.

I would suggest rebasing on Harald's 5bf091ee07ac44ed1bf1e75a4d07847edb86c5d6 
 
change.

It'll allow us to do this all in a race-free way.

We can register the name org.kde.plasmashell in a queued manner
then call quit on the current process, and then call waitForRegistration()

and it'll be better than the current approach plasma does.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks
Cc: davidedmundson, broulik, kossebau, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D22946: Include API to generically implement --replace arguments

2019-08-21 Thread David Edmundson
davidedmundson requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D22946

To: apol, #frameworks, davidedmundson
Cc: davidedmundson, broulik, kossebau, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

2019-08-21 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R308 KRunner

BRANCH
  betterhack

REVISION DETAIL
  https://phabricator.kde.org/D22758

To: fvogt, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23314: Fix runnertest exiting early

2019-08-21 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Some runner uses KIO, which creates a quitLock which kills the application
  early

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D23314

AFFECTED FILES
  tests/runnertest.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23314: Fix runnertest exiting early

2019-08-21 Thread Kai Uwe Broulik
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D23314

To: davidedmundson, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

2019-08-21 Thread David Edmundson
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Edit. On testing this doesn't seem to work.
  See runnertest (with D23314 )

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22758

To: fvogt, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

2019-08-21 Thread Fabian Vogt
This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:54e18b0d9b0d: Add a done signal to FindMatchesJob instead 
of using QObjectDecorator wrongly (authored by fvogt).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22758?vs=62583&id=64191

REVISION DETAIL
  https://phabricator.kde.org/D22758

AFFECTED FILES
  src/runnerjobs.cpp
  src/runnerjobs_p.h
  src/runnermanager.cpp

To: fvogt, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23315: Port runnertest to QGuiApplication

2019-08-21 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Runners deal with icons and therefor use pixmaps and such
  
  It matches any realworld runner cases better

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D23315

AFFECTED FILES
  tests/runnertest.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23315: Port runnertest to QGuiApplication

2019-08-21 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D23315

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D22859: Add Q_PROPERTIES interface to KDescendantsProxyModel

2019-08-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R275:ed7cdfcc3898: Add Q_PROPERTIES interface to 
KDescendantsProxyModel (authored by davidedmundson).

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22859?vs=62866&id=64196

REVISION DETAIL
  https://phabricator.kde.org/D22859

AFFECTED FILES
  src/kdescendantsproxymodel.cpp
  src/kdescendantsproxymodel.h

To: davidedmundson, apol
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Unstable!

2019-08-21 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/3/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Wed, 21 Aug 2019 13:02:30 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.autotests.kiconloader_unittest

D23300: Add FictionBook 2 icons

2019-08-21 Thread Nathaniel Graham
ngraham added a comment.


  Better, thanks! Any chance you could make the gray background color a bit 
different? Maybe lighter, or some other color? That particular gray isn't a 
very attractive color IMO. It's very brutalist. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D23047: Properly turn real into integer

2019-08-21 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:ee1d424f1cb9: Properly turn real into integer (authored 
by apol).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23047?vs=63418&id=64204

REVISION DETAIL
  https://phabricator.kde.org/D23047

AFFECTED FILES
  src/kicontheme.cpp

To: apol, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D22723: Fix RunnerManager::queryFinished()

2019-08-21 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> runnermanager.cpp:360
>  
> +teardownRequested = true;
>  checkTearDown();

can you explain why we need this?

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D22723: Fix RunnerManager::queryFinished()

2019-08-21 Thread Aleix Pol Gonzalez
apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in runnermanager.cpp:360
> can you explain why we need this?

In checkTearDown we have the code that reacts to the job being done. If we 
don't set it to true we'll never be looking at whether all jobs are done 
because we'll exit early the function.

Note that so far it was only being set to true in single runner mode, so it was 
impossible it we'd ever emit queryFinished() otherwise.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23300: Add FictionBook 2 icons

2019-08-21 Thread Yuri Chornoivan
yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D23300: Add FictionBook 2 icons

2019-08-21 Thread Yuri Chornoivan
yurchor updated this revision to Diff 64206.
yurchor added a comment.


  Total unbrutalization

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64186&id=64206

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D23300: Add FictionBook 2 icons

2019-08-21 Thread Nathaniel Graham
ngraham added a comment.


  Haha that pink might be a bit too un-brutalist. :) Orange-on-pink isn't 
exactly the best color combination. A blue background of some sort might be 
nicer with the orange polygon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D23300: Add FictionBook 2 icons

2019-08-21 Thread Yuri Chornoivan
yurchor edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D23300: Add FictionBook 2 icons

2019-08-21 Thread Yuri Chornoivan
yurchor updated this revision to Diff 64212.
yurchor added a comment.


  Use blue background

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64206&id=64212

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D23314: Fix runnertest exiting early

2019-08-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:f53b34e179ce: Fix runnertest exiting early (authored by 
davidedmundson).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23314?vs=64190&id=64215

REVISION DETAIL
  https://phabricator.kde.org/D23314

AFFECTED FILES
  tests/runnertest.cpp

To: davidedmundson, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23315: Port runnertest to QGuiApplication

2019-08-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R308:54d55441ec7e: Port runnertest to QGuiApplication 
(authored by davidedmundson).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23315?vs=64192&id=64216

REVISION DETAIL
  https://phabricator.kde.org/D23315

AFFECTED FILES
  tests/runnertest.cpp

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23312: JSP: support of

2019-08-21 Thread Dominik Haumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Nice simplification.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  jsp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23312

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D22723: Fix RunnerManager::queryFinished()

2019-08-21 Thread David Edmundson
davidedmundson added a comment.


  Makes sense, thanks.
  
  (well makes sense, within the confines of the mess that is RunnerManager)
  
  This morning I accepted Fabian's patch, but it wasn't complete.
  
  Can you merge these two lines from your patch: 
https://phabricator.kde.org/P455

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23300: Add FictionBook 2 icons

2019-08-21 Thread Nathaniel Graham
ngraham added a subscriber: ndavis.
ngraham added a comment.


  LGTM. @ndavis?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D23300: Add FictionBook 2 icons

2019-08-21 Thread Noah Davis
ndavis added a comment.


  Reduce the size of the SVGs by optimizing them with one of these tools: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23300

To: yurchor, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

2019-08-21 Thread Volker Krause
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23323

AFFECTED FILES
  src/core/ktcpsocket.cpp
  src/core/ktcpsocket.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23300: Add FictionBook 2 icons

2019-08-21 Thread Yuri Chornoivan
yurchor updated this revision to Diff 64236.
yurchor added a comment.


  Optimize SVG with svgcleaner + svgo

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23300?vs=64212&id=64236

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23300

AFFECTED FILES
  icons/mimetypes/16/application-x-fictionbook+xml.svg
  icons/mimetypes/16/application-x-zip-compressed-fb2.svg
  icons/mimetypes/22/application-x-fictionbook+xml.svg
  icons/mimetypes/22/application-x-zip-compressed-fb2.svg
  icons/mimetypes/32/application-x-fictionbook+xml.svg
  icons/mimetypes/32/application-x-zip-compressed-fb2.svg
  icons/mimetypes/64/application-x-fictionbook+xml.svg
  icons/mimetypes/64/application-x-zip-compressed-fb2.svg

To: yurchor, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D22708: [WIP] Add a kded module infra for fuse mount services

2019-08-21 Thread Alexander Saoutkin
feverfew added a comment.


  In D22708#507449 , @ngraham wrote:
  
  > What?
  
  
  Don't worry, all is fine. I've taken over Chinmoy's work on this for now. We 
agreed on a better way to go about integrating KIOFuse into KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: feverfew, ngraham, andriusr, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D22708: [WIP] Add a kded module infra for fuse mount services

2019-08-21 Thread Nathaniel Graham
ngraham added a comment.


  Oh good. :) Is there anywhere I can follow the progress?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: feverfew, ngraham, andriusr, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D22708: [WIP] Add a kded module infra for fuse mount services

2019-08-21 Thread Alexander Saoutkin
feverfew added a comment.


  In D22708#516128 , @ngraham wrote:
  
  > Oh good. :) Is there anywhere I can follow the progress?
  
  
  All my work goes on KIOFuse goes into review here:
  https://gitlab.com/Vogtinator/kio-fuse/merge_requests
  
  Sometimes I need to upload diffs upstream to KIO to fix bugs or for 
integrating KIOFuse into KIO. Those can be followed via my phabricator diffs. I 
have some (i.e. KIO bug fixes) that I would like to get into 5.62, but no one 
is able to review/approve my KIO changes atm...
  
  Also feel free to pop by #kde-fm for discussions or if you want to ask a 
question.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: feverfew, ngraham, andriusr, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D22708: [WIP] Add a kded module infra for fuse mount services

2019-08-21 Thread Nathaniel Graham
ngraham added a comment.


  In D22708#516131 , @feverfew wrote:
  
  > In D22708#516128 , @ngraham 
wrote:
  >
  > > Oh good. :) Is there anywhere I can follow the progress?
  >
  >
  > All my work goes on KIOFuse goes into review here:
  >  https://gitlab.com/Vogtinator/kio-fuse/merge_requests
  
  
  Thanks!
  
  > Sometimes I need to upload diffs upstream to KIO to fix bugs or for 
integrating KIOFuse into KIO. Those can be followed via my phabricator diffs. I 
have some (i.e. KIO bug fixes) that I would like to get into 5.62, but no one 
is able to review/approve my KIO changes atm...
  
  I'll see if I can get some attention on them.
  
  > Also feel free to pop by #kde-fm for discussions or if you want to ask a 
question.
  
  It kicks me out for not having a registered nickname even though I totally do 
and am using it. If it's not necessary anymore, it might be nice to remove that 
restriction.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: feverfew, ngraham, andriusr, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D22708: [WIP] Add a kded module infra for fuse mount services

2019-08-21 Thread Alexander Saoutkin
feverfew added a comment.


  In D22708#516132 , @ngraham wrote:
  
  > In D22708#516131 , @feverfew 
wrote:
  >
  > > In D22708#516128 , @ngraham 
wrote:
  > >
  > > >
  > >
  > >
  > > Also feel free to pop by #kde-fm for discussions or if you want to ask a 
question.
  >
  >
  > It kicks me out for not having a registered nickname even though I totally 
do and am using it. If it's not necessary anymore, it might be nice to remove 
that restriction.
  
  
  Yeah I've had problems accessing that channel via matrix unless I used 
Konversation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: feverfew, ngraham, andriusr, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D9175: Migrate some more QRegExps to QRegularExpression

2019-08-21 Thread Dominik Haumann
dhaumann updated this revision to Diff 64248.
dhaumann added a comment.


  - Rebase from 2016 to year 2019.
  
  I don't even know whether it still compiles...

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9175?vs=23538&id=64248

BRANCH
  QRegExpCleanup2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9175

AFFECTED FILES
  src/search/kateplaintextsearch.cpp
  src/search/kateregexpsearch.h
  src/search/katesearchbar.cpp
  src/utils/codecompletionmodelcontrollerinterface.cpp
  src/utils/katebookmarks.cpp
  src/utils/katecommandrangeexpressionparser.cpp
  src/utils/katesedcmd.cpp
  src/variableeditor/variablelistview.cpp
  src/view/kateview.cpp

To: dhaumann, cullmann, kfunk, mwolff
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D23312: JSP: support of

2019-08-21 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:433e5d85979c: JSP: support of