D23597: Bulk port away from foreach
kossebau added inline comments. INLINE COMMENTS > kossebau wrote in kfontsizeaction.cpp:93 > Will test is this works, but IIRC actions() returned a normal left-side value > thingie, which qAsConst does not want to take. Yes, `qAsConst(actions())` does not work, as actions() is a r-value type, which qAsConst does not take (move overload of qAsConst explicitly deleted), following std::as_const here, to not run into dangling pointers. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23597 To: kossebau, #frameworks, cfeck Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23597: Bulk port away from foreach
kossebau updated this revision to Diff 65089. kossebau added a comment. - align * & & with var name, not type, by current KF coding style - fix "fir" for "for" REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23597?vs=65032&id=65089 BRANCH portmostfporeach REVISION DETAIL https://phabricator.kde.org/D23597 AFFECTED FILES autotests/kacceleratormanagertest.cpp autotests/kdatetimeedittest.cpp src/common_helpers.cpp src/fonthelpers.cpp src/kacceleratormanager.cpp src/kactionselector.cpp src/kcharselect.cpp src/kcharselectdata.cpp src/kcollapsiblegroupbox.cpp src/kcolumnresizer.cpp src/kdatetimeedit.cpp src/kfontaction.cpp src/kfontrequester.cpp src/kfontsizeaction.cpp src/kmessagebox_p.cpp src/kmessagewidget.cpp src/kmimetypechooser.cpp src/kselectaction.cpp src/kselectaction_p.h src/ksqueezedtextlabel.cpp src/ktimecombobox.cpp src/ktoolbarlabelaction.cpp src/kviewstateserializer.h To: kossebau, #frameworks, cfeck Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D7446: [Places panel] Revamp the Recently Saved section
meven added a comment.
Should we add this to existing users places settings ?
Like we do with `withBaloo` for instance, adding it if it was not added
before.
INLINE COMMENTS
> kfileplacesmodel.cpp:315
> +// Add a Recently Used entry if available (it comes from kio-extras)
> +if (KProtocolInfo::isKnownProtocol(QStringLiteral("recentlyused"))) {
> +KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
Should we add this to existing places settings ?
Like we do with `withBaloo` for instance, adding it if it was not added before.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7446
To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel,
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik,
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, vmarinescu,
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,
michaelh, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,
mikesomov
D22069: Localize long number strings
ngraham added a comment. I'm not sure I understand about about localization to figure that out. Would you be able to help me out? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/47/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 01 Sep 2019 02:57:57 + Build duration: 8 min 18 sec and counting JUnit Tests Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
D23597: Bulk port away from foreach
cfeck added inline comments.
INLINE COMMENTS
> kacceleratormanagertest.cpp:35
> +const auto menuActions = menu.actions();
> +for (const QAction* action : menuActions) {
> if (action->isSeparator()) {
Please use KF5 coding style: `Type *var` instead of `Type* var` (also for `&`
references),
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D23597
To: kossebau, #frameworks, cfeck
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23619: Introduce cloning and replication of output devices
romangg added a comment. If the output device - that is the replication source - goes away (hot plug) we need to clear the `replicationSource` field in the other output device. This is straight forward with a single connect but question is if afterwards the replicate event should be send to clients with null string (and a flag indicating that this source removal was due to a hotplug and was not set explicitly) or if they should just conclude this from the other output device going away. A similar case is the replication source being switched off while staying connected. Here the output device does not go away, but the wl_output normally should. Still it makes sense to not replicate an output which is switched off. So remove the replication source in the compositor and then signaled to the clients? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23619: Introduce cloning and replication of output devices
romangg retitled this revision from "[server] Introduce cloning and replication of output devices" to "Introduce cloning and replication of output devices". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23619: [server] Introduce cloning and replication of output devices
romangg added inline comments. INLINE COMMENTS > zzag wrote in outputdevice.cpp:391 > Correction: that's not reliable way to check whether a C string is empty. You > assume that all empty strings have the same address, which in some cases > cannot be true, e.g. if the string is dynamically allocated. Will change in next revision. It currently also does not yet check if the provided source uuid is not the one of the output-device itself. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23619: [server] Introduce cloning and replication of output devices
zzag added inline comments. INLINE COMMENTS > zzag wrote in outputdevice.cpp:391 > That's not safe if the raw string is dynamically allocated, use qstrlen > instead. Correction: that's not reliable way to check whether a C string is empty. You assume that all empty strings have the same address, which in some cases cannot be true, e.g. if the string is dynamically allocated. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23619: [server] Introduce cloning and replication of output devices
zzag added inline comments.
INLINE COMMENTS
> outputdevice.cpp:391
> +Q_UNUSED(output);
> +if (!source_uuid || source_uuid == "") {
> +o->replicationSource.clear();
That's not safe if the raw string is dynamically allocated, use qstrlen instead.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D23619
To: romangg, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23619: [server] Introduce cloning and replication of output devices
romangg added a task: T11222: Reimagine output cloning. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23619 To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23619: [server] Introduce cloning and replication of output devices
romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY The org_kde_kwin_outputdevice and respective org_kde_kwin_outputconfiguration protocols will be extended by events to indicate the current replication and clone status of an output device and a request to change the replication. Here the notion of clones designate outputs sharing the same properties in an immutable fahsion. This is mostly dependent on hardware characteristics when outputs share a common CRTC. Changes to such an output will inevitably apply to all its clones alike. The property is meant mainly to inform clients about such a relation. Replicas on the other side are arbitrary duplications of the image on an output on other ones. This is an one-to-many relation allowing one output as source of the image, also called the replication source, and arbitrary many other outputs as replicas of the replicaiton source. It is expected that the compositor has means to facilitate the replication in a sensible way, for example by providing black bars to compensate for different aspect ratios. Besides the protocol description changes and standard client API this patch introduces on server side new functions and algorithms to make use of this new interface in an efficient way: - Logical position and size are cached values of the current position and size of the output in compositor space respecting the replication status. - The cached clients-scale is the recommended scaling factor sent to clients on this output such that clients on the replication source and all replicas can provide buffers of optimal resolution. It is the ceiled maximum of all width and height quotients between replicas and replication source and the replication source scale itself. When an output is not a replica it always equals the ceiled scale value of the output. - The view-geometry provides a recommended geometry, which is cached as well, of positioning the actual viewable area on the output in pixel-coordinates. Using this geometry the aspect ratio of the final image on every replica will be the same one as the one of the replication source. The geometry returned is a rectangle positioned at the origin with size equaling output's mode size when the output is not a replica. TEST PLAN Tested with patches in KWin, libkscreen and KScreen. Autotests in the future. REPOSITORY R127 KWayland BRANCH clone REVISION DETAIL https://phabricator.kde.org/D23619 AFFECTED FILES src/client/outputconfiguration.cpp src/client/outputconfiguration.h src/client/outputdevice.cpp src/client/outputdevice.h src/client/protocols/output-management.xml src/client/protocols/outputdevice.xml src/client/registry.cpp src/server/outputchangeset.cpp src/server/outputchangeset.h src/server/outputchangeset_p.h src/server/outputconfiguration_interface.cpp src/server/outputdevice_interface.cpp src/server/outputdevice_interface.h src/server/outputmanagement_interface.cpp To: romangg, #kwin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/46/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 31 Aug 2019 18:19:08 + Build duration: 7 min 54 sec and counting JUnit Tests Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/21/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 31 Aug 2019 18:19:08 + Build duration: 6 min 16 sec and counting CONSOLE OUTPUT [...truncated 576 lines...][2019-08-31T18:25:03.238Z] [ 2%] Generating index.cache.bz2[2019-08-31T18:25:03.238Z] Scanning dependencies of target docs-kcontrol5-smb-index-cache-bz2[2019-08-31T18:25:03.744Z] Scanning dependencies of target docs-kcontrol5-trash-index-cache-bz2[2019-08-31T18:25:03.744Z] [ 3%] Generating index.cache.bz2[2019-08-31T18:25:03.744Z] [ 3%] Built target docs-kioslave5-telnet-index-cache-bz2[2019-08-31T18:25:03.744Z] [ 3%] Generating index.cache.bz2[2019-08-31T18:25:03.744Z] Scanning dependencies of target docs-kcontrol5-useragent-index-cache-bz2[2019-08-31T18:25:03.744Z] [ 3%] Built target docs-kioslave5-webdav-index-cache-bz2[2019-08-31T18:25:03.744Z] [ 3%] Built target docs-kcontrol5-cache-index-cache-bz2[2019-08-31T18:25:03.744Z] [ 3%] Generating index.cache.bz2[2019-08-31T18:25:03.744Z] Scanning dependencies of target docs-kcontrol5-webshortcuts-index-cache-bz2[2019-08-31T18:25:03.744Z] [ 3%] Built target docs-kcontrol5-cookies-index-cache-bz2[2019-08-31T18:25:03.744Z] Scanning dependencies of target KF5KIO_QCH[2019-08-31T18:25:03.744Z] [ 3%] Built target docs-kcontrol5-netpref-index-cache-bz2[2019-08-31T18:25:03.744Z] [ 3%] Generating index.cache.bz2[2019-08-31T18:25:03.744Z] Scanning dependencies of target copy_protocols[2019-08-31T18:25:03.744Z] Scanning dependencies of target protocoltojson_autogen[2019-08-31T18:25:03.744Z] [ 3%] Generating src/KF5KIO.qch, src/KF5KIO.tags[2019-08-31T18:25:04.247Z] [ 4%] Built target copy_protocols[2019-08-31T18:25:04.247Z] [ 4%] Automatic MOC for target protocoltojson[2019-08-31T18:25:04.247Z] [ 4%] Built target docs-kcontrol5-proxy-index-cache-bz2[2019-08-31T18:25:04.247Z] Scanning dependencies of target KF5KIONTLM_autogen[2019-08-31T18:25:04.247Z] Scanning dependencies of target kded_kcookiejar_autogen[2019-08-31T18:25:04.248Z] [ 4%] Automatic MOC for target KF5KIONTLM[2019-08-31T18:25:04.248Z] [ 4%] Built target protocoltojson_autogen[2019-08-31T18:25:04.248Z] [ 4%] Automatic MOC for target kded_kcookiejar[2019-08-31T18:25:04.248Z] [ 4%] Built target KF5KIONTLM_autogen[2019-08-31T18:25:04.248Z] Scanning dependencies of target kcookiejar5_autogen[2019-08-31T18:25:04.248Z] [ 5%] Automatic MOC for target kcookiejar5[2019-08-31T18:25:04.248Z] Scanning dependencies of target ktelnetservice5_autogen[2019-08-31T18:25:04.759Z] [ 5%] Built target kcookiejar5_autogen[2019-08-31T18:25:04.759Z] [ 5%] Automatic MOC for target ktelnetservice5[2019-08-31T18:25:04.759Z] [ 5%] Built target ktelnetservice5_autogen[2019-08-31T18:25:04.759Z] Scanning dependencies of target httpheadertokenizetest_autogen[2019-08-31T18:25:04.759Z] [ 5%] Automatic MOC for target httpheadertokenizetest[2019-08-31T18:25:04.759Z] [ 5%] Built target docs-kcontrol5-trash-index-cache-bz2[2019-08-31T18:25:04.759Z] Scanning dependencies of target httpfiltertest_autogen[2019-08-31T18:25:04.759Z] [ 5%] Built target docs-kcontrol5-smb-index-cache-bz2[2019-08-31T18:25:04.759Z] [ 5%] Automatic MOC for target httpfiltertest[2019-08-31T18:25:04.759Z] Scanning dependencies of target httpheaderdispositiontest_autogen[2019-08-31T18:25:04.759Z] Scanning dependencies of target KF5KIOCore_autogen[2019-08-31T18:25:05.266Z] [ 5%] Automatic MOC for target httpheaderdispositiontest[2019-08-31T18:25:05.266Z] [ 5%] Built target kded_kcookiejar_autogen[2019-08-31T18:25:05.266Z] [ 5%] Automatic MOC for target KF5KIOCore[2019-08-31T18:25:05.266Z] [ 5%] Built target docs-kcontrol5-useragent-index-cache-bz2[2019-08-31T18:25:05.266Z] [ 5%] Built target docs-kcontrol5-webshortcuts-index-cache-bz2[2019-08-31T18:25:05.771Z] [ 5%] Built target httpheadertokenizetest_autogen[2019-08-31T18:25:05.771Z] [ 5%] Generating org.kde.KCookieServer.xml[2019-08-31T18:25:05.771Z] Scanning dependencies of target protocoltojson[2019-08-31T18:25:05.771Z] [ 5%] Built target httpheaderdispositiontest_autogen[2019-08-31T18:25:05.771Z] [ 5%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/main.cpp.obj[2019-08-31T18:25:06.375Z] main.cpp[2019-08-31T18:25:06.375Z] [ 5%] Generating kcookieserveradaptor.cpp, kcookieserveradaptor.h[2019-08-31T18:25:06.375Z] qdbusxml2cpp: Cannot process input: 'C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/build/src/ioslaves/http/kcookiejar/org.kde.KCookieServer.xml'. Stop.[2019-08-31T18:25:06.375Z] jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.13\build\src\ioslaves\http\kcookiejar\CMakeFiles\kded_kcookiejar.dir\build.make [src\ioslaves\http\kcookiejar\kcookieserveradaptor.cpp] Error 1[2019-08-31T18:25:06.375Z] [ 5%] Built target httpfiltertest_autogen[2019-08-31T18:25:06.375Z] Scanning dependencies of target KF5KIONTLM[2019-08-31T18:25:06.
D23323: Add support for handling QNAM SSL errors to KSslErrorUiData
This revision was automatically updated to reflect the committed changes. Closed by commit R241:b97ce61950c9: Add support for handling QNAM SSL errors to KSslErrorUiData (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23323?vs=64233&id=65061#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23323?vs=64233&id=65061 REVISION DETAIL https://phabricator.kde.org/D23323 AFFECTED FILES src/core/ktcpsocket.cpp src/core/ktcpsocket.h To: vkrause, #frameworks, dfaure Cc: dhaumann, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23597: Bulk port away from foreach
kossebau added a comment.
Thanks for review @dhaumann :) Well, if you like I can give KTextEditor a
try, motivated there with my KDevelop hat on :) Let's see when I am sleepless
at the computer next time ;)
INLINE COMMENTS
> dhaumann wrote in fonthelpers.cpp:97
> Optionally, you could even write:
>
> static const auto genericNames = {
> QLatin1String("..."), ...
> };
>
> This initializer list will then even not require any memory allocation. You
> don't have.contains() later, though... You'd need to simply use std::find()
> semantics.
Yes, it was the contains() which was my motivation here to stay with
QStringList.
> dhaumann wrote in kfontsizeaction.cpp:93
> Imho here `qAsConst(actions())` would be nicer to avoid this->.
Will test is this works, but IIRC actions() returned a normal left-side value
thingie, which qAsConst does not want to take.
> dhaumann wrote in kviewstateserializer.h:134
> I think `fir` does not compile, does it?
That was... left as exercise for the person copying the code from the docs ;)
Alright, not. Well spotted.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D23597
To: kossebau, #frameworks, cfeck
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23323: Add support for handling QNAM SSL errors to KSslErrorUiData
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ktcpsocket.h:416 > +/** > + * Create an instance and initialize it with SSL error data from @p > reply. > + */ @since 5.62 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause, #frameworks, dfaure Cc: dhaumann, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23597: Bulk port away from foreach
dhaumann added a comment. PS: could you do the same for kate.git ? :-D REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23597 To: kossebau, #frameworks, cfeck Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23597: Bulk port away from foreach
dhaumann added a comment.
I think the patch is fine: +1
Please address/comment on `fir` :) besides that, another review won't hurt,
since you simplify the code in 1-2 places, i.e. the changes are slightly more
than just the transition to `for`.
INLINE COMMENTS
> fonthelpers.cpp:97
> // Generic fonts, in the inverse of desired order.
> -QStringList genericNames;
> -genericNames.append(QStringLiteral("Monospace"));
> -genericNames.append(QStringLiteral("Serif"));
> -genericNames.append(QStringLiteral("Sans Serif"));
> +const QStringList genericNames {
> +QStringLiteral("Monospace"),
Optionally, you could even write:
static const auto genericNames = {
QLatin1String("..."), ...
};
This initializer list will then even not require any memory allocation. You
don't have.contains() later, though... You'd need to simply use std::find()
semantics.
> kfontsizeaction.cpp:93
> +const auto actions = this->actions();
> +for (QAction* action : actions) {
> if (action->text() == test) {
Imho here `qAsConst(actions())` would be nicer to avoid this->.
> kviewstateserializer.h:134
> QStringList itemStrings;
> -Q_FOREACH(qint64 item, items)
> +fir (qint64 item : items)
>itemStrings << QString::number(item);
I think `fir` does not compile, does it?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D23597
To: kossebau, #frameworks, cfeck
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 31 Aug 2019 07:39:23 + Build duration: 1 hr 7 min and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest
D23598: Make battery serial property constant
This revision was automatically updated to reflect the committed changes. Closed by commit R245:76710483c865: Make battery serial property constant (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23598?vs=65033&id=65041 REVISION DETAIL https://phabricator.kde.org/D23598 AFFECTED FILES src/solid/devices/frontend/battery.h To: meven, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23323: Add support for handling QNAM SSL errors to KSslErrorUiData
vkrause added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause, #frameworks, dfaure Cc: dhaumann, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23598: Make battery serial property constant
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D23598 To: meven, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23598: Make battery serial property constant
meven edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23598 To: meven, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23598: Make battery serial property constant
meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Since serial property cannot change and has no NOTIFY function, mark it as constant, to avoid warnings when the property is used in qml expression. For instance in kinfocenter energy_info kcm : QQmlExpression: Expression file:///home/meven/kde/usr/share/kpackage/kcms/kcm_energyinfo/contents/ui/main.qml:452:29 depends on non-NOTIFYable properties: Solid::Battery::serial REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D23598 AFFECTED FILES src/solid/devices/frontend/battery.h To: meven, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
