D23778: Remove superfluous 32px recent documents icons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:fbbc49bf219b: Remove superfluous 32px recent documents 
icons (authored by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23778?vs=65708&id=65717

REVISION DETAIL
  https://phabricator.kde.org/D23778

AFFECTED FILES
  icons-dark/actions/32/document-open-recent.svg
  icons/actions/32/document-open-recent.svg

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  There is some small risk here:
  
  - overseen call chains which still call the owner and modify the container
  - other threads might access the same containers, even if class is not 
designed to be thread-safe, but wrong usages are currently caught mostly by the 
container copy
  
  GIT_SILENT

REPOSITORY
  R263 KXmlGui

BRANCH
  portmoreforeachmethodargswithotrecursivecalls

REVISION DETAIL
  https://phabricator.kde.org/D23813

AFFECTED FILES
  autotests/kxmlgui_unittest.cpp
  autotests/testguiclient.h
  autotests/testxmlguiwindow.h
  src/kkeysequencewidget.cpp
  src/kshortcutschemeshelper.cpp
  src/kxmlguiclient.cpp
  src/kxmlguifactory.cpp
  src/kxmlguiversionhandler.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23812: Port away from foreach loops over members without calls to owner class

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  There is some small risk here:
  
  - overseen call chains which still call the owner and modify the container
  - other threads might access the same containers, even if class is not 
designed to be thread-safe, but wrong usages are currently caught mostly by the 
container copy
  
  GIT_SILENT

REPOSITORY
  R263 KXmlGui

BRANCH
  portmoreforeachwithoutrecursivecalls

REVISION DETAIL
  https://phabricator.kde.org/D23812

AFFECTED FILES
  src/kactioncollection.cpp
  src/kgesture.cpp
  src/kkeysequencewidget.cpp
  src/kshortcutsdialog.cpp
  src/kshortcutseditor.cpp
  src/ktoolbar.cpp
  src/ktoolbarhandler.cpp
  src/kxmlguiclient.cpp
  src/kxmlguifactory.cpp
  src/kxmlguifactory_p.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23810: Port away from Qt's foreach all loops over rvalue container objects

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 65714.
kossebau added a comment.


  add some more of this category

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23810?vs=65712&id=65714

BRANCH
  portmoreforeachforlocalcontainerobjects

REVISION DETAIL
  https://phabricator.kde.org/D23810

AFFECTED FILES
  autotests/ktoolbar_unittest.cpp
  src/kedittoolbar.cpp
  src/kmainwindow.cpp
  src/kmenumenuhandler_p.cpp
  src/kshortcutschemeseditor.cpp
  src/kshortcutschemeshelper.cpp
  src/kshortcutseditor.cpp
  src/ktoolbar.cpp
  src/kxmlguifactory.cpp
  src/kxmlguiwindow.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

[Christoph Feck]

cfeck created this revision.
cfeck added a reviewer: Frameworks.
cfeck added a project: Gwenview.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cfeck requested review of this revision.

TEST PLAN
  Tested with HDR images from hdrihaven.com
  
  - Loading in KolourPaint works
  - Thumbnails in Dolphin work

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D23811

AFFECTED FILES
  src/imageformats/CMakeLists.txt
  src/imageformats/hdr.cpp
  src/imageformats/hdr.json
  src/imageformats/hdr_p.h

To: cfeck, #frameworks
Cc: kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, huoni, 
michaelh, muhlenpfordt, rkflx, ngraham, bruns

D23778: Remove superfluous 32px recent documents icons

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-superfluous-recent-docs-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23778

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23713: strongswan support for custom proposals

[Robert Richmond]

rrichmond marked 5 inline comments as done.

REVISION DETAIL
  https://phabricator.kde.org/D23713

To: rrichmond, fvogt, jgrulich
Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23713: strongswan support for custom proposals

[Robert Richmond]

rrichmond updated this revision to Diff 65711.
rrichmond added a comment.


  Moved custom cipher proposals into its own group box, with the checked 
property, encompassing the IKE/ESP proposal QLineEdit boxes.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23713?vs=65357&id=65711

REVISION DETAIL
  https://phabricator.kde.org/D23713

AFFECTED FILES
  plasma-nm-5.15.5/vpn/strongswan/nm-strongswan-service.h
  plasma-nm-5.15.5/vpn/strongswan/strongswanprop.ui
  plasma-nm-5.15.5/vpn/strongswan/strongswanwidget.cpp

To: rrichmond, fvogt, jgrulich
Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23810: Port away from Qt's foreach all loops over rvalue container objects

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The other simple part of foreach porting, as those containers objects
  are not shared with anyone, so the removal of the container copying has
  no risks.
  
  GIT_SILENT

REPOSITORY
  R263 KXmlGui

BRANCH
  portmoreforeachforlocalcontainerobjects

REVISION DETAIL
  https://phabricator.kde.org/D23810

AFFECTED FILES
  autotests/ktoolbar_unittest.cpp
  src/kedittoolbar.cpp
  src/kmainwindow.cpp
  src/kmenumenuhandler_p.cpp
  src/kshortcutschemeseditor.cpp
  src/kshortcutschemeshelper.cpp
  src/ktoolbar.cpp
  src/kxmlguifactory.cpp
  src/kxmlguiwindow.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23801: Port kpac from QtScript

[Sandro Knauß]

knauss added a task: T11530: Investigate removal of KIO's KPAC in favor of 
QNetworkProxy.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23801

To: carewolf, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:f9f2ef104fa7: Remove the man KPart, and thus the last 
KHtml user in kio-extras (authored by vkrause).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23809?vs=65707&id=65710

REVISION DETAIL
  https://phabricator.kde.org/D23809

AFFECTED FILES
  CMakeLists.txt
  man/CMakeLists.txt
  man/kmanpart.cpp
  man/kmanpart.desktop
  man/kmanpart.h

To: vkrause, dfaure, broulik
Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D23664: Port away from Qt's foreach all loops over method-local containers

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:867351258d1f: Port away from Qt's foreach all loops 
over method-local containers (authored by kossebau).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23664?vs=65213&id=65709

REVISION DETAIL
  https://phabricator.kde.org/D23664

AFFECTED FILES
  autotests/kxmlgui_unittest.cpp
  src/kedittoolbar.cpp
  src/kkeysequencewidget.cpp
  src/kmainwindow.cpp
  src/kmainwindowiface.cpp
  src/kshortcutschemeseditor.cpp
  src/kshortcutseditor.cpp
  src/kswitchlanguagedialog_p.cpp
  src/ktoolbar.cpp
  src/ktoolbarhandler.cpp
  src/kxmlguifactory.cpp
  src/kxmlguiversionhandler.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23797: [KWidgetAddons] port to non-deprecated Qt API

[Christoph Feck]

cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.


  Merci!

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23797

To: dfaure, cfeck
Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23778: Remove superfluous >22px recent documents icons

[Nathaniel Graham]

ngraham updated this revision to Diff 65708.
ngraham added a comment.


  Restore 24px versions (they will be deleted later)

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23778?vs=65596&id=65708

BRANCH
  remove-superfluous-recent-docs-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23778

AFFECTED FILES
  icons-dark/actions/32/document-open-recent.svg
  icons/actions/32/document-open-recent.svg

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23778: Remove superfluous 32px recent documents icons

[Nathaniel Graham]

ngraham retitled this revision from "Remove superfluous >22px recent documents 
icons" to "Remove superfluous 32px recent documents icons".
ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23778

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23664: Port away from Qt's foreach all loops over method-local containers

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  plainporttorangeloop

REVISION DETAIL
  https://phabricator.kde.org/D23664

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23809

To: vkrause, dfaure, broulik
Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23809

To: vkrause, dfaure
Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D23782: Add "edit-none-border" icon

[Nathaniel Graham]

ngraham added a comment.


  I kinda liked the originally proposed icon IMO. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23782

To: GB_2, #vdg, ndavis
Cc: trickyricky26, ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, 
LeGast00n, GB_2, michaelh, bruns

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

[Nathaniel Graham]

ngraham added a comment.


  +1

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23809

To: vkrause, dfaure
Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, mikesomov

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  The man KPart was originally added to open troff files directly from
  Konqueror. This however doesn't work nowadays anymore as the man page
  files are compressed on most systems and thus cannot be detected as
  troff files.
  
  This does not affect the man kioslave, which remains to work as before.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23809

AFFECTED FILES
  CMakeLists.txt
  man/CMakeLists.txt
  man/kmanpart.cpp
  man/kmanpart.desktop
  man/kmanpart.h

To: vkrause, dfaure
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23667: Add == and != operators to KIO::UDSEntry

[Méven Car]

meven updated this revision to Diff 65705.
meven added a comment.


  Remove unneeded friend function declarations

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23667?vs=65608&id=65705

BRANCH
  arcpatch-D23667

REVISION DETAIL
  https://phabricator.kde.org/D23667

AFFECTED FILES
  autotests/udsentrytest.cpp
  autotests/udsentrytest.h
  src/core/udsentry.cpp
  src/core/udsentry.h
  tests/udsentrybenchmark.cpp

To: meven, #frameworks, ngraham
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23797: [KWidgetAddons] port to non-deprecated Qt API

[David Faure]

dfaure updated this revision to Diff 65703.
dfaure added a comment.


  constify, sort includes

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23797?vs=65673&id=65703

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23797

AFFECTED FILES
  autotests/kpasswordlineedittest.cpp
  autotests/ksqueezedtextlabelautotest.cpp
  src/kassistantdialog.cpp
  src/kcapacitybar.cpp
  src/kcollapsiblegroupbox.cpp
  src/kcolorbutton.cpp
  src/kdatecombobox.cpp
  src/kdatepicker.cpp
  src/kdatetable.cpp
  src/kfontchooser.cpp
  src/kmessagebox.cpp
  src/kpixmapregionselectordialog.cpp
  src/kpopupframe.cpp
  src/kruler.cpp
  src/kselector.cpp
  src/ksqueezedtextlabel.cpp
  src/ktitlewidget.cpp
  src/kxyselector.cpp

To: dfaure, cfeck
Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23664: Port away from Qt's foreach all loops over method-local containers

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Ping :)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23664

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir marked 6 inline comments as done.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 65696.
leinir marked 2 inline comments as done.
leinir added a comment.


  - Add a simple cache for CommentsModel instances

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=65689&id=65696

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  CMakeLists.txt
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/commentsmodel.cpp
  src/qtquick/commentsmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/65/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 09 Sep 2019 16:53:19 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "WIP: Add ECMGenerateExportHeaders, for 
improved handling of deprecated API" to "RFC: Add ECMGenerateExportHeaders, for 
improved handling of deprecated API".

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23800

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23797: [KWidgetAddons] port to non-deprecated Qt API

[Dominik Haumann]

dhaumann added a comment.


  Lgtm.

INLINE COMMENTS

> dhaumann wrote in ktitlewidget.cpp:137
> Is that not needed anymore?

Sorry, the next line gives the answer ;)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23797

To: dfaure, cfeck
Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/17/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 09 Sep 2019 16:51:11 +
 Build duration:
2 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D23797: [KWidgetAddons] port to non-deprecated Qt API

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> ktitlewidget.cpp:137
>  d->headerLayout->setColumnStretch(0, 1);
> -d->headerLayout->setMargin(6);
>  d->headerLayout->setContentsMargins(0, 0, 0, 0);

Is that not needed anymore?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23797

To: dfaure, cfeck
Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D23802: RFC: Use ECMGenerateExportHeader 
to manage deprecated API better.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a dependency: D23789: WIP: Add ECMGenerateExportHeaders, for 
improved handling of deprecated API.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D23802

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau edited the test plan for this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D23802

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KService to hide deprecated API up to a given version 
or silence deprecation warnings before a given version, using
- -DKSERVICE_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKSERVICE_DEPRECATED_WARNINGS_SINCE
- -DKSERVICE_NO_DEPRECATED_WARNINGS
- -DKSERVICE_NO_DEPRECATED or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
- -DKF_NO_DEPRECATED
  - to build KService optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT and
  all the versions where deprecations were done.
  
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT and
  all the versions where deprecations were done.

REPOSITORY
  R309 KService

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23802

AFFECTED FILES
  CMakeLists.txt
  autotests/kplugininfotest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/CMakeLists.txt
  src/kdeinit/ktoolinvocation.cpp
  src/kdeinit/ktoolinvocation.h
  src/plugin/kdbusservicestarter.cpp
  src/plugin/kdbusservicestarter.h
  src/services/kplugininfo.cpp
  src/services/kplugininfo.h
  src/services/kservice.h
  src/sycoca/ksycoca.cpp
  src/sycoca/ksycoca.h
  tests/CMakeLists.txt

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir marked 3 inline comments as done.
leinir added inline comments.

INLINE COMMENTS

> broulik wrote in author.h:111
> `ProfilePage`?

In principle yes, except we can't change homepage to homePage, until KF6... and 
then we'd end up with mixed spelling styles, and that just makes me sad ;)

> broulik wrote in commentsmodel.cpp:184
> Any particular reason not do just return a null `QVariant()`?

Hmm... This actually is supposed to be "Unknown model role"... It's kind of 
corner-casey, but i've noticed in the past that something other than just an 
invalid QVariant is occasionally useful for those times where you've, say, 
missed the h in "depth" ;) Usually this wouldn't be hit, of course, so it's not 
actually expensive in any real way. But yes, compared to this, QVariant() would 
be the better option.

> broulik wrote in commentsmodel.h:70
> Why is this an explicit `Engine` pointer rather than generic `QObject`?

Entirely to make it awkward for people to use it in a counter-intended fashion 
:)

> broulik wrote in commentsmodel.h:75
> You might want to set that to `Qt::DisplayRole`

Hmm... i guess, except that it's not reeeally the obvious choice (because i 
don't really see one of those)... but yeah, having one is probably not terrible 
anyway.

> broulik wrote in commentsmodel.h:88
> `QModelIndex` is usable from QML these days, this overload isn't neccessary, 
> you can do from QML:
> 
>   model.data(model.index(row, column), role);

Aah! i did not know this, very handy indeed. Couple of places where that'll 
make life simpler :)

> broulik wrote in engine.cpp:803
> ah, so this is why it's not `const`

Indeed :) (and yes, that cache still needs to be made...)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23801: Port kpac from QtScript

[Allan Sandfeld Jensen]

carewolf created this revision.
carewolf added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
carewolf requested review of this revision.

REVISION SUMMARY
  Migrate the QtScript code to QJS classes.
  
  Warning: untested

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23801

AFFECTED FILES
  src/kpac/CMakeLists.txt
  src/kpac/script.cpp
  src/kpac/script.h

To: carewolf, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 65689.
leinir marked 3 inline comments as done.
leinir added a comment.


  Address comments by Kai Uwe and David
  
  - Use QQmlParserStatus to ensure we don't do unnecessary work
  - Get rid of all the extraneous data entries (also a couple of other bits)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=65579&id=65689

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  CMakeLists.txt
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/commentsmodel.cpp
  src/qtquick/commentsmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: davidedmundson, broulik, ahiemstra, anthonyfieroni, pino, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D23800: RFC: Use ECMGenerateExportHeader 
to manage deprecated API better.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a dependency: D23789: WIP: Add ECMGenerateExportHeaders, for 
improved handling of deprecated API.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23800

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KCoreAddons to hide deprecated API up to a given 
version or silence deprecation warnings before a given version, using 
-DKCOREADDONS_DISABLE_DEPRECATED_BEFORE_AND_AT 
-DKCOREADDONS_DEPRECATED_WARNINGS_SINCE -DKCOREADDONS_NO_DEPRECATED_WARNINGS 
-DKCOREADDONS_NO_DEPRECATED or -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT 
-DKF_DEPRECATED_WARNINGS_SINCE -DKF_NO_DEPRECATED_WARNINGS -DKF_NO_DEPRECATED
  - to build KCoreAddons optionally with deprecated API excluded from the 
build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT and
  all the versions where deprecations were done.

REPOSITORY
  R244 KCoreAddons

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23800

AFFECTED FILES
  CMakeLists.txt
  autotests/kaboutdatatest.cpp
  autotests/kusertest.cpp
  src/lib/CMakeLists.txt
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h
  src/lib/plugin/kexportplugin.h
  src/lib/plugin/kpluginfactory.cpp
  src/lib/plugin/kpluginfactory.h
  src/lib/util/kuser.h

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D10362: Change reveal password button logic

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fb18347e4dea: Change reveal password button logic 
(authored by GB_2).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10362?vs=65592&id=65681

REVISION DETAIL
  https://phabricator.kde.org/D10362

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TextField.qml

To: GB_2, #plasma, #vdg, ngraham, broulik, ndavis
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 65678.
kossebau added a comment.


  - change BEFORE to BEFORE_AND_AT, to match actual Qt behaviour (though do not 
copy confusing name, but be more precise using AND_AT
  - add NO_DEFINITION_EXPORT_TO_BUILD_INTERFACE option

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23789?vs=65655&id=65678

BRANCH
  addgenerateexportheader

REVISION DETAIL
  https://phabricator.kde.org/D23789

AFFECTED FILES
  docs/module/ECMGenerateExportHeader.rst
  modules/ECMGenerateExportHeader.cmake

To: kossebau
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D23797: [KWidgetAddons] port to non-deprecated Qt API

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kpopupframe.cpp:24
>  
> -#include 
> +#include 
>  #include 

Please keep this sorted.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23797

To: dfaure, cfeck
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/25/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 09 Sep 2019 15:12:13 +
 Build duration:
4 min 25 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/64/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 09 Sep 2019 14:16:26 +
 Build duration:
6 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/26/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 09 Sep 2019 14:05:50 +
 Build duration:
2 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D23797: [KWidgetAddons] port to non-deprecated Qt API

[Albert Astals Cid]

aacid added a comment.


  +1 looks sane but i have **not** tried this

INLINE COMMENTS

> kcollapsiblegroupbox.cpp:288
>  {
> -int top, left, right, bottom;
> -getContentsMargins(&left, &top, &right, &bottom);
> +QMargins margins = contentsMargins();
>  

if you get bored, add const?

> kpixmapregionselectordialog.cpp:53
>  //Set maximum size for picture
> -QDesktopWidget desktopWidget;
> -QRect screen = desktopWidget.availableGeometry();
> +QRect screenGeometry = 
> pixmapSelectorWidget->screen()->availableGeometry();
>  pixmapSelectorWidget->setMaximumWidgetSize(

same, if you get bored, const

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23797

To: dfaure, cfeck
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23797: [KWidgetAddons] port to non-deprecated Qt API

[David Faure]

dfaure created this revision.
dfaure added a reviewer: cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  Added "cxxflags -DQT_DISABLE_DEPRECATED_BEFORE=0x06" to
  kdesrc-build's kf5-frameworks-build-include (in the frameworks module-set)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23797

AFFECTED FILES
  autotests/kpasswordlineedittest.cpp
  autotests/ksqueezedtextlabelautotest.cpp
  src/kassistantdialog.cpp
  src/kcapacitybar.cpp
  src/kcollapsiblegroupbox.cpp
  src/kcolorbutton.cpp
  src/kdatecombobox.cpp
  src/kdatepicker.cpp
  src/kdatetable.cpp
  src/kfontchooser.cpp
  src/kmessagebox.cpp
  src/kpixmapregionselectordialog.cpp
  src/kpopupframe.cpp
  src/kruler.cpp
  src/kselector.cpp
  src/ksqueezedtextlabel.cpp
  src/ktitlewidget.cpp
  src/kxyselector.cpp

To: dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/25/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 09 Sep 2019 12:30:35 +
 Build duration:
1 min 50 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/24/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 09 Sep 2019 12:10:50 +
 Build duration:
8 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D23789: WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D23789#527769 , @cgiboudeaux 
wrote:
  
  > Tests needed :)
  
  
  Sure :) Will be done, once I know investment makes sense. For now interested 
in feedback whether the principle approach makes sense and is welcome/wanted, 
and what people think about the API of the macro as well as the generated 
API/macros for use in the code.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

Re: Proposing Quick Charts as a new framework

[Dominik Haumann]

Hi,

On Sat, Sep 7, 2019 at 3:59 PM Arjen Hiemstra  wrote:

> On 06-09-2019 02:49, Aleix Pol wrote:
> > On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra 
> > wrote:
> >>
> >> On 02-09-2019 19:26, Luigi Toscano wrote:
> >> > Arjen Hiemstra ha scritto:
>
[...]

> >> That's actually a good point, though the kf5 is only in the repository
> >> name, I
> >> name it "Quick Charts" everywhere else. Which is probably a good
> >> reason
> >> to have
> >> the repo name changed in the first place. :) Originally, I put kf5 in
> >> the repo
> >> name because that's what is used once installed as part of Frameworks,
> >> but I
> >> agree that it can lead to confusing things.
> >
> > It should be called kquickchart (which indeed is far too similar to
> > kqtquickcharts). Much like you use KF5CoreAddons, but the repository
> > is called kcoreaddons.
>
> To be fair, KCoreAddons is called KCoreAddons in its documentation, so
> it
> does not seem to be called "CoreAddons". At the same time, there are
> plenty
> of Frameworks that do not start with a K, like Solid, Prison or BluezQt.
> So I do not really see why it should be "kquickcharts".
>

Just my 2 cents:

The reason is consistency. Don't underestimate consistency. We have
done naming mistakes from time to time, but that should not imply
we should do it again.

+1 for KQuickCharts, names do matter.

Best regards
Dominik