D23713: strongswan support for custom proposals

[Jan Grulich]

jgrulich added a comment.


  Do not enable "Custom cipher proposals" by default, that forces everyone to 
uncheck it.

REVISION DETAIL
  https://phabricator.kde.org/D23713

To: rrichmond, fvogt, jgrulich
Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23815: [KConfig] port away from deprecated methods in Qt 5.14

[David Faure]

dfaure created this revision.
dfaure added reviewers: mdawson, arichardson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  In kconf_update, the ctime usage used to be about metadata change time
  (buff.st_ctime, before it got ported to the misnamed created()).
  I ported it to birthTime, because I think
  date of birth is a more useful way to identify a file than
  date of permission change which doesn't really matter to us.
  But in practice, I can't help but wonder if mtime alone wouldn't be
  enough.
  
  For the QStringLiteral("%%1").arg(i) bit, I tested it in tst_qstring,
  the first % is left untouched.

TEST PLAN
  make && ctest

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23815

AFFECTED FILES
  autotests/kconfigloadertest.cpp
  autotests/kconfigtest.cpp
  src/core/kcoreconfigskeleton.cpp
  src/kconf_update/kconf_update.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: dfaure, mdawson, arichardson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

[Albert Astals Cid]

aacid added a comment.


  Could you try to figure out if adding some autotest file would be hard?
  
  i think all is needed is an autotests/read/hdr folder with some hdr files and 
their png counterpart and then readtest will magically pick it up

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D23811

To: cfeck, #frameworks
Cc: aacid, kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, 
huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

[David Faure]

dfaure created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Unfortunately there is no QWidget::mapFromGlobal(QPointF).

TEST PLAN
  Builds.

REPOSITORY
  R276 KItemViews

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23816

AFFECTED FILES
  src/kwidgetitemdelegate.cpp
  src/kwidgetitemdelegatepool.cpp

To: dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23797: [KWidgetAddons] port to non-deprecated Qt API

[David Faure]

dfaure closed this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23797

To: dfaure, cfeck
Cc: dhaumann, aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.13/23/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Sep 2019 08:03:57 +
 Build duration:
2 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 240 lines...][2019-09-10T08:05:36.711Z] [  4%] Generating ui_knewpasswordwidget.h[2019-09-10T08:05:37.326Z] Scanning dependencies of target KF5WidgetsAddons[2019-09-10T08:05:37.326Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/KF5WidgetsAddons_autogen/mocs_compilation.cpp.o[2019-09-10T08:05:37.326Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kbusyindicatorwidget.cpp.o[2019-09-10T08:05:37.326Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kanimatedbutton.cpp.o[2019-09-10T08:05:37.326Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kacceleratormanager.cpp.o[2019-09-10T08:05:37.326Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselect.cpp.o[2019-09-10T08:05:37.326Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselectdata.cpp.o[2019-09-10T08:05:37.326Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcollapsiblegroupbox.cpp.o[2019-09-10T08:05:37.326Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorbutton.cpp.o[2019-09-10T08:05:42.805Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatepicker.cpp.o[2019-09-10T08:05:42.805Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o[2019-09-10T08:05:42.805Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolumnresizer.cpp.o[2019-09-10T08:05:42.805Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.o[2019-09-10T08:05:43.809Z] Building up file structure...[2019-09-10T08:05:43.809Z] Insert custom filters...[2019-09-10T08:05:43.809Z] Insert help data for filter section (1 of 1)...[2019-09-10T08:05:43.809Z] Insert files...[2019-09-10T08:05:43.809Z] Insert contents...[2019-09-10T08:05:43.809Z] Insert indices...[2019-09-10T08:05:43.809Z] Documentation successfully generated.[2019-09-10T08:05:43.809Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetimeedit.cpp.o[2019-09-10T08:05:43.809Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.o[2019-09-10T08:05:44.494Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/knewpasswordwidget.cpp.o[2019-09-10T08:05:45.513Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.o[2019-09-10T08:05:47.540Z] /usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.13/src/kfontaction.cpp:146:2: warning: #warning is a language extension [-Wpedantic][2019-09-10T08:05:47.540Z] #warning FIXME: items need to be converted[2019-09-10T08:05:47.540Z]  ^[2019-09-10T08:05:47.540Z] /usr/home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 FreeBSDQt5.13/src/kfontaction.cpp:146:2: warning: FIXME: items need to be converted [-W#warnings][2019-09-10T08:05:48.177Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.o[2019-09-10T08:05:48.177Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.o[2019-09-10T08:05:48.177Z] [ 10%] Built target KF5WidgetsAddons_QCH[2019-09-10T08:05:48.177Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselectaction.cpp.o[2019-09-10T08:05:48.177Z] 2 warnings generated.[2019-09-10T08:05:49.147Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktimecombobox.cpp.o[2019-09-10T08:05:49.147Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.o[2019-09-10T08:05:49.147Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.o[2019-09-10T08:05:49.147Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontchooser.cpp.o[2019-09-10T08:05:49.147Z] [ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kguiitem.cpp.o[2019-09-10T08:05:49.762Z] [ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kled.cpp.o[2019-09-10T08:05:51.159Z] [ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox.cpp.o[2019-09-10T08:05:51.448Z] [ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox_p.cpp.o[2019-09-10T08:05:51.719Z] [ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmultitabbar.cpp.o[2019-09-10T08:05:51.719Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kurllabel.cpp.o[2019-09-10T08:05:51.719Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kstandardguiitem.cpp.o[2019-09-10T08:05:52.369Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcapacitybar.cpp.o[2019-09-10T08:05:52.369Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontrequester.cpp.o[2019-09-10T08:05:52.641Z] [ 15%] Building CXX object s

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.13 - Build # 22 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.13/22/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Tue, 10 Sep 2019 08:03:57 +
 Build duration:
2 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 239 lines...][2019-09-10T08:05:18.644Z] [2019-09-10T08:05:18.901Z] -- Build files have been written to: /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-09-10T08:05:19.934Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kwidgetsaddons --branchGroup kf5-qt5 --platform AndroidQt5.13 --usingInstall /home/user/install-prefix/[2019-09-10T08:05:20.200Z] Scanning dependencies of target KF5WidgetsAddons_autogen[2019-09-10T08:05:20.200Z] [  0%] Automatic MOC for target KF5WidgetsAddons[2019-09-10T08:05:22.759Z] [  0%] Built target KF5WidgetsAddons_autogen[2019-09-10T08:05:22.759Z] Scanning dependencies of target kdatetabletest_autogen[2019-09-10T08:05:22.759Z] [  1%] Automatic MOC for target kdatetabletest[2019-09-10T08:05:22.759Z] [  1%] Built target kdatetabletest_autogen[2019-09-10T08:05:22.759Z] [  1%] Generating ui_kpassworddialog.h[2019-09-10T08:05:22.759Z] [  2%] Generating ui_knewpasswordwidget.h[2019-09-10T08:05:22.759Z] [  2%] Generating ui_knewpassworddialog.h[2019-09-10T08:05:22.759Z] [  2%] Generating ui_kdatetimeedit.h[2019-09-10T08:05:22.759Z] [  2%] Generating qrc_icons.cpp[2019-09-10T08:05:23.348Z] Scanning dependencies of target KF5WidgetsAddons[2019-09-10T08:05:23.348Z] [  2%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/KF5WidgetsAddons_autogen/mocs_compilation.cpp.o[2019-09-10T08:05:25.241Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorbutton.cpp.o[2019-09-10T08:05:26.179Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolumnresizer.cpp.o[2019-09-10T08:05:27.552Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.o[2019-09-10T08:05:28.931Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatepicker.cpp.o[2019-09-10T08:05:30.849Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o[2019-09-10T08:05:32.221Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetimeedit.cpp.o[2019-09-10T08:05:34.144Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.o[2019-09-10T08:05:34.720Z] /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.13/src/kfontaction.cpp:146:2: warning: #warning is a language extension [-Wpedantic][2019-09-10T08:05:34.720Z] #warning FIXME: items need to be converted[2019-09-10T08:05:34.720Z]  ^[2019-09-10T08:05:34.720Z] /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.13/src/kfontaction.cpp:146:2: warning: FIXME: items need to be converted [-W#warnings][2019-09-10T08:05:34.981Z] 2 warnings generated.[2019-09-10T08:05:34.981Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/knewpasswordwidget.cpp.o[2019-09-10T08:05:36.373Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.o[2019-09-10T08:05:36.938Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.o[2019-09-10T08:05:38.326Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.o[2019-09-10T08:05:39.711Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselectaction.cpp.o[2019-09-10T08:05:41.104Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktimecombobox.cpp.o[2019-09-10T08:05:43.018Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.o[2019-09-10T08:05:43.957Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.o[2019-09-10T08:05:44.909Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontchooser.cpp.o[2019-09-10T08:05:46.815Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kguiitem.cpp.o[2019-09-10T08:05:47.756Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kled.cpp.o[2019-09-10T08:05:48.702Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox.cpp.o[2019-09-10T08:05:50.620Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox_p.cpp.o[2019-09-10T08:05:51.566Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmultitabbar.cpp.o[2019-09-10T08:05:53.477Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kstandardguiitem.cpp.o[2019-09-10T08:05:54.417Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kurllabel.cpp.o[2019-09-10T08:05:55.792Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcapacitybar.cpp.o[2019-09-10T08:05:57.193Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontrequester.cpp.o[2019-09-10T08:05:58.1

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.13 - Build # 24 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.13/24/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 10 Sep 2019 08:03:57 +
 Build duration:
3 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 273 lines...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-09-10T08:05:29.286Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kwidgetsaddons --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2019-09-10T08:05:29.571Z] Scanning dependencies of target KF5WidgetsAddons_QCH[2019-09-10T08:05:29.572Z] [  1%] Generating src/KF5WidgetsAddons.qch, src/KF5WidgetsAddons.tags[2019-09-10T08:05:30.957Z] Building up file structure...[2019-09-10T08:05:30.957Z] Insert custom filters...[2019-09-10T08:05:30.957Z] Insert help data for filter section (1 of 1)...[2019-09-10T08:05:30.957Z] Insert files...[2019-09-10T08:05:30.957Z] Insert contents...[2019-09-10T08:05:30.957Z] Insert indices...[2019-09-10T08:05:30.957Z] Documentation successfully generated.[2019-09-10T08:05:30.957Z] [  1%] Built target KF5WidgetsAddons_QCH[2019-09-10T08:05:30.957Z] Scanning dependencies of target kdatetabletest_autogen[2019-09-10T08:05:30.957Z] [  1%] Automatic MOC for target kdatetabletest[2019-09-10T08:05:31.234Z] [  1%] Built target kdatetabletest_autogen[2019-09-10T08:05:31.234Z] Scanning dependencies of target KF5WidgetsAddons_autogen[2019-09-10T08:05:31.234Z] [  1%] Automatic MOC for target KF5WidgetsAddons[2019-09-10T08:05:35.452Z] [  1%] Built target KF5WidgetsAddons_autogen[2019-09-10T08:05:35.452Z] Scanning dependencies of target kdatetabletest[2019-09-10T08:05:35.452Z] [  2%] Building CXX object tests/CMakeFiles/kdatetabletest.dir/kdatetabletest_autogen/mocs_compilation.cpp.o[2019-09-10T08:05:35.452Z] [  2%] Building CXX object tests/CMakeFiles/kdatetabletest.dir/__/src/kdatetable.cpp.o[2019-09-10T08:05:37.356Z] [  2%] Building CXX object tests/CMakeFiles/kdatetabletest.dir/kdatetabletest.cpp.o[2019-09-10T08:05:38.744Z] [  3%] Linking CXX executable ../bin/kdatetabletest[2019-09-10T08:05:39.007Z] [  3%] Built target kdatetabletest[2019-09-10T08:05:39.007Z] [  3%] Generating ui_kpassworddialog.h[2019-09-10T08:05:39.007Z] [  4%] Generating ui_knewpasswordwidget.h[2019-09-10T08:05:39.271Z] [  4%] Generating ui_knewpassworddialog.h[2019-09-10T08:05:39.271Z] [  4%] Generating ui_kdatetimeedit.h[2019-09-10T08:05:39.271Z] [  4%] Generating qrc_icons.cpp[2019-09-10T08:05:39.539Z] Scanning dependencies of target KF5WidgetsAddons[2019-09-10T08:05:39.539Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/KF5WidgetsAddons_autogen/mocs_compilation.cpp.o[2019-09-10T08:05:42.064Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolumnresizer.cpp.o[2019-09-10T08:05:43.960Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.o[2019-09-10T08:05:45.877Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatepicker.cpp.o[2019-09-10T08:05:48.413Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o[2019-09-10T08:05:50.958Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetimeedit.cpp.o[2019-09-10T08:05:52.880Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.o[2019-09-10T08:05:52.880Z] /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.13/src/kfontaction.cpp:146:2: warning: #warning is a GCC extension[2019-09-10T08:05:52.880Z]   146 | #warning FIXME: items need to be converted[2019-09-10T08:05:52.880Z]   |  ^~~[2019-09-10T08:05:52.880Z] /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.13/src/kfontaction.cpp:146:2: warning: #warning FIXME: items need to be converted [-Wcpp][2019-09-10T08:05:54.280Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/knewpasswordwidget.cpp.o[2019-09-10T08:05:56.216Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.o[2019-09-10T08:05:57.177Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.o[2019-09-10T08:05:59.085Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.o[2019-09-10T08:06:00.460Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselectaction.cpp.o[2019-09-10T08:06:03.023Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktimecombobox.cpp.o[2019-09-10T08:06:04.918Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.o[2019-09-10T08:06:06.294Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.o[2019-09-10T08:06:07.671Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontchooser.cpp.o[2019-09-10T08:06:10.222Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kguiitem.cpp.o[2019-09-10T08:06:11.617Z

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 62 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/62/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 10 Sep 2019 08:03:57 +
 Build duration:
4 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 274 lines...][Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-09-10T08:06:15.735Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kwidgetsaddons --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-09-10T08:06:15.735Z] Scanning dependencies of target KF5WidgetsAddons_QCH[2019-09-10T08:06:15.735Z] [  1%] Generating src/KF5WidgetsAddons.qch, src/KF5WidgetsAddons.tags[2019-09-10T08:06:18.129Z] Building up file structure...[2019-09-10T08:06:18.129Z] Insert custom filters...[2019-09-10T08:06:18.129Z] Insert help data for filter section (1 of 1)...[2019-09-10T08:06:18.129Z] Insert files...[2019-09-10T08:06:18.129Z] Insert contents...[2019-09-10T08:06:18.129Z] Insert indices...[2019-09-10T08:06:18.129Z] Documentation successfully generated.[2019-09-10T08:06:18.129Z] [  1%] Built target KF5WidgetsAddons_QCH[2019-09-10T08:06:18.129Z] Scanning dependencies of target KF5WidgetsAddons_autogen[2019-09-10T08:06:18.129Z] [  1%] Automatic MOC for target KF5WidgetsAddons[2019-09-10T08:06:31.153Z] [  1%] Built target KF5WidgetsAddons_autogen[2019-09-10T08:06:31.153Z] Scanning dependencies of target kdatetabletest_autogen[2019-09-10T08:06:31.153Z] [  1%] Automatic MOC for target kdatetabletest[2019-09-10T08:06:31.153Z] [  1%] Built target kdatetabletest_autogen[2019-09-10T08:06:31.153Z] [  1%] Generating ui_kpassworddialog.h[2019-09-10T08:06:31.153Z] [  1%] Generating qrc_icons.cpp[2019-09-10T08:06:31.153Z] [  1%] Generating ui_kdatetimeedit.h[2019-09-10T08:06:31.153Z] [  1%] Generating ui_knewpassworddialog.h[2019-09-10T08:06:31.153Z] [  2%] Generating ui_knewpasswordwidget.h[2019-09-10T08:06:31.153Z] Scanning dependencies of target KF5WidgetsAddons[2019-09-10T08:06:31.153Z] [  2%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/KF5WidgetsAddons_autogen/mocs_compilation.cpp.o[2019-09-10T08:06:33.546Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kacceleratormanager.cpp.o[2019-09-10T08:06:36.981Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kanimatedbutton.cpp.o[2019-09-10T08:06:38.682Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kbusyindicatorwidget.cpp.o[2019-09-10T08:06:40.382Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselect.cpp.o[2019-09-10T08:06:45.437Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselectdata.cpp.o[2019-09-10T08:06:48.609Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcollapsiblegroupbox.cpp.o[2019-09-10T08:06:50.997Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorbutton.cpp.o[2019-09-10T08:06:53.386Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolumnresizer.cpp.o[2019-09-10T08:06:55.775Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.o[2019-09-10T08:06:58.166Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatepicker.cpp.o[2019-09-10T08:07:01.354Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o[2019-09-10T08:07:03.746Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetimeedit.cpp.o[2019-09-10T08:07:06.921Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.o[2019-09-10T08:07:06.921Z] /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.12/src/kfontaction.cpp:146:2: warning: #warning is a GCC extension[2019-09-10T08:07:06.921Z]   146 | #warning FIXME: items need to be converted[2019-09-10T08:07:06.921Z]   |  ^~~[2019-09-10T08:07:06.921Z] /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.12/src/kfontaction.cpp:146:2: warning: #warning FIXME: items need to be converted [-Wcpp][2019-09-10T08:07:08.620Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/knewpasswordwidget.cpp.o[2019-09-10T08:07:10.313Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.o[2019-09-10T08:07:12.283Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.o[2019-09-10T08:07:14.666Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.o[2019-09-10T08:07:16.357Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselectaction.cpp.o[2019-09-10T08:07:18.738Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktimecombobox.cpp.o[2019-09-10T08:07:21.903Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.o[2019-09-10T08:07:23.603Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.o[2019-09-10T08:07:24.676Z] [  9%] Buildin

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 9 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20WindowsMSVCQt5.13/9/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 10 Sep 2019 08:03:56 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 336 lines...][2019-09-10T08:14:03.715Z] kfontsizeaction.cpp[2019-09-10T08:14:03.715Z] kcharselectdata.cpp[2019-09-10T08:14:03.715Z] kpopupframe.cpp[2019-09-10T08:14:03.715Z] kdatecombobox.cpp[2019-09-10T08:14:03.715Z] kdatepicker.cpp[2019-09-10T08:14:03.715Z] kdatetable.cpp[2019-09-10T08:14:03.715Z] kfontaction.cpp[2019-09-10T08:14:03.715Z] kselectaction.cpp[2019-09-10T08:14:03.715Z] ktimecombobox.cpp[2019-09-10T08:14:03.978Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.obj[2019-09-10T08:14:04.273Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.obj[2019-09-10T08:14:04.273Z] kdualaction.cpp[2019-09-10T08:14:04.273Z] kdragwidgetdecorator.cpp[2019-09-10T08:14:04.582Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontchooser.cpp.obj[2019-09-10T08:14:04.849Z] kfontchooser.cpp[2019-09-10T08:14:05.462Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kguiitem.cpp.obj[2019-09-10T08:14:05.763Z] kguiitem.cpp[2019-09-10T08:14:06.090Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kled.cpp.obj[2019-09-10T08:14:06.369Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox.cpp.obj[2019-09-10T08:14:06.369Z] kled.cpp[2019-09-10T08:14:06.628Z] kmessagebox.cpp[2019-09-10T08:14:06.628Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox_p.cpp.obj[2019-09-10T08:14:07.229Z] [ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmultitabbar.cpp.obj[2019-09-10T08:14:07.229Z] kmessagebox_p.cpp[2019-09-10T08:14:07.507Z] kmultitabbar.cpp[2019-09-10T08:14:07.767Z] [ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kstandardguiitem.cpp.obj[2019-09-10T08:14:08.429Z] kstandardguiitem.cpp[2019-09-10T08:14:09.397Z] [ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kurllabel.cpp.obj[2019-09-10T08:14:09.397Z] [ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcapacitybar.cpp.obj[2019-09-10T08:14:09.683Z] kurllabel.cpp[2019-09-10T08:14:09.683Z] kcapacitybar.cpp[2019-09-10T08:14:10.018Z] [ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontrequester.cpp.obj[2019-09-10T08:14:10.307Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kruler.cpp.obj[2019-09-10T08:14:10.590Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselector.cpp.obj[2019-09-10T08:14:10.590Z] kfontrequester.cpp[2019-09-10T08:14:10.850Z] kruler.cpp[2019-09-10T08:14:10.850Z] kselector.cpp[2019-09-10T08:14:11.113Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kxyselector.cpp.obj[2019-09-10T08:14:11.375Z] kxyselector.cpp[2019-09-10T08:14:11.638Z] [ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kseparator.cpp.obj[2019-09-10T08:14:11.907Z] [ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ksqueezedtextlabel.cpp.obj[2019-09-10T08:14:11.907Z] kseparator.cpp[2019-09-10T08:14:12.193Z] ksqueezedtextlabel.cpp[2019-09-10T08:14:12.193Z] [ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktitlewidget.cpp.obj[2019-09-10T08:14:12.193Z] [ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoggleaction.cpp.obj[2019-09-10T08:14:12.510Z] ktitlewidget.cpp[2019-09-10T08:14:12.510Z] ktoggleaction.cpp[2019-09-10T08:14:13.115Z] [ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktogglefullscreenaction.cpp.obj[2019-09-10T08:14:13.379Z] ktogglefullscreenaction.cpp[2019-09-10T08:14:13.650Z] [ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstateserializer.cpp.obj[2019-09-10T08:14:13.932Z] kviewstateserializer.cpp[2019-09-10T08:14:13.932Z] [ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstatemaintainerbase.cpp.obj[2019-09-10T08:14:14.553Z] kviewstatemaintainerbase.cpp[2019-09-10T08:14:14.811Z] [ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/keditlistwidget.cpp.obj[2019-09-10T08:14:15.509Z] keditlistwidget.cpp[2019-09-10T08:14:15.509Z] [ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcursor.cpp.obj[2019-09-10T08:14:15.803Z] kcursor.cpp[2019-09-10T08:14:16.077Z] [ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingwidget.cpp.obj[2019-09-10T08:14:16.340Z] kratingwidget.cpp[2019-09-10T08:14:16.650Z] [ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingpainter.cpp.obj[2019-09-10T08:14:16.650Z] [ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kactionselector.cpp.obj[2019-09-10T08:14:16.953Z] kratingpainter.cpp[2019-09-10T08:14:16.953Z] [ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorcombo.cpp.obj[2019-09-10T08:14:16.953Z] kcolorc

D23810: Port away from Qt's foreach all loops over rvalue container objects

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R263 KXmlGui

BRANCH
  portmoreforeachforlocalcontainerobjects

REVISION DETAIL
  https://phabricator.kde.org/D23810

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23815: [KConfig] port away from deprecated methods in Qt 5.14

[Laurent Montel]

mlaurent added a comment.


  Why you don't add add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) in 
cmake toplevel ?
  or 5.14 value ? so we can be sure that it builds without deprecated method 
until it.
  
  (I prefere QT_DISABLE_DEPRECATED_BEFORE=0x06 so we can fix it each time 
that we increase qt and not just waiting that we port to qt6) :)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23815

To: dfaure, mdawson, arichardson
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23819: [KConfigWidgets] port away from deprecated API in Qt 5.14

[David Faure]

dfaure created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23819

AFFECTED FILES
  src/kconfigdialog.cpp
  src/krecentfilesaction.cpp
  src/ktipdialog.cpp

To: dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11542: Remove KHTML

[Volker Krause]

vkrause triaged this task as "Normal" priority.

TASK DETAIL
  https://phabricator.kde.org/T11542

To: vkrause
Cc: ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, 
knauss, GB_2, niccolove, kpiwowarski, vkrause, cordlandwehr, dfaure

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.13 - Build # 23 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.13/23/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Tue, 10 Sep 2019 08:39:02 +
 Build duration:
1 min 57 sec and counting
   CONSOLE OUTPUT
  [...truncated 251 lines...][2019-09-10T08:39:59.034Z] [  0%] Built target KF5WidgetsAddons_autogen[2019-09-10T08:39:59.034Z] Scanning dependencies of target kdatetabletest_autogen[2019-09-10T08:39:59.034Z] [  1%] Automatic MOC for target kdatetabletest[2019-09-10T08:39:59.313Z] [  1%] Built target kdatetabletest_autogen[2019-09-10T08:39:59.313Z] [  1%] Generating ui_kpassworddialog.h[2019-09-10T08:39:59.313Z] [  2%] Generating ui_knewpasswordwidget.h[2019-09-10T08:39:59.313Z] [  2%] Generating ui_knewpassworddialog.h[2019-09-10T08:39:59.313Z] [  2%] Generating ui_kdatetimeedit.h[2019-09-10T08:39:59.575Z] [  2%] Generating qrc_icons.cpp[2019-09-10T08:39:59.835Z] Scanning dependencies of target KF5WidgetsAddons[2019-09-10T08:40:00.096Z] [  2%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/KF5WidgetsAddons_autogen/mocs_compilation.cpp.o[2019-09-10T08:40:01.996Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorbutton.cpp.o[2019-09-10T08:40:03.381Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolumnresizer.cpp.o[2019-09-10T08:40:04.767Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.o[2019-09-10T08:40:06.145Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatepicker.cpp.o[2019-09-10T08:40:07.524Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o[2019-09-10T08:40:09.429Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetimeedit.cpp.o[2019-09-10T08:40:10.808Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.o[2019-09-10T08:40:11.738Z] /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.13/src/kfontaction.cpp:146:2: warning: #warning is a language extension [-Wpedantic][2019-09-10T08:40:11.738Z] #warning FIXME: items need to be converted[2019-09-10T08:40:11.738Z]  ^[2019-09-10T08:40:11.738Z] /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.13/src/kfontaction.cpp:146:2: warning: FIXME: items need to be converted [-W#warnings][2019-09-10T08:40:11.997Z] 2 warnings generated.[2019-09-10T08:40:11.997Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/knewpasswordwidget.cpp.o[2019-09-10T08:40:13.376Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.o[2019-09-10T08:40:14.306Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.o[2019-09-10T08:40:15.685Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.o[2019-09-10T08:40:17.073Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselectaction.cpp.o[2019-09-10T08:40:18.451Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktimecombobox.cpp.o[2019-09-10T08:40:20.358Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.o[2019-09-10T08:40:21.331Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.o[2019-09-10T08:40:22.739Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontchooser.cpp.o[2019-09-10T08:40:24.126Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kguiitem.cpp.o[2019-09-10T08:40:25.513Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kled.cpp.o[2019-09-10T08:40:26.445Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox.cpp.o[2019-09-10T08:40:28.362Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox_p.cpp.o[2019-09-10T08:40:29.305Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmultitabbar.cpp.o[2019-09-10T08:40:31.210Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kstandardguiitem.cpp.o[2019-09-10T08:40:32.149Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kurllabel.cpp.o[2019-09-10T08:40:33.535Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcapacitybar.cpp.o[2019-09-10T08:40:34.922Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontrequester.cpp.o[2019-09-10T08:40:35.873Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpassworddialog.cpp.o[2019-09-10T08:40:37.254Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kruler.cpp.o[2019-09-10T08:40:38.192Z] /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.13/src/kruler.cpp:158:2: warning: #warning is a language extension [-Wpedantic][2019-09-10T08:40:38.192Z] #warning FIXME setFrameStyle(WinPanel | Raised);[2019-09-10T08:40:38.192Z]  ^[2019-09-10T08:40:38.192Z] /home/user/workspace/Frameworks/kwidgetsaddons/kf5-qt5 AndroidQt5.13/src/kruler.cpp:158:2: warning: FIXME setFrameStyle(Win

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 10 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20WindowsMSVCQt5.13/10/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 10 Sep 2019 08:39:02 +
 Build duration:
1 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 333 lines...][2019-09-10T08:40:44.257Z] kfontsizeaction.cpp[2019-09-10T08:40:44.257Z] fonthelpers.cpp[2019-09-10T08:40:44.257Z] kcharselect.cpp[2019-09-10T08:40:44.257Z] kpopupframe.cpp[2019-09-10T08:40:44.257Z] kdatecombobox.cpp[2019-09-10T08:40:44.257Z] kdatepicker.cpp[2019-09-10T08:40:44.257Z] kdatetable.cpp[2019-09-10T08:40:44.257Z] kfontaction.cpp[2019-09-10T08:40:44.257Z] kselectaction.cpp[2019-09-10T08:40:44.257Z] ktimecombobox.cpp[2019-09-10T08:40:44.540Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.obj[2019-09-10T08:40:44.540Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.obj[2019-09-10T08:40:44.540Z] kdragwidgetdecorator.cpp[2019-09-10T08:40:44.853Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontchooser.cpp.obj[2019-09-10T08:40:44.853Z] kdualaction.cpp[2019-09-10T08:40:44.853Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kguiitem.cpp.obj[2019-09-10T08:40:44.853Z] kfontchooser.cpp[2019-09-10T08:40:44.853Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kled.cpp.obj[2019-09-10T08:40:44.853Z] kguiitem.cpp[2019-09-10T08:40:45.114Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox.cpp.obj[2019-09-10T08:40:45.114Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmessagebox_p.cpp.obj[2019-09-10T08:40:45.394Z] kled.cpp[2019-09-10T08:40:45.394Z] kmessagebox.cpp[2019-09-10T08:40:45.394Z] kmessagebox_p.cpp[2019-09-10T08:40:45.660Z] [ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kmultitabbar.cpp.obj[2019-09-10T08:40:45.946Z] kmultitabbar.cpp[2019-09-10T08:40:46.206Z] [ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kstandardguiitem.cpp.obj[2019-09-10T08:40:46.794Z] kstandardguiitem.cpp[2019-09-10T08:40:46.794Z] [ 12%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kurllabel.cpp.obj[2019-09-10T08:40:47.077Z] kurllabel.cpp[2019-09-10T08:40:47.077Z] [ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcapacitybar.cpp.obj[2019-09-10T08:40:47.077Z] [ 13%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontrequester.cpp.obj[2019-09-10T08:40:47.341Z] kcapacitybar.cpp[2019-09-10T08:40:47.603Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kruler.cpp.obj[2019-09-10T08:40:47.603Z] kfontrequester.cpp[2019-09-10T08:40:47.603Z] kruler.cpp[2019-09-10T08:40:47.864Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselector.cpp.obj[2019-09-10T08:40:48.123Z] [ 14%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kxyselector.cpp.obj[2019-09-10T08:40:48.123Z] kselector.cpp[2019-09-10T08:40:48.123Z] kxyselector.cpp[2019-09-10T08:40:48.384Z] [ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kseparator.cpp.obj[2019-09-10T08:40:48.649Z] kseparator.cpp[2019-09-10T08:40:48.649Z] [ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ksqueezedtextlabel.cpp.obj[2019-09-10T08:40:48.933Z] ksqueezedtextlabel.cpp[2019-09-10T08:40:48.933Z] [ 15%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktitlewidget.cpp.obj[2019-09-10T08:40:48.933Z] [ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktoggleaction.cpp.obj[2019-09-10T08:40:48.933Z] ktitlewidget.cpp[2019-09-10T08:40:49.192Z] [ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktogglefullscreenaction.cpp.obj[2019-09-10T08:40:49.192Z] [ 16%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstateserializer.cpp.obj[2019-09-10T08:40:49.450Z] kviewstateserializer.cpp[2019-09-10T08:40:49.450Z] ktogglefullscreenaction.cpp[2019-09-10T08:40:49.450Z] ktoggleaction.cpp[2019-09-10T08:40:49.450Z] [ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kviewstatemaintainerbase.cpp.obj[2019-09-10T08:40:49.746Z] kviewstatemaintainerbase.cpp[2019-09-10T08:40:50.050Z] [ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/keditlistwidget.cpp.obj[2019-09-10T08:40:50.050Z] [ 17%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcursor.cpp.obj[2019-09-10T08:40:50.050Z] keditlistwidget.cpp[2019-09-10T08:40:50.343Z] kcursor.cpp[2019-09-10T08:40:50.637Z] [ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingwidget.cpp.obj[2019-09-10T08:40:50.937Z] kratingwidget.cpp[2019-09-10T08:40:51.222Z] [ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kratingpainter.cpp.obj[2019-09-10T08:40:51.222Z] kratingpainter.cpp[2019-09-10T08:40:51.505Z] [ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kactionselector.cpp.obj[2019-09-10T08:40:51.780Z] [ 18%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorco

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.13 - Build # 25 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.13/25/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 10 Sep 2019 08:39:02 +
 Build duration:
3 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 282 lines...][2019-09-10T08:41:37.736Z] [  0%] Automatic MOC for target kdatetabletest[2019-09-10T08:41:37.736Z] [  1%] Generating src/KF5WidgetsAddons.qch, src/KF5WidgetsAddons.tags[2019-09-10T08:41:38.810Z] [  1%] Built target kdatetabletest_autogen[2019-09-10T08:41:39.321Z] Scanning dependencies of target kdatetabletest[2019-09-10T08:41:39.321Z] [  2%] Building CXX object tests/CMakeFiles/kdatetabletest.dir/kdatetabletest_autogen/mocs_compilation.cpp.o[2019-09-10T08:41:39.321Z] [  2%] Building CXX object tests/CMakeFiles/kdatetabletest.dir/__/src/kdatetable.cpp.o[2019-09-10T08:41:39.321Z] [  2%] Building CXX object tests/CMakeFiles/kdatetabletest.dir/kdatetabletest.cpp.o[2019-09-10T08:41:42.497Z] [  2%] Built target KF5WidgetsAddons_autogen[2019-09-10T08:41:42.497Z] [  2%] Generating qrc_icons.cpp[2019-09-10T08:41:42.497Z] [  2%] Generating ui_kpassworddialog.h[2019-09-10T08:41:42.497Z] [  2%] Generating ui_kdatetimeedit.h[2019-09-10T08:41:42.497Z] [  2%] Generating ui_knewpassworddialog.h[2019-09-10T08:41:42.497Z] [  3%] Generating ui_knewpasswordwidget.h[2019-09-10T08:41:42.497Z] Building up file structure...[2019-09-10T08:41:42.497Z] Insert custom filters...[2019-09-10T08:41:42.497Z] Insert help data for filter section (1 of 1)...[2019-09-10T08:41:42.497Z] Insert files...[2019-09-10T08:41:42.497Z] Insert contents...[2019-09-10T08:41:42.497Z] Insert indices...[2019-09-10T08:41:42.497Z] Documentation successfully generated.[2019-09-10T08:41:42.497Z] [  3%] Built target KF5WidgetsAddons_QCH[2019-09-10T08:41:43.007Z] Scanning dependencies of target KF5WidgetsAddons[2019-09-10T08:41:43.007Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/KF5WidgetsAddons_autogen/mocs_compilation.cpp.o[2019-09-10T08:41:43.007Z] [  3%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kanimatedbutton.cpp.o[2019-09-10T08:41:43.007Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselect.cpp.o[2019-09-10T08:41:43.007Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kbusyindicatorwidget.cpp.o[2019-09-10T08:41:43.007Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kacceleratormanager.cpp.o[2019-09-10T08:41:43.523Z] [  6%] Linking CXX executable ../bin/kdatetabletest[2019-09-10T08:41:44.612Z] [  6%] Built target kdatetabletest[2019-09-10T08:41:44.612Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselectdata.cpp.o[2019-09-10T08:41:45.694Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcollapsiblegroupbox.cpp.o[2019-09-10T08:41:45.694Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorbutton.cpp.o[2019-09-10T08:41:47.387Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolumnresizer.cpp.o[2019-09-10T08:41:47.387Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.o[2019-09-10T08:41:49.090Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatepicker.cpp.o[2019-09-10T08:41:49.090Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o[2019-09-10T08:41:49.604Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetimeedit.cpp.o[2019-09-10T08:41:49.604Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.o[2019-09-10T08:41:49.604Z] /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.13/src/kfontaction.cpp:146:2: warning: #warning is a GCC extension[2019-09-10T08:41:49.604Z]   146 | #warning FIXME: items need to be converted[2019-09-10T08:41:49.604Z]   |  ^~~[2019-09-10T08:41:49.604Z] /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.13/src/kfontaction.cpp:146:2: warning: #warning FIXME: items need to be converted [-Wcpp][2019-09-10T08:41:50.680Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/knewpasswordwidget.cpp.o[2019-09-10T08:41:51.759Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.o[2019-09-10T08:41:52.838Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.o[2019-09-10T08:41:53.350Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.o[2019-09-10T08:41:53.350Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselectaction.cpp.o[2019-09-10T08:41:54.428Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktimecombobox.cpp.o[2019-09-10T08:41:54.428Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.o[2019-09-10T08:41:54.428Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdualaction.cpp.o[2019-09-10T08:41:56.861Z] [ 11%] Building CXX object

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 63 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/63/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 10 Sep 2019 08:39:02 +
 Build duration:
4 min 52 sec and counting
   CONSOLE OUTPUT
  [...truncated 280 lines...][2019-09-10T08:41:34.868Z] [  1%] Generating src/KF5WidgetsAddons.qch, src/KF5WidgetsAddons.tags[2019-09-10T08:41:34.868Z] [  1%] Automatic MOC for target KF5WidgetsAddons[2019-09-10T08:41:38.917Z] Building up file structure...[2019-09-10T08:41:38.917Z] Insert custom filters...[2019-09-10T08:41:38.917Z] Insert help data for filter section (1 of 1)...[2019-09-10T08:41:38.917Z] Insert files...[2019-09-10T08:41:38.917Z] Insert contents...[2019-09-10T08:41:38.917Z] Insert indices...[2019-09-10T08:41:38.917Z] Documentation successfully generated.[2019-09-10T08:41:39.428Z] [  1%] Built target KF5WidgetsAddons_QCH[2019-09-10T08:41:39.428Z] Scanning dependencies of target kdatetabletest_autogen[2019-09-10T08:41:39.428Z] [  1%] Automatic MOC for target kdatetabletest[2019-09-10T08:41:39.939Z] [  1%] Built target kdatetabletest_autogen[2019-09-10T08:41:39.939Z] Scanning dependencies of target kdatetabletest[2019-09-10T08:41:39.939Z] [  2%] Building CXX object tests/CMakeFiles/kdatetabletest.dir/kdatetabletest_autogen/mocs_compilation.cpp.o[2019-09-10T08:41:40.450Z] [  2%] Building CXX object tests/CMakeFiles/kdatetabletest.dir/kdatetabletest.cpp.o[2019-09-10T08:41:45.900Z] [  2%] Building CXX object tests/CMakeFiles/kdatetabletest.dir/__/src/kdatetable.cpp.o[2019-09-10T08:41:53.524Z] [  2%] Built target KF5WidgetsAddons_autogen[2019-09-10T08:41:53.524Z] [  3%] Linking CXX executable ../bin/kdatetabletest[2019-09-10T08:41:54.038Z] [  3%] Built target kdatetabletest[2019-09-10T08:41:54.038Z] [  3%] Generating ui_kpassworddialog.h[2019-09-10T08:41:54.038Z] [  3%] Generating qrc_icons.cpp[2019-09-10T08:41:54.038Z] [  3%] Generating ui_kdatetimeedit.h[2019-09-10T08:41:54.038Z] [  3%] Generating ui_knewpassworddialog.h[2019-09-10T08:41:54.038Z] [  4%] Generating ui_knewpasswordwidget.h[2019-09-10T08:41:54.548Z] Scanning dependencies of target KF5WidgetsAddons[2019-09-10T08:41:54.548Z] [  4%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/KF5WidgetsAddons_autogen/mocs_compilation.cpp.o[2019-09-10T08:41:57.736Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kacceleratormanager.cpp.o[2019-09-10T08:42:01.795Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kanimatedbutton.cpp.o[2019-09-10T08:42:03.492Z] [  5%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kbusyindicatorwidget.cpp.o[2019-09-10T08:42:05.201Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselect.cpp.o[2019-09-10T08:42:10.277Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcharselectdata.cpp.o[2019-09-10T08:42:13.445Z] [  6%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcollapsiblegroupbox.cpp.o[2019-09-10T08:42:15.832Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolorbutton.cpp.o[2019-09-10T08:42:18.225Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kcolumnresizer.cpp.o[2019-09-10T08:42:20.614Z] [  7%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatecombobox.cpp.o[2019-09-10T08:42:24.035Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatepicker.cpp.o[2019-09-10T08:42:26.421Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetable.cpp.o[2019-09-10T08:42:29.581Z] [  8%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdatetimeedit.cpp.o[2019-09-10T08:42:31.961Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontaction.cpp.o[2019-09-10T08:42:32.471Z] /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.12/src/kfontaction.cpp:146:2: warning: #warning is a GCC extension[2019-09-10T08:42:32.471Z]   146 | #warning FIXME: items need to be converted[2019-09-10T08:42:32.471Z]   |  ^~~[2019-09-10T08:42:32.471Z] /home/jenkins/workspace/Frameworks/kwidgetsaddons/kf5-qt5 SUSEQt5.12/src/kfontaction.cpp:146:2: warning: #warning FIXME: items need to be converted [-Wcpp][2019-09-10T08:42:34.160Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/knewpasswordwidget.cpp.o[2019-09-10T08:42:36.552Z] [  9%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/fonthelpers.cpp.o[2019-09-10T08:42:38.246Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kfontsizeaction.cpp.o[2019-09-10T08:42:40.632Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kpopupframe.cpp.o[2019-09-10T08:42:42.325Z] [ 10%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kselectaction.cpp.o[2019-09-10T08:42:45.500Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/ktimecombobox.cpp.o[2019-09-10T08:42:47.890Z] [ 11%] Building CXX object src/CMakeFiles/KF5WidgetsAddons.dir/kdragwidgetdecorator.cpp.o[201

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.13 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.13/24/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Tue, 10 Sep 2019 08:45:27 +
 Build duration:
1 min 35 sec and counting

T11542: Remove KHTML

[Andreas Cord-Landwehr]

cordlandwehr added a comment.


  Added all KDE Edu application specific KHTML removal tasks.

TASK DETAIL
  https://phabricator.kde.org/T11542

To: cordlandwehr
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, 
#frameworks, knauss, GB_2, niccolove, kpiwowarski, vkrause, dfaure

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 64 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/64/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 10 Sep 2019 08:45:27 +
 Build duration:
6 min 58 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WidgetsAddons-5.62.0.xmlcompat_reports/KF5WidgetsAddons_compat_report.htmllogs/KF5WidgetsAddons/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)44%
(74/169)44%
(74/169)35%
(5256/15222)25%
(1881/7443)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(20/20)100%
(20/20)99%
(1675/1684)49%
(787/1592)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src47%
(54/114)47%
(54/114)29%
(3581/12398)19%
(1094/5692)tests0%
(0/34)0%
(0/34)0%
(0/1123)0%
(0/157)

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 11 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20WindowsMSVCQt5.13/11/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 10 Sep 2019 08:45:27 +
 Build duration:
7 min 36 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kcolorbuttontestFailed: projectroot.autotests.kpasswordlineedittestFailed: projectroot.autotests.ksplittercollapserbuttontest

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.13/24/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Sep 2019 08:39:02 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.13 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.13/26/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 10 Sep 2019 08:45:27 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5WidgetsAddons-5.62.0.xmlcompat_reports/KF5WidgetsAddons_compat_report.htmllogs/KF5WidgetsAddons/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)44%
(74/169)44%
(74/169)35%
(5285/15226)26%
(1900/7447)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(20/20)100%
(20/20)99%
(1678/1687)49%
(789/1596)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src47%
(54/114)47%
(54/114)29%
(3607/12399)20%
(/5692)tests0%
(0/34)0%
(0/34)0%
(0/1123)0%
(0/157)

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

[Christoph Cullmann]

cullmann added a comment.


  Hmm, is lastLineLenght correct? Must one not decrement by one?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23674

To: kossebau, #kate
Cc: cullmann, apol, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23815: [KConfig] port away from deprecated methods in Qt 5.14

[Antonio Rojas]

arojas added a comment.


  In D23815#528369 , @mlaurent wrote:
  
  > Why you don't add add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) 
in cmake toplevel ?
  >  or 5.14 value ? so we can be sure that it builds without deprecated method 
until it.
  >
  > (I prefere QT_DISABLE_DEPRECATED_BEFORE=0x06 so we can fix it each time 
that we increase qt and not just waiting that we port to qt6) :)
  
  
  Please don't. This should never, ever, be in released code (it's the same 
kind of evil as -Werror). You're artificially imposing an expiration date on 
the code, and effectively reverting Qt5 binary compatibility commitment. You 
don't know which Qt version the distributions shipping your application will be 
using, it may be newer than the one available at release time. 
-DQT_DISABLE_DEPRECATED_BEFORE should not be set to anything higher than the 
latest release, Qt is known to change their API even at the RC stage.
  
  This kind of thing should only be added to the developer's personal build 
flags, or to CI.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23815

To: dfaure, mdawson, arichardson
Cc: arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23824: Initial start of variables dialog

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  This patch adds one public function to KTextEditor::Editor:
  
void addVariableExpansion(const QVector& widgets,
  const QStringList& variables = QStringList()) 
const;
  
  Once called for QLineEdits (QTextEdit support still pending),
  QLineEdits will get an action that opens an variable expansion
  dialog that allows the user to insert variables from a list
  view.
  
  What is still missing:
  
  - add support for QTextEdits
  - use for backup prefix/suffix (bug 403583)
  - use in External Tools plugin (bug 299248)

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  add-variables-dialog

REVISION DETAIL
  https://phabricator.kde.org/D23824

AFFECTED FILES
  src/CMakeLists.txt
  src/include/ktexteditor/editor.h
  src/utils/kateglobal.cpp
  src/utils/kateglobal.h
  src/utils/katemacroexpander.cpp
  src/utils/katemacroexpander.h
  src/utils/katevariableexpansionhelpers.h
  src/utils/katevariableexpansionmanager.cpp
  src/utils/katevariableexpansionmanager.h
  src/utils/ktexteditor.cpp
  src/utils/variable.cpp
  src/utils/variable.h

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23825: Split KSslErrorUiData from KTcpSocket

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  The former we want to keep, the latter we want to deprecate, so this is
  a necessary first step to detangle them.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23825

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/ksslcertificatemanager.cpp
  src/core/ksslerroruidata.cpp
  src/core/ksslerroruidata.h
  src/core/ksslerroruidata_p.h
  src/core/ktcpsocket.cpp
  src/core/ktcpsocket.h
  src/core/ktcpsocket_p.h
  src/widgets/sslui.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23824: Initial start of variables dialog

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  :P ok

REPOSITORY
  R39 KTextEditor

BRANCH
  add-variables-dialog

REVISION DETAIL
  https://phabricator.kde.org/D23824

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23824: Initial start of variables dialog

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6b8b652979a2: Initial start of variables dialog (authored 
by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23824?vs=65730&id=65732

REVISION DETAIL
  https://phabricator.kde.org/D23824

AFFECTED FILES
  src/CMakeLists.txt
  src/include/ktexteditor/editor.h
  src/utils/kateglobal.cpp
  src/utils/kateglobal.h
  src/utils/katemacroexpander.cpp
  src/utils/katemacroexpander.h
  src/utils/katevariableexpansionhelpers.h
  src/utils/katevariableexpansionmanager.cpp
  src/utils/katevariableexpansionmanager.h
  src/utils/ktexteditor.cpp
  src/utils/variable.cpp
  src/utils/variable.h

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 76 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/76/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 10 Sep 2019 10:05:53 +
 Build duration:
59 sec and counting
   CONSOLE OUTPUT
  [...truncated 250 lines...][2019-09-10T10:06:49.397Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-09-10T10:06:49.397Z] -- Detecting C compiler ABI info[2019-09-10T10:06:49.397Z] -- Detecting C compiler ABI info - done[2019-09-10T10:06:49.397Z] -- Detecting C compile features[2019-09-10T10:06:49.658Z] -- Detecting C compile features - done[2019-09-10T10:06:49.658Z] -- Check for working CXX compiler: /usr/bin/c++[2019-09-10T10:06:49.658Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-09-10T10:06:49.658Z] -- Detecting CXX compiler ABI info[2019-09-10T10:06:49.913Z] -- Detecting CXX compiler ABI info - done[2019-09-10T10:06:49.913Z] -- Detecting CXX compile features[2019-09-10T10:06:50.474Z] -- Detecting CXX compile features - done[2019-09-10T10:06:50.474Z] -- [2019-09-10T10:06:50.474Z] [2019-09-10T10:06:50.474Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 SUSEQt5.13/build/prefix.sh to set the environment for KTextEditor.[2019-09-10T10:06:50.474Z] -- Looking for __GLIBC__[2019-09-10T10:06:50.474Z] -- Looking for __GLIBC__ - found[2019-09-10T10:06:50.474Z] -- Performing Test _OFFT_IS_64BIT[2019-09-10T10:06:50.474Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-09-10T10:06:50.474Z] -- Performing Test HAVE_DATE_TIME[2019-09-10T10:06:50.730Z] -- Performing Test HAVE_DATE_TIME - Success[2019-09-10T10:06:50.730Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2019-09-10T10:06:50.730Z] -- Found PkgConfig: /usr/bin/pkg-config (found version "1.6.1") [2019-09-10T10:06:50.730Z] -- Could NOT find LibGit2 (missing: LIBGIT2_LIBRARY LIBGIT2_INCLUDE_DIR) (Required is at least version "0.22.0")[2019-09-10T10:06:50.984Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-09-10T10:06:50.984Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-09-10T10:06:50.984Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-09-10T10:06:50.984Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-09-10T10:06:50.984Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-09-10T10:06:51.240Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-09-10T10:06:51.240Z] -- Found Doxygen: /usr/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot [2019-09-10T10:06:51.240Z] -- Found QHelpGenerator executable: /usr/lib64/qt5/bin/qhelpgenerator[2019-09-10T10:06:51.240Z] -- No such target Qt5Widgets_QCH defined when calling ecm_add_qch(), ignored.[2019-09-10T10:06:51.240Z] -- No such target Qt5Network_QCH defined when calling ecm_add_qch(), ignored.[2019-09-10T10:06:51.240Z] -- No such target Qt5Xml_QCH defined when calling ecm_add_qch(), ignored.[2019-09-10T10:06:51.240Z] -- No such target Qt5DBus_QCH defined when calling ecm_add_qch(), ignored.[2019-09-10T10:06:51.240Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2019-09-10T10:06:51.240Z] -- No such target Qt5Gui_QCH defined when calling ecm_add_qch(), ignored.[2019-09-10T10:06:51.240Z] -- Looking for fdatasync[2019-09-10T10:06:51.240Z] -- Looking for fdatasync - found[2019-09-10T10:06:51.240Z] -- The following features have been enabled:[2019-09-10T10:06:51.240Z] [2019-09-10T10:06:51.240Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-09-10T10:06:51.240Z] [2019-09-10T10:06:51.240Z] -- The following OPTIONAL packages have been found:[2019-09-10T10:06:51.240Z] [2019-09-10T10:06:51.240Z]  * PkgConfig[2019-09-10T10:06:51.240Z] [2019-09-10T10:06:51.240Z] -- The following REQUIRED packages have been found:[2019-09-10T10:06:51.240Z] [2019-09-10T10:06:51.240Z]  * ECM (required version >= 5.62.0), Extra CMake Modules., [2019-09-10T10:06:51.240Z]  * Qt5Gui (required version >= 5.13.0)[2019-09-10T10:06:51.240Z]  * Qt5Widgets[2019-09-10T10:06:51.240Z]  * Qt5Network (required version >= 5.13.0)[2019-09-10T10:06:51.240Z]  * Qt5Qml[2019-09-10T10:06:51.240Z]  * Qt5PrintSupport[2019-09-10T10:06:51.240Z]  * Qt5Xml[2019-09-10T10:06:51.240Z]  * KF5Archive (required version >= 5.62.0)[2019-09-10T10:06:51.240Z]  * KF5Config (required version >= 5.62.0)[2019-09-10T10:06:51.240Z]  * KF5GuiAddons (required version >= 5.62.0)[2019-09-10T10:06:51.240Z]  * Gettext[2019-09-10T10:06:51.240Z]  * KF5I18n (required version >= 5.62.0)[2019-09-10T10:06:51.240Z]  * KF5KIO (required version >= 5.62.0)[2019-09-10T10:06:51.240Z]  * KF5Parts (required version >= 5.62.0)[2019-09-10T10:06:51.240Z]  * KF5Sonnet (required version >= 5.62.0)[2019-09-10T10:06:51.240Z]  * KF5IconThemes (required version >= 5.62.0)[2019-09-10T10:06:51.240Z]  * KF5SyntaxHighlighting (required ve

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/74/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Sep 2019 10:05:53 +
 Build duration:
50 sec and counting
   CONSOLE OUTPUT
  [...truncated 938 lines...][2019-09-10T10:06:41.653Z] >>> referenced by mocs_compilation.cpp[2019-09-10T10:06:41.653Z] >>>   CMakeFiles/completion_test.dir/completion_test_autogen/mocs_compilation.cpp.o:(vtable for AbbreviationCodeCompletionTestModel)[2019-09-10T10:06:41.653Z] [2019-09-10T10:06:41.653Z] /usr/bin/ld: error: too many errors emitted, stopping now (use -error-limit=0 to see all errors)[2019-09-10T10:06:41.653Z] c++: error: linker command failed with exit code 1 (use -v to see invocation)[2019-09-10T10:06:41.653Z] gmake[2]: *** [autotests/CMakeFiles/completion_test.dir/build.make:129: bin/completion_test] Error 1[2019-09-10T10:06:41.653Z] gmake[1]: *** [CMakeFiles/Makefile2:2219: autotests/CMakeFiles/completion_test.dir/all] Error 2[2019-09-10T10:06:41.653Z] /usr/bin/ld: error: undefined symbol: KateScriptView::qt_metacast(char const*)[2019-09-10T10:06:41.653Z] >>> referenced by moc_testutils.cpp:510 (/usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.13/build/autotests/commands_test_autogen/UVLADIE3JM/moc_testutils.cpp:510)[2019-09-10T10:06:41.653Z] >>>   CMakeFiles/commands_test.dir/commands_test_autogen/mocs_compilation.cpp.o:(KateViewObject::qt_metacast(char const*))[2019-09-10T10:06:41.653Z] [2019-09-10T10:06:41.653Z] /usr/bin/ld: error: undefined symbol: KateScriptView::qt_metacall(QMetaObject::Call, int, void**)[2019-09-10T10:06:41.653Z] >>> referenced by moc_testutils.cpp:515 (/usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.13/build/autotests/commands_test_autogen/UVLADIE3JM/moc_testutils.cpp:515)[2019-09-10T10:06:41.653Z] >>>   CMakeFiles/commands_test.dir/commands_test_autogen/mocs_compilation.cpp.o:(KateViewObject::qt_metacall(QMetaObject::Call, int, void**))[2019-09-10T10:06:41.653Z] [2019-09-10T10:06:41.653Z] /usr/bin/ld: error: undefined symbol: KateScriptDocument::qt_metacast(char const*)[2019-09-10T10:06:41.653Z] >>> referenced by moc_testutils.cpp:591 (/usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.13/build/autotests/commands_test_autogen/UVLADIE3JM/moc_testutils.cpp:591)[2019-09-10T10:06:41.653Z] >>>   CMakeFiles/commands_test.dir/commands_test_autogen/mocs_compilation.cpp.o:(KateDocumentObject::qt_metacast(char const*))[2019-09-10T10:06:41.653Z] [2019-09-10T10:06:41.653Z] /usr/bin/ld: error: undefined symbol: KateScriptDocument::qt_metacall(QMetaObject::Call, int, void**)[2019-09-10T10:06:41.653Z] >>> referenced by moc_testutils.cpp:596 (/usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.13/build/autotests/commands_test_autogen/UVLADIE3JM/moc_testutils.cpp:596)[2019-09-10T10:06:41.653Z] >>>   CMakeFiles/commands_test.dir/commands_test_autogen/mocs_compilation.cpp.o:(KateDocumentObject::qt_metacall(QMetaObject::Call, int, void**))[2019-09-10T10:06:41.653Z] [2019-09-10T10:06:41.653Z] /usr/bin/ld: error: undefined symbol: KateScriptView::staticMetaObject[2019-09-10T10:06:41.653Z] >>> referenced by mocs_compilation.cpp[2019-09-10T10:06:41.653Z] >>>   CMakeFiles/commands_test.dir/commands_test_autogen/mocs_compilation.cpp.o:(KateViewObject::staticMetaObject)[2019-09-10T10:06:41.653Z] [2019-09-10T10:06:41.653Z] /usr/bin/ld: error: undefined symbol: KateScriptDocument::staticMetaObject[2019-09-10T10:06:41.653Z] >>> referenced by mocs_compilation.cpp[2019-09-10T10:06:41.653Z] >>>   CMakeFiles/commands_test.dir/commands_test_autogen/mocs_compilation.cpp.o:(KateDocumentObject::staticMetaObject)[2019-09-10T10:06:41.653Z] [2019-09-10T10:06:41.653Z] /usr/bin/ld: error: undefined symbol: typeinfo for KateScriptView[2019-09-10T10:06:41.653Z] >>> referenced by mocs_compilation.cpp[2019-09-10T10:06:41.653Z] >>>   CMakeFiles/commands_test.dir/commands_test_autogen/mocs_compilation.cpp.o:(typeinfo for KateViewObject)[2019-09-10T10:06:41.653Z] [2019-09-10T10:06:41.653Z] /usr/bin/ld: error: undefined symbol: typeinfo for KateScriptDocument[2019-09-10T10:06:41.653Z] >>> referenced by mocs_compilation.cpp[2019-09-10T10:06:41.653Z] >>>   CMakeFiles/commands_test.dir/commands_test_autogen/mocs_compilation.cpp.o:(typeinfo for KateDocumentObject)[2019-09-10T10:06:41.653Z] [2019-09-10T10:06:41.653Z] /usr/bin/ld: error: undefined symbol: KTextEditor::EditorPrivate::enableUnitTestMode()[2019-09-10T10:06:41.653Z] >>> referenced by script_test_base.cpp:60 (/usr/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 FreeBSDQt5.13/autotests/src/script_test_base.cpp:60)[2019-09-10T10:06:41.654Z] >>>   CMakeFiles/commands_test.dir/src/script_test_base.cpp.o:(ScriptTestBase::initTestCase())[2019-09-10T10:06:41.654Z] [2019-09-10T10:0

D23824: Initial start of variables dialog

[Christoph Cullmann]

cullmann added a comment.


  Upsa, file missing :P

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23824

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23815: [KConfig] port away from deprecated methods in Qt 5.14

[Laurent Montel]

mlaurent added a comment.


  "This kind of thing should only be added to the developer's personal build 
flags, or to CI."
  on CI without this flags in module is just not a good idea.
  
  After that I use in pim* and it's not a problem. If a people wants to use new 
qt (as David :) ) he will fix it and it"s good for me :)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23815

To: dfaure, mdawson, arichardson
Cc: arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Sep 2019 10:09:33 +
 Build duration:
5 min 40 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D23825: Split KSslErrorUiData from KTcpSocket

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> ksslerroruidata.h:26
> +
> +template  class QList;
> +class KTcpSocket;

Minor comment, with all the "noise" around QList in Qt6, would it be maybe more 
future proof to just #include  ehre so we don't end up declaring a class 
that doesn't exist in the future?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23825

To: vkrause, dfaure
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23825: Split KSslErrorUiData from KTcpSocket

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Other than that just commit it i'd say, you're just moving code around so no 
need to "re-review" code that we already accept as "good" for the moment imho

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23825

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23810: Port away from Qt's foreach all loops over rvalue container objects

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:0cab036a2dab: Port away from Qt's foreach all loops 
over rvalue container objects (authored by kossebau).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23810?vs=65714&id=65734

REVISION DETAIL
  https://phabricator.kde.org/D23810

AFFECTED FILES
  autotests/ktoolbar_unittest.cpp
  src/kedittoolbar.cpp
  src/kmainwindow.cpp
  src/kmenumenuhandler_p.cpp
  src/kshortcutschemeseditor.cpp
  src/kshortcutschemeshelper.cpp
  src/kshortcutseditor.cpp
  src/ktoolbar.cpp
  src/kxmlguifactory.cpp
  src/kxmlguiwindow.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 197 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/197/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 10 Sep 2019 10:26:49 +
 Build duration:
8 min 39 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.62.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.inlinenote_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(263/298)88%
(263/298)68%
(33326/49207)50%
(14935/29776)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)93%
(4745/5087)49%
(1780/3654)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5480/5521)58%
(978/1688)src.buffer88%
(15/17)88%
(15/17)90%
(1710/1902)75%
(1103/1472)src.completion100%
(11/11)100%
(11/11)57%
(1786/3135)41%
(993/2405)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/850)0%
(0/178)src.document100%
(4/4)100%
(4/4)61%
(1940/3185)48%
(1432/2989)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(305/840)19%
(126/677)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/861)0%
(0/278)src.render100%
(7/7)100%
(7/7)78%
(965/1238)68%
(606/896)src.schema29%
(2/7)29%
(2/7)1%
(20/1493)1%
(6/625)src.script100%
(16/16)100%
(16/16)69%
(727/1053)56%
(226/403)src.search100%
  

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 77 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/77/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 10 Sep 2019 10:09:33 +
 Build duration:
26 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.62.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(263/298)88%
(263/298)68%
(33409/49212)50%
(14972/29776)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4796/5091)49%
(1805/3654)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5480/5521)58%
(978/1688)src.buffer88%
(15/17)88%
(15/17)90%
(1710/1902)75%
(1103/1472)src.completion100%
(11/11)100%
(11/11)57%
(1786/3135)41%
(993/2405)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/850)0%
(0/178)src.document100%
(4/4)100%
(4/4)61%
(1940/3185)48%
(1431/2989)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(305/840)19%
(126/677)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/861)0%
(0/278)src.render100%
(7/7)100%
(7/7)78%
(965/1238)68%
(606/896)src.schema29%
(2/7)29%
(2/7)1%
(20/1493)1%
(6/625)src.script100%
(16/16)100%
(16/16)69%
(727/1053)56%
(226/403)src.search100%
(7/7)100%
 

D23827: Add manual tests for PC3

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  These were super useful for spotting bugs in PC2.
  They show many many issues already.
  
  Visually they should match PC2. They don't
  
  Some API doesn't map directly. Those tests
  were removed.

TEST PLAN
  Opened in qmlscene
  Everything binds correctly. Some things look horrible.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23827

AFFECTED FILES
  tests/components/busyindicator3.qml
  tests/components/button3.qml
  tests/components/checkbox3.qml
  tests/components/progressbar3.qml
  tests/components/radiobutton3.qml
  tests/components/textarea3.qml
  tests/components/textfield3.qml
  tests/components/toolbutton3.qml

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23828: Disable DBus pieces on Android

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  No DBus on Android. The few places do not seem critically necessary.
  
  This is required to bring plasma-phonebook on Android

REPOSITORY
  R307 KPeople

BRANCH
  dbus

REVISION DETAIL
  https://phabricator.kde.org/D23828

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/personmanager.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven added a comment.


  A plan of action would be :
  
  1. Check add recenly_used only on plasma KDE_FULL_SESSION (it can't be used 
outside )
  
  To improve dolphin and kde apps outside of plasma, make KRecentDocuments a 
recentlyused file user :
  
  2. Outside of plasma, make `recentlyused:/` use recentlyused.xbel as backend
  3. Make KRecentDocumensts use recentlyused.xbel
  
  4. Remove the KDE_FULL_SESSION check added in 1. (Alternatively, not do 1. 
and 4. as 2. and 3. make them not necessary)
  
  5. Kactivities mode without kactivitymanagerd could write data to 
recentlyused.xbel ? Seems not essential as with 3, at least File dialogs will 
mark files opened, only ResourceInstance calls will be added.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23815: [KConfig] port away from deprecated methods in Qt 5.14

[David Faure]

dfaure added a comment.


  I actually think it's a mistake to set this define unconditionally in PIM.
  
  If a user of the last PIM release (as in, a person or a distro) wants to use 
Qt 5.14, they'll get compilation errors, unnecessarily.
  
  If we want to enable this flag (to "punish" the first KDE developer who 
upgrades Qt, like me currently), then at least we should only do so in git 
checkouts, not in release tarballs.
  This is easy to do: `if (EXISTS "${CMAKE_SOURCE_DIR}/.git")`.
  I'm actually thinking of doing that (in KDEFrameworkCompilerSettings), once 
everything builds again (I obviously can't push that just yet).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23815

To: dfaure, mdawson, arichardson
Cc: arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D7446: [Places panel] Revamp the Recently Saved section

[David Faure]

dfaure added a comment.


  The last comment from Méven are the notes from a discussion we had together.
  In that discussion I realized that the kioslave depends on kactivities-stats, 
so I'm withdrawing my suggestion to move it to kio, where this dependency isn't 
wanted.
  It actually makes sense in kio-extras, especially if it gains support for 
non-plasma use cases.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23815: [KConfig] port away from deprecated methods in Qt 5.14

[Laurent Montel]

mlaurent added a comment.


  "If a user of the last PIM release (as in, a person or a distro) wants to use 
Qt 5.14, they'll get compilation errors, unnecessarily." and he will fix it :) 
not a bad idea :)
  
  "if (EXISTS "${CMAKE_SOURCE_DIR}/.git")" I like this idea.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23815

To: dfaure, mdawson, arichardson
Cc: arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23815: [KConfig] port away from deprecated methods in Qt 5.14

[David Faure]

dfaure added a comment.


  Laurent: I'm talking about release tarballs. People don't fix those, that 
would be pointless.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23815

To: dfaure, mdawson, arichardson
Cc: arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23801: Port kpac from QtScript

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I'll trust your expertise with such ports.
  I wouldn't know how to test this either.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23801

To: carewolf, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 65738.
kossebau added a comment.


  use brackets for correct logic

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23674?vs=65228&id=65738

BRANCH
  morecountoversplit

REVISION DETAIL
  https://phabricator.kde.org/D23674

AFFECTED FILES
  src/vimode/modes/normalvimode.cpp

To: kossebau, #kate
Cc: cullmann, apol, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D23674#528430 , @cullmann wrote:
  
  > Hmm, is lastLineLenght correct? Must one not decrement by one?
  
  
  Yes, someone missed in their brain to properly turn `- (x + 1)` into `- x - 
1`, just happened again with me when redoing the code in brain on first try, 
darn.
  As main idea of logic is: "fulllength" - "length of all chars up to last 
linebreak", so "length"  - "lastindex + 1"
  
  So example:
  
012345 <- pos
CCCNCC <- pasted text, C: char, N: newline
->
size: 6
last N pos: 3
last line length: 2

const int lastLineLength = 6 - (3 + 1) -> 2, 
  
  Adding brackets now, so the original idea is visible

INLINE COMMENTS

> apol wrote in normalvimode.cpp:3848
> oh I see, how about just using splitRef? This way we don't have to allocate 
> all the strings but the code still is more readable.

Still one allocation done for the vector ;)

Not sure about readibility. While the mistake done in formula spoils my point, 
I find the new code more readable, as the splitref would make me expect more 
sections are used, while it is just a hack to get the precalculated length of 
the last section, with info about all other sections discarded.
New code has less surprises to me. but two more error-prone calculations. Guess 
this is up to opinions, so up to maintainer :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23674

To: kossebau, #kate
Cc: cullmann, apol, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  morecountoversplit

REVISION DETAIL
  https://phabricator.kde.org/D23674

To: kossebau, #kate, cullmann
Cc: cullmann, apol, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23801: Port kpac from QtScript

[Allan Sandfeld Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:4ad1902278f0: Port kpac from QtScript (authored by 
carewolf).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23801?vs=65690&id=65741

REVISION DETAIL
  https://phabricator.kde.org/D23801

AFFECTED FILES
  src/kpac/CMakeLists.txt
  src/kpac/script.cpp
  src/kpac/script.h

To: carewolf, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:328adb52d3db: Use QString::count(QChar)+1 over 
QString::splitRef().length() (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23674?vs=65738&id=65743

REVISION DETAIL
  https://phabricator.kde.org/D23674

AFFECTED FILES
  src/vimode/modes/normalvimode.cpp

To: kossebau, #kate, cullmann
Cc: cullmann, apol, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23791: ECMAddQch: add INCLUDE_DIRS argument

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Would push upcoming WE if there are no objections.
  And then also adapt all KF modules to make use of this new argument, for 
better results and less need for predefined macros.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23791

To: kossebau, #build_system
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/66/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Sep 2019 12:05:59 +
 Build duration:
1 hr 6 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

T11542: Remove KHTML

[Andreas Cord-Landwehr]

cordlandwehr closed subtask T11575: Port Parley away from KHTML as 
"Resolved".

TASK DETAIL
  https://phabricator.kde.org/T11542

To: cordlandwehr
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, 
#frameworks, knauss, GB_2, kpiwowarski, asturmlechner, vkrause, dfaure

D23832: Variable expansion: Prefer return value over return argument

[Dominik Haumann]

dhaumann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  Backup on save: Support time and date string replacements
  
  Supported variables are:
  
  - %{Date:Locale}
  - %{Date:ISO}
  - %{Date:} - see https://doc.qt.io/qt-5/qdate.html#toString
  - %{Time:Locale}
  - %{Time:ISO}
  - %{Time:} - see https://doc.qt.io/qt-5/qtime.html#toString
  - %{ENV:}
  - %{JS:}
  - %{UUID}
  
  BUG: 403583
  FIXED-IN: 5.63

REPOSITORY
  R39 KTextEditor

BRANCH
  bug

REVISION DETAIL
  https://phabricator.kde.org/D23832

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/utils/katevariableexpansionmanager.cpp
  src/utils/katevariableexpansionmanager.h
  src/utils/ktexteditor.cpp

To: dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23832: Variable expansion: Prefer return value over return argument

[Dominik Haumann]

dhaumann added a comment.


  KateDialogs contains the following:
  
if (uiadv->edtBackupSuffix->text().isEmpty() && 
uiadv->edtBackupPrefix->text().isEmpty()) {
KMessageBox::information(
this,
i18n("You did not provide a backup suffix or prefix. Using default 
suffix: '~'"),
i18n("No Backup Suffix or Prefix")
);
uiadv->edtBackupSuffix->setText(QStringLiteral("~"));
}
  
  Theoretically, if a variable exands to nothing (JS:..., ENV:...) we could 
still run into both empty prefix and suffix in katedocument.cpp.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23832

To: dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23832: Variable expansion: Prefer return value over return argument

[Dominik Haumann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:5ed71b5b75ec: Variable expansion: Prefer return value over 
return argument (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23832?vs=65749&id=65750#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23832?vs=65749&id=65750

REVISION DETAIL
  https://phabricator.kde.org/D23832

AFFECTED FILES
  src/utils/katevariableexpansionmanager.cpp
  src/utils/katevariableexpansionmanager.h
  src/utils/ktexteditor.cpp

To: dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23833: Fix port to QJS

[Allan Sandfeld Jensen]

carewolf created this revision.
carewolf added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
carewolf requested review of this revision.

REVISION SUMMARY
  Two mistakes with DateRange was discovered after I figured out
  how to test it.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23833

AFFECTED FILES
  src/kpac/CMakeLists.txt
  src/kpac/script.cpp

To: carewolf, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 198 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/198/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 10 Sep 2019 12:26:41 +
 Build duration:
1 hr 8 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.62.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(263/298)88%
(263/298)68%
(33392/49213)50%
(14962/29776)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4796/5091)49%
(1805/3654)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5480/5521)58%
(978/1688)src.buffer88%
(15/17)88%
(15/17)90%
(1710/1902)75%
(1103/1472)src.completion100%
(11/11)100%
(11/11)57%
(1786/3135)41%
(993/2405)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/850)0%
(0/178)src.document100%
(4/4)100%
(4/4)61%
(1940/3185)48%
(1432/2989)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(305/840)19%
(126/677)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/861)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(950/1238)67%
(597/896)src.schema29%
(2/7)29%
(2/7)1%
(20/1493)1%
(6/625)src.script100%
(16/16)100%
(16/16)69%
(727/1053)56%
(226/403)src.search100%
(7/7)100%

D23832: Variable expansion: Prefer return value over return argument

[Dominik Haumann]

dhaumann reopened this revision.
dhaumann added a comment.


  arc bug: it's not yet committed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23832

To: dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23833: Fix port to QJS

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Can you maybe document how to test this, e.g. in the README in this dir?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23833

To: carewolf, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23832: Variable expansion: Prefer return value over return argument

[Dominik Haumann]

dhaumann updated this revision to Diff 65754.
dhaumann added a comment.


  - rebase to master

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23832?vs=65750&id=65754

BRANCH
  bug

REVISION DETAIL
  https://phabricator.kde.org/D23832

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp

To: dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23832: Variable expansion: Prefer return value over return argument

[Dominik Haumann]

dhaumann added a reviewer: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23832

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23835: Add TabKCM

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  We have quite a few KCMs that use tabs as top-level components. Since tabs 
are a bit weird in QML quite a few workarounds have been piling up in some 
KCMs, making them inconsistent with each other.
  
  By adding a common TabKCM API we can unify the presentation and implementation

REPOSITORY
  R296 KDeclarative

BRANCH
  tabkcm

REVISION DETAIL
  https://phabricator.kde.org/D23835

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/Tab.qml
  src/qmlcontrols/kcmcontrols/qml/TabKCM.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir

To: nicolasfella, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23835: Add TabKCM

[Nicolas Fella]

nicolasfella edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23832: Variable expansion: Prefer return value over return argument

[Dominik Haumann]

dhaumann edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23832

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23832: Variable expansion: Prefer return value over return argument

[Dominik Haumann]

dhaumann added a subscriber: ngraham.
dhaumann added a comment.


  @ngraham: This may be interesting to you as well (and a prereq for the 
External Tools plugin)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23832

To: dhaumann, cullmann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, bruns, demsking, cullmann, sars, dhaumann

D23835: Add TabKCM

[Nathaniel Graham]

ngraham added a comment.


  Nice, I think we need this.
  
  From the image, I think the frame's background color needs to be the same as 
the active tab color, and there shouldn't be a line separating them, This is 
something we currently have in the Plasma-pa KCM (albeit with the wrong 
background color), but we lose it with this new KCM style.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> TabKCM.qml:153-160
> +var theTabs = []
> +var i = 0
> +
> +for( i=0; i < tabs.length; i++) {
> +tabs[i].delegate.createObject(sl, {})
> +theTabs.push(tabs[i].title)
> +}

FYI, QML has some features from ECMAScript 6, so you could make this code a bit 
cleaner, e.g.

  for (const tab of tabs)
  tab.delegate.createObject(sl, {});
  
  tabsRepeater.model = tabs.map(tab => tab.title);

(I didn't test whether this code actually works)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

T11542: Remove KHTML

[Sandro Knauß]

knauss reopened subtask T11575: Port Parley away from KHTML as "Open".

TASK DETAIL
  https://phabricator.kde.org/T11542

To: knauss
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, 
#frameworks, knauss, GB_2, kpiwowarski, asturmlechner, vkrause, dfaure

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/76/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Sep 2019 12:26:41 +
 Build duration:
1 hr 47 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys

D23835: Add TabKCM

[Nathaniel Graham]

ngraham added a dependent revision: D23836: Use new TabKCM API.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

[Nathaniel Graham]

ngraham added a comment.


  Also related: the lack of a real QML tab view: 
https://bugs.kde.org/show_bug.cgi?id=394296

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

[Nicolas Fella]

nicolasfella updated this revision to Diff 65760.
nicolasfella added a comment.


  - Remove line beneath active tab

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23835?vs=65755&id=65760

BRANCH
  tabkcm

REVISION DETAIL
  https://phabricator.kde.org/D23835

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/Tab.qml
  src/qmlcontrols/kcmcontrols/qml/TabKCM.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

[Nicolas Fella]

nicolasfella added a comment.


  In D23835#528688 , @ngraham wrote:
  
  > Nice, I think we need this.
  >
  > From the image, I think the frame's background color needs to be the same 
as the active tab color, and there shouldn't be a line separating them, This is 
something we currently have in the Plasma-pa KCM (albeit with the wrong 
background color), but we lose it with this new KCM style.
  
  
  Achieving this was easier than I initially thought, but now the color of the 
active tab doesn't match the content. With the line in this was much less of a 
problem

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

[Nicolas Fella]

nicolasfella updated this revision to Diff 65761.
nicolasfella added a comment.


  - Implement Vlad's suggestion

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23835?vs=65760&id=65761

BRANCH
  tabkcm

REVISION DETAIL
  https://phabricator.kde.org/D23835

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/Tab.qml
  src/qmlcontrols/kcmcontrols/qml/TabKCM.qml
  src/qmlcontrols/kcmcontrols/qml/qmldir

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23835: Add TabKCM

[Nicolas Fella]

nicolasfella edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23833: Fix port to QJS

[Allan Sandfeld Jensen]

carewolf added a comment.


  It was already described in the two tests included kpactest.pac and 
kpactest2.pac

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23833

To: carewolf, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23833: Fix port to QJS

[Allan Sandfeld Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9e1220bf76ad: Fix port to QJS (authored by carewolf).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23833?vs=65752&id=65767

REVISION DETAIL
  https://phabricator.kde.org/D23833

AFFECTED FILES
  src/kpac/CMakeLists.txt
  src/kpac/script.cpp

To: carewolf, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Sep 2019 14:14:07 +
 Build duration:
46 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23839: Port away from Qt's foreach

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: KWin, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R278 KWindowSystem

BRANCH
  portfromforeach

REVISION DETAIL
  https://phabricator.kde.org/D23839

AFFECTED FILES
  autotests/kwindowsystem_threadtest.cpp
  src/platforms/xcb/kwindoweffects.cpp
  src/platforms/xcb/kwindowsystem.cpp
  src/platforms/xcb/netwm.cpp
  src/pluginwrapper.cpp

To: kossebau, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23835: Add TabKCM

[Onvitai Kayan]

onvitaik added a comment.


  Can I also suggest making the tabs occupy the full width of the area 
available? It minimizes the unused space and keeps everything in a nice 
rectangle:
  
  F7337756: wide_tabs.png 

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

[David Faure]

dfaure added a reviewer: mlaurent.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D23816

To: dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

[David Faure]

dfaure updated this revision to Diff 65770.
dfaure added a comment.


  rebase on top of Laurent's angleDelta().y() commit

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23816?vs=65720&id=65770

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23816

AFFECTED FILES
  src/kwidgetitemdelegate.cpp
  src/kwidgetitemdelegatepool.cpp

To: dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23839: Port away from Qt's foreach

[Albert Astals Cid]

aacid added a comment.


  seems good to me, but let someone of the people that actually know the code 
to the +2

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23839

To: kossebau, #kwin, zzag
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/77/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Sep 2019 14:14:19 +
 Build duration:
59 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 10 Sep 2019 14:15:53 +
 Build duration:
1 hr 1 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D23825: Split KSslErrorUiData from KTcpSocket

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:79ee43be4d3f: Split KSslErrorUiData from KTcpSocket 
(authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23825?vs=65731&id=65775

REVISION DETAIL
  https://phabricator.kde.org/D23825

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/ksslcertificatemanager.cpp
  src/core/ksslerroruidata.cpp
  src/core/ksslerroruidata.h
  src/core/ksslerroruidata_p.h
  src/core/ktcpsocket.cpp
  src/core/ktcpsocket.h
  src/core/ktcpsocket_p.h
  src/widgets/sslui.cpp

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23832: Backup on save: Support time and date string replacements

[Dominik Haumann]

dhaumann retitled this revision from "Variable expansion: Prefer return value 
over return argument" to "Backup on save: Support time and date string 
replacements".
dhaumann edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23832

To: dhaumann, cullmann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, bruns, demsking, cullmann, sars, dhaumann

D23839: Port away from Qt's foreach

[Vlad Zagorodniy]

zzag added a comment.


  Did you use a script to create this patch?

INLINE COMMENTS

> kwindowsystem_threadtest.cpp:61
>  const QList windows = KWindowSystem::stackingOrder();
> -foreach (auto wid, windows) {
> +for (auto wid : windows) {
>  KWindowInfo info(wid, NET::WMVisibleName);

Capture the value by const ref please.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23839

To: kossebau, #kwin, zzag
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

[David Faure]

dfaure added a comment.


  @Kai-Uwe, you can drop this merge request, given that D23758 
 is in.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11987

To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

[David Faure]

dfaure added a comment.


  Heh, yeah, we have 3 APIs about mounted filesystems. Solid, KMountPoint, and 
KFileSystemType.
  
  KFileSystemType uses the blocking statvfs, while KMountPoint relies on a 
properly filled in /etc/fstab -- which breaks on the FreeBSD CI these days, 
some weird magic with containers not needing anything in /etc/fstab.
  
  It seems to me that we're still looking for the silver bullet solution in 
this area

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23420

To: meven, dfaure, #frameworks
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23839: Port away from Qt's foreach

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D23839#528788 , @zzag wrote:
  
  > Did you use a script to create this patch?
  
  
  Nope, manually done.

INLINE COMMENTS

> zzag wrote in kwindowsystem_threadtest.cpp:61
> Capture the value by const ref please.

Would a const ref make sense here, given the type nature of WId which boils 
down to a integer matching the byte size of a pointer?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23839

To: kossebau, #kwin, zzag
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23839: Port away from Qt's foreach

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> kossebau wrote in kwindowsystem_threadtest.cpp:61
> Would a const ref make sense here, given the type nature of WId which boils 
> down to a integer matching the byte size of a pointer?

I asked that because `for (const Type &item : collection) {` is more common. I 
know that const ref doesn't have any advantages here.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23839

To: kossebau, #kwin, zzag
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23816: [KItemViews] Port to non-deprecated QWheelEvent API

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  It seems ok for me. +2

REPOSITORY
  R276 KItemViews

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23816

To: dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23839: Port away from Qt's foreach

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in kwindowsystem_threadtest.cpp:61
> I asked that because `for (const Type &item : collection) {` is more common. 
> I know that const ref doesn't have any advantages here.

In either case, this change is good to go. However, it would be great to 
capture values by const ref.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23839

To: kossebau, #kwin, zzag
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 211 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/211/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 10 Sep 2019 15:21:19 +
 Build duration:
22 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.62.0.xmllogs/KF5KIO/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33698/61208)39%
(17275/44142)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9376/9826)47%
(4345/9242)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8638/14459)51%
(4774/9299)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4652/8280)43%
(2056/4837)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(674/1209)40%
(382/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D23839: Port away from Qt's foreach

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for review, Albert & Vlad.
  
  BTW; still one foreach left in macOS branch of code, which I could not 
test-drive, so did not change (also touching internals that I could not quickly 
understand if there is a chance to conflicting container changes in the call 
chains from the loop).

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23839

To: kossebau, #kwin, zzag
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns