D23970: Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23970

To: dfaure, davidedmundson, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 80 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/80/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 01:12:26 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/18/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 00:40:10 +
 Build duration:
50 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 19 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/19/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 16 Sep 2019 00:40:11 +
 Build duration:
49 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.63.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(240/268)90%
(240/268)85%
(27108/32005)53%
(10892/20534)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12424/12524)50%
(6536/13037)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6344/7473)65%
(1829/2828)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)84%
(7886/9351)64%
(2350/3678)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/31/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 00:27:31 +
 Build duration:
55 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 81 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/81/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 16 Sep 2019 00:00:09 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.63.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6880/9069)43%
(10762/24785)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2867/2956)49%
(6164/12707)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/789)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D23970: Port away from deprecated methods in Qt 5.14

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23970

To: dfaure, davidedmundson, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23968: Use app specific location for DB on Android

[Aleix Pol Gonzalez]

apol added a comment.


  Then maybe Qt shouldn't offer it? It's supposed to be writtable after all...

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D23968

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 updated this revision to Diff 66167.
GB_2 added a comment.


  Also for Qt 4

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23879?vs=66166=66167

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23879

AFFECTED FILES
  icons-dark/apps/48/designer-qt5.svg
  icons/apps/48/designer-qt5.svg

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 updated this revision to Diff 66166.
GB_2 added a comment.


  Rename to `designer-qt5` to avoid overriding unrelated icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23879?vs=65857=66166

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23879

AFFECTED FILES
  icons-dark/apps/48/designer-qt5.svg
  icons/apps/48/designer-qt5.svg

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 updated this revision to Diff 66162.
GB_2 added a comment.


  Really add back "Show Alternatives..." item

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66160=66162

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 updated this revision to Diff 66160.
GB_2 added a comment.


  Add back "Show Alternatives..." item

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66103=66160

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/plasma/private/applet_p.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D21197: [KCoreDirLister] Remove assert in reinsert method

[David Faure]

dfaure added a comment.


  @chinmoyr D23875  fixes the crash, I 
suggest to abandon this change request. We can discuss it again if someone 
manages to hit the assert again, in a different scenario :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21197

To: chinmoyr, dfaure, #frameworks, pino, elvisangelaccio, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[Dominik Haumann]

dhaumann added a comment.


  @dfaure: D21197  can be closed / 
abandoned?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23875

To: dfaure, #frameworks, ahmadsamir
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[David Faure]

dfaure added a comment.


  Yeah I didn't change the git commit's author. It's partly your code, partly 
me deleting someone else's code :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23875

To: dfaure, #frameworks, ahmadsamir
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[Ahmad Samir]

ahmadsamir added a comment.


  Here, in the web-UI, it says authored by dfaure, as it should, but the commit 
still says authored by me.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23875

To: dfaure, #frameworks, ahmadsamir
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve desktop layout and panel editing UX

[Nathaniel Graham]

ngraham added a comment.


  OK cool, let's move the general UX discussion back into T10190 
 and use these just for implementation 
discussion.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[David Faure]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f539b17ceec2: KCoreDirLister: fix crash when creating new 
folders from kfilewidget (authored by ahmadsamir, committed by dfaure).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23875?vs=66116=66152

REVISION DETAIL
  https://phabricator.kde.org/D23875

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/core/kcoredirlister.cpp

To: dfaure, #frameworks, ahmadsamir
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23963: [KTextEditor] Port away from deprecated qBinaryFind

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:532e9dc7bac8: [KTextEditor] Port away from deprecated 
qBinaryFind (authored by dfaure).
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23963?vs=66120=66151

REVISION DETAIL
  https://phabricator.kde.org/D23963

AFFECTED FILES
  src/render/katelayoutcache.cpp

To: dfaure, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23951: Improve desktop layout and panel editing UX

[Nathaniel Graham]

ngraham added a task: T10190: (Re)define modes when editing panels and widgets.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 62 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/62/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 15 Sep 2019 19:00:13 +
 Build duration:
7 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.63.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(240/268)90%
(240/268)85%
(27121/32003)53%
(10906/20534)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12450/12524)50%
(6559/13037)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6332/7471)64%
(1821/2828)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)84%
(7885/9351)64%
(2349/3678)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/17/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Sep 2019 19:00:12 +
 Build duration:
6 min 8 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D23915: Improve documentation

[Frederik Gladhorn]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:6388d550e3a2: Improve documentation (authored by 
gladhorn).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23915?vs=66078=66150

REVISION DETAIL
  https://phabricator.kde.org/D23915

AFFECTED FILES
  src/client/datadevice.h
  src/client/dpms.h
  src/server/datadevice_interface.h
  src/server/dpms_interface.h

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23915: Improve documentation

[Roman Gilg]

romangg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  arcpatch-D23915_1

REVISION DETAIL
  https://phabricator.kde.org/D23915

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23961: Add apidox to most of KFilePlacesModel

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bcf51ae68193: Add apidox to most of KFilePlacesModel 
(authored by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23961?vs=66124=66149

REVISION DETAIL
  https://phabricator.kde.org/D23961

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.h

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23955: KBookmark: improve addBookmark apidox

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:797763d4b4d2: KBookmark: improve addBookmark apidox 
(authored by elvisangelaccio).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23955?vs=66108=66148

REVISION DETAIL
  https://phabricator.kde.org/D23955

AFFECTED FILES
  src/kbookmark.h

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23969: [kpropertiesdialog] add icons for the size section

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:764616b91b21: [kpropertiesdialog] add icons for the size 
section (authored by tienisto, committed by GB_2).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23969?vs=66130=66146

REVISION DETAIL
  https://phabricator.kde.org/D23969

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, mglb, meven, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, ngraham, andrebarros, 
bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D23969: [kpropertiesdialog] add icons for the size section

[Björn Feber]

GB_2 accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23969

To: tienisto, #vdg, ngraham, GB_2
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, mglb, meven, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, ngraham, andrebarros, 
bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D23969: [kpropertiesdialog] add icons for the size section

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice!

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23969

To: tienisto, #vdg, ngraham
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, mglb, meven, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, ngraham, andrebarros, 
bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D23972: Add icons for "Open With" and "Actions" menus

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e574f67a319e: Add icons for Open With and 
Actions menus (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23972?vs=66139=66140

REVISION DETAIL
  https://phabricator.kde.org/D23972

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: ngraham, #vdg, GB_2
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23972: Add icons for "Open With" and "Actions" menus

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Excellent!

REPOSITORY
  R241 KIO

BRANCH
  icons-in-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23972

To: ngraham, #vdg, GB_2
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23972: Add icons for "Open With" and "Actions" menus

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, GB_2.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  As requested in D23757 

TEST PLAN
  F7356406: all icons.png 

REPOSITORY
  R241 KIO

BRANCH
  icons-in-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23972

AFFECTED FILES
  src/widgets/kfileitemactions.cpp

To: ngraham, #vdg, GB_2
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[Ahmad Samir]

ahmadsamir added a comment.


  Thanks for the explanation; it filled all the, various, gaps in my reasoning.
  
  Looks good to me. (I don't have a dev account, so probably phab.kde.org 
doesn't show the "accept revision" or similar in its web UI for me).

INLINE COMMENTS

> dfaure wrote in kfilewidgettest.cpp:516
> This test fails when being run twice in a row (without the fix), or if 
> /tmp/folder1 already exists for some unrelated reason.
> 
> I suggest using QTemporaryDir instead of QDir::tempPath, so that the deletion 
> of the QTemporaryDir cleans up in all cases (success or failure).
> 
> I did it locally to debug this, here it is:
> 
>   QTemporaryDir tempDir;
>   QVERIFY(tempDir.isValid());
>   const QString dir = tempDir.path();
>   const QUrl url = QUrl::fromLocalFile(dir); 
> 
> (and then you can remove the cleanup code at the end of the method)

Yes, it does fail if the dir got created and the test didn't finish running for 
whatever reason; I was thinking of CI (which will nuke the whole build and 
start over), rather than of other people running the test locally.

> dfaure wrote in kfilewidgettest.cpp:522
> show() and activateWindow() are not needed for this unittest to demonstrate 
> the failure.
> 
> I'm trying to reduce the number of stuff popping up when running ctest, since 
> that's rather annoying if I'm doing something else at the same time :-)

Yes, they're quiet sudden, and disappear too quickly too. But it won't matter 
for KIO tests, it's just one of many many dialogs :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23875

To: dfaure, #frameworks, ahmadsamir
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23145

To: broulik, vonreth, pali, antlarr, bruns
Cc: apol, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23970: Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure created this revision.
dfaure added reviewers: davidedmundson, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  Builds with -DQT_DISABLE_DEPRECATED_BEFORE=0x06 (as of today)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23970

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/plasma/containmentactions.cpp
  src/plasma/framesvg.cpp
  src/plasmaquick/dialog.cpp

To: dfaure, davidedmundson, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23969: [kpropertiesdialog] add icons for the size section

[Tien Do Nam]

tienisto retitled this revision from "add icons for kpropertiesdialog" to 
"[kpropertiesdialog] add icons for the size section".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23969

To: tienisto, #vdg, ngraham
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, mglb, meven, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, ngraham, andrebarros, 
bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D23969: add icons for kpropertiesdialog

[Tien Do Nam]

tienisto edited the summary of this revision.
tienisto added a reviewer: ngraham.
tienisto added projects: Dolphin, VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23969

To: tienisto, #vdg, ngraham
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, mglb, meven, 
michaelh, crozbo, spoorun, ndavis, navarromorales, firef, ngraham, andrebarros, 
bruns, skadinna, emmanuelp, mikesomov, aaronhoneycutt, mbohlender

D23968: Use app specific location for DB on Android

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  GenericDataLocation is typically not trivially writable on Android. Since we 
don't share the database with other apps we can use an app specific directory

REPOSITORY
  R307 KPeople

BRANCH
  appdata

REVISION DETAIL
  https://phabricator.kde.org/D23968

AFFECTED FILES
  src/personmanager.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23969: add icons for kpropertiesdialog

[Tien Do Nam]

tienisto created this revision.
tienisto added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tienisto requested review of this revision.

REVISION SUMMARY
  add icons for two buttons in the "size" section

TEST PLAN
  Open properties of a folder and see those icons under "General/size"

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23969

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23961: Add apidox to most of KFilePlacesModel

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Nice work!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23961

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23960: [KTextEditor] Port away from deprecated QModelIndex::child()

[David Faure]

dfaure closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23960

To: dfaure, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23960: [KTextEditor] Port away from deprecated QModelIndex::child()

[David Faure]

dfaure added a comment.


  -DQT_DISABLE_DEPRECATED_BEFORE=0x06 leaves me no choice ;-)

REPOSITORY
  R39 KTextEditor

BRANCH
  port_child

REVISION DETAIL
  https://phabricator.kde.org/D23960

To: dfaure, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23960: [KTextEditor] Port away from deprecated QModelIndex::child()

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for taking care, I was always to lazy too tackle that :/

REPOSITORY
  R39 KTextEditor

BRANCH
  port_child

REVISION DETAIL
  https://phabricator.kde.org/D23960

To: dfaure, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23961: Add apidox to most of KFilePlacesModel

[Elvis Angelaccio]

elvisangelaccio updated this revision to Diff 66124.
elvisangelaccio added a comment.


  Mention that URLs will be stored in the QUrl::FullyEncoded string format.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23961?vs=66121=66124

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23961

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.h

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23961: Add apidox to most of KFilePlacesModel

[Elvis Angelaccio]

elvisangelaccio updated this revision to Diff 66121.
elvisangelaccio added a comment.


  - Fixed typo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23961?vs=66118=66121

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23961

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.h

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23961: Add apidox to most of KFilePlacesModel

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23961

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.h

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23960: [KTextEditor] Port away from deprecated QModelIndex::child()

[David Faure]

dfaure created this revision.
dfaure added reviewers: cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  A bit more verbose in some places, but actually simpler in code
  that was checking parent.isValid() and calling index or child, while index 
does it all.

TEST PLAN
  Compiles

REPOSITORY
  R39 KTextEditor

BRANCH
  port_child

REVISION DETAIL
  https://phabricator.kde.org/D23960

AFFECTED FILES
  src/completion/kateargumenthinttree.cpp
  src/completion/katecompletionmodel.cpp
  src/completion/katecompletiontree.cpp
  src/completion/katecompletionwidget.cpp
  src/schema/katecolortreewidget.cpp

To: dfaure, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/78/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Sep 2019 12:26:25 +
 Build duration:
7 min 17 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23954: KRun: port to KService::Ptr

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23954

To: dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[David Faure]

dfaure commandeered this revision.
dfaure edited reviewers, added: ahmadsamir; removed: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23875

To: dfaure, #frameworks, ahmadsamir
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[David Faure]

dfaure resigned from this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23875

To: ahmadsamir, #frameworks
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[David Faure]

dfaure updated this revision to Diff 66116.
dfaure added a comment.


  Simplify autotest; suggest a different fix which removes unnecessary updates 
and preserves the assert.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23875?vs=66104=66116

BRANCH
  arcpatch-D23875

REVISION DETAIL
  https://phabricator.kde.org/D23875

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/core/kcoredirlister.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Sorry it took me a long time to review this. The commit didn't fully satisfy 
my need to understand the underlying problem, so I had to find the time to 
debug the issue (thanks for the unittest, it really helps with that).
  
  AFAICS here's what happens:
  
  1. We create folder1 and immediately move the view into it
  2. So by the time `itemsAddedInDirectory()` (the DBus notification) is called 
for the parent directory, there is no KDirLister showing that directory 
anymore. Therefore this directory isn't listed again, it's just marked as dirty 
in the cache, for the next time the user will go into it (see `checkUpdate` 
where it says "not in use, marked dirty"). That's the usual optimization to 
avoid re-listing directories that are not shown anymore.
  3. Therefore the parent directory doesn't actually have a child item for 
folder1
  4. We then process the KDirWatch notification (`processPendingUpdates`) for 
the parent directory, which updates the mtime of that directory item. OK.
  5. Steps 1-3 happen again the same way for `folder1/folder2`
  6. Then, just like step 4, we process the KDirWatch notification for 
`folder1`, but it can't find that item in the parent directory due to step 2 
above. ASSERT.
  
  The heart of the issue is that `findByUrl` first looks into "child items of 
the parent dir" then, for subdirs, falls back to the "." of the subdir (so it 
actually works for `folder1`).
  On the other hand, `reinsert` only supports child items, not "." items.
  This design is certainly quite tricky because for subdirs, the same URL is 
normally represented those two different items (except in this unusual scenario 
which skipped creating a child item in the parent directory...).
  
  OK, so how to fix this. A KDirWatch notification for a directory is about 
updating the mtime and/or permissions of that directory. But that's already 
done in `handleFileDirty`, as shown by `bin/kdirlistertest 
testDirPermissionChange`. A permission change for an item we're not showing 
(folder1, while in folder2) also works (handleFileDirty ends up in checkUpdate 
which marks it as dirty; tested manually).
  So... overall we don't actually need to do a `processPendingUpdates` for a 
KDirWatch notification for a directory in cache. It was added in commit 
9c1e5d56cdfb8 
 but 
`testDirPermissionChange` actually passes without it (at least nowadays). In 
addition, adding pending updates in `updateDirectory` called by 
`processPendingUpdates` seems very unclean to me (cyclic layering).
  So my suggested fix is to actually remove some code :-)
  
  I'll post a modified patch with my suggested changes.
  
  Thanks for pushing me to debug this, it's  not trivial.

INLINE COMMENTS

> kfilewidgettest.cpp:516
> +//created and entered, kdirlister would hit an assert (in 
> reinsert()), bug 408801
> +const QUrl url = 
> QUrl::fromLocalFile(QDir::tempPath()).adjusted(QUrl::StripTrailingSlash);
> +const QString dir = url.toLocalFile();

This test fails when being run twice in a row (without the fix), or if 
/tmp/folder1 already exists for some unrelated reason.

I suggest using QTemporaryDir instead of QDir::tempPath, so that the deletion 
of the QTemporaryDir cleans up in all cases (success or failure).

I did it locally to debug this, here it is:

  QTemporaryDir tempDir;
  QVERIFY(tempDir.isValid());
  const QString dir = tempDir.path();
  const QUrl url = QUrl::fromLocalFile(dir); 

(and then you can remove the cleanup code at the end of the method)

> kfilewidgettest.cpp:522
> +fw.show();
> +fw.activateWindow();
> +

show() and activateWindow() are not needed for this unittest to demonstrate the 
failure.

I'm trying to reduce the number of stuff popping up when running ctest, since 
that's rather annoying if I'm doing something else at the same time :-)

> kfilewidgettest.cpp:533
> +// check that KFileWidget didn't crash
> +QVERIFY(QTest::qWaitForWindowActive());
> +

Not needed, I get the assert even without this line.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23875

To: ahmadsamir, #frameworks, dfaure
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KF6 Sprint

[Volker Krause]

Hi,

as you might have seen in David's summary of the KF6 BoF at Akademy (https://
mail.kde.org/pipermail/kde-frameworks-devel/2019-September/093298.html), 
there's the idea to have a KF6 sprint, along the lines of the KF5 sprint we 
had in Randa a few years back, to determine what we actually want to achieve 
with KF6 beyond just porting to Qt6.

If you are interested please subscribe to https://phabricator.kde.org/T11535 
and indicate your interest to participate, as well as times that would work 
for you. I'm not just looking at the current KF5 contributors for this, but 
also those of you heavily using KF5.

If you are willing to help organize the sprint, please indicate so there too, 
help with that would be greatly appreciated (I'm not organizing this, I'm just 
writing this email because Albert asked me too ;-) ).

With Qt 6 planned for Nov 2020 we are probably looking at a 18-24 month time 
frame towards KF6, so it's time to get this going.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/77/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Sep 2019 10:53:06 +
 Build duration:
7 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23956: KFilePlacesModel: fix @since tags

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:90c5872c08de: KFilePlacesModel: fix @since tags (authored 
by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23956?vs=66109=66111

REVISION DETAIL
  https://phabricator.kde.org/D23956

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.h

To: elvisangelaccio, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23956: KFilePlacesModel: fix @since tags

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Yeah, that's my next patch ;)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23956

To: elvisangelaccio, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23956: KFilePlacesModel: fix @since tags

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I'll trust you on the numbers.
  
  While you're at it, did you notice how much missing method documentation 
there is in in this class? :-)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23956

To: elvisangelaccio, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23956: KFilePlacesModel: fix @since tags

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added reviewers: dfaure, aacid.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  A bunch of @since tags were missing or wrong.
  While at it, use the same ///< style for enum apidox comments.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23956

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.h

To: elvisangelaccio, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23954: KRun: port to KService::Ptr

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  2019_krun_rewrite

REVISION DETAIL
  https://phabricator.kde.org/D23954

To: dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Heads-up: KContacts and KCalendarCore about to move to Frameworks

[Volker Krause]

Hi,

as previously discussed here and finally approved during Akademy we will move 
KContacts and KCalendarCore from Applications to Frameworks. This should 
hopefully cause minimal disruptions as the versions then released with KF 5.63 
are drop-in replacements for the previously releases with Applications (same 
ABI, higher version number).

KCalendarCore will however rename its Git repo in the process to be consistent 
(kcalcore -> kcalendarcore). For kdesrc-build users not actively working on 
KCalendarCore this should be transparent, otherwise you might need to adjust 
the Git remote accordingly.

I'll inform you once this process has been completed.

Thanks,
Volker

signature.asc
Description: This is a digitally signed message part.

D23955: KBookmark: improve addBookmark apidox

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D23955#531647 , @dfaure wrote:
  
  > OK (why does this matter to the user of the class, though?)
  
  
  See D23706 , dolphin is going to need 
regex-based matches on the placesmodel URLs.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23955

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23955: KBookmark: improve addBookmark apidox

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK (why does this matter to the user of the class, though?)

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23955

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23955: KBookmark: improve addBookmark apidox

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  Clarify that the URL will be stored in its toString(QUrl::FullyEncoded)
  version.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23955

AFFECTED FILES
  src/kbookmark.h

To: elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23954: KRun: port to KService::Ptr

[David Faure]

dfaure created this revision.
dfaure added a reviewer: vkrause.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  One more step towards KJob

TEST PLAN
  krununittest; kruntest

REPOSITORY
  R241 KIO

BRANCH
  2019_krun_rewrite

REVISION DETAIL
  https://phabricator.kde.org/D23954

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun_p.h

To: dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 added a dependent revision: D23952: Remove panel toolbox clean up editing 
options.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

[Ahmad Samir]

ahmadsamir updated this revision to Diff 66104.
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a reviewer: chinmoyr.
ahmadsamir added a comment.


  Refer to one bug report, the others are dupes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23875?vs=65846=66104

BRANCH
  ahmad/kcoredirlister (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23875

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/core/kcoredirlister_p.h

To: ahmadsamir, #frameworks, dfaure, chinmoyr
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23951: Improve desktop layout and panel editing UX

[Björn Feber]

GB_2 retitled this revision from "Move "Panel Options" context menu items out 
of submenu and rename "Configure Panel..." option" to "Improve desktop layout 
and panel editing UX".
GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 updated this revision to Diff 66103.
GB_2 added a comment.


  Only show "Unlock Widgets" in the UI and only show "Show Alternatives..." in 
panel edit mode

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23951?vs=66095=66103

BRANCH
  
move-panel-options-contextmenu-items-out-of-submenu-and-rename-configure-panel-option
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23951

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/corona.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:010c34f0e7c5: Add enablefont and disablefont icon for 
kfontinst KCM (authored by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23942?vs=66083=66100

REVISION DETAIL
  https://phabricator.kde.org/D23942

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/font-enable.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/font-enable.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/font-enable.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/font-enable.svg

To: guoyunhe, #breeze, ndavis, GB_2
Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D23951: Move "Panel Options" context menu items out of submenu and rename "Configure Panel..." option

[Björn Feber]

GB_2 added a comment.


  In D23951#531545 , @ngraham wrote:
  
  > Two things with this patch series:
  >
  > 1. Now there's no way to lock widgets without entering panel edit mode. 
Feels like we might as well just get rid of unlocked mode entirely. Or are more 
patches coming? Did we ever come to a conclusion in T10190 
?
  
  
  Right, I think we'll need to discuss it a bit more.
  
  > - Delay D23950  until Plasma 5.18 
(maybe for the best if the final UX is not clear yet)
  
  Yeah, then we have some more time to think about the UX and test it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns