D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-syntax-srt

REVISION DETAIL
  https://phabricator.kde.org/D24211

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24210: KadeModeMenuList: fix memory leaks and others

[Nibaldo González]

nibags added a comment.


  `m_searchName` is a pointer to an attribute of a KateFileType object (which 
may be the string `translatedName` or `name`), but in some cases a new string 
is created.
  
  I added the boolean `m_bHasNewSearchName` that is true when a new QString is 
created for search. This is much simpler.
  
  Still, if you don't like it and prefer to use inline attributes, I can change 
it without problems =)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24210

To: nibags, #ktexteditor, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24210: KadeModeMenuList: fix memory leaks and others

[Nibaldo González]

nibags updated this revision to Diff 66864.
nibags added a comment.


  - Update
  
  - Add boolean `m_bHasNewSearchName` to verify removal of `m_searchName`.
  - Correct format in some comments.
  - Remove `friend KateModeMenuList` and replace it with the "Factory" class.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24210?vs=66798=66864

BRANCH
  fix-mode-menu

REVISION DETAIL
  https://phabricator.kde.org/D24210

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

[Nibaldo González]

nibags updated this revision to Diff 66863.
nibags added a comment.


  - Undo changes in Mustache

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24211?vs=66799=66863

BRANCH
  add-syntax-srt

REVISION DETAIL
  https://phabricator.kde.org/D24211

AFFECTED FILES
  autotests/folding/test.srt.fold
  autotests/html/test.srt.html
  autotests/input/test.srt
  autotests/reference/test.srt.ref
  data/syntax/html.xml
  data/syntax/markdown.xml
  data/syntax/subrip-subtitles.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Can you please provide an example which:
  
  - is currently indexed though it should be skipped due to size
  - is skipped after this change
  
  and another example which:
  
  - is currently skipped though it should be indexed
  - is indexed after this change

INLINE COMMENTS

> app.cpp:184
> +// have trouble processing them
> +if ((ex->extractorProperties()["Name"].toString() == 
> QLatin1String("PlaintextExtractor")) && (filesize >= 10 * 1024 * 1024)) {
> +qCWarning(BALOO) << "Skipping" << url << ": large plain text 
> file";

You should compare for size first, as that's much cheaper than fetching the 
property and comparing  the string.

> app.cpp:185
> +if ((ex->extractorProperties()["Name"].toString() == 
> QLatin1String("PlaintextExtractor")) && (filesize >= 10 * 1024 * 1024)) {
> +qCWarning(BALOO) << "Skipping" << url << ": large plain text 
> file";
> +continue;

Users will love us for spammig the logs ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  improve-large-text-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D24185: Add format-text-underline-squiggle actions icons

[Nathaniel Graham]

ngraham added a comment.


  Not the butt ends are gone again. :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24185

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

Re: Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129083/
---

(Updated Sept. 25, 2019, 8:29 p.m.)


Status
--

This change has been discarded.


Review request for Dolphin, KDE Frameworks and David Edmundson.


Bugs: 369640
https://bugs.kde.org/show_bug.cgi?id=369640


Repository: kiconthemes


Description
---

Keeps them from being painted outside view and scales them with the image 
they're supposed to be painted on.


Diffs
-

  src/kiconloader.cpp 5315ea4 


Diff: https://git.reviewboard.kde.org/r/129083/diff/3/


Testing
---

Ran dolphin with device pixel ratio 2, got my symolic link icon again.
Ran it with device pixel ratio 1, looked as it did before.

(couldn't figure out why the VCS icons don't show up though)


Thanks,

Kai Uwe Broulik

D24227: Add colorful preferences-desktop-filter icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:63b9438be1e4: Add colorful preferences-desktop-filter 
icon (authored by GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24227?vs=66839=66846

REVISION DETAIL
  https://phabricator.kde.org/D24227

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-filter.svg
  icons/preferences/32/preferences-desktop-filter.svg

To: GB_2, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D24227: Add colorful preferences-desktop-filter icon

[Björn Feber]

GB_2 updated this revision to Diff 66839.
GB_2 added a comment.


  Make bottom hard show slightly stronger

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24227?vs=66838=66839

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24227

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-filter.svg
  icons/preferences/32/preferences-desktop-filter.svg

To: GB_2, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

Re: Proposing Quick Charts as a new framework

[Friedrich W. H. Kossebau]

Am Mittwoch, 18. September 2019, 11:50:58 CEST schrieb Arjen Hiemstra:
> On 09-09-2019 10:24, Dominik Haumann wrote:
> > Hi,
> > 
> > On Sat, Sep 7, 2019 at 3:59 PM Arjen Hiemstra 
> > 
> > wrote:
> >> On 06-09-2019 02:49, Aleix Pol wrote:
> >>> On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra
> >> 
> >> 
> >> 
> >>> wrote:
>  On 02-09-2019 19:26, Luigi Toscano wrote:
> > Arjen Hiemstra ha scritto:
> > [...]
> > 
>  That's actually a good point, though the kf5 is only in the
> >> 
> >> repository
> >> 
>  name, I
>  name it "Quick Charts" everywhere else. Which is probably a good
>  reason
>  to have
>  the repo name changed in the first place. :) Originally, I put
> >> 
> >> kf5 in
> >> 
>  the repo
>  name because that's what is used once installed as part of
> >> 
> >> Frameworks,
> >> 
>  but I
>  agree that it can lead to confusing things.
> >>> 
> >>> It should be called kquickchart (which indeed is far too similar
> >> 
> >> to
> >> 
> >>> kqtquickcharts). Much like you use KF5CoreAddons, but the
> >> 
> >> repository
> >> 
> >>> is called kcoreaddons.
> >> 
> >> To be fair, KCoreAddons is called KCoreAddons in its documentation,
> >> so
> >> it
> >> does not seem to be called "CoreAddons". At the same time, there are
> >> 
> >> plenty
> >> of Frameworks that do not start with a K, like Solid, Prison or
> >> BluezQt.
> >> So I do not really see why it should be "kquickcharts".
> > 
> > Just my 2 cents:
> > 
> > The reason is consistency. Don't underestimate consistency. We have
> > done naming mistakes from time to time, but that should not imply
> > we should do it again.
> > 
> > +1 for KQuickCharts, names do matter.
> 
> At the same time, I could argue that we are trying to move away from k-
> names in applications and might want to do the same for other parts of
> KDE.

When moving away from k-names one still needs to come up with unique 
memorialize names. Which is a challenge.
Using patterns for names, especially when they are for items in a collection, 
helps a lot. Just remember how we like Qt API because almost all methods can 
be guessed from patterns. When using patterns based on generic terms, one 
though also need to think of proper namespacing, to avoid conflicts or 
ambiguity.

Prison, Sonnet, Plasma, Kirigami, Solid, Baloo, Purpose... for each those 
modules you first have to learn what they are about. This can make sense to 
expect for high-profile modules, as they are used often enough, so their names 
will become mapped in brains properly to the functionality the named products 
provide.

But just imagine that all >50 KF modules had such fantasy-born names...

For the others, having a pattern like "K" + english generic description terms 
helps a lot, both in discoverability and understanding the scope. As well as 
attributing the module to be part of "KDE Frameworks". (actually, using "KF" 
as prefix might be even more interesting when it comes to marketing, perhaps 
an idea to pick up starting with the 6 series).

Also, any numbers for versioning should not be part of the basic product name, 
but for products part of a the development series. Like "KDE Frameworks" is 
not named "KDE Frameworks 5" in general, but the "5" only used when denoting 
the current technology series. When people say "KF5", that is a shortcut for 
"technology series 5 of the KDE Frameworks".

Using "Quick Charts" as identifier name would be even more a challenge. 
Somebody hearing/seeing that name would never be able to attribute this to 
anything, unless the context had been properly set up. Just try to query your 
$searchengine for such a name ;) Even in Qt context, there will be always 
doubt if not the QML variant of Qt Charts is meant in an informal descriptive 
way.

So +1 for KQuickCharts, that identifier name would serve lots of purposes (and 
respective repository name)

And yes, there is e.g. the repo name "syntax-highlighting". This was catched 
too late when the module was added to KDE Frameworks, things only got fixed in 
time at least on code level. "Syndication" and modemmanager-qt/networkmanager-
qt/bluez-qt ideally also would be changed to be consistent with the rest. But 
those are exceptions no-one has energy/motivation to fix up now. No reason to 
make life more complicated by new exceptions from rules :)

Other than that:
that library sounds like good work from description, thanks for going to share 
with the world under fair conditions :) (no personal needs currently, so also 
cannot judge about feasibility & overlap with other options)

Cheers
Friedrich

D24227: Add colorful preferences-desktop-filter icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM!

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24227

To: GB_2, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D24227: Add colorful preferences-desktop-filter icon

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 406900
  F7431167: preferences-desktop-filter Icon.png 


TEST PLAN
  Search for `preferences-desktop-filter` in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24227

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-filter.svg
  icons/preferences/32/preferences-desktop-filter.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24226: bitbake: handle embedded shell and python

[Mark Nauwelaerts]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:53187de4a78a: bitbake: handle embedded shell and python 
(authored by mnauwelaerts).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24226?vs=66835=66837

REVISION DETAIL
  https://phabricator.kde.org/D24226

AFFECTED FILES
  autotests/folding/test.bb.fold
  autotests/html/test.bb.html
  autotests/input/test.bb
  autotests/reference/test.bb.ref
  data/syntax/bitbake.xml

To: mnauwelaerts, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D24226: bitbake: handle embedded shell and python

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable + has test => accept ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  syntax-bitbake (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24226

To: mnauwelaerts, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D24226: bitbake: handle embedded shell and python

[Mark Nauwelaerts]

mnauwelaerts created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
mnauwelaerts requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  syntax-bitbake (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24226

AFFECTED FILES
  autotests/folding/test.bb.fold
  autotests/html/test.bb.html
  autotests/input/test.bb
  autotests/reference/test.bb.ref
  data/syntax/bitbake.xml

To: mnauwelaerts
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

[Dominik Haumann]

dhaumann added a comment.


  I'd indeed prefer another/separate diff. :)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24211

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: Proposing Quick Charts as a new framework

[David Edmundson]

One area of overlap not mentioned yet is KDeclarative::Plotter

KDeclarative::Plotter is something we found we had to create in Plasma
as the existing solutions didn't cover simple use cases or high
refresh rate well at all.

This framework absolutely overlaps with that, which is a good thing as
we want to split KDeclarative up and the current plotter
implementation has been repeatedly problematic.

I can say that this framework acts as a good replacement for those
existing places as well as the other custom pie chart code in the
system load viewer applets.

David

D23879: Add Qt Designer icon symlink

[Björn Feber]

GB_2 planned changes to this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23879

To: GB_2, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23857: Honor global animation speed factor

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d5a5d07f0f89: Honor global animation speed factor 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23857?vs=65804=66828

REVISION DETAIL
  https://phabricator.kde.org/D23857

AFFECTED FILES
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24185

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 66827.
trickyricky26 added a comment.
This revision is now accepted and ready to land.


  - Use sine wave as suggested by ndavis

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24185?vs=66778=66827

BRANCH
  arcpatch-D24185

REVISION DETAIL
  https://phabricator.kde.org/D24185

AFFECTED FILES
  icons-dark/actions/16/format-text-underline-squiggle.svg
  icons-dark/actions/22/format-text-underline-squiggle.svg
  icons/actions/16/format-text-underline-squiggle.svg
  icons/actions/22/format-text-underline-squiggle.svg

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23857: Honor global animation speed factor

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23857

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D23927#537585 , @vkrause wrote:
  
  > Moving even more towards a QIcon rather than a QPixmap API is a good thing 
for sure, I agree on that. I don't think going back is justified here though, 
especially since the QIcon-based API improves high DPI scalability support. If 
it's decided to revert this nevertheless, please note that this has a ripple 
effect on the frameworks already depending on this.
  
  
  The commit & its message claims to "Improve naming of KTitleWidget icon 
methods", which it does not. It is now actually resulting in wrong expectations.
  
  Using a QIcon as pixmap provider engine surely makes sense. That is why the 
old API had those overloads. But the method does not set an icon, it sets the 
pixmap by immediately having the QIcon generating the pixmap and then 
discarding the QIcon object. Which means, if the title widget gets scaled e..g 
by setting another level, the API user had no gain by passing a QIcon object.
  
  Please add a respective disclaimer to the API documentation for now, as the 
current documentation is misleading, as I can tell you by experience :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23927

To: vkrause, dfaure
Cc: kossebau, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

[Volker Krause]

vkrause added a comment.


  In D23927#537583 , @kossebau wrote:
  
  > When going to adapt some code to follow the deprecation, I now look though 
at some inconsistency in the API:
  >
  > - KTitleWidget has a property "pixmap"
  > - the `setPixmap` methods all set this pixmap, with overloads for 
convenience
  > - `setIcon` is without a getter and a documented property, the relation to 
the pixmap property is unclear just by the API names
  >
  >   With this in mind, I fear I consider this change a regression in API 
quality. I'd propose to revert this, or go the full mile and make "icon" a real 
property, deprecating the pixmap one. What do you think?
  
  
  Moving even more towards a QIcon rather than a QPixmap API is a good thing 
for sure, I agree on that. I don't think going back is justified here though, 
especially since the QIcon-based API improves high DPI scalability support. If 
it's decided to revert this nevertheless, please note that this has a ripple 
effect on the frameworks already depending on this.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23927

To: vkrause, dfaure
Cc: kossebau, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

[Friedrich W. H. Kossebau]

kossebau added a comment.


  When going to adapt some code to follow the deprecation, I now look though at 
some inconsistency in the API:
  
  - KTitleWidget has a property "pixmap"
  - the `setPixmap` methods all set this pixmap, with overloads for convenience
  - `setIcon` is without a getter and a documented property, the relation to 
the pixmap property is unclear just by the API names
  
  With this in mind, I fear I consider this change a regression in API quality. 
I'd propose to revert this, or go the full mile and make "icon" a real 
property, deprecating the pixmap one. What do you think?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23927

To: vkrause, dfaure
Cc: kossebau, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23951: Improve desktop layout and panel editing UX

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23951

To: GB_2, #plasma, #vdg, mart
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, 
bruns

D24220: [src/ioslaves/*] replace deprecated foreach with range for

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  The code compiles and passes all unit tests

REPOSITORY
  R241 KIO

BRANCH
  ahmad/foreach-ioslaves2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24220

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/http/http_cache_cleaner.cpp
  src/ioslaves/http/httpauthentication.cpp
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/ioslaves/http/kcookiejar/kcookieserver.cpp
  src/ioslaves/trash/trashimpl.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24217: [src/ioslaves/*] replace deprecated foreach with range for

[Ahmad Samir]

ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  git branch mess up on my end, will submit again after cleaning.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24217

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24217: [src/ioslaves/*] replace deprecated foreach with range for

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  The code compiles and passes all unit tests

REPOSITORY
  R241 KIO

BRANCH
  ahmad/foreach-ioslaves (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24217

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/http/http_cache_cleaner.cpp
  src/ioslaves/http/httpauthentication.cpp
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/ioslaves/http/kcookiejar/kcookieserver.cpp
  src/ioslaves/trash/trashimpl.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 planned changes to this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24185: Add format-text-underline-squiggle actions icons

[TrickyRicky]

trickyricky26 added a comment.


  In D24185#537365 , @ndavis wrote:
  
  > I have some improvements to the squiggle, but unfortunately, I have no 
internet in my house except on my phone until the 27th.
  >
  > basically, I
  >
  > - made a rectangle
  > - gave it a stroke
  > - shrunk the height to fit in the 12x3 area under the U
  > - used the function plotter to generate a sine wave
  >   - adjusted the width and function x/y parameters of the function plotter 
until I got exactly the right length from the low point (left) to the high 
point (right)
  > - converted the stroke to a path
  > - cut it at the low point (left)/high point (right)
  > - simplified the path
  >
  >   this probably could have been simpler
  
  
  I tried to do this with a Sine wave, but I couldn't get it to generate a 
fitting wave, so I guess I abandoned that approach prematurely. I'll try again 
with some of your parameters.

REPOSITORY
  R266 Breeze Icons

BRANCH
  format-text-underline-squiggle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24185

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Igor Poboiko]

poboiko marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23787

To: poboiko, #baloo, bruns, ngraham
Cc: broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D23787: [baloo_file_extractor] Improve handling of large plain-text files

[Igor Poboiko]

poboiko updated this revision to Diff 66805.
poboiko added a comment.


  Address raised issue: fetch file size only once

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23787?vs=65646=66805

BRANCH
  improve-large-text-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23787

AFFECTED FILES
  src/file/extractor/app.cpp

To: poboiko, #baloo, bruns, ngraham
Cc: broulik, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, 
abrahams

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

[Nibaldo González]

nibags added a comment.


  Sorry, that could go in another diff.
  In the definition of Mustashe, I realized that using WordDetect requires a 
delimiter before `` doesn't match the 
WordDetect rule, so I changed it to RegExpr.
  
  In HTML, I only put the Tags in a different context to make it simpler to 
include in other languages, such as Markdown and this new one.
  
  This highlighting depends on HTML, since the tags are inserted, and HTML has 
kateversion 5.53

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24211

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> subrip-subtitles.xml:22
> +  version="1"
> +  kateversion="5.53"
> +  section="Other"

What feature do you use to require 5.53 instead of 5.0?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24211

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

[Dominik Haumann]

dhaumann added a comment.


  There are also changes in other xml files. Are these intentional? E.g. the 
changes from WordDetect to RegExpr seem suspicious.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24211

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24210: KadeModeMenuList: fix memory leaks and others

[Christoph Cullmann]

cullmann added a comment.


  I must confess the m_searchName deletion condition seems for me too be overly 
complex.
  Given QString copying is cheap, can't we just always set that and store it 
inline as value?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D24210

To: nibags, #ktexteditor, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Add highlighting for the classic .SRT subtitle files.
  
  More info:
  http://ale5000.altervista.org/subtitles.htm

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-syntax-srt

REVISION DETAIL
  https://phabricator.kde.org/D24211

AFFECTED FILES
  autotests/folding/test.srt.fold
  autotests/html/test.srt.html
  autotests/input/test.srt
  autotests/reference/test.srt.ref
  data/syntax/html.xml
  data/syntax/markdown.xml
  data/syntax/mustache.xml
  data/syntax/subrip-subtitles.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24210: KadeModeMenuList: fix memory leaks and others

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  - Remove strings `m_searchName` in the destructor of the ListItem class.
  - Use the same object for transparent colors/icons.
  - Add the `Deselect` flag in item sections.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-mode-menu

REVISION DETAIL
  https://phabricator.kde.org/D24210

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24179: Fix skipOffset with dynamic RegExpr

[Christoph Cullmann]

cullmann accepted this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  d399388 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24179

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann