D24434: Fix include path to kjob.h

2019-10-05 Thread David Hallas 
hallas added a comment.


  @dfaure  - I just found that if you include `KListOpenFilesJob` from e.g. 
Dolphin then it fails because it cannot include `jobs/kjob.h` :(
  
  It would be really nice to have this commit in the coming Frameworks release, 
do you think that is possible?
  
  Sorry for all these late fixes :/

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24434

To: hallas, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24434: Fix include path to kjob.h

2019-10-05 Thread David Hallas 
hallas created this revision.
hallas added reviewers: dfaure, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fix include path to kjob.h. When kcoreaddons is installed all the
  headers files are installed in the same directory, so we shouldn't use
  jobs/ when including files from public header files.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24434

AFFECTED FILES
  src/lib/util/klistopenfilesjob.h

To: hallas, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23800: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-05 Thread Michael Pyne 
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.


  The change looks good and builds in various combinations of CMake options 
(after I installed the changeset from D23789 
). I encountered that excluding deprecated 
components from the build requires a version of x.y.z. (not just x.y) but other 
than that things were straightforward from a developer's perspective.
  
  Once D23789  is in we can commit to 
kcoreaddons.

REPOSITORY
  R244 KCoreAddons

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23800

To: kossebau, #frameworks, mpyne
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24433: Move URL parsing methods from kioslave to query object

2019-10-05 Thread Ismael Asensio 
iasensio created this revision.
iasensio added reviewers: Baloo, meven.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  This allows for query objects generated from `Baloo::Query::fromSearchUrl` to 
use the same URLs parsing as those using the kioslave. 
  Previously, only query urls with `json` format were available, while the 
kioslave could also parse the `query` keyword and simple type urls (e.g. 
`baloosearch://videos`)
  This was preventing the file type to be updated for places panels' default 
search urls (e.g. `baloosearch://videos`)

TEST PLAN
  - Open dolphin searchbar and activate "More Options"
  - Type `baloosearch://images`
  - The type 'Images' gets selected

REPOSITORY
  R293 Baloo

BRANCH
  extend_query_url

REVISION DETAIL
  https://phabricator.kde.org/D24433

AFFECTED FILES
  src/kioslaves/search/kio_search.cpp
  src/lib/query.cpp

To: iasensio, #baloo, meven
Cc: kde-frameworks-devel, #dolphin, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24326: Add syntax highlighting for RenPy (.rpy)

2019-10-05 Thread jonathan poelen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4e278a1c3e47: Add syntax highlighting for RenPy (.rpy) 
(authored by jpoelen).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24326?vs=67235=67358

REVISION DETAIL
  https://phabricator.kde.org/D24326

AFFECTED FILES
  autotests/folding/highlight.rpy.fold
  autotests/html/highlight.rpy.html
  autotests/input/highlight.rpy
  autotests/reference/highlight.rpy.ref
  data/syntax/renpy.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24412: Add edit-line-width icons

2019-10-05 Thread Noah Davis 
ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-line-width-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24431: Restore cursor thumbnailer

2019-10-05 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, fredrik.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Baiscally just find xlib and change the link targets.
  There's no xcb equivalent for plain cursor file loading.
  
  BUG: 387660
  FIXED-IN: 19.12.0

TEST PLAN
  F7523094: Screenshot_20191005_214242.png 

  It doesn't appear to use `Display` for just reading the files, so doesn't 
need any X11 guards? Thumbnails work fine in Dolphin on Wayland.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D24431

AFFECTED FILES
  thumbnail/CMakeLists.txt

To: broulik, #plasma, fredrik
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-05 Thread Kai Uwe Broulik 
broulik added a dependent revision: D24430: [KCModuleLoader] Show error when 
QML fails to load.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24430: [KCModuleLoader] Show error when QML fails to load

2019-10-05 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Currently it just prints a warning to console and shows an empty dialog 
leaving the user wondering.

TEST PLAN
  Depends on D24429 
  F7522827: Screenshot_20191001_225332.png 

  Not pretty but better than nothing :)

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D24430

AFFECTED FILES
  src/kcmoduleloader.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-05 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24429

AFFECTED FILES
  src/quickaddons/configmodule.cpp
  src/quickaddons/configmodule.h

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

2019-10-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/9/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 05 Oct 2019 17:16:43 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed:

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

2019-10-05 Thread Albert Astals Cid 
aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24419

To: vkrause, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-05 Thread Friedrich W. H. Kossebau 
kossebau retitled this revision from "RFC: Use ECMGenerateExportHeader to 
manage deprecated API better" to "Use ECMGenerateExportHeader to manage 
deprecated API better".
kossebau added reviewers: Frameworks, dfaure.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D23802

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-10-05 Thread Friedrich W. H. Kossebau 
kossebau added reviewers: Frameworks, Build System.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau, #frameworks, #build_system
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23800: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-05 Thread Friedrich W. H. Kossebau 
kossebau retitled this revision from "RFC: Use ECMGenerateExportHeader to 
manage deprecated API better" to "Use ECMGenerateExportHeader to manage 
deprecated API better".
kossebau added reviewers: Frameworks, mpyne.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23800

To: kossebau, #frameworks, mpyne
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

2019-10-05 Thread TrickyRicky 
trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Nathaniel Graham 
ngraham added a comment.


  +1 based on the explanation of following the FDO spec more closely. I'll 
leave Frameworks folks to figure out how to untangle the implementation 
details. :)

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ngraham, ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24412: Add edit-line-width icons

2019-10-05 Thread Nathaniel Graham 
ngraham added a comment.


  Much better!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 8 - Still Unstable!

2019-10-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/8/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 05 Oct 2019 14:58:03 +
 Build duration:
1 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed:

D24416: Declare Calendar::Ptr as metatype

2019-10-05 Thread Nicolas Fella 
nicolasfella closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D24416

To: nicolasfella, #frameworks, vkrause

D24416: Declare Calendar::Ptr as metatype

2019-10-05 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  metatype

REVISION DETAIL
  https://phabricator.kde.org/D24416

To: nicolasfella, #frameworks, vkrause

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Luigi Toscano 
ltoscano added a comment.


  I wonder how to untangle this dependency, because a change in Frameworks 
can't (shouldn't?) depend on a change in a consumer (yes, same issues as toys).

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Yunhe Guo 
guoyunhe added a dependency: D24424: Create kf5-network.directory.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Yunhe Guo 
guoyunhe edited the summary of this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Yunhe Guo 
guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24423

To: guoyunhe, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Yunhe Guo 
guoyunhe created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  In freedesktop.org specification, the category is Network. Most applications
  under this category can also be used in local network, like FTP client,
  browsers, P2P clients, cloud storage clients. So I think "Network" is the
  best name for this category.
  
  The "Internet>Terminal" category actually doesn't include anything because it
  doesn't have a `` block. "Terminal" sub-category is already included
  in "System" category. So I removed it.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24423

AFFECTED FILES
  src/applications.menu

To: guoyunhe
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

2019-10-05 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24412: Add edit-line-width icons

2019-10-05 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 67348.
trickyricky26 added a comment.


  - Use design with multiple lines of different thickness

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24412?vs=67319=67348

BRANCH
  add-line-width-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24412

AFFECTED FILES
  icons-dark/actions/16/edit-line-width.svg
  icons-dark/actions/22/edit-line-width.svg
  icons/actions/16/edit-line-width.svg
  icons/actions/22/edit-line-width.svg

To: trickyricky26, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24416: Declare Calendar::Ptr as metatype

2019-10-05 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 67347.
nicolasfella added a comment.


  Revert accidental change

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24416?vs=67330=67347

BRANCH
  metatype

REVISION DETAIL
  https://phabricator.kde.org/D24416

AFFECTED FILES
  src/calendar.h

To: nicolasfella, #frameworks, vkrause

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-05 Thread David Edmundson 
davidedmundson accepted this revision.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson, ngraham
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-05 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

To: GB_2, #frameworks, #vdg, davidedmundson, ngraham
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

2019-10-05 Thread Nathaniel Graham 
ngraham added a comment.


  In D17595#542142 , @meven wrote:
  
  > I received the agreements of all contributors including the original code 
author, to relicense this code and hence upstream it.
  >  It reminds of the importance of signing FLA to KDE e.V.
  >
  > So this is good to follow through the normal review process.
  >  @dfaure
  
  
  I appreciate your doggedness here. It'll be very nice to get this in.
  
  > I would like to add a KF6 TODO : rename the class RenameFileDialog to 
RenameDialog and the class RenameFileDialog to RenameFileOverwrittenDialog or 
similar.
  
  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D7446: [Places panel] Revamp the Recently Saved section

2019-10-05 Thread Nathaniel Graham 
ngraham added a comment.


  Wooh!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

2019-10-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/33/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 05 Oct 2019 12:19:32 +
 Build duration:
1 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-05 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R309:9f4b516eac6b: Move Amusement to Games directory instead 
of Games  Toys (authored by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24384?vs=67310=67343

REVISION DETAIL
  https://phabricator.kde.org/D24384

AFFECTED FILES
  src/applications.menu

To: guoyunhe, #frameworks, #vdg, ngraham
Cc: ltoscano, aacid, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24389: Fix klistopenfilesjob header file not being installed

2019-10-05 Thread David Hallas 
hallas added a comment.


  In D24389#541644 , @dfaure wrote:
  
  > `git tag` doesn't show any 5.63.0-rc* tag yet, so it hasn't been tagged, so 
this commit will be included.
  >
  > (I do that on the first Saturday of the month)
  
  
  Phew :) Glad that this one made it

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24389

To: hallas, dfaure, meven, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24412: Add edit-line-width icons

2019-10-05 Thread TrickyRicky 
trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  In D24412#542056 , @ndavis wrote:
  
  > I think something similar to this line width icon would work well: 
F6304104: Lines.png 
  >  Inkscape uses a similar icon, but for all line styles: F7517386: 
Screenshot_20191004_143517.png 
  
  
  Yeah, that seems like a more obvious choice.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24412

To: trickyricky26, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24416: Declare Calendar::Ptr as metatype

2019-10-05 Thread Volker Krause 
vkrause added a comment.


  Ok as such, but there seem to be unrelated changes to test scripts in this 
commit.

REVISION DETAIL
  https://phabricator.kde.org/D24416

To: nicolasfella, #frameworks, vkrause

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

2019-10-05 Thread Volker Krause 
vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24419

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24046: Allow triggering sort from QML

2019-10-05 Thread Jonah Brüchert 
jbbgameich added a comment.


  why not
  
Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) 
override {
QSortFilterProxyModel::sort(column, order);
}
  
  instead of adding a new function?

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D24046

To: nicolasfella, apol
Cc: jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-05 Thread Björn Feber 
GB_2 updated this revision to Diff 67336.
GB_2 marked 2 inline comments as done.
GB_2 added a comment.


  Address comments

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24415?vs=67329=67336

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24415

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: GB_2, #frameworks, #vdg, davidedmundson
Cc: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks, 
LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Framework for encrypted storage for apps

2019-10-05 Thread Ivan Čukić 
Hi Johan, 

One important question here is how do you want the secrets to be unlocked.
Is the user going to type in some master password every time the otpclient is 
started?

If that is the case, you can use QCA to encrypt and decrypt the data you need
to store securely.

If that is not the case - if you don't want to always ask the user for the 
password, then you can expect quite a complicated story of how to make 
something like kwallet safe.

>  1. (On KDE) these libraries wind up calling dbus. We would like to
> avoid plain text out-of-process communication of secrets, especially
> communication through a 'shared' channel (for obvious reasons).
>  2. In particular with KDE Wallet it was suggested that the wallet
> itself may, in fact, not be encrypted.

Another huge problem of kwallet is that it can not authenticate which 
application is asking for the password. I was told that this could be easier 
to do with flatpaks, but it will still need significant changes to how kwallet 
works.

> Another possible contender is Plasma Vault, but we don't really know
> how that would work in the context of an app, especially a flatpak
> app.

An approach like the one taken in Plasma Vault could work for applications,
but it would (like the QCA option previously mentioned) require the user to
type in the password every time. The problem with using Plasma Vault is
that it works with fuse mounts - so the decrypted data si visible through the 
filesystem. (though, flatpaks could maybe have some solution there as well, 
not my area)

Cheers,
Ivan


-- 
dr Ivan Čukić
KDE, ivan.cu...@kde.org, https://cukic.co/
gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232  07AE 01C6 CE2B FF04 1C12

D17595: Upstream Dolphin's file rename dialog

2019-10-05 Thread Méven Car 
meven added a comment.


  I received the agreements of all contributors including the original code 
author, to relicense this code and hence upstream it.
  It reminds of the importance of signing FLA to KDE e.V.
  
  So this is good to follow through the normal review process.
  @dfaure
  
  I would like to add a KF6 TODO : rename the class RenameFileDialog to 
RenameDialog and the class RenameFileDialog to RenameFileOverwrittenDialog or 
similar.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 247 - Unstable!

2019-10-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/247/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 05 Oct 2019 05:43:45 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfileplacesmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33881/61426)39%
(17086/43774)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9501/9993)47%
(4412/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8665/14477)51%
(4592/8971)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4677/8302)43%
(2022/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1410)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4292)36%
(1303/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 130 - Unstable!

2019-10-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/130/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 05 Oct 2019 05:43:45 +
 Build duration:
22 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_kfileplacesmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33895/61428)39%
(17093/43770)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9501/9993)47%
(4404/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8669/14477)51%
(4602/8971)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4682/8303)43%
(2021/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)41%
(387/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1410)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4292)36%
(1303/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%