D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Noah Davis]

ndavis added a comment.


  Why do the gray rectangles have margins around them? I don't like the look 
very much.

REPOSITORY
  R276 KItemViews

BRANCH
  newcategorystyle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, 
#kpublictransport, #amarok, ngraham
Cc: ndavis, ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Noah Davis]

ndavis added a comment.


  In D24453#543063 , @ngraham wrote:
  
  > Nice. Is there any way to make it touch the edges of its parent view rather 
than having those small margins?
  
  
  I would like this. I'm not aware of any place where we use margins around 
alternate list item or header backgrounds.

REPOSITORY
  R276 KItemViews

BRANCH
  newcategorystyle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, 
#kpublictransport, #amarok, ngraham
Cc: ndavis, ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23835: Add TabKCM

[Kai Uwe Broulik]

broulik added a comment.


  Don't use ECMAScript 6 stuff in KDeclarative or plasma-framework! It is a 
Framework which has a minimum version version support of Qt 5.11 (last three, 
5.13, 5.12, 5.11). ECMAScript 6 is only in Qt 5.12

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: broulik, onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

Re: Akonadi SchemaVersionTable is broken with PostgreSQL Version 12 changes

[Harald Sitter]

Hey,

Please file bug reports about issues:
https://bugs.kde.org/enter_bug.cgi?product=Akonadi

On Thu, Oct 10, 2019 at 12:29 AM Stuart  wrote:
>
> Dear development team,
>
> As per the PostgreSQL release documents:
> E.1. Release 12
> https://www.postgresql.org/docs/12/release-12.html#id-1.11.6.5.5
>
> PostgreSQL Version 12 removes:
>
> obsolete pg_constraint.consrc column
> obsolete pg_attrdef.adsrc column
>
>
> Akonadi executes this query that fails due to changes in the PostgreSQL schema
>
> DB=akonadi USER=akonadi SELECT pg_attribute.attname, 
> pg_attribute.atttypid::int, pg_attribute.attnotnull, pg_attribute.attlen, 
> pg_attribute.atttypmod, pg_attrdef.adsrc FROM pg_class, pg_attribute LEFT 
> JOIN pg_attrdef ON (pg_attrdef.adrelid = pg_attribute.attrelid AND 
> pg_attrdef.adnum = pg_attribute.attnum) WHERE 
> pg_table_is_visible(pg_class.oid) AND pg_class.relname = 'schemaversiontable' 
> AND pg_attribute.attnum > 0 AND pg_attribute.attrelid = pg_class.oid AND 
> pg_attribute.attisdropped = false ORDER BY pg_attribute.attnum
> DB=akonadi USER=akonadi SELECT ERROR:  42703: column pg_attrdef.adsrc does 
> not exist at character 128
> DB=akonadi USER=akonadi SELECT pg_attribute.attname, 
> pg_attribute.atttypid::int, pg_attribute.attnotnull, pg_attribute.attlen, 
> pg_attribute.atttypmod, pg_attrdef.adsrc FROM pg_class, pg_attribute LEFT 
> JOIN pg_attrdef ON (pg_attrdef.adrelid = pg_attribute.attrelid AND 
> pg_attrdef.adnum = pg_attribute.attnum) WHERE 
> pg_table_is_visible(pg_class.oid) AND pg_class.relname = 'schemaversiontable' 
> AND pg_attribute.attnum > 0 AND pg_attribute.attrelid = pg_class.oid AND 
> pg_attribute.attisdropped = false ORDER BY pg_attribute.attnum
> DB=akonadi USER=akonadi ALTER TABLE SchemaVersionTable ADD COLUMN version 
> INTEGER NOT NULL DEFAULT 0
> DB=akonadi USER=akonadi ALTER TABLE ERROR:  42701: column "version" of 
> relation "schemaversiontable" already exists
>
>
> This causes akonadi to repeatedly try to update the SchemaVersionTable and 
> quits with error.
>
> org.kde.pim.akonadiserver: Starting up the Akonadi Server...
> org.kde.pim.akonadiserver: Running DB initializer
> org.kde.pim.akonadiserver: "\nSql error: ERROR:  column \"version\" of 
> relation \"schemaversiontable\" already exists\n(42701) QPSQL: Unable to 
> create query\nQuery: ALTER TABLE SchemaVersionTable ADD COLUMN version 
> INTEGER NOT NULL DEFAULT 0"
> org.kde.pim.akonadiserver: Unable to initialize database.
> org.kde.pim.akonadiserver: Shutting down AkonadiServer...
>
>
> The schema information for these dropped columes can be obtained using the 
> functions
>
> pg_constraint.consrc pg_get_constraintdef(pg_constraint.oid)
> pg_attrdef.adsrc pg_get_expr(pg_attrdef.adbin, pg_class.oid)
>
> So the Akonadi query:
>
> SELECT pg_attribute.attname, pg_attribute.atttypid::int, 
> pg_attribute.attnotnull, pg_attribute.attlen, pg_attribute.atttypmod, 
> pg_attrdef.adsrc
> FROM pg_class, pg_attribute
> LEFT JOIN pg_attrdef ON (pg_attrdef.adrelid = pg_attribute.attrelid AND 
> pg_attrdef.adnum = pg_attribute.attnum)
> WHERE pg_table_is_visible(pg_class.oid)
> AND pg_class.relname = 'schemaversiontable'
> AND pg_attribute.attnum > 0
> AND pg_attribute.attrelid = pg_class.oid
> AND pg_attribute.attisdropped = false ORDER BY pg_attribute.attnum ;
>
> should probably be changed to something like:
>
> SELECT pg_attribute.attname, pg_attribute.atttypid::int, 
> pg_attribute.attnotnull, pg_attribute.attlen, pg_attribute.atttypmod, 
> pg_get_expr(pg_attrdef.adbin, pg_class.oid) AS adsrc
> FROM pg_class
> LEFT JOIN pg_attribute ON ( pg_attribute.attrelid = pg_class.oid )
> LEFT JOIN pg_attrdef ON  ( pg_attrdef.adrelid = pg_attribute.attrelid
>  AND   pg_attrdef.adnum = pg_attribute.attnum )
> WHERE pg_table_is_visible(pg_class.oid)
> AND pg_class.relname = 'schemaversiontable'
> AND pg_attribute.attnum > 0
> AND pg_attribute.attisdropped = false
> ORDER BY pg_attribute.attnum;
>
> This will produce something like the following table:
>
>   attname   | atttypid | attnotnull | attlen | atttypmod | adsrc
> +--+++---+---
>  version|   23 | t  |  4 |-1 | 0
>  generation |   23 | t  |  4 |-1 | 0
> (2 rows)
>

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Jarosław Staniek]

staniek removed a reviewer: KEXI.

REPOSITORY
  R276 KItemViews

BRANCH
  newcategorystyle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kde_edu, #kde_pim, 
#kpublictransport, #amarok, ngraham, #kexi
Cc: ndavis, ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  It could make sense to tweak it so in KF6 `ParentInConstructor=true` it's 
true by default.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24490

To: ervin, #plasma, #frameworks, dfaure, mart, apol
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

[Aleix Pol Gonzalez]

apol added a comment.


  Looks better, it could make sense to add a KF6 TODO/Warning.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24494

To: ervin, #plasma, #frameworks, dfaure, mart
Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

[Kevin Ottens]

ervin added a comment.


  In D24490#544599 , @apol wrote:
  
  > It could make sense to tweak it so in KF6 `ParentInConstructor=true` it's 
true by default.
  
  
  What do you mean by tweak?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24490

To: ervin, #plasma, #frameworks, dfaure, mart, apol
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

[Kevin Ottens]

ervin updated this revision to Diff 67597.
ervin added a comment.


  Add the KF6 comment

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24494?vs=67522&id=67597

REVISION DETAIL
  https://phabricator.kde.org/D24494

AFFECTED FILES
  autotests/kconfigskeletontest.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: ervin, #plasma, #frameworks, dfaure, mart
Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

[Aleix Pol Gonzalez]

apol added a comment.


  #if FRAMEWORK_VERSION < 6
  defaultValue = false
  #else
  defaultValue = true
  #endif
  
  Or at least
  #if FRAMEWORK_VERSION >= 6
  #pragma message Consider enabling ParentInConstructor by default
  #endif
  
  It's just a thought, not necessary.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24490

To: ervin, #plasma, #frameworks, dfaure, mart, apol
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "Add ECMGenerateExportHeaders, for 
improved handling of deprecated API" to "Add ECMGenerateExportHeader, for 
improved handling of deprecated API".

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau, #frameworks, #build_system
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67620.
kossebau marked an inline comment as done.
kossebau added a comment.


  switch to do generation-time decision about deprecated(text) attribute usage
  
  GCC/Clang are mostly ABI-compatible, so mixing and linking of artifacts from
  both compilers can be expected, so headers should be compatible, too. Though
  the compiler versions officially supported for KF (and thus ECM)* both
  support __attribute__ ((__deprecated__(text))), so it can be hardcoded into
  the generated header without triggering incompatibilities.
  On Windows mixing compilers seems not expected, so compiler detected at
  generation time can also be expected at any further header usage time.
  
  - 
https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23789?vs=67584&id=67620

BRANCH
  addgenerateexportheader

REVISION DETAIL
  https://phabricator.kde.org/D23789

AFFECTED FILES
  docs/module/ECMGenerateExportHeader.rst
  modules/ECMGenerateExportHeader.cmake
  tests/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/main.cpp
  
tests/ECMGenerateExportHeaderTest/consumer/testAPI_DISABLE_DEPRECATED_BEFORE_AND_AT.cmake
  tests/ECMGenerateExportHeaderTest/consumer/testAPI_NO_DEPRECATED.cmake
  tests/ECMGenerateExportHeaderTest/format_version/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/format_version/main.cpp
  tests/ECMGenerateExportHeaderTest/library/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/library/library.cpp
  tests/ECMGenerateExportHeaderTest/library/library.hpp
  tests/ECMGenerateExportHeaderTest/library/main.cpp

To: kossebau, #frameworks, #build_system
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24355: TypeScript: update grammar and fixes

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c6f2bd8ba96d: TypeScript: update grammar and fixes 
(authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24355?vs=67588&id=67624

REVISION DETAIL
  https://phabricator.kde.org/D24355

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: Akonadi SchemaVersionTable is broken with PostgreSQL Version 12 changes

[Stuart]

Thanks, Done.

bug 412818
https://bugs.kde.org/show_bug.cgi?id=412818

On Thu, Oct 10, 2019 at 11:53 AM Harald Sitter  wrote:

> Hey,
>
> Please file bug reports about issues:
> https://bugs.kde.org/enter_bug.cgi?product=Akonadi
>
> On Thu, Oct 10, 2019 at 12:29 AM Stuart  wrote:
> >
> > Dear development team,
> >
> > As per the PostgreSQL release documents:
> > E.1. Release 12
> > https://www.postgresql.org/docs/12/release-12.html#id-1.11.6.5.5
> >
> > PostgreSQL Version 12 removes:
> >
> > obsolete pg_constraint.consrc column
> > obsolete pg_attrdef.adsrc column
> >
> >
> > Akonadi executes this query that fails due to changes in the PostgreSQL
> schema
> >
> > DB=akonadi USER=akonadi SELECT pg_attribute.attname,
> pg_attribute.atttypid::int, pg_attribute.attnotnull, pg_attribute.attlen,
> pg_attribute.atttypmod, pg_attrdef.adsrc FROM pg_class, pg_attribute LEFT
> JOIN pg_attrdef ON (pg_attrdef.adrelid = pg_attribute.attrelid AND
> pg_attrdef.adnum = pg_attribute.attnum) WHERE
> pg_table_is_visible(pg_class.oid) AND pg_class.relname =
> 'schemaversiontable' AND pg_attribute.attnum > 0 AND pg_attribute.attrelid
> = pg_class.oid AND pg_attribute.attisdropped = false ORDER BY
> pg_attribute.attnum
> > DB=akonadi USER=akonadi SELECT ERROR:  42703: column pg_attrdef.adsrc
> does not exist at character 128
> > DB=akonadi USER=akonadi SELECT pg_attribute.attname,
> pg_attribute.atttypid::int, pg_attribute.attnotnull, pg_attribute.attlen,
> pg_attribute.atttypmod, pg_attrdef.adsrc FROM pg_class, pg_attribute LEFT
> JOIN pg_attrdef ON (pg_attrdef.adrelid = pg_attribute.attrelid AND
> pg_attrdef.adnum = pg_attribute.attnum) WHERE
> pg_table_is_visible(pg_class.oid) AND pg_class.relname =
> 'schemaversiontable' AND pg_attribute.attnum > 0 AND pg_attribute.attrelid
> = pg_class.oid AND pg_attribute.attisdropped = false ORDER BY
> pg_attribute.attnum
> > DB=akonadi USER=akonadi ALTER TABLE SchemaVersionTable ADD COLUMN
> version INTEGER NOT NULL DEFAULT 0
> > DB=akonadi USER=akonadi ALTER TABLE ERROR:  42701: column "version" of
> relation "schemaversiontable" already exists
> >
> >
> > This causes akonadi to repeatedly try to update the SchemaVersionTable
> and quits with error.
> >
> > org.kde.pim.akonadiserver: Starting up the Akonadi Server...
> > org.kde.pim.akonadiserver: Running DB initializer
> > org.kde.pim.akonadiserver: "\nSql error: ERROR:  column \"version\" of
> relation \"schemaversiontable\" already exists\n(42701) QPSQL: Unable to
> create query\nQuery: ALTER TABLE SchemaVersionTable ADD COLUMN version
> INTEGER NOT NULL DEFAULT 0"
> > org.kde.pim.akonadiserver: Unable to initialize database.
> > org.kde.pim.akonadiserver: Shutting down AkonadiServer...
> >
> >
> > The schema information for these dropped columes can be obtained using
> the functions
> >
> > pg_constraint.consrc pg_get_constraintdef(pg_constraint.oid)
> > pg_attrdef.adsrc pg_get_expr(pg_attrdef.adbin, pg_class.oid)
> >
> > So the Akonadi query:
> >
> > SELECT pg_attribute.attname, pg_attribute.atttypid::int,
> pg_attribute.attnotnull, pg_attribute.attlen, pg_attribute.atttypmod,
> pg_attrdef.adsrc
> > FROM pg_class, pg_attribute
> > LEFT JOIN pg_attrdef ON (pg_attrdef.adrelid = pg_attribute.attrelid AND
> pg_attrdef.adnum = pg_attribute.attnum)
> > WHERE pg_table_is_visible(pg_class.oid)
> > AND pg_class.relname = 'schemaversiontable'
> > AND pg_attribute.attnum > 0
> > AND pg_attribute.attrelid = pg_class.oid
> > AND pg_attribute.attisdropped = false ORDER BY pg_attribute.attnum ;
> >
> > should probably be changed to something like:
> >
> > SELECT pg_attribute.attname, pg_attribute.atttypid::int,
> pg_attribute.attnotnull, pg_attribute.attlen, pg_attribute.atttypmod,
> pg_get_expr(pg_attrdef.adbin, pg_class.oid) AS adsrc
> > FROM pg_class
> > LEFT JOIN pg_attribute ON ( pg_attribute.attrelid = pg_class.oid )
> > LEFT JOIN pg_attrdef ON  ( pg_attrdef.adrelid = pg_attribute.attrelid
> >  AND   pg_attrdef.adnum = pg_attribute.attnum )
> > WHERE pg_table_is_visible(pg_class.oid)
> > AND pg_class.relname = 'schemaversiontable'
> > AND pg_attribute.attnum > 0
> > AND pg_attribute.attisdropped = false
> > ORDER BY pg_attribute.attnum;
> >
> > This will produce something like the following table:
> >
> >   attname   | atttypid | attnotnull | attlen | atttypmod | adsrc
> > +--+++---+---
> >  version|   23 | t  |  4 |-1 | 0
> >  generation |   23 | t  |  4 |-1 | 0
> > (2 rows)
> >
>

D24537: Icons for windy weather

[Carson Black]

cblack created this revision.
cblack added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  There are now icons to represent windy weather.

REPOSITORY
  R266 Breeze Icons

BRANCH
  windy-weather-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24537

AFFECTED FILES
  icons-dark/applets/48/weather-clear-night-wind.svg
  icons-dark/applets/48/weather-clear-wind.svg
  icons-dark/applets/48/weather-clouds-night-wind.svg
  icons-dark/applets/48/weather-clouds-wind.svg
  icons-dark/applets/48/weather-few-clouds-night-wind.svg
  icons-dark/applets/48/weather-few-clouds-wind.svg
  icons-dark/applets/48/weather-many-clouds-wind.svg
  icons-dark/applets/48/weather-overcast-wind.svg
  icons/applets/48/weather-clear-night-wind.svg
  icons/applets/48/weather-clear-wind.svg
  icons/applets/48/weather-clouds-night-wind.svg
  icons/applets/48/weather-clouds-wind.svg
  icons/applets/48/weather-few-clouds-night-wind.svg
  icons/applets/48/weather-few-clouds-wind.svg
  icons/applets/48/weather-many-clouds-wind.svg
  icons/applets/48/weather-overcast-wind.svg

To: cblack, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24537: Icons for windy weather

[Carson Black]

cblack edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24538: [Database] Rework handling environment flags

[Kai Krakow]

hurikhan77 created this revision.
hurikhan77 added a reviewer: ngraham.
hurikhan77 added a project: Baloo.
Herald added a project: Frameworks.
Herald added subscribers: Baloo, kde-frameworks-devel.
hurikhan77 requested review of this revision.

REVISION SUMMARY
  This will keep the code of the following changes simpler to read. It 
introduces no functional change.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24538

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham
Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24538: [Database] Disable read-ahead to prevent thrashing

[Kai Krakow]

hurikhan77 updated this revision to Diff 67627.
hurikhan77 retitled this revision from "[Database] Rework handling environment 
flags" to "[Database] Disable read-ahead to prevent thrashing".
hurikhan77 edited the summary of this revision.
hurikhan77 added a comment.


  Prevent filesystem thrashing in low-mem situations by turning off
  read-ahead. Access patterns of baloo are unlikely to benefit from
  read-ahead and preserving cache is more valuable than reading ahead
  potentially unused data.
  
  In low-memory conditions, the random access patterns of Baloo combined
  with read-ahead tend to dominate the cache. Let Baloo be the slow player
  here, and leave system cache and memory for interactive performance.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24538?vs=67626&id=67627

REVISION DETAIL
  https://phabricator.kde.org/D24538

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham
Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24538: [Database] Disable read-ahead to prevent thrashing

[Kai Krakow]

hurikhan77 abandoned this revision.
hurikhan77 added a comment.


  My submission didn't work as expected...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24538

To: hurikhan77, ngraham
Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24539: [Database] Rework handling environment flags

[Kai Krakow]

hurikhan77 created this revision.
hurikhan77 added a reviewer: ngraham.
hurikhan77 added a project: Baloo.
Herald added a project: Frameworks.
Herald added subscribers: Baloo, kde-frameworks-devel.
hurikhan77 requested review of this revision.

REVISION SUMMARY
  This will keep the code of the following changes simpler to read. It 
introduces no functional change.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham
Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24540: [Database] Disable read-ahead to reduce thrashing

[Kai Krakow]

hurikhan77 created this revision.
hurikhan77 added a reviewer: ngraham.
hurikhan77 added a project: Baloo.
Herald added a project: Frameworks.
Herald added subscribers: Baloo, kde-frameworks-devel.
hurikhan77 requested review of this revision.

REVISION SUMMARY
  Prevent filesystem thrashing in low-mem situations by turning off
  read-ahead. Access patterns of baloo are unlikely to benefit from
  read-ahead and preserving cache is more valuable than reading ahead
  potentially unused data.
  
  In low-memory conditions, the random access patterns of Baloo combined
  with read-ahead tend to dominate the cache. Let Baloo be the slow player
  here, and leave system cache and memory for interactive performance.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24540

AFFECTED FILES
  src/engine/database.cpp

To: hurikhan77, ngraham
Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24540: [Database] Disable read-ahead to reduce thrashing

[Kai Krakow]

hurikhan77 added a dependency: D24539: [Database] Rework handling environment 
flags.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24540

To: hurikhan77, ngraham
Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24539: [Database] Rework handling environment flags

[Kai Krakow]

hurikhan77 added a dependent revision: D24540: [Database] Disable read-ahead to 
reduce thrashing.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham
Cc: kde-frameworks-devel, ngraham, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24537: Icons for windy weather

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24537: Icons for windy weather

[Nathaniel Graham]

ngraham added a comment.


  Nice!
  
  Looks like there are some gaps in the windy overcast icon: F7568360: gaps.png 

  
  Also I wonder if the wind gust lines might look better if they were moved two 
pixels to the right. When there are clouds, the right-most edge lands right on 
top of the right-most edge of the clouds, which muddies the display a bit IMO. 
Like so: F7568370: Screenshot_20191010_122207.png 

  
  (You can kind of see the gaps here too)
  
  Finally the SVGs themselves have some extra shapes used for scratch work 
beyond the bounds of the frame. Those should probably be removed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

[Nathaniel Graham]

ngraham added a comment.


  Also one more thing, sorry: `-wind` should go before `-night` in the night 
versions.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for the icon work. I fear some info here though has been lost: what is 
needed is an icon which describes "windy weather" in general, where we have no 
other info about whether it is cloudy, sunny or not.
  At least by what I understood from D24483 
, the info provided by the weather service 
is "Breezy"/"Windy". Whose meaning might depend on the context of the area & 
season. I have seen this e.g. with New Yorh forecast from NOAA. So to handle 
this in a generic way, as context might be hard to pull in, having an icon 
which just states "windy" would be good to have, not referring to clouds etc.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

[Nathaniel Graham]

ngraham added a comment.


  That was my impression too, but upon further examination, the `noaa_i18n.dat` 
file has strings that indicate windyness in addition to other conditions, and 
if I add a complex conditional to the data engine, I can see that the windy + 
cloudy condition is getting hit (it is in fact windy and partly cloudy today, 
lucky me):
  
  F7568554: Screenshot_20191010_125706.png 

  
  So I think this is fine. For the case where all we get back is "windy", we 
can probably assume a clear sky like we do for the "hot" condition, because if 
there were any clouds, they would have been mentioned.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

[Nathaniel Graham]

ngraham added a dependent revision: D24483: [Weather data engine] Handle windy 
conditions in NOAA backend.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24539: [Database] Rework handling environment flags

[Kai Krakow]

hurikhan77 added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24540: [Database] Disable read-ahead to reduce thrashing

[Kai Krakow]

hurikhan77 added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24540

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D22365: KNotification macOS native support by NSNotificationCenter

[Weixuan Xiao]

Inoki closed this revision.
Inoki added a comment.


  Landed:
  
https://cgit.kde.org/knotifications.git/commit/?id=58caf6ad5b48aa573a6d3b8d3e23e07afce8a03f

REVISION DETAIL
  https://phabricator.kde.org/D22365

To: Inoki, rjvbb, nicolasfella
Cc: lnj, nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24539: [Database] Rework handling environment flags

[Nathaniel Graham]

ngraham added a comment.


  This doesn't apply cleanly on master. Can you rebase it?
  
  Also it would be nice to use `arc` to submit patches: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24539

To: hurikhan77, ngraham, #baloo
Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, 
abrahams

D24540: [Database] Disable read-ahead to reduce thrashing

[Nathaniel Graham]

ngraham added a reviewer: bruns.
ngraham added a subscriber: bruns.
ngraham added a comment.


  @bruns, does this make sense to you?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24540

To: hurikhan77, ngraham, #baloo, bruns
Cc: bruns, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, 
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  To keep the momentum, now going to merge, given there was no objection when I 
pointed out the plan to move forward both here and in the email to 
frameworks-devel.
  I assume no-one has time enough to wrap their brain around this as well 
and/or too many other competing stuff which has more of their interest.
  
  Thanks again @dfaure for your review feedback done here, as result this 
feature should be more useful to all of us.
  Still hoping for more review and feedback post-merge, when people start to 
get in contact :)  Will be eager to shape things some more where needed, 
especially before things get final with 5.64 release.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau, #frameworks, #build_system
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:7b15c20dafc9: Add ECMGenerateExportHeader, for improved 
handling of deprecated API (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23789?vs=67620&id=67653#toc

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23789?vs=67620&id=67653

REVISION DETAIL
  https://phabricator.kde.org/D23789

AFFECTED FILES
  docs/module/ECMGenerateExportHeader.rst
  modules/ECMGenerateExportHeader.cmake
  tests/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/main.cpp
  
tests/ECMGenerateExportHeaderTest/consumer/testAPI_DISABLE_DEPRECATED_BEFORE_AND_AT.cmake
  tests/ECMGenerateExportHeaderTest/consumer/testAPI_NO_DEPRECATED.cmake
  tests/ECMGenerateExportHeaderTest/format_version/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/format_version/main.cpp
  tests/ECMGenerateExportHeaderTest/library/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/library/library.cpp
  tests/ECMGenerateExportHeaderTest/library/library.hpp
  tests/ECMGenerateExportHeaderTest/library/main.cpp

To: kossebau, #frameworks, #build_system
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 67655.
kossebau added a comment.


  tests no longer need to unset KSERVICE_DEPRECATED

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23802?vs=67222&id=67655

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D23802

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/kplugininfotest.cpp
  autotests/kservicetest.cpp
  autotests/kservicetest.h
  src/CMakeLists.txt
  src/kdeinit/ktoolinvocation.cpp
  src/kdeinit/ktoolinvocation.h
  src/plugin/kdbusservicestarter.cpp
  src/plugin/kdbusservicestarter.h
  src/services/kplugininfo.cpp
  src/services/kplugininfo.h
  src/services/kservice.h
  src/sycoca/ksycoca.cpp
  src/sycoca/ksycoca.h
  tests/CMakeLists.txt

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 40 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/40/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Thu, 10 Oct 2019 21:06:55 +
 Build duration:
51 sec and counting
   CONSOLE OUTPUT
  [...truncated 137 lines...][2019-10-10T21:07:45.655Z] BUILD_DISPLAY_NAME= '#40'[2019-10-10T21:07:45.655Z] HUDSON_HOME   = '/home/production/data'[2019-10-10T21:07:45.655Z] ANDROID_NDK_HOST  = 'linux-x86_64'[2019-10-10T21:07:45.655Z] JOB_BASE_NAME = 'kf5-qt5 AndroidQt5.13'[2019-10-10T21:07:45.655Z] PATH  = '/opt/Qt/5.13.1/android_armv7/bin:/opt/kdeandroid-deps/bin:/opt/cmake/bin:/opt/Qt/5.13.1/android_armv7/bin:/opt/android-sdk/tools:/opt/android-sdk/tools/bin:/opt/android-sdk/platform-tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'[2019-10-10T21:07:45.655Z] STANDALONE_EXTRA  = '--stl=libc++ --arch=arm'[2019-10-10T21:07:45.655Z] BUILD_ID  = '40'[2019-10-10T21:07:45.655Z] BUILD_TAG = 'jenkins-Frameworks-kcoreaddons-kf5-qt5 AndroidQt5.13-40'[2019-10-10T21:07:45.655Z] ANDROID_ARCH  = 'arm'[2019-10-10T21:07:45.655Z] JENKINS_URL   = 'https://build.kde.org/'[2019-10-10T21:07:45.655Z] LANG  = 'en_US.UTF-8'[2019-10-10T21:07:45.655Z] QT_PATH   = '/opt/Qt'[2019-10-10T21:07:45.655Z] JOB_URL   = 'https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/'[2019-10-10T21:07:45.655Z] ANDROID_NDK_ROOT  = '/opt/android-ndk'[2019-10-10T21:07:45.655Z] DEBIAN_FRONTEND   = 'noninteractive'[2019-10-10T21:07:45.655Z] BUILD_NUMBER  = '40'[2019-10-10T21:07:45.655Z] SHELL = '/bin/sh'[2019-10-10T21:07:45.655Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/40/display/redirect'[2019-10-10T21:07:45.655Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/display/redirect'[2019-10-10T21:07:45.655Z] ANDROID_SDK_ROOT  = '/opt/android-sdk'[2019-10-10T21:07:45.655Z] STANDALONE_CXX= 'clang++'[2019-10-10T21:07:45.655Z] JOB_NAME  = 'Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.13'[2019-10-10T21:07:45.655Z] PWD   = '/home/user/workspace/Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.13'[2019-10-10T21:07:45.655Z] LC_ALL= 'en_US.UTF-8'[2019-10-10T21:07:45.655Z] JAVA_HOME = '/usr/lib/jvm/java-8-openjdk-amd64'[2019-10-10T21:07:45.656Z] ANDROID_HOME  = '/opt/android-sdk'[2019-10-10T21:07:45.656Z] ANDROID_NDK_TOOLCHAIN_PREFIX = 'arm-linux-androideabi'[2019-10-10T21:07:45.656Z] ANDROID_NDK   = '/opt/android-ndk'[2019-10-10T21:07:45.656Z] CMAKE_PREFIX_PATH = '/home/user/install-prefix:/opt/Qt/5.13.1/android_armv7:/opt/kdeandroid-deps'[2019-10-10T21:07:45.656Z] XDG_DATA_DIRS = '/home/user/install-prefix/share:/opt/kdeandroid-deps/share'[2019-10-10T21:07:45.656Z] LD_LIBRARY_PATH   = '/opt/Qt/5.13.1/android_armv7/lib:/opt/kdeandroid-deps/lib'[2019-10-10T21:07:45.656Z] PKG_CONFIG_PATH   = '/opt/Qt/5.13.1/android_armv7/lib/pkgconfig:/opt/kdeandroid-deps/lib/pkgconfig'[2019-10-10T21:07:45.656Z] QMAKEFEATURES = '/opt/Qt/5.13.1/android_armv7/mkspecs/features'[2019-10-10T21:07:45.656Z] QT_SELECT = 'qt5'[2019-10-10T21:07:45.656Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-10T21:07:45.656Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-10-10T21:07:45.656Z] [2019-10-10T21:07:45.656Z] [2019-10-10T21:07:45.656Z] == Commencing Configuration:[2019-10-10T21:07:45.656Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.13.1/android_armv7;/opt/kdeandroid-deps" -DANDROID_API_LEVEL=21 "/home/user/workspace/Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.13"[2019-10-10T21:07:45.656Z] -- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=[2019-10-10T21:07:45.656Z] -- Android: Targeting API '21' with architecture 'arm', ABI 'armeabi-v7a', and processor 'armv7-a'[2019-10-10T21:07:45.656Z] -- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=[2019-10-10T21:07:45.656Z] -- Android: Selected Clang toolchain 'arm-linux-androideabi-clang' with GCC toolchain 'arm-linux-androideabi-4.9'[2019-10-10T21:07:45.920Z] -- The C compiler identification is Clang 7.0.2[2019-10-10T21:07:46.180Z] -- The CXX compiler identification is

D24468: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  If no-one objets, would be pushing on Monday evening, Oct. 14th.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D24468

To: kossebau, #frameworks, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24467: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  If no-one objects, would be pushing on Monday evening, Oct. 14th.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D24467

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  If no-one objects, would be pushing on Monday evening, Oct. 14th.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  If no-one objects, would be pushing on Monday evening, Oct. 14th.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24465

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  If no-one objects, would be pushing on Monday evening, Oct. 14th.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D23802

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 10 Oct 2019 21:06:56 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/22/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 06 Oct 2019 09:37:25 +
 Build duration:
4 days 11 hr and counting

D23800: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:76d89c91e05f: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23800?vs=67221&id=67662

REVISION DETAIL
  https://phabricator.kde.org/D23800

AFFECTED FILES
  CMakeLists.txt
  autotests/kaboutdatatest.cpp
  autotests/kusertest.cpp
  src/lib/CMakeLists.txt
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h
  src/lib/plugin/kexportplugin.h
  src/lib/plugin/kpluginfactory.cpp
  src/lib/plugin/kpluginfactory.h
  src/lib/util/kuser.h

To: kossebau, #frameworks, mpyne
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> netwm_def.h:336-339
>  /**
> @deprecated has unclear meaning and is KDE-only
>  **/
>  Override = 6, // NON STANDARD

This one should be wrapped in `#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 
0)`, right?

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24465

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> zzag wrote in netwm_def.h:336-339
> This one should be wrapped in `#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 
> 0)`, right?

Hmm... I should have checked the patch after uploading. IIRC I initially had 
this guarded here, same with the OverrideMask, but then found that too much 
code seems to rely on this, so I reverted things and added a TODO: Seemingly 
not the state here, and sadly nothing found in my stash. Sorry, I will have to 
recheck this.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24465

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

[Aleix Pol Gonzalez]

apol added a comment.


  In D22362#493722 , @davidedmundson 
wrote:
  
  > As some background:
  >
  > At a recent Plasma sprint, one comment was that adding protocols to 
KWayland was an absolute pain involving writing a tonne of boiler plate. My 
experience adding a protocol to Qt was relatively painless.
  >
  > We said we'd try on a really simple protocol.
  >
  > IMHO this looks encouraging.
  >
  > Obviously having a mix of styles isn't great, but something has to be first.
  >
  >  
  >
  > One thing we need to resolve is
  >
  > QtWaylandServer::org_kde_kwin_keystate
  >
  >   will call init which will call wl_global_create
  >   
  >
  > Global::Private will call wl_global_create
  >
  > Calling that twice is wrong.
  
  
  I was looking into this and realised it's not really easy to solve. The 
reason is that KWayland::Server::Global was designed to be able to expose the 
wl_global as if it was useful, but this is something you never do. The 
wl_global is private on the generated code so we can't access it. I'll provide 
a workaround for now to keep the conversation alive, but I'd say at least 
`operator wl_global*();` should get deprecated.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D22362

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D22362: Port keystates to use QtWayland's generator

[Aleix Pol Gonzalez]

apol updated this revision to Diff 67670.
apol added a comment.


  Just don't use KWayland::Global
  
  Lets generated code do its thing already

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22362?vs=61478&id=67670

BRANCH
  arcpatch-D22362

REVISION DETAIL
  https://phabricator.kde.org/D22362

AFFECTED FILES
  CMakeLists.txt
  src/client/CMakeLists.txt
  src/client/keystate.cpp
  src/server/CMakeLists.txt
  src/server/global_p.h
  src/server/keystate_interface.cpp
  src/server/keystate_interface.h

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 122 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/122/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 10 Oct 2019 23:05:47 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 8 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiofilewidgets_kurlnavigatortestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltersearchprovideractionstestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22362: Port keystates to use QtWayland's generator

[Aleix Pol Gonzalez]

apol updated this revision to Diff 67671.
apol added a comment.


  Unnecessary change

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22362?vs=67670&id=67671

BRANCH
  arcpatch-D22362

REVISION DETAIL
  https://phabricator.kde.org/D22362

AFFECTED FILES
  CMakeLists.txt
  src/client/CMakeLists.txt
  src/client/keystate.cpp
  src/server/CMakeLists.txt
  src/server/keystate_interface.cpp
  src/server/keystate_interface.h

To: apol, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 252 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/252/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 10 Oct 2019 23:05:48 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiofilewidgets_kurlnavigatortestFailed: projectroot.autotests.kiowidgets_kurifiltersearchprovideractionstestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report53%
(19/36)61%
(246/403)61%
(246/403)51%
(30996/61266)36%
(15593/43774)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(53/57)93%
(53/57)90%
(8965/9971)45%
(4259/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core85%
(100/117)85%
(100/117)59%
(8501/14463)50%
(4519/8971)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets66%
(25/38)66%
(25/38)48%
(3983/8270)35%
(1650/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)41%
(387/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1410)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4292)36%
(1303/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 135 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/135/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 10 Oct 2019 23:05:48 +
 Build duration:
26 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiofilewidgets_kurlnavigatortestFailed: projectroot.autotests.kiowidgets_kurifiltersearchprovideractionstestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report53%
(19/36)61%
(246/403)61%
(246/403)51%
(30999/61266)36%
(15581/43770)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(53/57)93%
(53/57)90%
(8965/9971)45%
(4255/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core85%
(100/117)85%
(100/117)59%
(8505/14463)50%
(4515/8971)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets66%
(25/38)66%
(25/38)48%
(3982/8270)35%
(1647/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1410)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4292)36%
(1303/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
  

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/33/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 00:21:58 +
 Build duration:
3 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 41 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/41/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Fri, 11 Oct 2019 01:22:07 +
 Build duration:
1 min 14 sec and counting

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/40/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 01:22:07 +
 Build duration:
3 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/12/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:24:26 +
 Build duration:
2 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/34/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:24:28 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/13/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:24:28 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: projectroot.autotests.Re

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/37/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:24:29 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/18/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:24:29 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/14/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:24:32 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/14/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:24:35 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/61/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 11 Oct 2019 02:48:15 +
 Build duration:
28 min and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.63.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)22%
(449/2045)18%
(170/947)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(143/156)53%
(53/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)61%
(23/38)src.plugins.telegram0%
(0

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/25/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:25:06 +
 Build duration:
57 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 127 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/127/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 11 Oct 2019 03:32:12 +
 Build duration:
9 min 37 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.63.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)22%
(457/2046)18%
(172/947)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(147/156)54%
(54/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)61%
(23/38)src.plugins.telegram0%
  

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 44 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/44/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 11 Oct 2019 02:48:50 +
 Build duration:
59 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.63.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6885/9076)43%
(10769/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2872/2964)48%
(6171/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/41/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:25:27 +
 Build duration:
1 hr 33 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/23/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:25:28 +
 Build duration:
1 hr 46 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 62 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/62/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 11 Oct 2019 03:32:12 +
 Build duration:
42 min and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.63.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)23%
(461/2046)19%
(178/947)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)60%
(60/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)61%
(23/38)src.plugins.telegram0%
(0/1)0%
 

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 24 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/24/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 11 Oct 2019 02:48:54 +
 Build duration:
1 hr 27 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.63.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModelFailed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)89%
(238/268)89%
(238/268)82%
(26121/31964)51%
(10396/20544)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)94%
(11827/12527)48%
(6206/13047)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client95%
(72/76)95%
(72/76)81%
(6028/7449)59%
(1673/2828)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)84%
(7812/9332)64%
(2340/3678)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 123 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/123/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:25:29 +
 Build duration:
1 hr 52 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 11 Oct 2019 02:25:32 +
 Build duration:
1 hr 56 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/25/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 11 Oct 2019 02:49:04 +
 Build duration:
1 hr 36 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KCMUtils-5.63.0.xmlcompat_reports/KF5KCMUtils_compat_report.htmllogs/KF5KCMUtils/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/2)0%
(0/21)0%
(0/21)0%
(0/1703)0%
(0/887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/13)0%
(0/13)0%
(0/1284)0%
(0/710)src.ksettings0%
(0/8)0%
(0/8)0%
(0/419)0%
(0/177)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 136 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/136/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 11 Oct 2019 02:48:54 +
 Build duration:
1 hr 39 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.63.0.xmllogs/KF5KIO/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33921/61426)39%
(17132/43770)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9534/9993)47%
(4446/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8669/14477)51%
(4599/8971)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4680/8302)43%
(2024/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1410)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4292)36%
(1303/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
  

D24554: Don't build static library when BUILD_TESTING=OFF

[Antonio Rojas]

arojas created this revision.
arojas added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Since the static library is only used for autotests, don't waste CPU cycles 
when not building them

TEST PLAN
  Builds with and without BUILD_TESTING

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D24554

AFFECTED FILES
  src/solid/CMakeLists.txt

To: arojas, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

[Kevin Ottens]

ervin added a comment.


  Ah I see what you meant now. I'd rather not do this, it's IMO better if we 
remove the setting completely when KF6 comes.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24490

To: ervin, #plasma, #frameworks, dfaure, mart, apol
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns