D24722: Add an ability to set local name for BLE Advertisement

[Artur Drobinskiy]

arturdrobinskiy created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arturdrobinskiy requested review of this revision.

TEST PLAN
  1. Start ./bin/leserver
  2. Scan for existing BLE devices (e.g. using nRF Connect for Android/iOS)
  3. Check that the name of found device is "LE Server Advertisement" (before 
this patch the name was "N/A")

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D24722

AFFECTED FILES
  src/leadvertisement.cpp
  src/leadvertisement.h
  src/leadvertisement_p.cpp
  src/leadvertisement_p.h
  src/leadvertisementadaptor.cpp
  src/leadvertisementadaptor.h
  tests/leserver.cpp

To: arturdrobinskiy
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24487: fix password error condition handling of smb mount

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:45b1327a6dac: fix password error condition handling of 
smb mount (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24487?vs=67483&id=68112

REVISION DETAIL
  https://phabricator.kde.org/D24487

AFFECTED FILES
  smb/kio_smb_mount.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

[David Edmundson]

davidedmundson updated this revision to Diff 68113.
davidedmundson edited the summary of this revision.
davidedmundson removed a reviewer: ervin.
davidedmundson removed a subscriber: ervin.
davidedmundson added a comment.


  Use unique_ptr

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24716?vs=68096&id=68113

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24716

AFFECTED FILES
  src/kcmoduleloader.cpp
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: davidedmundson, #plasma, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, ervin

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

[David Edmundson]

davidedmundson marked 2 inline comments as done.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D24716

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> KDEClangFormat.cmake:53
> +# try to find clang-format in path
> +find_program(KDE_CLANG_FORMAT_EXECUTABLE clang-format)
> +

I'm pretty sure you need to check the version the exectuable. When I use 6.0 I 
get ctors smushed into one line.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24725: GIT_SILENT Fix grammar

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, mpyne.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  text-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24725

AFFECTED FILES
  src/lib/kaboutdata.h

To: ahmadsamir, #frameworks, mpyne
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Looks good to me, I'll accept it but better wait a bit in case others want to 
chip in.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24716

To: davidedmundson, #plasma, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems good to me, but I might not be the best person to approve this.

INLINE COMMENTS

> utils.cpp:355
> +}
> +   if (apRsn.testFlag(NetworkManager::AccessPoint::PairCcmp) &&
> +
> interfaceCaps.testFlag(NetworkManager::WirelessDevice::Ccmp)) {

just a small indentation space error

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24689

To: jgrulich, #frameworks, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24725: Fix grammar

[Aleix Pol Gonzalez]

apol retitled this revision from "GIT_SILENT Fix grammar" to "Fix grammar".

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24725

To: ahmadsamir, #frameworks, mpyne
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24725: Fix grammar

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  text-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24725

To: ahmadsamir, #frameworks, mpyne, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24726: Fix null pointer reference when extraction fails

[Pekka Vuorela]

pvuorela created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pvuorela requested review of this revision.

REPOSITORY
  R243 KArchive

BRANCH
  null_check

REVISION DETAIL
  https://phabricator.kde.org/D24726

AFFECTED FILES
  src/karchive.cpp

To: pvuorela
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24725: Fix grammar

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:b539685e9495: Fix grammar (authored by ahmadsamir).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24725?vs=68118&id=68123

REVISION DETAIL
  https://phabricator.kde.org/D24725

AFFECTED FILES
  src/lib/kaboutdata.h

To: ahmadsamir, #frameworks, mpyne, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/44/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 17 Oct 2019 11:08:22 +
 Build duration:
3 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 48 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/48/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 17 Oct 2019 11:08:26 +
 Build duration:
4 min 6 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.64.0.xmllogs/KF5CoreAddons/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6884/9076)43%
(10766/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2871/2964)48%
(6168/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24716

To: davidedmundson, #plasma, ervin, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:aea58fcca359: Fix memory leak of 
KQuickAddons::ConfigModule objects (authored by davidedmundson).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24716?vs=68113&id=68124

REVISION DETAIL
  https://phabricator.kde.org/D24716

AFFECTED FILES
  src/kcmoduleloader.cpp
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: davidedmundson, #plasma, ervin, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.12 - Build # 63 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/63/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 17 Oct 2019 12:00:14 +
 Build duration:
2 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 308 lines...][2019-10-17T12:02:40.016Z]  * KF5CoreAddons (required version >= 5.63.0)[2019-10-17T12:02:40.016Z]  * ECM (required version >= 1.6.0), Extra CMake Modules., [2019-10-17T12:02:40.016Z]  * KF5Package (required version >= 5.63.0)[2019-10-17T12:02:40.016Z]  * KF5Declarative (required version >= 5.63.0)[2019-10-17T12:02:40.016Z]  * Doxygen (required version >= 1.8.13)[2019-10-17T12:02:40.016Z]Needed for API dox QCH file generation[2019-10-17T12:02:40.016Z]  * QHelpGenerator, Part of Qt5 tools[2019-10-17T12:02:40.016Z]Needed for API dox QCH file generation[2019-10-17T12:02:40.016Z]  * Qt5Core[2019-10-17T12:02:40.016Z] [2019-10-17T12:02:40.016Z] -- Configuring done[2019-10-17T12:02:40.016Z] -- Generating done[2019-10-17T12:02:40.016Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-10-17T12:02:42.352Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcmutils --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-10-17T12:02:42.352Z] Scanning dependencies of target KF5Service_QCH[2019-10-17T12:02:42.352Z] Scanning dependencies of target KF5ConfigWidgets_QCH[2019-10-17T12:02:42.352Z] [  0%] Built target KF5ConfigWidgets_QCH[2019-10-17T12:02:42.352Z] [  0%] Built target KF5Service_QCH[2019-10-17T12:02:42.352Z] Scanning dependencies of target KF5Auth_QCH[2019-10-17T12:02:42.352Z] Scanning dependencies of target KF5CoreAddons_QCH[2019-10-17T12:02:42.352Z] [  0%] Built target KF5Auth_QCH[2019-10-17T12:02:42.352Z] [  0%] Built target KF5CoreAddons_QCH[2019-10-17T12:02:42.352Z] Scanning dependencies of target KF5Codecs_QCH[2019-10-17T12:02:42.352Z] [  0%] Built target KF5Codecs_QCH[2019-10-17T12:02:42.352Z] Scanning dependencies of target KF5Config_QCH[2019-10-17T12:02:42.352Z] [  0%] Built target KF5Config_QCH[2019-10-17T12:02:42.352Z] Scanning dependencies of target KF5WidgetsAddons_QCH[2019-10-17T12:02:42.352Z] [  0%] Built target KF5WidgetsAddons_QCH[2019-10-17T12:02:42.352Z] Scanning dependencies of target KF5KCMUtils_autogen[2019-10-17T12:02:42.352Z] [  6%] Automatic MOC for target KF5KCMUtils[2019-10-17T12:02:42.352Z] Scanning dependencies of target KF5KCMUtils_QCH[2019-10-17T12:02:42.352Z] [ 12%] Generating src/KF5KCMUtils.qch, src/KF5KCMUtils.tags[2019-10-17T12:02:44.019Z] [ 12%] Built target KF5KCMUtils_autogen[2019-10-17T12:02:44.519Z] Scanning dependencies of target KF5KCMUtils[2019-10-17T12:02:44.519Z] [ 18%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/KF5KCMUtils_autogen/mocs_compilation.cpp.o[2019-10-17T12:02:45.017Z] Building up file structure...[2019-10-17T12:02:45.017Z] Insert custom filters...[2019-10-17T12:02:45.017Z] Insert help data for filter section (1 of 1)...[2019-10-17T12:02:45.017Z] Insert files...[2019-10-17T12:02:45.017Z] Insert contents...[2019-10-17T12:02:45.017Z] Insert indices...[2019-10-17T12:02:45.017Z] Documentation successfully generated.[2019-10-17T12:02:45.017Z] [ 18%] Built target KF5KCMUtils_QCH[2019-10-17T12:02:45.017Z] [ 25%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleinfo.cpp.o[2019-10-17T12:02:46.675Z] [ 31%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleloader.cpp.o[2019-10-17T12:02:47.173Z] [ 37%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleqml.cpp.o[2019-10-17T12:02:47.672Z] In file included from /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.12/src/kcmoduleloader.cpp:25:[2019-10-17T12:02:47.672Z] /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.12/src/kcmoduleqml_p.h:36:32: error: expected ���)��� before ���<��� token[2019-10-17T12:02:47.672Z]36 | KCModuleQml(std::unique_ptr configModule, QWidget* parent, const QVariantList& args);[2019-10-17T12:02:47.672Z]   |~   ^[2019-10-17T12:02:47.672Z]   |)[2019-10-17T12:02:47.672Z] /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.12/src/kcmoduleqml_p.h:54:31: warning: non-static const member ���KCModuleQmlPrivate* const KCModuleQml::d��� in class without a constructor [-Wuninitialized][2019-10-17T12:02:47.672Z]54 | KCModuleQmlPrivate *const d;[2019-10-17T12:02:47.672Z]   |   ^[2019-10-17T12:02:48.170Z] In file included from /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.12/src/kcmoduleqml.cpp:19:[2019-10-17T12:02:48.170Z] /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.12/src/kcmoduleqml_p.h:36:32: error: expected ���)��� before ���<��� token[2019-10-17T12:02:48.170Z]36 | K

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 28 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/28/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 17 Oct 2019 12:00:13 +
 Build duration:
3 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 328 lines...][2019-10-17T12:03:03.988Z] Scanning dependencies of target KF5Auth_QCH[2019-10-17T12:03:03.988Z] Scanning dependencies of target KF5Codecs_QCH[2019-10-17T12:03:03.988Z] Scanning dependencies of target KF5Service_QCH[2019-10-17T12:03:03.988Z] Scanning dependencies of target KF5ConfigWidgets_QCH[2019-10-17T12:03:03.988Z] Scanning dependencies of target KF5Config_QCH[2019-10-17T12:03:03.988Z] [  0%] Built target KF5CoreAddons_QCH[2019-10-17T12:03:03.988Z] [  0%] Built target KF5Auth_QCH[2019-10-17T12:03:03.988Z] [  0%] Built target KF5Codecs_QCH[2019-10-17T12:03:03.988Z] [  0%] Built target KF5Service_QCH[2019-10-17T12:03:03.988Z] [  0%] Built target KF5ConfigWidgets_QCH[2019-10-17T12:03:03.988Z] [  0%] Built target KF5Config_QCH[2019-10-17T12:03:03.988Z] Scanning dependencies of target KF5WidgetsAddons_QCH[2019-10-17T12:03:03.988Z] Scanning dependencies of target KF5KCMUtils_autogen[2019-10-17T12:03:03.988Z] [  0%] Built target KF5WidgetsAddons_QCH[2019-10-17T12:03:03.988Z] [  6%] Automatic MOC for target KF5KCMUtils[2019-10-17T12:03:03.988Z] Scanning dependencies of target KF5KCMUtils_QCH[2019-10-17T12:03:03.988Z] [ 12%] Generating src/KF5KCMUtils.qch, src/KF5KCMUtils.tags[2019-10-17T12:03:12.947Z] Building up file structure...[2019-10-17T12:03:12.947Z] Insert custom filters...[2019-10-17T12:03:12.947Z] Insert help data for filter section (1 of 1)...[2019-10-17T12:03:12.947Z] Insert files...[2019-10-17T12:03:12.947Z] Insert contents...[2019-10-17T12:03:12.947Z] Insert indices...[2019-10-17T12:03:12.947Z] Documentation successfully generated.[2019-10-17T12:03:12.947Z] [ 12%] Built target KF5KCMUtils_QCH[2019-10-17T12:03:13.991Z] [ 12%] Built target KF5KCMUtils_autogen[2019-10-17T12:03:20.092Z] Scanning dependencies of target KF5KCMUtils[2019-10-17T12:03:20.092Z] [ 25%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/KF5KCMUtils_autogen/mocs_compilation.cpp.o[2019-10-17T12:03:20.092Z] [ 25%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleinfo.cpp.o[2019-10-17T12:03:20.092Z] [ 31%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleloader.cpp.o[2019-10-17T12:03:20.092Z] [ 37%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmultidialog.cpp.o[2019-10-17T12:03:20.092Z] [ 43%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleqml.cpp.o[2019-10-17T12:03:20.092Z] [ 50%] Building CXX object src/CMakeFiles/KF5KCMUtils.dir/kcmoduleproxy.cpp.o[2019-10-17T12:03:22.462Z] In file included from /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.13/src/kcmultidialog.cpp:28:[2019-10-17T12:03:22.462Z] /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.13/src/kcmoduleqml_p.h:36:32: error: expected ���)��� before ���<��� token[2019-10-17T12:03:22.462Z]36 | KCModuleQml(std::unique_ptr configModule, QWidget* parent, const QVariantList& args);[2019-10-17T12:03:22.462Z]   |~   ^[2019-10-17T12:03:22.462Z]   |)[2019-10-17T12:03:22.462Z] /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.13/src/kcmoduleqml_p.h:54:31: warning: non-static const member ���KCModuleQmlPrivate* const KCModuleQml::d��� in class without a constructor [-Wuninitialized][2019-10-17T12:03:22.462Z]54 | KCModuleQmlPrivate *const d;[2019-10-17T12:03:22.462Z]   |   ^[2019-10-17T12:03:22.462Z] In file included from /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.13/src/kcmoduleloader.cpp:25:[2019-10-17T12:03:22.462Z] /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.13/src/kcmoduleqml_p.h:36:32: error: expected ���)��� before ���<��� token[2019-10-17T12:03:22.462Z]36 | KCModuleQml(std::unique_ptr configModule, QWidget* parent, const QVariantList& args);[2019-10-17T12:03:22.462Z]   |~   ^[2019-10-17T12:03:22.462Z]   |)[2019-10-17T12:03:22.462Z] /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.13/src/kcmoduleqml_p.h:54:31: warning: non-static const member ���KCModuleQmlPrivate* const KCModuleQml::d��� in class without a constructor [-Wuninitialized][2019-10-17T12:03:22.462Z]54 | KCModuleQmlPrivate *const d;[2019-10-17T12:03:22.462Z]   |   ^[2019-10-17T12:03:22.462Z] In file included from /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.13/src/kcmoduleqml.cpp:19:[2019-10-17T12:03:22.462Z] /home/jenkins/workspace/Frameworks/kcmutils/kf5-qt5 SUSEQt5.13/src/kcmoduleqml_p.h:36:32: error: expected ���)��� before ���<��� token[2019-10-17T12:03:22.462Z]36 | KCModuleQml(std::unique_ptr configModule, QWidget* parent, const QVariantLi

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/29/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 17 Oct 2019 12:04:38 +
 Build duration:
5 min 8 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KCMUtils-5.64.0.xmllogs/KF5KCMUtils/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/2)0%
(0/21)0%
(0/21)0%
(0/1703)0%
(0/889)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/13)0%
(0/13)0%
(0/1284)0%
(0/712)src.ksettings0%
(0/8)0%
(0/8)0%
(0/419)0%
(0/177)

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.12 - Build # 64 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/64/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 17 Oct 2019 12:04:38 +
 Build duration:
6 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KCMUtils-5.64.0.xmllogs/KF5KCMUtils/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/2)0%
(0/21)0%
(0/21)0%
(0/1703)0%
(0/889)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/13)0%
(0/13)0%
(0/1284)0%
(0/712)src.ksettings0%
(0/8)0%
(0/8)0%
(0/419)0%
(0/177)

D24537: Icons for windy weather

[Friedrich W. H. Kossebau]

kossebau added a subscriber: spstarr.
kossebau added a comment.


  Good work with the icons.
  
  Seems there is also need for snow + wind, @vkrause & @spstarr can and 
hopefully tell you more.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24537

To: cblack, #vdg, ndavis, ngraham
Cc: spstarr, trickyricky26, GB_2, vkrause, ndavis, kossebau, ngraham, 
kde-frameworks-devel, LeGast00n, michaelh, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @dfaure Any remaining issues from your side, or is your +1 available as well 
now? :)

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

tcberner updated this revision to Diff 68138.
tcberner added a comment.


  - procstat: add FindProcstat.cmake
  - procstat: add procstat backend
  - procstat: add procstat option
  - procstat: add linkage for procstat backend

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21146?vs=57921&id=68138

BRANCH
  procstat_v3

REVISION DETAIL
  https://phabricator.kde.org/D21146

AFFECTED FILES
  CMakeLists.txt
  cmake/FindProcstat.cmake
  src/lib/CMakeLists.txt
  src/lib/util/kprocesslist_unix_procstat.cpp
  src/lib/util/kprocesslist_unix_procstat_p.h

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

tcberner added a comment.


  @adridg I've addressed your comments [finally].

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

[David Redondo]

davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Otherwise assigning a key combination which is currently bound to a global
  shortcut action will trigger the global shortcut.

TEST PLAN
  Try to assign a global shortcut to KKeySequenceItem. The global shortcut is
  not triggered - instead the steal shortcut prompt is displayed.

REPOSITORY
  R296 KDeclarative

BRANCH
  grabkeyboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24736

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.h

To: davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

[David Redondo]

davidre added a reviewer: Frameworks.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24736

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

[Kai Uwe Broulik]

broulik added a comment.


  Alternatively you could make the `KeySequenceHelper` itself a `QQuickItem` so 
it gets assigned a window.

INLINE COMMENTS

> keysequencehelper.cpp:118
>  QString shortcutDisplay;
> -
> +QQuickItem* keySequenceItem;
>  //! Check the key sequence against KStandardShortcut::find()

Typically store items created by QtQuick in a `QPointer` so we can detect when 
they are garbage collected

> keysequencehelper.h:65
> +READ keySequenceItem
> +WRITE setKeySequenceItem)
>  

this needs a `NOTIFY` argument, corresponding `signal` and `emit` in the setter

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24736

To: davidre, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

[David Redondo]

davidre updated this revision to Diff 68143.
davidre added a comment.


  - Make helper a qquickitem instead

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24736?vs=68142&id=68143

BRANCH
  grabkeyboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24736

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.h

To: davidre, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

[David Redondo]

davidre updated this revision to Diff 68144.
davidre added a comment.


  Whitespace

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24736?vs=68143&id=68144

BRANCH
  grabkeyboard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24736

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.h

To: davidre, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24710: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R301:2f0fffb70604: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R301 KEmoticons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24710?vs=68082&id=68146

REVISION DETAIL
  https://phabricator.kde.org/D24710

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/kemoticonsprovider.cpp
  src/core/kemoticonsprovider.h
  src/core/kemoticonstheme.cpp
  src/core/kemoticonstheme.h

To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure accepted this revision.
dfaure added a comment.


  Yep all good from my point of view.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Adriaan de Groot]

adridg accepted this revision.
adridg added a comment.
This revision is now accepted and ready to land.


  Let's get this in, and then quibble about how much commentary needs to be 
written for the `_p.h` file (since, looking back, it's a bit heavy on the C++ 
fancyness -- my Opinions have changed a little)

REPOSITORY
  R244 KCoreAddons

BRANCH
  procstat_v3

REVISION DETAIL
  https://phabricator.kde.org/D21146

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24495: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R284:adb16c18d98c: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24495?vs=68093&id=68148

REVISION DETAIL
  https://phabricator.kde.org/D24495

AFFECTED FILES
  CMakeLists.txt
  autotests/klineedit_unittest.cpp
  src/CMakeLists.txt
  src/kcombobox.cpp
  src/kcombobox.h
  src/kcompletion.h
  src/kcompletionbase.h
  src/kcompletionbox.h
  src/klineedit.cpp
  src/klineedit.h
  src/ksortablelist.h

To: kossebau, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21146: KProcessInfoList -- add proclist backend for FreeBSD

[Tobias C. Berner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:b1d27cabc2a9: KProcessInfoList -- add proclist backend 
for FreeBSD (authored by tcberner).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21146?vs=68138&id=68151

REVISION DETAIL
  https://phabricator.kde.org/D21146

AFFECTED FILES
  CMakeLists.txt
  cmake/FindProcstat.cmake
  src/lib/CMakeLists.txt
  src/lib/util/kprocesslist_unix_procstat.cpp
  src/lib/util/kprocesslist_unix_procstat_p.h

To: tcberner, #freebsd, adridg, davidedmundson
Cc: pino, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/45/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 17 Oct 2019 14:38:39 +
 Build duration:
2 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich updated this revision to Diff 68156.
jgrulich added a comment.


  - Coding style

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24689?vs=68029&id=68156

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24689

AFFECTED FILES
  src/accesspoint.h
  src/settings/wirelesssecuritysetting.cpp
  src/settings/wirelesssecuritysetting.h
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.h

To: jgrulich, #frameworks, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

jgrulich marked an inline comment as done.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  wpa3

REVISION DETAIL
  https://phabricator.kde.org/D24689

To: jgrulich, #frameworks, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24689: Add support for SAE authentication used by WPA3

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:4a6a5e708077: Add support for SAE authentication used by 
WPA3 (authored by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24689?vs=68156&id=68157

REVISION DETAIL
  https://phabricator.kde.org/D24689

AFFECTED FILES
  src/accesspoint.h
  src/settings/wirelesssecuritysetting.cpp
  src/settings/wirelesssecuritysetting.h
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.h

To: jgrulich, #frameworks, meven
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kactioncollection.h:308
>  
> +#if KXMLGUI_ENABLE_DEPRECATED_SINCE(5, 0)
>  /**

Fixed to `KXMLGUI_ENABLE_DEPRECATED_SINCE`, as `slotActionHighlighted` is a 
virtual method, which the compiler needs to always know about.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in kactioncollection.h:308
> Fixed to `KXMLGUI_ENABLE_DEPRECATED_SINCE`, as `slotActionHighlighted` is a 
> virtual method, which the compiler needs to always know about.

Eh, fixed to KXMLGUI_BUILD_DEPRECATED_SINCE actually :)

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:808bd05b37e4: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24466?vs=67733&id=68160#toc

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24466?vs=67733&id=68160

REVISION DETAIL
  https://phabricator.kde.org/D24466

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kactioncollection.cpp
  src/kactioncollection.h
  src/kkeysequencewidget.cpp
  src/kkeysequencewidget.h
  src/kmainwindow.cpp
  src/kmainwindow.h
  src/kshortcutseditor.cpp
  src/kshortcutseditor.h
  src/kshortcutwidget.cpp
  src/kshortcutwidget.h
  src/ktoolbar.cpp
  src/ktoolbar.h
  src/kxmlguibuilder.cpp
  src/kxmlguibuilder.h
  tests/kmainwindowrestoretest.cpp

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Méven Car]

meven created this revision.
meven added a reviewer: ivan.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Improve API UI to prevent user handling QString to QUrl.
  Would prevent error such as D22005  and 
D24728  and allow to simplify their code

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24741

AFFECTED FILES
  src/resultset.cpp
  src/resultset.h

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

[Konrad Materka]

kmaterka marked 2 inline comments as done.
kmaterka added a comment.


  In D24667#548245 , @broulik wrote:
  
  > > bool takeOwnership = true);
  >
  > If only Qt/we used modern C++ features to communicate object ownership :)
  
  
  Hehe, yes. Unfortunately KSNI messes with parent of menu object :/
  
  >> do not delete menu in KSNI
  > 
  > Makes the most sense in some form.
  >  It /could/ be done without additional API by abusing QObject parentship: 
https://phabricator.kde.org/P479
  > 
  > Then this code being a special case would just set the parent back 
afterwards. Whether that's actually any better than any explicit boolean method 
is debatable though.
  
  Believe me, I checked that :) I was thinking about this, but it won't work in 
this form. There are two reasons. First:
  
void KStatusNotifierItemPrivate::init(const QString &extraId)
//...
QMenu *m = new QMenu(associatedWidget);
  
  associatedWidget can be null or not. I don't know if this is needed, what is 
the purpose of this code and what are side effects. Probably this can be safely 
removed.
  Second reason is more serious: QMenu parent must be of QWidget type and KSNI 
is not a widget.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24667

To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Méven Car]

meven updated this revision to Diff 68162.
meven added a comment.


  Fix indentation

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24741?vs=68161&id=68162

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24741

AFFECTED FILES
  src/resultset.cpp
  src/resultset.h

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Méven Car]

meven updated this revision to Diff 68163.
meven added a comment.


  Improve comment

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24741?vs=68162&id=68163

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24741

AFFECTED FILES
  src/resultset.cpp
  src/resultset.h

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Méven Car]

meven added a comment.


  Relates to D16087  as well

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D24741

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:aa6bb9b06cfb: [KStatusNotifierItem] Allow left click when 
menu is null (authored by kmaterka).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24667?vs=67986&id=68165

REVISION DETAIL
  https://phabricator.kde.org/D24667

AFFECTED FILES
  src/kstatusnotifieritem.cpp
  src/kstatusnotifieritemdbus_p.cpp

To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/46/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 17 Oct 2019 16:13:09 +
 Build duration:
3 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/41/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 17 Oct 2019 16:19:54 +
 Build duration:
4 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24608: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:f046410b316f: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24608?vs=67843&id=68167#toc

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24608?vs=67843&id=68167

REVISION DETAIL
  https://phabricator.kde.org/D24608

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kiconloader.cpp
  src/kiconloader.h
  src/kicontheme.cpp

To: kossebau, #frameworks, cfeck, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  So far this is done implicitly in KSSLD by not being able to persist
  these error codes in its config file. This however is rather error
  prone, and requires manual enum <-> string mapping there.
  
  Now we do this explicitly, which allows us to eventually use QMetaEnum
  for serialization in KSSLD.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24742

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslcertificatemanager.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24600: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R275:c03781b0a6b7: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24600?vs=67806&id=68169

REVISION DETAIL
  https://phabricator.kde.org/D24600

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdescendantsproxymodel.cpp
  src/kdescendantsproxymodel.h

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24675: Deprecate the KTcpSocket-based variant of SslUi::askIgnoreSslErrors

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b5f5fb475da7: Deprecate the KTcpSocket-based variant of 
SslUi::askIgnoreSslErrors (authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24675?vs=67998&id=68170

REVISION DETAIL
  https://phabricator.kde.org/D24675

AFFECTED FILES
  src/widgets/sslui.h

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24611: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:7e971bfd6d2a: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24611?vs=67848&id=68171

REVISION DETAIL
  https://phabricator.kde.org/D24611

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/properties.h

To: kossebau, #frameworks, bruns, mlaurent
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Méven Car]

meven updated this revision to Diff 68172.
meven added a comment.


  Add @since

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24741?vs=68163&id=68172

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24741

AFFECTED FILES
  src/resultset.cpp
  src/resultset.h

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 141 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/141/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 17 Oct 2019 16:41:19 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 154 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/154/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 17 Oct 2019 16:41:19 +
 Build duration:
25 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/405)67%
(271/405)56%
(34822/61637)40%
(17616/43576)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9656/10118)47%
(4508/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)61%
(8796/14531)52%
(4569/8813)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4675/8302)43%
(2021/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(679/1208)40%
(383/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1371)37%
(520/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1800/4291)36%
(1309/3626)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D24742: Make non-ignorable SSL errors explicit

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> ksslcertificatemanager.cpp:537
> +});
>  return {};
>  }

`return ret; ` ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24742

To: vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Ivan Čukić]

ivan requested changes to this revision.
ivan added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> resultset.h:78
> +QString resource() const; ///< String representation of 
> resource (can represent an url or a path)
> +QUrl url() const; ///< Url representation of a 
> resource based on internal resource, readonly, @since 5.64
>  QString title() const;///< Title of the resource, or 
> URL if title is not known

`url` or `resourceUrl`?

I hoped we are not going to have these problems after the death of Nepomuk. 
Thought file paths for files and urls for everything else would be a sane 
default. :)

Also, can you add a `TODO: KF6 rething the function names` for these two.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D24741

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann marked an inline comment as done.
cullmann added a comment.


  With
  
  BreakConstructorInitializers: BeforeColon
  
  you get collapsed stuff like;
  
  Range::Range(const KTextEditor::Cursor &c1, const KTextEditor::Cursor c2, 
MotionType mt) : Range(c1.line(), c1.column(), c2.line(), c2.column(), mt)
  
  I think the behavior of the default of WebKit
  
  BCIS_BeforeComma (in configuration: BeforeComma) Break constructor 
initializers before the colon and commas, and align the commas with the colon.
  
  Constructor()
  
: initializer1()
, initializer2()
  
  is much more reasonable.
  
  One can play with
  
  ConstructorInitializerAllOnOneLineOrOnePerLine (bool)
  If the constructor initializers don’t fit on a line, put each initializer on 
its own line.
  
  true:
  SomeClass::Constructor()
  
  : (), (), 
(a) {
return 0;
  
  }
  
  false:
  SomeClass::Constructor()
  
  : (), (),
(a) {
return 0;
  
  }
  ConstructorInitializerIndentWidth (unsigned)
  The number of characters to use for indentation of constructor initializer 
lists as well as inheritance lists.

INLINE COMMENTS

> sitter wrote in KDEClangFormat.cmake:53
> I'm pretty sure you need to check the version the exectuable. When I use 6.0 
> I get ctors smushed into one line.

No, actually the reason for that is the added BreakConstructorInitializers: 
BeforeColon
I am not sure how to avoid that if we not go back to the old variant I had 
without that.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann updated this revision to Diff 68186.
cullmann marked an inline comment as done.
cullmann added a comment.


  - avoid collapsing of constructor initializer lines

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24568?vs=68091&id=68186

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24568

AFFECTED FILES
  kde-modules/KDEClangFormat.cmake
  kde-modules/clang-format.cmake

To: cullmann, #frameworks, dfaure
Cc: sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24707: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R269:02721f6c30fa: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24707?vs=68073&id=68188#toc

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24707?vs=68073&id=68188

REVISION DETAIL
  https://phabricator.kde.org/D24707

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/manager.cpp
  src/manager.h

To: kossebau, #frameworks, drosca, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added a comment.


  Without the initializer change, the file works for me reasonable well, tried 
it again on KTextEditor.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24620: Windows MSVC compile fix

[Christoph Cullmann]

cullmann added a comment.


  Ok to push that? Would avoid the last patch in craft to build frameworks.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D24620

To: cullmann, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24617: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:7c58c615206e: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24617?vs=67858&id=68191

REVISION DETAIL
  https://phabricator.kde.org/D24617

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt
  src/lib/resultiterator.cpp
  src/lib/resultiterator.h

To: kossebau, #frameworks, aacid
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> ivan wrote in resultset.h:78
> `url` or `resourceUrl`?
> 
> I hoped we are not going to have these problems after the death of Nepomuk. 
> Thought file paths for files and urls for everything else would be a sane 
> default. :)
> 
> Also, can you add a `TODO: KF6 rething the function names` for these two.

`url` makes more sense to me, no need to decorate it, this is idiomatic KDE/Qt. 
`toUrl` might make sense alternatively since it is not a free operation as it 
is a copy.

I am not too aware of the history around Nepomuk.

File paths for files and urls for everything else is fine internally but the 
API was not very clear about how to use it.
Given you would need to basically parse the resource to know which one it is, 
if you did not forget to do it in the first place.
That's why D22005  happens.

IMO we would need a type dedicated for file path, that would be a wrapper 
around QString, something like C++17 
https://en.cppreference.com/w/cpp/filesystem/path or Rust 
https://doc.rust-lang.org/std/path/struct.Path.html

While we are at it I could add a isPath() or similar to tell if resource 
contains a url or a path QDir::isAbsolutePath(resource()) basically.

About KF6 I would suggest resource would return something like 
std::variant 
https://en.cppreference.com/w/cpp/utility/variant
Add a std::optionnal path() and make url std::optionnal could 
also be interesting.
Can't wait for KF6 C++17 !
I learned a lot of those modern C++ features first in Rust.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D24741

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> dfaure wrote in clang-format.cmake:75
> typo: ternary

I've been always wondering how one should break long ternary operators when 
writing KF code. There are several ways to do it

(a) w/o breaking (BreakBeforeTernaryOperators: false)

  const FooBar *foobar = someStupidCondition() ?
  someSuperDuperBeatifulFunctionWithLongName() :
  anotherSuperDuperBeatiflFunctionWithLongName();

(b) w/ breaking (BreakBeforeTernaryOperators: true)

  const FooBar *foobar = someStupidCondition()
  ? someSuperDuperBeatifulFunctionWithLongName()
  : anotherSuperDuperBeatiflFunctionWithLongName();

According to the _clang-format file from the qt5 super repo, Qt fellas prefer 
(b) to break before ternary operators.

Do we really want to not break before ternary opeartors?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24598: Update elisa icon

[Alexander Stippich]

astippich updated this revision to Diff 68192.
astippich added a comment.


  - update and save as optimized svg

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24598?vs=67836&id=68192

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

AFFECTED FILES
  icons-dark/apps/22/elisa.svg
  icons-dark/apps/48/elisa.svg
  icons/apps/22/elisa.svg
  icons/apps/48/elisa.svg

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Ivan Čukić]

ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.


  Just add TODO and you are free to push

INLINE COMMENTS

> meven wrote in resultset.h:78
> `url` makes more sense to me, no need to decorate it, this is idiomatic 
> KDE/Qt. `toUrl` might make sense alternatively since it is not a free 
> operation as it is a copy.
> 
> I am not too aware of the history around Nepomuk.
> 
> File paths for files and urls for everything else is fine internally but the 
> API was not very clear about how to use it.
> Given you would need to basically parse the resource to know which one it is, 
> if you did not forget to do it in the first place.
> That's why D22005  happens.
> 
> IMO we would need a type dedicated for file path, that would be a wrapper 
> around QString, something like C++17 
> https://en.cppreference.com/w/cpp/filesystem/path or Rust 
> https://doc.rust-lang.org/std/path/struct.Path.html
> 
> While we are at it I could add a isPath() or similar to tell if resource 
> contains a url or a path QDir::isAbsolutePath(resource()) basically.
> 
> About KF6 I would suggest resource would return something like 
> std::variant 
> https://en.cppreference.com/w/cpp/utility/variant
> Add a std::optionnal path() and make url std::optionnal could 
> also be interesting.
> Can't wait for KF6 C++17 !
> I learned a lot of those modern C++ features first in Rust.

Ok, agreed. The reason why I thought the `resourceUrl` is a better choice is 
that it is an url of the resource, not of the result. But I agree `url` is 
cleaner.

We'll see about the KF6 part. variants/optionals vs a proxy type that converts 
to QString and QUrl in a correct way :)

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24741

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Méven Car]

meven marked 3 inline comments as done.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24741

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Méven Car]

meven updated this revision to Diff 68194.
meven added a comment.


  Add a KF6 TODO

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24741?vs=68172&id=68194

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24741

AFFECTED FILES
  src/resultset.cpp
  src/resultset.h

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24741: Add a utility accessor to get a QUrl from a ResultSet::Result

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R159:2cb2d4a20f26: Add a utility accessor to get a QUrl from a 
ResultSet::Result (authored by meven).

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24741?vs=68194&id=68195

REVISION DETAIL
  https://phabricator.kde.org/D24741

AFFECTED FILES
  src/resultset.cpp
  src/resultset.h

To: meven, ivan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24598: Update elisa icon

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24598: Update elisa icon

[TrickyRicky]

trickyricky26 accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  elisa_updated (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24598

To: astippich, #vdg, ngraham, mgallien, trickyricky26
Cc: trickyricky26, GB_2, kde-frameworks-devel, stuartm, daerny, mfraser, 
mnesbitt, LeGast00n, carneirogustavo, jguidon, ctakano, Tizon, oussemabouaneni, 
ashwind, fbampaloukas, sourabhboss, aureliencouderc, tgraves, hantzv, 
lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, astippich, James, 
ngraham, bruns, kmf, lemuel, mgallien

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto created this revision.
tienisto added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
tienisto requested review of this revision.

REVISION SUMMARY
  special ui changes if root directory is selected

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto edited the summary of this revision.
tienisto added a reviewer: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Björn Feber]

GB_2 added a comment.


  Can we also set the root folder icon?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham
Cc: GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1172
>  
> -l = new QLabel(i18n("Mounted on:"), d->m_frame);
> -grid->addWidget(l, curRow, 0, Qt::AlignRight);
> +// only show for non-root folders because '/' is obviously 
> mounted on '/'
> +if(!hasRoot) {

Probably not so obvious for new Linux users; especially those coming from 
windows where things are represented as C:\, D:\ ... etc.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kpropertiesdialog.cpp:1172
> Probably not so obvious for new Linux users; especially those coming from 
> windows where things are represented as C:\, D:\ ... etc.

I think new linux users don't even know what mounting means :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Developing an GLFW app that links makes use of KWindowEffects?

[Christian Parpart]

Hi guys,

I hope I landed into the right channel (it's many many years ago I did
stuff with KDE), so I've to apologize in advance, eventually. :-)

I am developing an OpenGL / GLFW application (for highest platform
independence and easiest porting efforts). It's basically a terminal
emulator, and I want the background to be optionally transparent (done) but
also blurred (done for windows, not linux/mac). I found out, that for KDE's
konsole, it's not doing it by itself but using
KWindowEffects::enableBlurBehind(...) instead, which is more or less how
you do it on Windows 10 too. However, making use of it and linking against
KF5::WindowSystem tells me that it couldn't find any plugins.


*org.kde.kwindowsystem: Could not find any platform plugin*

Also, I highly doubt I can just pump in the X11 `Window` (XID) handle to
`enableBlurBehind`'s first param, but I couldn't figure how to construct a
`WId` without fully transforming my program into a full KDE/Qt app.

Is there a way without fully converting into KDE app (I'd like to retain
platform independence, but at least get blur-behind feature on each
platform, with the least effort and code duplication).

Many thanks in advance,
Christian Parpart.

D24497: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:bf157dfa4d76: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24497?vs=68010&id=68203#toc

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24497?vs=68010&id=68203

REVISION DETAIL
  https://phabricator.kde.org/D24497

AFFECTED FILES
  CMakeLists.txt
  autotests/kconfigdialog_unittest.cpp
  src/CMakeLists.txt
  src/kcmodule.cpp
  src/kcmodule.h
  src/kconfigdialogmanager.cpp
  src/kconfigdialogmanager.h
  src/kpastetextaction.cpp
  src/kpastetextaction.h
  src/kstandardaction.cpp
  src/kstandardaction.h
  src/kstandardaction_p.h

To: kossebau, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24610: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R276:95d6613e23b4: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24610?vs=67846&id=68204

REVISION DETAIL
  https://phabricator.kde.org/D24610

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/kcategorizedsortfilterproxymodel.cpp
  src/kcategorizedsortfilterproxymodel.h
  src/kcategorizedview.cpp
  src/kcategorizedview.h
  src/kcategorydrawer.h
  src/kfilterproxysearchline.cpp
  src/kfilterproxysearchline.h
  src/klistwidgetsearchline.h
  src/ktreewidgetsearchline.h
  src/kwidgetitemdelegate.cpp
  src/kwidgetitemdelegate.h

To: kossebau, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto updated this revision to Diff 68205.
tienisto added a comment.


  cleanup

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24746?vs=68199&id=68205

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto updated this revision to Diff 68206.
tienisto added a comment.


  use root folder icon

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24746?vs=68205&id=68206

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 155 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/155/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 18 Oct 2019 05:10:52 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/405)67%
(271/405)57%
(34825/61637)40%
(17606/43576)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9658/10118)47%
(4499/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)61%
(8797/14531)52%
(4564/8813)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4674/8302)43%
(2020/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1371)37%
(520/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1800/4291)36%
(1309/3626)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 68210.
kossebau added a comment.


  update to latest master and new deprecated API

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24684?vs=68021&id=68210

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24684

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/copyjob.h
  src/core/global.cpp
  src/core/global.h
  src/core/job_base.h
  src/core/jobuidelegateextension.h
  src/core/kcoredirlister.h
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/krecentdocument.h
  src/core/ksambashare.cpp
  src/core/ksambashare.h
  src/core/ksslcertificatemanager.h
  src/core/ktcpsocket.h
  src/core/scheduler.cpp
  src/core/scheduler.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/core/transferjob.cpp
  src/core/transferjob.h
  src/core/udsentry.cpp
  src/core/udsentry.h
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilepreviewgenerator.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h
  src/filewidgets/knewfilemenu.h
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/widgets/CMakeLists.txt
  src/widgets/accessmanager.cpp
  src/widgets/accessmanager.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/kurifilter.cpp
  src/widgets/kurifilter.h
  src/widgets/kurlrequester.cpp
  src/widgets/kurlrequester.h
  src/widgets/kurlrequesterdialog.cpp
  src/widgets/kurlrequesterdialog.h
  src/widgets/paste.cpp
  src/widgets/paste.h
  src/widgets/previewjob.cpp
  src/widgets/previewjob.h
  src/widgets/renamedialog.cpp
  src/widgets/renamedialog.h
  src/widgets/sslui.h
  src/widgets/thumbcreator.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 142 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/142/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 18 Oct 2019 05:10:52 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/16/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 18 Oct 2019 05:52:22 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: projectroot.autotests.Re

D24496: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  seems ok for me

REPOSITORY
  R237 KConfig

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24496

To: kossebau, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24673: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent added a comment.


  +1 for me

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D24673

To: kossebau, #plasma, mart, broulik
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24700: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24700

To: kossebau, #frameworks, ilic, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24678: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24678

To: kossebau, #plasma, mart, davidedmundson, apol, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/17/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 18 Oct 2019 06:10:59 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: projectroot.autotests.Re

D23205: [KProcessList] Optimize KProcessList::processInfo

[David Hallas]

hallas added a comment.


  @davidedmundson  ping :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23205

To: hallas, davidedmundson, broulik
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns