D24993: Add integrated inline spelling menu to KTextEdit

[Tommy Lincoln]

pajamapants3000 edited the test plan for this revision.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24993

To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/45/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 27 Oct 2019 22:24:07 +
 Build duration:
2 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Alternatively kded could be build with additionally 
`-DKSERVICE_DISABLE_DEPRECATED_BEFORE_AND_AT=0x05`. So it will would be 
still hidden to anyone else who uses 
-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x050x00

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24974

To: dfaure, kossebau, vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

[David Faure]

dfaure closed this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D24974

To: dfaure, kossebau, vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24974

To: dfaure, kossebau, vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[David Faure]

dfaure added a comment.


  Any reason why you didn't implement my suggestion of
  
 DeleteJobIOWorker *ioworker() {
 if (!m_ioworker) {
   ...
 }
 return m_ioworker;
 }
[...] 
QMetaObject::invokeMethod(ioworker(), "rmfile", [...]);
  
  ?
  A call to an initSomething() method can easily be forgotten, while an 
on-demand getter ensure that the worker is created when it's needed (for the 
first time).
  Sorry for the nitpicking :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24993: Add integrated inline spelling menu to KTextEdit

[Nathaniel Graham]

ngraham added a comment.


  Very nice! Could you attach a screenshot or a screen recording in the Test 
Plan section that shows what this is and how it works? it's nice to do this 
when you add #vdg  as a reviewer since 
not all VDG people can test out patches themselves

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24993

To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24993: Add integrated inline spelling menu to KTextEdit

[Nathaniel Graham]

ngraham added reviewers: Frameworks, cullmann, cfeck.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24993

To: pajamapants3000, #vdg, #frameworks, cullmann, cfeck
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24993: Add integrated inline spelling menu to KTextEdit

[Tommy Lincoln]

pajamapants3000 created this revision.
pajamapants3000 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pajamapants3000 requested review of this revision.

REVISION SUMMARY
  Adds a new option to the KTextEdit control in KTextWidgets to show
  spelling suggestions and options, provided by Sonnet, in the standard context
  menu.
  
  BUG: 400647

REPOSITORY
  R310 KTextWidgets

BRANCH
  bug_400647 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24993

AFFECTED FILES
  src/CMakeLists.txt
  src/widgets/ktextedit.cpp
  src/widgets/ktextedit.h
  src/widgets/spellingmenu.cpp
  src/widgets/spellingmenu.h

To: pajamapants3000, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: [WIP]: Add Button to open the folder in filelight for more details

[Nathaniel Graham]

ngraham added a comment.


  Copy some other code that's already doing it this way I guess. For example, 
in plasma: 
https://cgit.kde.org/plasma-workspace.git/tree/libtaskmanager/tasktools.cpp#n767
  
  If you don't already know about it, let me introduce you to the magic of LXR: 
https://lxr.kde.org/ident?_i=runApplication

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven updated this revision to Diff 68854.
meven marked 7 inline comments as done.
meven added a comment.


  Create worker thread only once needed, fix a removeLast missing, formatting

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=68826&id=68854

BRANCH
  arcpatch-D24962

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Nathaniel Graham]

ngraham added a comment.


  In D24975#554805 , @ndavis wrote:
  
  > I don't have time to do all 32px icons at once, but thankfully, they're 
usually only used in the desktop shell (I can put 32px monochrome icons in the 
desktop theme), or in preferences or navigation sidebars. I suppose it also 
affects people who raise the toolbar icon size to 32px, but I wonder how many 
people even know they can do that. I could just keep this diff unlanded for as 
long as it takes to convert all 32px icons.
  
  
  That might be a good idea. We'll surely get bug reports about 
half-color/half-monochrome icons in apps that use 32px action icons for their 
own category switcher sidebars, like Okular:
  
  F7675508: Screenshot_20191027_144101.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  color32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg, ngraham
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24318: Make 32px document-save icon colorful

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Abandoned in favor of D24975 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24318

To: ngraham, #vdg, ndavis
Cc: churaev, GB_2, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns

D24975: Change some 32px action icons to color style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  These look great to me.

REPOSITORY
  R266 Breeze Icons

BRANCH
  color32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg, ngraham
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24966: KXmlGui: port away from KF5 deprecated API

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Actually I have a WIP undeprecation patch somewhere, which reduced the 
deprecation to notes with setApplicationData/appliactionData,  Guess I should 
pick this from the attic, clean up and share,

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24966

To: dfaure, kossebau, elvisangelaccio, vkrause, jriddell
Cc: jriddell, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, Build System.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  enableallqtkfdeprecationwarningsforframeworks

REVISION DETAIL
  https://phabricator.kde.org/D24990

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: kossebau, #frameworks, #build_system
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24966: KXmlGui: port away from KF5 deprecated API

[David Faure]

dfaure added a subscriber: jriddell.
dfaure added a comment.


  Yep, actually I found code in kcmutils 
(KPluginSelector::Private::PluginDelegate::slotAboutClicked) which sets the 
program icon name from a plugin (so NOT qApp->windowIcon()) on the aboutData 
passed to this dialog.
  So the functionality kind of made sense, but it was removed and deprecated 
because KAboutData is in kcoreaddons and can't link to QIcon (commit 
62aad4fc37fd 
 by 
@jriddell).
  I have to wonder about this logic however, as a container for a string, 
loaded in the above dialog, it was still useful.
  
  The problem is that KAboutData can be about the program (main about data) or 
about anything else (part, plugin).
  For the program, we don't need to set an icon name in KAboutData.
  But for parts/plugins, I can see how this was (somewhat) useful.
  
  The above commit deprecated setProgramIconName because 
KAboutData::setApplicationData can't make use of it, but the code in 
kaboutapplicationdialog.cpp can.
  How about we undeprecate it?
  And possibly rename it setIconName...

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24966

To: dfaure, kossebau, elvisangelaccio, vkrause
Cc: jriddell, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24966: KXmlGui: port away from KF5 deprecated API

[David Faure]

dfaure added a reviewer: jriddell.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24966

To: dfaure, kossebau, elvisangelaccio, vkrause, jriddell
Cc: jriddell, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24989: support multiple rcc files with icons themes

[Hannah von Reth]

vonreth requested changes to this revision.
vonreth added a subscriber: dfaure.
vonreth added a comment.
This revision now requires changes to proceed.


  Rest looks good to me.
  @dfaure you created the initial version what do you think?

INLINE COMMENTS

> kicontheme.cpp:79
> +for (const auto &iconDir : 
> QStandardPaths::locateAll(QStandardPaths::AppDataLocation, 
> QStringLiteral("icons"), QStandardPaths::LocateDirectory)) {
> +QDirIterator it(iconDir, QStringList() << QLatin1String("*.rcc"), 
> QDir::Files);
> +while (it.hasNext()) {

I guess we can use an Initializer here

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24989

To: cullmann, #frameworks, vonreth
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24989: support multiple rcc files with icons themes

[Christoph Cullmann]

cullmann added reviewers: Frameworks, vonreth.
cullmann added a comment.


  To make this usable, we will need to change the way we create the binary 
resources in breeze-icons and adapt the craft packaging.
  Then we can use e.g. breeze + breeze dark for app store applications like 
normally.
  We might want to alter this later to use libs to have mmap on all 
architectures.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24989

To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24989: support multiple rcc files with icons themes

[Christoph Cullmann]

cullmann created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  Instead of one hard-coded theme, support multiple ones
  This assumes that the rccs themself contain a /icons/ prefix

TEST PLAN
  Compiles and finds my local stuff

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24989

AFFECTED FILES
  src/kicontheme.cpp

To: cullmann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: KSyntaxHighlighting: My changes to data files don’t seem to affect test outputs

[Dominik Haumann]

What does `ldd build/bin/syntax/testhighlighter_test` tell you?
What, if you first source build/prefix.sh?

Likely the wrong lib is used.

Greetings
Dominik


Adrian Chaves  schrieb am So., 27. Okt. 2019, 17:49:

> I emptied data/syntax/rest.xml (made it a valid syntax file that would
> mark all text as normal).
>
> Then I run:
>
>  rm -rf build && mkdir build && cd build
>  cmake .. && make -j8 && make test
>
> But the contents of build/autotests/html.output/highlight.rst.html are
> still those that would be generated if data/syntax/rest.xml had not been
> changed.
>

D24979: KRunner: port away from deprecated KF5 API

[Friedrich W. H. Kossebau]

kossebau requested changes to this revision.
kossebau added a comment.
This revision now requires changes to proceed.


  One of the Interesting challenges with all the cross-library deprecation 
visibility control setup.
  
  Let me try to collect requirements:
  
  - Plasma::Package is part of ABI of Plasma API, cannot be removed in normal 
builds, only made optionally invisible in API when building against
  - Plasma::Package is part of ABI of KRunner API, cannot be removed in normal 
builds, only made optionally invisible in API when building against
  - if Plasma::Package is made invisible with Plasma API, it also needs to be 
invisible with KRunner API
  
  Current patch as proposed  has an issue for build time of KRunner itself, 
because KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00 results in 
PLASMA_ENABLE_DEPRECATED_SINCE(5, 28) evaluating to FALSE during the build of 
KRunner. Which means,the symbol for AbstractRunner::package() will be missing 
and thus ABI being broken -> not allowed.
  
  At the same time #if PLASMA_ENABLE_DEPRECATED_SINCE(5, 28) with the 
declaration in the header is needed indeed, as Plasma::Package is only visible 
to the compiler with this condition, and given consumers of KRunner API have 
control over that we need to handle it.
  
  So, KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00 is not possibly in total 
with KRunner, as its required implementation code has a hard dependency on 
Plasma API deprecated before that.
  Two options:
  a) set the module specific PLASMA_DISABLE_DEPRECATED_BEFORE_AND_AT=0x050500 
to override the default from the group KF one
  b) remove visibility wrappers around  originalPlasma::Package API
  
  I personally favour a) here.
  
  Given we have officially deprecated API in KRunner, it should indeed also get 
ported to ecm_generate_export_header. I would have now done this myself, but 
actually would like to see other people are easily able to use that macro API, 
so it's not just something compatible to my state of brain ;)

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D24979

To: dfaure, kossebau, mart, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 131 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/131/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 27 Oct 2019 17:45:50 +
 Build duration:
6 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 159 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/159/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 27 Oct 2019 17:41:51 +
 Build duration:
8 min 17 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Almost there ;)

INLINE COMMENTS

> deletejob.cpp:73
> +/**
> + * Deletes the file @p points to
> + * The file must be a LocalFile

Missing "url" after @p (which introduces the name of an argument). Not that 
we're going to run doxygen here, but well ;)

> deletejob.cpp:132
> +void rmdirResult(bool result, const QUrl& url);
> +void deleteFileUsingJob (const QUrl& url, bool isLink);
> +void deleteDirUsingJob (const QUrl& url);

no space after method name (same on next line)

> deletejob.cpp:188
> +
> +m_ioworker = new DeleteJobIOWorker;
> +m_ioworker->moveToThread(&m_thread);

One problem left: creating the worker and its thread is done even if we're 
deleting only remote URLs. This is a bit wasteful. Suggestion: create a 
worker() method which does all this (everything that you added to this method) 
on demand, if m_ioworker is null.

> deletejob.cpp:340
> +
> +if (isLink) { // not a link
> +symlinks.removeFirst();

That is a really weird comment, for a bool called isLink :-)

> deletejob.cpp:348
> +} else {
> +// fallback if unlink() failed (we'll use the job's error handling 
> in that case)
> +deleteFileUsingJob(url, isLink);

(pre-existing) s/unlink/QFile::remove/ in this comment would be less confusing

> deletejob.cpp:353
> +
> +void DeleteJobPrivate::deleteFileUsingJob (const QUrl &url, bool isLink)
>  {

please remove spaces after method names everywhere

> dfaure wrote in deletejob.cpp:412
> removeLast here too?

marked as done but I still see removeFirst, I'm confused.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24970: Port away from I18N_NOOP2 and KLocalizedString::insertQtDomain

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24970

To: dfaure, aacid, ilic
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/22/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 27 Oct 2019 16:34:15 +
 Build duration:
56 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis added a comment.


  I don't have time to do all 32px icons at once, but thankfully, they're 
usually only used in the desktop shell (I can put 32px monochrome icons in the 
desktop theme), or in preferences or navigation sidebars. I suppose it also 
affects people who raise the toolbar icon size to 32px, but I wonder how many 
people even know they can do that. I could just keep this diff unlanded for as 
long as it takes to convert all 32px icons.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis added a subscriber: ngraham.
ndavis added a comment.


  In D24975#554721 , @mglb wrote:
  
  > Why do you replace action icons instead of adding separate colorful icons 
for use in preference dialogs? Right now all action icons are "monochrome", 
making few of them colorful will introduce inconsistency.
  
  
  Maybe I should have explained it in the summary. It's kind of impossible to 
have consistent icon styles in 3rd party apps and well be breaking 
compatibility with 3rd party icon themes whenever we add another `preferences-` 
icon. @ngraham and I have talked about this and we decided that it might be 
best to just make all 32px and larger icons use the color style. In order to 
fix the problem we have without changing breeze-icons, we may need a new 
freedesktop.org icon spec that is designed to handle the type of theme we have. 
The current fd.o spec works in a way that assumes an icon theme will have one 
style. GNOME gets around that by just naming some icons symbolic, but that 
means apps have to choose to use symbolic icons. If you want more time to 
discuss changes like these and find other solutions, that's fine with me. This 
patch doesn't need to be landed in a hurry.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24961: Port to the QSslError variant of KSslInfoDialog

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24961

To: vkrause, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KSyntaxHighlighting: My changes to data files don’t seem to affect test outputs

[Adrian Chaves]

I emptied data/syntax/rest.xml (made it a valid syntax file that would 
mark all text as normal).


Then I run:

rm -rf build && mkdir build && cd build
cmake .. && make -j8 && make test

But the contents of build/autotests/html.output/highlight.rst.html are 
still those that would be generated if data/syntax/rest.xml had not been 
changed.

D24970: Port away from I18N_NOOP2 and KLocalizedString::insertQtDomain

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24970

To: dfaure, aacid, ilic
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24983: KateModeMenuList: improve word wrap

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  It's hard to review all the pixel changes with no screenshots. It's even 
unclear to me what problem exactly is fixed at hand. Given it's all your code, 
I trust you know what you are doing...

REPOSITORY
  R39 KTextEditor

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.12 - Build # 58 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.12/58/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 27 Oct 2019 16:34:15 +
 Build duration:
6 min 48 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5People-5.64.0.xmlcompat_reports/KF5People_compat_report.htmllogs/KF5People/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(3/7)45%
(22/49)45%
(22/49)46%
(768/1677)29%
(255/866)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)99%
(212/214)45%
(101/222)examples0%
(0/5)0%
(0/5)0%
(0/143)0%
(0/42)src71%
(10/14)71%
(10/14)57%
(463/818)32%
(142/443)src.backends73%
(8/11)73%
(8/11)89%
(93/104)55%
(12/22)src.declarative0%
(0/4)0%
(0/4)0%
(0/92)0%
(0/27)src.widgets0%
(0/10)0%
(0/10)0%
(0/291)0%
(0/106)src.widgets.plugins0%
(0/1)0%
(0/1)0%
(0/15)0%
(0/4)

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 35 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/35/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 27 Oct 2019 16:34:15 +
 Build duration:
4 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5People-5.64.0.xmlcompat_reports/KF5People_compat_report.htmllogs/KF5People/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(3/7)45%
(22/49)45%
(22/49)46%
(768/1677)29%
(255/866)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)99%
(212/214)45%
(101/222)examples0%
(0/5)0%
(0/5)0%
(0/143)0%
(0/42)src71%
(10/14)71%
(10/14)57%
(463/818)32%
(142/443)src.backends73%
(8/11)73%
(8/11)89%
(93/104)55%
(12/22)src.declarative0%
(0/4)0%
(0/4)0%
(0/92)0%
(0/27)src.widgets0%
(0/10)0%
(0/10)0%
(0/291)0%
(0/106)src.widgets.plugins0%
(0/1)0%
(0/1)0%
(0/15)0%
(0/4)

KDE CI: Frameworks » kpeople » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20FreeBSDQt5.13/32/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 27 Oct 2019 16:34:15 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kpeople » kf5-qt5 AndroidQt5.13 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20AndroidQt5.13/7/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Sun, 27 Oct 2019 16:34:15 +
 Build duration:
1 min 5 sec and counting

D24982: Small improvements in some XML files

[Dominik Haumann]

dhaumann added a comment.


  I wonder if the `?:` optimizations make sense. QRegularExpression has the 
option `QRegularExpression::DontCaptureOption` to not capture anything. Looking 
into our code we have:
  
561 bool RegExpr::doLoad(QXmlStreamReader& reader)
562 {
563 
m_regexp.setPattern(reader.attributes().value(QStringLiteral("String")).toString());
   // here we set the pattern -> OK
564
565 const auto isMinimal = 
Xml::attrToBool(reader.attributes().value(QStringLiteral("minimal")));
566 const auto isCaseInsensitive = 
Xml::attrToBool(reader.attributes().value(QStringLiteral("insensitive")));
567 m_regexp.setPatternOptions( 
   // if (m_dynamic == false), we could add 
the
568(isMinimal ? QRegularExpression::InvertedGreedinessOption : 
QRegularExpression::NoPatternOption) |  // flag 
QRegularExpression::DontCaptureOption
569(isCaseInsensitive ? QRegularExpression::CaseInsensitiveOption : 
QRegularExpression::NoPatternOption));
570
571// optimize the pattern for the non-dynamic case, we use them OFTEN
572m_dynamic = 
Xml::attrToBool(reader.attributes().value(QStringLiteral("dynamic")));
573if (!m_dynamic) {
574m_regexp.optimize();
575}
576// [...]
  
  In other words: The current patch adds many `?:` which also makes the RegExps 
harder to read. So: Do we really get a performance gain here? Wouldn't it be 
possible to get an even better performance gain by using the flag 
`DontCaptureOption`?
  
  Currently, I am not yet convinced, can you give this a try? :-)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D24982

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24939: Meson: more built-in functions and add built-in member functions

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9181ad6fedae: Meson: more built-in functions and add 
built-in member functions (authored by jpoelen).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24939?vs=68727&id=68838#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24939?vs=68727&id=68838

REVISION DETAIL
  https://phabricator.kde.org/D24939

AFFECTED FILES
  autotests/folding/meson.build.fold
  autotests/html/meson.build.html
  autotests/input/meson.build
  autotests/reference/meson.build.ref
  data/syntax/meson.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir added a comment.


  In D24928#554731 , @vkrause wrote:
  
  > In D24928#554720 , @ahmadsamir 
wrote:
  >
  > > So, we ditch digestMethod but keep the rest? 
ecryptionMethod/authenticationMethod/keyExchangeMethod can be deduced from the 
name() sometimes, but some others, not so obvious:
  >
  >
  > I was thinking of just:
  >
  >   sslMetaData.insert(QStringLiteral("ssl_cipher"), cipher.name());
  >
  >
  > It's the same as ssl_cipher_name then, ie. we'd be setting both for 
compatibility. Not every detail might be obviously readable out of this, but 
neither is that possible from the old format which adds no lables, just 
abbreviations separated by a line break.
  
  
  That makes sense.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir updated this revision to Diff 68836.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24928?vs=68834&id=68836

BRANCH
  ahmad/tcpslavebase (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24928

AFFECTED FILES
  src/core/tcpslavebase.cpp

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir updated this revision to Diff 68834.
ahmadsamir added a comment.


  cipher.name() is deemed sufficient when setting the ssl MetaData

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24928?vs=68701&id=68834

BRANCH
  ahmad/tcpslavebase (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24928

AFFECTED FILES
  src/core/tcpslavebase.cpp

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Volker Krause]

vkrause added a comment.


  In D24928#554720 , @ahmadsamir 
wrote:
  
  > So, we ditch digestMethod but keep the rest? 
ecryptionMethod/authenticationMethod/keyExchangeMethod can be deduced from the 
name() sometimes, but some others, not so obvious:
  
  
  I was thinking of just:
  
sslMetaData.insert(QStringLiteral("ssl_cipher"), cipher.name());
  
  It's the same as ssl_cipher_name then, ie. we'd be setting both for 
compatibility. Not every detail might be obviously readable out of this, but 
neither is that possible from the old format which adds no lables, just 
abbreviations separated by a line break.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven updated this revision to Diff 68829.
meven added a comment.


  Add KIO::UDSEntry::UDS_RECURSIVE_SIZE to store recursive size of folders

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24773?vs=68402&id=68829

BRANCH
  arcpatch-D24773

REVISION DETAIL
  https://phabricator.kde.org/D24773

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/udsentry.h
  src/ioslaves/trash/kio_trash.cpp
  src/ioslaves/trash/trashimpl.cpp
  src/ioslaves/trash/trashimpl.h

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven added a comment.


  In D24773#554409 , @dfaure wrote:
  
  > You can do whatever you want in the GUI -- I'll happily step out of that 
part of the discussion --, as long as you don't abuse UDS_SIZE for what it was 
not meant for, thus creating an ambiguous meaning for it.
  >
  > My suggestion would be to add a UDS_RECURSIVE_SIZE instead.
  >  The problem with that, however, is that the kioslave can't know if the 
application actually wants the information. So in most cases we would be 
wasting a lot of time for nothing -- even here it's not fully for free.
  
  
  Some ioslave could provide it by default in some situation like for 
kio_trash, this make sense for /.
  
  > One solution would be to use the "details" metadata for this.
  > 
  > - 0 (as set by DeleteJob) means bare minimum (filename and type).
  > - 1 isn't used anymore, but it adds uid, gid, atime, mtime, btime
  > - 2 is the default, which is the above plus ACL data
  > - 3 requests in addition the device and inode number (from kio_file), so 
that DirectorySizeJob can check for hardlinks
  > - we could add that 4 means "I want UDS_RECURSIVE_SIZE too".
  
  Good idea, could be a base to fix https://bugs.kde.org/show_bug.cgi?id=158090 
later.
  
  This `KIO::stat` details parameter begs to be a bitmask...
  I am thinking about adding a KF6 TODO about this.
  
  > I don't know if this will be useful in any other kioslave, but at least 
here it would allow skipping this stuff when not needed.
  > 
  > Sample code, like in kio_file and kio_ftp:
  > 
  >   const QString sDetails = metaData(QLatin1String("details"));
  >   const int details = sDetails.isEmpty() ? 2 : sDetails.toInt();
  >
  
  All dependent of the implementations and the users.
  But for sure UDS_RECURSIVE_SIZE cannot be a default.
  
  About https://bugs.kde.org/show_bug.cgi?id=158090
  I would imagine something where the job recurse at most N levels, or M number 
of directory before stopping with N = 4 and M = 300.
  Returning incomplete results, but enough to give good information in most 
usercases.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24981: Modelines: fix end of comment

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-end-modelines

REVISION DETAIL
  https://phabricator.kde.org/D24981

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24932: [WIP]: Add Button to open the folder in filelight for more details

[Shubham]

shubham added a comment.


  @ngraham How should I create a KService for runApplication?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Mariusz Glebocki]

mglb added a comment.


  Why do you replace action icons instead of adding separate colorful icons for 
use in preference dialogs? Right now all action icons are "monochrome", making 
few of them colorful will introduce inconsistency.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: mglb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir added a comment.


  So, we ditch digestMethod but keep the rest? 
ecryptionMethod/authenticationMethod/keyExchangeMethod can be deduced from the 
name() sometimes, but some others, not so obvious:
  
Name:  "TLS_AES_256_GCM_SHA384"
Encryption method:  "AESGCM(256)"
Auth method: "any"
Key exchange method:  "any"
Protocol:  "TLSv1.3" 

Name:  "TLS_CHACHA20_POLY1305_SHA256"
Encryption method:  "CHACHA20/POLY1305(256)"
Auth method: "any"
Key exchange method:  "any"
Protocol:  "TLSv1.3" 

Name:  "TLS_AES_128_GCM_SHA256"
Encryption method:  "AESGCM(128)"
Auth method: "any"
Key exchange method:  "any"
Protocol:  "TLSv1.3" 

Name:  "ECDHE-ECDSA-AES256-GCM-SHA384"
Encryption method:  "AESGCM(256)"
Auth method: "ECDSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-RSA-AES256-GCM-SHA384"
Encryption method:  "AESGCM(256)"
Auth method: "RSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "DHE-RSA-AES256-GCM-SHA384"
Encryption method:  "AESGCM(256)"
Auth method: "RSA"
Key exchange method:  "DH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-ECDSA-CHACHA20-POLY1305"
Encryption method:  "CHACHA20/POLY1305(256)"
Auth method: "ECDSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-RSA-CHACHA20-POLY1305"
Encryption method:  "CHACHA20/POLY1305(256)"
Auth method: "RSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "DHE-RSA-CHACHA20-POLY1305"
Encryption method:  "CHACHA20/POLY1305(256)"
Auth method: "RSA"
Key exchange method:  "DH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-ECDSA-AES128-GCM-SHA256"
Encryption method:  "AESGCM(128)"
Auth method: "ECDSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-RSA-AES128-GCM-SHA256"
Encryption method:  "AESGCM(128)"
Auth method: "RSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "DHE-RSA-AES128-GCM-SHA256"
Encryption method:  "AESGCM(128)"
Auth method: "RSA"
Key exchange method:  "DH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-ECDSA-AES256-SHA384"
Encryption method:  "AES(256)"
Auth method: "ECDSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-RSA-AES256-SHA384"
Encryption method:  "AES(256)"
Auth method: "RSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "DHE-RSA-AES256-SHA256"
Encryption method:  "AES(256)"
Auth method: "RSA"
Key exchange method:  "DH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-ECDSA-AES128-SHA256"
Encryption method:  "AES(128)"
Auth method: "ECDSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-RSA-AES128-SHA256"
Encryption method:  "AES(128)"
Auth method: "RSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1.2" 

Name:  "DHE-RSA-AES128-SHA256"
Encryption method:  "AES(128)"
Auth method: "RSA"
Key exchange method:  "DH"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-ECDSA-AES256-SHA"
Encryption method:  "AES(256)"
Auth method: "ECDSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1" 

Name:  "ECDHE-RSA-AES256-SHA"
Encryption method:  "AES(256)"
Auth method: "RSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1" 

Name:  "DHE-RSA-AES256-SHA"
Encryption method:  "AES(256)"
Auth method: "RSA"
Key exchange method:  "DH"
Protocol:  "SSLv3" 

Name:  "ECDHE-ECDSA-AES128-SHA"
Encryption method:  "AES(128)"
Auth method: "ECDSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1" 

Name:  "ECDHE-RSA-AES128-SHA"
Encryption method:  "AES(128)"
Auth method: "RSA"
Key exchange method:  "ECDH"
Protocol:  "TLSv1" 

Name:  "DHE-RSA-AES128-SHA"
Encryption method:  "AES(128)"
Auth method: "RSA"
Key exchange method:  "DH"
Protocol:  "SSLv3" 

Name:  "RSA-PSK-AES256-GCM-SHA384"
Encryption method:  "AESGCM(256)"
Auth method: "RSA"
Key exchange method:  "RSAPSK"
Protocol:  "TLSv1.2" 

Name:  "DHE-PSK-AES256-GCM-SHA384"
Encryption method:  "AESGCM(256)"
Auth method: "PSK"
Key exchange method:  "DHEPSK"
Protocol:  "TLSv1.2" 

Name:  "RSA-PSK-CHACHA20-POLY1305"
Encryption method:  "CHACHA20/POLY1305(256)"
Auth method: "RSA"
Key exchange method:  "RSAPSK"
Protocol:  "TLSv1.2" 

Name:  "DHE-PSK-CHACHA20-POLY1305"
Encryption method:  "CHACHA20/POLY1305(256)"
Auth method: "PSK"
Key exchange method:  "DHEPSK"
Protocol:  "TLSv1.2" 

Name:  "ECDHE-PSK-CHACHA20-POLY1305"
Encryption method:  "CHACHA20/POLY1305(256)"
Auth method: "PSK"
Key exchange method:  "ECDHEPSK"
Protocol:  "TLSv1.2" 

Name:  "AES256

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags updated this revision to Diff 68828.
nibags added a comment.


  - Fixes

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24983?vs=68827&id=68828

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24983: KateModeMenuList: improve word wrap

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  - Use `QFontMetrics::horizontalAdvance(text)` instead of 
`QFontMetrics::boundingRect(text).width()`, since it obtains a more precise 
value over the width of a text.
  - Allow word wrap in section titles.

REPOSITORY
  R39 KTextEditor

BRANCH
  improve-word-wrap

REVISION DETAIL
  https://phabricator.kde.org/D24983

AFFECTED FILES
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven updated this revision to Diff 68826.
meven marked 4 inline comments as done.
meven added a comment.


  Remove some const bool in function signature, use m_currentURL for consistency

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=68825&id=68826

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> deletejob.cpp:67
> +Q_SIGNALS:
> +void rmfileResult(bool succeeded, const QUrl& url, const bool isLink);
> +void rmddirResult(bool succeeded, const QUrl& url);

"const bool" doesn't do anything in a signal, I suggest removing the const.

> deletejob.cpp:76
> + */
> +void rmfile(const QUrl& url, const bool isLink){
> +emit rmfileResult(QFile::remove(url.toLocalFile()), url, isLink);

(here it technically does something (guarantees that it's not modified in the 
implementation), but that's quite unusual in Qt/KDE code; your choice)

> deletejob.cpp:412
> +m_processedDirs++;
> +dirs.removeFirst();
> +deleteNextDir();

removeLast here too?

> deletejob.cpp:445
> +// If local dir, try to rmdir it directly
> +if ((*it).isLocalFile()) {
> +// delete it on separate worker thread

Use m_currentURL here, or use (*it) in the Q_ARG. It's just inconsistent right 
now, even though of course it's all technically the same.

(I think the code wasn't using m_currentURL because that's just something used 
for reporting, added after the fact, and which could technically be changed 
again one day -- although that's unlikely, I guess).
So I don't feel strongly about which one to use, but it should be consistent.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

[David Faure]

On dimanche 27 octobre 2019 03:07:01 CET Friedrich W. H. Kossebau wrote:
> Am Freitag, 25. Oktober 2019, 00:35:46 CET schrieb David Faure:
> > On jeudi 24 octobre 2019 22:24:55 CEST Friedrich W. H. Kossebau wrote:
> > > BTW, we want to also set
> > > 
> > > -DQT_DEPRECATED_WARNINGS_SINCE=0x06
> > > 
> > > otherwise the deprecations done with QT_DEPRECATED_VERSION in Qt's API
> > > will
> > > not emit warnings, because QT_DEPRECATED_WARNINGS_SINCE defaults to
> > > QT_DISABLE_DEPRECATED_BEFORE if set.
> > 
> > Oh, good to know. Done now for all of KF5.
> 
> And the same would need to be done also for the KF variant, i.e. setting
> -DKF_DEPRECATED_WARNINGS_SINCE=0x06
> otherwise the use of KF_DISABLE_DEPRECATED_BEFORE_AND_AT will also result in
> warnings for API deprecated only in newer versions.

Hmm, true.

> Quite some explicit setup. But I made ECMGenerateExportHeader follow what Qt
> does, as consistency rules here IMHO.
> 
> Both QT_DEPRECATED_WARNINGS_SINCE & DKF_DEPRECATED_WARNINGS_SINCE could be
> though set via KDEFrameworkCompilerSettings perhaps, that would match what
> is done for -Wzero-as-null-pointer-constant already.

That would make sense, good idea. I didn't want the DISABLE stuff to come from 
ECM, so we keep some control over it (and it's a good thing I did, see
commit dd98b2b7175b in kimageformats)

But for warnings, not much harm can happen, so that's a good idea.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven updated this revision to Diff 68825.
meven added a comment.


  Fix rmdir, we must use removeLast since we remove in reverse order

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=68822&id=68825

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24982: Small improvements in some XML files

[Nibaldo González]

nibags updated this revision to Diff 68824.
nibags added a comment.


  - Increase version of javascript.xml

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24982?vs=68823&id=68824

BRANCH
  improve-some-xml

REVISION DETAIL
  https://phabricator.kde.org/D24982

AFFECTED FILES
  autotests/folding/highlight.y.fold
  data/syntax/apparmor.xml
  data/syntax/coffee.xml
  data/syntax/fortran-fixed.xml
  data/syntax/fortran-free.xml
  data/syntax/html.xml
  data/syntax/javascript.xml
  data/syntax/logcat.xml
  data/syntax/mustache.xml
  data/syntax/rust.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  data/syntax/selinux.xml
  data/syntax/xml.xml
  data/syntax/yacc.xml
  data/syntax/yaml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24982: Small improvements in some XML files

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  **Changes:**
  
  - Replace some unnecessary RegExpr rules with other rules.
  - Use non-capturing groups in some regular expressions.
  - Add `##Modelines` in comments.
  - Add folding for multi-line comments, add attribute `region` in element 
``.
  - Add `column` atributte in some rules.

TEST PLAN
  make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-some-xml

REVISION DETAIL
  https://phabricator.kde.org/D24982

AFFECTED FILES
  autotests/folding/highlight.y.fold
  data/syntax/apparmor.xml
  data/syntax/coffee.xml
  data/syntax/fortran-fixed.xml
  data/syntax/fortran-free.xml
  data/syntax/html.xml
  data/syntax/javascript.xml
  data/syntax/logcat.xml
  data/syntax/mustache.xml
  data/syntax/rust.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml
  data/syntax/selinux.xml
  data/syntax/xml.xml
  data/syntax/yacc.xml
  data/syntax/yaml.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven updated this revision to Diff 68822.
meven added a comment.


  Fix argument passing to invokeMethod

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=68821&id=68822

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven updated this revision to Diff 68821.
meven added a comment.


  amend commit

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=68819&id=68821

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven retitled this revision from "WIP [DeleteJob] Use a separate worker thread 
to run actual IO operation" to "[DeleteJob] Use a separate worker thread to run 
actual IO operation".
meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24981: Modelines: fix end of comment

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Use `fallthroughContext` to finish Modeline. This allows you to finish the 
comment block correctly if the Modeline is incomplete.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-end-modelines

REVISION DETAIL
  https://phabricator.kde.org/D24981

AFFECTED FILES
  autotests/folding/test.js.fold
  autotests/html/test.js.html
  autotests/input/test.js
  autotests/reference/test.js.ref
  data/syntax/modelines.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24959: Add new preferences search icons

[Noah Davis]

ndavis added a comment.


  In D24959#554523 , @trickyricky26 
wrote:
  
  > On the technical side, we usually convert everything to paths, and even 
though I can't imagine Qt SVG Renderer would have a problem with `circle`, it 
might be better to convert the background to a path.
  
  
  I don't think this matters. Usually, it's strokes that need to be converted 
to paths because otherwise they appear jagged for whatever reason.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24959

To: astippich, #vdg, ngraham, trickyricky26
Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven added a comment.


  In D24962#554586 , @dfaure wrote:
  
  > I like the approach.
  
  
  Thanks for the suggestion in the last diff. I feared the callback hell, but 
this was not too difficult in fact.
  
  > Just a few minor things.
  > 
  > (and remember to remove the WIP from the commit log and the phab request)
  
  Great review, thanks.
  
  > The passing of iterators to another thread *looks* scary, but of course 
it's safe here since we only run one subjob at a time, so the list can't change 
while the worker does its work.
  
  I have update the code to instead pass the bool isLink and use `removeFirst`. 
It should be more efficient than begin == it + erase.
  
  I feel the code looks simpler, although you need to understand the looping 
spreading over 4 functions.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven updated this revision to Diff 68819.
meven added a comment.


  Review feedback, cleanup, simplify parts, use removeFist instead of erase, 
formatting, comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=68816&id=68819

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

[Friedrich W. H. Kossebau]

Am Freitag, 25. Oktober 2019, 00:35:46 CET schrieb David Faure:
> On jeudi 24 octobre 2019 22:24:55 CEST Friedrich W. H. Kossebau wrote:
> > BTW, we want to also set
> > 
> > -DQT_DEPRECATED_WARNINGS_SINCE=0x06
> > 
> > otherwise the deprecations done with QT_DEPRECATED_VERSION in Qt's API
> > will
> > not emit warnings, because QT_DEPRECATED_WARNINGS_SINCE defaults to
> > QT_DISABLE_DEPRECATED_BEFORE if set.
> 
> Oh, good to know. Done now for all of KF5.

And the same would need to be done also for the KF variant, i.e. setting
-DKF_DEPRECATED_WARNINGS_SINCE=0x06
otherwise the use of KF_DISABLE_DEPRECATED_BEFORE_AND_AT will also result in 
warnings for API deprecated only in newer versions.

Quite some explicit setup. But I made ECMGenerateExportHeader follow what Qt 
does, as consistency rules here IMHO.

Both QT_DEPRECATED_WARNINGS_SINCE & DKF_DEPRECATED_WARNINGS_SINCE could be 
though set via KDEFrameworkCompilerSettings perhaps, that would match what is 
done for -Wzero-as-null-pointer-constant already.

Cheers
Friedrich

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 71 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/71/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 27 Oct 2019 03:20:46 +
 Build duration:
6 min 18 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.64.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)22%
(454/2046)18%
(171/947)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(144/156)51%
(51/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)66%
(25/38)src.plugins.telegram0%
   

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24980

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis added a task: T10165: Large category icons should all be colorful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  The TCPSlaveBase side of this can be fully ported to QSslError once D24928 

  is in.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24980

AFFECTED FILES
  src/core/ksslerror_p.h
  src/core/tcpslavebase.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/ksslinfodialog.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

[Méven Car]

meven updated this revision to Diff 68816.
meven marked 9 inline comments as done.
meven added a comment.


  Review feedback, cleanup, simplify parts, formatting, comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24962?vs=68785&id=68816

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24962

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  - document-open-recent, document-save-all, document-save-as, document-save, 
folder-open-recent, view-presentation, view-preview.svg

REPOSITORY
  R266 Breeze Icons

BRANCH
  color32 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24975

AFFECTED FILES
  icons-dark/actions/32/document-open-recent.svg
  icons-dark/actions/32/document-save-all.svg
  icons-dark/actions/32/document-save-as.svg
  icons-dark/actions/32/document-save.svg
  icons-dark/actions/32/folder-open-recent.svg
  icons-dark/actions/32/view-presentation.svg
  icons-dark/actions/32/view-preview.svg
  icons/actions/32/document-open-recent.svg
  icons/actions/32/document-save-all.svg
  icons/actions/32/document-save-as.svg
  icons/actions/32/document-save.svg
  icons/actions/32/folder-open-recent.svg
  icons/actions/32/view-presentation.svg
  icons/actions/32/view-preview.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas marked an inline comment as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24979: KRunner: port away from deprecated KF5 API

[David Faure]

dfaure created this revision.
dfaure added reviewers: kossebau, mart, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Plasma::Package has been deprecated since 5.28, but it's used
  in the public API for AbstractRunner.
  
  Removed the underlying member variable which is never set
  (since apol's commit 8d77a33b6eae26 
).
  
  Once krunner is ported to the new deprecation macros, I guess
  the package() method will need something like
  
#if KRUNNER_ENABLE_DEPRECATED_SINCE(5, 28)
  
  Technically the method wasn't marked as deprecated between 5.28 and 5.64
  but the class it returned, was, so that's pretty much the same.

TEST PLAN
  Builds

REPOSITORY
  R308 KRunner

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24979

AFFECTED FILES
  CMakeLists.txt
  src/abstractrunner.cpp
  src/abstractrunner.h
  src/abstractrunner_p.h

To: dfaure, kossebau, mart, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 72 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/72/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 27 Oct 2019 08:44:35 +
 Build duration:
8 min 48 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.64.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)22%
(453/2036)18%
(172/939)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)98%
(143/146)59%
(54/92)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)61%
(23/38)src.plugins.telegram0%
(0/1)0%

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/21/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 27 Oct 2019 08:47:43 +
 Build duration:
4 min 52 sec and counting
   CONSOLE OUTPUT
  [...truncated 378 lines...][2019-10-27T08:52:27.110Z] [ 39%] Building CXX object src/CMakeFiles/KF5People.dir/KF5People_autogen/EWIEGA46WW/qrc_resources.cpp.obj[2019-10-27T08:52:27.110Z] qrc_resources.cpp[2019-10-27T08:52:27.375Z] [ 40%] Linking CXX shared library ..\bin\libkpeople.dll[2019-10-27T08:52:27.947Z]Creating library ..\lib\libkpeople.lib and object ..\lib\libkpeople.exp[2019-10-27T08:52:28.210Z]Creating library ..\lib\libkpeople.lib and object ..\lib\libkpeople.exp[2019-10-27T08:52:28.210Z] [ 40%] Built target KF5People[2019-10-27T08:52:28.482Z] Scanning dependencies of target KF5PeopleWidgets_autogen[2019-10-27T08:52:28.482Z] Scanning dependencies of target contactlistwidgets_autogen[2019-10-27T08:52:28.482Z] Scanning dependencies of target duplicates_autogen[2019-10-27T08:52:28.482Z] Scanning dependencies of target personsmodeltest_autogen[2019-10-27T08:52:28.482Z] Scanning dependencies of target persondatatest_autogen[2019-10-27T08:52:28.482Z] Scanning dependencies of target personsproxymodeltest_autogen[2019-10-27T08:52:28.482Z] [ 45%] Automatic MOC for target KF5PeopleWidgets[2019-10-27T08:52:28.746Z] [ 46%] Automatic MOC for target duplicates[2019-10-27T08:52:28.746Z] [ 47%] Built target duplicates_autogen[2019-10-27T08:52:28.746Z] [ 47%] Automatic MOC for target personsmodeltest[2019-10-27T08:52:28.746Z] [ 47%] Automatic MOC for target personsproxymodeltest[2019-10-27T08:52:28.746Z] [ 47%] Automatic MOC for target persondatatest[2019-10-27T08:52:28.746Z] [ 43%] Automatic MOC for target contactlistwidgets[2019-10-27T08:52:28.746Z] [ 47%] Built target persondatatest_autogen[2019-10-27T08:52:28.746Z] [ 47%] Built target personsmodeltest_autogen[2019-10-27T08:52:28.746Z] [ 47%] Built target personsproxymodeltest_autogen[2019-10-27T08:52:28.746Z] [ 47%] Built target contactlistwidgets_autogen[2019-10-27T08:52:29.016Z] [ 47%] Built target KF5PeopleWidgets_autogen[2019-10-27T08:52:29.016Z] Scanning dependencies of target duplicates[2019-10-27T08:52:29.016Z] [ 51%] Building CXX object examples/CMakeFiles/duplicates.dir/duplicates.cpp.obj[2019-10-27T08:52:29.016Z] [ 51%] Building CXX object examples/CMakeFiles/duplicates.dir/duplicates_autogen/mocs_compilation.cpp.obj[2019-10-27T08:52:29.016Z] Scanning dependencies of target contactlistwidgets[2019-10-27T08:52:29.016Z] duplicates.cpp[2019-10-27T08:52:29.016Z] [ 52%] Building CXX object examples/CMakeFiles/contactlistwidgets.dir/contactlistwidgets.cpp.obj[2019-10-27T08:52:29.016Z] [ 53%] Building CXX object examples/CMakeFiles/contactlistwidgets.dir/contactlistwidgets_autogen/mocs_compilation.cpp.obj[2019-10-27T08:52:29.289Z] contactlistwidgets.cpp[2019-10-27T08:52:29.289Z] Scanning dependencies of target personsmodeltest[2019-10-27T08:52:29.289Z] Scanning dependencies of target persondatatest[2019-10-27T08:52:29.289Z] Scanning dependencies of target personsproxymodeltest[2019-10-27T08:52:29.289Z] mocs_compilation.cpp[2019-10-27T08:52:29.289Z] [ 57%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/personsmodeltest.cpp.obj[2019-10-27T08:52:29.289Z] [ 59%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/fakecontactsource.cpp.obj[2019-10-27T08:52:29.289Z] [ 59%] Building CXX object autotests/CMakeFiles/persondatatest.dir/persondatatests.cpp.obj[2019-10-27T08:52:29.289Z] [ 60%] Building CXX object autotests/CMakeFiles/persondatatest.dir/fakecontactsource.cpp.obj[2019-10-27T08:52:29.289Z] [ 60%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/personsmodeltest_autogen/mocs_compilation.cpp.obj[2019-10-27T08:52:29.289Z] [ 62%] Building CXX object autotests/CMakeFiles/persondatatest.dir/persondatatest_autogen/mocs_compilation.cpp.obj[2019-10-27T08:52:29.289Z] [ 62%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/personsproxymodeltest.cpp.obj[2019-10-27T08:52:29.289Z] mocs_compilation.cpp[2019-10-27T08:52:29.289Z] personsmodeltest.cpp[2019-10-27T08:52:29.289Z] persondatatests.cpp[2019-10-27T08:52:29.289Z] [ 63%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/fakecontactsource.cpp.obj[2019-10-27T08:52:29.289Z] personsproxymodeltest.cpp[2019-10-27T08:52:29.289Z] [ 64%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/personsproxymodeltest_autogen/mocs_compilation.cpp.obj[2019-10-27T08:52:29.584Z] [ 48%] Generating ui_person-details-presentation.h[2019-10-27T08:52:29.584Z] Scanning dependencies of target KF5PeopleWidgets[2019-10-27T08:52:31.558Z] fakecontactsource.cpp[2019-10-27T08:52:31.558Z] fakecontactsource.cpp[2019-10-27T08:52:31.840Z] mocs_compilation.cpp[2019-10-27T08:52:31.840Z] mocs_compilation.cpp[2019-10-27T08:52:31.840Z] fakecontactsource.cpp[2019-10-2

KDE CI: Frameworks » kpeople » kf5-qt5 AndroidQt5.13 - Build # 6 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20AndroidQt5.13/6/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Sun, 27 Oct 2019 08:47:35 +
 Build duration:
2 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 244 lines...][2019-10-27T08:49:30.506Z] [2019-10-27T08:49:30.506Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-10-27T08:49:30.506Z] [2019-10-27T08:49:30.506Z] -- Configuring done[2019-10-27T08:49:30.506Z] -- Generating done[2019-10-27T08:49:30.506Z] -- Build files have been written to: /home/user/workspace/Frameworks/kpeople/kf5-qt5 AndroidQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-10-27T08:49:32.018Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpeople --branchGroup kf5-qt5 --platform AndroidQt5.13 --usingInstall /home/user/install-prefix/[2019-10-27T08:49:32.018Z] Scanning dependencies of target KF5PeopleBackend_autogen[2019-10-27T08:49:32.018Z] [  1%] Automatic MOC for target KF5PeopleBackend[2019-10-27T08:49:32.519Z] [  1%] Built target KF5PeopleBackend_autogen[2019-10-27T08:49:32.519Z] Scanning dependencies of target KF5PeopleBackend[2019-10-27T08:49:32.519Z] [  3%] Building CXX object src/backends/CMakeFiles/KF5PeopleBackend.dir/KF5PeopleBackend_autogen/mocs_compilation.cpp.o[2019-10-27T08:49:34.180Z] [  5%] Building CXX object src/backends/CMakeFiles/KF5PeopleBackend.dir/defaultcontactmonitor.cpp.o[2019-10-27T08:49:35.236Z] [  6%] Building CXX object src/backends/CMakeFiles/KF5PeopleBackend.dir/abstractpersonaction.cpp.o[2019-10-27T08:49:37.580Z] [  8%] Building CXX object src/backends/CMakeFiles/KF5PeopleBackend.dir/abstracteditablecontact.cpp.o[2019-10-27T08:49:38.629Z] [ 10%] Building CXX object src/backends/CMakeFiles/KF5PeopleBackend.dir/allcontactsmonitor.cpp.o[2019-10-27T08:49:40.289Z] [ 11%] Building CXX object src/backends/CMakeFiles/KF5PeopleBackend.dir/basepersonsdatasource.cpp.o[2019-10-27T08:49:41.952Z] [ 13%] Building CXX object src/backends/CMakeFiles/KF5PeopleBackend.dir/abstractcontact.cpp.o[2019-10-27T08:49:43.004Z] [ 15%] Building CXX object src/backends/CMakeFiles/KF5PeopleBackend.dir/contactmonitor.cpp.o[2019-10-27T08:49:44.059Z] [ 16%] Linking CXX shared library ../../bin/libKF5PeopleBackend.so[2019-10-27T08:49:44.568Z] [ 16%] Built target KF5PeopleBackend[2019-10-27T08:49:44.568Z] Scanning dependencies of target KF5People_autogen[2019-10-27T08:49:44.568Z] [ 18%] Automatic MOC for target KF5People[2019-10-27T08:49:45.071Z] [ 18%] Built target KF5People_autogen[2019-10-27T08:49:45.071Z] [ 20%] Automatic RCC for resources.qrc[2019-10-27T08:49:45.071Z] Scanning dependencies of target KF5People[2019-10-27T08:49:45.071Z] [ 22%] Building CXX object src/CMakeFiles/KF5People.dir/KF5People_autogen/mocs_compilation.cpp.o[2019-10-27T08:49:47.426Z] [ 23%] Building CXX object src/CMakeFiles/KF5People.dir/matchessolver.cpp.o[2019-10-27T08:49:49.775Z] [ 25%] Building CXX object src/CMakeFiles/KF5People.dir/match.cpp.o[2019-10-27T08:49:50.836Z] [ 27%] Building CXX object src/CMakeFiles/KF5People.dir/duplicatesfinder.cpp.o[2019-10-27T08:49:51.900Z] [ 28%] Building CXX object src/CMakeFiles/KF5People.dir/persondata.cpp.o[2019-10-27T08:49:52.980Z] [ 30%] Building CXX object src/CMakeFiles/KF5People.dir/personsmodel.cpp.o[2019-10-27T08:49:53.500Z] [ 32%] Building CXX object src/CMakeFiles/KF5People.dir/metacontact.cpp.o[2019-10-27T08:49:54.012Z] /home/user/workspace/Frameworks/kpeople/kf5-qt5 AndroidQt5.13/src/persondata.cpp:129:2: warning: #warning is a language extension [-Wpedantic][2019-10-27T08:49:54.012Z] #warning probably not needed anymore[2019-10-27T08:49:54.012Z]  ^[2019-10-27T08:49:54.012Z] /home/user/workspace/Frameworks/kpeople/kf5-qt5 AndroidQt5.13/src/persondata.cpp:129:2: warning: probably not needed anymore [-W#warnings][2019-10-27T08:49:54.517Z] [ 33%] Building CXX object src/CMakeFiles/KF5People.dir/personpluginmanager.cpp.o[2019-10-27T08:49:54.517Z] 2 warnings generated.[2019-10-27T08:49:54.517Z] [ 35%] Building CXX object src/CMakeFiles/KF5People.dir/global.cpp.o[2019-10-27T08:49:55.600Z] /home/user/workspace/Frameworks/kpeople/kf5-qt5 AndroidQt5.13/src/personsmodel.cpp:241:33: warning: comparison of integers of different signs: 'quintptr' (aka 'unsigned int') and 'int' [-Wsign-compare][2019-10-27T08:49:55.600Z] if (childIndex.internalId() == -1 || !childIndex.isValid()) {[2019-10-27T08:49:55.600Z] ~~~ ^  ~~[2019-10-27T08:49:57.280Z] 1 warning generated.[2019-10-27T08:49:57.280Z] [ 37%] Building CXX object src/CMakeFiles/KF5People.dir/KF5People_autogen/EWIEGA46WW/qrc_resources.cpp.o[2019-10-27T08:49:57.781Z] [ 38%] Building CXX object src/CMakeFiles/KF5People.dir/personssortfilterproxymodel.cpp.o[2019-10-27T08:49:59.444Z] [ 40%] Building CXX object src/CMakeFiles/KF5People.dir/personmanager.cpp.o[2019-10-27T0

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 34 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/34/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 27 Oct 2019 08:47:43 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 339 lines...][2019-10-27T08:48:40.902Z] [ 26%] Building CXX object src/CMakeFiles/KF5People.dir/KF5People_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:40.902Z] [ 28%] Building CXX object src/CMakeFiles/KF5People.dir/persondata.cpp.o[2019-10-27T08:48:40.902Z] [ 29%] Building CXX object src/CMakeFiles/KF5People.dir/global.cpp.o[2019-10-27T08:48:40.902Z] [ 30%] Building CXX object src/CMakeFiles/KF5People.dir/match.cpp.o[2019-10-27T08:48:40.902Z] [ 31%] Building CXX object src/CMakeFiles/KF5People.dir/matchessolver.cpp.o[2019-10-27T08:48:40.902Z] [ 32%] Building CXX object src/CMakeFiles/KF5People.dir/personsmodel.cpp.o[2019-10-27T08:48:40.902Z] [ 34%] Building CXX object src/CMakeFiles/KF5People.dir/duplicatesfinder.cpp.o[2019-10-27T08:48:41.163Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/persondata.cpp:129:2: warning: #warning is a GCC extension[2019-10-27T08:48:41.163Z]   129 | #warning probably not needed anymore[2019-10-27T08:48:41.163Z]   |  ^~~[2019-10-27T08:48:41.163Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/persondata.cpp:129:2: warning: #warning probably not needed anymore [-Wcpp][2019-10-27T08:48:42.105Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/personsmodel.cpp: In member function ���virtual QModelIndex KPeople::PersonsModel::parent(const QModelIndex&) const���:[2019-10-27T08:48:42.105Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/personsmodel.cpp:241:33: warning: comparison of integer expressions of different signedness: ���quintptr��� {aka ���long long unsigned int���} and ���int��� [-Wsign-compare][2019-10-27T08:48:42.105Z]   241 | if (childIndex.internalId() == -1 || !childIndex.isValid()) {[2019-10-27T08:48:42.105Z]   | ^[2019-10-27T08:48:42.105Z] [ 35%] Building CXX object src/CMakeFiles/KF5People.dir/personpluginmanager.cpp.o[2019-10-27T08:48:42.105Z] [ 36%] Building CXX object src/CMakeFiles/KF5People.dir/personmanager.cpp.o[2019-10-27T08:48:42.365Z] [ 37%] Building CXX object src/CMakeFiles/KF5People.dir/personssortfilterproxymodel.cpp.o[2019-10-27T08:48:42.365Z] [ 39%] Building CXX object src/CMakeFiles/KF5People.dir/KF5People_autogen/EWIEGA46WW/qrc_resources.cpp.o[2019-10-27T08:48:43.739Z] [ 40%] Linking CXX shared library ../bin/libKF5People.so[2019-10-27T08:48:43.739Z] [ 40%] Built target KF5People[2019-10-27T08:48:43.739Z] Scanning dependencies of target KF5PeopleWidgets_autogen[2019-10-27T08:48:43.739Z] Scanning dependencies of target duplicates_autogen[2019-10-27T08:48:43.739Z] Scanning dependencies of target persondatatest_autogen[2019-10-27T08:48:43.739Z] Scanning dependencies of target contactlistwidgets_autogen[2019-10-27T08:48:43.739Z] Scanning dependencies of target personsproxymodeltest_autogen[2019-10-27T08:48:43.739Z] Scanning dependencies of target personsmodeltest_autogen[2019-10-27T08:48:43.739Z] [ 41%] Automatic MOC for target duplicates[2019-10-27T08:48:43.739Z] [ 42%] Automatic MOC for target KF5PeopleWidgets[2019-10-27T08:48:43.739Z] [ 43%] Automatic MOC for target persondatatest[2019-10-27T08:48:43.739Z] [ 45%] Automatic MOC for target personsmodeltest[2019-10-27T08:48:43.739Z] [ 46%] Automatic MOC for target contactlistwidgets[2019-10-27T08:48:43.739Z] [ 47%] Automatic MOC for target personsproxymodeltest[2019-10-27T08:48:43.997Z] [ 47%] Built target contactlistwidgets_autogen[2019-10-27T08:48:43.997Z] [ 47%] Built target persondatatest_autogen[2019-10-27T08:48:43.997Z] [ 47%] Built target KF5PeopleWidgets_autogen[2019-10-27T08:48:43.997Z] [ 47%] Built target duplicates_autogen[2019-10-27T08:48:43.997Z] Scanning dependencies of target contactlistwidgets[2019-10-27T08:48:43.997Z] [ 48%] Generating ui_person-details-presentation.h[2019-10-27T08:48:43.997Z] [ 50%] Building CXX object examples/CMakeFiles/contactlistwidgets.dir/contactlistwidgets_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:43.997Z] [ 51%] Building CXX object examples/CMakeFiles/contactlistwidgets.dir/contactlistwidgets.cpp.o[2019-10-27T08:48:43.997Z] Scanning dependencies of target duplicates[2019-10-27T08:48:43.997Z] [ 51%] Built target personsmodeltest_autogen[2019-10-27T08:48:43.997Z] [ 52%] Building CXX object examples/CMakeFiles/duplicates.dir/duplicates_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:43.997Z] [ 53%] Building CXX object examples/CMakeFiles/duplicates.dir/duplicates.cpp.o[2019-10-27T08:48:43.997Z] [ 53%] Built target personsproxymodeltest_autogen[2019-10-27T08:48:43.997Z] Scanning dependencies of target persondatatest[2019-10-27T08:48:43.997Z] Scanning dependencies of target KF5PeopleWidgets[2019-10-27T08:48:43.997Z] [ 54%] Building CXX o

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.12 - Build # 57 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.12/57/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 27 Oct 2019 08:47:41 +
 Build duration:
50 sec and counting
   CONSOLE OUTPUT
  [...truncated 340 lines...][2019-10-27T08:48:27.867Z] [ 28%] Building CXX object src/CMakeFiles/KF5People.dir/persondata.cpp.o[2019-10-27T08:48:27.867Z] [ 30%] Building CXX object src/CMakeFiles/KF5People.dir/duplicatesfinder.cpp.o[2019-10-27T08:48:27.867Z] [ 30%] Building CXX object src/CMakeFiles/KF5People.dir/matchessolver.cpp.o[2019-10-27T08:48:27.867Z] [ 31%] Building CXX object src/CMakeFiles/KF5People.dir/match.cpp.o[2019-10-27T08:48:27.867Z] [ 32%] Building CXX object src/CMakeFiles/KF5People.dir/personsmodel.cpp.o[2019-10-27T08:48:27.867Z] [ 34%] Building CXX object src/CMakeFiles/KF5People.dir/metacontact.cpp.o[2019-10-27T08:48:27.867Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/persondata.cpp:129:2: warning: #warning is a GCC extension[2019-10-27T08:48:27.867Z]   129 | #warning probably not needed anymore[2019-10-27T08:48:27.867Z]   |  ^~~[2019-10-27T08:48:27.867Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/persondata.cpp:129:2: warning: #warning probably not needed anymore [-Wcpp][2019-10-27T08:48:28.847Z] [ 35%] Building CXX object src/CMakeFiles/KF5People.dir/personpluginmanager.cpp.o[2019-10-27T08:48:28.847Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/personsmodel.cpp: In member function ���virtual QModelIndex KPeople::PersonsModel::parent(const QModelIndex&) const���:[2019-10-27T08:48:28.847Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/personsmodel.cpp:241:33: warning: comparison of integer expressions of different signedness: ���quintptr��� {aka ���long long unsigned int���} and ���int��� [-Wsign-compare][2019-10-27T08:48:28.847Z]   241 | if (childIndex.internalId() == -1 || !childIndex.isValid()) {[2019-10-27T08:48:28.847Z]   | ^[2019-10-27T08:48:28.847Z] [ 36%] Building CXX object src/CMakeFiles/KF5People.dir/personmanager.cpp.o[2019-10-27T08:48:28.847Z] [ 37%] Building CXX object src/CMakeFiles/KF5People.dir/personssortfilterproxymodel.cpp.o[2019-10-27T08:48:29.114Z] [ 39%] Building CXX object src/CMakeFiles/KF5People.dir/KF5People_autogen/EWIEGA46WW/qrc_resources.cpp.o[2019-10-27T08:48:30.064Z] [ 40%] Linking CXX shared library ../bin/libKF5People.so[2019-10-27T08:48:30.064Z] [ 40%] Built target KF5People[2019-10-27T08:48:30.064Z] Scanning dependencies of target duplicates_autogen[2019-10-27T08:48:30.064Z] Scanning dependencies of target personsmodeltest_autogen[2019-10-27T08:48:30.064Z] Scanning dependencies of target personsproxymodeltest_autogen[2019-10-27T08:48:30.064Z] Scanning dependencies of target KF5PeopleWidgets_autogen[2019-10-27T08:48:30.064Z] Scanning dependencies of target persondatatest_autogen[2019-10-27T08:48:30.064Z] Scanning dependencies of target contactlistwidgets_autogen[2019-10-27T08:48:30.064Z] [ 41%] Automatic MOC for target duplicates[2019-10-27T08:48:30.064Z] [ 42%] Automatic MOC for target personsmodeltest[2019-10-27T08:48:30.064Z] [ 43%] Automatic MOC for target KF5PeopleWidgets[2019-10-27T08:48:30.064Z] [ 45%] Automatic MOC for target personsproxymodeltest[2019-10-27T08:48:30.064Z] [ 46%] Automatic MOC for target persondatatest[2019-10-27T08:48:30.064Z] [ 47%] Automatic MOC for target contactlistwidgets[2019-10-27T08:48:30.324Z] [ 47%] Built target persondatatest_autogen[2019-10-27T08:48:30.324Z] [ 47%] Built target personsproxymodeltest_autogen[2019-10-27T08:48:30.324Z] [ 47%] Built target personsmodeltest_autogen[2019-10-27T08:48:30.324Z] Scanning dependencies of target persondatatest[2019-10-27T08:48:30.324Z] [ 47%] Built target duplicates_autogen[2019-10-27T08:48:30.324Z] Scanning dependencies of target personsproxymodeltest[2019-10-27T08:48:30.324Z] [ 48%] Building CXX object autotests/CMakeFiles/persondatatest.dir/persondatatest_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:30.324Z] [ 48%] Built target contactlistwidgets_autogen[2019-10-27T08:48:30.324Z] [ 50%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/fakecontactsource.cpp.o[2019-10-27T08:48:30.324Z] [ 51%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/personsproxymodeltest.cpp.o[2019-10-27T08:48:30.324Z] [ 52%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/personsproxymodeltest_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:30.324Z] [ 53%] Building CXX object autotests/CMakeFiles/persondatatest.dir/persondatatests.cpp.o[2019-10-27T08:48:30.324Z] [ 53%] Built target KF5PeopleWidgets_autogen[2019-10-27T08:48:30.324Z] Scanning dependencies of target duplicates[2019-10-27T08:48:30.324Z] Scanning dependencies of target personsmodeltest[2019-10-27T08:48:30.324Z] [ 54%] Building CXX object autotests/CMakeFiles/persondatates

KDE CI: Frameworks » kpeople » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20FreeBSDQt5.13/31/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 27 Oct 2019 08:47:44 +
 Build duration:
32 sec and counting
   CONSOLE OUTPUT
  [...truncated 293 lines...][2019-10-27T08:48:09.146Z] [ 39%] Building CXX object src/CMakeFiles/KF5People.dir/KF5People_autogen/EWIEGA46WW/qrc_resources.cpp.o[2019-10-27T08:48:09.146Z] /usr/home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 FreeBSDQt5.13/src/persondata.cpp:129:2: warning: #warning is a language extension [-Wpedantic][2019-10-27T08:48:09.146Z] #warning probably not needed anymore[2019-10-27T08:48:09.146Z]  ^[2019-10-27T08:48:09.146Z] /usr/home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 FreeBSDQt5.13/src/persondata.cpp:129:2: warning: probably not needed anymore [-W#warnings][2019-10-27T08:48:09.718Z] 2 warnings generated.[2019-10-27T08:48:09.718Z] /usr/home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 FreeBSDQt5.13/src/personsmodel.cpp:241:33: warning: comparison of integers of different signs: 'quintptr' (aka 'unsigned long long') and 'int' [-Wsign-compare][2019-10-27T08:48:09.718Z] if (childIndex.internalId() == -1 || !childIndex.isValid()) {[2019-10-27T08:48:09.718Z] ~~~ ^  ~~[2019-10-27T08:48:09.976Z] 1 warning generated.[2019-10-27T08:48:10.236Z] [ 40%] Linking CXX shared library ../bin/libKF5People.so[2019-10-27T08:48:10.495Z] [ 40%] Built target KF5People[2019-10-27T08:48:10.495Z] Scanning dependencies of target duplicates_autogen[2019-10-27T08:48:10.495Z] Scanning dependencies of target personsproxymodeltest_autogen[2019-10-27T08:48:10.495Z] Scanning dependencies of target KF5PeopleWidgets_autogen[2019-10-27T08:48:10.495Z] Scanning dependencies of target contactlistwidgets_autogen[2019-10-27T08:48:10.495Z] Scanning dependencies of target personsmodeltest_autogen[2019-10-27T08:48:10.495Z] Scanning dependencies of target persondatatest_autogen[2019-10-27T08:48:10.495Z] [ 41%] Automatic MOC for target personsmodeltest[2019-10-27T08:48:10.495Z] [ 43%] Automatic MOC for target KF5PeopleWidgets[2019-10-27T08:48:10.495Z] [ 43%] Automatic MOC for target personsproxymodeltest[2019-10-27T08:48:10.495Z] [ 45%] Automatic MOC for target duplicates[2019-10-27T08:48:10.495Z] [ 46%] Automatic MOC for target persondatatest[2019-10-27T08:48:10.495Z] [ 47%] Automatic MOC for target contactlistwidgets[2019-10-27T08:48:11.525Z] [ 47%] Built target personsproxymodeltest_autogen[2019-10-27T08:48:11.525Z] [ 47%] Built target personsmodeltest_autogen[2019-10-27T08:48:11.803Z] Scanning dependencies of target personsproxymodeltest[2019-10-27T08:48:11.803Z] [ 47%] Built target persondatatest_autogen[2019-10-27T08:48:11.803Z] [ 47%] Built target KF5PeopleWidgets_autogen[2019-10-27T08:48:11.803Z] [ 47%] Built target duplicates_autogen[2019-10-27T08:48:11.803Z] [ 48%] Generating ui_person-details-presentation.h[2019-10-27T08:48:11.803Z] Scanning dependencies of target personsmodeltest[2019-10-27T08:48:11.803Z] [ 50%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/personsproxymodeltest_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:11.803Z] [ 51%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/personsmodeltest_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:11.803Z] [ 52%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/personsmodeltest.cpp.o[2019-10-27T08:48:11.803Z] [ 53%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/fakecontactsource.cpp.o[2019-10-27T08:48:11.803Z] [ 54%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/personsproxymodeltest.cpp.o[2019-10-27T08:48:11.803Z] Scanning dependencies of target duplicates[2019-10-27T08:48:11.803Z] [ 54%] Built target contactlistwidgets_autogen[2019-10-27T08:48:11.803Z] Scanning dependencies of target persondatatest[2019-10-27T08:48:11.803Z] [ 56%] Building CXX object examples/CMakeFiles/duplicates.dir/duplicates_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:11.803Z] [ 57%] Building CXX object examples/CMakeFiles/duplicates.dir/duplicates.cpp.o[2019-10-27T08:48:11.803Z] [ 58%] Building CXX object autotests/CMakeFiles/persondatatest.dir/persondatatest_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:11.803Z] [ 59%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/fakecontactsource.cpp.o[2019-10-27T08:48:12.095Z] Scanning dependencies of target KF5PeopleWidgets[2019-10-27T08:48:12.095Z] [ 60%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/KF5PeopleWidgets_autogen/mocs_compilation.cpp.o[2019-10-27T08:48:13.134Z] [ 62%] Building CXX object autotests/CMakeFiles/persondatatest.dir/persondatatests.cpp.o[2019-10-27T08:48:13.134Z] [ 63%] Building CXX object autotests/CMakeFiles/persondatatest.dir/fakecontactsource.cpp.o[2019-10-27T08:48:13.134Z] [ 64%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/persondetailsdialog.cpp.o[2019-10

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I like the approach.
  Just a few minor things.
  
  (and remember to remove the WIP from the commit log and the phab request)
  
  The passing of iterators to another thread *looks* scary, but of course it's 
safe here since we only run one subjob at a time, so the list can't change 
while the worker does its work.

INLINE COMMENTS

> deletejob.cpp:68
> +
> +public:
> +

can be removed

> deletejob.cpp:192
> +
> +m_ioworker = new DeleteJobIOWorkerPrivate;
> +m_ioworker->moveToThread(&m_thread);

I would remove the "Private" from the name, it makes one think that there is a 
corresponding public class somewhere.

> deletejob.cpp:194
> +m_ioworker->moveToThread(&m_thread);
> +m_thread.connect(&m_thread, &QThread::finished, m_ioworker, 
> &QObject::deleteLater);
> +m_ioworker->connect(m_ioworker, &DeleteJobIOWorkerPrivate::rmddirResult, 
> [=](bool result, const QList::iterator it){

You're using the 4-args connect, which is static, so `m_thread.connect` is 
confusing/wrong. This should be `QObject::connect` instead.

> deletejob.cpp:195
> +m_thread.connect(&m_thread, &QThread::finished, m_ioworker, 
> &QObject::deleteLater);
> +m_ioworker->connect(m_ioworker, &DeleteJobIOWorkerPrivate::rmddirResult, 
> [=](bool result, const QList::iterator it){
> +this->rmdirResult(result, it);

Prefer QObject::connect(4 args), the receiver is missing and could be q_func() 
for extra safety (so that the connect is broken if the DeleteJob is deleted, 
even if m_ioworker is leaked for some reason).

> deletejob.cpp:359
> +} else {
> +deleteNextFile();
> +}

(With the change I suggest below, this would just move to after 
`m_processedFiles++;` above. This would simplify the control flow in this 
method)

> deletejob.cpp:363
> +
> +SimpleJob* DeleteJobPrivate::deleteFileUsingJob (const QList::iterator 
> it)
> +{

No space after the method name.

This method could take a QUrl instead of an iterator, all it does is `*it` to 
get to the QUrl.

Even better, it could keep using an iterator, but also take care of of the two 
`erase(it)` calls and `addSubjob`. This is currently duplicated between the two 
callers. The only difference is `bool isLink`, you could pass that as parameter.

This would even be more consistent with `DeleteJobPrivate::deleteDirUsingJob` 
which takes care of `erase(it)` and `addSubjob`.

> deletejob.cpp:388
> +QList::iterator it = files.begin();
> +bool isLink = (it == files.end()); // No more files
> +if (isLink) {

You can make it `const` then.

> deletejob.cpp:397
> +// separate thread will do the work
> +//m_ioworker->rmfile((*it).toLocalFile());
> +QMetaObject::invokeMethod(m_ioworker, "rmfile", 
> Qt::QueuedConnection,

I suggest to remove the erroneous comment

> deletejob.cpp:461
> +  Q_ARG(const QList::iterator, 
> it));
> +return;
> +} else {

Move both `return` to after the `if/else`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24962

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24978: Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut

[Méven Car]

meven created this revision.
meven added reviewers: davidre, fvogt, apol, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Currently KglobalAccel uses NoDisplay to disable its component.
  But NoDisplay is to be used for hiding programs in menus.
  This keeps program whose desktop file are not displayed in Menu to have 
shortcuts.
  Ex: krunner D24857 
  
  Add a key "X-KDE-NoGlobalShortcut" specific for use in KglobalAccel and its 
kcm.
  
  Relates to D24956 

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24978

AFFECTED FILES
  src/services/kservice.cpp
  src/services/kservice.h

To: meven, davidre, fvogt, apol, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.13/12/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 27 Oct 2019 08:39:50 +
 Build duration:
6 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s)

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Volker Krause]

vkrause added a comment.


  In D24928#554514 , @ahmadsamir 
wrote:
  
  > In D24928#553952 , @vkrause 
wrote:
  >
  > > The cipher naming stuff looks very fishy though, that's not due to your 
changes though but coming from old KSslCipher code. I'm wondering where the 
ssl_cipher meta data is being consumed? If this is purely used for display, 
maybe let's just replace the entire string in there by QSslCipher::name()?
  >
  >
  > Looking at how ktorrent uses KIO::MetaData: 
https://lxr.kde.org/source/extragear/network/libktorrent/src/tracker/httptracker.cpp#0480
  >
  > gave me an idea to search for "ssl_cipher" on lxr.k.o, I found no hits at 
all. So nothing uses it in KDE, I don't know about 3rd party users. So maybe we 
just remove the digest method (or the whole sslCipher string), especially since 
cipher.name() is pretty descriptive.
  
  
  I did find uses, but they merely pass on the value, or display it in some 
way, ie. I found nothing that requires a specific format in there. I'd say 
let's go with QSslCipher::name() here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.13 - Build # 20 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.13/20/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 27 Oct 2019 08:39:50 +
 Build duration:
2 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)85%
(17/20)85%
(17/20)49%
(1940/3964)38%
(860/2238)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)68%
(266/392)46%
(62/134)src.imageformats93%
(13/14)93%
(13/14)49%
(1670/3437)39%
(796/2064)tests33%
(1/3)33%
(1/3)3%
(4/135)5%
(2/40)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/17/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 27 Oct 2019 08:39:50 +
 Build duration:
1 min 8 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr