D21235: Add handling of fuseiso filesystem type

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> fstabdevice.cpp:92
> +if (!isoFilePath.isEmpty()) {
> +m_description = ShortenPath(isoFilePath) + QLatin1String(" 
> on ") + m_product;
> +}

That's incorrect concatenation of translated strings.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

[Christoph Cullmann]

cullmann marked 2 inline comments as done.
cullmann added inline comments.

INLINE COMMENTS

> vonreth wrote in ispellcheckerclient.cpp:33
> is that needed? It should be handled by the qt main loop?

The docs state one shall do that in any case and that it stacks.
I think there is no harm to do it, just to be sure com is correctly initialized.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25244

To: cullmann, #frameworks, vonreth
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added a comment.


  In D24568#563092 , @davidedmundson 
wrote:
  
  > As an update on this from the Plasma POV.
  >
  > I added the macro to every repo and told every dev to do a final test 
before we commit the formatted results.
  >
  > I had some feedback and the result was that we can't proceed with in the 
current state [1].
  >
  > What's noteworthy is we were generally ok with the results from the first 
file we prepared in T11214 , so potentially 
we just need some settings tweaked. 
  >  I'll try and break that down into future diffs.
  >
  > 1.https://mail.kde.org/pipermail/plasma-devel/2019-November/106186.html
  
  
  For the comment alignment stuff, that is easy, we can just remove
  
  AlignTrailingComments: true
  
  For the other general "moving between different lines" stuff, I don't see any 
solution for this.
  
  You can arbitrary change the ColumnLimit, but as far as I know, it will just 
arbitrarily pack stuff together, like in the if conditions, if you have not 
e.g. comments in-between.
  
  But perhaps somebody else knows a proper switch for that.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D25328: Always rehiglhight() after definition was changed

[Christoph Cullmann]

cullmann added a comment.


  Hmm, the use case is that it re-highlights if you set an invalid definition?
  Perhaps one should just trigger rehighlight here just for that case, too.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25328

To: meven, kossebau, cullmann, vkrause
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D21660: remove dbus for windows build and change audio dep logic

[Christoph Cullmann]

cullmann added a comment.


  +1 for no dbus on Windows!

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: cullmann, habacker, aspotashev, bcooksley, apol, nicolasfella, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Let's just reopen this and work on improving it.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added reviewers: broulik, davidedmundson.
cullmann added a comment.


  For the lambda issue, I think we can add:
  
# keep lambda formatting multi-line if not empty
AllowShortLambdasOnASingleLine: Empty
  
  see https://clang.llvm.org/docs/ClangFormatStyleOptions.html
  
  That fixes for me the issue with the collapsed lambda.
  
  For the comments, as said, we can remove
  
AlignTrailingComments: true
  
  For the generic issue of stuff folded in one line, one can play with the 
ColumnLimit, but as said, that will still arbitrarily pack stuff as long as it 
fits the limit.
  
  Kai, could you try the two changes (for lambda and comments) by just 
temporarily changing that in the .clang-format file locally and rerunning make 
clang-format?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure, broulik, davidedmundson
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added a comment.


  Btw., I just tried e.g.
  
  https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format
  
  that one has exactly the same issues as our file and re-flows stuff into 
single lines (even lambdas).
  
  The only thing that often hinders that is the column limit of 100 there.
  
  That on the other side make as lot of code lot harder to read, too, like:
  
-
cc()->unregisterCompletionModel(KTextEditor::EditorPrivate::self()->wordCompletionModel());
 // would add additional items, we don't want that in tests
+cc()->unregisterCompletionModel(KTextEditor::EditorPrivate::self()
+->wordCompletionModel()); // 
would add additional items,
+  // 
we don't want that in tests

-
highlightMatchAttribute->dynamicAttribute(Attribute::ActivateMouseIn)->setBackground(searchColor);
-
highlightMatchAttribute->dynamicAttribute(Attribute::ActivateMouseIn)->setForeground(foregroundColor);
-
highlightMatchAttribute->dynamicAttribute(Attribute::ActivateCaretIn)->setBackground(searchColor);
-
highlightMatchAttribute->dynamicAttribute(Attribute::ActivateCaretIn)->setForeground(foregroundColor);
+highlightMatchAttribute->dynamicAttribute(Attribute::ActivateMouseIn)
+->setBackground(searchColor);
+highlightMatchAttribute->dynamicAttribute(Attribute::ActivateMouseIn)
+->setForeground(foregroundColor);
+highlightMatchAttribute->dynamicAttribute(Attribute::ActivateCaretIn)
+->setBackground(searchColor);
+highlightMatchAttribute->dynamicAttribute(Attribute::ActivateCaretIn)
+->setForeground(foregroundColor);
  
  (and that is just one of  places in KTextEditor that look like that 
afterwards).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure, broulik, davidedmundson
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Christoph Cullmann]

cullmann added a comment.


  The issue with this approach is, that you get "too high" lines for the case 
that none of this characters ever appear.
  Beside that, unfortunately, you get rendering artifacts in addition, as Qt 
will not paint e.g. selection high enough for lines without such chars.
  
  See e.g. attached screenshot.F7768081: rendering_issue.png 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25244: Implement ISpellChecker backend for Windows >= 8

[Hannah von Reth]

vonreth accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

BRANCH
  sonnet_ispellchecker_win

REVISION DETAIL
  https://phabricator.kde.org/D25244

To: cullmann, #frameworks, vonreth
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
cullmann marked an inline comment as done.
Closed by commit R246:67cbe8776a1f: Implement ISpellChecker backend for Windows 
>= 8 (authored by cullmann).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25244?vs=69544&id=69874

REVISION DETAIL
  https://phabricator.kde.org/D25244

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/ispellchecker/CMakeLists.txt
  src/plugins/ispellchecker/ispellcheckerclient.cpp
  src/plugins/ispellchecker/ispellcheckerclient.h
  src/plugins/ispellchecker/ispellcheckerdict.cpp
  src/plugins/ispellchecker/ispellcheckerdict.h

To: cullmann, #frameworks, vonreth
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.13 - Build # 19 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.13/19/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 17 Nov 2019 14:02:42 +
 Build duration:
2 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 200 lines...][2019-11-17T14:04:13.201Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\sonnet;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils'[2019-11-17T14:04:13.202Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\sonnet\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils\share'[2019-11-17T14:04:13.202Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils\lib\pkgconfig'[2019-11-17T14:04:13.202Z] QT_PLUGIN_PATH= 'C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\bin\plugins'[2019-11-17T14:04:13.202Z] QMAKEFEATURES = 'C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\mkspecs/features'[2019-11-17T14:04:13.202Z] QT_DATA_DIRS  = 'C:\CI\Software Installs\sonnet\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils\share'[2019-11-17T14:04:13.202Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-11-17T14:04:13.202Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-11-17T14:04:13.202Z] [2019-11-17T14:04:13.202Z] [2019-11-17T14:04:13.202Z] == Commencing Configuration:[2019-11-17T14:04:13.202Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/sonnet/" -G "NMake Makefiles JOM" -DBUILD_QCH=TRUE "C:\CI\workspace\Frameworks\sonnet\kf5-qt5 WindowsMSVCQt5.13"[2019-11-17T14:04:13.202Z] -- The C compiler identification is MSVC 19.16.27031.1[2019-11-17T14:04:14.270Z] -- The CXX compiler identification is MSVC 19.16.27031.1[2019-11-17T14:04:14.270Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe[2019-11-17T14:04:17.425Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe -- works[2019-11-17T14:04:17.425Z] -- Detecting C compiler ABI info[2019-11-17T14:04:19.110Z] -- Detecting C compiler ABI info - done[2019-11-17T14:04:19.110Z] -- Detecting C compile features[2019-11-17T14:04:21.488Z] -- Detecting C compile features - done[2019-11-17T14:04:21.488Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe[2019-11-17T14:04:23.871Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe -- works[2019-11-17T14:04:23.871Z] -- Detecting CXX compiler ABI info[2019-11-17T14:04:27.028Z] -- Detecting CXX compiler ABI info - done[2019-11-17T14:04:27.028Z] -- Detecting CXX compile features[2019-11-17T14:04:36.098Z] -- Detecting CXX compile features - done[2019-11-17T14:04:36.098Z] -- [2019-11-17T14:04:36.098Z] [2019-11-17T14:04:36.098Z] Installing in C:/CI/Software Installs/sonnet. Run C:/CI/workspace/Frameworks/sonnet/kf5-qt5 WindowsMSVCQt5.13/build/prefix.sh to set the environment for Sonnet.[2019-11-17T14:04:36.098Z] -- Looking for __GLIBC__[2019-11-17T14:04:36.098Z] -- Looking for __GLIBC__ - not found[2019-11-17T14:04:36.098Z] -- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support[2019-11-17T14:04:36.098Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-11-17T14:04:36.616Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-11-17T14:04:37.133Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed[2019-11-17T14:04:37.133Z] -- Performing Test COMPILER_HAS_DEPRECATED[2019-11-17T14:04:39.511Z] -- Performing Test COMPILER_HAS_DEPRECATED - Success[2019-11-17T14:04:39.511Z] -- Found Doxygen: C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/dev-utils/bin/doxygen.exe (found suitable version "1.8.14", minimum required is "1.8.13") found components:  doxygen missing components:  dot[2019-11-17T14:04:43.529Z] -- Found QHelpGenerator executable: C:/Craft/CI-Qt513/windows-msvc2017_64-cl-debug/bin/qhelpgenerator.exe[2019-11-17T14:04:43.529Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2019-11-17T14:04:43.529Z] -- Could NOT find ASPELL (missing: ASPELL_LIBRARIES ASPELL_INCLUDE_DIR ASPELL_EXECUTABLE) [2019-11-17T14:04:43.529Z] -- Could NOT find HSPELL (missing: HSPELL_LIBRARIES HSPELL_INCLUDE_DIR) [2019-11-17T14

KDE CI: Frameworks » sonnet » kf5-qt5 WindowsMSVCQt5.13 - Build # 20 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/sonnet/job/kf5-qt5%20WindowsMSVCQt5.13/20/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 17 Nov 2019 14:08:32 +
 Build duration:
5 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D25355: [Samba] Improve warning message about netbios name

[Méven Car]

meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Before:
  kf5.kio.core: We got some errors while running testparm "Load smb config 
files from /etc/samba/smb.conf\nLoaded services file OK.\nWARNING: The 'netbios 
name' is too long (max. 15 chars).\n\n"
  
  After:
  kf5.kio.core: The samba 'netbios name' parameter was longer than the 
authorized 15 characters. It may be because your hostname is longer than 13 and 
samba default 'netbios name' defaults to 'hostname-W' If that it is the case 
simply define a netbios name parameter in /etc/samba/smb.conf at most 15 
characters long

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25355: [Samba] Improve warning message about netbios name

[Méven Car]

meven updated this revision to Diff 69877.
meven added a comment.


  Display leftovers warnings if any

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25355?vs=69876&id=69877

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25355: [Samba] Improve warning message about netbios name

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25355

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25355: [Samba] Improve warning message about netbios name

[Méven Car]

meven updated this revision to Diff 69878.
meven edited the summary of this revision.
meven added a comment.


  Fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25355?vs=69877&id=69878

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

AFFECTED FILES
  src/core/ksambashare.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  Can you remove the line width changes from this? When this patch just adds 
the transparent blue background, I think it's pretty uncontroversial and read 
to land quickly.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21235: Add handling of fuseiso filesystem type

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in fstabdevice.cpp:92
> That's incorrect concatenation of translated strings.

yeah, should be `m_description = i18nc("provide context here", %1 on %2, 
ShortenPath(isoFilePath), m_product);`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25355: [Samba] Improve warning message about netbios name

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25355

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove updated this revision to Diff 69879.
niccolove added a comment.


  Resized 2px tabbar line to 3px

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25334?vs=69841&id=69879

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove updated this revision to Diff 69880.
niccolove added a comment.


  Changed 2px lines to 3px

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69851&id=69880

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove added a comment.


  In D25340#563593 , @ndavis wrote:
  
  > Here's a cleaned up version of the file with the changes Nate and I 
requested: F7767647: tasks.svg 
  
  
  Oh sorry, I missed this. I'll use that file.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove updated this revision to Diff 69882.
niccolove added a comment.


  Tweaked colors of icon view backgrounds

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69880&id=69882

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 69886.
niccolove added a comment.


  Updated breeze shadows

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25015?vs=69820&id=69886

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove added a comment.


  Finally! I'm 100% this works now.
  
  In D25015#563300 , @niccolove 
wrote:
  
  > This is a comparison: F7766697: Screenshot_20191116_165659.png 

  >  The problem is not that you don't see, it's that it doesn't show. I'll try 
to understand what's going on and get back to you.
  
  
  Please refer to the comparison to see the difference, although I think it's 
quite noticeable :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

[Filip Fila]

filipf added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

[Christoph Cullmann]

cullmann added a comment.


  This allows to shrink e.g. the Kate installation on Windows from 431 MB to 
274 MB, > 150 MB space less occupied ;=)

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25244

To: cullmann, #frameworks, vonreth
Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Nathaniel Graham]

ngraham added a comment.


  Yep, can confirm that it works now. It is indeed a more subtle and pleasing 
effect. I still think the distance away from the window would be lengthened to 
make it even nicer-looking. :) But if nobody else agrees, I'm okay with this in 
its current form.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Nathaniel Graham]

ngraham added a comment.


  I'm not 100% sure how I feel about the change to use the same background 
color for "open" and "minimized" states and distinguish the two entirely with 
the presence or absence of a gray line. It feels very subtle, almost too much 
so. I preferred it when the open and minimized states had a more immediately 
obvious visual difference.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Nathaniel Graham]

ngraham added a comment.


  I don't hate the current state, let me note. It's just not what I expected, 
and I feel like I would need to get used to it rather than immediately falling 
in love with it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25331: Duplicate QML installation for unit tests

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Maybe wrap in if(BUILD_TESTING)

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25331

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19498: loadLibrary: Use enum values to define what type of plugin we load

[Alexander Potashev]

This revision was automatically updated to reflect the committed changes.
Closed by commit R317:f6a65feda870: loadLibrary: Use enum values to define what 
type of plugin we load (authored by aspotashev).

REPOSITORY
  R317 Kross

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19498?vs=53083&id=69890

REVISION DETAIL
  https://phabricator.kde.org/D19498

AFFECTED FILES
  src/core/manager.cpp

To: aspotashev, #frameworks, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  This seems perfect to me. A big visual improvement IMO. Any objections?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove added a comment.


  Now that we got back the 3px line, I would say that it is recognizable. I 
like the idea of having the background and reinforcing the idea that 
line=visible. But it's such a minor change that I would be okay with any option 
really.
  F7768659: Screenshot_20191117_210453.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  These colors don't look right
  F7768670: Screenshot_20191117_152000.png 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Xuetian Weng]

xuetianweng added a comment.


  Any idea about how konsole derive
  
  In D25339#563656 , @cullmann wrote:
  
  > The issue with this approach is, that you get "too high" lines for the case 
that none of this characters ever appear.
  >  Beside that, unfortunately, you get rendering artifacts in addition, as Qt 
will not paint e.g. selection high enough for lines without such chars.
  >
  > See e.g. attached screenshot.F7768081: rendering_issue.png 

  
  
  Then what is the ideal solution to you for this case?
  
  Having different font height for every line? Or keep this "slightly higher 
line" by do vertical center align  and fix the artifact?
  
  At least the current state doesn't look right to me and I think it need to be 
fixed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  Even if the colors are fixed, there are a number of other places that need 
fixes in order for this to look right, so I think we should hold off landing 
this until these issues are fixed:
  Not extending to the edge: F7768790: Screenshot_20191117_171047.png 

  Something about this feels wrong: F7768797: Screenshot_20191117_171225.png 

  Same here: F7768799: Screenshot_20191117_171323.png 

  
  These may need separate patches to the code that controls the widgets.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  tabbar_blue_background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25331: Duplicate QML installation for unit tests

[David Edmundson]

davidedmundson updated this revision to Diff 69896.
davidedmundson added a comment.


  update

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25331?vs=69816&id=69896

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25331

AFFECTED FILES
  src/qml/CMakeLists.txt

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Frameworks, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  CCBUG: 379498

TEST PLAN
  - Set `LeftClickNavigatesByPage=true` in the `[KDE]` section of 
~/.config/kdeglobals
  - Click in the scroll trough in a Qt/KDE app
  - See that the scroll handle position jumps right there
  - Set `LeftClickNavigatesByPage=false` or remove it from kdeglobals
  - Click in the scroll trough in a Qt/KDE app
  - See that the scroll handle moves up or down by one page height

REPOSITORY
  R252 Framework Integration

BRANCH
  left-click-warps-scrollbar-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25360

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: ngraham, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

[Nathaniel Graham]

ngraham added a dependent revision: D25361: [Workspace KCM] Expose setting to 
choose what left-clicking in the scroll trough does.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D25360

To: ngraham, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25331: Duplicate QML installation for unit tests

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25331

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  In D25340#563783 , @ngraham wrote:
  
  > I don't hate the current state, let me note. It's just not what I expected, 
and I feel like I would need to get used to it rather than immediately falling 
in love with it.
  
  
  What could be done to make it better? I noticed the same feeling myself, but 
decreasing the opacity of the inactive/minimized modes felt better.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Nathaniel Graham]

ngraham added a comment.


  Decreasing the opacity of the icon itself? Maybe that could work.
  
  A pet peeve I have with the status quo is that minimized apps/windows have 
greater visual prominence than other ones, which seems backwards. This patch 
generally fixes that (especially for the active app/window), but now minimized 
apps/windows have a state that looks too similar to other ones. We just need to 
figure out how to make that state look de-emphasized.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  In D25340#563908 , @ngraham wrote:
  
  > Decreasing the opacity of the icon itself? Maybe that could work.
  
  
  Not the icon, the background.
  
  > A pet peeve I have with the status quo is that minimized apps/windows have 
greater visual prominence than other ones, which seems backwards. This patch 
generally fixes that (especially for the active app/window), but now minimized 
apps/windows have a state that looks too similar to other ones. We just need to 
figure out how to make that state look de-emphasized.
  
  I agree.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25334: Added transparent blue background to tabbars

[Nathaniel Graham]

ngraham added a comment.


  In D25334#563841 , @ndavis wrote:
  
  > Even if the colors are fixed, there are a number of other places that need 
fixes in order for this to look right, so I think we should hold off landing 
this until these issues are fixed:
  >  Not extending to the edge: F7768790: Screenshot_20191117_171047.png 

  
  
  This was originally fixed by D19745 , but 
that got reverted in 2594eb1b33b56ec7e0e8eb6c37acb1c7f2a5a1ff 
 
because it caused other regressions that the patch author never returned to 
correct. We'd need to revisit this and do it in a regression-free manner.
  
  > Something about this feels wrong: F7768797: Screenshot_20191117_171225.png 

  
  I agree. IMO double-width panels need to increase the size of the icons by 
default, because having a grid rather than a row is just awful and encourages 
the use of like 20 icons. We get many bug reports about people wanting this 
changed by default: https://bugs.kde.org/show_bug.cgi?id=360333 It's easily 
worked around locally by adding `iconSize=2` to 
`~/.config/plasma-org.kde.plasma.desktop-appletsrc` in the section that has 
`extraItems=` in it. It's a pretty trivial solution that works fairly well as 
the icons scale themselves down when the panel is shorter. Looks like this with 
a double-height panel: F7769037: Screenshot_20191117_183648.png 

  
  Maybe worth investigating.
  
  > Same here: F7768799: Screenshot_20191117_171323.png 

  
  Looks like a lack of adequate side margins. This code is super fragile, 
sadly. I can give it a look-see.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  F7769041: Screenshot_20191117_203818.png 

  15% Inactive BG opacity
  10% Minimized BG opacity

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/59/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 01:44:37 +
 Build duration:
1 min 42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D25339#563822 , @xuetianweng 
wrote:
  
  > Having different font height for every line?
  
  
  
  
  1. We don't want a bigger lines
  2. We don't want a lines that are bigger that other in a view.
  3. We don't want different font height in a view.
  
  I don't know which is best.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

[Christoph Cullmann]

cullmann added a comment.


  Actually, I could live with:
  
  1. All lines are a bit higher, for me that makes reading even easier. But the 
rendering shall have no glitches.
  2. Some lines have different heights. But I assume this is hard to implement 
at the moment.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann