D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio added inline comments.

INLINE COMMENTS

> bruns wrote in usermetadatawritertest.cpp:44
> You can just use the static overload and provide an invalid target name.
> https://doc.qt.io/qt-5/qfile.html#link-1

You are right. I tried that with an empty string and it didn't work, but it 
does with a non-existent filename.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio updated this revision to Diff 70035.
iasensio marked an inline comment as done.
iasensio added a comment.


  - Simplify symlink creation

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25414?vs=70031=70035

BRANCH
  fix_symlink

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  autotests/usermetadatawritertest.cpp
  autotests/usermetadatawritertest.h
  src/xattr_p.h

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> usermetadatawritertest.cpp:44
> +QFile tempTarget(testFilePath("temporal_target"));
> +tempTarget.link(testFilePath(TEST_SYMLINK));
> +tempTarget.remove();

You can just use the static overload and provide an invalid target name.
https://doc.qt.io/qt-5/qfile.html#link-1

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25407: EBN cleanup to change quotes and transport protocol

[John Hayes]

jhayes added a comment.


  This diff was the changes that was made to two lines in a total of two files. 
Arc sent the original diff with nothing but svg changes.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25407

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio edited the test plan for this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25407: EBN cleanup to change quotes and transport protocol

[John Hayes]

jhayes updated this revision to Diff 70030.
jhayes added a comment.


  This is what the diff should have been to start with

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25407?vs=70005=70030

REVISION DETAIL
  https://phabricator.kde.org/D25407

AFFECTED FILES
  autotests/newlinetest.cpp
  autotests/scalabletest.cpp

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio updated this revision to Diff 70031.
iasensio added a comment.


  - Use temporal symlink

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25414?vs=70029=70031

BRANCH
  fix_symlink

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  autotests/usermetadatawritertest.cpp
  autotests/usermetadatawritertest.h
  src/xattr_p.h

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio updated this revision to Diff 70029.
iasensio marked 2 inline comments as done.
iasensio added a comment.


  - Protect from size < 0
  - Add test case for dangling symlink

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25414?vs=70019=70029

BRANCH
  fix_symlink

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  autotests/samplefiles/dangling_symlink
  autotests/usermetadatawritertest.cpp
  autotests/usermetadatawritertest.h
  src/xattr_p.h

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Stefan Brüns]

bruns added a comment.


  Also add a testcase covering this, autotests/usermetadatawritertest.cpp

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Stefan Brüns]

bruns added a comment.


  wrap the summary at <80 characters

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Stefan Brüns]

bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25414: xattr: fix crash on dangling symlinks

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> xattr_p.h:228
>  
> +if (size == -1 && errno == ENOENT) {
> +return UserMetaData::Attribute::None;

if (size < 0) {
if (errno == E2BIG) {
  return UserMetaData::Attribute::All;
}
  
return UserMetaData::Attribute::None;
  }

> xattr_p.h:240
>  
>  if (size > 0 && attributes == UserMetaData::Attribute::Any) {
>  return UserMetaData::Attribute::All;

The `size > 0` can be removed here then.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25276: reStructuredText: Fix inline literals highlighting preceding characters

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> rest.xml:14
>-->
>   mimetype="text/x-rst" version="5" kateversion="2.4" casesensitive="1">
>  

Please increase the version from 5 to 6. Every time a highlighting file is 
changed this needs to be done.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25276

To: adrianchavesfernandez, mosra
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio created this revision.
iasensio added a reviewer: astippich.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  When requesting metadata on a dangling symlink, the framestack ends up 
calling `k_queryAttributes` with the symlink path.
  There, the `listxattr` syscall returns `size=-1` and `errno=ENOENT` (2 No 
such file or directory), which was not covered before, and provoking a segfault 
on `QByteArray`. Full traceback on: https://bugs.kde.org/show_bug.cgi?id=414227
  
  It might be also a good idea to protect the function in any other cases where 
`size=-1`
  
  BUG: 414227

TEST PLAN
  On dolphin, with panel information open, hover over a dangling symlink

REPOSITORY
  R286 KFileMetaData

BRANCH
  fix_symlink

REVISION DETAIL
  https://phabricator.kde.org/D25414

AFFECTED FILES
  src/xattr_p.h

To: iasensio, astippich
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25219: Only create a session config when actually restoring a session

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kconfiggui.cpp:73
>  {
>  return sessionConfig()->name();
>  }

sessionConfig() can be nullptr can you add a check.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25409: rst: Add support for standalone hyperlinks

[Adrián Chaves Fernández]

adrianchavesfernandez added a reviewer: mosra.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25409

To: adrianchavesfernandez, mosra
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25409: rst: Add support for standalone hyperlinks

[Adrián Chaves Fernández]

adrianchavesfernandez created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
adrianchavesfernandez requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  rst-standalone-hyperlinks

REVISION DETAIL
  https://phabricator.kde.org/D25409

AFFECTED FILES
  autotests/folding/highlight.rst.fold
  autotests/html/highlight.rst.html
  autotests/input/highlight.rst
  autotests/reference/highlight.rst.ref
  data/syntax/markdown.xml
  data/syntax/rest.xml

To: adrianchavesfernandez
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25219: Only create a session config when actually restoring a session

[Nathaniel Graham]

ngraham added a comment.


  Can I get a review on this?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25219

To: ngraham, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25106: Also allow invoking session restoration logic when apps are manually launched

[Nathaniel Graham]

ngraham added a comment.


  Can I get a review on this?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25106

To: ngraham, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25407: EBN cleanup to change quotes and transport protocol

[John Hayes]

jhayes added a comment.


  I checked the diff and this change is not what I changed. I changed 3
  characters total out of 2 files.
  
  John Hayes

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25407

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25276: reStructuredText: Fix inline literals highlighting preceding characters

[Adrián Chaves Fernández]

adrianchavesfernandez added a reviewer: mosra.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25276

To: adrianchavesfernandez, mosra
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25401: Fix deprecation syntax in ktcpsocket.h

[Volker Krause]

vkrause added a comment.


  In D25401#564683 , @dfaure wrote:
  
  > As a data point: this commit changes things for kimap, which has code saying
  >
  >   src/imapstreamparser.cpp:493:} else if (KTcpSocket *socket = 
qobject_cast(m_socket)) {
  >   src/imapstreamparser.cpp-494-qWarning() << "No incoming 
packet for" << dt.elapsed()/1000 << "seconds on TCP socket. state=" << 
socket->state() << "error=" << socket->error() << socket->errorString();
  >
  >
  > With the class being deprecated, this code now fails to build (because of 
the "-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06" big hammer).
  >  The obvious fix is then to add this to kimap's CMakeLists.txt:
  >
  >   add_definitions(-DKIOCORE_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054000) # We 
need KTcpSocket
  >
  >
  > IMHO this is all correct. We *are* using a deprecated class, it's important 
to know it, even if we didn't instantiate it ourselves. Because this means 
there will be porting effort when the class is removed.
  >  In some cases one can right away port to a non-deprecated solution, or in 
this case where we do need to keep support for older KF5 versions, we need to 
enable the use of the deprecated class for a little while longer.
  
  
  I don't see KTcpSocket in kimap? Or is that some older branch? Then that most 
definitely should not have the 6.0 deprecation version set.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25401

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25407: EBN cleanup to change quotes and transport protocol

[John Hayes]

jhayes created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jhayes requested review of this revision.

REVISION SUMMARY
  Change from "" to '' to add a char to a string. Change transport protocol 
from http to https.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25407

AFFECTED FILES
  icons-dark/apps/48/baloo.svg
  icons-dark/preferences/32/baloo.svg
  icons-dark/preferences/32/preferences-desktop-baloo.svg
  icons/apps/48/baloo.svg
  icons/preferences/32/baloo.svg
  icons/preferences/32/preferences-desktop-baloo.svg

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22946: Include API to generically implement --replace arguments

[Aleix Pol Gonzalez]

apol updated this revision to Diff 69997.
apol added a comment.


  Made the code less "racey"

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22946?vs=69147=69997

BRANCH
  arcpatch-D22946

REVISION DETAIL
  https://phabricator.kde.org/D22946

AFFECTED FILES
  src/kdbusservice.cpp
  src/kdbusservice.h

To: apol, #frameworks, davidedmundson
Cc: davidedmundson, broulik, kossebau, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Nathaniel Graham]

ngraham added a comment.


  In D25340#563913 , @ndavis wrote:
  
  > F7769041: Screenshot_20191117_203818.png 

  >  15% Inactive BG opacity
  >  10% Minimized BG opacity
  
  
  Might be too subtle, maybe more opacity would be needed

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25402: [KDirOperator] Add Backspace shortcut to cdUp action

[Méven Car]

meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Very useful when navigating with keyboard in the KDirOperator

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25402

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 319 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/319/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 19 Nov 2019 14:14:57 +
 Build duration:
8 min 45 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/404)67%
(271/404)56%
(34714/61703)40%
(17594/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9658/10118)47%
(4502/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)60%
(8680/14579)51%
(4518/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4670/8288)43%
(2025/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1799/4291)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 188 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/188/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 19 Nov 2019 14:14:57 +
 Build duration:
8 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25084: Allow a Multiple instances to become Unique

[David Faure]

dfaure added a comment.


  > Just speculating, if an app opens as multiple and then another instance 
tries to open as unique, it should reuse the existing one or merge?
  
  With a konsole state of mind, I can see how this would possibly make sense 
indeed.
  But it would break DBus-activation of unique applications (if it is ever 
possible to start one of those as "multiple").
  
  When you make a call to "org.kde.kmail" and kmail or kontact isn't running, 
then the org.kde.kmail.service file installed into the DBus services directory 
leads to DBus activation, i.e. this starts kmail, which then registers as 
org.kde.kmail (as expected!), which allows the DBus call to proceed.
  If instead, it would register as org.kde.kmail-1234 because there happens to 
be such a name on the bus already, then the call would fail.
  
  I admit that I don't know of an application which supports both Multiple and 
Unique, and which also provides a dbus service file for the activation feature.
  But this scenario makes me wonder if the magic that you have in mind should 
be in konsole itself instead of kdbusaddons, to avoid affecting other 
applications.
  
  I'm open to counter-arguments and counter-examples. Actually, do we know of 
any other app than konsole which supports both Multiple and Unique modes?

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D25084

To: tcanabrava, adridg, dfaure
Cc: dfaure, GB_2, davidedmundson, adridg, ngraham, kde-frameworks-devel, 
LeGast00n, michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  Please, consider using 3px highlight so tabs don't look like this.
  This one is from the kickoff task but it would also happen in Audio Volume.
  F7771606: IMG_20191119_151319.jpg 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:eab483fa2eab: when kioslave5 couldnt be found in 
libexec-ish locations try $PATH (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25308?vs=69757=69995#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25308?vs=69757=69995

REVISION DETAIL
  https://phabricator.kde.org/D25308

AFFECTED FILES
  src/core/slave.cpp

To: sitter, dfaure, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Re: Bulk replacement of projects.kde.org on Frameworks modules

[David Faure]

On samedi 16 novembre 2019 16:25:37 CET Luigi Toscano wrote:
> Luigi Toscano ha scritto:
> > Hi,
> > basically all Frameworks components reference the ECM website
> > using the old projects.kde.org URL, which is long gone and
> > it is just a (partial) redirect.
> > 
> > See for example:
> > 
> > set_package_properties(ECM PROPERTIES TYPE REQUIRED
> > 
> > DESCRIPTION "Extra CMake Modules."
> > URL
> > "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;)
> > 
> > Can I go around a bulk-replace all the URLs with
> > https://commits.kde.org/extra-cmake-modules, so that it would look like:
> > 
> > set_package_properties(ECM PROPERTIES TYPE REQUIRED
> > 
> > DESCRIPTION "Extra CMake Modules."
> > URL "https://commits.kde.org/extra-cmake-modules;)
> > 
> > There are few additional URLs which use the old website and I would
> > replace
> > them as well using the same pattern.
> > 
> > I'm asking to avoid ~70 almost-identical review requests.
> 
> Apart from Elvis (here) and Volker (on IRC), any other ack? (looking
> especially for dfaure :)

Ack for a global search/replace without review.

No idea about which URL to use though, I'll trust you and others about that.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D25401: Fix deprecation syntax in ktcpsocket.h

[David Faure]

dfaure added a comment.


  As a data point: this commit changes things for kimap, which has code saying
  
src/imapstreamparser.cpp:493:} else if (KTcpSocket *socket = 
qobject_cast(m_socket)) {
src/imapstreamparser.cpp-494-qWarning() << "No incoming 
packet for" << dt.elapsed()/1000 << "seconds on TCP socket. state=" << 
socket->state() << "error=" << socket->error() << socket->errorString();
  
  With the class being deprecated, this code now fails to build (because of the 
"-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06" big hammer).
  The obvious fix is then to add this to kimap's CMakeLists.txt:
  
add_definitions(-DKIOCORE_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054000) # We 
need KTcpSocket
  
  IMHO this is all correct. We *are* using a deprecated class, it's important 
to know it, even if we didn't instantiate it ourselves. Because this means 
there will be porting effort when the class is removed.
  In some cases one can right away port to a non-deprecated solution, or in 
this case where we do need to keep support for older KF5 versions, we need to 
enable the use of the deprecated class for a little while longer.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25401

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

[Alexander Volkov]

volkov added a comment.


  Qt Core
  
> cat qt_lib_widgets.pri | grep depends
QT.widgets.depends = core gui

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D25397

To: volkov, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

[Albert Astals Cid]

aacid added a comment.


  I don't know much about creating pri files but looks sensible.
  
  Do you know what is the "core" that moved from the DEPS on KF5Auth to 
KF5AuthCore?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D25397

To: volkov, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24990#564670 , @dfaure wrote:
  
  > So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while 
building FOO itself, right? Either magically here, or manually in every 
module...
  
  
  Nono, FOO_DISABLE_DEPRECATED_BEFORE_AND_AT does not need to be touched, that 
works fine.
  We want to rather have a new sane automatism for sane values of 
FOO_DEPRECATED_WARNINGS_SINCE in the build of FOO, despite group variables 
being set. While also still allowing full flexibility to other non-KF usage 
patterns.
  I have a small set of approaches drafted/tested so far, but need to explore 
them in full details yet for all KDE & non-KDE usages I know about (& imagine). 
Just mentioning here that I am cooking up something :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

[David Faure]

dfaure added a comment.


  So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while building 
FOO itself, right? Either magically here, or manually in every module...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Hm, only noticed now that this actually has an unwanted sideeffects: it 
triggers deprecation warnings for all deprecated warning also inside each 
library itself. Which is not what one wants.
  
  Because so far FOO_DISABLE_DEPRECATED_BEFORE_AND_AT as set while building 
library FOO defaults FOO_DEPRECATED_WARNINGS_SINCE to the same version, which 
means, any calls of own deprecated API will be without warnings as well as also 
with the autotests (due to definitions being exported in the BUILD interface). 
But with the group variant of *_DEPRECATED_WARNINGS_SINCE now being set, 
FOO_DEPRECATED_WARNINGS_SINCE instead defaults to that value.
  
  Reserved some time this week to give this some more thought, so far no 
satisfying proposal yet developed.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24990

To: kossebau, #frameworks, #build_system, apol, dfaure
Cc: dfaure, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25401: Fix deprecation syntax in ktcpsocket.h

[Friedrich W. H. Kossebau]

kossebau added a comment.


  One thing I saw with the Qt deprecation tags is that deprecation attributes 
were only added to constructor calls, not the class itself.
  Which to me made some sense, as one should be warned when creating instances 
of that class. But once you are passed an instance due to other reasons, being 
warned about furher calls on the instance makes no real sense, as one has to 
use the instance now that it exists.
  In the initial set of patches to KF with the new deprecation macros I also 
did it like that for deprecated classes,  added the warning macros only to 
constructor or other generation functions, not next to the class keyword.
  
  Not sure how compilers actually react on deprecation attributes to the class 
only, still have to look up in what warnings on which class usages that results.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25401

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25401: Fix deprecation syntax in ktcpsocket.h

[David Faure]

dfaure created this revision.
dfaure added reviewers: vkrause, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  gcc (7.4.1 here) says:
  ktcpsocket.h:171:22: warning: attribute ignored in declaration of ‘class 
KTcpSocket’ [-Wattributes]
   class KIOCORE_EXPORT KTcpSocket: public QIODevice
  
^~
  
  ktcpsocket.h:171:22: note: attribute for ‘class KTcpSocket’ must follow the 
‘class’ keyword

TEST PLAN
  builds without that warning

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25401

AFFECTED FILES
  src/core/ktcpsocket.h

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:ec2e765242f5: Make the docs reflect that setIconName 
should be preferred over setPixmap when… (authored by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25396?vs=69986=69990

REVISION DETAIL
  https://phabricator.kde.org/D25396

AFFECTED FILES
  src/knotification.h

To: nicolasfella, #plasma, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  doc

REVISION DETAIL
  https://phabricator.kde.org/D25396

To: nicolasfella, #plasma, broulik, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25389: Verify modes of the session config file

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Sounds reasonable, code looks better, too!
  Thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  verify-session-modes

REVISION DETAIL
  https://phabricator.kde.org/D25389

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 19 Nov 2019 11:53:14 +
 Build duration:
4 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D18610: Introduce KF5AuthCore

[Alexander Volkov]

volkov added a comment.


  Fix for .pri: D25397 

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: volkov, rikmills, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

[Alexander Volkov]

volkov added a reviewer: aacid.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D25397

To: volkov, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25397: Install .pri file for KAuthCore

[Alexander Volkov]

volkov created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
volkov requested review of this revision.

REVISION SUMMARY
  And fix dependencies in .pri file for KAuth.
  This commit amends 65db21c6fc5369ad498b959b08ab8de19b73c5c4 
.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25397

AFFECTED FILES
  src/CMakeLists.txt

To: volkov
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25396: Make the docs reflect that setIconName should be preferred over setPixmap when possible

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R289 KNotifications

BRANCH
  doc

REVISION DETAIL
  https://phabricator.kde.org/D25396

AFFECTED FILES
  src/knotification.h

To: nicolasfella, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 19 Nov 2019 11:15:02 +
 Build duration:
1 min 36 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D25394: support Qt File selectors in KPackage

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:2fa9f54224d7: support Qt File selectors in KPackage 
(authored by mart).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25394?vs=69980=69981

REVISION DETAIL
  https://phabricator.kde.org/D25394

AFFECTED FILES
  src/kpackage/package.cpp
  src/kpackage/private/package_p.h

To: mart, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25394: support Qt File selectors in KPackage

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  phab/selectors

REVISION DETAIL
  https://phabricator.kde.org/D25394

To: mart, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25394: support Qt File selectors in KPackage

[Marco Martin]

mart updated this revision to Diff 69980.
mart added a comment.


  - directly delete

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25394?vs=69979=69980

BRANCH
  phab/selectors

REVISION DETAIL
  https://phabricator.kde.org/D25394

AFFECTED FILES
  src/kpackage/package.cpp
  src/kpackage/private/package_p.h

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25394: support Qt File selectors in KPackage

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  support for things like contents/ui/+phone/main.qml
  right now in qml based packages qml file selectors are supported as
  there is always one internal for qml, for every file, *except*
  main.qml or any loaded directly by kpackage.
  this gives the same behavior between main.qml and every other file
  in the package

TEST PLAN
  package without selector folders works exactly the same and every plasmoid
  kcm and so on is loaded fine.
  if one adds for instance in a kcm package under ui the subfolder +phone with 
a 
  main.qml, then export QT_FILE_SELECTORS=phone, that alternative qml file will 
be 
  loaded instead

REPOSITORY
  R290 KPackage

BRANCH
  phab/selectors

REVISION DETAIL
  https://phabricator.kde.org/D25394

AFFECTED FILES
  src/kpackage/package.cpp
  src/kpackage/private/package_p.h

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Alexander Volkov]

volkov added a comment.


  What about qmake?
  I came across the following error:
  
g++ -Wl,-z,relro -o ... /usr/lib/x86_64-linux-gnu/libQt5Gui.so 
/usr/lib/x86_64-linux-gnu/libKF5Auth.so 
/usr/lib/x86_64-linux-gnu/libKF5CoreAddons.so 
/usr/lib/x86_64-linux-gnu/libQt5Core.so /usr/lib/x86_64-linux-gnu/libGL.so 
-lpthread   
/usr/bin/ld: ...: undefined reference to symbol '_ZN5KAuth11ActionReplyD1Ev'
/usr/bin/ld: //usr/lib/x86_64-linux-gnu/libKF5AuthCore.so.5: error adding 
symbols: DSO missing from command line

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid, apol
Cc: volkov, rikmills, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25149: Add a new template for KCMs

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> kcm.cpp:37
> +KAboutData* about = new KAboutData(
> +QStringLiteral("kcm_%{APPNAMELC}"), i18n("%{APPNAME} Configuration 
> Module"),
> +QStringLiteral("0.1"), QString(), KAboutLicense::GPL,

Nitpick: indentation looks broken here, I think it wasn't earlier.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava, #plasma, #frameworks, mart, ervin
Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, 
kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart