date:20191207

D25700: [KHistoryComboBox] Add method to set an icon provider

2019-12-07 Thread Nicolas Fella

nicolasfella added a reviewer: dfaure.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D25700

To: nicolasfella, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

2019-12-07 Thread Nicolas Fella

nicolasfella updated this revision to Diff 71072.
nicolasfella added a comment.


  - For real

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25700?vs=71071&id=71072

BRANCH
  icopro

REVISION DETAIL
  https://phabricator.kde.org/D25700

AFFECTED FILES
  src/CMakeLists.txt
  src/khistorycombobox.cpp
  src/khistorycombobox.h

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

2019-12-07 Thread Nicolas Fella

nicolasfella updated this revision to Diff 71071.
nicolasfella added a comment.


  - Adapt deprecation version

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25700?vs=71070&id=71071

BRANCH
  icopro

REVISION DETAIL
  https://phabricator.kde.org/D25700

AFFECTED FILES
  src/CMakeLists.txt
  src/khistorycombobox.cpp
  src/khistorycombobox.h

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

2019-12-07 Thread Nicolas Fella

nicolasfella updated this revision to Diff 71070.
nicolasfella added a comment.


  - Deprecation, fix, and docs

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25700?vs=70794&id=71070

BRANCH
  icopro

REVISION DETAIL
  https://phabricator.kde.org/D25700

AFFECTED FILES
  src/CMakeLists.txt
  src/khistorycombobox.cpp
  src/khistorycombobox.h

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-07 Thread Filip Fila

filipf added a comment.


  In D25699#573713 , @fvogt wrote:
  
  > The check for the prefix was added in 
`bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got 
added much earlier.
  >
  > The labels are visible again with just the `control.flat` condition, but 
the prefix one might be needed as well for non-breeze themes.
  >
  > There's a part missing though, the triangle (visible on 
https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is 
gone. That seems to be a feature lost with PC3 :-(
  
  
  Thanks for looking into the patch.
  
  Yeah, the triangle seems to be missing :/ possibly because PC2 has a menu 
property and PC3 doesn't... I will investigate further.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: fvogt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25802: Don't use obsolete qVariantFromValue

2019-12-07 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R486:c167627675e8: Don't use obsolete qVariantFromValue 
(authored by nicolasfella).

REPOSITORY
  R486 QCA Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25802?vs=71063&id=71068

REVISION DETAIL
  https://phabricator.kde.org/D25802

AFFECTED FILES
  src/support/console.cpp

To: nicolasfella, iromanov, sitter, dfaure, #frameworks

D24443: Add a plugin system

2019-12-07 Thread Nicolas Fella

nicolasfella updated this revision to Diff 71067.
nicolasfella added a comment.


  - Use uniqe_ptr again

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=71066&id=71067

BRANCH
  arcpatch-D24443_1

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarentry.cpp
  src/calendarentry.h
  src/calendarentry_p.h
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, 
fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D25802: Don't use obsolete qVariantFromValue

2019-12-07 Thread Harald Sitter

sitter accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R486 QCA Library

BRANCH
  varval

REVISION DETAIL
  https://phabricator.kde.org/D25802

To: nicolasfella, iromanov, sitter, dfaure, #frameworks

D24443: Add a plugin system

2019-12-07 Thread Carl Schwan

ognarb added inline comments.

INLINE COMMENTS

> dvratil wrote in calendarentry.h:63
> Use `std::unique_ptr const d` for automatic memory 
> management.

This wasn't done, I still see `CalendarEntryPrivate *d;`

> nicolasfella wrote in calendarplugin.h:39
> My idea was to be able to add a d-ptr later if needed without breaking ABI

Will this also work if we are using unique_ptr?

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, 
fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-07 Thread Fabian Vogt

fvogt added a comment.


  The check for the prefix was added in 
`bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got 
added much earlier.
  
  The labels are visible again with just the `control.flat` condition, but the 
prefix one might be needed as well for non-breeze themes.
  
  There's a part missing though, the triangle (visible on 
https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is 
gone. That seems to be a feature lost with PC3 :-(

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: fvogt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-07 Thread Filip Fila

filipf edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

2019-12-07 Thread Nicolas Fella

nicolasfella updated this revision to Diff 71066.
nicolasfella added a comment.
Herald added a project: KDE PIM.
Herald added a subscriber: kde-pim.


  - Fix build
  - Rename description to name

REPOSITORY
  R172 KCalendar Core

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24443?vs=69253&id=71066

BRANCH
  arcpatch-D24443_1

REVISION DETAIL
  https://phabricator.kde.org/D24443

AFFECTED FILES
  src/CMakeLists.txt
  src/calendarentry.cpp
  src/calendarentry.h
  src/calendarentry_p.h
  src/calendarplugin.cpp
  src/calendarplugin.h

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, 
fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 87 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/87/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 07 Dec 2019 21:11:10 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.65.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)84%
(27097/32221)53%
(10888/20713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)98%
(12368/12592)49%
(6488/13117)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6325/7468)65%
(1838/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7950/9505)63%
(2385/3769)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/40/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 21:11:10 +
 Build duration:
6 min 10 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

2019-12-07 Thread David Faure

dfaure added a comment.


  Assuming we install all parts under plugins/parts instead of just plugins/ 
like we currently do, the application should be able to do
  
  `KPluginTrader::createInstanceFromQuery("parts", 
"KParts/ReadOnlyPart", "'application/pdf' in MimeTypes", parent, parentWidget)`
  
  This makes me realize however that mimetype inheritance would probably not be 
supported when doing it this way.
  We probably want to add a queryByMimeType to KPluginTrader as well, and a 
createInstanceFromQuery that takes a mimetype name, like KMimeTypeTrader has 
(maybe with another name though, too many overloads otherwise).
  
  Would this work for you?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D25698

To: dfaure, broulik, mart, vkrause, nicolasfella
Cc: aacid, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25802: Don't use obsolete qVariantFromValue

2019-12-07 Thread Nicolas Fella

nicolasfella edited the test plan for this revision.
nicolasfella added reviewers: iromanov, sitter, dfaure, Frameworks.

REPOSITORY
  R486 QCA Library

REVISION DETAIL
  https://phabricator.kde.org/D25802

To: nicolasfella, iromanov, sitter, dfaure, #frameworks

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 70 - Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/70/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 07 Dec 2019 19:42:20 +
 Build duration:
1 hr 1 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.65.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6877/9072)43%
(10784/24837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2874/2966)49%
(6178/12735)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(867/1296)36%
(1002/2811)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(670/786)42%
(948/2251)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(992/1214)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 36 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/36/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 07 Dec 2019 19:41:43 +
 Build duration:
1 hr 0 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13097)49%
(4166/8588)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2683/2805)52%
(756/1464)src94%
(44/47)94%
(44/47)62%
(6358/10292)48%
(3410/7124)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:47:11 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:46:14 +
 Build duration:
44 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 15 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandOutputManagementFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 86 - Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/86/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 07 Dec 2019 19:46:14 +
 Build duration:
39 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.65.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27270/32225)53%
(11001/20711)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12502/12591)50%
(6585/13115)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6339/7471)65%
(1838/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7975/9507)64%
(2401/3769)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/53/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:45:47 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 216 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/216/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:44:13 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/23/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:45:27 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:45:08 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/22/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:44:03 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/50/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:42:48 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 34 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/34/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 07 Dec 2019 19:41:43 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13097)49%
(4166/8588)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2683/2805)52%
(756/1464)src94%
(44/47)94%
(44/47)62%
(6358/10292)48%
(3410/7124)

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis

ndavis added a comment.


  @niccolove Do you mind if I commandeer this? I know dealing with these kinds 
of issues can be super annoying and I'm already used to it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/25/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:42:55 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 65 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/65/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:42:20 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/34/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:41:43 +
 Build duration:
7 min 29 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: projectroot.autote

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 35 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/35/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 07 Dec 2019 19:34:07 +
 Build duration:
5 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13097)49%
(4166/8588)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2683/2805)52%
(756/1464)src94%
(44/47)94%
(44/47)62%
(6358/10292)48%
(3410/7124)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/33/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 07 Dec 2019 19:34:07 +
 Build duration:
3 min 55 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13097)49%
(4166/8588)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2683/2805)52%
(756/1464)src94%
(44/47)94%
(44/47)62%
(6358/10292)48%
(3410/7124)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/33/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:34:07 +
 Build duration:
1 min 29 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: projectroot.autote

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 32 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/32/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 07 Dec 2019 19:27:27 +
 Build duration:
5 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13097)49%
(4166/8588)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2683/2805)52%
(756/1464)src94%
(44/47)94%
(44/47)62%
(6358/10292)48%
(3410/7124)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 34 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/34/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 07 Dec 2019 19:27:28 +
 Build duration:
4 min 55 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13097)49%
(4166/8588)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2683/2805)52%
(756/1464)src94%
(44/47)94%
(44/47)62%
(6358/10292)48%
(3410/7124)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

2019-12-07 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/32/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:27:27 +
 Build duration:
3 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 489 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testcalendarobserverFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 74 - Fixed!

2019-12-07 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/74/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 07 Dec 2019 19:19:57 +
 Build duration:
4 min 55 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.65.0.xmllogs/KF5WindowSystem/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7272/9616)56%
(3535/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3078/3165)52%
(1289/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(820/1374)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3367/4719)61%
(1942/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 46 - Fixed!

2019-12-07 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/46/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 07 Dec 2019 19:19:57 +
 Build duration:
3 min 34 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.65.0.xmllogs/KF5WindowSystem/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7272/9616)56%
(3532/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3083/3165)53%
(1292/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(819/1374)47%
(302/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3363/4719)60%
(1935/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 116 - Fixed!

2019-12-07 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/116/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 07 Dec 2019 19:16:54 +
 Build duration:
5 min 56 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.65.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6876/9073)43%
(10781/24837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2873/2966)48%
(6175/12735)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(867/1296)36%
(1002/2811)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(670/787)42%
(948/2251)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(992/1214)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Fixed!

2019-12-07 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/41/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 07 Dec 2019 19:19:57 +
 Build duration:
2 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

D25517: Add an option to extract binary data and add front cover property

2019-12-07 Thread Alexander Stippich

astippich added a comment.


  ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis

ndavis added a comment.


  It's still going to be a PITA with manual editing. Maybe there's a way to 
automate it with `awk`, but I don't know that tool well enough. This should at 
least make the deleting part easier: `sed --follow-symlinks -i 
's/style="opacity:0.05"//' tasks.svg`
  
  Do this too while you're at it since I noticed some useless style lines: `sed 
--follow-symlinks -i 's/style=""//' tasks.svg`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis

ndavis requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis

ndavis added a comment.


  Oh wait, here's the problem

INLINE COMMENTS

> tasks.svg:3206
> + transform="matrix(-1 0 0 -1 36 134)"
> + opacity=".16"
> + style="opacity:0.05">

Starts here
Conflicting opacity values. Set `opacity="0.05"` and delete the conflicting 
`style="opacity:0.05"` part.

> tasks.svg:3904
> + transform="matrix(0 1 1 0 122 89.97)"
> + opacity=".16"
> + style="opacity:0.05">

Ends here

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis

ndavis added a comment.


  In D25340#573654 , @ngraham wrote:
  
  > Hmm, I'm not seeing any change, and the difference between open and 
maximized items is still too subtle IMO: F7804140: 
Screenshot_20191207_093912.PNG 
  >
  > If the background is a different color/opacity, I can't tell.
  
  
  When changing the SVGs for plasmashell widgets, you have to delete cache. `rm 
-r ~/.cache/plasma*`

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25686: Updates from CMake 3.16 final release

2019-12-07 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c2de17ba8342: Updates from CMake 3.16 final release 
(authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25686?vs=70761&id=71060

REVISION DETAIL
  https://phabricator.kde.org/D25686

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Nathaniel Graham

ngraham added a comment.


  Hmm, I'm not seeing any change, and the difference between open and maximized 
items is still too subtle IMO: F7804140: Screenshot_20191207_093912.PNG 

  
  If the background is a different color/opacity, I can't tell.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D23457: Port regex search to QRegularExpression

2019-12-07 Thread Ahmad Samir

ahmadsamir updated this revision to Diff 71059.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23457?vs=64618&id=71059

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23457

AFFECTED FILES
  autotests/src/regexpsearch_test.cpp
  autotests/src/regexpsearch_test.h
  autotests/src/searchbar_test.cpp
  src/CMakeLists.txt
  src/document/katedocument.cpp
  src/search/kateplaintextsearch.cpp
  src/search/kateregexp.cpp
  src/search/kateregexp.h
  src/search/kateregexpsearch.cpp
  src/search/kateregexpsearch.h
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/utils/katesedcmd.cpp
  src/utils/katesedcmd.h

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25754: Refactor KHistoryComboBox::insertItems

2019-12-07 Thread Laurent Montel

mlaurent added inline comments.

INLINE COMMENTS

> khistorycombobox.cpp:435
> +
> +for (const QString item : items) {
> +if (item.isEmpty()) {

Missing & here no ?

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D25754

To: nicolasfella, #frameworks, apol
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25754: Refactor KHistoryComboBox::insertItems

2019-12-07 Thread Nicolas Fella

This revision was automatically updated to reflect the committed changes.
Closed by commit R284:ecb651bb2ee6: Refactor KHistoryComboBox::insertItems 
(authored by nicolasfella).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25754?vs=70926&id=71054

REVISION DETAIL
  https://phabricator.kde.org/D25754

AFFECTED FILES
  src/khistorycombobox.cpp

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Niccolò Venerandi

niccolove updated this revision to Diff 71050.
niccolove added a comment.


  Reset tabbar to master

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71048&id=71050

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Niccolò Venerandi

niccolove added a comment.


  In D25340#573594 , @ndavis wrote:
  
  > Wait, is a change to tabbar.svg supposed to be in this diff?
  
  
  Nope, I must have messed up the different arc features. Sorry.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Wait, is a change to tabbar.svg supposed to be in this diff?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

2019-12-07 Thread Niccolò Venerandi

niccolove added a comment.


  In D25334#566992 , @ngraham wrote:
  
  > In D25334#566745 , @ndavis wrote:
  >
  > > Yes that's right, the Kickoff tabs are fine, it's the panel that doesn't 
look right. It just doesn't look good with that kind of highlight to me. Or 
maybe the highlight background is too bright.
  >
  >
  > To me it looks fine with Breeze light IMO. If you think it looks bad with 
Breeze Dark, that seems like kind of a problem since as far as I was aware, 
this is the proposed new highlight style that you're working on, right? It 
definitely needs to look good with Breeze Dark, or at least no worse than the 
status quo.
  
  
  As per the screenshot above, this patch highlight look just as it was before 
in Breeze Dark, there was no change of that. If you think the current highlight 
is wrong with breeze dark, I could create a different task for that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Noah Davis

ndavis accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

2019-12-07 Thread Niccolò Venerandi

niccolove updated this revision to Diff 71048.
niccolove added a comment.


  Changed inactive to 5%

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=70207&id=71048

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tabbar.svg
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

2019-12-07 Thread Albert Astals Cid

aacid added a comment.


  How would i load a "KPart that can open PDF files" then?
  
  Doesn't seem that KPluginLoader has api for that and a Part is not an 
Application either

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D25698

To: dfaure, broulik, mart, vkrause, nicolasfella
Cc: aacid, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25599: Fix plugin-metadata translations on windows

2019-12-07 Thread Kåre Särs

sars added a comment.


  Yes it works :)
  
  (I added QLocale::setDefault(QLocale(QString::fromLatin1(languageCode))); to 
the end of the if statement in initializeLanguages())
  
  Hmm... For an application like Kate it is totally fine to set the language 
through kxmlgui, but kxmlgui is tier 3 while kcoreaddons and ki18n are tier1. 
Sure any application can use setDefault() to change the language of the plugin 
metadata, but that does not change the translation language in ki18n.
  
  I think the proper solution would be to use the same mechanism in ki18n and 
KCoreAddons. If we use the env variable we need to change KCoreAddons and if we 
want to use QLocale we need to change KI18n to use QLocale.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D25767: KAutoSaveFile: add a unit test to check max. filename length

2019-12-07 Thread Ahmad Samir

ahmadsamir added inline comments.

INLINE COMMENTS

> dhaumann wrote in kautosavefiletest.cpp:98
> What I wonder is: PATH_MAX etc are #defines, right? Since on Windows there is 
> a registry flag to enable much longer paths/file names. My intention is not 
> to block this series of patches, but we might end up with restrictions in our 
> code that do not exist on the filesystem at hand.

On windows the extended-length path is 32,767[1] characters, which is a bit 
unreasonable. I only skimmed those docs though.

[1] https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file

FTR, according to lxr.kde.org KAutoSaveFile is used by kdenlive, lokalize and 
libkeduvocdocument.

REPOSITORY
  R244 KCoreAddons

BRANCH
  l-kautosave-unittest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25767

To: ahmadsamir, #frameworks, mpyne, dfaure
Cc: dhaumann, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25767: KAutoSaveFile: add a unit test to check max. filename length

2019-12-07 Thread Ahmad Samir

ahmadsamir updated this revision to Diff 71047.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25767?vs=70968&id=71047

BRANCH
  l-kautosave-unittest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25767

AFFECTED FILES
  autotests/kautosavefiletest.cpp
  autotests/kautosavefiletest.h

To: ahmadsamir, #frameworks, mpyne, dfaure
Cc: dhaumann, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

63 matches

Mail list logo