D25814: [KColorScheme] Add SeparatorColor

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Few more comments on this:
  
  - general: you will never be able to make all the opiniated people happy, and 
you have to draw a line (otherwise your code will become bloated, buggy, and 
unmaintainable)
  - regarding this specific case: many widget style will not implement this new 
color. For those this will just generate bugs reports: why is my color scheme 
not respectd ?
  - some widget styles (oxygen at least, but I'm sure there are others) use two 
colors for frames and separators, to mimic shadows or relief effects. Adding 
one single color for this will not fit such schemes.
  - in the end if you need an extra color for a given theme (be it 
future-breeze or whatever), there is also the possibility to add it as a extra 
option for this specific theme, rather than forcing it to kcolorscheme and 
imposing it to all styles (or making kcolorscheme broken for all the styles 
that wont use it).
  
  This is how window decoration shadows and glow were handled to oxygen. 
  I think this change will break more things than it will fix, especially if 
the fix is to make some opinionated people happy.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: filipf, cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25820: SimpleScreenRecorder icon added

[Filip Fila]

filipf added a comment.


  I agree, I think brighter and slightly less saturated colors would look nice.
  
  Thank you for adding this btw, the old icon doesn't fit in.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25820

To: vinzenzv, #vdg, ndavis
Cc: filipf, ndavis, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Filip Fila]

filipf added a comment.


  I think this is useful. Every once in a while we get opinionated people who 
think light separators are awful in the Breeze Dark scheme (I would hate dark 
ones on the other hand) or even some ricer people who want to turn off 
separators (which they could do now by matching it with window color I guess).
  
  Implementation-wise there definitely always needs to be a fallback value so 
we don't break third-party color-schemes.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: filipf, cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

[Aleix Pol Gonzalez]

apol added a comment.


  Plasma master can depend on kf5 master.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  prov

REVISION DETAIL
  https://phabricator.kde.org/D25701

To: nicolasfella, #plasma, #frameworks, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25820: SimpleScreenRecorder icon added

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Good start! The lens flare looks upside down and the icon needs more pixel 
alignment. I feel like the red/green/blue colors of the center area are a bit 
too dark as well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25820

To: vinzenzv, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  @hpereiradacosta, Fair points and I'm glad you spoke up. JFYI, I'm in no rush 
to land this and I will consider reserving this change for KF6 if experienced 
KDE devs think that is best.
  
  In D25814#574105 , 
@hpereiradacosta wrote:
  
  > Adding new entries to the kcolorscheme should be done with a lot of care, 
because it could be seen as some sort of API break for existing colorscheme, as 
soon as you start using this color in the widget style: you would need a 
fallback implementation, for all the colorscheme in the open which do not 
implement this particular color. These kind of additions happened a lot whith 
gtk3 css style and resulting of overall unhappiness and distrust from 
theme/color scheme developpers. This also increases the complexity of the code 
and difficulty to maintain.
  
  
  In terms of breakage, I think it would be fine if I made the color fallback 
(as you said) to what the breeze widget style currently does. 3rd party widget 
styles wouldn't use this color without modification, so it shouldn't hurt them. 
KColorScheme already has default colors, but they're defined before 
KColorScheme tries to read colors from the colorscheme file instead of when a 
color is not found. That hurts the flexibility of these defaults and seems 
backwards to me, but there may be a reason for it that I don't know of.
  
  > Also I am not convinced about the usefullness of this option either, 
especially considering that tweaking the colorscheme in the systemsettings is 
already quite advanced configuration (I would bet that most users stop at 
switching between pre-made color schemes, rather than tweaking a particular 
one. This will get even less the case if you start implementing more corner 
case colors.
  
  Yes, it is yet another option in a sea of options, many of which are 
completely useless when a user ventures outside of the Common Colors section. 
You're probably correct that most users don't even bother with manually 
adjusting colors since choosing good colors can be tricky. I don't think that 
makes this option useless though, except for the fact that it's repeated for 
each color set and only a few versions of it will get any amount of use. I hope 
to simplify the colorscheme editor in the future so that only options that do 
something are exposed.
  
  > Or do you plan to ship a "breeze dark with dark separators" +and+ a "breeze 
dark with light separators" ?
  
  I do not.
  
  > All in all i would say that people (that is: active developpers and the 
very few that manifest themselves on developper/vdg channels) having different 
opinion is not a strong enough argument to expose such a low level tweaking to 
all. Or is there an actual poll that shows (on a larger data sample) that one 
really cannot decide between the two options ?
  
  There is no such poll.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Hugo Pereira Da Costa]

hpereiradacosta added a subscriber: cfeck.
hpereiradacosta added a comment.


  Would also be good to have the opinion of @cfeck on this.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis added a comment.


  In D25815#574111 , @vinzenzv wrote:
  
  > In D25815#574103 , @ndavis wrote:
  >
  > > The actual name of the icon is `transmission`, so you would have to 
rename the file to that and add `id="transmission"` to the group. Since this is 
a desktop theme icon, you would also have to add an invisible 22x22 rectangle 
to the group.
  > >
  > > However, even after doing all that myself, I can't get this icon to work. 
I'm not sure why. It doesn't work with `transmission-qt` either.
  >
  >
  > I rebuilt the whole icon taking the SVG of Konversation. Maybe I messed up 
something with the initial one.
  >
  > F7805591: Screenshot_20191209_015303.png 

  
  
  Nope, I even completely redid it any it wouldn't work with `transmission` or 
`transmission-qt`

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis
Cc: ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, 
GB_2, trickyricky26, michaelh, bruns

D25815: Transmission-Qt tray icon added

[Vinzenz Vietzke]

vinzenzv updated this revision to Diff 71107.
vinzenzv added a comment.


  In D25815#574103 , @ndavis wrote:
  
  > The actual name of the icon is `transmission`, so you would have to rename 
the file to that and add `id="transmission"` to the group. Since this is a 
desktop theme icon, you would also have to add an invisible 22x22 rectangle to 
the group.
  >
  > However, even after doing all that myself, I can't get this icon to work. 
I'm not sure why. It doesn't work with `transmission-qt` either.
  
  
  I rebuilt the whole icon taking the SVG of Konversation. Maybe I messed up 
something with the initial one.
  
  F7805591: Screenshot_20191209_015303.png 


CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25815?vs=71097=71107

REVISION DETAIL
  https://phabricator.kde.org/D25815

AFFECTED FILES
  src/desktoptheme/breeze/icons/transmission.svg

To: vinzenzv, #vdg, ndavis
Cc: ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, 
GB_2, trickyricky26, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Adding new entries to the kcolorscheme should be done with a lot of care, 
because it could be seen as some sort of API break for existing colorscheme, as 
soon as you start using this color in the widget style: you would need a 
fallback implementation, for all the colorscheme in the open which do not 
implement this particular color. These kind of additions happened a lot whith 
gtk3 css style and resulting of overall unhappiness and distrust from 
theme/color scheme developpers. This also increases the complexity of the code 
and difficulty to maintain.
  
  Also I am not convinced about the usefullness of this option either, 
especially considering that tweaking the colorscheme in the systemsettings is 
already quite advanced configuration (I would bet that most users stop at 
switching between pre-made color schemes, rather than tweaking a particular 
one. This will get even less the case if you start implementing more corner 
case colors. 
  Or do you plan to ship a "breeze dark with dark separators" +and+ a "breeze 
dark with light separators" ? 
  All in all i would say that people (that is: active developpers and the very 
few that manifest themselves on developper/vdg channels) having different 
opinion is not a strong enough argument to expose such a low level tweaking to 
all. Or is there an actual poll that shows (on a larger data sample) that one 
really cannot decide between the two options ?
  
  My two cents.
  
  Hugo

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25815: Transmission-Qt tray icon added

[Vinzenz Vietzke]

vinzenzv added a comment.


  Okay, gotcha. I played around a bit but am not too satisfied yet. I tends to 
look like a grave...
  
  F7805560: Screenshot_20191209_010939.png 

  
  Best I could get yet:
  
  F7805561: Screenshot_20191209_011147.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis
Cc: ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, 
GB_2, trickyricky26, michaelh, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis added a comment.


  The actual name of the icon is `transmission`, so you would have to rename 
the file to that and add `id="transmission"` to the group. Since this is a 
desktop theme icon, you would also have to add an invisible 22x22 rectangle to 
the group.
  
  However, even after doing all that myself, I can't get this icon to work. I'm 
not sure why.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis
Cc: ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, 
GB_2, trickyricky26, michaelh, bruns

D25820: SimpleScreenRecorder icon added

[Vinzenz Vietzke]

vinzenzv created this revision.
vinzenzv added a reviewer: VDG.
vinzenzv added a project: Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vinzenzv requested review of this revision.

REVISION SUMMARY
  I took the existing DigiKam icon and tweaked it to rebuild the original icon 
of SimpleScreenRecorder .
  
  Original: F7805539: icon_Y093431.webp 
  
  Breeze: F7805540: Screenshot_20191209_004032.png 

  
  BUG: 412490

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25820

AFFECTED FILES
  icons/apps/48/simplescreenrecorder.svg

To: vinzenzv, #vdg
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Hey, thanks for the patch!
  
  - Breeze usually uses 1px lines, but does use 2px in some instances (mainly 
centered lines). You can use a 2px thickness at the bottom in this case to 
match the look of the original logo.
  - The shapes need to be aligned to 1px grid spaces. If using strokes, use 
miter joins (value: 4), square caps, align to the centers of pixels and then 
convert to paths. I won't be too picky about diagonal lines except for 45 
degree angles: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Diagonal_lines
  - The margins must to be 3px on the top and bottom, but you can fudge the 
horizontal margins as needed

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis
Cc: ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, 
GB_2, trickyricky26, michaelh, bruns

D25815: Transmission-Qt tray icon added

[Nathaniel Graham]

ngraham added a comment.


  Very nice! You even embedded the stylesheet. However there are a number of 
lines and corners that would look better aligned to grid lines or points. You 
don't have to always to this, but in general it's better to. Also the Breeze 
icon style generally has pointy corners rather than rounded ones.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg
Cc: ngraham, iasensio, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, bruns

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

[Nicolas Fella]

nicolasfella added a comment.


  Can Plasma depend on Frameworks master or does this have to wait until 5.66 
release?

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  prov

REVISION DETAIL
  https://phabricator.kde.org/D25701

To: nicolasfella, #plasma, #frameworks, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/54/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 08 Dec 2019 22:59:11 +
 Build duration:
1 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25700: [KHistoryComboBox] Add method to set an icon provider

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R284:9fe2d187f8e9: [KHistoryComboBox] Add method to set an 
icon provider (authored by nicolasfella).

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25700?vs=71098=71102

REVISION DETAIL
  https://phabricator.kde.org/D25700

AFFECTED FILES
  src/CMakeLists.txt
  src/khistorycombobox.cpp
  src/khistorycombobox.h

To: nicolasfella, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R284 KCompletion

BRANCH
  icopro

REVISION DETAIL
  https://phabricator.kde.org/D25700

To: nicolasfella, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25816: Port KPluginTrader away from Q_GLOBAL_STATIC.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D25816

To: dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25816: Port KPluginTrader away from Q_GLOBAL_STATIC.

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25816

To: dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25816: Port KPluginTrader away from Q_GLOBAL_STATIC.

[David Faure]

dfaure created this revision.
dfaure added a reviewer: aacid.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  It's just simpler this way, we don't need the extra features
  of Q_GLOBAL_STATIC.

TEST PLAN
  Builds

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25816

AFFECTED FILES
  src/plugin/kplugintrader.cpp
  src/plugin/kplugintrader.h

To: dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25700: [KHistoryComboBox] Add method to set an icon provider

[Nicolas Fella]

nicolasfella updated this revision to Diff 71098.
nicolasfella marked 3 inline comments as done.
nicolasfella added a comment.


  - Comments

REPOSITORY
  R284 KCompletion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25700?vs=71072=71098

BRANCH
  icopro

REVISION DETAIL
  https://phabricator.kde.org/D25700

AFFECTED FILES
  src/CMakeLists.txt
  src/khistorycombobox.cpp
  src/khistorycombobox.h

To: nicolasfella, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/36/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 08 Dec 2019 22:34:26 +
 Build duration:
5 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9108/13159)49%
(4200/8620)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2745/2867)52%
(774/1496)src94%
(44/47)94%
(44/47)62%
(6363/10292)48%
(3426/7124)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/38/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 08 Dec 2019 22:34:26 +
 Build duration:
4 min 26 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9108/13159)49%
(4200/8620)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2745/2867)52%
(774/1496)src94%
(44/47)94%
(44/47)62%
(6363/10292)48%
(3426/7124)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/36/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 08 Dec 2019 22:34:26 +
 Build duration:
3 min 56 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 489 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testcalendarobserverFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

D25414: xattr: fix crash on dangling symlinks

[Ismael Asensio]

iasensio added a comment.


  Ping?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25414

To: iasensio, astippich, bruns
Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D25700: [KHistoryComboBox] Add method to set an icon provider

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> khistorycombobox.cpp:415
>  
> +#if KCOMPLETION_ENABLE_DEPRECATED_SINCE(5, 66)
>  void KHistoryComboBox::setPixmapProvider(KPixmapProvider *provider)

s/ENABLE/BUILD/ in .cpp files

> khistorycombobox.cpp:499
>  
> +#if KCOMPLETION_ENABLE_DEPRECATED_SINCE(5, 66)
>  KPixmapProvider *KHistoryComboBox::pixmapProvider() const

BUILD

> khistorycombobox.h:195
> + * Sets an icon provider, so that items in the combobox can have an icon.
> + * The provider is a function that takes a QString and returns a QIcon
> + */

Missing `@since 5.66`

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D25700

To: nicolasfella, #frameworks, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25599: Fix plugin-metadata translations on windows

[Albert Astals Cid]

aacid added a comment.


  In D25599#573581 , @sars wrote:
  
  > Yes it works :)
  >
  > (I added QLocale::setDefault(QLocale(QString::fromLatin1(languageCode))); 
to the end of the if statement in initializeLanguages())
  >
  > Hmm... For an application like Kate it is totally fine to set the language 
through kxmlgui, but kxmlgui is tier 3 while kcoreaddons and ki18n are tier1. 
Sure any application can use setDefault() to change the language of the plugin 
metadata, but that does not change the translation language in ki18n.
  >
  > I think the proper solution would be to use the same mechanism in ki18n and 
KCoreAddons. If we use the env variable we need to change KCoreAddons and if we 
want to use QLocale we need to change KI18n to use QLocale.
  
  
  Proper solution for what? I don't understand what you're trying to fix. I 
thought your problem was "when people use kxmlgui to set a custom language for 
the app things don't work", but now you're saying of not using kxmlgui so i'm 
confused.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D25815: Transmission-Qt tray icon added

[Vinzenz Vietzke]

vinzenzv created this revision.
vinzenzv added a reviewer: VDG.
vinzenzv added a project: Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vinzenzv requested review of this revision.

REVISION SUMMARY
  Replace the default Transmission-Qt icon with a breeze version
  
  Before: F7805469: Screenshot_20191120_145904.png 

  
  After: F7805470: Screenshot_20191208_195211.png 

  
  BUG: 414335

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25815

AFFECTED FILES
  src/desktoptheme/breeze/icons/transmission-qt.svg

To: vinzenzv, #vdg
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

[Albert Astals Cid]

aacid added a comment.


  > Would this work for you?
  
  I guess, i'm not really sure if i understand all you wrote, but i just want 
to make sure we can do a "generic part loader that opens files" if we want to

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D25698

To: dfaure, broulik, mart, vkrause, nicolasfella
Cc: aacid, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25727: Expose enum to the metaobject compiler

[David Faure]

dfaure added a comment.


  CI = not happy
  
  src/declarative/peopleqmlplugin.cpp:73: undefined reference to 
`KPeople::staticMetaObject'

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D25727

To: apol, jbbgameich, davidedmundson
Cc: dfaure, lnj, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Code looks OK. No opinion on usefulness though.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis updated this revision to Diff 71096.
ndavis added a comment.


  - update @since version

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25814?vs=71095=71096

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis edited the summary of this revision.
ndavis added reviewers: Frameworks, VDG, dfaure.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Users sometimes ask for the ability to customize the color of separators.
  When talking about how the next version of Breeze Dark should look, some 
developers

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25683: KDirOperator: Use a fixed line height for scroll speed

[Elvis Angelaccio]

elvisangelaccio accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  diroperator_scrollspeed

REVISION DETAIL
  https://phabricator.kde.org/D25683

To: ahiemstra, ngraham, elvisangelaccio
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.12 - Build # 67 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.12/67/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 08 Dec 2019 20:33:40 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 394 lines...][2019-12-08T20:34:38.140Z] [ 60%] Linking CXX executable ../bin/duplicates[2019-12-08T20:34:38.140Z] [ 61%] Linking CXX executable ../bin/contactlistwidgets[2019-12-08T20:34:38.397Z] [ 63%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/personsmodeltest.cpp.o[2019-12-08T20:34:38.654Z] [ 63%] Built target duplicates[2019-12-08T20:34:38.654Z] [ 64%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/fakecontactsource.cpp.o[2019-12-08T20:34:38.654Z] [ 64%] Built target contactlistwidgets[2019-12-08T20:34:38.654Z] [ 65%] Generating ui_person-details-presentation.h[2019-12-08T20:34:38.654Z] Scanning dependencies of target KF5PeopleWidgets[2019-12-08T20:34:38.654Z] [ 66%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/KF5PeopleWidgets_autogen/mocs_compilation.cpp.o[2019-12-08T20:34:39.216Z] [ 67%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/persondetailsdialog.cpp.o[2019-12-08T20:34:39.779Z] [ 69%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/persondetailsview.cpp.o[2019-12-08T20:34:39.779Z] [ 70%] Linking CXX executable ../bin/persondatatest[2019-12-08T20:34:39.779Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/widgets/persondetailsview.cpp:80:2: warning: #warning is a GCC extension[2019-12-08T20:34:39.779Z]80 | #warning fixme, should be made user-visible somehow[2019-12-08T20:34:39.779Z]   |  ^~~[2019-12-08T20:34:39.779Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/widgets/persondetailsview.cpp:80:2: warning: #warning fixme, should be made user-visible somehow [-Wcpp][2019-12-08T20:34:39.779Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/widgets/persondetailsview.cpp:122:2: warning: #warning is a GCC extension[2019-12-08T20:34:39.779Z]   122 | #warning figure out a way to list properties[2019-12-08T20:34:39.779Z]   |  ^~~[2019-12-08T20:34:39.779Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/widgets/persondetailsview.cpp:122:2: warning: #warning figure out a way to list properties [-Wcpp][2019-12-08T20:34:40.344Z] [ 70%] Built target persondatatest[2019-12-08T20:34:40.344Z] [ 71%] Linking CXX executable ../bin/personsproxymodeltest[2019-12-08T20:34:40.344Z] [ 72%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/plugins/emaildetailswidget.cpp.o[2019-12-08T20:34:40.344Z] [ 73%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/abstractfieldwidgetfactory.cpp.o[2019-12-08T20:34:40.601Z] [ 75%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/actions.cpp.o[2019-12-08T20:34:40.601Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/widgets/persondetailsview.cpp: In constructor ���KPeople::PersonDetailsView::PersonDetailsView(QWidget*)���:[2019-12-08T20:34:40.601Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/widgets/persondetailsview.cpp:147:53: warning: ���static KPluginInfo::List KPluginInfo::fromServices(const List&, const KConfigGroup&)��� is deprecated: Since 5.0. Use (Q|K)PluginLoader [-Wdeprecated-declarations][2019-12-08T20:34:40.601Z]   147 | const QList plugins = KPluginInfo::fromServices(pluginList);[2019-12-08T20:34:40.601Z]   | ^~~~[2019-12-08T20:34:40.601Z] In file included from /home/jenkins/install-prefix/include/KF5/KService/KPluginInfo:1,[2019-12-08T20:34:40.601Z]  from /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/widgets/persondetailsview.cpp:32:[2019-12-08T20:34:40.601Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:200:30: note: declared here[2019-12-08T20:34:40.601Z]   200 | static KPluginInfo::List fromServices(const KService::List , const KConfigGroup  = KConfigGroup());[2019-12-08T20:34:40.601Z]   |  ^~~~[2019-12-08T20:34:40.601Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.12/src/widgets/persondetailsview.cpp:147:76: warning: ���static KPluginInfo::List KPluginInfo::fromServices(const List&, const KConfigGroup&)��� is deprecated: Since 5.0. Use (Q|K)PluginLoader [-Wdeprecated-declarations][2019-12-08T20:34:40.601Z]   147 | const QList plugins = KPluginInfo::fromServices(pluginList);[2019-12-08T20:34:40.601Z]   |^[2019-12-08T20:34:40.601Z] In file included from /home/jenkins/install-prefix/include/KF5/KService/KPluginInfo:1,[2019-12-08T20:34:40.601Z]  from /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 31 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/31/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 08 Dec 2019 20:33:40 +
 Build duration:
1 min 31 sec and counting
   CONSOLE OUTPUT
  [...truncated 420 lines...][2019-12-08T20:34:59.905Z] [ 63%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/fakecontactsource.cpp.obj[2019-12-08T20:34:59.905Z] [ 61%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/personsmodeltest_autogen/mocs_compilation.cpp.obj[2019-12-08T20:34:59.905Z] persondatatests.cpp[2019-12-08T20:34:59.905Z] personsmodeltest.cpp[2019-12-08T20:34:59.905Z] personsproxymodeltest.cpp[2019-12-08T20:34:59.905Z] [ 47%] Generating ui_person-details-presentation.h[2019-12-08T20:34:59.905Z] Scanning dependencies of target KF5PeopleWidgets[2019-12-08T20:35:02.490Z] mocs_compilation.cpp[2019-12-08T20:35:02.490Z] mocs_compilation.cpp[2019-12-08T20:35:02.490Z] mocs_compilation.cpp[2019-12-08T20:35:02.490Z] fakecontactsource.cpp[2019-12-08T20:35:02.490Z] [ 69%] Linking CXX executable ..\bin\duplicates.exe[2019-12-08T20:35:02.490Z] fakecontactsource.cpp[2019-12-08T20:35:02.490Z] fakecontactsource.cpp[2019-12-08T20:35:02.490Z] [ 73%] Linking CXX executable ..\bin\contactlistwidgets.exe[2019-12-08T20:35:03.063Z] [ 75%] Built target duplicates[2019-12-08T20:35:03.063Z] [ 64%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/persondetailsdialog.cpp.obj[2019-12-08T20:35:03.063Z] persondetailsdialog.cpp[2019-12-08T20:35:03.063Z] [ 66%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/abstractfieldwidgetfactory.cpp.obj[2019-12-08T20:35:03.063Z] [ 66%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/plugins/emaildetailswidget.cpp.obj[2019-12-08T20:35:03.063Z] [ 67%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/actions.cpp.obj[2019-12-08T20:35:03.063Z] [ 70%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/mergedialog.cpp.obj[2019-12-08T20:35:03.063Z] [ 71%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/mergedelegate.cpp.obj[2019-12-08T20:35:03.063Z] [ 72%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/kpeople_widgets_debug.cpp.obj[2019-12-08T20:35:03.063Z] emaildetailswidget.cpp[2019-12-08T20:35:03.063Z] abstractfieldwidgetfactory.cpp[2019-12-08T20:35:03.063Z] actions.cpp[2019-12-08T20:35:03.063Z] mergedialog.cpp[2019-12-08T20:35:03.063Z] mergedelegate.cpp[2019-12-08T20:35:03.063Z] kpeople_widgets_debug.cpp[2019-12-08T20:35:03.063Z] [ 75%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/KF5PeopleWidgets_autogen/mocs_compilation.cpp.obj[2019-12-08T20:35:03.063Z] [ 76%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/persondetailsview.cpp.obj[2019-12-08T20:35:03.322Z] [ 76%] Built target contactlistwidgets[2019-12-08T20:35:03.323Z] C:\CI\workspace\Frameworks\kpeople\kf5-qt5 WindowsMSVCQt5.13\autotests\persondatatests.cpp(118): warning C4003: not enough arguments for function-like macro invocation 'QStringLiteral'[2019-12-08T20:35:03.323Z] C:\CI\workspace\Frameworks\kpeople\kf5-qt5 WindowsMSVCQt5.13\autotests\persondatatests.cpp(118): warning C4003: not enough arguments for function-like macro invocation 'QT_UNICODE_LITERAL'[2019-12-08T20:35:04.275Z] mocs_compilation.cpp[2019-12-08T20:35:04.275Z] persondetailsview.cpp[2019-12-08T20:35:04.275Z] [ 77%] Linking CXX executable ..\bin\personsmodeltest.exe[2019-12-08T20:35:04.539Z] [ 78%] Linking CXX executable ..\bin\persondatatest.exe[2019-12-08T20:35:04.539Z] [ 79%] Linking CXX executable ..\bin\personsproxymodeltest.exe[2019-12-08T20:35:04.798Z] C:\CI\workspace\Frameworks\kpeople\kf5-qt5 WindowsMSVCQt5.13\src\widgets\persondetailsview.cpp(147): warning C4996: 'KPluginInfo::fromServices': Since 5.0. Use (Q|K)PluginLoader[2019-12-08T20:35:04.798Z] c:\ci\software installs\kpeople\include\kf5\kservice\kplugininfo.h(200): note: see declaration of 'KPluginInfo::fromServices'[2019-12-08T20:35:05.364Z] [ 79%] Built target personsproxymodeltest[2019-12-08T20:35:05.364Z] [ 79%] Built target persondatatest[2019-12-08T20:35:05.364Z] [ 80%] Linking CXX shared library ..\..\bin\libKPeopleWidgets.dll[2019-12-08T20:35:05.364Z] [ 80%] Built target personsmodeltest[2019-12-08T20:35:06.304Z]Creating library ..\..\lib\libKPeopleWidgets.lib and object ..\..\lib\libKPeopleWidgets.exp[2019-12-08T20:35:06.873Z]Creating library ..\..\lib\libKPeopleWidgets.lib and object ..\..\lib\libKPeopleWidgets.exp[2019-12-08T20:35:06.873Z] [ 80%] Built target KF5PeopleWidgets[2019-12-08T20:35:06.873Z] Scanning dependencies of target KF5PeopleDeclarative_autogen[2019-12-08T20:35:06.873Z] Scanning dependencies of target duplicatesdialog_autogen[2019-12-08T20:35:06.873Z] Scanning dependencies of target personwidget_autogen[2019-12-08T20:35:06.873Z] [ 83%] Automatic MOC for target 

KDE CI: Frameworks » kpeople » kf5-qt5 SUSEQt5.13 - Build # 45 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20SUSEQt5.13/45/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 08 Dec 2019 20:33:40 +
 Build duration:
58 sec and counting
   CONSOLE OUTPUT
  [...truncated 394 lines...][2019-12-08T20:34:31.601Z] [ 59%] Building CXX object examples/CMakeFiles/contactlistwidgets.dir/contactlistwidgets.cpp.o[2019-12-08T20:34:31.601Z] [ 60%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/KF5PeopleWidgets_autogen/mocs_compilation.cpp.o[2019-12-08T20:34:32.532Z] [ 61%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/persondetailsdialog.cpp.o[2019-12-08T20:34:32.532Z] [ 63%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/persondetailsview.cpp.o[2019-12-08T20:34:32.532Z] [ 64%] Building CXX object autotests/CMakeFiles/persondatatest.dir/persondatatests.cpp.o[2019-12-08T20:34:32.532Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/widgets/persondetailsview.cpp:80:2: warning: #warning is a GCC extension[2019-12-08T20:34:32.532Z]80 | #warning fixme, should be made user-visible somehow[2019-12-08T20:34:32.532Z]   |  ^~~[2019-12-08T20:34:32.532Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/widgets/persondetailsview.cpp:80:2: warning: #warning fixme, should be made user-visible somehow [-Wcpp][2019-12-08T20:34:32.532Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/widgets/persondetailsview.cpp:122:2: warning: #warning is a GCC extension[2019-12-08T20:34:32.532Z]   122 | #warning figure out a way to list properties[2019-12-08T20:34:32.532Z]   |  ^~~[2019-12-08T20:34:32.532Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/widgets/persondetailsview.cpp:122:2: warning: #warning figure out a way to list properties [-Wcpp][2019-12-08T20:34:32.532Z] [ 65%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/plugins/emaildetailswidget.cpp.o[2019-12-08T20:34:32.789Z] [ 66%] Linking CXX executable ../bin/duplicates[2019-12-08T20:34:33.046Z] [ 67%] Linking CXX executable ../bin/contactlistwidgets[2019-12-08T20:34:33.046Z] [ 69%] Building CXX object autotests/CMakeFiles/persondatatest.dir/fakecontactsource.cpp.o[2019-12-08T20:34:33.306Z] [ 69%] Built target duplicates[2019-12-08T20:34:33.306Z] [ 70%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/abstractfieldwidgetfactory.cpp.o[2019-12-08T20:34:33.306Z] [ 70%] Built target contactlistwidgets[2019-12-08T20:34:33.306Z] [ 71%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/actions.cpp.o[2019-12-08T20:34:33.564Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/widgets/persondetailsview.cpp: In constructor ���KPeople::PersonDetailsView::PersonDetailsView(QWidget*)���:[2019-12-08T20:34:33.564Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/widgets/persondetailsview.cpp:147:53: warning: ���static KPluginInfo::List KPluginInfo::fromServices(const List&, const KConfigGroup&)��� is deprecated: Since 5.0. Use (Q|K)PluginLoader [-Wdeprecated-declarations][2019-12-08T20:34:33.564Z]   147 | const QList plugins = KPluginInfo::fromServices(pluginList);[2019-12-08T20:34:33.564Z]   | ^~~~[2019-12-08T20:34:33.564Z] In file included from /home/jenkins/install-prefix/include/KF5/KService/KPluginInfo:1,[2019-12-08T20:34:33.564Z]  from /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/widgets/persondetailsview.cpp:32:[2019-12-08T20:34:33.564Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:200:30: note: declared here[2019-12-08T20:34:33.564Z]   200 | static KPluginInfo::List fromServices(const KService::List , const KConfigGroup  = KConfigGroup());[2019-12-08T20:34:33.564Z]   |  ^~~~[2019-12-08T20:34:33.564Z] /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/widgets/persondetailsview.cpp:147:76: warning: ���static KPluginInfo::List KPluginInfo::fromServices(const List&, const KConfigGroup&)��� is deprecated: Since 5.0. Use (Q|K)PluginLoader [-Wdeprecated-declarations][2019-12-08T20:34:33.564Z]   147 | const QList plugins = KPluginInfo::fromServices(pluginList);[2019-12-08T20:34:33.564Z]   |^[2019-12-08T20:34:33.564Z] In file included from /home/jenkins/install-prefix/include/KF5/KService/KPluginInfo:1,[2019-12-08T20:34:33.564Z]  from /home/jenkins/workspace/Frameworks/kpeople/kf5-qt5 SUSEQt5.13/src/widgets/persondetailsview.cpp:32:[2019-12-08T20:34:33.564Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:200:30: note: declared here[2019-12-08T20:34:33.564Z]   200 | static KPluginInfo::List fromServices(const KService::List , const KConfigGroup  = 

KDE CI: Frameworks » kpeople » kf5-qt5 AndroidQt5.13 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20AndroidQt5.13/16/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Sun, 08 Dec 2019 20:33:40 +
 Build duration:
52 sec and counting
   CONSOLE OUTPUT
  [...truncated 306 lines...][2019-12-08T20:34:28.279Z] [ 49%] Automatic MOC for target persondatatest[2019-12-08T20:34:28.537Z] [ 49%] Built target personsmodeltest_autogen[2019-12-08T20:34:28.537Z] [ 49%] Built target personsproxymodeltest_autogen[2019-12-08T20:34:28.537Z] [ 49%] Built target persondatatest_autogen[2019-12-08T20:34:28.537Z] [ 49%] Built target KF5PeopleWidgets_autogen[2019-12-08T20:34:28.537Z] [ 50%] Generating ui_person-details-presentation.h[2019-12-08T20:34:28.537Z] Scanning dependencies of target persondatatest[2019-12-08T20:34:28.537Z] Scanning dependencies of target personsproxymodeltest[2019-12-08T20:34:28.537Z] Scanning dependencies of target personsmodeltest[2019-12-08T20:34:28.537Z] [ 52%] Building CXX object autotests/CMakeFiles/persondatatest.dir/persondatatest_autogen/mocs_compilation.cpp.o[2019-12-08T20:34:28.537Z] [ 54%] Building CXX object autotests/CMakeFiles/persondatatest.dir/persondatatests.cpp.o[2019-12-08T20:34:28.537Z] [ 55%] Building CXX object autotests/CMakeFiles/persondatatest.dir/fakecontactsource.cpp.o[2019-12-08T20:34:28.537Z] [ 57%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/personsproxymodeltest_autogen/mocs_compilation.cpp.o[2019-12-08T20:34:28.537Z] [ 59%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/personsmodeltest.cpp.o[2019-12-08T20:34:28.537Z] [ 62%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/personsmodeltest_autogen/mocs_compilation.cpp.o[2019-12-08T20:34:28.537Z] [ 62%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/fakecontactsource.cpp.o[2019-12-08T20:34:28.537Z] [ 63%] Building CXX object autotests/CMakeFiles/personsproxymodeltest.dir/personsproxymodeltest.cpp.o[2019-12-08T20:34:28.537Z] Scanning dependencies of target KF5PeopleWidgets[2019-12-08T20:34:28.537Z] [ 65%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/KF5PeopleWidgets_autogen/mocs_compilation.cpp.o[2019-12-08T20:34:29.484Z] [ 67%] Building CXX object autotests/CMakeFiles/personsmodeltest.dir/fakecontactsource.cpp.o[2019-12-08T20:34:29.484Z] [ 68%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/persondetailsview.cpp.o[2019-12-08T20:34:29.485Z] [ 70%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/persondetailsdialog.cpp.o[2019-12-08T20:34:29.485Z] [ 72%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/plugins/emaildetailswidget.cpp.o[2019-12-08T20:34:29.485Z] [ 73%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/abstractfieldwidgetfactory.cpp.o[2019-12-08T20:34:30.060Z] [ 75%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/actions.cpp.o[2019-12-08T20:34:30.318Z] [ 77%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/mergedialog.cpp.o[2019-12-08T20:34:30.318Z] /home/user/workspace/Frameworks/kpeople/kf5-qt5 AndroidQt5.13/src/widgets/persondetailsview.cpp:80:2: warning: #warning is a language extension [-Wpedantic][2019-12-08T20:34:30.318Z] #warning fixme, should be made user-visible somehow[2019-12-08T20:34:30.318Z]  ^[2019-12-08T20:34:30.318Z] /home/user/workspace/Frameworks/kpeople/kf5-qt5 AndroidQt5.13/src/widgets/persondetailsview.cpp:80:2: warning: fixme, should be made user-visible somehow [-W#warnings][2019-12-08T20:34:30.318Z] /home/user/workspace/Frameworks/kpeople/kf5-qt5 AndroidQt5.13/src/widgets/persondetailsview.cpp:122:2: warning: #warning is a language extension [-Wpedantic][2019-12-08T20:34:30.318Z] #warning figure out a way to list properties[2019-12-08T20:34:30.318Z]  ^[2019-12-08T20:34:30.318Z] /home/user/workspace/Frameworks/kpeople/kf5-qt5 AndroidQt5.13/src/widgets/persondetailsview.cpp:122:2: warning: figure out a way to list properties [-W#warnings][2019-12-08T20:34:30.318Z] [ 78%] Building CXX object src/widgets/CMakeFiles/KF5PeopleWidgets.dir/mergedelegate.cpp.o[2019-12-08T20:34:30.318Z] /home/user/workspace/Frameworks/kpeople/kf5-qt5 AndroidQt5.13/src/widgets/persondetailsview.cpp:147:53: warning: 'fromServices' is deprecated: Since 5.0. Use (Q|K)PluginLoader [-Wdeprecated-declarations][2019-12-08T20:34:30.318Z] const QList plugins = KPluginInfo::fromServices(pluginList);[2019-12-08T20:34:30.318Z] ^[2019-12-08T20:34:30.318Z] /home/user/install-prefix/include/KF5/KService/kplugininfo.h:199:5: note: 'fromServices' has been explicitly marked deprecated here[2019-12-08T20:34:30.318Z] KSERVICE_DEPRECATED_VERSION(5, 0, "Use (Q|K)PluginLoader")[2019-12-08T20:34:30.318Z] ^[2019-12-08T20:34:30.318Z] /home/user/install-prefix/include/KF5/KService/kservice_export.h:137:57: note: expanded from macro 

D25727: Expose enum to the metaobject compiler

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R307:508b1bab207e: Expose enum to the metaobject compiler 
(authored by apol).

REPOSITORY
  R307 KPeople

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25727?vs=70997=71093

REVISION DETAIL
  https://phabricator.kde.org/D25727

AFFECTED FILES
  src/declarative/CMakeLists.txt
  src/declarative/peopleqmlplugin.cpp
  src/widgets/actions.h

To: apol, jbbgameich, davidedmundson
Cc: lnj, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25775: Check cursor_open return value

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25775

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 08 Dec 2019 18:07:07 +
 Build duration:
3 min 40 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9108/13159)49%
(4200/8620)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2745/2867)52%
(774/1496)src94%
(44/47)94%
(44/47)62%
(6363/10292)48%
(3426/7124)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/37/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 08 Dec 2019 18:07:07 +
 Build duration:
2 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9108/13159)49%
(4200/8620)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2745/2867)52%
(774/1496)src94%
(44/47)94%
(44/47)62%
(6363/10292)48%
(3426/7124)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/35/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 08 Dec 2019 18:07:08 +
 Build duration:
2 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: 

D25720: Fix shortcut conflict between Cut and Delete File

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D25720#572291 , @ngraham wrote:
  
  > Though Dolphin seems to have some kind of local hack to make Shift+delete 
work for file deletion. But it doesn't work for Cut. It's all pretty messy.
  
  
  Yes it's messy but it's Microsoft fault since they chose to use an already 
used shortcut for another thing and we are doomed.
  
  Some years ago I submitted the very same patch and it eventually led to 
8eabbf6725386e716b7536c71a9181dfe5d959f0 
 in 
kxmlgui, which automatically handles the conflict for those few apps that need 
both actions (dolphin, gwenview, etc.)
  
  (Too bad reviewboard was shutdown, I had to dig in my mail to find it :/)
  
  So imho #414799 should be closed as intentional.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D25720

To: ngraham, #frameworks, cfeck
Cc: elvisangelaccio, aspotashev, bcooksley, davidedmundson, aacid, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis updated this revision to Diff 71092.
ndavis added a comment.


  - change minimized bg opacity to 8%

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71084=71092

BRANCH
  arcpatch-D25340 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Nathaniel Graham]

ngraham added a comment.


  This feels so close to perfection! But now it feels like the minimized bg is 
too subtle, maybe. I wonder if 0.08 opacity for minimized tasks might help. Or 
maybe I'm just torturing this poor patch to death...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations

[Andreas Sturmlechner]

asturmlechner added a reviewer: Frameworks.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25812

To: asturmlechner, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  In the end, not opening device nodes readonly just because it does not concern
  'most PCs' is not sufficient. This switch, default off, would enable us to 
drop
  per-package patchwork and still keep the informal message.
  
  Back story: https://bugzilla.gnome.org/show_bug.cgi?id=744135
  BUG: 387753

TEST PLAN
  purpose continues to configure and build fine.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  gentoo

REVISION DETAIL
  https://phabricator.kde.org/D25812

AFFECTED FILES
  modules/ECMFindQMLModule.cmake.in

To: asturmlechner
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

[Christoph Cullmann]

cullmann added a comment.


  Nice that you take care of that stuff.
  Could you enhance the CMake test file, too, to cover some of the new stuff?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25811

To: turbov, #framework_syntax_highlighting
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

[Alex Turbov]

turbov created this revision.
turbov added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
turbov requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D25811

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/generators/generate-cmake-syntax.py
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25809: Use standard ECMQMLModules

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:8d7123896b98: Use standard ECMQMLModules (authored by 
asturmlechner).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25809?vs=71085=71087

REVISION DETAIL
  https://phabricator.kde.org/D25809

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/cmake/FindQMLModule.cmake.in
  src/plugins/cmake/QMLModules.cmake

To: asturmlechner, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25809: Use standard ECMQMLModules

[Nicolas Fella]

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25809

To: asturmlechner, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25809: Use standard ECMQMLModules

[Andreas Sturmlechner]

asturmlechner created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  Drop obsolete QMLModules.cmake and FindQMLModule.cmake.in
  
  Superseded by standard ECM modules.

TEST PLAN
  Build succeeds.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25809

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/cmake/FindQMLModule.cmake.in
  src/plugins/cmake/QMLModules.cmake

To: asturmlechner
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis updated this revision to Diff 71084.
ndavis added a comment.


  - Change normal bg to 15% opacity
  - Change minimized bg to 5% opacity

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=71050=71084

BRANCH
  arcpatch-D25340 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24489: KAutosaveFile not respecting maximum filename length

[Jean-Baptiste Mardelle]

mardelle marked 3 inline comments as done.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

[Jean-Baptiste Mardelle]

mardelle updated this revision to Diff 71081.
mardelle added a comment.


  Update patch according to discussion. 
  extractManagedFilePath will be broken in case of long truncated path but that 
has always been the case...

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24489?vs=67489=71081

REVISION DETAIL
  https://phabricator.kde.org/D24489

AFFECTED FILES
  src/lib/io/kautosavefile.cpp

To: mardelle, #frameworks, dfaure, mpyne
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

[Björn Feber]

GB_2 added a comment.


  In D25360#573798 , @IlyaBizyaev 
wrote:
  
  > Should this also affect GTK apps? There's a matching radio group in the GTK 
KCM.
  
  
  D25703 

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D25360

To: ngraham, #frameworks, #plasma
Cc: GB_2, IlyaBizyaev, broulik, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: niccolove; removed: ndavis.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: ndavis, #vdg, ngraham, niccolove
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Should this also affect GTK apps? There's a matching radio group in the GTK 
KCM.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D25360

To: ngraham, #frameworks, #plasma
Cc: IlyaBizyaev, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

Re: Submitting Grantlee as a KF5 Framework

[laurent Montel]

Le dimanche 8 décembre 2019, 10:52:19 CET Volker Krause a écrit :
> Hi,
> 
> very happy to see Grantlee "coming home" :)
> 
> Technically I think it's largely in line with Frameworks requirements
> already, and it has been reliably powering e.g. KMail's message viewer for
> years. Moving to a faster and, more importantly, predictable release cycle
> would help us a lot with upstreaming extensions and improvements though,
> and would allow us to get rid of some repeated code in applications.

Indeed same for kaddressbook/knotes/akregator :)

> 
> Longer term I'd also hope we can add the support for QtGui types (icons,
> colors, palettes, etc) that is currently spread around application code,
> either as a plugin in the Grantlee repo directly, or as a tier 2 framework
> on top.
> 
> So, definitely a +1 from me!

+1 for me too

Thanks Stephen !


> 
> Regards,
> Volker
> 
> On Friday, 6 December 2019 22:36:09 CET Stephen Kelly wrote:
> > Hello,
> > 
> > I have been developing Grantlee for over 10 years with contributions
> > from a community of others mostly connected with KDE.
> > 
> >   https://github.com/steveire/grantlee
> > 
> > I have not been able to maintain a reasonable release cadence of
> > Grantlee in the last few years (last release 3 years ago), so I'm
> > submitting Grantlee to KDE Review with the aim of addition to KDE
> > Frameworks.
> > 
> > Grantlee consists of two libraries,
> > 
> > * Grantlee::Templates is a text-template system based on Qt introspection
> > * Grantlee::TextDocument is a builder design pattern implementation for
> > processing QTextDocuments
> > 
> > Grantlee is already a dependency of several KDE applications, but it is
> > treated as an external dependency. This change would make it a Tier 1
> > KDE Framework.
> > 
> > $ apt-cache rdepends libgrantlee-templates5
> > libgrantlee-templates5
> > 
> > Reverse Depends:
> >libgrantlee5-dev
> >skrooge
> >rocs
> >libkf5pimcommon5abi3
> >libkf5messageviewer5abi5
> >libkf5messageviewer-plugins
> >libkf5kaddressbookgrantlee5
> >libkf5grantleetheme5
> >libkf5grantleetheme-plugins
> >libkf5calendarutils5abi1
> >libkf5calendarutils-bin
> >kdepim-addons
> >kjots
> >khelpcenter
> >kdevelop52-libs
> >kdevelop
> > 
> > $ apt-cache rdepends libgrantlee-textdocument5
> > libgrantlee-textdocument5
> > 
> > Reverse Depends:
> >libgrantlee5-dev
> >libkf5pimtextedit5abi3
> >libkf5messageviewer5abi5
> >libkf5messagecomposer5abi2
> >kjots
> > 
> > My intention is to make one more release of Grantlee myself before
> > turning it into a KDE Frameworks repository.
> > 
> > I don't think much needs to change in terms of the C++ code.  The
> > namespace would remain Grantlee:: etc, so that releases made from KDE
> > Frameworks will be binary compatible with previous Grantlee5 releases.
> > 
> > However, I've not been putting time into making releases (The last
> > release was over 3 years ago).
> > 
> > This is a proposal to submit Grantlee as a KF5 repository. It should be
> > a natural addition to the KF5 ecosystem. This move will mean:
> > 
> > * Grantlee will be released regularly as part of KF5
> > * All KDE contributors will have the commit bit to make changes
> > * My guilt about lack of releases will be reduced
> > 
> > Grantlee::Templates depends on QtQml for script bindings (can be
> > disabled at build time).
> > Grantlee::TextDocument depends only on QtGui.
> > 
> > 
> > I'm not quite familiar with what needs to happen to complete this
> > transition. It seems to me that something along these lines ought to do
> > it:
> > 
> > * I make one last release of Grantlee myself
> > * Set up a new KDE repository for me to push to
> > * Integrate KF5 buildsystem into Grantlee (ECM for example)
> > * Set up CI for that repository
> > * Set up doxygen generation for the repository
> > * Transfer grantlee.org to KDE sysadmin
> > 
> > Grantlee already has ki18n integration in the form of a library
> > 
> > implementing Grantlee abstractions:
> >   https://cgit.kde.org/grantleetheme.git/about/
> > 
> > Initial reviews and comments welcome!
> > 
> > Thanks,
> > 
> > Stephen.


-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 

Re: Submitting Grantlee as a KF5 Framework

[Volker Krause]

Hi,

very happy to see Grantlee "coming home" :)

Technically I think it's largely in line with Frameworks requirements already, 
and it has been reliably powering e.g. KMail's message viewer for years. 
Moving to a faster and, more importantly, predictable release cycle would help 
us a lot with upstreaming extensions and improvements though, and would allow 
us to get rid of some repeated code in applications.

Longer term I'd also hope we can add the support for QtGui types (icons, 
colors, palettes, etc) that is currently spread around application code, 
either as a plugin in the Grantlee repo directly, or as a tier 2 framework on 
top.

So, definitely a +1 from me!

Regards,
Volker

On Friday, 6 December 2019 22:36:09 CET Stephen Kelly wrote:
> Hello,
> 
> I have been developing Grantlee for over 10 years with contributions
> from a community of others mostly connected with KDE.
> 
>   https://github.com/steveire/grantlee
> 
> I have not been able to maintain a reasonable release cadence of
> Grantlee in the last few years (last release 3 years ago), so I'm
> submitting Grantlee to KDE Review with the aim of addition to KDE
> Frameworks.
> 
> Grantlee consists of two libraries,
> 
> * Grantlee::Templates is a text-template system based on Qt introspection
> * Grantlee::TextDocument is a builder design pattern implementation for
> processing QTextDocuments
> 
> Grantlee is already a dependency of several KDE applications, but it is
> treated as an external dependency. This change would make it a Tier 1
> KDE Framework.
> 
> $ apt-cache rdepends libgrantlee-templates5
> libgrantlee-templates5
> Reverse Depends:
>libgrantlee5-dev
>skrooge
>rocs
>libkf5pimcommon5abi3
>libkf5messageviewer5abi5
>libkf5messageviewer-plugins
>libkf5kaddressbookgrantlee5
>libkf5grantleetheme5
>libkf5grantleetheme-plugins
>libkf5calendarutils5abi1
>libkf5calendarutils-bin
>kdepim-addons
>kjots
>khelpcenter
>kdevelop52-libs
>kdevelop
> $ apt-cache rdepends libgrantlee-textdocument5
> libgrantlee-textdocument5
> Reverse Depends:
>libgrantlee5-dev
>libkf5pimtextedit5abi3
>libkf5messageviewer5abi5
>libkf5messagecomposer5abi2
>kjots
> 
> 
> My intention is to make one more release of Grantlee myself before
> turning it into a KDE Frameworks repository.
> 
> I don't think much needs to change in terms of the C++ code.  The
> namespace would remain Grantlee:: etc, so that releases made from KDE
> Frameworks will be binary compatible with previous Grantlee5 releases.
> 
> However, I've not been putting time into making releases (The last
> release was over 3 years ago).
> 
> This is a proposal to submit Grantlee as a KF5 repository. It should be
> a natural addition to the KF5 ecosystem. This move will mean:
> 
> * Grantlee will be released regularly as part of KF5
> * All KDE contributors will have the commit bit to make changes
> * My guilt about lack of releases will be reduced
> 
> Grantlee::Templates depends on QtQml for script bindings (can be
> disabled at build time).
> Grantlee::TextDocument depends only on QtGui.
> 
> 
> I'm not quite familiar with what needs to happen to complete this
> transition. It seems to me that something along these lines ought to do it:
> 
> * I make one last release of Grantlee myself
> * Set up a new KDE repository for me to push to
> * Integrate KF5 buildsystem into Grantlee (ECM for example)
> * Set up CI for that repository
> * Set up doxygen generation for the repository
> * Transfer grantlee.org to KDE sysadmin
> 
> Grantlee already has ki18n integration in the form of a library
> implementing Grantlee abstractions:
> 
>   https://cgit.kde.org/grantleetheme.git/about/
> 
> Initial reviews and comments welcome!
> 
> Thanks,
> 
> Stephen.


signature.asc
Description: This is a digitally signed message part.

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove added a comment.


  In D25340#573672 , @ndavis wrote:
  
  > @niccolove Do you mind if I commandeer this? I know dealing with these 
kinds of issues can be super annoying and I'm already used to it.
  
  
  Feel free to do that :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham, ndavis
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns