KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/79/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 16 Dec 2019 06:05:36 +
 Build duration:
5 min 31 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.66.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kautosavefiletest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6870/9088)43%
(10722/24783)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2872/2974)48%
(6142/12677)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(863/1306)35%
(980/2823)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(670/786)42%
(948/2251)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(991/1212)50%
(1012/2011)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/128/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 16 Dec 2019 06:05:37 +
 Build duration:
3 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.66.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kautosavefiletest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6870/9089)43%
(10722/24783)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2872/2974)48%
(6142/12677)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(863/1306)35%
(980/2823)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(670/787)42%
(948/2251)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(991/1212)50%
(1012/2011)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/76/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Dec 2019 06:05:36 +
 Build duration:
2 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kautosavefiletestFailed: projectroot.autotests.kdirwatch_inotify_unittest

D26034: Replace KLocalSocket with QLocalSocket

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella added subscribers: vonreth, cullmann.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26034

To: nicolasfella, #frameworks
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26034: Replace KLocalSocket with QLocalSocket

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  As described in T12010 .
  
  AFAIU the QTcpSocket path was only used for Windows, but since QLocalSocket 
supports Windows we can just use that.
  
  This is entirely untested on Windows though.

TEST PLAN
  Did some SFTP stuff in Dolphin.
  No new tests fail

REPOSITORY
  R241 KIO

BRANCH
  klocalsocket

REVISION DETAIL
  https://phabricator.kde.org/D26034

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/klocalsocketservertest.cpp
  autotests/klocalsocketservertest.h
  autotests/klocalsockettest.cpp
  autotests/klocalsockettest.h
  src/core/CMakeLists.txt
  src/core/connection.cpp
  src/core/connectionbackend.cpp
  src/core/connectionbackend_p.h
  src/core/connectionserver.cpp
  src/core/klocalsocket.cpp
  src/core/klocalsocket.h
  src/core/klocalsocket_p.h
  src/core/klocalsocket_unix.cpp
  src/core/klocalsocket_win.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/52/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 23:01:07 +
 Build duration:
4 min 40 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 156 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/156/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 22:32:35 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.messagetestName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 360 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/360/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 15 Dec 2019 22:17:44 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34610/61665)40%
(17540/43565)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9643/10105)47%
(4500/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8642/14559)51%
(4492/8823)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4658/8286)43%
(2030/4748)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(663/1206)38%
(361/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 62 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/62/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 22:29:20 +
 Build duration:
6 min 20 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)Name: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 227 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/227/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 22:17:44 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 35 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/35/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 15 Dec 2019 22:10:09 +
 Build duration:
7 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 22:00:14 +
 Build duration:
1 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/26/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 21:43:09 +
 Build duration:
1 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/44/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 21:44:58 +
 Build duration:
2 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/26/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 21:45:34 +
 Build duration:
1 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 226 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/226/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 21:00:38 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25533: Deprecate KFileWidget::toolBar

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6973d4b26501: Deprecate KFileWidget::toolBar (authored by 
nicolasfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25533?vs=70622=71631#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25533?vs=70622=71631

REVISION DETAIL
  https://phabricator.kde.org/D25533

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

[seb sasch]

sasch added a comment.


  You created the patch within hours, it was approved within days.
  
  One year later we still have nothing within master or any usable distro. Any 
plans at all to show correct file sizes with KDE?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17071

To: davidedmundson, dfaure, apol
Cc: bruns, sasch, adridg, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham

D25517: Add an option to extract image data and add front cover property

[Alexander Stippich]

astippich retitled this revision from "Add an option to extract binary data and 
add front cover property" to "Add an option to extract image data and add front 
cover property".

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25517: Add an option to extract binary data and add front cover property

[Alexander Stippich]

astippich updated this revision to Diff 71623.
astippich added a comment.


  - rename flag to ImageData

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25517?vs=70723=71623

BRANCH
  binaryData

REVISION DETAIL
  https://phabricator.kde.org/D25517

AFFECTED FILES
  src/extractionresult.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:f2fea112: Remove unrequired private declarations for 
taglibextractor (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25516?vs=70398=71620

REVISION DETAIL
  https://phabricator.kde.org/D25516

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D23205: [KProcessList] Optimize KProcessList::processInfo

[David Hallas]

hallas added a comment.


  Sorry for breaking the build :/
  
  @kossebau  - thanks for fixing it so quickly! I think your fix looks fine :D

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23205

To: hallas, davidedmundson, broulik, mpyne
Cc: kossebau, bcooksley, mpyne, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 127 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/127/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 15 Dec 2019 18:47:55 +
 Build duration:
6 min 34 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.66.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kautosavefiletest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6870/9089)43%
(10722/24783)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2872/2974)48%
(6142/12677)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(863/1306)35%
(980/2823)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(670/787)42%
(948/2251)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(991/1212)50%
(1012/2011)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 18:47:55 +
 Build duration:
4 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kautosavefiletestFailed: projectroot.autotests.kdirwatch_inotify_unittest

D23205: [KProcessList] Optimize KProcessList::processInfo

[Friedrich W. H. Kossebau]

kossebau added a comment.


  I pushed a quick fix to unbreak the build as 
bfdc20ed7c6fc1397ba66edd07f86c84d380e291 

  You might want to inspect it to add that optimization code for the procstat 
as well, if possible (no idea).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23205

To: hallas, davidedmundson, broulik, mpyne
Cc: kossebau, bcooksley, mpyne, apol, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/78/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 15 Dec 2019 18:47:55 +
 Build duration:
4 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.66.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kautosavefiletest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6870/9088)43%
(10722/24783)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2872/2974)48%
(6142/12677)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(863/1306)35%
(980/2823)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(670/786)42%
(948/2251)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(991/1212)50%
(1012/2011)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/74/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 18:38:09 +
 Build duration:
2 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 495 lines...][2019-12-15T18:40:18.529Z]std::move(spyDeleted)[2019-12-15T18:40:18.529Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:367:12: warning: local variable 'spyDeleted' will be copied despite being returned by name [-Wreturn-std-move][2019-12-15T18:40:18.529Z] return spyDeleted;[2019-12-15T18:40:18.529Z]^~[2019-12-15T18:40:18.529Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:367:12: note: call 'std::move' explicitly to avoid copying[2019-12-15T18:40:18.529Z] return spyDeleted;[2019-12-15T18:40:18.529Z]^~[2019-12-15T18:40:18.529Z]std::move(spyDeleted)[2019-12-15T18:40:18.529Z] [ 52%] Building CXX object autotests/CMakeFiles/kstringhandlertest.dir/kstringhandlertest.cpp.o[2019-12-15T18:40:18.529Z] [ 52%] Built target kprocesstest_helper[2019-12-15T18:40:18.859Z] Scanning dependencies of target kpluginmetadatatest[2019-12-15T18:40:19.169Z] [ 53%] Building CXX object autotests/CMakeFiles/kpluginmetadatatest.dir/kpluginmetadatatest_autogen/mocs_compilation.cpp.o[2019-12-15T18:40:19.169Z] [ 53%] Building CXX object autotests/CMakeFiles/kpluginmetadatatest.dir/kpluginmetadatatest.cpp.o[2019-12-15T18:40:19.776Z] [ 53%] Linking CXX executable ../bin/kdelibs4migrationtest[2019-12-15T18:40:20.056Z] [ 54%] Linking CXX executable ../bin/kusertest[2019-12-15T18:40:20.329Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:289:20: warning: local variable 'spyDirty' will be copied despite being returned by name [-Wreturn-std-move][2019-12-15T18:40:20.329Z] return spyDirty;[2019-12-15T18:40:20.329Z]^~~~[2019-12-15T18:40:20.329Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:289:20: note: call 'std::move' explicitly to avoid copying[2019-12-15T18:40:20.329Z] return spyDirty;[2019-12-15T18:40:20.329Z]^~~~[2019-12-15T18:40:20.329Z]std::move(spyDirty)[2019-12-15T18:40:20.329Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:293:12: warning: local variable 'spyDirty' will be copied despite being returned by name [-Wreturn-std-move][2019-12-15T18:40:20.329Z] return spyDirty;[2019-12-15T18:40:20.329Z]^~~~[2019-12-15T18:40:20.329Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:293:12: note: call 'std::move' explicitly to avoid copying[2019-12-15T18:40:20.329Z] return spyDirty;[2019-12-15T18:40:20.329Z]^~~~[2019-12-15T18:40:20.329Z]std::move(spyDirty)[2019-12-15T18:40:20.329Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:363:20: warning: local variable 'spyDeleted' will be copied despite being returned by name [-Wreturn-std-move][2019-12-15T18:40:20.329Z] return spyDeleted;[2019-12-15T18:40:20.329Z]^~[2019-12-15T18:40:20.329Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:363:20: note: call 'std::move' explicitly to avoid copying[2019-12-15T18:40:20.329Z] return spyDeleted;[2019-12-15T18:40:20.329Z]^~[2019-12-15T18:40:20.329Z]std::move(spyDeleted)[2019-12-15T18:40:20.329Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:367:12: warning: local variable 'spyDeleted' will be copied despite being returned by name [-Wreturn-std-move][2019-12-15T18:40:20.329Z] return spyDeleted;[2019-12-15T18:40:20.329Z]^~[2019-12-15T18:40:20.329Z] /usr/home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 FreeBSDQt5.13/autotests/kdirwatch_unittest.cpp:367:12: note: call 'std::move' explicitly to avoid copying[2019-12-15T18:40:20.329Z] return spyDeleted;[2019-12-15T18:40:20.329Z]^~[2019-12-15T18:40:20.329Z]std::move(spyDeleted)[2019-12-15T18:40:20.637Z] 4 warnings generated.[2019-12-15T18:40:20.637Z] [ 54%] Linking CXX executable ../bin/kdirwatch_qfswatch_unittest[2019-12-15T18:40:20.637Z] [ 54%] Built target kusertest[2019-12-15T18:40:20.637Z] [ 54%] Built target kdelibs4migrationtest[2019-12-15T18:40:21.323Z] Scanning dependencies of target krandomtest[2019-12-15T18:40:21.323Z] Scanning dependencies of target 

D23457: Port the search interface from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71618.
ahmadsamir retitled this revision from "Port regex search to 
QRegularExpression" to "Port the search interface from QRegExp to 
QRegularExpression".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir added a comment.


  Verbatim commit message

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23457?vs=71617=71618

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23457

AFFECTED FILES
  autotests/src/regexpsearch_test.cpp
  autotests/src/searchbar_test.cpp
  src/CMakeLists.txt
  src/document/katedocument.cpp
  src/search/kateplaintextsearch.cpp
  src/search/kateregexp.cpp
  src/search/kateregexp.h
  src/search/kateregexpsearch.cpp
  src/search/kateregexpsearch.h
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/utils/katesedcmd.cpp
  src/utils/katesedcmd.h

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23457: Port regex search to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  Disagreement doesn't always mean distrust.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23457

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23457: Port regex search to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71617.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23457?vs=71178=71617

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23457

AFFECTED FILES
  autotests/src/regexpsearch_test.cpp
  autotests/src/searchbar_test.cpp
  src/CMakeLists.txt
  src/document/katedocument.cpp
  src/search/kateplaintextsearch.cpp
  src/search/kateregexp.cpp
  src/search/kateregexp.h
  src/search/kateregexpsearch.cpp
  src/search/kateregexpsearch.h
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/utils/katesedcmd.cpp
  src/utils/katesedcmd.h

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25984: Load translations

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D25984#578306 , @kossebau wrote:
  
  > Hm, though now I am confused why calling this from 
`KirigamiPlugin::initializeEngine` fixes things for you, the static struct 
constructor of that startup hook technology in the lib should be invoked before 
during loading, no?
  
  
  Looking at the ECM generated code, that one sees to do the catalog loading in 
the main thread, and if not in the main thread already using a timer event to 
trigger the loading there.
  While the plugin is loaded in another thread (called "QQmlThread" by what my 
debug output told me).
  
INIT CATALOG HOOKUP QThread(0x564b8c8c6fb0, name = "QQmlThread")
INIT ENGINE QThread(0x564b8c3a28d0)
LOADING FROM CATALOG HOOKUP QThread(0x564b8c3a28d0)
  
  Which explains to me why your patch then fixes things.
  
  No idea/proposal about/for a proper solution, but at least my curiousity is 
satisfied for now for what is broken here :/

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  I guess it builds the QML tree and evaluates the `qsTr` calls and then finds 
it needs an item from a plugin and loads the import and only then translates 
it. Subsequent controls are translated, only the ones on the initial item are 
not. Perhaps if we shoehorn a `QQmlEngine::retranslate()` call in the ecm qm 
loader thing (or rather have a ecm qm loader for qml plugin) it should force 
re-evaluation of those things. Not pretty either :/

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D25984: Load translations

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Hm, though now I am confused why calling this from 
`KirigamiPlugin::initializeEngine` fixes things for you, the static struct 
constructor of that startup hook technology in the lib should be invoked before 
during loading, no?
  
  Time to go playing with the actual code myself.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D25984: Load translations

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D25984#578299 , @broulik wrote:
  
  > Ok, so turns out, it does call it when the plugin is loaded, but the 
translations are only installed *after* the QML has loaded and processed.
  
  
  Uh, okay, that seems like things need indeed another approach. Actually, any 
librarries using the hook and linked to only from qml plugins would then be 
prone to fail?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D25984: Load translations

[David Edmundson]

davidedmundson added a comment.


  > Okay. Which app did you test with? Does it link kcoreaddons? Would poke 
then as well a bit, as I happen to have a related rant blog post lying around 
;) ).
  
  systemsettings5 exhibits this situation

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D25984: Load translations

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D25984#578298 , @broulik wrote:
  
  > Well, whatever it is, it doesn't work. My search field isn't translated and 
I put breakpoints and I only get it load translations for kcoreaddons and 
kjobwidgets.
  
  
  Okay. Which app did you test with? Does it link kcoreaddons? Would poke then 
as well a bit, as I happen to have a related rant blog post lying around ;) ).

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  Ok, so turns out, it does call it when the plugin is loaded, but the 
translations are only installed *after* the QML has loaded and processed.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  Well, whatever it is, it doesn't work. My search field isn't translated and I 
put breakpoints and I only get it load translations for kcoreaddons and 
kjobwidgets.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25984: Load translations

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D25984#578296 , @broulik wrote:
  
  > We don't link against Kirigami, so the startup routine stuff doesn't apply?
  
  
  `Q_COREAPP_STARTUP_FUNCTION` generates a static struct in the compiled code, 
whose constructor will be invoked on loading the lib which bundles that obect 
code, and the constructor does the registration call (which then also cares for 
directly executing the method if already passed QApp construction phase). See 
below for how exactly.
  
  So at least to what I "know" being loaded in a lib only later at runtime 
still should result in the call being triggered, as also at that time any 
static objects will be constructed/init during lib load.
  
  > And we're way after the QCoreApp constructor at this point.
  
  Yes, but that is something `qAddPreRoutine` deals with, by in that case then 
also executing the method itself:
  
void qAddPreRoutine(QtStartUpFunction p)
{
QStartUpFuncList *list = preRList();
if (!list)
return;
if (QCoreApplication::instance())
p();
// Due to C++11 parallel dynamic initialization, this can be called
// from multiple threads.
QMutexLocker locker();
list->prepend(p); // in case QCoreApplication is re-created, see 
qt_call_pre_routines
}
  
  See how `qAddPreRoutine` code is generated  by `Q_COREAPP_STARTUP_FUNCTION`:
  
#define Q_COREAPP_STARTUP_FUNCTION(AFUNC) \
static void AFUNC ## _ctor_function() {  \
qAddPreRoutine(AFUNC);\
} \
Q_CONSTRUCTOR_FUNCTION(AFUNC ## _ctor_function)
  
  with `Q_CONSTRUCTOR_FUNCTION` being:
  
#ifndef Q_CONSTRUCTOR_FUNCTION
# define Q_CONSTRUCTOR_FUNCTION0(AFUNC) \
namespace { \
static const struct AFUNC ## _ctor_class_ { \
inline AFUNC ## _ctor_class_() { AFUNC(); } \
} AFUNC ## _ctor_instance_; \
}
# define Q_CONSTRUCTOR_FUNCTION(AFUNC) Q_CONSTRUCTOR_FUNCTION0(AFUNC)
#endif

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  We don't link against Kirigami, so the startup routine stuff doesn't apply? 
And we're way after the QCoreApp constructor at this point.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25922: Don't use a verified nullptr as a data source

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:5a379ba5a6ce: Dont use a verified nullptr as a data 
source (authored by leinir).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25922?vs=71362=71608

REVISION DETAIL
  https://phabricator.kde.org/D25922

AFFECTED FILES
  src/provider.cpp
  src/version.h.cmake

To: leinir, #frameworks, #knewstuff, #plasma, ronaldv, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25984: Load translations

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D25984#578291 , @broulik wrote:
  
  > Qt docs say "Adds a global function that will be called from the 
QCoreApplication constructor. " but when we at runtime somewhere load a QML 
plugin we're too late with that.
  
  
  Q_COREAPP_STARTUP_FUNCTION creates code using qAddPreRoutine(), which does 
directly execute the registered method though when the QApp already exists, as 
I tried to hint before, and has since Qt 5.6 at least. (see the above link :) 
). The API dox is missing to define that, indeed, but thinking about it one 
would expect it to happen.
  
  Things might fail though if there is static linking involved perhaps with the 
plugins somehow?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove added a comment.


  Got it. Blur is not rounded either to me. The shadow was hiding it.
  F7819795: Screenshot_20191215_170023.png 

  
  In D25015#575297 , @mart wrote:
  
  > In D25015#568865 , @niccolove 
wrote:
  >
  > > Got it. The shape is actually rounded BUT the desktop contract effect is 
applied in the whole rectangle underneath, and it makes everything look like a 
rectangle. Here's the widget with fully transparent background, but with the 
contract effect on:
  > >  F7788618: Screenshot_20191128_153515.png 

  > >  Of course, I can't just turn off the contrast desktop effect. I'm unsure 
how to move forward with this.
  > >  Here's Plasma without desktop effect:
  > >  F7788630: Screenshot_20191128_154652.png 

  > >  As you can see, shadows are working!
  >
  >
  > Not sure why it looks rectangular, on current theme the mask- prefix is 
correctly used and the blur is correctly shaped with rounded borders
  
  
  If you remove the shadows, desktop effect and background, do you still see 
rounded blur? If so, it's my machine.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  Qt docs say "Adds a global function that will be called from the 
QCoreApplication constructor. " but when we at runtime somewhere load a QML 
plugin we're too late with that.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove added a comment.


  I just compared the blur and contrast effects and the mask is used in the 
exact same way :-/ I have no idea what could be wrong there.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25984: Load translations

[Friedrich W. H. Kossebau]

kossebau added a comment.


  > The ECM QM Loader uses Q_COREAPP_STARTUP_FUNCTION which doesn't work for 
things loaded as plugins like QML modules.
  
  Curious, where it exactly does it fail to work? Q_COREAPP_STARTUP_FUNCTION 
being nvoked during lib loading after the QApp instance exists still should 
result in the startup function to be executed from what I remember and just 
looked at again in the code 
(https://code.woboq.org/qt5/qtbase/src/corelib/kernel/qcoreapplication.cpp.html#286),
 see the
  
if (QCoreApplication::instance())
p();
  
  So, what am I missing? :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  Breeze dark highlight is currently #3daee9 in the Breeze Dark colorscheme. If 
that's too light, we could darken it there, right?
  Currently it's: F7819764: Screenshot_20191215_163924.png 

  Darker could be (example value):
  F7819766: Screenshot_20191215_164056.png 

  Otherwise, the highlight effect could be made more transparent so that it's 
darker, but that would be a problem for consistency, as the same highlight 
color is also used throughout the desktop theme.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26000: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags don't knows

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:192a50fe8c3c: [Plasma Dialog] Use QXcbWindowFunctions for 
setting window types Qt WindowFlags… (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26000?vs=71538=71606#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26000?vs=71538=71606

REVISION DETAIL
  https://phabricator.kde.org/D26000

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26016: [KeySequenceHelper] Work around Meta modifier behavior

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26016

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26017

To: broulik, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26000: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags don't knows

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I think we need to look at our direction of KWindowSystem long term, but in 
terms of what actually happens this makes complete sense.
  
  Better to set the right type once, than to constantly set and reset the same 
thing, sending garbage data over the wire.

INLINE COMMENTS

> dialog.cpp:728
> +case Dialog::Normal:
> +Q_UNREACHABLE();
> +break;

Personally, I prefer Q_ASSERT + return as you get to catch when a future 
mistake happens.
Whereas with Q_UNREACHABLE you get literally undefined behaviour as the 
compiler will optimise this out the jump map.

(not that it really matters...it is unreachable)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26000

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25999: Add optional subtitle to grid delegate

[Nathaniel Graham]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:0dda5f9566cf: Add optional subtitle to grid delegate 
(authored by ngraham).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25999?vs=71540=71598

REVISION DETAIL
  https://phabricator.kde.org/D25999

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml
  src/qmlcontrols/kcmcontrols/qml/private/GridViewInternal.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: ndavis, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25999: Add optional subtitle to grid delegate

[Nathaniel Graham]

ngraham added a comment.


  Got a shipit from @davidedmundson, shippingit!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: ndavis, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26017: [KKeySequenceWidget] Work around Meta modifier behavior

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When I press my Meta key, I get a `Key_Super_L` *without* a Meta key 
confusing the rest of the modifier handling in this class.
  To work around this, explicitly set `MetaModifier` when the key is pressed 
and remove it

TEST PLAN
  - I can now press Meta and it is handled immediately like Alt and Shift

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26017

AFFECTED FILES
  src/kkeysequencewidget.cpp

To: broulik, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26016: [KeySequenceHelper] Work around Meta modifier behavior

[Kai Uwe Broulik]

broulik updated this revision to Diff 71596.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Turns out it's not QtQuick

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26016?vs=71595=71596

REVISION DETAIL
  https://phabricator.kde.org/D26016

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26016: [KeySequenceHelper] Work around Meta modifier behavior

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  For some reason in QtQuick when I press my Meta key, I get a `Key_Super_L` 
*without* a Meta key confusing the rest of the modifier handling in this class.
  To work around this, explicitly set `MetaModifier` when the key is pressed 
and remove it

TEST PLAN
  - I can use Meta for modifiers properly now like I can do in the Qt widgets 
counterpart

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26016

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26014: remove compiler information from bug report dialog

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26014

To: sitter, dfaure, ngraham, davidedmundson
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Aleix Pol Gonzalez]

apol added a comment.


  In D13541#578027 , @bcooksley 
wrote:
  
  > This broke the build on FreeBSD - Please see 
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/
  
  
  fixed

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: bcooksley, davidedmundson, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26014: remove compiler information from bug report dialog

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  it's been broken since 5.0 and nobody noticed. Nate and I also think that
  it doesn't really add much, if any, value.

TEST PLAN
  built it and the broken label is gone

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26014

AFFECTED FILES
  src/config-xmlgui.h.cmake
  src/kbugreport.cpp
  src/kbugreport.h

To: sitter, dfaure
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D26014: remove compiler information from bug report dialog

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26014

To: sitter, dfaure, ngraham
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D26013: [KeySequenceHelper] Grab actual window when embedded

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidre.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When used in a KCM which uses `QQuickWidget` it needs to enable grab on the 
render window and not the embedded container.

TEST PLAN
  - Put KeySequence thing in a KCM, I could now type a shortcut which was 
occupied by someone else
  - Still works in system settings (`renderWindowFor` annoyingly returns 
`nullptr` instead of the same window if it isn't redirected so I had to check)
  
  For simplicity I store the window in a `QPointer` to ungrab the same thing I 
grabbed before

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26013

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: broulik, #plasma, davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/45/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 11:18:41 +
 Build duration:
1 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/44/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 11:11:51 +
 Build duration:
1 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 551 lines...][2019-12-15T11:13:12.372Z] [ 80%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halfstabhandling.cpp.o[2019-12-15T11:13:12.372Z] [ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halgenericinterface.cpp.o[2019-12-15T11:13:12.372Z] [ 81%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/haldevice.cpp.o[2019-12-15T11:13:12.631Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halmanager.cpp.o[2019-12-15T11:13:12.631Z] [ 82%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halopticaldisc.cpp.o[2019-12-15T11:13:12.631Z] [ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halportablemediaplayer.cpp.o[2019-12-15T11:13:12.888Z] [ 83%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halprocessor.cpp.o[2019-12-15T11:13:12.888Z] [ 84%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halstorageaccess.cpp.o[2019-12-15T11:13:13.149Z] [ 84%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halstorage.cpp.o[2019-12-15T11:13:13.149Z] [ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/devices/backends/hal/halvolume.cpp.o[2019-12-15T11:13:13.407Z] [ 85%] Building CXX object src/solid/CMakeFiles/KF5Solid_static.dir/ECMQmLoader-solid5_qt.cpp.o[2019-12-15T11:13:13.407Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.13/src/solid/devices/backends/hal/haldevice.cpp:534:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2019-12-15T11:13:13.407Z] second = trUtf8("/DVD±R DL", "Second item of %1%2 Drive sentence");[2019-12-15T11:13:13.407Z]  ^[2019-12-15T11:13:13.407Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.13/src/solid/devices/backends/hal/haldevice.h:45:5: note: 'trUtf8' has been explicitly marked deprecated here[2019-12-15T11:13:13.407Z] Q_OBJECT[2019-12-15T11:13:13.407Z] ^[2019-12-15T11:13:13.407Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:186:5: note: expanded from macro 'Q_OBJECT'[2019-12-15T11:13:13.407Z] QT_TR_FUNCTIONS \[2019-12-15T11:13:13.407Z] ^[2019-12-15T11:13:13.407Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:142:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2019-12-15T11:13:13.407Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2019-12-15T11:13:13.407Z] ^[2019-12-15T11:13:13.407Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2019-12-15T11:13:13.407Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2019-12-15T11:13:13.407Z] ^[2019-12-15T11:13:13.407Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:233:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2019-12-15T11:13:13.407Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2019-12-15T11:13:13.407Z] ^[2019-12-15T11:13:13.407Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.13/src/solid/devices/backends/hal/haldevice.cpp:536:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2019-12-15T11:13:13.407Z] second = trUtf8("/DVD±R", "Second item of %1%2 Drive sentence");[2019-12-15T11:13:13.407Z]  ^[2019-12-15T11:13:13.407Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.13/src/solid/devices/backends/hal/haldevice.h:45:5: note: 'trUtf8' has been explicitly marked deprecated here[2019-12-15T11:13:13.407Z] Q_OBJECT[2019-12-15T11:13:13.407Z] ^[2019-12-15T11:13:13.407Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:186:5: note: expanded from macro 'Q_OBJECT'[2019-12-15T11:13:13.407Z] QT_TR_FUNCTIONS \[2019-12-15T11:13:13.407Z] ^[2019-12-15T11:13:13.407Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:142:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2019-12-15T11:13:13.407Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2019-12-15T11:13:13.407Z] ^[2019-12-15T11:13:13.407Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2019-12-15T11:13:13.407Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2019-12-15T11:13:13.407Z] ^[2019-12-15T11:13:13.407Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:233:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2019-12-15T11:13:13.407Z] #  define Q_DECL_DEPRECATED __attribute__ 

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/47/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 15 Dec 2019 10:03:25 +
 Build duration:
4 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 82 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/82/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 15 Dec 2019 10:03:29 +
 Build duration:
3 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D26011: Align ECM and Qt setup with Frameworks conventions

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R174:ce6699a141a0: Align ECM and Qt setup with Frameworks 
conventions (authored by vkrause).

REPOSITORY
  R174 KContacts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26011?vs=71575=71576

REVISION DETAIL
  https://phabricator.kde.org/D26011

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt

To: vkrause, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 225 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/225/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 09:57:53 +
 Build duration:
8 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26011: Align ECM and Qt setup with Frameworks conventions

[Volker Krause]

vkrause updated this revision to Diff 71575.
vkrause added a comment.


  Remove duplicate include.

REPOSITORY
  R174 KContacts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26011?vs=71573=71575

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26011

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt

To: vkrause, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25972: Support PyQt5 compiled with SIP 5

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:7c84be59f686: Support PyQt5 compiled with SIP 5 (authored 
by arojas).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25972?vs=71563=71574

REVISION DETAIL
  https://phabricator.kde.org/D25972

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: arojas, bruns, dfaure, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26011: Align ECM and Qt setup with Frameworks conventions

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:28
>  include(ECMSetupVersion)
>  include(FeatureSummary)
>  include(ECMQtDeclareLoggingCategory)

Remove this one

REPOSITORY
  R174 KContacts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26011

To: vkrause, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 224 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/224/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 09:45:56 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26011: Align ECM and Qt setup with Frameworks conventions

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This completes the previous commit which provided the hotfix for the ECM
  version lookup issue breaking the build.

REPOSITORY
  R174 KContacts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26011

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.13 - Build # 35 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.13/35/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 15 Dec 2019 09:46:08 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.kcontacts_addresstest

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.13 - Build # 38 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.13/38/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 15 Dec 2019 09:46:08 +
 Build duration:
5 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Contacts-5.66.0.xmlcompat_reports/KF5Contacts_compat_report.htmllogs/KF5Contacts/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)83%
(68/82)83%
(68/82)77%
(8547/11030)52%
(2990/5790)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(32/32)100%
(32/32)99%
(4274/4288)52%
(1030/1974)src82%
(31/38)82%
(31/38)65%
(3602/5566)51%
(1535/3007)src.converter100%
(2/2)100%
(2/2)73%
(331/455)57%
(221/386)src.generator0%
(0/3)0%
(0/3)0%
(0/153)0%
(0/76)src.vcardparser100%
(3/3)100%
(3/3)86%
(340/396)79%
(204/259)tests0%
(0/4)0%
(0/4)0%
(0/172)0%
(0/88)

KDE CI: Frameworks » kcontacts » kf5-qt5 SUSEQt5.12 - Build # 37 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20SUSEQt5.12/37/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 15 Dec 2019 09:46:09 +
 Build duration:
3 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Contacts-5.66.0.xmlcompat_reports/KF5Contacts_compat_report.htmllogs/KF5Contacts/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)83%
(68/82)83%
(68/82)77%
(8547/11030)52%
(2990/5790)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(32/32)100%
(32/32)99%
(4274/4288)52%
(1030/1974)src82%
(31/38)82%
(31/38)65%
(3602/5566)51%
(1535/3007)src.converter100%
(2/2)100%
(2/2)73%
(331/455)57%
(221/386)src.generator0%
(0/3)0%
(0/3)0%
(0/153)0%
(0/76)src.vcardparser100%
(3/3)100%
(3/3)86%
(340/396)79%
(204/259)tests0%
(0/4)0%
(0/4)0%
(0/172)0%
(0/88)

D23205: [KProcessList] Optimize KProcessList::processInfo

[Ben Cooksley]

bcooksley added a comment.


  This broke the build on FreeBSD - See 
https://build.kde.org/view/Failing/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/lastFailedBuild/console

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23205

To: hallas, davidedmundson, broulik, mpyne
Cc: bcooksley, mpyne, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kcontacts » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20FreeBSDQt5.13/36/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 09:46:08 +
 Build duration:
1 min 57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 32 test(s)

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Ben Cooksley]

bcooksley added a comment.


  This broke the build on FreeBSD - Please see 
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D13541

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: bcooksley, davidedmundson, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25972: Support PyQt5 compiled with SIP 5

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D25972

To: arojas, bruns, dfaure, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26009: KCoreAddons: fix compilation with qtbase git dev branch

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26009

To: dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25996: KRemoteEncoding::encoding: don't return temporary. Found with clazy.

[Christian Ehrlicher]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d80cb8c96eef: KRemoteEncoding::encoding: dont 
return temporary. Found with clazy. (authored by chehrlic).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25996?vs=71529=71572

REVISION DETAIL
  https://phabricator.kde.org/D25996

AFFECTED FILES
  src/core/kremoteencoding.cpp

To: chehrlic, thiago, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 09:44:43 +
 Build duration:
1 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 545 lines...][2019-12-15T09:46:04.138Z] Q_OBJECT[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:186:5: note: expanded from macro 'Q_OBJECT'[2019-12-15T09:46:04.138Z] QT_TR_FUNCTIONS \[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:142:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2019-12-15T09:46:04.138Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2019-12-15T09:46:04.138Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:233:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2019-12-15T09:46:04.138Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.13/src/solid/devices/backends/hal/haldevice.cpp:536:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2019-12-15T09:46:04.138Z] second = trUtf8("/DVD±R", "Second item of %1%2 Drive sentence");[2019-12-15T09:46:04.138Z]  ^[2019-12-15T09:46:04.138Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.13/src/solid/devices/backends/hal/haldevice.h:45:5: note: 'trUtf8' has been explicitly marked deprecated here[2019-12-15T09:46:04.138Z] Q_OBJECT[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:186:5: note: expanded from macro 'Q_OBJECT'[2019-12-15T09:46:04.138Z] QT_TR_FUNCTIONS \[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:142:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2019-12-15T09:46:04.138Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2019-12-15T09:46:04.138Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:233:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2019-12-15T09:46:04.138Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.13/src/solid/devices/backends/hal/haldevice.cpp:541:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2019-12-15T09:46:04.138Z] second = trUtf8("/DVD±RW DL", "Second item of %1%2 Drive sentence");[2019-12-15T09:46:04.138Z]  ^[2019-12-15T09:46:04.138Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.13/src/solid/devices/backends/hal/haldevice.h:45:5: note: 'trUtf8' has been explicitly marked deprecated here[2019-12-15T09:46:04.138Z] Q_OBJECT[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:186:5: note: expanded from macro 'Q_OBJECT'[2019-12-15T09:46:04.138Z] QT_TR_FUNCTIONS \[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qobjectdefs.h:142:5: note: expanded from macro 'QT_TR_FUNCTIONS'[2019-12-15T09:46:04.138Z] QT_DEPRECATED static inline QString trUtf8(const char *s, const char *c = nullptr, int n = -1) \[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qglobal.h:292:25: note: expanded from macro 'QT_DEPRECATED'[2019-12-15T09:46:04.138Z] #  define QT_DEPRECATED Q_DECL_DEPRECATED[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/local/include/qt5/QtCore/qcompilerdetection.h:233:45: note: expanded from macro 'Q_DECL_DEPRECATED'[2019-12-15T09:46:04.138Z] #  define Q_DECL_DEPRECATED __attribute__ ((__deprecated__))[2019-12-15T09:46:04.138Z] ^[2019-12-15T09:46:04.138Z] /usr/home/jenkins/workspace/Frameworks/solid/kf5-qt5 FreeBSDQt5.13/src/solid/devices/backends/hal/haldevice.cpp:543:26: warning: 'trUtf8' is deprecated [-Wdeprecated-declarations][2019-12-15T09:46:04.138Z] second = trUtf8("/DVD±RW", "Second item of %1%2 Drive 

D25997: KFilePlacesModel: properly parent tagsLister to avoid memleak. Introduced with D7700

[Christian Ehrlicher]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:be9537998890: KFilePlacesModel: properly parent 
tagsLister to avoid memleak. Introduced with… (authored by chehrlic).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25997?vs=71530=71571

REVISION DETAIL
  https://phabricator.kde.org/D25997

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: chehrlic, dfaure, nicolasfella, ngraham, #dolphin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25922: Don't use a verified nullptr as a data source

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R235 Attica

BRANCH
  dont-use-null-qcoreapp-instance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25922

To: leinir, #frameworks, #knewstuff, #plasma, ronaldv, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25995: HTTP ioslave: call correct base class in virtual_hook(). The base of HTTP ioslave is TCPSlaveBase, not SlaveBase.

[Christian Ehrlicher]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:6f1628706490: HTTP ioslave: call correct base class in 
virtual_hook(). The base of HTTP… (authored by chehrlic).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25995?vs=71528=71570

REVISION DETAIL
  https://phabricator.kde.org/D25995

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: chehrlic, dfaure, ngraham, #dolphin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:9f868681b26e: Port solid from Qt5::Widgets to Qt5::Gui 
(authored by graesslin, committed by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13541?vs=36167=71569#toc

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13541?vs=36167=71569

REVISION DETAIL
  https://phabricator.kde.org/D13541

AFFECTED FILES
  CMakeLists.txt
  src/solid/CMakeLists.txt
  src/solid/devices/backends/udisks2/udisksstorageaccess.cpp

To: graesslin, #frameworks, dhaumann, apol, broulik
Cc: davidedmundson, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.13 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.13/35/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 15 Dec 2019 08:54:59 +
 Build duration:
2 min 26 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Codecs-5.66.0.xmlcompat_reports/KF5Codecs_compat_report.htmllogs/KF5Codecs/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.kencodingprobertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)85%
(50/59)85%
(50/59)73%
(2796/3827)54%
(1183/2207)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)97%
(650/667)60%
(111/184)src81%
(13/16)81%
(13/16)74%
(1493/2008)63%
(840/1344)src.probers84%
(31/37)84%
(31/37)57%
(653/1152)34%
(232/679)

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.12 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.12/63/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 15 Dec 2019 08:54:59 +
 Build duration:
2 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Codecs-5.66.0.xmlcompat_reports/KF5Codecs_compat_report.htmllogs/KF5Codecs/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.kencodingprobertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)85%
(50/59)85%
(50/59)73%
(2796/3827)54%
(1183/2207)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)97%
(650/667)60%
(111/184)src81%
(13/16)81%
(13/16)74%
(1493/2008)63%
(840/1344)src.probers84%
(31/37)84%
(31/37)57%
(653/1152)34%
(232/679)

KDE CI: Frameworks » kcodecs » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20FreeBSDQt5.13/31/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Dec 2019 08:54:59 +
 Build duration:
1 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.kencodingprobertest