D26650: Use KService to look for Filelight

[Shubham]

shubham marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26650: Use KService to look for Filelight

[Shubham]

shubham updated this revision to Diff 73593.
shubham added a comment.


  Make requested changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26650?vs=73556=73593

BRANCH
  filelight

REVISION DETAIL
  https://phabricator.kde.org/D26650

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog_p.h

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26652: Unbreak module imports for Python2

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Last night's run of api.kde.org generation with kapidox locally patched with 
this change worked again,
  So unless there are objections will push then latest next WE, though happy to 
have people give green light before :)

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr
Cc: bcooksley, awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26671: Cleanup and add 22px media repeat icons

[Alexander Stippich]

astippich added a comment.


  here you go:
  
  F7883937: media-repet.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26671

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26671: Cleanup and add 22px media repeat icons

[Alexander Stippich]

astippich updated this revision to Diff 73592.
astippich added a comment.


  - remove color

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26671?vs=73567=73592

BRANCH
  repeatIcons

REVISION DETAIL
  https://phabricator.kde.org/D26671

AFFECTED FILES
  icons-dark/actions/22/media-playlist-repeat.svg
  icons-dark/actions/22/media-repeat-all.svg
  icons-dark/actions/22/media-repeat-none.svg
  icons/actions/22/media-playlist-repeat.svg
  icons/actions/22/media-repeat-all.svg
  icons/actions/22/media-repeat-none.svg

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26671: Cleanup and add 22px media repeat icons

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Making monochrome breeze icons is tricky; you'll want to read 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips if you 
haven't already.
  
  Also, screenshots using the Cuttlefish app are appreciated. :)

INLINE COMMENTS

> media-playlist-repeat.svg:7
> + 
> + 
>  

Remove `color="#eff0f1"`

> media-playlist-repeat.svg:7
> + 
> + 
>  

remove `color="#232629"`

> media-repeat-none.svg:11
> +  fill="currentColor"/>
> +  color="#da4453" fill="currentColor"/>
> +

remove `color="#da4453"`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26671

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26677: Port away from KLineEdit and KComboBox to Q equivalent

[Gilbert Assaf]

gassaf added a reviewer: kde-frameworks-devel.

REPOSITORY
  R305 KNotifyConfig

REVISION DETAIL
  https://phabricator.kde.org/D26677

To: gassaf, kde-frameworks-devel
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26677: Port away from KLineEdit and KComboBox to Q equivalent

[Gilbert Assaf]

gassaf added a task: T12168: KNotifyConfig: Port away from KLineEdit and 
KComboBox to Q equivalent.

REPOSITORY
  R305 KNotifyConfig

REVISION DETAIL
  https://phabricator.kde.org/D26677

To: gassaf
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26677: Port away from KLineEdit and KComboBox to Q equivalent

[Gilbert Assaf]

gassaf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gassaf requested review of this revision.

REVISION SUMMARY
  Port away from KLineEdit and KComboBox to Q equivalent

REPOSITORY
  R305 KNotifyConfig

BRANCH
  port_to_q_ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26677

AFFECTED FILES
  src/knotifyconfigactionswidgetbase.ui

To: gassaf
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26671: Cleanup and add 22px media repeat icons

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: VDG, ngraham, ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  This patch does the following things:
  -small cleanup to the existing 22px media-playlist-repeat icon
  -adds a media-repeat-all symlink to media-playlist-repeat, which
  exists for 32px icons
  -adds a new 22px media-repeat-none icon
  
  This makes the toggle repeat button in Elisa look sharp

REPOSITORY
  R266 Breeze Icons

BRANCH
  repeatIcons

REVISION DETAIL
  https://phabricator.kde.org/D26671

AFFECTED FILES
  icons-dark/actions/22/media-playlist-repeat.svg
  icons-dark/actions/22/media-repeat-all.svg
  icons-dark/actions/22/media-repeat-none.svg
  icons/actions/22/media-playlist-repeat.svg
  icons/actions/22/media-repeat-all.svg
  icons/actions/22/media-repeat-none.svg

To: astippich, #vdg, ngraham, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26670: ki18n_wrap_ui: error when file doesn't exist

[David Redondo]

davidre edited the summary of this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26670

To: davidre, #framework_syntax_highlighting, #localization, #build_system
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26670: ki18n_wrap_ui: error when file doesn't exist

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> KF5I18nMacros.cmake.in:52
> foreach (_current_FILE ${ARGN})
> -
> +  if(NOT EXISTS ${CMAKE_CURRENT_LIST_DIR}/${_current_FILE})
> + message(SEND_ERROR

This assumes a relative path given. It might make sense to also deal with 
absolute path, and only append CMAKE_CURRENT_LIST_DIR if not absolute, then 
check for existance?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26670

To: davidre, #framework_syntax_highlighting, #localization, #build_system
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26670: ki18n_wrap_ui: error when file doesn't exist

[David Redondo]

davidre edited the test plan for this revision.
davidre added reviewers: Framework: Syntax Highlighting, Localization, Build 
System.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26670

To: davidre, #framework_syntax_highlighting, #localization, #build_system
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26670: ki18n_wrap_ui: error when file doesn't exist

[David Redondo]

davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Makes it clear why the current build is failing instead of the develoepr 
wasting
  time investigating other causes. The message is styled similiar to the CMake
  error when it can't find a source file.

REPOSITORY
  R249 KI18n

BRANCH
  error (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26670

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1114
> +
> d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon()));
>  connect(d->m_sizeDetailsButton, ::clicked, this, 
> ::slotSizeDetails);
>  sizelay->addWidget(d->m_sizeDetailsButton, 0);

We don't need to reparse desktop file on every click just make it

  connect(d->m_sizeDetailsButton, ::clicked, this, [this, 
service]() {
  KRun::runApplication(*service, { properties->url() }, 
properties->window());
  });

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26650: Use KService to look for Filelight

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1452-1457
>  void KFilePropsPlugin::slotSizeDetails()
>  {
>  // Open the current folder in filelight
> -KRun::run((QStandardPaths::findExecutable(QStringLiteral("filelight"))), 
> { properties->url() }, properties->window(), QStringLiteral("Filelight"), 
> QStringLiteral("filelight"));
> +KService::Ptr service = 
> KService::serviceByDesktopName(QStringLiteral("org.kde.filelight"));
> +KRun::runApplication(*service, { properties->url() }, 
> properties->window());
>  }

Remove

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

[Nathaniel Graham]

ngraham added a subscriber: elvisangelaccio.
ngraham added a comment.


  #frameworks  folks, #dolphin 
 folks, and/or @elvisangelaccio, how 
is this looking? It would be really nice to be able to use the same backend 
code for the Places panel in Dolphin and the file dialogs again. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

To: broulik, #frameworks, #vdg, #dolphin
Cc: elvisangelaccio, meven, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26650: Use KService to look for Filelight

[Shubham]

shubham marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26650: Use KService to look for Filelight

[Nathaniel Graham]

ngraham added a comment.


  Please mark the inline comments that are resolved as "Done"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73557.
tcanabrava added a comment.


  - Add missing copyright holders

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=73510=73557

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11a.h.ref
  autotests/kconfig_compiler/test12.h.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test9.h.ref
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_translation_kde.h.ref
  autotests/kconfig_compiler/test_translation_kde_domain.h.ref
  autotests/kconfig_compiler/test_translation_qt.h.ref
  autotests/kconfigtest.h
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26650: Use KService to look for Filelight

[Shubham]

shubham marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26650: Use KService to look for Filelight

[Shubham]

shubham updated this revision to Diff 73556.
shubham added a comment.


  Use desciptive variable name

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26650?vs=73535=73556

BRANCH
  filelight

REVISION DETAIL
  https://phabricator.kde.org/D26650

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26650: Use KService to look for Filelight

[Nathaniel Graham]

ngraham added a comment.


  Much better, thanks. Remember to mark inline comments as "Done" once you've 
addressed them.

INLINE COMMENTS

> kpropertiesdialog.cpp:1109
>  
> -if 
> (!QStandardPaths::findExecutable(QStringLiteral("filelight")).isEmpty()) {
> +KService::Ptr serv = 
> KService::serviceByDesktopName(QStringLiteral("org.kde.filelight"));
> +

prefer descriptive variable names; "service" is better than "serv"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:945f1849cc24: [KMessageBox] Only allow selecting text in 
the dialog box using the mouse (authored by ngraham).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26649?vs=73478=73555

REVISION DETAIL
  https://phabricator.kde.org/D26649

AFFECTED FILES
  src/kmessagebox.cpp

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Nathaniel Graham]

ngraham added a comment.


  In D26649#593825 , @broulik wrote:
  
  > So you can't tab around to end up focusing the text field?
  
  
  As Noah said, you already can't. This doesn't change anything about what you 
can focus with the tab key.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

[Nathaniel Graham]

ngraham added a comment.


  I don't see the separator lines in plasma applets. Is that intentional?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/47/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 14 Jan 2020 16:26:55 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 15 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testWindowmanagementFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV6Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 53 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/53/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 14 Jan 2020 16:26:55 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.67.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27283/32231)53%
(11008/20683)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12522/12597)50%
(6593/13085)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6332/7469)65%
(1837/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7975/9509)64%
(2401/3771)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D26648: Improved quality of JPEG thumbnails

[William Tradewell]

chroniceel edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26648: Improved quality of JPEG thumbnails

[William Tradewell]

chroniceel added a comment.


  It's not overly scientific, but with this little fix, it can gen ~10 
thumbnails a second on my system (1.6 Ghz pentium, ~10MP). This seems on par 
with png files of a similar size. As far as I can tell, there is not a super 
huge performance decrease. Please note, I use a potato.

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26248: API dox: add since for KDE_INSTALL_KNSRCDIR, note backward-compatible variant

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:bd2e67ea61b5: API dox: add since for 
KDE_INSTALL_KNSRCDIR, note backward-compatible variant (authored by kossebau).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26248?vs=72269=73546

REVISION DETAIL
  https://phabricator.kde.org/D26248

AFFECTED FILES
  README.md

To: kossebau, leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

mart updated this revision to Diff 73545.
mart added a comment.


  - add missing property

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73543=73545

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 271 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/271/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 14 Jan 2020 15:21:47 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

mart updated this revision to Diff 73543.
mart added a comment.


  - smoother transition

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26664?vs=73525=73543

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26648: Improved quality of JPEG thumbnails

[Stefan Brüns]

bruns added a comment.


  In D26648#593895 , @volkov wrote:
  
  > But as I mentioned there, it doesn't really influence on the decoding 
speed, and it was only needed to preserve the old behavior as much as possible.
  
  
  Can we have some quick benchmarks of e.g. generating Thumbnails for typical 
24MP smartphone images? Only having to decode DC and scale down should be 
significantly faster CPU wise, and probably also saves IO.

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 279 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/279/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 14 Jan 2020 15:21:47 +
 Build duration:
9 min 9 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.67.0.xmllogs/KF5KIO/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34764/62024)40%
(17674/43786)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9685/10144)47%
(4516/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8698/14617)51%
(4524/8859)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4681/8323)43%
(2068/4802)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(687/1260)40%
(396/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D26663: Fix doc block in KProtocolInfoFactory

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:be69b302f1d7: Fix doc block in KProtocolInfoFactory 
(authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26663?vs=73522=73538

REVISION DETAIL
  https://phabricator.kde.org/D26663

AFFECTED FILES
  src/core/kprotocolinfofactory_p.h

To: meven, dfaure, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

[Shubham]

shubham updated this revision to Diff 73535.
shubham added a comment.


  Use KService to get the application's icon

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26650?vs=73483=73535

BRANCH
  filelight

REVISION DETAIL
  https://phabricator.kde.org/D26650

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 96 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/96/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 14 Jan 2020 14:42:54 +
 Build duration:
5 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.67.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6907/9089)43%
(10770/24792)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2896/2989)49%
(6187/12712)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(679/798)42%
(954/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(422/827)47%
(988/2121)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 73530.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26659?vs=73529=73530

BRANCH
  l-qregexp-deprecate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26659

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> broulik wrote in kcoredirlister.h:595
> This class is exported, you cannot change this existing method and you also 
> cannot add a new `virtual`, see 
> https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

Thanks, fixed. Luckily it's a convenience function of sorts and replacing the 
one instance it was used in KCoreDirLister was simple).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 91 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/91/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 14 Jan 2020 14:42:52 +
 Build duration:
2 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 73529.
ahmadsamir removed a subscriber: broulik.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26659?vs=73527=73529

BRANCH
  l-qregexp-deprecate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26659

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, broulik

D26122: Add utility text function KShell::tildeCollapse

[Méven Car]

meven added a comment.


  Now we have a small list of potential users of this :
  
  plasma-desktop/kcms/kfontinst/lib/Misc.cpp:391
  plasma-desktop/kcms/baloo/filteredfoldermodel.cpp:50
  plasma-workspace/runners/baloo/baloosearchrunner.cpp:176
  plasma-workspace/libnotificationmanager/job_p.cpp:120
  solid/src/solid/devices/backends/fstab/fstabdevice.cpp:61

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26122

To: meven, #frameworks, broulik, ngraham, ervin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26122: Add utility text function KShell::tildeCollapse

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:94e6927d2f8c: Add utility text function 
KShell::tildeCollapse (authored by meven).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26122?vs=73386=73528

REVISION DETAIL
  https://phabricator.kde.org/D26122

AFFECTED FILES
  autotests/kshelltest.cpp
  src/lib/util/kshell.cpp
  src/lib/util/kshell.h

To: meven, #frameworks, broulik, ngraham, ervin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 73527.
ahmadsamir added a comment.


  Can't change doNameFilter due to BIC

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26659?vs=73515=73527

BRANCH
  l-qregexp-deprecate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26659

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: ahmadsamir, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

[Marco Martin]

mart retitled this revision from "same behavior for scrollbar as the desktop 
style" to "Same behavior for scrollbar as the desktop style".
mart edited the test plan for this revision.
mart added a reviewer: ngraham.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: same behavior for scrollbar as the desktop style

[Marco Martin]

mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  bigger scrollbar and add a small line separator
  to look consistent with D26655  and 
D26654 
  
  same behavior for mobile scrollbar

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ScrollBar.qml
  src/desktoptheme/breeze/widgets/scrollbar.svg

To: mart, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Noah Davis]

ndavis added a comment.


  In D26649#593825 , @broulik wrote:
  
  > So you can't tab around to end up focusing the text field?
  
  
  You currently aren't able to, but after you click with the mouse on the text, 
you can use the arrow keys to move an I beam around in the text.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[Méven Car]

meven added a comment.


  I am thinking about adding some api to check status of nfs, sftp or smb 
mounts by checking their hostname network reachability, to complement isSlow(), 
and perhaps then running a stat of the mount with a timeout.
  This would be kept in a cache with a short duration.
  We still need this because we will lack icons for network files and folders 
as long as we skip mimetype checking solely on fs type.
  And this would allow to make this check default and remove 
m_bSkipMimeTypeFromContent at this point.

INLINE COMMENTS

> dfaure wrote in kfileitem.cpp:787
> OK, but I still read "can only mean" like a possibly incorrect assumption.
> 
> I suggest s/can only mean/for instance/

I meant this and this what KMountPoint does, better be precise here.

> dfaure wrote in kfileitem.cpp:1246
> Did you mean || ?
> 
> Otherwise this changes the behaviour also on fast local paths (when 
> SkipMimeTypeFromContent is set).
> 
> Then again, D19887  (which introduced 
> this if) was apparently about network mounts.

I meant to change the behavior : this isSlow check would be triggered only when 
m_bSkipMimeTypeFromContent is set  or I will create regression in Dolphin for 
instance where icons for folders in network mount would disappear.

> dfaure wrote in kmountpoint.h:66
> I don't really like the name, it's non-obvious until reading the 
> documentation.
> Maybe it should be findByPath(path, KMountPoint::DontResolveSymlinks) ?
> (with a 2-args findByPath overload and a KF6 TODO to merge the two)

Nice suggestion !

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[Méven Car]

meven updated this revision to Diff 73524.
meven marked 4 inline comments as done.
meven added a comment.


  Address review: Make KMountPoint::Ptr KMountPoint::List::findByPath 
non-blocking, checking recursively intermediate symlinks

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26407?vs=73282=73524

BRANCH
  arcpatch-D26407

REVISION DETAIL
  https://phabricator.kde.org/D26407

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25856: Show IOSlaves that return local files when in local file mode

[Fabian Vogt]

fvogt added a comment.


  In D25856#594088 , @meven wrote:
  
  > In D25856#575125 , @fvogt wrote:
  >
  > > In D25856#575083 , @ngraham 
wrote:
  > >
  > > > In D25856#575044 , @fvogt 
wrote:
  > > >
  > > > > IMO this should be done in KIO, so that all users benefit.
  > > >
  > > >
  > > > How would you do it in KIO?
  > >
  > >
  > > Add code to KFileDialog to allow specific protocols/slaves if the `file` 
scheme is supported.
  >
  >
  > I would guess something in the slave interface sort of like 
`KDE-KIO-Protocols` in json/.protocol files expect it would be about supported 
output scheme instead of input/handled.
  >  Something like `KDE-KIO-Output-Protocols`
  >  Then there would be an equivalent to `KProtocolInfoFactory::findProtocol` 
to get those, like `KProtocolInfoFactory::findOutputProtocol`
  >  Basically ioslaves `desktop` `file` `recentlyused` `trash` and `tags` 
would have `"file"` set in there.
  
  
  IMO an overgeneralization: I can't come up with any use for that new key 
other than `file`.
  There's the `mostLocalUrl()` method already, so maybe it should just be 
indicated that `mostLocalUrl()` returns `file://`?
  
  > And also `recentdocuments` `timeline` for those who use those.
  
  AFAIK those can also have non-local URLs inside, so it's not possible to 
guarantee that only locally-reachable files are shown that way.
  
  > What do you think ?
  
  It seems like there's no easy way to fully implement this :-/

REPOSITORY
  R229 KDialog

REVISION DETAIL
  https://phabricator.kde.org/D25856

To: ngraham, #frameworks, #dolphin
Cc: fvogt, broulik, meven

D25856: Show IOSlaves that return local files when in local file mode

[Méven Car]

meven added a comment.


  In D25856#575125 , @fvogt wrote:
  
  > In D25856#575083 , @ngraham 
wrote:
  >
  > > In D25856#575044 , @fvogt 
wrote:
  > >
  > > > IMO this should be done in KIO, so that all users benefit.
  > >
  > >
  > > How would you do it in KIO?
  >
  >
  > Add code to KFileDialog to allow specific protocols/slaves if the `file` 
scheme is supported.
  
  
  I would guess something in the slave interface sort of like 
`KDE-KIO-Protocols` in json/.protocol files expect it would be about supported 
output scheme instead of input/handled.
  Something like `KDE-KIO-Output-Protocols`
  Then there would be an equivalent to `KProtocolInfoFactory::findProtocol` to 
get those, like `KProtocolInfoFactory::findOutputProtocol`
  Basically ioslaves `desktop` `file` `recentlyused` `trash` and `tags` would 
have `"file"` set in there. And also `recentdocuments` `timeline` for those who 
use those.
  
  What do you think ?

REPOSITORY
  R229 KDialog

REVISION DETAIL
  https://phabricator.kde.org/D25856

To: ngraham, #frameworks, #dolphin
Cc: fvogt, broulik, meven

D26663: Fix doc block in KProtocolInfoFactory

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26663

To: meven, dfaure, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26663: Fix doc block in KProtocolInfoFactory

[Méven Car]

meven created this revision.
meven added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Prevented documentation to appear.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26663

AFFECTED FILES
  src/core/kprotocolinfofactory_p.h

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26122: Add utility text function KShell::tildeCollapse

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  arcpatch-D26122

REVISION DETAIL
  https://phabricator.kde.org/D26122

To: meven, #frameworks, broulik, ngraham, ervin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 73518.
kossebau added a comment.


  fix comment locale -> filesystem encoding

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26661?vs=73517=73518

BRANCH
  hackfsencoding

REVISION DETAIL
  https://phabricator.kde.org/D26661

AFFECTED FILES
  src/kapidox/preprocessing.py

To: kossebau, bshah, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org

[Friedrich W. H. Kossebau]

kossebau added a comment.


  D22836  was tried before to fix this, but 
later it was found this still did not work on api.kde.org. At that time I had 
added some local patches on api.kde.org itself, but not getting further at one 
point forgot about things sadly.
  
  That remaining patch then resulted in blocking any git pull updates as we 
found now (cmp, D25632#593787 )
  
  Given Python2 is EOL and to keep api.kde.org working, IMHO this hardcoding 
should be fine. I have no other idea how to fix this, and putting this hack 
upstream allows to keep api.kde.org clean from local patches.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26661

To: kossebau, bshah, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D26661: Hardcode utf-8 as filesystem encoding with Python2 to help api.kde.org

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: bshah, ochurlaud.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R264 KApiDox

BRANCH
  hackfsencoding

REVISION DETAIL
  https://phabricator.kde.org/D26661

AFFECTED FILES
  src/kapidox/preprocessing.py

To: kossebau, bshah, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kcoredirlister.h:595
>   */
> -virtual bool doNameFilter(const QString , const QList 
> ) const;
> +virtual bool doNameFilter(const QString , const 
> QVector ) const;
>  

This class is exported, you cannot change this existing method and you also 
cannot add a new `virtual`, see 
https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26122: Add utility text function KShell::tildeCollapse

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.


  Looks good to me, just explain what it does on the commit message.

REPOSITORY
  R244 KCoreAddons

BRANCH
  arcpatch-D26122

REVISION DETAIL
  https://phabricator.kde.org/D26122

To: meven, #frameworks, broulik, ngraham, ervin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  doNameFilter() was the only protected function that took a QRegExp param.,
  but I couldn't find any users of it in KDE. Also changed lstFilters from
  from QList to QVector.
  
  Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern(),
  and QRegExp::Wildcard with QRegularExpression::wildcardToRegularExpression().
  
  Note that setNameFilter() has some users, it took a QString param.,
  which is used as the pattern for a QRegularExpression, but there are
  differences between valid QRegExp and QRegularExpression patterns.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-qregexp-deprecate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26659

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister.h
  src/core/kcoredirlister_p.h

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26248: API dox: add since for KDE_INSTALL_KNSRCDIR, note backward-compatible variant

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Sorry it took so long to tick this box, but go for it

REPOSITORY
  R304 KNewStuff

BRANCH
  moredetailsaboutKDE_INSTALL_KNSRCDIR

REVISION DETAIL
  https://phabricator.kde.org/D26248

To: kossebau, leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26652: Unbreak module imports for Python2

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 73513.
kossebau added a comment.


  Brown paper bag for me: if one changes code, they should also see to trigger
  that code, in this case passing the --depdiagram-dot-dir arg to
  kapidox_generate...
  
  I can confirm now in my testing on the server that things fail without the
  patch, and work with this simple change Ben hinted to :)

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26652?vs=73488=73513

BRANCH
  fixpython2support

REVISION DETAIL
  https://phabricator.kde.org/D26652

AFFECTED FILES
  src/kapidox/depdiagram/frameworkdb.py

To: kossebau, ochurlaud, cordlandwehr
Cc: bcooksley, awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava added a comment.


  Took the time to nuke the SignalArguments and use Param instead, easier than 
I initially tougth.

INLINE COMMENTS

> dfaure wrote in kconfigcompiler_test.cpp:180
> I meant  QVERIFY2(diffFile.open(...), ...).
> No need to make a separate call to isOpen().

ups :)

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 73510.
tcanabrava marked 10 inline comments as done.
tcanabrava added a comment.


  - Simplify List creation
  - Fail with the diff file name
  - Simplify Code
  - Fix Typo
  - Remove `SignalArgument` for `Param`
  - Nitpicks and Include fixes

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=73345=73510

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11a.h.ref
  autotests/kconfig_compiler/test12.h.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test9.h.ref
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_translation_kde.h.ref
  autotests/kconfig_compiler/test_translation_kde_domain.h.ref
  autotests/kconfig_compiler/test_translation_qt.h.ref
  autotests/kconfigtest.h
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26652: Unbreak module imports for Python2

[Friedrich W. H. Kossebau]

kossebau added a comment.


  For now, given @bcooksley's comment going to try some simple change to 'from 
kapidox.depdiagram import gvutils', this is a pattern found elsewhere in the 
old code. Will do a local patch to the checkout on the server and see if this 
has any effect on next cron job run. So far that also worked for all the 3 
situations I tested (local python3 & python2, python2 on server test env).
  
  All that while awaiting Python gurus to bring in the light :)

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr
Cc: bcooksley, awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26657: Add perlSplit() overload taking a QRegularExpression and deprecate the QRegExp one

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, mpyne, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This adds a perlSplit() overload that takes a QRegularExpression
  parameter, and also deprecates the version that took a QRegExp param.
  
  For both functions, return early if the string to be split is empty.

TEST PLAN
  make && ctest

REPOSITORY
  R244 KCoreAddons

BRANCH
  l-perlsplit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26657

AFFECTED FILES
  autotests/kstringhandlertest.cpp
  src/lib/CMakeLists.txt
  src/lib/text/kstringhandler.cpp
  src/lib/text/kstringhandler.h

To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25811: cmake: Fix `CMAKE_POLICY_*_CMP` regex and add special args to `get_cmake_property`

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:bb06250bd2a5: cmake: Fix `CMAKE_POLICY_*_CMPN` 
regex and add special args to… (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25811?vs=71088=73506

REVISION DETAIL
  https://phabricator.kde.org/D25811

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/generators/generate-cmake-syntax.py
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26652: Unbreak module imports for Python2

[Friedrich W. H. Kossebau]

kossebau added a comment.


  To add to my confusion, running the unpatched version works with my local 
2.7.17 python interpreter (checked with `print (sys.version)`) and worse, 
running things manually on api.kde.org in some test subdir also works with its 
2.7.15...
  
  Now why does it fail in the cronjob...

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr
Cc: bcooksley, awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26648: Improved quality of JPEG thumbnails

[Alexander Volkov]

volkov added a comment.


  `imageReader.setQuality(0);` was added in 
https://phabricator.kde.org/R320:c249f8547f2d1913e0570d78a0240c5f8865c336 when 
I ported `JpegCreator` to `QImageReader`.
  But as I mentioned there, it doesn't really influence on the decoding speed, 
and it was only needed to preserve the old behavior as much as possible.
  This change looks good to me, +1.

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26648: Improved quality of JPEG thumbnails

[Christoph Feck]

cfeck added a comment.


  @meven, this isn't about save quality, but load quality.

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26014: remove compiler information from bug report dialog

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:3014b0278c50: remove compiler information from bug report 
dialog (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26014?vs=71587=73498#toc

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26014?vs=71587=73498

REVISION DETAIL
  https://phabricator.kde.org/D26014

AFFECTED FILES
  src/config-xmlgui.h.cmake
  src/kbugreport.cpp
  src/kbugreport.h

To: sitter, dfaure, ngraham, davidedmundson
Cc: kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D26019: remove ability to report bugs against arbitrary stuff from a static list

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:59954316cc95: remove ability to report bugs against 
arbitrary stuff from a static list (authored by sitter).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26019?vs=71610=73499

REVISION DETAIL
  https://phabricator.kde.org/D26019

AFFECTED FILES
  src/kbugreport.cpp
  src/kbugreport.h
  src/kdepackages.h

To: sitter, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 270 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/270/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 14 Jan 2020 09:43:53 +
 Build duration:
9 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26519: Show button respecting what is declared by KCModule

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:f52314e6cf19: Show button respecting what is declared by 
KCModule (authored by bport).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26519?vs=73045=73494

REVISION DETAIL
  https://phabricator.kde.org/D26519

AFFECTED FILES
  src/kcmultidialog.cpp

To: bport, ervin, meven, crossi, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kglobalaccel » kf5-qt5 WindowsMSVCQt5.13 - Build # 36 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kglobalaccel/job/kf5-qt5%20WindowsMSVCQt5.13/36/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 14 Jan 2020 09:36:53 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26122: Add utility text function KShell::tildeCollapse

[Méven Car]

meven added a comment.


  @apol is it ok with you ?

REPOSITORY
  R244 KCoreAddons

BRANCH
  arcpatch-D26122

REVISION DETAIL
  https://phabricator.kde.org/D26122

To: meven, #frameworks, broulik, ngraham, ervin
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26517: Fix KCMModule::setButtons documentation, if Apply is activated we also want to show a Reset button

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:4dc3f18f1443: Fix KCMModule::setButtons documentation, if 
Apply is activated we also want to… (authored by bport).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26517?vs=73040=73492

REVISION DETAIL
  https://phabricator.kde.org/D26517

AFFECTED FILES
  src/kcmodule.h

To: bport, ervin, meven, crossi, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 269 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/269/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 14 Jan 2020 09:33:54 +
 Build duration:
9 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:76470c116640: Allow to handle apps with Terminal=True in 
their desktop file, handle their… (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26557?vs=73490=73491

REVISION DETAIL
  https://phabricator.kde.org/D26557

AFFECTED FILES
  src/core/desktopexecparser.cpp
  src/widgets/krun.cpp

To: meven, ervin, ngraham, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

[Méven Car]

meven added a comment.


  > OK, scheme-handler replaces most of these uses. I think we should just 
deprecate "helper protocols" (which either hardcode an exec line or abuse 
mimetypes) and move it all to the scheme-handler mechanism.
  
  I completely agree, we have a standardized way to handle scheme better 
implement the standard and improve compatibility.
  It means KService will gain more responsibility over KProtocolInfo.
  Could be a KF6 item.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D26557

REVISION DETAIL
  https://phabricator.kde.org/D26557

To: meven, ervin, ngraham, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D26557

REVISION DETAIL
  https://phabricator.kde.org/D26557

To: meven, ervin, ngraham, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26557: Allow to handle apps with Terminal=True in their desktop file, handle their associated mimetype properly

[Méven Car]

meven updated this revision to Diff 73490.
meven added a comment.


  Remove uncorrect comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26557?vs=73449=73490

BRANCH
  arcpatch-D26557

REVISION DETAIL
  https://phabricator.kde.org/D26557

AFFECTED FILES
  src/core/desktopexecparser.cpp
  src/widgets/krun.cpp

To: meven, ervin, ngraham, #frameworks, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26617: KOpenWithDialog: Allow to return a newly created KService created associated to a mimetype

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:56732facdb3b: KOpenWithDialog: Allow to return a newly 
created KService created associated to… (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26617?vs=73383=73489

REVISION DETAIL
  https://phabricator.kde.org/D26617

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: meven, ervin, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: KUrlPixmapProvider & kdelibs4support

[Friedrich W. H. Kossebau]

Am Dienstag, 14. Januar 2020, 10:30:02 CET schrieb Ben Cooksley:
> Hi all,
> 
> Recently there have been some changes to deprecate parts of
> KUrlPixmapProvider - changes that appear to have landed in the last 24
> hours.
> 
> Unfortunately this has caused breakage in kdelibs4support as shown by
> the current status of several Dependency Builds on all platforms.
> 
> See
> https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Buil
> d%20Calligra%20kf5-qt5%20SUSEQt5.12/lastFailedBuild/console for one instance
> of this failure.
> 
> Could someone please investigate this?

That had been handled already yesterday CET morning:
https://phabricator.kde.org/R241:bfcc2363174804160e7da06b47128b7bad10cf09

So all that is needed should be a new build (doing now).

Cheers
Friedrich

KUrlPixmapProvider & kdelibs4support

[Ben Cooksley]

Hi all,

Recently there have been some changes to deprecate parts of
KUrlPixmapProvider - changes that appear to have landed in the last 24
hours.

Unfortunately this has caused breakage in kdelibs4support as shown by
the current status of several Dependency Builds on all platforms.

See 
https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Calligra%20kf5-qt5%20SUSEQt5.12/lastFailedBuild/console
for one instance of this failure.

Could someone please investigate this?

As an additional note, we're currently looking at preparing for some
major breaking changes to Windows CI, so it would be appreciated if we
could please avoid landing any further changes like this (and be
careful with landing changes in Frameworks in general) for the next
few weeks.

Thanks,
Ben

D26652: Unbreak module imports for Python2

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> bcooksley wrote in frameworkdb.py:39
> This probably needs to be `import gvutils from kapidox.depdiagram` otherwise 
> any calling code will need to be `kapidox.depdiagram.gvutils.` 
> instead of just `fvutils.` (unless Python3 allows something special 
> i'm not aware of)

As said no Python developer myself, but the code using the import is like this 
a few times below:

  for node_handle in gvutils.get_node_list(src_handle):
  node = gvutils.Node(node_handle)

so something there seems to work? Also this is the current import code added in 
D25632  to have it work with Python3, so my 
expectation would have rather been this is correct?

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr
Cc: bcooksley, awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26650: Use KService to look for Filelight

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> shubham wrote in kpropertiesdialog.cpp:1113
> I tried removing it, but I couldn't see the icon on the button then.

Does this not work?

  d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(service->icon());

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26648: Improved quality of JPEG thumbnails

[Méven Car]

meven added subscribers: volkov, meven.
meven added a comment.


  Nice first patch @chroniceel !
  
  
https://github.com/openwebos/qt/blob/master/src/gui/image/qimagereader.cpp#L1202
 is the only use of quality in ImageReader, its default is -1 so it depends on 
its https://doc.qt.io/qt-5/qimageiohandler.html to choose the default behavior 
and its documentation is not more precise either.
  We probably should pick ourselves a value so that if Qt changes its default 
we are not affected and to set the performance level ourselves. 80 or 90 seems 
like reasonable values as mentioned by @ngraham before.
  
  This line was added in c249f8547f2d1913e0570d78a0240c5f8865c336 

  So @volkov maybe you have some input ?
  
  You can add `FIXED-IN: 20.04` to the commit comment, following our commit 
policy https://community.kde.org/Policies/Commit_Policy to automatically close 
the bug when it lands.

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: meven, volkov, cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, 
Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26650: Use KService to look for Filelight

[Shubham]

shubham added inline comments.

INLINE COMMENTS

> broulik wrote in kpropertiesdialog.cpp:1113
> You can also use the icon from the service

I tried removing it, but I couldn't see the icon on the button then.

> anthonyfieroni wrote in kpropertiesdialog.cpp:1455
> service can be nullptr, add a check

This slot is called from a check at line , so not required

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26652: Unbreak module imports for Python2

[Ben Cooksley]

bcooksley added inline comments.

INLINE COMMENTS

> frameworkdb.py:39
> +else:
> +import kapidox.depdiagram.gvutils
> +from kapidox.depdiagram.framework import Framework

This probably needs to be `import gvutils from kapidox.depdiagram` otherwise 
any calling code will need to be `kapidox.depdiagram.gvutils.` 
instead of just `fvutils.` (unless Python3 allows something special 
i'm not aware of)

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr
Cc: bcooksley, awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, 
gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26652: Unbreak module imports for Python2

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Because the very user api.kde.org right now in production still uses python2 
sadly. And replacing that server with something modern is sadly not a few-hours 
job, still waiting for someone to spend the weeks on getting a substitution 
done.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr
Cc: awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26648: Improved quality of JPEG thumbnails

[Christoph Feck]

cfeck added a comment.


  Did you time a performance difference? I think the idea was to get the 
downscaled result as fast as possible, by using integer IDCT instead of float 
IDCT, and by using only the DC coefficient instead of performing the IDCT at 
all for scale factors <= 1/8.

REVISION DETAIL
  https://phabricator.kde.org/D26648

To: chroniceel, broulik, #frameworks, #vdg
Cc: cfeck, bruns, ngraham, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D26652: Unbreak module imports for Python2

[A. Wilcox]

awilcox added a comment.


  Why should Python 2 continue to be supported, after its EOL on 2020-01-01?
  
  What cases would a user be running the latest KDE release, but still have a 
Python 2 interpreter present as their primary/only Python interpreter?

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr
Cc: awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26649: [KMessageBox] Only allow selecting text in the dialog box using the mouse

[Kai Uwe Broulik]

broulik added a comment.


  So you can't tab around to end up focusing the text field?

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-more-keyboard-selectability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26649

To: ngraham, dfaure, #frameworks, #vdg, ndavis
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1455
>  // Open the current folder in filelight
> -KRun::run((QStandardPaths::findExecutable(QStringLiteral("filelight"))), 
> { properties->url() }, properties->window(), QStringLiteral("Filelight"), 
> QStringLiteral("filelight"));
> +KService::Ptr serv = 
> KService::serviceByDesktopName(QStringLiteral("org.kde.filelight"));
> +KRun::runApplication(*serv, { properties->url() }, properties->window());

service can be nullptr, add a check

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25632: Fix module imports with Python3

[Friedrich W. H. Kossebau]

kossebau added a comment.


  D26652  now up as proposal to fix this

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D25632

To: cordlandwehr, ochurlaud
Cc: kossebau, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D26652: Unbreak module imports for Python2

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: ochurlaud, cordlandwehr.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
kossebau requested review of this revision.

TEST PLAN
  Using kapidox_generate with python3 & python2 works

REPOSITORY
  R264 KApiDox

BRANCH
  fixpython2support

REVISION DETAIL
  https://phabricator.kde.org/D26652

AFFECTED FILES
  src/kapidox/depdiagram/__init__.py
  src/kapidox/depdiagram/frameworkdb.py

To: kossebau, ochurlaud, cordlandwehr
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D26650: Use KService to look for Filelight

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1113
>  d->m_sizeDetailsButton = new QPushButton(i18n("Explore in 
> Filelight"), d->m_frame);
>  
> d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(QStringLiteral("filelight")));
>  connect(d->m_sizeDetailsButton, ::clicked, this, 
> ::slotSizeDetails);

You can also use the icon from the service

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns